[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: disable FBC if its pipe is fused off

2022-09-26 Thread Patchwork
== Series Details == Series: drm/i915: disable FBC if its pipe is fused off URL : https://patchwork.freedesktop.org/series/109044/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12182_full -> Patchwork_109044v1_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for Add HWMON support

2022-09-26 Thread Patchwork
== Series Details == Series: Add HWMON support URL : https://patchwork.freedesktop.org/series/109069/ State : success == Summary == CI Bug Log - changes from CI_DRM_12185 -> Patchwork_109069v1 Summary --- **SUCCESS** No

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: enable local stolen memory (rev3)

2022-09-26 Thread Patchwork
== Series Details == Series: drm/i915/mtl: enable local stolen memory (rev3) URL : https://patchwork.freedesktop.org/series/109066/ State : success == Summary == CI Bug Log - changes from CI_DRM_12185 -> Patchwork_109066v3 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Start cleaning up the DPLL ID mess (rev2)

2022-09-26 Thread Patchwork
== Series Details == Series: drm/i915: Start cleaning up the DPLL ID mess (rev2) URL : https://patchwork.freedesktop.org/series/108827/ State : success == Summary == CI Bug Log - changes from CI_DRM_12185 -> Patchwork_108827v2 Summary

Re: [Intel-gfx] [RFC v4 06/14] drm/i915/vm_bind: Handle persistent vmas

2022-09-26 Thread Zeng, Oak
Regards, Oak > -Original Message- > From: Intel-gfx On Behalf Of > Niranjana > Vishwanathapura > Sent: September 21, 2022 3:10 AM > To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Cc: Zanoni, Paulo R ; Hellstrom, Thomas > ; Auld, Matthew ; Vetter, > Daniel ;

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: enable PS64 support for DG2

2022-09-26 Thread Patchwork
== Series Details == Series: drm/i915: enable PS64 support for DG2 URL : https://patchwork.freedesktop.org/series/109059/ State : success == Summary == CI Bug Log - changes from CI_DRM_12185 -> Patchwork_109059v1 Summary ---

[Intel-gfx] [PATCH v4.1] drm/i915/mtl: Define engine context layouts

2022-09-26 Thread Radhakrishna Sripada
From: Matt Roper The part of the media and blitter engine contexts that we care about for setting up an initial state on MTL are nearly similar to DG2 (and PVC). The difference being PRT_BB_STATE being replaced with NOP. For render/compute engines, the part of the context images are nearly the

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-09-26 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/109063/ State : warning == Summary == Error: dim checkpatch failed 1ae330098759 overflow: Allow

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-09-26 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/109063/ State : success == Summary == CI Bug Log - changes from CI_DRM_12185 -> Patchwork_109063v1

[Intel-gfx] [PATCH v2 0/4] drm/i915: Start cleaning up the DPLL ID mess

2022-09-26 Thread Ville Syrjala
From: Ville Syrjälä Start to clean up the mess around DPLL IDs a bit by removing the nasty assumption that the index of the DPLL in the arrays matches its ID. Fortunately we did have a WARN i nthere to cathc mistakes, but better to not has such silly assumptions i nthe first place. There's

[Intel-gfx] [PATCH v2 1/4] drm/i915: Stop requiring PLL index == PLL ID

2022-09-26 Thread Ville Syrjala
From: Ville Syrjälä There's no good reason to keep around this PLL index == PLL ID footgun. Get rid of it. state->shared_dpll[] is now indexed by pll->index, which happens to match the index for i915->shared_dplls[] but that detail is inconsequential now. Everything else is all about PLL IDs

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix a potential UAF at device unload (rev2)

2022-09-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix a potential UAF at device unload (rev2) URL : https://patchwork.freedesktop.org/series/108944/ State : success == Summary == CI Bug Log - changes from CI_DRM_12185 -> Patchwork_108944v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: enable PS64 support for DG2

2022-09-26 Thread Patchwork
== Series Details == Series: drm/i915: enable PS64 support for DG2 URL : https://patchwork.freedesktop.org/series/109059/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 0/7] Add HWMON support

2022-09-26 Thread Guenter Roeck
On 9/26/22 10:52, Badal Nilawar wrote: This series adds the HWMON support for DGFX Test-with: 20220919144408.251981-1-riana.ta...@intel.com v2: - Reorganized series. Created first patch as infrastructure patch followed by feature patches. (Ashutosh) - Fixed review comments (Jani)

Re: [Intel-gfx] [PATCH v2 14/15] drm/i915/guc: Support OA when Wa_16011777198 is enabled

2022-09-26 Thread Belgaumkar, Vinay
On 9/26/2022 11:19 AM, Umesh Nerlige Ramappa wrote: On Mon, Sep 26, 2022 at 08:56:01AM -0700, Dixit, Ashutosh wrote: On Fri, 23 Sep 2022 13:11:53 -0700, Umesh Nerlige Ramappa wrote: From: Vinay Belgaumkar Hi Umesh/Vinay, @@ -3254,6 +3265,24 @@ static int i915_oa_stream_init(struct

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-09-26 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/109063/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode

Re: [Intel-gfx] [PATCH] drm/i915/guc: do not capture error state on exiting context

2022-09-26 Thread Andi Shyti
Hi Andrzej, On Mon, Sep 26, 2022 at 11:54:09PM +0200, Andrzej Hajda wrote: > Capturing error state is time consuming (up to 350ms on DG2), so it should > be avoided if possible. Context reset triggered by context removal is a > good example. > With this patch multiple igt tests will not timeout

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Round to closest in g4x+ HDMI clock readout

2022-09-26 Thread Patchwork
== Series Details == Series: drm/i915: Round to closest in g4x+ HDMI clock readout URL : https://patchwork.freedesktop.org/series/109080/ State : success == Summary == CI Bug Log - changes from CI_DRM_12185 -> Patchwork_109080v1 Summary

[Intel-gfx] [PATCH v2 4/4] drm/i915: s/dev_priv/i915/ in the shared_dpll code

2022-09-26 Thread Ville Syrjala
From: Ville Syrjälä Do a s/dev_priv/i915/ pass over the shared_dpll code to get the variable names into sync with modern standards. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 914 +- drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 14 +-

Re: [Intel-gfx] [PATCH v2] overflow: Introduce overflows_type() and castable_to_type()

2022-09-26 Thread Nick Desaulniers
+ Arnd On Mon, Sep 26, 2022 at 12:11 PM Kees Cook wrote: > --- > v2: > - fix comment typo > - wrap clang pragma to avoid GCC warnings > - style nit cleanups > - rename __castable_to_type() to castable_to_type() > - remove prior overflows_type() definition > v1:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add HWMON support

2022-09-26 Thread Patchwork
== Series Details == Series: Add HWMON support URL : https://patchwork.freedesktop.org/series/109069/ State : warning == Summary == Error: dim checkpatch failed 2f9dc1a45021 drm/i915/hwmon: Add HWMON infrastructure Traceback (most recent call last): File "scripts/spdxcheck.py", line 11, in

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Initial Meteorlake Support (rev11)

2022-09-26 Thread Patchwork
== Series Details == Series: Initial Meteorlake Support (rev11) URL : https://patchwork.freedesktop.org/series/106786/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/106786/revisions/11/mbox/ not applied Applying: drm/i915: Read

[Intel-gfx] [PATCH v2 2/4] drm/i915: Decouple I915_NUM_PLLS from PLL IDs

2022-09-26 Thread Ville Syrjala
From: Ville Syrjälä Stop assuming the size of PLL ID based bitmask is restricted to I915_NUM_PLLS bits. This is the last thing coupling the two things together and thus artificially limiting PLL IDs. We could just pass any arbitrary (large enough) size to for_each_set_bit() and be done with it,

[Intel-gfx] [PATCH v2 3/4] drm/i915: Introduce for_each_shared_dpll()

2022-09-26 Thread Ville Syrjala
From: Ville Syrjälä No one really cares how we store the shared_dplls. Currently it happens to be an array, but we could change that to a more flexible scheme at some point. Hide the implementation details behind an iterator macro. The slight downside is the pll variable moving out of the loop

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: enable local stolen memory (rev3)

2022-09-26 Thread Patchwork
== Series Details == Series: drm/i915/mtl: enable local stolen memory (rev3) URL : https://patchwork.freedesktop.org/series/109066/ State : warning == Summary == Error: dim checkpatch failed 73961edcf789 drm/i915/mtl: enable local stolen memory -:222: CHECK:MACRO_ARG_REUSE: Macro argument

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: enable local stolen memory (rev3)

2022-09-26 Thread Patchwork
== Series Details == Series: drm/i915/mtl: enable local stolen memory (rev3) URL : https://patchwork.freedesktop.org/series/109066/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: enable PS64 support for DG2

2022-09-26 Thread Patchwork
== Series Details == Series: drm/i915: enable PS64 support for DG2 URL : https://patchwork.freedesktop.org/series/109059/ State : warning == Summary == Error: dim checkpatch failed 0b2ac0d0d908 drm/i915: enable PS64 support for DG2 -:15: ERROR:GIT_COMMIT_ID: Please use git commit description

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Use i915_vm_put on ppgtt_create error paths

2022-09-26 Thread Patchwork
== Series Details == Series: drm/i915/gt: Use i915_vm_put on ppgtt_create error paths URL : https://patchwork.freedesktop.org/series/109061/ State : success == Summary == CI Bug Log - changes from CI_DRM_12185 -> Patchwork_109061v1 Summary

Re: [Intel-gfx] [PATCH v2 14/15] drm/i915/guc: Support OA when Wa_16011777198 is enabled

2022-09-26 Thread Dixit, Ashutosh
On Mon, 26 Sep 2022 14:17:21 -0700, Belgaumkar, Vinay wrote: > > > On 9/26/2022 11:19 AM, Umesh Nerlige Ramappa wrote: > > On Mon, Sep 26, 2022 at 08:56:01AM -0700, Dixit, Ashutosh wrote: > >> On Fri, 23 Sep 2022 13:11:53 -0700, Umesh Nerlige Ramappa wrote: > >>> > >>> From: Vinay Belgaumkar > >>

[Intel-gfx] ✗ Fi.CI.BUILD: failure for overflow: Introduce overflows_type() and castable_to_type()

2022-09-26 Thread Patchwork
== Series Details == Series: overflow: Introduce overflows_type() and castable_to_type() URL : https://patchwork.freedesktop.org/series/109076/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/109076/revisions/1/mbox/ not applied Applying:

[Intel-gfx] [PATCH] drm/i915: Round to closest in g4x+ HDMI clock readout

2022-09-26 Thread Ville Syrjala
From: Ville Syrjälä On pre-ddi platforms we have slightly different code being used for HDMI TMDS clock to dotclock conversion between the state computation and state readout. Both of these need to round the same way in order to not get a mismatch between the computed and read out states. Fix up

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/display: Don't assume dual mode adaptors support i2c sub-addressing

2022-09-26 Thread Patchwork
== Series Details == Series: drm/display: Don't assume dual mode adaptors support i2c sub-addressing URL : https://patchwork.freedesktop.org/series/109049/ State : success == Summary == CI Bug Log - changes from CI_DRM_12185 -> Patchwork_109049v1

[Intel-gfx] [PATCH] drm/i915/guc: do not capture error state on exiting context

2022-09-26 Thread Andrzej Hajda
Capturing error state is time consuming (up to 350ms on DG2), so it should be avoided if possible. Context reset triggered by context removal is a good example. With this patch multiple igt tests will not timeout and should run faster. Closes:

Re: [Intel-gfx] [PATCH] drm/i915/guc: do not capture error state on exiting context

2022-09-26 Thread Ceraolo Spurio, Daniele
On 9/26/2022 3:44 PM, Andi Shyti wrote: Hi Andrzej, On Mon, Sep 26, 2022 at 11:54:09PM +0200, Andrzej Hajda wrote: Capturing error state is time consuming (up to 350ms on DG2), so it should be avoided if possible. Context reset triggered by context removal is a good example. With this patch

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Move scratch page into system memory on all platforms

2022-09-26 Thread Patchwork
== Series Details == Series: drm/i915/gt: Move scratch page into system memory on all platforms URL : https://patchwork.freedesktop.org/series/109064/ State : success == Summary == CI Bug Log - changes from CI_DRM_12185 -> Patchwork_109064v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Start cleaning up the DPLL ID mess (rev2)

2022-09-26 Thread Patchwork
== Series Details == Series: drm/i915: Start cleaning up the DPLL ID mess (rev2) URL : https://patchwork.freedesktop.org/series/108827/ State : warning == Summary == Error: dim checkpatch failed 490086d775df drm/i915: Stop requiring PLL index == PLL ID -:172: CHECK:SPACING: No space is

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Start cleaning up the DPLL ID mess (rev2)

2022-09-26 Thread Patchwork
== Series Details == Series: drm/i915: Start cleaning up the DPLL ID mess (rev2) URL : https://patchwork.freedesktop.org/series/108827/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: do not capture error state on exiting context

2022-09-26 Thread Patchwork
== Series Details == Series: drm/i915/guc: do not capture error state on exiting context URL : https://patchwork.freedesktop.org/series/109087/ State : success == Summary == CI Bug Log - changes from CI_DRM_12185 -> Patchwork_109087v1

[Intel-gfx] [PATCH v2] overflow: Introduce overflows_type() and castable_to_type()

2022-09-26 Thread Kees Cook
Implement a robust overflows_type() macro to test if a variable or constant value would overflow another variable or type. This can be used as a constant expression for static_assert() (which requires a constant expression[1][2]) when used on constant values. This must be constructed manually,

Re: [Intel-gfx] [PATCH v2] overflow: Introduce overflows_type() and castable_to_type()

2022-09-26 Thread Kees Cook
On Mon, Sep 26, 2022 at 01:17:18PM -0700, Nick Desaulniers wrote: > + Arnd > > On Mon, Sep 26, 2022 at 12:11 PM Kees Cook wrote: > > --- > > v2: > > - fix comment typo > > - wrap clang pragma to avoid GCC warnings > > - style nit cleanups > > - rename __castable_to_type() to

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add HWMON support

2022-09-26 Thread Patchwork
== Series Details == Series: Add HWMON support URL : https://patchwork.freedesktop.org/series/109069/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/display: Don't assume dual mode adaptors support i2c sub-addressing

2022-09-26 Thread Patchwork
== Series Details == Series: drm/display: Don't assume dual mode adaptors support i2c sub-addressing URL : https://patchwork.freedesktop.org/series/109049/ State : success == Summary == CI Bug Log - changes from CI_DRM_12185_full -> Patchwork_109049v1_full

[Intel-gfx] [PATCH] drm/i915: Remove unwanted pointer unpacking

2022-09-26 Thread Niranjana Vishwanathapura
In await_fence_array(), unpacking syncobj pointer is not needed. Remove it. Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c

[Intel-gfx] [PATCH 4/7] drm/i915/hwmon: Show device level energy usage

2022-09-26 Thread Badal Nilawar
From: Dale B Stimson Use i915 HWMON to display device level energy input. v2: Updated the date and kernel version in feature description v3: - Cleaned up hwm_energy function and removed unused function i915_hwmon_energy_status_get (Ashutosh) v4: KernelVersion: 6.2, Date: February 2023 in

[Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval

2022-09-26 Thread Badal Nilawar
From: Ashutosh Dixit Expose power1_max_interval, that is the tau corresponding to PL1, as a custom hwmon attribute. Some bit manipulation is needed because of the format of PKG_PWR_LIM_1_TIME in GT0_PACKAGE_RAPL_LIMIT register (1.x * power(2,y)). v2: Update date and kernel version in

[Intel-gfx] [PATCH 7/7] drm/i915/hwmon: Extend power/energy for XEHPSDV

2022-09-26 Thread Badal Nilawar
From: Dale B Stimson Extend hwmon power/energy for XEHPSDV especially per gt level energy usage. v2: Update to latest HWMON spec (Ashutosh) v3: Fix review comments (Ashutosh) v4: Fix review comments (Anshuman) v5: s/hwmon_device_register_with_info/ devm_hwmon_device_register_with_info/

[Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-09-26 Thread Badal Nilawar
From: Dale B Stimson Use i915 HWMON to display/modify dGfx power PL1 limit and TDP setting. v2: - Fix review comments (Ashutosh) - Do not restore power1_max upon module unload/load sequence because on production systems modules are always loaded and not unloaded/reloaded (Ashutosh)

[Intel-gfx] [PATCH 5/7] drm/i915/hwmon: Expose card reactive critical power

2022-09-26 Thread Badal Nilawar
From: Ashutosh Dixit Expose the card reactive critical (I1) power. I1 is exposed as power1_crit in microwatts (typically for client products) or as curr1_crit in milliamperes (typically for server). v2: Add curr1_crit functionality (Ashutosh) v3: Use HWMON_CHANNEL_INFO to define power1_crit,

[Intel-gfx] [PATCH 1/7] drm/i915/hwmon: Add HWMON infrastructure

2022-09-26 Thread Badal Nilawar
From: Dale B Stimson The i915 HWMON module will be used to expose voltage, power and energy values for dGfx. Here we set up i915 hwmon infrastructure including i915 hwmon registration, basic data structures and functions. v2: - Create HWMON infra patch (Ashutosh) - Fixed review comments

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Fix a potential UAF at device unload (rev2)

2022-09-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix a potential UAF at device unload (rev2) URL : https://patchwork.freedesktop.org/series/108944/ State : success == Summary == CI Bug Log - changes from CI_DRM_12185_full -> Patchwork_108944v2_full

[Intel-gfx] [PATCH 2/7] drm/i915/hwmon: Add HWMON current voltage support

2022-09-26 Thread Badal Nilawar
From: Riana Tauro Use i915 HWMON subsystem to display current input voltage. v2: - Updated date and kernel version in feature description - Fixed review comments (Ashutosh) v3: Use macro HWMON_CHANNEL_INFO to define hwmon channel (Guenter) v4: - Fixed review comments (Ashutosh) - Use

Re: [Intel-gfx] [RFC v4 06/14] drm/i915/vm_bind: Handle persistent vmas

2022-09-26 Thread Niranjana Vishwanathapura
On Mon, Sep 26, 2022 at 07:36:24PM -0700, Zeng, Oak wrote: Regards, Oak -Original Message- From: Intel-gfx On Behalf Of Niranjana Vishwanathapura Sent: September 21, 2022 3:10 AM To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: Zanoni, Paulo R ; Hellstrom,

[Intel-gfx] [PATCH 0/7] drm/i915: Add HWMON support

2022-09-26 Thread Badal Nilawar
This series adds the HWMON support for DGFX Test-with: 20220919144408.251981-1-riana.ta...@intel.com v2: - Reorganized series. Created first patch as infrastructure patch followed by feature patches. (Ashutosh) - Fixed review comments (Jani) - Fixed review comments (Ashutosh) v3: -

Re: [Intel-gfx] [PATCH 0/7] Add HWMON support

2022-09-26 Thread Nilawar, Badal
On 27-09-2022 02:39, Guenter Roeck wrote: On 9/26/22 10:52, Badal Nilawar wrote: This series adds the HWMON support for DGFX Test-with: 20220919144408.251981-1-riana.ta...@intel.com v2:    - Reorganized series. Created first patch as infrastructure patch followed by feature patches.

Re: [Intel-gfx] [PATCH v2 09/33] drm/connector: Add TV standard property

2022-09-26 Thread Maxime Ripard
On Sat, Sep 24, 2022 at 05:52:29PM +0200, Noralf Trønnes wrote: > Den 22.09.2022 16.25, skrev Maxime Ripard: > > The TV mode property has been around for a while now to select and get the > > current TV mode output on an analog TV connector. > > > > Despite that property name being generic, its

Re: [Intel-gfx] [PATCH] drm/i915: fix device info for devices without display

2022-09-26 Thread Jani Nikula
On Tue, 20 Sep 2022, Lucas De Marchi wrote: > On Mon, Sep 19, 2022 at 11:10:53AM +0300, Jani Nikula wrote: >>On Fri, 16 Sep 2022, Lucas De Marchi wrote: >>> On Fri, Sep 16, 2022 at 11:26:42AM +0300, Jani Nikula wrote: Commit 00c6cbfd4e8a ("drm/i915: move pipe_mask and cpu_transcoder_mask

Re: [Intel-gfx] [PATCH v2 10/33] drm/modes: Add a function to generate analog display modes

2022-09-26 Thread Maxime Ripard
Hi, On Fri, Sep 23, 2022 at 11:05:48AM +0200, Thomas Zimmermann wrote: > > + /* 63.556us * 13.5MHz = 858 pixels */ > > I kind of get what the comment wants to tell me, but the units don't add up. I'm not sure how it doesn't add up? We have a frequency in Hz (equivalent to s^-1) and a

Re: [Intel-gfx] [PATCH 03/15] drm/i915: Drop pointless 'budget' variable

2022-09-26 Thread Luca Coelho
On Mon, 2022-09-12 at 14:18 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Just return the thing directly from the switch statement. > > Signed-off-by: Ville Syrjälä > --- Also here. I think this is just unnecessary churn, but it's up to you, so: Reviewed-by: Luca Coelho -- Cheers,

Re: [Intel-gfx] [PATCH v2 02/33] drm/tests: Add Kunit Helpers

2022-09-26 Thread Noralf Trønnes
Den 24.09.2022 19.56, skrev Noralf Trønnes: > > > Den 22.09.2022 16.25, skrev Maxime Ripard: >> As the number of kunit tests in KMS grows further, we start to have >> multiple test suites that, for example, need to register a mock DRM >> driver to interact with the KMS function they are

Re: [Intel-gfx] [PATCH v2 09/33] drm/connector: Add TV standard property

2022-09-26 Thread Noralf Trønnes
Den 22.09.2022 16.25, skrev Maxime Ripard: > The TV mode property has been around for a while now to select and get the > current TV mode output on an analog TV connector. > > Despite that property name being generic, its content isn't and has been > driver-specific which makes it hard to

Re: [Intel-gfx] [PATCH v2 31/33] drm/vc4: vec: Convert to the new TV mode property

2022-09-26 Thread Noralf Trønnes
Den 22.09.2022 16.25, skrev Maxime Ripard: > Now that the core can deal fine with analog TV modes, let's convert the vc4 > VEC driver to leverage those new features. > > We've added some backward compatibility to support the old TV mode property > and translate it into the new TV norm

Re: [Intel-gfx] [PATCH v2 27/33] drm/atomic-helper: Add an analog TV atomic_check implementation

2022-09-26 Thread Noralf Trønnes
Den 22.09.2022 16.25, skrev Maxime Ripard: > The analog TV connector drivers share some atomic_check logic, and the new > TV standard property have created a bunch of new constraints that needs to > be shared across drivers too. The constraints part doesn't apply anymore after removing the

Re: [Intel-gfx] [PATCH v2 08/33] drm/connector: Rename drm_mode_create_tv_properties

2022-09-26 Thread Noralf Trønnes
Den 22.09.2022 16.25, skrev Maxime Ripard: > drm_mode_create_tv_properties(), among other things, will create the > "mode" property that stores the analog TV mode that connector is > supposed to output. > > However, that property is getting deprecated, so let's rename that > function to

Re: [Intel-gfx] [PATCH v2 00/41] drm: Analog TV Improvements

2022-09-26 Thread Noralf Trønnes
Den 21.09.2022 16.03, skrev Maxime Ripard: > On Wed, Sep 07, 2022 at 06:44:53PM +0200, Noralf Trønnes wrote: >> >> >> Den 07.09.2022 12.36, skrev Stefan Wahren: >>> Hi Maxime, >>> >>> Am 05.09.22 um 16:57 schrieb Maxime Ripard: On Fri, Sep 02, 2022 at 01:28:16PM +0200, Noralf Trønnes

Re: [Intel-gfx] [PATCH v2 01/33] drm/tests: Order Kunit tests in Makefile

2022-09-26 Thread Noralf Trønnes
Den 22.09.2022 16.25, skrev Maxime Ripard: > Since we've recently added a ton of tests, the list starts to be a bit > of a mess and creates unneeded conflicts. > > Let's order it alphabetically. > > Signed-off-by: Maxime Ripard > Reviewed-by: Noralf Trønnes

Re: [Intel-gfx] [PATCH 06/15] drm/i915: Extract intel_edp_backlight_setup()

2022-09-26 Thread Luca Coelho
On Mon, 2022-09-12 at 14:18 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Pull the eDP backlight setup ino its own function. No > reason to pollute intel_edp_init_connector() with all > the mundane details. > > Signed-off-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH 01/15] drm/i915: Drop pointless middle man variable

2022-09-26 Thread Luca Coelho
On Mon, 2022-09-26 at 13:43 +0300, Jani Nikula wrote: > On Mon, 26 Sep 2022, Luca Coelho wrote: > > On Mon, 2022-09-12 at 14:18 +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > No need for the 'procmon' variable here. Just return the correct > > > thing from the switch

[Intel-gfx] [PATCH RESEND] drm/display: Don't assume dual mode adaptors support i2c sub-addressing

2022-09-26 Thread Simon Rettberg
Current dual mode adaptor ("DP++") detection code assumes that all adaptors support i2c sub-addressing for read operations from the DP-HDMI adaptor ID buffer. It has been observed that multiple adaptors do not in fact support this, and always return data starting at register 0. On affected

Re: [Intel-gfx] [PATCH v3 01/37] drm/i915: fix kernel-doc trivial warnings on i915/*.[ch] files

2022-09-26 Thread Mauro Carvalho Chehab
Em Fri, 16 Sep 2022 17:03:27 +0300 Gwan-gyeong Mun escreveu: > > /** > > - * Called when user space has done writes to this buffer > > + * i915_gem_sw_finish_ioctl - Called when user space has done writes to > > + * this buffer > As per this link[1], the brief description does not

Re: [Intel-gfx] [PATCH v2 02/33] drm/tests: Add Kunit Helpers

2022-09-26 Thread Maxime Ripard
Hi Noralf, On Sat, Sep 24, 2022 at 08:06:17PM +0200, Noralf Trønnes wrote: > Den 24.09.2022 19.56, skrev Noralf Trønnes: > > > > > > Den 22.09.2022 16.25, skrev Maxime Ripard: > >> As the number of kunit tests in KMS grows further, we start to have > >> multiple test suites that, for example,

Re: [Intel-gfx] [PATCH v2 06/33] drm/connector: Rename legacy TV property

2022-09-26 Thread Maxime Ripard
Hi Thomas, On Fri, Sep 23, 2022 at 10:19:08AM +0200, Thomas Zimmermann wrote: > Hi > > Am 22.09.22 um 16:25 schrieb Maxime Ripard: > > The current tv_mode has driver-specific values that don't allow to > > easily share code using it, either at the userspace or kernel level. > > > > Since we're

Re: [Intel-gfx] [PATCH v2 10/33] drm/modes: Add a function to generate analog display modes

2022-09-26 Thread Maxime Ripard
On Fri, Sep 23, 2022 at 12:16:13PM +0200, Thomas Zimmermann wrote: > Hi > > Am 23.09.22 um 11:18 schrieb Jani Nikula: > > On Fri, 23 Sep 2022, Thomas Zimmermann wrote: > > > Am 22.09.22 um 16:25 schrieb Maxime Ripard: > > > > + drm_dbg_kms(dev, > > > > + "Generating a

Re: [Intel-gfx] [PATCH v2 10/33] drm/modes: Add a function to generate analog display modes

2022-09-26 Thread Geert Uytterhoeven
Hi Maxime, On Mon, Sep 26, 2022 at 12:17 PM Maxime Ripard wrote: > On Fri, Sep 23, 2022 at 11:05:48AM +0200, Thomas Zimmermann wrote: > > > + /* 63.556us * 13.5MHz = 858 pixels */ > > > > I kind of get what the comment wants to tell me, but the units don't add up. > > I'm not sure how it

Re: [Intel-gfx] [PATCH 01/15] drm/i915: Drop pointless middle man variable

2022-09-26 Thread Luca Coelho
On Mon, 2022-09-12 at 14:18 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > No need for the 'procmon' variable here. Just return the correct > thing from the switch statement directly. > > Signed-off-by: Ville Syrjälä > --- This doesn't make any difference in practice, the compiler will

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pps: Enable 2nd pps for dual EDP scenario

2022-09-26 Thread Jani Nikula
On Tue, 20 Sep 2022, "Manna, Animesh" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Friday, September 16, 2022 5:00 PM >> To: Manna, Animesh ; Ville Syrjälä >> >> Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma >> Subject: RE: [PATCH 2/2] drm/i915/pps: Enable 2nd pps

Re: [Intel-gfx] [PATCH v2 02/33] drm/tests: Add Kunit Helpers

2022-09-26 Thread Noralf Trønnes
Den 22.09.2022 16.25, skrev Maxime Ripard: > As the number of kunit tests in KMS grows further, we start to have > multiple test suites that, for example, need to register a mock DRM > driver to interact with the KMS function they are supposed to test. > > Let's add a file meant to provide

Re: [Intel-gfx] [PATCH v2 00/33] drm: Analog TV Improvements

2022-09-26 Thread Noralf Trønnes
Den 22.09.2022 16.25, skrev Maxime Ripard: > Hi, > > Here's a series aiming at improving the command line named modes support, > and more importantly how we deal with all the analog TV variants. > > The named modes support were initially introduced to allow to specify the > analog TV mode to

Re: [Intel-gfx] [PATCH v4 09/21] drm/etnaviv: Prepare to dynamic dma-buf locking specification

2022-09-26 Thread cco
To whoom it may belong: Deepest sorrow to inform you that my husband Helmut passed by on July 21. This access will be cleared in a view days. Irene Ursprüngliche Nachricht Von: Christian König Datum: 01.09.22 08:50 (GMT+01:00) An: Dmitry Osipenko , David Airlie , Gerd

Re: [Intel-gfx] [PATCH v2 28/33] drm/vc4: vec: Fix definition of PAL-M mode

2022-09-26 Thread Noralf Trønnes
Den 22.09.2022 16.25, skrev Maxime Ripard: > From: Mateusz Kwiatkowski > > PAL-M is a Brazilian analog TV standard that uses a PAL-style chroma > subcarrier at 3.575611[888111] MHz on top of 525-line (480i60) timings. > This commit makes the driver actually use the proper VEC preset for this

Re: [Intel-gfx] [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry

2022-09-26 Thread Zheng Hacker
I've sent it using git send-email with another email account (zyytlz...@163.com) Regards, Zheng Wang Jani Nikula 于2022年9月19日周一 17:30写道: > > On Mon, 19 Sep 2022, Zheng Wang <1002992...@qq.com> wrote: > > From afe79848cb74cc8e45ab426d13fa2394c87e0422 Mon Sep 17 00:00:00 2001 > > From: xmzyshypnc

Re: [Intel-gfx] [PATCH v2 06/33] drm/connector: Rename legacy TV property

2022-09-26 Thread Noralf Trønnes
Den 22.09.2022 16.25, skrev Maxime Ripard: > The current tv_mode has driver-specific values that don't allow to > easily share code using it, either at the userspace or kernel level. > > Since we're going to introduce a new, generic, property that fit the > same purpose, let's rename this one

Re: [Intel-gfx] [PATCH v2 30/33] drm/vc4: vec: Check for VEC output constraints

2022-09-26 Thread Noralf Trønnes
Den 22.09.2022 16.25, skrev Maxime Ripard: > From: Mateusz Kwiatkowski > > The VEC can accept pretty much any relatively reasonable mode, but still > has a bunch of constraints to meet. > > Let's create an atomic_check() implementation that will make sure we > don't end up accepting a

Re: [Intel-gfx] [PATCH 05/15] drm/i915: Pass intel_encoder to to_lvds_encoder()

2022-09-26 Thread Luca Coelho
On Mon, 2022-09-12 at 14:18 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Most of our encoder type cast stuff already operates on > intel_encoder rather than drm_encoder. Switch to_lvds_encoder() > over as well. > > Signed-off-by: Ville Syrjälä > --- Reviewed-by: Luca Coelho --

Re: [Intel-gfx] [PATCH v2 10/33] drm/modes: Add a function to generate analog display modes

2022-09-26 Thread Thomas Zimmermann
Hi Am 26.09.22 um 12:34 schrieb Geert Uytterhoeven: Hi Maxime, On Mon, Sep 26, 2022 at 12:17 PM Maxime Ripard wrote: On Fri, Sep 23, 2022 at 11:05:48AM +0200, Thomas Zimmermann wrote: + /* 63.556us * 13.5MHz = 858 pixels */ I kind of get what the comment wants to tell me, but the units

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable YCbCr420 for VDSC (rev2)

2022-09-26 Thread Patchwork
== Series Details == Series: Enable YCbCr420 for VDSC (rev2) URL : https://patchwork.freedesktop.org/series/108824/ State : success == Summary == CI Bug Log - changes from CI_DRM_12180 -> Patchwork_108824v2 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH v3 27/37] docs: gpu: i915.rst: gt: add more kernel-doc markups

2022-09-26 Thread Mauro Carvalho Chehab
Em Fri, 9 Sep 2022 05:06:46 -0400 Rodrigo Vivi escreveu: > On Fri, Sep 09, 2022 at 09:34:34AM +0200, Mauro Carvalho Chehab wrote: > > There are several documented GT kAPI that aren't currently part > > of the docs. Add them, as this allows identifying issues with > > badly-formatted tags. > >

Re: [Intel-gfx] [PATCH] drm/i915: move i915_coherent_map_type() to i915_gem_pages.c and un-inline

2022-09-26 Thread Jani Nikula
On Tue, 20 Sep 2022, Matthew Auld wrote: > On 15/09/2022 08:49, Tvrtko Ursulin wrote: >> >> On 14/09/2022 17:35, Jani Nikula wrote: >>> The inline function has no place in i915_drv.h. Move it away, un-inline, >>> and untangle some header dependencies while at it. >>> >>> Cc: Matthew Auld >>>

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Mark FBC B gone if pipe B is gone

2022-09-26 Thread Luca Coelho
On Fri, 2022-09-23 at 10:46 +0300, Ville Syrjälä wrote: > On Fri, Sep 23, 2022 at 09:24:28AM +0300, Luca Coelho wrote: > > On Thu, 2022-09-22 at 14:57 +0300, Ville Syrjälä wrote: > > > On Thu, Sep 22, 2022 at 02:37:35PM +0300, Luca Coelho wrote: > > > > On Thu, 2022-09-22 at 12:36 +0300, Ville

[Intel-gfx] ✓ Fi.CI.IGT: success for Enable YCbCr420 for VDSC (rev2)

2022-09-26 Thread Patchwork
== Series Details == Series: Enable YCbCr420 for VDSC (rev2) URL : https://patchwork.freedesktop.org/series/108824/ State : success == Summary == CI Bug Log - changes from CI_DRM_12180_full -> Patchwork_108824v2_full Summary ---

Re: [Intel-gfx] [PATCH v11.5] overflow: Introduce overflows_type() and __castable_to_type()

2022-09-26 Thread Gwan-gyeong Mun
Hi Kees, Thank you so much for taking the time to refine and update the code and checking out where the side effects that I missed may occur. On 9/26/22 3:37 AM, Kees Cook wrote: Add overflows_type() to test if a variable or constant value would overflow another variable or type. This can be

[Intel-gfx] [PATCH] drm/i915: disable FBC if its pipe is fused off

2022-09-26 Thread Luca Coelho
In newer hardware, the FBCs are associated with their pipes, so if the pipe is fused off, it means that the FBC is not available either. We already disable FBC A if pipe A is fused off, but the other FBCs were not handled. Currently we only have FBC A and FBC B, but for consistency, add FBC C

Re: [Intel-gfx] [PATCH 02/15] drm/i915: Clean up transcoder_to_stream_enc_status()

2022-09-26 Thread Luca Coelho
On Mon, 2022-09-12 at 14:18 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Drop the pointless middle man variable and just return the > correct thing directly. And while at it change the return > type to u32 since this is a register value we're returning. > > Signed-off-by: Ville

Re: [Intel-gfx] [PATCH 04/15] drm/i915: Use BIT() when dealing with output types

2022-09-26 Thread Luca Coelho
On Mon, 2022-09-12 at 14:18 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Most places that deal with output types already use BIT() > but a few places still use manual shifts. Convert the > stragglers over to BIT(). > > Signed-off-by: Ville Syrjälä > --- Reviewed-by: Luca Coelho --

Re: [Intel-gfx] [PATCH v2 32/33] drm/vc4: vec: Add support for more analog TV standards

2022-09-26 Thread Noralf Trønnes
Den 22.09.2022 16.25, skrev Maxime Ripard: > From: Mateusz Kwiatkowski > > Add support for the following composite output modes (all of them are > somewhat more obscure than the previously defined ones): > > - NTSC_443 - NTSC-style signal with the chroma subcarrier shifted to > 4.43361875

Re: [Intel-gfx] [PATCH 01/15] drm/i915: Drop pointless middle man variable

2022-09-26 Thread Jani Nikula
On Mon, 26 Sep 2022, Luca Coelho wrote: > On Mon, 2022-09-12 at 14:18 +0300, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> No need for the 'procmon' variable here. Just return the correct >> thing from the switch statement directly. >> >> Signed-off-by: Ville Syrjälä >> --- > > This

Re: [Intel-gfx] [PATCH v2 10/33] drm/modes: Add a function to generate analog display modes

2022-09-26 Thread Thomas Zimmermann
Hi Am 26.09.22 um 12:18 schrieb Maxime Ripard: On Fri, Sep 23, 2022 at 12:16:13PM +0200, Thomas Zimmermann wrote: Hi Am 23.09.22 um 11:18 schrieb Jani Nikula: On Fri, 23 Sep 2022, Thomas Zimmermann wrote: Am 22.09.22 um 16:25 schrieb Maxime Ripard: + drm_dbg_kms(dev, +

Re: [Intel-gfx] [PATCH 06/15] drm/i915: Extract intel_edp_backlight_setup()

2022-09-26 Thread Ville Syrjälä
On Mon, Sep 26, 2022 at 01:58:42PM +0300, Luca Coelho wrote: > On Mon, 2022-09-12 at 14:18 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Pull the eDP backlight setup ino its own function. No > > reason to pollute intel_edp_init_connector() with all > > the mundane details. > > > >

Re: [Intel-gfx] [PATCH] drm/i915/gt: Restrict forced preemption to the active context

2022-09-26 Thread Andi Shyti
Hi Andrzej and Chris, pushed to drm-intel-gt-next Thanks! Andi On Wed, Sep 21, 2022 at 03:52:58PM +0200, Andrzej Hajda wrote: > From: Chris Wilson > > When we submit a new pair of contexts to ELSP for execution, we start a > timer by which point we expect the HW to have switched execution to

Re: [Intel-gfx] [PATCH 06/15] drm/i915: Extract intel_edp_backlight_setup()

2022-09-26 Thread Luca Coelho
On Mon, 2022-09-26 at 14:16 +0300, Ville Syrjälä wrote: > On Mon, Sep 26, 2022 at 01:58:42PM +0300, Luca Coelho wrote: > > On Mon, 2022-09-12 at 14:18 +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Pull the eDP backlight setup ino its own function. No > > > reason to pollute

Re: [Intel-gfx] [PATCH 06/15] drm/i915: Extract intel_edp_backlight_setup()

2022-09-26 Thread Luca Coelho
On Mon, 2022-09-26 at 14:33 +0300, Luca Coelho wrote: > On Mon, 2022-09-26 at 14:16 +0300, Ville Syrjälä wrote: > > On Mon, Sep 26, 2022 at 01:58:42PM +0300, Luca Coelho wrote: > > > On Mon, 2022-09-12 at 14:18 +0300, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > > > > > > > Pull the eDP

  1   2   >