[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add HWMON support (rev8)

2022-09-29 Thread Patchwork
== Series Details == Series: drm/i915: Add HWMON support (rev8) URL : https://patchwork.freedesktop.org/series/104278/ State : success == Summary == CI Bug Log - changes from CI_DRM_12185 -> Patchwork_104278v8 Summary ---

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for Add SLPC selftest live_slpc_power (rev2)

2022-09-29 Thread Gupta, Anshuman
On 9/24/2022 7:31 AM, Patchwork wrote: *Patch Details* *Series:* Add SLPC selftest live_slpc_power (rev2) *URL:* https://patchwork.freedesktop.org/series/108900/ *State:*success *Details:*

[Intel-gfx] [PATCH 04/10] drm/i915: Clean up intel_color_init_hooks()

2022-09-29 Thread Ville Syrjala
From: Ville Syrjälä Remove a bunch of pointless curly brackets and do the s/dev_priv/i915/ while at it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_color.c | 43 +++--- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git

Re: [Intel-gfx] [PATCH v4 3/4] drm/i915: Make the heartbeat play nice with long pre-emption timeouts

2022-09-29 Thread Tvrtko Ursulin
On 29/09/2022 03:18, john.c.harri...@intel.com wrote: From: John Harrison Compute workloads are inherently not pre-emptible for long periods on current hardware. As a workaround for this, the pre-emption timeout for compute capable engines was disabled. This is undesirable with GuC

[Intel-gfx] ✗ Fi.CI.IGT: failure for iommu: Remove iova cpu hotplugging flushing (rev2)

2022-09-29 Thread Patchwork
== Series Details == Series: iommu: Remove iova cpu hotplugging flushing (rev2) URL : https://patchwork.freedesktop.org/series/108880/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12193_full -> Patchwork_108880v2_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Prep work for finishing (de)gamma readout

2022-09-29 Thread Patchwork
== Series Details == Series: drm/i915: Prep work for finishing (de)gamma readout URL : https://patchwork.freedesktop.org/series/109229/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Prep work for finishing (de)gamma readout

2022-09-29 Thread Patchwork
== Series Details == Series: drm/i915: Prep work for finishing (de)gamma readout URL : https://patchwork.freedesktop.org/series/109229/ State : success == Summary == CI Bug Log - changes from CI_DRM_12197 -> Patchwork_109229v1 Summary

Re: [Intel-gfx] [PATCH v4 1/4] drm/i915/guc: Limit scheduling properties to avoid overflow

2022-09-29 Thread Tvrtko Ursulin
On 29/09/2022 03:18, john.c.harri...@intel.com wrote: From: John Harrison GuC converts the pre-emption timeout and timeslice quantum values into clock ticks internally. That significantly reduces the point of 32bit overflow. On current platforms, worst case scenario is approximately 110

Re: [Intel-gfx] [PATCH] drm/i915/guc: do not capture error state on exiting context

2022-09-29 Thread Tvrtko Ursulin
On 28/09/2022 19:27, John Harrison wrote: On 9/28/2022 00:19, Tvrtko Ursulin wrote: On 27/09/2022 22:36, Ceraolo Spurio, Daniele wrote: On 9/27/2022 12:45 AM, Tvrtko Ursulin wrote: On 27/09/2022 07:49, Andrzej Hajda wrote: On 27.09.2022 01:34, Ceraolo Spurio, Daniele wrote: On 9/26/2022

[Intel-gfx] ✓ Fi.CI.IGT: success for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-09-29 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/109169/ State : success == Summary == CI Bug Log - changes from CI_DRM_12193_full ->

[Intel-gfx] [PATCH 07/10] drm/i915: Introduce crtc_state->{pre, post}_csc_lut

2022-09-29 Thread Ville Syrjala
From: Ville Syrjälä Add an extra remapping step between the logical state of the LUTs (hw.(de)gamma_lut) as specified via uapi/bigjoiner copy vs. the actual state of the LUTs programmed into the hardware. With this we should be finally able finish the (de)gamma readout/state checker support for

[Intel-gfx] [PATCH 06/10] drm/i915: Make ilk_load_luts() deal with degamma

2022-09-29 Thread Ville Syrjala
From: Ville Syrjälä Make ilk_load_luts() ready for a degamma lut. Currently we never have one, but soon we may get one from readout, and I think we may want to change the state computation such that we may end up with one even when userspace has simply supplied a gamma lut. At least the code

[Intel-gfx] [PATCH 09/10] drm/i915: Get rid of glk_load_degamma_lut_linear()

2022-09-29 Thread Ville Syrjala
From: Ville Syrjälä Since we now have a place (pre_csc_lut) to stuff a purely internal LUT we can replace glk_load_degamma_lut_linear() with such a thing and just rely on the normal glk_load_degamma_lut() to load it as well. drm_mode_config_cleanup() will clean this up for us. Signed-off-by:

[Intel-gfx] [PATCH 08/10] drm/i915: Assert {pre, post}_csc_lut were assigned sensibly

2022-09-29 Thread Ville Syrjala
From: Ville Syrjälä Since we now have the extra step from hw.(de)gamma_lut into {pre,post}_csc_lut let's make sure we didn't forget to assign them appropriately. Ie. basically making sure intel_color_check() was called when necessary (and that it did its job suitable well). Signed-off-by: Ville

[Intel-gfx] [PATCH 10/10] drm/i915: Stop loading linear degammma LUT on glk needlessly

2022-09-29 Thread Ville Syrjala
From: Ville Syrjälä Make glk_load_luts() a bit lighter for the common case where neither the degamma LUT nor pipe CSC are enabled by not loading the linear degamma LUT. Making .load_luts() as lightweight as possible is a good idea since it may need to execute from a vblank worker under tight

[Intel-gfx] [PATCH 00/10] drm/i915: Prep work for finishing (de)gamma readout

2022-09-29 Thread Ville Syrjala
From: Ville Syrjälä Add another layer of LUT blobs in order to make gamma state readout/check possible on ilk-skl. As a bonus we can also simplify the glk degamma vs. csc mess. The actual state readout/checker stuff that we're currently missing will follow later. Ville Syrjälä (10):

[Intel-gfx] [PATCH 01/10] drm/i915: Remove PLL asserts from .load_luts()

2022-09-29 Thread Ville Syrjala
From: Ville Syrjälä .load_luts() potentially runs from the vblank worker, and is under a deadline to complete within the vblank. Thus we can't do expesive stuff like talk to the Punit, etc. To that end get rid of the assert_dsi_pll_enabled() call for vlv/chv. We'll just have to trust that the

[Intel-gfx] [PATCH 05/10] drm/i915: Change glk_load_degamma_lut() calling convention

2022-09-29 Thread Ville Syrjala
From: Ville Syrjälä Make glk_load_degamma_lut() more like most everyone else and pass in the LUT explicitly. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_color.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git

[Intel-gfx] [PATCH 03/10] drm/i915: Simplify the intel_color_init_hooks() if ladder

2022-09-29 Thread Ville Syrjala
From: Ville Syrjälä Get rid of the funny hsw vs. ivb extra indentation level in intel_color_init_hooks(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_color.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

[Intel-gfx] [PATCH 02/10] drm/i915: Split up intel_color_init()

2022-09-29 Thread Ville Syrjala
From: Ville Syrjälä intel_color_init() does both device level and crtc level stuff. Split it up accordingly. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_color.c | 15 +-- drivers/gpu/drm/i915/display/intel_color.h | 4 +++-

Re: [Intel-gfx] [PATCH v4 4/4] drm/i915: Improve long running compute w/a for GuC submission

2022-09-29 Thread Tvrtko Ursulin
On 29/09/2022 03:18, john.c.harri...@intel.com wrote: From: John Harrison A workaround was added to the driver to allow compute workloads to run 'forever' by disabling pre-emption on the RCS engine for Gen12. It is not totally unbound as the heartbeat will kick in eventually and cause a

Re: [Intel-gfx] [PATCH] drm/i915/guc: do not capture error state on exiting context

2022-09-29 Thread Andrzej Hajda
On 29.09.2022 10:22, Tvrtko Ursulin wrote: On 28/09/2022 19:27, John Harrison wrote: On 9/28/2022 00:19, Tvrtko Ursulin wrote: On 27/09/2022 22:36, Ceraolo Spurio, Daniele wrote: On 9/27/2022 12:45 AM, Tvrtko Ursulin wrote: On 27/09/2022 07:49, Andrzej Hajda wrote: On 27.09.2022 01:34,

Re: [Intel-gfx] [PATCH 05/16] drm/i915/vm_bind: Implement bind and unbind of object

2022-09-29 Thread Matthew Auld
On 29/09/2022 06:24, Niranjana Vishwanathapura wrote: On Wed, Sep 28, 2022 at 06:52:21PM +0100, Matthew Auld wrote: On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: Add uapi and implement support for bind and unbind of an object at the specified GPU virtual addresses. The vm_bind mode is

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gt: Flush to global observation point before breadcrumb write (rev2)

2022-09-29 Thread Patchwork
== Series Details == Series: drm/i915/gt: Flush to global observation point before breadcrumb write (rev2) URL : https://patchwork.freedesktop.org/series/109133/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry (rev3)

2022-09-29 Thread Patchwork
== Series Details == Series: drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry (rev3) URL : https://patchwork.freedesktop.org/series/108732/ State : warning == Summary == Error: dim checkpatch failed 4b8a44dfb06a drm/i915/gvt: fix double free bug in split_2MB_gtt_entry -:54:

[Intel-gfx] [PATCH v4 07/30] drm/connector: Rename legacy TV property

2022-09-29 Thread Maxime Ripard
The current tv_mode has driver-specific values that don't allow to easily share code using it, either at the userspace or kernel level. Since we're going to introduce a new, generic, property that fit the same purpose, let's rename this one to legacy_tv_mode to make it obvious we should move away

[Intel-gfx] [PATCH v4 12/30] drm/modes: Only consider bpp and refresh before options

2022-09-29 Thread Maxime Ripard
Some video= options might have a value that contains a dash. However, the command line parsing mode considers all dashes as the separator between the mode and the bpp count. Let's rework the parsing code a bit to only consider a dash as the bpp separator if it before a comma, the options

[Intel-gfx] [PATCH v4 14/30] drm/client: Add some tests for drm_connector_pick_cmdline_mode()

2022-09-29 Thread Maxime Ripard
drm_connector_pick_cmdline_mode() is in charge of finding a proper drm_display_mode from the definition we got in the video= command line argument. Let's add some unit tests to make sure we're not getting any regressions there. Signed-off-by: Maxime Ripard --- Changes in v4: - Removed MODULE

[Intel-gfx] [PATCH v4 08/30] drm/connector: Only register TV mode property if present

2022-09-29 Thread Maxime Ripard
The drm_create_tv_properties() will create the TV mode property unconditionally. However, since we'll gradually phase it out, let's register it only if we have a list passed as an argument. This will make the transition easier. Acked-by: Noralf Trønnes Signed-off-by: Maxime Ripard ---

[Intel-gfx] [PATCH v4 11/30] drm/modes: Add a function to generate analog display modes

2022-09-29 Thread Maxime Ripard
Multiple drivers (meson, vc4, sun4i) define analog TV 525-lines and 625-lines modes in their drivers. Since those modes are fairly standard, and that we'll need to use them in more places in the future, it makes sense to move their definition into the core framework. However, analog display

[Intel-gfx] [PATCH v4 09/30] drm/connector: Rename drm_mode_create_tv_properties

2022-09-29 Thread Maxime Ripard
drm_mode_create_tv_properties(), among other things, will create the "mode" property that stores the analog TV mode that connector is supposed to output. However, that property is getting deprecated, so let's rename that function to mention it's deprecated. We'll introduce a new variant of that

Re: [Intel-gfx] [PATCH] drm/i915: Fix CFI violations in gt_sysfs

2022-09-29 Thread Andi Shyti
Hi Nathan, thanks for this refactoring... looks good even though i would have split it in more patches as this is doing quite many things. But I will not be stubborn, I understand that it's not trivial to have things split. I will give my r-b for now but I will check it again before applying it

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gvt: Add missing vfio_unregister_group_dev() call

2022-09-29 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Add missing vfio_unregister_group_dev() call URL : https://patchwork.freedesktop.org/series/109264/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/109264/revisions/1/mbox/ not applied Applying:

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm: Analog TV Improvements (rev3)

2022-09-29 Thread Patchwork
== Series Details == Series: drm: Analog TV Improvements (rev3) URL : https://patchwork.freedesktop.org/series/107892/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/107892/revisions/3/mbox/ not applied Applying: drm/docs: Remove unused TV

Re: [Intel-gfx] [PATCH 05/16] drm/i915/vm_bind: Implement bind and unbind of object

2022-09-29 Thread Niranjana Vishwanathapura
On Thu, Sep 29, 2022 at 11:49:30AM +0100, Matthew Auld wrote: On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: Add uapi and implement support for bind and unbind of an object at the specified GPU virtual addresses. The vm_bind mode is not supported in legacy execbuf2 ioctl. It will be

[Intel-gfx] [PATCH v4 01/30] drm/docs: Remove unused TV Standard property

2022-09-29 Thread Maxime Ripard
That property is not used or exposed by any driver in the kernel. Remove it from the documentation. Signed-off-by: Maxime Ripard --- Changes in v4: - New patch --- Documentation/gpu/kms-properties.csv | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/gpu/kms-properties.csv

[Intel-gfx] [PATCH v4 02/30] drm/tests: Order Kunit tests in Makefile

2022-09-29 Thread Maxime Ripard
Since we've recently added a ton of tests, the list starts to be a bit of a mess and creates unneeded conflicts. Let's order it alphabetically. Acked-by: Thomas Zimmermann Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/Makefile | 14 +++--- 1 file

[Intel-gfx] [PATCH v4 03/30] drm/tests: Add Kunit Helpers

2022-09-29 Thread Maxime Ripard
As the number of kunit tests in KMS grows further, we start to have multiple test suites that, for example, need to register a mock DRM driver to interact with the KMS function they are supposed to test. Let's add a file meant to provide those kind of helpers to avoid duplication. Signed-off-by:

[Intel-gfx] [PATCH v4 05/30] drm/connector: Rename subconnector state variable

2022-09-29 Thread Maxime Ripard
There is two TV subconnector related properties registered by drm_mode_create_tv_properties(): subconnector and select subconnector. While the select subconnector property is stored in the kernel by the drm_tv_connector_state structure, the subconnector property isn't stored anywhere. Worse, the

[Intel-gfx] [PATCH v4 06/30] drm/atomic: Add TV subconnector property to get/set_property

2022-09-29 Thread Maxime Ripard
The subconnector property was created by drm_mode_create_tv_properties(), but wasn't exposed to the userspace through the generic atomic_get/set_property implementation, and wasn't stored in any generic state structure. Let's solve this. Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard

[Intel-gfx] [PATCH v4 04/30] drm/atomic-helper: Rename drm_atomic_helper_connector_tv_reset to avoid ambiguity

2022-09-29 Thread Maxime Ripard
We currently have two sets of TV properties. The first one is there to deal with analog TV properties, creating properties such as the TV mode, subconnectors, saturation, hue and so on. It's created by calling the drm_mode_create_tv_properties() function. The second one is there to deal with

Re: [Intel-gfx] [PATCH v4 15/15] vfio: Add struct device to vfio_device

2022-09-29 Thread Alex Williamson
Hi Kevin, This introduced the regression discovered here: https://lore.kernel.org/all/20220928125650.0a2ea297.alex.william...@redhat.com/ Seems we're not releasing the resources when removing an mdev. This is a regression, so it needs to be fixed or reverted before the merge window. Thanks,

Re: [Intel-gfx] [PATCH 05/16] drm/i915/vm_bind: Implement bind and unbind of object

2022-09-29 Thread Matthew Auld
On 29/09/2022 17:38, Niranjana Vishwanathapura wrote: On Thu, Sep 29, 2022 at 11:49:30AM +0100, Matthew Auld wrote: On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: Add uapi and implement support for bind and unbind of an object at the specified GPU virtual addresses. The vm_bind mode is

Re: [Intel-gfx] [PATCH 05/16] drm/i915/vm_bind: Implement bind and unbind of object

2022-09-29 Thread Niranjana Vishwanathapura
On Thu, Sep 29, 2022 at 06:28:39PM +0100, Matthew Auld wrote: On 29/09/2022 17:38, Niranjana Vishwanathapura wrote: On Thu, Sep 29, 2022 at 11:49:30AM +0100, Matthew Auld wrote: On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: Add uapi and implement support for bind and unbind of an

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Add C10 phy support

2022-09-29 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add C10 phy support URL : https://patchwork.freedesktop.org/series/109248/ State : success == Summary == CI Bug Log - changes from CI_DRM_12199 -> Patchwork_109248v1 Summary --- **SUCCESS**

[Intel-gfx] [PATCH v4 10/30] drm/connector: Add TV standard property

2022-09-29 Thread Maxime Ripard
The TV mode property has been around for a while now to select and get the current TV mode output on an analog TV connector. Despite that property name being generic, its content isn't and has been driver-specific which makes it hard to build any generic behaviour on top of it, both in kernel and

[Intel-gfx] [PATCH v4 13/30] drm/modes: parse_cmdline: Add support for named modes containing dashes

2022-09-29 Thread Maxime Ripard
From: Geert Uytterhoeven It is fairly common for named video modes to contain dashes (e.g. "tt-mid" on Atari, "dblntsc-ff" on Amiga). Currently such mode names are not recognized, as the dash is considered to be a separator between mode name and bpp. Fix this by skipping any dashes that are

[Intel-gfx] [PATCH v4 18/30] drm/connector: Add pixel clock to cmdline mode

2022-09-29 Thread Maxime Ripard
We'll need to get the pixel clock to generate proper display modes for all the current named modes. Let's add it to struct drm_cmdline_mode and fill it when parsing the named mode. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_modes.c | 9 ++--- include/drm/drm_connector.h | 7

[Intel-gfx] [PATCH v4 15/30] drm/modes: Move named modes parsing to a separate function

2022-09-29 Thread Maxime Ripard
The current construction of the named mode parsing doesn't allow to extend it easily. Let's move it to a separate function so we can add more parameters and modes. In order for the tests to still pass, some extra checks are needed, so it's not a 1:1 move. Signed-off-by: Maxime Ripard ---

Re: [Intel-gfx] [PATCH v4 15/15] vfio: Add struct device to vfio_device

2022-09-29 Thread Alex Williamson
On Thu, 29 Sep 2022 14:49:56 -0300 Jason Gunthorpe wrote: > On Thu, Sep 29, 2022 at 10:55:19AM -0600, Alex Williamson wrote: > > Hi Kevin, > > > > This introduced the regression discovered here: > > > > https://lore.kernel.org/all/20220928125650.0a2ea297.alex.william...@redhat.com/ > > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry (rev3)

2022-09-29 Thread Patchwork
== Series Details == Series: drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry (rev3) URL : https://patchwork.freedesktop.org/series/108732/ State : success == Summary == CI Bug Log - changes from CI_DRM_12199 -> Patchwork_108732v3

[Intel-gfx] [PATCH v4 00/30] drm: Analog TV Improvements

2022-09-29 Thread Maxime Ripard
Hi, Here's a series aiming at improving the command line named modes support, and more importantly how we deal with all the analog TV variants. The named modes support were initially introduced to allow to specify the analog TV mode to be used. However, this was causing multiple issues: *

Re: [Intel-gfx] [PATCH] drm/i915/guc: do not capture error state on exiting context

2022-09-29 Thread John Harrison
On 9/29/2022 01:22, Tvrtko Ursulin wrote: On 28/09/2022 19:27, John Harrison wrote: On 9/28/2022 00:19, Tvrtko Ursulin wrote: On 27/09/2022 22:36, Ceraolo Spurio, Daniele wrote: On 9/27/2022 12:45 AM, Tvrtko Ursulin wrote: On 27/09/2022 07:49, Andrzej Hajda wrote: On 27.09.2022 01:34,

[Intel-gfx] [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call

2022-09-29 Thread Jason Gunthorpe
When converting to directly create the vfio_device the mdev driver has to put a vfio_register_emulated_iommu_dev() in the probe() and a pairing vfio_unregister_group_dev() in the remove. This was missed for gvt, add it. Cc: sta...@vger.kernel.org Fixes: 978cf586ac35 ("drm/i915/gvt: convert to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: enable local stolen memory (rev5)

2022-09-29 Thread Patchwork
== Series Details == Series: drm/i915/mtl: enable local stolen memory (rev5) URL : https://patchwork.freedesktop.org/series/109066/ State : success == Summary == CI Bug Log - changes from CI_DRM_12199 -> Patchwork_109066v5 Summary ---

Re: [Intel-gfx] [PATCH v5] drm/i915/mtl: enable local stolen memory

2022-09-29 Thread Matt Roper
On Thu, Sep 29, 2022 at 05:16:58PM +0530, Aravind Iddamsetty wrote: > As an integrated GPU, MTL does not have local memory and HAS_LMEM() > returns false. However the platform's stolen memory is presented via > BAR2 (i.e., the BAR we traditionally consider to be the GMADR on IGFX) > and should be

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Flush to global observation point before breadcrumb write (rev2)

2022-09-29 Thread Patchwork
== Series Details == Series: drm/i915/gt: Flush to global observation point before breadcrumb write (rev2) URL : https://patchwork.freedesktop.org/series/109133/ State : success == Summary == CI Bug Log - changes from CI_DRM_12199 -> Patchwork_109133v2

Re: [Intel-gfx] [PATCH 07/16] drm/i915/vm_bind: Add support to handle object evictions

2022-09-29 Thread Matthew Auld
On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: Support eviction by maintaining a list of evicted persistent vmas for rebinding during next submission. Ensure the list do not include persistent vmas that are being purged. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti

[Intel-gfx] [PATCH v4 26/30] drm/vc4: vec: Use TV Reset implementation

2022-09-29 Thread Maxime Ripard
The analog TV properties created by the drm_mode_create_tv_properties() are not properly initialised at reset. Let's switch our implementation to call drm_atomic_helper_connector_tv_reset(). Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_vec.c | 8 +++-

[Intel-gfx] [PATCH v4 19/30] drm/connector: Add a function to lookup a TV mode by its name

2022-09-29 Thread Maxime Ripard
As part of the command line parsing rework coming in the next patches, we'll need to lookup drm_connector_tv_mode values by their name, already defined in drm_tv_mode_enum_list. In order to avoid any code duplication, let's do a function that will perform a lookup of a TV mode name and return its

[Intel-gfx] [PATCH v4 28/30] drm/vc4: vec: Convert to the new TV mode property

2022-09-29 Thread Maxime Ripard
Now that the core can deal fine with analog TV modes, let's convert the vc4 VEC driver to leverage those new features. We've added some backward compatibility to support the old TV mode property and translate it into the new TV norm property. We're also making use of the new analog TV

[Intel-gfx] [PATCH v4 29/30] drm/vc4: vec: Add support for more analog TV standards

2022-09-29 Thread Maxime Ripard
From: Mateusz Kwiatkowski Add support for the following composite output modes (all of them are somewhat more obscure than the previously defined ones): - NTSC_443 - NTSC-style signal with the chroma subcarrier shifted to 4.43361875 MHz (the PAL subcarrier frequency). Never used for

[Intel-gfx] [PATCH v4 20/30] drm/modes: Introduce the tv_mode property as a command-line option

2022-09-29 Thread Maxime Ripard
Our new tv mode option allows to specify the TV mode from a property. However, it can still be useful, for example to avoid any boot time artifact, to set that property directly from the kernel command line. Let's add some code to allow it, and some unit tests to exercise that code.

[Intel-gfx] [PATCH v4 21/30] drm/modes: Properly generate a drm_display_mode from a named mode

2022-09-29 Thread Maxime Ripard
The framework will get the drm_display_mode from the drm_cmdline_mode it got by parsing the video command line argument by calling drm_connector_pick_cmdline_mode(). The heavy lifting will then be done by the drm_mode_create_from_cmdline_mode() function. In the case of the named modes though,

[Intel-gfx] [PATCH v4 17/30] drm/modes: Fill drm_cmdline mode from named modes

2022-09-29 Thread Maxime Ripard
The current code to deal with named modes will only set the mode name, and then it's up to drivers to try to match that name to whatever mode or configuration they see fit. The plan is to remove that need and move the named mode handling out of drivers and into the core, and only rely on modes

Re: [Intel-gfx] [PATCH] drm/i915: Fix CFI violations in gt_sysfs

2022-09-29 Thread Nathan Chancellor
On Thu, Sep 29, 2022 at 06:46:34PM +0200, Andi Shyti wrote: > Hi Nathan, > > thanks for this refactoring... looks good even though i would > have split it in more patches as this is doing quite many things. Right, sorry about that :/ I initially thought the problem was much simpler and the diff

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/mtl: Add C10 support

2022-09-29 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add C10 support URL : https://patchwork.freedesktop.org/series/109241/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: enable local stolen memory (rev5)

2022-09-29 Thread Patchwork
== Series Details == Series: drm/i915/mtl: enable local stolen memory (rev5) URL : https://patchwork.freedesktop.org/series/109066/ State : warning == Summary == Error: dim checkpatch failed 7e639baeef13 drm/i915/mtl: enable local stolen memory -:230: CHECK:MACRO_ARG_REUSE: Macro argument

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: enable local stolen memory (rev5)

2022-09-29 Thread Patchwork
== Series Details == Series: drm/i915/mtl: enable local stolen memory (rev5) URL : https://patchwork.freedesktop.org/series/109066/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH] drm/i915: Fix CFI violations in gt_sysfs

2022-09-29 Thread Nathan Chancellor
On Fri, Sep 30, 2022 at 12:34:41AM +0200, Andrzej Hajda wrote: > On 22.09.2022 21:51, Nathan Chancellor wrote: > > When booting with clang's kernel control flow integrity series [1], > > there are numerous violations when accessing the files under > >

Re: [Intel-gfx] [PATCH v4 15/15] vfio: Add struct device to vfio_device

2022-09-29 Thread Tian, Kevin
> From: Alex Williamson > Sent: Friday, September 30, 2022 2:24 AM > > On Thu, 29 Sep 2022 14:49:56 -0300 > Jason Gunthorpe wrote: > > > On Thu, Sep 29, 2022 at 10:55:19AM -0600, Alex Williamson wrote: > > > Hi Kevin, > > > > > > This introduced the regression discovered here: > > > > > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for Fix Guc-Err-Capture sizing warning

2022-09-29 Thread Patchwork
== Series Details == Series: Fix Guc-Err-Capture sizing warning URL : https://patchwork.freedesktop.org/series/109276/ State : success == Summary == CI Bug Log - changes from CI_DRM_12202 -> Patchwork_109276v1 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Fix CFI violations in gt_sysfs

2022-09-29 Thread Andrzej Hajda
On 22.09.2022 21:51, Nathan Chancellor wrote: When booting with clang's kernel control flow integrity series [1], there are numerous violations when accessing the files under /sys/devices/pci:00/:00:02.0/drm/card0/gt/gt0: $ cd /sys/devices/pci:00/:00:02.0/drm/card0/gt/gt0

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add HWMON support (rev8)

2022-09-29 Thread Patchwork
== Series Details == Series: drm/i915: Add HWMON support (rev8) URL : https://patchwork.freedesktop.org/series/104278/ State : success == Summary == CI Bug Log - changes from CI_DRM_12185_full -> Patchwork_104278v8_full Summary ---

[Intel-gfx] [PATCH 3/3] drm/i915/gt: Fix platform prefix

2022-09-29 Thread Lucas De Marchi
Different handling for XeHP and later platforms should be using the xehp prefix, not gen125. Rename them. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 24 +-- drivers/gpu/drm/i915/gt/gen8_engine_cs.h | 12 +-

[Intel-gfx] [PATCH 1/3] drm/i915: Fix __gen125_emit_bb_start() without WA

2022-09-29 Thread Lucas De Marchi
ce->wa_bb_page is allocated only for graphics version 12. However __gen125_emit_bb_start() is used for any graphics version >= 12.50. For the currently supported platforms this is not an issue, but for future ones there's a mismatch causing the jump to `wa_offset + DG2_PREDICATE_RESULT_BB` to be

[Intel-gfx] [PATCH 0/3] drm/i915: Improve register state context init

2022-09-29 Thread Lucas De Marchi
Some small improvements to future-proof the initialization around the register state context. Lucas De Marchi (3): drm/i915: Fix __gen125_emit_bb_start() without WA drm/i915/gt: Document function to decode register state context drm/i915/gt: Fix platform prefix

[Intel-gfx] [PATCH 2/3] drm/i915/gt: Document function to decode register state context

2022-09-29 Thread Lucas De Marchi
It's no obviously clear how the encode/decode of the per platform tables is done. Document it so while adding tables for new platforms people can be confident they right things is being done. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/intel_lrc.c | 24 1

Re: [Intel-gfx] [PATCH v4 3/4] drm/i915: Make the heartbeat play nice with long pre-emption timeouts

2022-09-29 Thread John Harrison
On 9/29/2022 00:42, Tvrtko Ursulin wrote: On 29/09/2022 03:18, john.c.harri...@intel.com wrote: From: John Harrison Compute workloads are inherently not pre-emptible for long periods on current hardware. As a workaround for this, the pre-emption timeout for compute capable engines was

[Intel-gfx] [PATCH v4 24/30] drm/atomic-helper: Add an analog TV atomic_check implementation

2022-09-29 Thread Maxime Ripard
The analog TV connector drivers share some atomic_check logic, and the new TV standard property have created some boilerplate that can be be shared across drivers too. Let's create an atomic_check helper for those use cases. Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard ---

[Intel-gfx] [PATCH v4 27/30] drm/vc4: vec: Check for VEC output constraints

2022-09-29 Thread Maxime Ripard
From: Mateusz Kwiatkowski The VEC can accept pretty much any relatively reasonable mode, but still has a bunch of constraints to meet. Let's create an atomic_check() implementation that will make sure we don't end up accepting a non-functional mode. Acked-by: Noralf Trønnes Signed-off-by:

[Intel-gfx] [PATCH v4 30/30] drm/sun4i: tv: Convert to the new TV mode property

2022-09-29 Thread Maxime Ripard
Now that the core can deal fine with analog TV modes, let's convert the sun4i TV driver to leverage those new features. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun4i_tv.c | 148 ++- drivers/gpu/drm/vc4/vc4_vec.c| 5 +- 2 files changed, 54

[Intel-gfx] [PATCH v4 22/30] drm/modes: Introduce more named modes

2022-09-29 Thread Maxime Ripard
Now that we can easily extend the named modes list, let's add a few more analog TV modes that were used in the wild, and some unit tests to make sure it works as intended. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_modes.c | 2 +

[Intel-gfx] [PATCH v4 23/30] drm/atomic-helper: Add a TV properties reset helper

2022-09-29 Thread Maxime Ripard
The drm_tv_create_properties() function will create a bunch of properties, but it's up to each and every driver using that function to properly reset the state of these properties leading to inconsistent behaviours. Let's create a helper that will take care of it. Reviewed-by: Noralf Trønnes

[Intel-gfx] [PATCH v4 16/30] drm/modes: Switch to named mode descriptors

2022-09-29 Thread Maxime Ripard
The current named mode parsing relies only the mode name, and doesn't allow to specify any other parameter. Let's convert that string list to an array of a custom structure that will hold the name and some additional parameters in the future. Signed-off-by: Maxime Ripard ---

[Intel-gfx] [PATCH v4 25/30] drm/vc4: vec: Fix definition of PAL-M mode

2022-09-29 Thread Maxime Ripard
From: Mateusz Kwiatkowski PAL-M is a Brazilian analog TV standard that uses a PAL-style chroma subcarrier at 3.575611[888111] MHz on top of 525-line (480i60) timings. This commit makes the driver actually use the proper VEC preset for this mode instead of just changing PAL subcarrier frequency.

[Intel-gfx] ✓ Fi.CI.IGT: success for iommu: Remove iova cpu hotplugging flushing (rev2)

2022-09-29 Thread Patchwork
== Series Details == Series: iommu: Remove iova cpu hotplugging flushing (rev2) URL : https://patchwork.freedesktop.org/series/108880/ State : success == Summary == CI Bug Log - changes from CI_DRM_12193_full -> Patchwork_108880v2_full

Re: [Intel-gfx] [PATCH 04/16] drm/i915/vm_bind: Add support to create persistent vma

2022-09-29 Thread Matthew Auld
On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: Add i915_vma_instance_persistent() to create persistent vmas. Persistent vmas will use i915_gtt_view to support partial binding. vma_lookup is tied to segment of the object instead of section of VA space. Hence, it do not support aliasing.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: Add C10 phy support

2022-09-29 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add C10 phy support URL : https://patchwork.freedesktop.org/series/109248/ State : warning == Summary == Error: dim checkpatch failed 7a245d0165a3 drm/i915/mtl: Add Support for C10, C20 PHY Message Bus Traceback (most recent call last): File

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call

2022-09-29 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Friday, September 30, 2022 1:49 AM > > When converting to directly create the vfio_device the mdev driver has to > put a vfio_register_emulated_iommu_dev() in the probe() and a pairing > vfio_unregister_group_dev() in the remove. > > This was missed for gvt, add

[Intel-gfx] [PATCH 1/1] drm/i915/guc: Fix GuC error capture sizing estimation and reporting

2022-09-29 Thread Alan Previn
During GuC error capture initialization, we estimate the amount of size we need for the error-capture-region of the shared GuC-log-buffer. This calculation was incorrect so fix that. Additionally, if the size was insufficient, don't drm_warn or drm_notice, just drm_debug since actually running out

[Intel-gfx] ✓ Fi.CI.IGT: success for Improve anti-pre-emption w/a for compute workloads (rev7)

2022-09-29 Thread Patchwork
== Series Details == Series: Improve anti-pre-emption w/a for compute workloads (rev7) URL : https://patchwork.freedesktop.org/series/100428/ State : success == Summary == CI Bug Log - changes from CI_DRM_12197_full -> Patchwork_100428v7_full

Re: [Intel-gfx] [PATCH v4.1] drm/i915/mtl: Define engine context layouts

2022-09-29 Thread Lucas De Marchi
On Wed, Sep 28, 2022 at 08:55:11AM -0700, Radhakrishna Sripada wrote: From: Matt Roper The part of the media and blitter engine contexts that we care about for setting up an initial state on MTL are nearly similar to DG2 (and PVC). The difference being PRT_BB_STATE being replaced with NOP.

[Intel-gfx] ✓ Fi.CI.IGT: success for Move all drivers to a common dma-buf locking convention

2022-09-29 Thread Patchwork
== Series Details == Series: Move all drivers to a common dma-buf locking convention URL : https://patchwork.freedesktop.org/series/109205/ State : success == Summary == CI Bug Log - changes from CI_DRM_12197_full -> Patchwork_109205v1_full

[Intel-gfx] [PATCH 0/1] Fix Guc-Err-Capture sizing warning

2022-09-29 Thread Alan Previn
GuC Error capture initialization calculates an estimation buffer size for worst case scenario of all engines getting reset. Fix the calculation change from drm_warn to drm_dbg since its a corner case Alan Previn (1): drm/i915/guc: Fix GuC error capture sizing estimation and reporting

Re: [Intel-gfx] [PATCH] drm/i915/guc: do not capture error state on exiting context

2022-09-29 Thread Tvrtko Ursulin
On 29/09/2022 10:49, Andrzej Hajda wrote: On 29.09.2022 10:22, Tvrtko Ursulin wrote: On 28/09/2022 19:27, John Harrison wrote: On 9/28/2022 00:19, Tvrtko Ursulin wrote: On 27/09/2022 22:36, Ceraolo Spurio, Daniele wrote: On 9/27/2022 12:45 AM, Tvrtko Ursulin wrote: On 27/09/2022 07:49,

Re: [Intel-gfx] [PATCH 05/16] drm/i915/vm_bind: Implement bind and unbind of object

2022-09-29 Thread Matthew Auld
On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: Add uapi and implement support for bind and unbind of an object at the specified GPU virtual addresses. The vm_bind mode is not supported in legacy execbuf2 ioctl. It will be supported only in the newer execbuf3 ioctl. Signed-off-by:

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload

2022-09-29 Thread Andi Shyti
Hi Nirmoy, On Fri, Sep 23, 2022 at 09:35:14AM +0200, Nirmoy Das wrote: > i915_gem_drain_freed_objects() might not be enough to > free all the objects and RCU delayed work might get > scheduled after the i915 device struct gets freed. > > Call i915_gem_drain_workqueue() to catch all RCU delayed

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload

2022-09-29 Thread Das, Nirmoy
On 9/29/2022 1:32 PM, Andi Shyti wrote: Hi Nirmoy, On Fri, Sep 23, 2022 at 09:35:14AM +0200, Nirmoy Das wrote: i915_gem_drain_freed_objects() might not be enough to free all the objects and RCU delayed work might get scheduled after the i915 device struct gets freed. Call

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Change glk_load_degamma_lut() calling convention

2022-09-29 Thread Jani Nikula
On Thu, 29 Sep 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Make glk_load_degamma_lut() more like most everyone else and > pass in the LUT explicitly. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_color.c | 17 ++---

  1   2   >