Re: [Intel-gfx] [PATCH v10 0/2] drm/i915: Allow user to set cache at BO creation

2023-05-24 Thread Andi Shyti
Hi again, > > > finally... pushed in drm-intel-gt-next! :) > > > > I had to revert this (uapi commit only) by force pushing, luckily it was the > > top commit. > > OK, sorry! > > > 1) > > IGT is not merged yet. > > if igt is merged without the kernel it would fail, though. can we at least

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: add a dedicated workqueue inside drm_i915_private

2023-05-24 Thread Coelho, Luciano
On Wed, 2023-05-24 at 12:00 +0100, Tvrtko Ursulin wrote: > On 24/05/2023 10:05, Luca Coelho wrote: > > In order to avoid flush_scheduled_work() usage, add a dedicated > > workqueue in the drm_i915_private structure. In this way, we don't > > need to use the system queue anymore. > > > > This

Re: [Intel-gfx] [PATCH v10 0/2] drm/i915: Allow user to set cache at BO creation

2023-05-24 Thread Andi Shyti
Hi Tvrtko, > > finally... pushed in drm-intel-gt-next! :) > > I had to revert this (uapi commit only) by force pushing, luckily it was the > top commit. OK, sorry! > 1) > IGT is not merged yet. if igt is merged without the kernel it would fail, though. > 2) > The

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/perf: Clear out entire reports after reading if not power of 2 size (rev3)

2023-05-24 Thread Patchwork
== Series Details == Series: drm/i915/perf: Clear out entire reports after reading if not power of 2 size (rev3) URL : https://patchwork.freedesktop.org/series/118151/ State : success == Summary == CI Bug Log - changes from CI_DRM_13180_full -> Patchwork_118151v3_full

Re: [Intel-gfx] [PATCH v10 0/2] drm/i915: Allow user to set cache at BO creation

2023-05-24 Thread Tvrtko Ursulin
On 24/05/2023 12:56, Tvrtko Ursulin wrote: On 23/05/2023 09:37, Andi Shyti wrote: Hi Fei, finally... pushed in drm-intel-gt-next! :) I had to revert this (uapi commit only) by force pushing, luckily it was the top commit. 1) IGT is not merged yet. 2) The

Re: [Intel-gfx] [PATCH v10 0/2] drm/i915: Allow user to set cache at BO creation

2023-05-24 Thread Tvrtko Ursulin
On 23/05/2023 09:37, Andi Shyti wrote: Hi Fei, finally... pushed in drm-intel-gt-next! :) I had to revert this (uapi commit only) by force pushing, luckily it was the top commit. 1) IGT is not merged yet. 2) The tools/include/uapi/drm/i915_drm.h part of the patch was not removed.

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Make PMU sample array two-dimensional

2023-05-24 Thread Tvrtko Ursulin
On 23/05/2023 16:19, Ashutosh Dixit wrote: No functional changes but we can remove some unsightly index computation and read/write functions if we convert the PMU sample array from a one-dimensional to a two-dimensional array. Suggested-by: Tvrtko Ursulin Signed-off-by: Ashutosh Dixit ---

Re: [Intel-gfx] [PATCH] drm/i915:fix kernel-doc trivial warnings

2023-05-24 Thread Jani Nikula
On Wed, 24 May 2023, pengfuyuan wrote: > The test robot reports some make warnings. > > Fix those warnings: > drivers/gpu/drm/i915/i915_gpu_error.c:2174: warning: Function parameter > or member 'dump_flags' not described in 'i915_capture_error_state' >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: implement internal workqueues (rev2)

2023-05-24 Thread Patchwork
== Series Details == Series: drm/i915: implement internal workqueues (rev2) URL : https://patchwork.freedesktop.org/series/117618/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13181 -> Patchwork_117618v2 Summary ---

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: add a dedicated workqueue inside drm_i915_private

2023-05-24 Thread Tvrtko Ursulin
On 24/05/2023 12:00, Tvrtko Ursulin wrote: On 24/05/2023 10:05, Luca Coelho wrote: 8<   if (pool_free_older_than(pool, HZ)) -    schedule_delayed_work(>work, -  round_jiffies_up_relative(HZ)); +    queue_delayed_work(gt->i915->unordered_wq, >work, + 

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: implement internal workqueues (rev2)

2023-05-24 Thread Patchwork
== Series Details == Series: drm/i915: implement internal workqueues (rev2) URL : https://patchwork.freedesktop.org/series/117618/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: implement internal workqueues (rev2)

2023-05-24 Thread Patchwork
== Series Details == Series: drm/i915: implement internal workqueues (rev2) URL : https://patchwork.freedesktop.org/series/117618/ State : warning == Summary == Error: dim checkpatch failed e66f4bf055e1 drm/i915: use pointer to i915 instead of rpm in wakeref 9367ad3a84f8 drm/i915: add a

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/selftests: add local workqueue for SW fence selftest

2023-05-24 Thread Tvrtko Ursulin
On 24/05/2023 10:05, Luca Coelho wrote: Instead of using a global workqueue for the SW fence selftest, allocate a separate one temporarily only while running the test. Cc: Tetsuo Handa Cc: Tvrtko Ursulin Cc: Jani Nikula Cc: Ville Syrjälä Signed-off-by: Luca Coelho ---

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: add a dedicated workqueue inside drm_i915_private

2023-05-24 Thread Tvrtko Ursulin
On 24/05/2023 10:05, Luca Coelho wrote: In order to avoid flush_scheduled_work() usage, add a dedicated workqueue in the drm_i915_private structure. In this way, we don't need to use the system queue anymore. This change is mostly mechanical and based on Tetsuo's original patch[1]. Link:

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: use pointer to i915 instead of rpm in wakeref

2023-05-24 Thread Tvrtko Ursulin
On 24/05/2023 10:05, Luca Coelho wrote: Currently a pointer to an intel_runtime_pm structure is stored in the wake reference structures so the runtime data can be accessed. We can save the entire device information (drm_i915_private) instead, since we'll need to reference the new workqueue

[Intel-gfx] [PATCH v4 12/13] drm/fbdev-generic: Implement dedicated fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Implement dedicated fbdev helpers for framebuffer I/O instead of using DRM's helpers. Use an fbdev generator macro for deferred I/O to create the callbacks. Fbdev-generic was the only caller of the DRM helpers, so remove them from the helper module. v4: * generate deferred-I/O helpers

[Intel-gfx] [PATCH v4 08/13] drm/msm: Use regular fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Msm does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirely.

[Intel-gfx] [PATCH v4 03/13] drm/armada: Use regular fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Armada does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions

[Intel-gfx] [PATCH v4 11/13] drm/fb-helper: Export helpers for marking damage areas

2023-05-24 Thread Thomas Zimmermann
Export drm_fb_helper_damage() and drm_fb_helper_damage_range(), which handle damage areas for fbdev emulation. This is a temporary export that allows to move the DRM I/O helpers for fbdev into drivers. Only fbdev-generic and i915 need them. Both will be updated to implement damage handling by

[Intel-gfx] [PATCH v4 07/13] drm/fbdev-dma: Use regular fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Fbdev-dma does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions

[Intel-gfx] [PATCH v4 06/13] drm/radeon: Use regular fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Radeon does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions

[Intel-gfx] [PATCH v4 10/13] drm/tegra: Use regular fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Tegra does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions

[Intel-gfx] [PATCH v4 00/13] drm/fbdev: Remove DRM's helpers for fbdev I/O

2023-05-24 Thread Thomas Zimmermann
DRM provides a number of wrappers around fbdev cfb_() sys_(), fb_io_() and fb_sys_() helpers. The DRM functions don't provide any additional functionality for most DRM drivers. So remove them and call the fbdev I/O helpers directly. The DRM fbdev I/O wrappers were originally added because does

[Intel-gfx] [PATCH v4 04/13] drm/exynos: Use regular fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Exynos does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions

[Intel-gfx] [PATCH v4 13/13] drm/i915: Implement dedicated fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Implement dedicated fbdev helpers for framebuffer I/O instead of using DRM's helpers. Use an fbdev generator macro for deferred I/O to create the fbdev callbacks. i915 was the only caller of the DRM helpers, so remove them from the helper module. i915's fbdev emulation is still incomplete as it

[Intel-gfx] [PATCH v4 09/13] drm/omapdrm: Use regular fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Omapdrm does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions

[Intel-gfx] [PATCH v4 01/13] fbdev: Add Kconfig options to select different fb_ops helpers

2023-05-24 Thread Thomas Zimmermann
Many fbdev drivers use the same set of fb_ops helpers. Add Kconfig options to select them at once. This will help with making DRM's fbdev emulation code more modular, but can also be used to simplify fbdev's driver configs. v3: * fix select statement (Jingfeng) Signed-off-by: Thomas

[Intel-gfx] [PATCH v4 02/13] fbdev: Add initializer macros for struct fb_ops

2023-05-24 Thread Thomas Zimmermann
For framebuffers in I/O and system memory, add macros that set struct fb_ops to the respective callback functions. For deferred I/O, add macros that generate callback functions with damage handling. Add initializer macros that set struct fb_ops to the generated callbacks. These macros can remove

[Intel-gfx] [PATCH v4 05/13] drm/gma500: Use regular fbdev I/O helpers

2023-05-24 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Gma500 does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Make PMU sample array two-dimensional

2023-05-24 Thread Andrzej Hajda
On 23.05.2023 17:19, Ashutosh Dixit wrote: No functional changes but we can remove some unsightly index computation and read/write functions if we convert the PMU sample array from a one-dimensional to a two-dimensional array. Suggested-by: Tvrtko Ursulin Signed-off-by: Ashutosh Dixit

Re: [Intel-gfx] [PATCH 1/2] drm/i915/pmu: Turn off the timer to sample frequencies when GT is parked

2023-05-24 Thread Andrzej Hajda
On 23.05.2023 17:19, Ashutosh Dixit wrote: pmu_needs_timer() keeps the timer running even when GT is parked, ostensibly to sample requested/actual frequencies. However frequency_sample() has the following: /* Report 0/0 (actual/requested) frequency while parked. */ if

[Intel-gfx] [PATCH v2 3/3] drm/i915/selftests: add local workqueue for SW fence selftest

2023-05-24 Thread Luca Coelho
Instead of using a global workqueue for the SW fence selftest, allocate a separate one temporarily only while running the test. Cc: Tetsuo Handa Cc: Tvrtko Ursulin Cc: Jani Nikula Cc: Ville Syrjälä Signed-off-by: Luca Coelho --- drivers/gpu/drm/i915/selftests/i915_sw_fence.c | 16

[Intel-gfx] [PATCH v2 0/3] drm/i915: implement internal workqueues

2023-05-24 Thread Luca Coelho
Hi, This series implements internal workqueues in the i915 driver in order to avoid using the system queue. We add one generic workqueue in the drm_i915_private structure, one specific for wake references and one in a self-test. This is based on Tetsuo's work[1] and is required to get rid of

[Intel-gfx] [PATCH v2 1/3] drm/i915: use pointer to i915 instead of rpm in wakeref

2023-05-24 Thread Luca Coelho
Currently a pointer to an intel_runtime_pm structure is stored in the wake reference structures so the runtime data can be accessed. We can save the entire device information (drm_i915_private) instead, since we'll need to reference the new workqueue we'll add in subsequent patches. Cc: Tvrtko

[Intel-gfx] [PATCH v2 2/3] drm/i915: add a dedicated workqueue inside drm_i915_private

2023-05-24 Thread Luca Coelho
In order to avoid flush_scheduled_work() usage, add a dedicated workqueue in the drm_i915_private structure. In this way, we don't need to use the system queue anymore. This change is mostly mechanical and based on Tetsuo's original patch[1]. Link:

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Add vfio_device cdev for iommufd support (rev14)

2023-05-24 Thread Patchwork
== Series Details == Series: Add vfio_device cdev for iommufd support (rev14) URL : https://patchwork.freedesktop.org/series/113696/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/113696/revisions/14/mbox/ not applied Applying: vfio: Allocate per

Re: [Intel-gfx] [PATCH v11 19/23] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-05-24 Thread Liu, Yi L
> From: Liu, Yi L > Sent: Wednesday, May 24, 2023 10:41 AM > > > From: Tian, Kevin > > Sent: Wednesday, May 24, 2023 10:39 AM > > > > > From: Liu, Yi L > > > Sent: Wednesday, May 24, 2023 10:21 AM > > > > > > > > > > > > > vfio_device_open_file() > > > > > { > > > > >

Re: [Intel-gfx] [PATCH v11 21/23] vfio: Determine noiommu device in __vfio_register_dev()

2023-05-24 Thread Liu, Yi L
Hi Alex, I've two new patches to address the comment in this patch. If it makes sense then I'll put them in cdev v12. > From: Liu, Yi L > Sent: Tuesday, May 23, 2023 10:13 AM > > > From: Alex Williamson > > Sent: Tuesday, May 23, 2023 7:04 AM > > > > On Sat, 13 May 2023 06:28:25 -0700 > > Yi

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pmu: couple of cleanups

2023-05-24 Thread Patchwork
== Series Details == Series: drm/i915/pmu: couple of cleanups URL : https://patchwork.freedesktop.org/series/118225/ State : success == Summary == CI Bug Log - changes from CI_DRM_13177_full -> Patchwork_118225v1_full Summary ---

Re: [Intel-gfx] [PATCH v6 2/7] drm/i915: update the QGV point frequency calculations

2023-05-24 Thread Govindapillai, Vinod
On Tue, 2023-05-23 at 16:14 +0300, Jani Nikula wrote: > On Tue, 23 May 2023, "Govindapillai, Vinod" > wrote: > > On Tue, 2023-05-23 at 12:01 +0300, Jani Nikula wrote: > > > On Tue, 23 May 2023, Vinod Govindapillai > > > wrote: > > > > From MTL onwwards, pcode locks the QGV point based on peak

<    1   2