Re: [Intel-gfx] [PATCH v9 4/8] drm/i915/vdsc: Add function to read any PPS register

2023-08-23 Thread Nautiyal, Ankit K
On 8/22/2023 11:32 AM, Suraj Kandpal wrote: Add function to read any PPS register based on the intel_dsc_pps enum provided. Add a function which will call the new pps read function and place it in crtc state. Only PPS0 and PPS1 are readout the rest of the registers will be read in upcoming

[Intel-gfx] ✓ Fi.CI.IGT: success for Add DSC PPS readout (rev9)

2023-08-23 Thread Patchwork
== Series Details == Series: Add DSC PPS readout (rev9) URL : https://patchwork.freedesktop.org/series/120456/ State : success == Summary == CI Bug Log - changes from CI_DRM_13542_full -> Patchwork_120456v9_full Summary ---

[Intel-gfx] [PATCH v2 0/4] HDCP MST aux issue fix

2023-08-23 Thread Suraj Kandpal
Up until now all dp hdcp specific function derived the aux from dig_port which gave the aux of the primary port but with DPMST when a MST hub comes into picture the monitor becomes remote and what we need is a corresponding aux which is also remote. These set of patches aim to fix up just that.

[Intel-gfx] [PATCH v2 1/4] drm/i915/hdcp: Use intel_connector argument in intel_hdcp_shim

2023-08-23 Thread Suraj Kandpal
Update intel_hdcp_shim funcs specifically read_2_2_message, write_2_2_message and config_stream_type to use intel_connector argument instead of intel_digital_port as this will help in getting correct aux later for dp mst scenarios also already hdcp funcs derive digital_port from connector and then

[Intel-gfx] [PATCH v2 2/4] drm/i915/hdcp: Propagate aux info in DP HDCP functions

2023-08-23 Thread Suraj Kandpal
We were propagating dig_port info to dp hdcp2 specific functions. Let us clean that up and send intel_connector in the following functions: intel_dp_hdcp2_wait_for_msg, get_receiver_id_list_rx_info, intel_dp_hdcp2_read_rx_status. This optimises mst scenarios where aux ends up being remote and not

[Intel-gfx] [PATCH v2 3/4] drm/i915/hdcp: Send the correct aux for DPMST HDCP scenario

2023-08-23 Thread Suraj Kandpal
Up until now we were sending the base aux stored in dig_port which is not correct as this causes an issue when monitor is connected via a DPMST hub causing it to be remote hence we end up seeing AUX failures so let's send the remote aux in case of DPMST. Signed-off-by: Suraj Kandpal Reviewed-by:

[Intel-gfx] [PATCH v2 4/4] drm/i915/hdcp: Adjust timeout for read in DPMST Scenario

2023-08-23 Thread Suraj Kandpal
For dpmst hdcp scenario increase the message timeout based on the number of ports connected as each port needs to be validated and each will take the prescribed amount of time for the respective msg_id and total timeout will be original_timeout * num_ports. --v2 -Add justification for Adjusting

[Intel-gfx] [PATCH 0/2] eDP DSC fixes

2023-08-23 Thread Ankit Nautiyal
Assume 8bpc is supported if Sink claims DSC support. Also consider bpc constraint coming from EDID while computing input BPC for DSC. Ankit Nautiyal (2): drm/display/dp: Default 8 bpc support when DSC is supported drivers/drm/i915: Honor limits->max_bpp while computing DSC max input bpp

[Intel-gfx] [PATCH 1/2] drm/display/dp: Default 8 bpc support when DSC is supported

2023-08-23 Thread Ankit Nautiyal
As per DP v1.4, a DP DSC Sink device shall support 8bpc in DPCD 6Ah. Apparently some panels that do support DSC, are not setting the bit for 8bpc. So always assume 8bpc support by DSC decoder, when DSC is claimed to be supported. Signed-off-by: Ankit Nautiyal ---

[Intel-gfx] [PATCH 2/2] drivers/drm/i915: Honor limits->max_bpp while computing DSC max input bpp

2023-08-23 Thread Ankit Nautiyal
Edid specific BPC constraints are stored in limits->max_bpp. Honor these limits while computing the input bpp for DSC. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/mtl: Adding DeviceID for Arrowlake-S under MTL

2023-08-23 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Adding DeviceID for Arrowlake-S under MTL URL : https://patchwork.freedesktop.org/series/122754/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13549_full -> Patchwork_122754v1_full

Re: [Intel-gfx] [PATCH] drm/i915/vma: constify unbind_fence_ops

2023-08-23 Thread Hogander, Jouni
On Fri, 2023-08-18 at 14:27 +0300, Jani Nikula wrote: > unbind_fence_ops can be const and placed in rodata. > > Signed-off-by: Jani Nikula Reviewed-by: Jouni Högander > --- >  drivers/gpu/drm/i915/i915_vma_resource.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add DSC PPS readout (rev10)

2023-08-23 Thread Patchwork
== Series Details == Series: Add DSC PPS readout (rev10) URL : https://patchwork.freedesktop.org/series/120456/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add DSC PPS readout (rev10)

2023-08-23 Thread Patchwork
== Series Details == Series: Add DSC PPS readout (rev10) URL : https://patchwork.freedesktop.org/series/120456/ State : warning == Summary == Error: dim sparse failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDCP MST aux issue fix (rev3)

2023-08-23 Thread Patchwork
== Series Details == Series: HDCP MST aux issue fix (rev3) URL : https://patchwork.freedesktop.org/series/122267/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for HDCP MST aux issue fix (rev3)

2023-08-23 Thread Patchwork
== Series Details == Series: HDCP MST aux issue fix (rev3) URL : https://patchwork.freedesktop.org/series/122267/ State : warning == Summary == Error: dim sparse failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

Re: [Intel-gfx] [PATCH 1/3] drm/buddy: Fix contiguous memory allocation issues

2023-08-23 Thread Arunpravin Paneer Selvam
On 22/08/23 22:52, Christian König wrote: Am 21.08.23 um 13:16 schrieb Christian König: Am 21.08.23 um 12:14 schrieb Arunpravin Paneer Selvam: The way now contiguous requests are implemented such that the size rounded up to power of 2 and the corresponding order block picked from the

[Intel-gfx] ✓ Fi.CI.BAT: success for HDCP MST aux issue fix (rev3)

2023-08-23 Thread Patchwork
== Series Details == Series: HDCP MST aux issue fix (rev3) URL : https://patchwork.freedesktop.org/series/122267/ State : success == Summary == CI Bug Log - changes from CI_DRM_13549 -> Patchwork_122267v3 Summary --- **SUCCESS**

[Intel-gfx] [PATCH v10 4/8] drm/i915/vdsc: Add function to read any PPS register

2023-08-23 Thread Suraj Kandpal
Add function to read any PPS register based on the intel_dsc_pps enum provided. Add a function which will call the new pps read function and place it in crtc state. Only PPS0 and PPS1 are readout the rest of the registers will be read in upcoming patches. --v2 -Changes in read function as PPS

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-08-23 Thread Jani Nikula
On Tue, 22 Aug 2023, Alex Hung wrote: > On 2023-08-22 06:01, Jani Nikula wrote: >> Over the past years I've been trying to unify the override and firmware >> EDID handling as well as EDID property updates. It won't work if drivers >> do their own random things. > Let's check how to replace these

[Intel-gfx] ✓ Fi.CI.IGT: success for drivers: gpu: drm: i915: intel_huc: fix formatting warnings

2023-08-23 Thread Patchwork
== Series Details == Series: drivers: gpu: drm: i915: intel_huc: fix formatting warnings URL : https://patchwork.freedesktop.org/series/122746/ State : success == Summary == CI Bug Log - changes from CI_DRM_13549_full -> Patchwork_122746v1_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add DSC PPS readout (rev11)

2023-08-23 Thread Patchwork
== Series Details == Series: Add DSC PPS readout (rev11) URL : https://patchwork.freedesktop.org/series/120456/ State : warning == Summary == Error: dim sparse failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

Re: [Intel-gfx] [PATCH v11 4/8] drm/i915/vdsc: Add function to read any PPS register

2023-08-23 Thread Jani Nikula
On Wed, 23 Aug 2023, Suraj Kandpal wrote: > Add function to read any PPS register based on the > intel_dsc_pps enum provided. Add a function which will call the > new pps read function and place it in crtc state. Only PPS0 and > PPS1 are readout the rest of the registers will be read in upcoming

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/2] drm: Add an HPD poll helper to reschedule the poll work (rev2)

2023-08-23 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm: Add an HPD poll helper to reschedule the poll work (rev2) URL : https://patchwork.freedesktop.org/series/122736/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13549_full -> Patchwork_122736v2_full

[Intel-gfx] ✓ Fi.CI.BAT: success for Add DSC PPS readout (rev11)

2023-08-23 Thread Patchwork
== Series Details == Series: Add DSC PPS readout (rev11) URL : https://patchwork.freedesktop.org/series/120456/ State : success == Summary == CI Bug Log - changes from CI_DRM_13551 -> Patchwork_120456v11 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.IGT: failure for gpu: drm: i915: fix documentation style

2023-08-23 Thread Patchwork
== Series Details == Series: gpu: drm: i915: fix documentation style URL : https://patchwork.freedesktop.org/series/122747/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13549_full -> Patchwork_122747v1_full Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for Add DSC PPS readout (rev10)

2023-08-23 Thread Patchwork
== Series Details == Series: Add DSC PPS readout (rev10) URL : https://patchwork.freedesktop.org/series/120456/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13551 -> Patchwork_120456v10 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH v9 4/8] drm/i915/vdsc: Add function to read any PPS register

2023-08-23 Thread Jani Nikula
On Tue, 22 Aug 2023, Suraj Kandpal wrote: > Add function to read any PPS register based on the > intel_dsc_pps enum provided. Add a function which will call the > new pps read function and place it in crtc state. Only PPS0 and > PPS1 are readout the rest of the registers will be read in upcoming

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/amd/display: stop using drm_edid_override_connector_update() (rev2)

2023-08-23 Thread Patchwork
== Series Details == Series: drm/amd/display: stop using drm_edid_override_connector_update() (rev2) URL : https://patchwork.freedesktop.org/series/122739/ State : success == Summary == CI Bug Log - changes from CI_DRM_13549_full -> Patchwork_122739v2_full

[Intel-gfx] [PATCH v11 0/8] Add DSC PPS readout

2023-08-23 Thread Suraj Kandpal
Up until now we only verified one or two of the dsc pps params like bits_per_component and bits_per_pixel this patch series aim to readout almost all PPS param and get them compared. Along with that some work on making a common function to read and write PPS param regiters is also done. --v2

[Intel-gfx] [PATCH v11 3/8] drm/i915/vdsc: Add func to get no. of vdsc instances per pipe

2023-08-23 Thread Suraj Kandpal
We have a function that gets us the total of the vdsc engines being used but not the no. of vdsc instances being used by each pipe. --v6 -Change function to static --v7 -Shorten name to intel_dsc_get_vdsc_per_pipe Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal ---

[Intel-gfx] [PATCH v11 1/8] drm/i915/vdsc: Refactor dsc register field macro

2023-08-23 Thread Suraj Kandpal
This patch refactors dsc register related macros that prepares the values to be written in the register. The current bit shifting looks bad and going forward will not serve our purpose to readout dsc register field values the change was suggested by Jani Nikula. Cc: Jani Nikula Signed-off-by:

[Intel-gfx] [PATCH v11 2/8] drm/i915/vdsc: Add a check for dsc split cases

2023-08-23 Thread Suraj Kandpal
In intel_vdsc_get_config we only read the primary dsc engine register and not take into account if the other dsc engine is in use and if both registers have the same value or not this patche fixes that by adding a check. --v3 -Remove superfluos new line [Jani] -Fix register naming [Jani] --v5

[Intel-gfx] [PATCH v11 8/8] drm/i915/display: Compare the readout dsc pps params

2023-08-23 Thread Suraj Kandpal
With the dsc config being readout and filled in crtc_state add macros and use them to compare current and previous PPS param in DSC. --v2 -Remove version check [Jani] -Remove dupe macro for dsc pipe compare and use the existing ones [Jani] Signed-off-by: Suraj Kandpal Reviewed-by: Ankit

[Intel-gfx] [PATCH v11 6/8] drm/i915/vdsc: Remove unused dsc registers

2023-08-23 Thread Suraj Kandpal
Now that we have macros that can fetch dsc register values based on pipe and pps parameters we can go ahead and remove all the unused register. Signed-off-by: Suraj Kandpal Reviewed-by: Ankit Nautiyal --- .../gpu/drm/i915/display/intel_vdsc_regs.h| 251 ++ 1 file changed,

[Intel-gfx] [PATCH v11 4/8] drm/i915/vdsc: Add function to read any PPS register

2023-08-23 Thread Suraj Kandpal
Add function to read any PPS register based on the intel_dsc_pps enum provided. Add a function which will call the new pps read function and place it in crtc state. Only PPS0 and PPS1 are readout the rest of the registers will be read in upcoming patches. --v2 -Changes in read function as PPS

[Intel-gfx] [PATCH v11 5/8] drm/i915/vdsc: Add function to write in PPS register

2023-08-23 Thread Suraj Kandpal
Now that we have a function that reads any PPS register based on intel_dsc_pps enum provided lets create a function that can write on any PPS. --v2 -Changes need as PPS enum was dropped -Remove duplicated code in intel_dsc_write_pps_reg [Jani] --v3 -Use dsc_split instead of num_vdsc_instances

[Intel-gfx] [PATCH v11 7/8] drm/i915/vdsc: Fill the intel_dsc_get_pps_config function

2023-08-23 Thread Suraj Kandpal
We have setup both the read and write functions so we can move ahead and fill in all the readout state from PPS register into the crtc_state so we can send it for comparision. --v2 -Shorten comment to just PPSX rather than having the whole "Readout PPSX register" [Jani] -Remove pps_temp

Re: [Intel-gfx] [PATCH v6 3/4] drm: Expand max DRM device number to full MINORBITS

2023-08-23 Thread Simon Ser
On Tuesday, August 8th, 2023 at 17:04, James Zhu wrote: > I have a MR for libdrm to support drm nodes type up to 2^MINORBITS > nodes which can work with these patches, > > https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/305 FWIW, this MR has been merged, so in theory this kernel patch

Re: [Intel-gfx] [PATCH v6 3/4] drm: Expand max DRM device number to full MINORBITS

2023-08-23 Thread Simon Ser
On Wednesday, August 23rd, 2023 at 12:53, Simon Ser wrote: > On Tuesday, August 8th, 2023 at 17:04, James Zhu jam...@amd.com wrote: > > > I have a MR for libdrm to support drm nodes type up to 2^MINORBITS > > nodes which can work with these patches, > > > >

Re: [Intel-gfx] [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-23 Thread Daniel Vetter
On Tue, Aug 22, 2023 at 11:53:24AM -0700, John Harrison wrote: > On 8/11/2023 11:20, Zhanjun Dong wrote: > > This attempts to avoid circular locking dependency between flush delayed > > work and intel_gt_reset. > > When intel_gt_reset was called, task will hold a lock. > > To cacel delayed work

Re: [Intel-gfx] [Intel-xe] [PATCH 21/42] drm/i915/xe2lpd: Add display power well

2023-08-23 Thread Matt Roper
On Wed, Aug 23, 2023 at 10:07:19AM -0700, Lucas De Marchi wrote: > From: Ravi Kumar Vodapalli > > Add Display Power Well for LNL platform, mostly it is same as MTL > platform so reused the code > > Changes are: > 1. AUX_CH_CTL and AUX_CH_DATA1 are different from MTL so added extra >logic

[Intel-gfx] [PATCH 02/42] drm/i915/display: Remove unused POWER_DOMAIN_MASK

2023-08-23 Thread Lucas De Marchi
From: Gustavo Sousa That macro became unused with commit 323286c81245 ("drm/i915: Move the power domain->well mappings to intel_display_power_map.c"). Signed-off-by: Gustavo Sousa Reviewed-by: Matt Roper Signed-off-by: Matt Roper Link:

[Intel-gfx] [PATCH 00/42] Enable Lunar Lake display

2023-08-23 Thread Lucas De Marchi
Cross posting this to the i915 and xe mailing lists. The basic platform enabling for Lunar Lake is already applied in xe[1]. This patch series adds the display support, that will be driven by i915. A few notes from the series: 1. This is based on drm-xe-next branch since this is where it

[Intel-gfx] [PATCH 04/42] drm/i915: Simplify intel_cx0_program_phy_lane() with loop

2023-08-23 Thread Lucas De Marchi
From: Gustavo Sousa It is possible to generalize the "disable" value for the transmitters to be a bit mask based on the port width and the port reversal boolean, with a small exception for DP-alt mode with "x1" port width. Simplify the code by using such a mask and a for-loop instead of using

[Intel-gfx] [PATCH 07/42] drm/i915/tc: rename mtl_tc_port_get_pin_assignment_mask()

2023-08-23 Thread Lucas De Marchi
From: Luca Coelho This function doesn't really return the pin assignment mask, but the max lane count derived from that. So rename the function to mtl_tc_port_get_max_lane_count() to better reflect what it really does. Signed-off-by: Luca Coelho Reviewed-by: Suraj Kandpal Reviewed-by: Lucas

[Intel-gfx] [PATCH 11/42] drm/xe/lnl: Add IS_LUNARLAKE

2023-08-23 Thread Lucas De Marchi
From: Balasubramani Vivekanandan Add IS_LUNARLAKE in the compat-i915-headers. That macro, to be used by the xe driver, checks for the platform, whereas the macro on the i915 side is always false. Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h |

[Intel-gfx] [PATCH 01/42] drm/i915: Start using plane scale factor for relative data rate

2023-08-23 Thread Lucas De Marchi
From: Stanislav Lisovskiy BSpec clearly instructs us to use plane scale factor when calculating relative data rate to be used when allocating DDB blocks for each plane. For some reason we use scale factor for data_rate calculation, which is used for BW calculations, however we are not using it

[Intel-gfx] [PATCH 05/42] drm/i915/cx0: Enable/disable TX only for owned PHY lanes

2023-08-23 Thread Lucas De Marchi
From: Gustavo Sousa Display must not enable or disable transmitters for not-owned PHY lanes. BSpec: 64539 Reviewed-by: Mika Kahola Signed-off-by: Gustavo Sousa Signed-off-by: Matt Roper Link: https://patchwork.freedesktop.org/patch/msgid/20230814131331.69516-4-gustavo.so...@intel.com

[Intel-gfx] [PATCH 12/42] drm/i915/lnl: Add display definitions

2023-08-23 Thread Lucas De Marchi
From: Balasubramani Vivekanandan Add Lunar Lake platform definitions for i915 display. The support for LNL will be added to the xe driver, with i915 only driving the display side. Therefore define IS_LUNARLAKE to 0 to disable it when building the i915 module. Signed-off-by: Balasubramani

[Intel-gfx] [PATCH 13/42] drm/i915: Re-order if/else ladder in intel_detect_pch()

2023-08-23 Thread Lucas De Marchi
Follow the convention of checking the last platform first and reword the comment to convey there are more platforms than just DG1. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/soc/intel_pch.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git

[Intel-gfx] [PATCH 03/42] drm/i915/cx0: Add intel_cx0_get_owned_lane_mask()

2023-08-23 Thread Lucas De Marchi
From: Gustavo Sousa There are more parts of C10/C20 programming that need to take owned lanes into account. Define the function intel_cx0_get_owned_lane_mask() and use it. There will be new users of that function in upcoming changes. BSpec: 64539 Reviewed-by: Mika Kahola Signed-off-by: Gustavo

[Intel-gfx] [PATCH 06/42] drm/i915/cx0: Program vswing only for owned lanes

2023-08-23 Thread Lucas De Marchi
From: Gustavo Sousa According to the BSpec, voltage swing programming should be done for owned PHY lanes. Do not program a not-owned PHY lane. BSpec: 74103, 74104 Reviewed-by: Mika Kahola Signed-off-by: Gustavo Sousa Signed-off-by: Matt Roper Link:

[Intel-gfx] [PATCH 23/42] drm/i915/xe2lpd: FBC is now supported on all pipes

2023-08-23 Thread Lucas De Marchi
From: Matt Roper FBC is no longer limited by pipe. Bspec: 68881, 68904 Signed-off-by: Matt Roper Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_fbc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.h

[Intel-gfx] [PATCH 21/42] drm/i915/xe2lpd: Add display power well

2023-08-23 Thread Lucas De Marchi
From: Ravi Kumar Vodapalli Add Display Power Well for LNL platform, mostly it is same as MTL platform so reused the code Changes are: 1. AUX_CH_CTL and AUX_CH_DATA1 are different from MTL so added extra logic xelpdp_aux_power_well_ops functions. 2. PGPICA1 contains type-C capable port slices

[Intel-gfx] [PATCH 24/42] drm/i915/display: Remove FBC capability from fused off pipes

2023-08-23 Thread Lucas De Marchi
From: Clint Taylor If a particular pipe is disabled by fuse also remove the FBC for that pipe. Bspec: 69464 Cc: Anusha Srivatsa Cc: Gustavo Sousa Signed-off-by: Clint Taylor Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_display_device.c | 3 +++ 1 file changed, 3

[Intel-gfx] [PATCH 15/42] drm/i915/xe2lpd: Treat cursor plane as regular plane for DDB allocation

2023-08-23 Thread Lucas De Marchi
From: Stanislav Lisovskiy We now start calculating relative plane data rate for sursor plane as well, as instructed by BSpec and also treat cursor plane same way as other planes, when doing allocation, i.e not using fixed allocation for cursor anymore. Signed-off-by: Stanislav Lisovskiy

[Intel-gfx] [PATCH 22/42] drm/i915/xe2lpd: Add DC state support

2023-08-23 Thread Lucas De Marchi
From: Matt Roper Xe2_LPD supports DC5, DC6, and DC9 (DC3CO no longer exists). The overall programming and requirements to enter DC states are similar to those of Xe_LPD+ although AUX transactions do not require DC5/DC6 exit as they did previously. Bspec: 68851, 68857, 68886, 69115 Cc: Anusha

[Intel-gfx] [PATCH 20/42] drm/i915/xe2lpd: Register DE_RRMR has been removed

2023-08-23 Thread Lucas De Marchi
From: Clint Taylor Do not read DE_RRMR register after display version 20. This register contains display state information during GFX state dumps. Bspec: 69456 Cc: Anusha Srivatsa Cc: Gustavo Sousa Signed-off-by: Clint Taylor Signed-off-by: Lucas De Marchi ---

[Intel-gfx] [PATCH 31/42] drm/i915/lnl: Add gmbus/ddc support

2023-08-23 Thread Lucas De Marchi
LNL's south display uses the same table as MTP. Check for LNL's fake PCH to make it consistent with the other checks. The VBT table doesn't contain the VBT -> spec mapping for LNL. Like in other cases, uses the same as the previous platform. Bspec: 68971, 20124 Cc: Anusha Srivatsa

[Intel-gfx] [PATCH 36/42] drm/i915/lnl: Add support for CDCLK initialization sequence

2023-08-23 Thread Lucas De Marchi
From: Ravi Kumar Vodapalli Add CDCLK initialization sequence changes and CDCLK set frequency sequence for LNL platform. CDCLK frequency change sequence is different for LNL compared to MTL when a change in mdclk/cdclk ratio is observed. Below are changes to be made: 1. In MBUS_CTL register

[Intel-gfx] [PATCH 10/42] drm/i915/tc: remove "fia" from intel_tc_port_fia_max_lane_count()

2023-08-23 Thread Lucas De Marchi
From: Luca Coelho It is irrelevant for the caller that the max lane count is being derived from a FIA register, so having "fia" in the function name is irrelevant. Rename the function accordingly. Signed-off-by: Luca Coelho Reviewed-by: Lucas De Marchi Link:

[Intel-gfx] [PATCH 14/42] drm/i915/lnl: Add fake PCH

2023-08-23 Thread Lucas De Marchi
From: Gustavo Sousa LNL has south display on the same SoC. As such, define a new fake PCH entry for it. Signed-off-by: Gustavo Sousa Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/soc/intel_pch.c | 5 - drivers/gpu/drm/i915/soc/intel_pch.h | 2 ++ 2 files changed, 6

[Intel-gfx] [PATCH 26/42] drm/i915/xe2lpd: Handle port AUX interrupts

2023-08-23 Thread Lucas De Marchi
From: Gustavo Sousa Differently from previous version, Xe2_LPD groups all port AUX interrupt bits into PICA interrupt registers. BSpec: 68958, 69697 Signed-off-by: Gustavo Sousa Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_display_irq.c | 4 +++-

[Intel-gfx] [PATCH 33/42] drm/i915/lnl: Add CDCLK table

2023-08-23 Thread Lucas De Marchi
From: Stanislav Lisovskiy Add a new Lunar Lake CDCLK table from BSpec and also a helper function in order to be able to find lowest possible CDCLK, which has required MDCLK for the correspodent pixel rate. Bspec: 68861 Signed-off-by: Stanislav Lisovskiy Signed-off-by: Lucas De Marchi ---

[Intel-gfx] [PATCH 08/42] drm/i915/tc: make intel_tc_port_get_lane_mask() static

2023-08-23 Thread Lucas De Marchi
From: Luca Coelho This function is only used locally, so make it static and remove the definition from the header file. Signed-off-by: Luca Coelho Reviewed-by: Suraj Kandpal Link: https://lore.kernel.org/r/2023072121.369227-3-luciano.coe...@intel.com ---

[Intel-gfx] [PATCH 29/42] drm/i915/xe2lpd: Add support for HPD

2023-08-23 Thread Lucas De Marchi
From: Gustavo Sousa Hotplug setup for Xe2_LPD differs from Xe_LPD+ by the fact that the extra programming for hotplug inversion and DDI HPD filter duration is not necessary anymore. As mtp_hpd_irq_setup() is reasonably small, prefer to fork it into a new function for Xe2_LPD instead of adding a

[Intel-gfx] [PATCH 32/42] drm/i915/lnl: Introduce MDCLK

2023-08-23 Thread Lucas De Marchi
From: Stanislav Lisovskiy In Lunar Lake we now separate MDCLK from CDLCK, which used to be before always 2 times CDCLK. Now we might afford lower CDCLK, while having higher memory clock, so improving bandwidth and power consumption at the same time. This is prep work required to enable that.

[Intel-gfx] [PATCH 30/42] drm/i915/xe2lpd: Extend Wa_15010685871

2023-08-23 Thread Lucas De Marchi
Xe2_LPD also needs workaround 15010685871. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_cdclk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c index

[Intel-gfx] [PATCH 16/42] drm/i915/xe2lpd: Move D2D enable/disable

2023-08-23 Thread Lucas De Marchi
Bits to enable/disable and check state for D2D moved from XELPDP_PORT_BUF_CTL1 to DDI_BUF_CTL. Make the functions mtl_ddi_disable_d2d() and mtl_ddi_enable_d2d generic to work with multiple reg location and bitfield layout. Signed-off-by: Lucas De Marchi ---

[Intel-gfx] [PATCH 40/42] drm/i915/lnl: Add support to check c10 phy link rate

2023-08-23 Thread Lucas De Marchi
From: Ravi Kumar Vodapalli Add support to check c10 phy link rate for LNL in intel_c10_phy_check_hdmi_link_rate() function. BSpec: 68862 Signed-off-by: Ravi Kumar Vodapalli Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 11 --- 1 file changed, 8

[Intel-gfx] [PATCH 27/42] drm/i915/xe2lpd: Read pin assignment from IOM

2023-08-23 Thread Lucas De Marchi
From: Luca Coelho Starting from display version 20, we need to read the pin assignment from the IOM TCSS_DDI_STATUS register instead of reading it from the FIA. We use the pin assignment to decide the maximum lane count. So, to support this change, add a new lnl_tc_port_get_max_lane_count()

[Intel-gfx] [PATCH 17/42] drm/i915/xe2lpd: D2D Enable preserve bits in DDI_BUF_CTL

2023-08-23 Thread Lucas De Marchi
From: Clint Taylor Display Ver 20 moved the D2D Enable bit to DDI_BUF_CTL(DDI_CTL_DE) register. We used multiple variables for HDMI and DisplayPort copies of this register. Consolidate the various locations to use intel_digital_port saved_port_bits. Cc: Anusha Srivatsa Cc: Gustavo Sousa Cc:

[Intel-gfx] [PATCH 37/42] drm/i915/xe2lpd: Write DBuf after CDCLK change in post plane

2023-08-23 Thread Lucas De Marchi
From: Stanislav Lisovskiy Previously we always updated DBuf MBUS CTL and DBUF CTL regs after CDCLK has been changed(CDCLK_CTL), however for Xe2-LPD we can't do like that anymore. According to BSpec, we have to first update DBuf regs and then write CDCLK regs, when CDCLK is decreased, which we do

[Intel-gfx] [PATCH 09/42] drm/i915/tc: move legacy code out of the main _max_lane_count() func

2023-08-23 Thread Lucas De Marchi
From: Luca Coelho This makes the code a bit more symmetric and readable, especially when we start adding more display version-specific alternatives. Signed-off-by: Luca Coelho Link: https://lore.kernel.org/r/2023072121.369227-4-luciano.coe...@intel.com ---

[Intel-gfx] [PATCH 19/42] drm/i915/xe2lpd: Don't try to program PLANE_AUX_DIST

2023-08-23 Thread Lucas De Marchi
From: Matt Roper Since Xe2LPD technically has FlatCCS, it doesn't have AuxCCS registers like PLANE_AUX_DIST. However we currently have HAS_FLAT_CCS hardcoded to 0 since compression isn't ready; we need to make sure this doesn't cause the display code to go back to trying to write this register.

[Intel-gfx] [PATCH 39/42] drm/i915/lnl: Add pll table for LNL platform

2023-08-23 Thread Lucas De Marchi
From: Ravi Kumar Vodapalli Add PLL Table for Lunar Lake platform. BSpec: 68862 Cc: Clint Taylor Cc: Anusha Srivatsa Signed-off-by: Ravi Kumar Vodapalli Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 411 ++- 1 file changed, 406

[Intel-gfx] [PATCH 42/42] drm/xe/lnl: Enable the display support

2023-08-23 Thread Lucas De Marchi
From: Balasubramani Vivekanandan Enable the display support for LUNARLAKE Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/xe/xe_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c index 7fb00ea410a6..f723e19e8ca5

[Intel-gfx] [PATCH 18/42] drm/i915/xe2lpd: Move registers to PICA

2023-08-23 Thread Lucas De Marchi
Some registers for DDI A/B moved to PICA and now follow the same format as the ones for the PORT_TC ports. The wrapper here deals with 2 issues: - Share the implementation between xe2lpd and previous platforms: there are minor layout changes, it's mostly the register

[Intel-gfx] [PATCH 41/42] drm/i915/xe2lpd: Update mbus on post plane updates

2023-08-23 Thread Lucas De Marchi
From: Stanislav Lisovskiy According to BSpec we need to write the MBUS CTL and DBUF CTL both for increasing CDCLK case (pre plane) and for decreasing CDCLK case (post plane). Make sure those updates are in place for Xe2-LPD. Since the mbus update is not only on pre-enable anymore, also rename

[Intel-gfx] [PATCH 38/42] drm/i915/lnl: Serialize global state if mdclk/cdclk ratio changes.

2023-08-23 Thread Lucas De Marchi
From: Stanislav Lisovskiy mdclk_cdclk_ratio is a part of dbuf_state and if it changes, it requires hw to be poked, so we must serialize the global state in that case. Signed-off-by: Stanislav Lisovskiy Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_cdclk.c | 19

[Intel-gfx] [PATCH 35/42] drm/i915/lnl: Introduce MDCLK_CDCLK ratio to DBuf

2023-08-23 Thread Lucas De Marchi
From: Stanislav Lisovskiy When we change MDCLK/CDCLK the BSpec now instructs us to write a ratio between MDCLK/CDCLK to MBUS CTL and DBUF CTL registers during that change. Previsouly DBuf state and CDCLK were not anyhow coupled together. Now at compute stage when we know which CDCLK/MDCLK we

[Intel-gfx] [PATCH 34/42] drm/i915/lnl: Start using CDCLK through PLL

2023-08-23 Thread Lucas De Marchi
From: Stanislav Lisovskiy Introduce correspondent definitions and for choosing between CD2X CDCLK and PLL CDCLK as a source. Signed-off-by: Stanislav Lisovskiy Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_cdclk.c | 14 -- drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 25/42] drm/i915/xe2lpd: Add support for DP aux channels

2023-08-23 Thread Lucas De Marchi
From: Gustavo Sousa The location of aux channels registers for Xe2 display changed w.r.t. the previous version. BSpec: 69010 Signed-off-by: Gustavo Sousa Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dp_aux.c | 43 - 1 file changed, 42

[Intel-gfx] [PATCH 28/42] drm/i915/xe2lpd: enable odd size and panning for planar yuv on xe2lpd

2023-08-23 Thread Lucas De Marchi
From: Juha-Pekka Heikkilä Enable odd size and panning for planar yuv formats. Cc: Suraj Kandpal Signed-off-by: Juha-Pekka Heikkilä Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 8 1 file changed, 8 insertions(+) diff --git

[Intel-gfx] ✗ Fi.CI.IGT: failure for HDCP MST aux issue fix (rev3)

2023-08-23 Thread Patchwork
== Series Details == Series: HDCP MST aux issue fix (rev3) URL : https://patchwork.freedesktop.org/series/122267/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13549_full -> Patchwork_122267v3_full Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Enable Lunar Lake display

2023-08-23 Thread Patchwork
== Series Details == Series: Enable Lunar Lake display URL : https://patchwork.freedesktop.org/series/122799/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/122799/revisions/1/mbox/ not applied Applying: drm/i915: Start using plane scale factor

[Intel-gfx] PR for GSC FW release 102.0.0.1655 for MTL

2023-08-23 Thread Daniele Ceraolo Spurio
The following changes since commit 0e048b061bde79ad735c7b7b5161ee1bd3400150: Merge branch 'for-upstream' of https://github.com/CirrusLogic/linux-firmware (2023-08-14 13:03:41 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware mtl_gsc_1655 for you

[Intel-gfx] [PATCH 2/2] drm/i915: Set copy engine arbitration for pipeblit WA

2023-08-23 Thread Jonathan Cavitt
From: Nirmoy Das Set copy engine arbitration into round robin mode for part of Wa_16018031267 / Wa_16018063123 mitigation. Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 3 +++ drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 ++

[Intel-gfx] [PATCH 1/2] drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123

2023-08-23 Thread Jonathan Cavitt
From: Nirmoy Das Apply WABB blit for Wa_16018031267 / Wa_16018063123. Additionally, update the lrc selftest to exercise the new WABB changes. Signed-off-by: Jonathan Cavitt Co-developed-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 3 +

[Intel-gfx] [PATCH 0/2] Apply Wa_16018031267 / Wa_16018063123

2023-08-23 Thread Jonathan Cavitt
Apply Wa_16018031267 / Wa_16018063123. This necessitates submitting a fastcolor blit as WABB and setting the copy engine arbitration to round-robin mode. Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt CC: Joonas Lahtinen CC: Rodrigo Vivi CC: Tomasz Mistat CC: Gregory F Germano

Re: [Intel-gfx] [Intel-xe] [PATCH 16/42] drm/i915/xe2lpd: Move D2D enable/disable

2023-08-23 Thread Matt Roper
On Wed, Aug 23, 2023 at 10:07:14AM -0700, Lucas De Marchi wrote: > Bits to enable/disable and check state for D2D moved from > XELPDP_PORT_BUF_CTL1 to DDI_BUF_CTL. Make the functions As of Xe2, DDI_BUF_CTL is now renamed to "DDI_CTL_DE" in the spec, so you might want to toss a mention of the new

[Intel-gfx] [PATCH v2 0/2] Apply Wa_16018031267 / Wa_16018063123

2023-08-23 Thread Jonathan Cavitt
Apply Wa_16018031267 / Wa_16018063123. This necessitates submitting a fastcolor blit as WABB and setting the copy engine arbitration to round-robin mode. v2: - Rename old platform check in second patch to match declaration in first patch. - Refactor second patch name to match first patch.

[Intel-gfx] [PATCH v2 2/2] drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123

2023-08-23 Thread Jonathan Cavitt
From: Nirmoy Das Set copy engine arbitration into round robin mode for part of Wa_16018031267 / Wa_16018063123 mitigation. Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 3 +++ drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 ++

[Intel-gfx] [PATCH v2 1/2] drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123

2023-08-23 Thread Jonathan Cavitt
From: Nirmoy Das Apply WABB blit for Wa_16018031267 / Wa_16018063123. Additionally, update the lrc selftest to exercise the new WABB changes. Signed-off-by: Jonathan Cavitt Co-developed-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 3 +

Re: [Intel-gfx] [Intel-xe] [PATCH 18/42] drm/i915/xe2lpd: Move registers to PICA

2023-08-23 Thread Matt Roper
On Wed, Aug 23, 2023 at 10:07:16AM -0700, Lucas De Marchi wrote: > Some registers for DDI A/B moved to PICA and now follow the same format > as the ones for the PORT_TC ports. The wrapper here deals with 2 issues: > > - Share the implementation between xe2lpd and previous >

Re: [Intel-gfx] [Intel-xe] [PATCH 20/42] drm/i915/xe2lpd: Register DE_RRMR has been removed

2023-08-23 Thread Matt Roper
On Wed, Aug 23, 2023 at 10:07:18AM -0700, Lucas De Marchi wrote: > From: Clint Taylor > > Do not read DE_RRMR register after display version 20. This register > contains display state information during GFX state dumps. > > Bspec: 69456 > Cc: Anusha Srivatsa > Cc: Gustavo Sousa >

Re: [Intel-gfx] [REGRESSION] HDMI connector detection broken in 6.3 on Intel(R) Celeron(R) N3060 integrated graphics

2023-08-23 Thread Imre Deak
On Mon, Aug 21, 2023 at 11:27:29AM +0200, Maxime Ripard wrote: > On Tue, Aug 15, 2023 at 11:12:46AM +0300, Jani Nikula wrote: > > On Mon, 14 Aug 2023, Imre Deak wrote: > > > On Sun, Aug 13, 2023 at 03:41:30PM +0200, Linux regression tracking > > > (Thorsten Leemhuis) wrote: > > > Hi, > > > > >

Re: [Intel-gfx] [Intel-xe] [PATCH 21/42] drm/i915/xe2lpd: Add display power well

2023-08-23 Thread Matt Roper
On Wed, Aug 23, 2023 at 12:44:56PM -0700, Matt Roper wrote: > On Wed, Aug 23, 2023 at 10:07:19AM -0700, Lucas De Marchi wrote: > > From: Ravi Kumar Vodapalli > > > > Add Display Power Well for LNL platform, mostly it is same as MTL > > platform so reused the code > > > > Changes are: > > 1.

Re: [Intel-gfx] [Intel-xe] [PATCH 23/42] drm/i915/xe2lpd: FBC is now supported on all pipes

2023-08-23 Thread Matt Roper
On Wed, Aug 23, 2023 at 10:07:21AM -0700, Lucas De Marchi wrote: > From: Matt Roper > > FBC is no longer limited by pipe. It looks like we lost the part of this patch that adds this to the xe2_lpd_display device info structure. Matt > > Bspec: 68881, 68904 > Signed-off-by: Matt Roper >

  1   2   >