[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Skip pxp init if gt is wedged

2023-10-27 Thread Patchwork
== Series Details == Series: drm/i915: Skip pxp init if gt is wedged URL : https://patchwork.freedesktop.org/series/125658/ State : success == Summary == CI Bug Log - changes from CI_DRM_13799 -> Patchwork_125658v1 Summary ---

[Intel-gfx] [PULL] drm-misc-next

2023-10-27 Thread Maarten Lankhorst
drm-misc-next-2023-10-27: drm-misc-next for v6.7-rc1: drm-misc-next-2023-10-19 + following: UAPI Changes: Cross-subsystem Changes: - Convert fbdev drivers to use fbdev i/o mem helpers. Core Changes: - Use cross-references for macros in docs. - Make drm_client_buffer_addb use addfb2. - Add

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Apply Wa_16018031267 / Wa_16018063123 (rev2)

2023-10-27 Thread Andrzej Hajda
On 27.10.2023 10:32, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* Apply Wa_16018031267 / Wa_16018063123 (rev2) *URL:* https://patchwork.freedesktop.org/series/125650/ *State:*failure *Details:*

[Intel-gfx] ✓ Fi.CI.BAT: success for Cleanup a few functions in C10/C20 handling (rev3)

2023-10-27 Thread Patchwork
== Series Details == Series: Cleanup a few functions in C10/C20 handling (rev3) URL : https://patchwork.freedesktop.org/series/125323/ State : success == Summary == CI Bug Log - changes from CI_DRM_13799 -> Patchwork_125323v3 Summary

Re: [Intel-gfx] [PATCH] drm/i915/gt: Remove assignment from if condition

2023-10-27 Thread Andi Shyti
Hi Gilbert, > diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c > b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c > index e8f42ec6b1b4..cbc4ecf26d8b 100644 > --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c > +++

[Intel-gfx] [PATCH v4 1/4] pwm: rename pwm_apply_state() to pwm_apply_cansleep()

2023-10-27 Thread Sean Young
In order to introduce a pwm api which can be used from atomic context, we will need two functions for applying pwm changes: int pwm_apply_cansleep(struct pwm *, struct pwm_state *); int pwm_apply_atomic(struct pwm *, struct pwm_state *); This commit just deals with renaming

Re: [Intel-gfx] [PATCH 05/29] drm/dp_mst: Allow DSC in any Synaptics last branch device

2023-10-27 Thread Lisovskiy, Stanislav
On Tue, Oct 24, 2023 at 04:09:01AM +0300, Imre Deak wrote: > The Synaptics MST branch deivces support DSC decompression on all their devices > output ports, provided that they are last branch devices (with their > output ports connected to the sinks). The Thinkpad 40B0 TBT dock for > instance

Re: [Intel-gfx] [PATCH v3] drm/i915/dsb: DSB code refactoring

2023-10-27 Thread Luca Coelho
On Thu, 2023-10-26 at 14:23 +, Manna, Animesh wrote: > > > -Original Message- > > From: Luca Coelho > > Sent: Thursday, October 26, 2023 1:08 PM > > To: Manna, Animesh ; intel- > > g...@lists.freedesktop.org > > Cc: Nikula, Jani > > Subject: Re: [Intel-gfx] [PATCH v3] drm/i915/dsb:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Cleanup a few functions in C10/C20 handling (rev3)

2023-10-27 Thread Patchwork
== Series Details == Series: Cleanup a few functions in C10/C20 handling (rev3) URL : https://patchwork.freedesktop.org/series/125323/ State : warning == Summary == Error: dim checkpatch failed 12067ee10d5d drm/i915/display: Abstract C10/C20 pll hw readout 320dc6644c89 drm/i915/display:

Re: [Intel-gfx] [PATCH 20/29] drm/i915/dp_mst: Handle the Synaptics HBlank expansion quirk

2023-10-27 Thread Lisovskiy, Stanislav
On Tue, Oct 24, 2023 at 04:09:16AM +0300, Imre Deak wrote: > The Synaptics MST hubs expose some sink EDID modes with a reduced HBLANK > period, presumedly to save BW, which the hub expands before forwarding > the stream to the sink. In particular a 4k mode with a standard CVT > HBLANK period is

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Apply Wa_16018031267 / Wa_16018063123 (rev2)

2023-10-27 Thread Patchwork
== Series Details == Series: Apply Wa_16018031267 / Wa_16018063123 (rev2) URL : https://patchwork.freedesktop.org/series/125650/ State : warning == Summary == Error: dim checkpatch failed ee8204ae999d drm/i915: Reserve some kernel space per vm ca517da59005 drm/i915: Add WABB blit for

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Apply Wa_16018031267 / Wa_16018063123 (rev2)

2023-10-27 Thread Patchwork
== Series Details == Series: Apply Wa_16018031267 / Wa_16018063123 (rev2) URL : https://patchwork.freedesktop.org/series/125650/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for Apply Wa_16018031267 / Wa_16018063123 (rev2)

2023-10-27 Thread Patchwork
== Series Details == Series: Apply Wa_16018031267 / Wa_16018063123 (rev2) URL : https://patchwork.freedesktop.org/series/125650/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13799 -> Patchwork_125650v2 Summary ---

Re: [Intel-gfx] [PATCH 26/29] drm/i915/dp_mst: Force modeset CRTC if DSC toggling requires it

2023-10-27 Thread Lisovskiy, Stanislav
On Tue, Oct 24, 2023 at 04:09:22AM +0300, Imre Deak wrote: > Enabling / disabling DSC decompression in the branch device downstream > of the source may reset the while branch device. To avoid this while the "may reset the whOle branch device" I guess? > streams are still active, force a modeset

Re: [Intel-gfx] [PATCH 07/29] drm/dp_mst: Add HBLANK expansion quirk for Synaptics MST hubs

2023-10-27 Thread Lisovskiy, Stanislav
On Tue, Oct 24, 2023 at 04:09:03AM +0300, Imre Deak wrote: > Add a quirk for Synaptics MST hubs, which require a workaround - at leat > on i915 - for some modes, on which the hub applies HBLANK expansion. > These modes will only work by enabling DSC decompression for them, a > follow-up patch will

Re: [Intel-gfx] [PATCH] drm/i915/bios: Clamp VBT HDMI level shift on BDW

2023-10-27 Thread Nautiyal, Ankit K
On 10/13/2023 7:32 PM, Ville Syrjala wrote: From: Ville Syrjälä Apparently some BDW machines (eg. HP Pavilion 15-ab) shipped with a VBT inherited from some earlier HSW model. On HSW the HDMI level shift value could go up to 11, whereas on BDW the maximum value is 9. The DDI code does clamp

Re: [Intel-gfx] [PATCH v3] drm/i915/tc: Fix -Wformat-truncation in intel_tc_port_init

2023-10-27 Thread Kahola, Mika
> -Original Message- > From: Das, Nirmoy > Sent: Thursday, October 26, 2023 3:57 PM > To: intel-gfx@lists.freedesktop.org > Cc: Das, Nirmoy ; Kahola, Mika ; > Deak, Imre ; Nikula, > Jani ; Hajda, Andrzej > Subject: [PATCH v3] drm/i915/tc: Fix -Wformat-truncation in intel_tc_port_init >

Re: [Intel-gfx] [PATCH 06/29] drm/dp: Add DP_HBLANK_EXPANSION_CAPABLE and DSC_PASSTHROUGH_EN DPCD flags

2023-10-27 Thread Lisovskiy, Stanislav
On Tue, Oct 24, 2023 at 04:09:02AM +0300, Imre Deak wrote: > Add the DPCD flag to enable DSC passthrough in a last branch device, > used in a follow-up i915 patch. > > Also add a flag to detect HBLANK expansion support in a branch device, > used by a workaround in a follow-up i915 patch. > > Cc:

[Intel-gfx] [v2 1/2] drm/i915/display: Add support for darskscreen detection

2023-10-27 Thread Nemesa Garg
Darkscreen detection checks if all the pixels of the frame are less then or equal to the comparision value. The comparision value is set to 256 i.e black. So upon getting black pixels from the pipe, the dark screen detect bit is set and an error message will be printed. v2: Addressed review

[Intel-gfx] [v2 2/2] drm/i915/display: Add darkscreen debugfs entry under crtc

2023-10-27 Thread Nemesa Garg
This is to set the enable/disable status. v2: Addressed review comments (Jani) Signed-off-by: Nemesa Garg --- .../gpu/drm/i915/display/intel_darkscreen.c | 36 +++ .../drm/i915/display/intel_display_debugfs.c | 2 ++ 2 files changed, 38 insertions(+) diff --git

[Intel-gfx] [v2 0/2] Enable Darkscreen Feature

2023-10-27 Thread Nemesa Garg
The logic checks for any black screen at pipe level and upon such detection prints error. Darkscreen compares the pixels with the compare value(0x00 - black) for the detection purpose. This feature can be enables/disabled through debugfs. Nemesa Garg (2): drm/i915/display: Add support for

Re: [Intel-gfx] [v2 1/2] drm/i915/display: Add support for darskscreen detection

2023-10-27 Thread Jani Nikula
On Fri, 27 Oct 2023, Nemesa Garg wrote: > Darkscreen detection checks if all the pixels of the frame are less then > or equal to the comparision value. The comparision value is set to 256 > i.e black. So upon getting black pixels from the pipe, the dark screen > detect bit is set and an error

Re: [Intel-gfx] [PATCH] drm/i915/gt: Remove {} from if-else

2023-10-27 Thread Andi Shyti
Hi Soumya, On Wed, Oct 25, 2023 at 09:43:08PM -0700, Soumya Negi wrote: > In accordance to Linux coding style(Documentation/process/4.Coding.rst), > remove unneeded braces from if-else block as all arms of this block > contain single statements. > > Suggested-by: Andi Shyti > Signed-off-by:

Re: [Intel-gfx] [PATCH] drm/i915: Skip pxp init if gt is wedged

2023-10-27 Thread Jani Nikula
On Thu, 26 Oct 2023, Zhanjun Dong wrote: > gt wedged is fatal error, skip the pxp init on this situation. More information is needed in the commit message. When do you encounter this situation? I'll note that nobody checks intel_pxp_init() return status, so this silently skips PXP. BR, Jani.

Re: [Intel-gfx] [PATCH] drm/i915/sprite: move sprite_name() to intel_sprite.c

2023-10-27 Thread Jani Nikula
On Thu, 12 Oct 2023, Ville Syrjälä wrote: > On Wed, Oct 11, 2023 at 11:22:59PM +0300, Jani Nikula wrote: >> Move sprite_name() where its only user is, and convert it to a function, >> removing the implicit dev_priv usage. >> >> Signed-off-by: Jani Nikula > > Reviewed-by: Ville Syrjälä Thanks,

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Apply Wa_16018031267 / Wa_16018063123

2023-10-27 Thread Andrzej Hajda
Hi, On 27.10.2023 07:34, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* Apply Wa_16018031267 / Wa_16018063123 *URL:* https://patchwork.freedesktop.org/series/125650/ *State:*failure *Details:*

Re: [Intel-gfx] [PATCH v3] drm/i915/dsb: DSB code refactoring

2023-10-27 Thread Manna, Animesh
> -Original Message- > From: Ville Syrjälä > Sent: Thursday, October 26, 2023 8:03 PM > To: Manna, Animesh > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani > Subject: Re: [Intel-gfx] [PATCH v3] drm/i915/dsb: DSB code refactoring > > On Sun, Oct 08, 2023 at 03:42:06PM +0530,

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/lnl: Assign correct phys (rev3)

2023-10-27 Thread Patchwork
== Series Details == Series: drm/i915/lnl: Assign correct phys (rev3) URL : https://patchwork.freedesktop.org/series/125322/ State : success == Summary == CI Bug Log - changes from CI_DRM_13799 -> Patchwork_125322v3 Summary ---

Re: [Intel-gfx] [PATCH 22/29] drm/i915/dp: Enable DSC via the connector decompression AUX

2023-10-27 Thread Lisovskiy, Stanislav
On Tue, Oct 24, 2023 at 04:09:18AM +0300, Imre Deak wrote: > Enable DSC using the DSC AUX device stored for this purpose in the > connector. This prepares for a follow-up patch which toggles DSC for > each stream as needed, but for now keeps the current behavior, as DSC is > still only enabled for

[Intel-gfx] [PATCH] i915/perf: Fix NULL deref bugs with drm_dbg() calls

2023-10-27 Thread Harshit Mogalapalli
When i915 perf interface is not available dereferencing it will lead to NULL dereferences. Fix this by using DRM_DEBUG() which the scenario before the commit in the Fixes tag. Fixes: 2fec539112e8 ("i915/perf: Replace DRM_DEBUG with driver specific drm_dbg call") Signed-off-by: Harshit

Re: [Intel-gfx] [PATCH] i915/perf: Fix NULL deref bugs with drm_dbg() calls

2023-10-27 Thread Tvrtko Ursulin
On 27/10/2023 15:11, Andrzej Hajda wrote: On 27.10.2023 16:07, Harshit Mogalapalli wrote: When i915 perf interface is not available dereferencing it will lead to NULL dereferences. Fix this by using DRM_DEBUG() which the scenario before the commit in the Fixes tag. Fixes: 2fec539112e8

Re: [Intel-gfx] [PATCH 23/29] drm/i915/dp_mst: Enable DSC passthrough

2023-10-27 Thread Imre Deak
On Fri, Oct 27, 2023 at 06:00:33PM +0300, Imre Deak wrote: > On Fri, Oct 27, 2023 at 05:52:17PM +0300, Ville Syrjälä wrote: > > On Tue, Oct 24, 2023 at 04:09:19AM +0300, Imre Deak wrote: > > > Enable passing through DSC streams to the sink in last branch devices. > > > > > > Signed-off-by: Imre

Re: [Intel-gfx] [PATCH 25/29] drm/i915: Factor out function to clear pipe update flags

2023-10-27 Thread Ville Syrjälä
On Tue, Oct 24, 2023 at 04:09:21AM +0300, Imre Deak wrote: > Factor out a helper to clear the pipe update flags, used by a follow-up > patch to modeset an MST topology. > > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_display.c | 52 ++-- > 1 file changed,

Re: [Intel-gfx] [PATCH 26/29] drm/i915/dp_mst: Force modeset CRTC if DSC toggling requires it

2023-10-27 Thread Ville Syrjälä
On Tue, Oct 24, 2023 at 04:09:22AM +0300, Imre Deak wrote: > Enabling / disabling DSC decompression in the branch device downstream > of the source may reset the while branch device. To avoid this while the > streams are still active, force a modeset on all CRTC/ports connected to > this branch

Re: [Intel-gfx] [PATCH 23/29] drm/i915/dp_mst: Enable DSC passthrough

2023-10-27 Thread Imre Deak
On Fri, Oct 27, 2023 at 05:52:17PM +0300, Ville Syrjälä wrote: > On Tue, Oct 24, 2023 at 04:09:19AM +0300, Imre Deak wrote: > > Enable passing through DSC streams to the sink in last branch devices. > > > > Signed-off-by: Imre Deak > > --- > > drivers/gpu/drm/i915/display/intel_dp.c | 26

Re: [Intel-gfx] [PATCH v2 23/29] drm/i915/dp_mst: Enable DSC passthrough

2023-10-27 Thread Lisovskiy, Stanislav
On Tue, Oct 24, 2023 at 01:22:19PM +0300, Imre Deak wrote: > Enable passing through DSC streams to the sink in last branch devices. > > v2: > - Fix the DPCD register address while setting/clearing the passthrough > flag. > > Signed-off-by: Imre Deak Reviewed-by: Stanislav Lisovskiy > --- >

Re: [Intel-gfx] [PATCH 12/29] drm/i915/dp_mst: Account for FEC and DSC overhead during BW allocation

2023-10-27 Thread Lisovskiy, Stanislav
On Tue, Oct 24, 2023 at 04:09:08AM +0300, Imre Deak wrote: > Atm, the BW allocated for an MST stream doesn't take into account the > DSC control symbol (EOC) and data alignment overhead on the local (first > downstream) MST link (reflected by the data M/N/TU values) and - besides > the above

Re: [Intel-gfx] [PATCH v2 08/29] drm/dp: Add helpers to calculate the link BW overhead

2023-10-27 Thread Ville Syrjälä
On Tue, Oct 24, 2023 at 01:22:17PM +0300, Imre Deak wrote: > Add helpers drivers can use to calculate the BW allocation overhead - > due to SSC, FEC, DSC and data alignment on symbol cycles - and the > channel coding efficiency - due to the 8b/10b, 128b/132b encoding. On > 128b/132b links the FEC

Re: [Intel-gfx] [PATCH v3] drm/i915/dsb: DSB code refactoring

2023-10-27 Thread Manna, Animesh
> -Original Message- > From: Luca Coelho > Sent: Friday, October 27, 2023 12:19 PM > To: Manna, Animesh ; intel- > g...@lists.freedesktop.org > Cc: Nikula, Jani > Subject: Re: [Intel-gfx] [PATCH v3] drm/i915/dsb: DSB code refactoring > > On Thu, 2023-10-26 at 14:23 +, Manna,

Re: [Intel-gfx] [PATCH v2 08/29] drm/dp: Add helpers to calculate the link BW overhead

2023-10-27 Thread Lisovskiy, Stanislav
On Tue, Oct 24, 2023 at 01:22:17PM +0300, Imre Deak wrote: > Add helpers drivers can use to calculate the BW allocation overhead - > due to SSC, FEC, DSC and data alignment on symbol cycles - and the > channel coding efficiency - due to the 8b/10b, 128b/132b encoding. On > 128b/132b links the FEC

Re: [Intel-gfx] [PATCH] i915/perf: Fix NULL deref bugs with drm_dbg() calls

2023-10-27 Thread Andrzej Hajda
On 27.10.2023 16:07, Harshit Mogalapalli wrote: When i915 perf interface is not available dereferencing it will lead to NULL dereferences. Fix this by using DRM_DEBUG() which the scenario before the commit in the Fixes tag. Fixes: 2fec539112e8 ("i915/perf: Replace DRM_DEBUG with driver

Re: [Intel-gfx] [PATCH 10/29] drm/i915/dp: Specify the FEC overhead as an increment vs. a remainder

2023-10-27 Thread Lisovskiy, Stanislav
On Tue, Oct 24, 2023 at 04:09:06AM +0300, Imre Deak wrote: > A follow-up patch will add up all the overheads on a DP link, where it > makes more sense to specify each overhead factor in terms of the added > overhead amount vs. the reciprocal remainder (of usable BW remaining > after deducting the

[Intel-gfx] [PATCH v4] drm/i915/dsb: DSB code refactoring

2023-10-27 Thread Animesh Manna
Refactor DSB implementation to be compatible with Xe driver. v1: RFC version. v2: Make intel_dsb structure opaque from external usage. [Jani] v3: Rebased on latest. v4: - Add boundary check in dsb_buffer_memset(). [Luca] - Use size_t instead of u32. [Luca] Cc: Jani Nikula Signed-off-by: Animesh

[Intel-gfx] [PATCH v3 08/29] drm/dp: Add helpers to calculate the link BW overhead

2023-10-27 Thread Imre Deak
Add helpers drivers can use to calculate the BW allocation overhead - due to SSC, FEC, DSC and data alignment on symbol cycles - and the channel coding efficiency - due to the 8b/10b, 128b/132b encoding. On 128b/132b links the FEC overhead is part of the coding efficiency, so not accounted for in

[Intel-gfx] [PATCH v3 18/29] drm/i915/dp: Wait for FEC detected status in the sink

2023-10-27 Thread Imre Deak
As required by the DP standard wait for the sink to detect the FEC decode enabling symbol sent by the source. There is a difference between SST and MST when the source enables the FEC encoding: on SST this happens only after enabling the transcoder, whereas on MST it happens already after

Re: [Intel-gfx] [PATCH 24/29] drm/i915/dp_mst: Enable MST DSC decompression for all streams

2023-10-27 Thread Lisovskiy, Stanislav
On Tue, Oct 24, 2023 at 04:09:20AM +0300, Imre Deak wrote: > Enable DSC decompression for all streams. In particular atm if a sink is > connected to a last branch device that is downstream of the first branch > device connected to the source, decompression is not enabled for it. > Similarly it's

Re: [Intel-gfx] [PATCH 07/29] drm/dp_mst: Add HBLANK expansion quirk for Synaptics MST hubs

2023-10-27 Thread Lisovskiy, Stanislav
On Tue, Oct 24, 2023 at 04:09:03AM +0300, Imre Deak wrote: > Add a quirk for Synaptics MST hubs, which require a workaround - at leat > on i915 - for some modes, on which the hub applies HBLANK expansion. > These modes will only work by enabling DSC decompression for them, a > follow-up patch will

Re: [Intel-gfx] [PATCH v2 22/29] drm/i915/dp: Enable DSC via the connector decompression AUX

2023-10-27 Thread Lisovskiy, Stanislav
On Tue, Oct 24, 2023 at 01:22:18PM +0300, Imre Deak wrote: > Enable DSC using the DSC AUX device stored for this purpose in the > connector. This prepares for a follow-up patch which toggles DSC for > each stream as needed, but for now keeps the current behavior, as DSC is > still only enabled for

Re: [Intel-gfx] [PATCH v3] drm/i915/dsb: DSB code refactoring

2023-10-27 Thread Ville Syrjälä
On Fri, Oct 27, 2023 at 05:59:45AM +, Manna, Animesh wrote: > > > > -Original Message- > > From: Ville Syrjälä > > Sent: Thursday, October 26, 2023 8:03 PM > > To: Manna, Animesh > > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani > > Subject: Re: [Intel-gfx] [PATCH v3]

Re: [Intel-gfx] [PATCH 23/29] drm/i915/dp_mst: Enable DSC passthrough

2023-10-27 Thread Ville Syrjälä
On Tue, Oct 24, 2023 at 04:09:19AM +0300, Imre Deak wrote: > Enable passing through DSC streams to the sink in last branch devices. > > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_dp.c | 26 - > 1 file changed, 25 insertions(+), 1 deletion(-) > >

Re: [Intel-gfx] [PATCH 21/29] drm/i915/dp_mst: Enable decompression in the sink from the MST encoder hooks

2023-10-27 Thread Lisovskiy, Stanislav
On Tue, Oct 24, 2023 at 04:09:17AM +0300, Imre Deak wrote: > Enable/disable the DSC decompression in the sink/branch from the MST > encoder hooks. This prepares for an upcoming patch toggling DSC for each > stream as needed, but for now keeps the current behavior, as DSC is only > enabled for the

Re: [Intel-gfx] [PATCH 26/29] drm/i915/dp_mst: Force modeset CRTC if DSC toggling requires it

2023-10-27 Thread Imre Deak
On Fri, Oct 27, 2023 at 05:20:10PM +0300, Ville Syrjälä wrote: > On Tue, Oct 24, 2023 at 04:09:22AM +0300, Imre Deak wrote: > > Enabling / disabling DSC decompression in the branch device downstream > > of the source may reset the while branch device. To avoid this while the > > streams are still

Re: [Intel-gfx] [PATCH 25/29] drm/i915: Factor out function to clear pipe update flags

2023-10-27 Thread Lisovskiy, Stanislav
On Tue, Oct 24, 2023 at 04:09:21AM +0300, Imre Deak wrote: > Factor out a helper to clear the pipe update flags, used by a follow-up > patch to modeset an MST topology. > > Signed-off-by: Imre Deak Was willing to do that myself :)) Spotted when doing bigjoiner related refactoring, thanks for

Re: [Intel-gfx] [PATCH 24/29] drm/i915/dp_mst: Enable MST DSC decompression for all streams

2023-10-27 Thread Imre Deak
On Fri, Oct 27, 2023 at 05:45:30PM +0300, Lisovskiy, Stanislav wrote: > On Tue, Oct 24, 2023 at 04:09:20AM +0300, Imre Deak wrote: > > Enable DSC decompression for all streams. In particular atm if a sink is > > connected to a last branch device that is downstream of the first branch > > device

[Intel-gfx] [PATCH v2] i915/perf: Fix NULL deref bugs with drm_dbg() calls

2023-10-27 Thread Harshit Mogalapalli
When i915 perf interface is not available dereferencing it will lead to NULL dereferences. As returning -ENOTSUPP is pretty clear return when perf interface is not available. Fixes: 2fec539112e8 ("i915/perf: Replace DRM_DEBUG with driver specific drm_dbg call") Suggested-by: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH v2 08/29] drm/dp: Add helpers to calculate the link BW overhead

2023-10-27 Thread Imre Deak
On Fri, Oct 27, 2023 at 06:48:44PM +0300, Ville Syrjälä wrote: > On Tue, Oct 24, 2023 at 01:22:17PM +0300, Imre Deak wrote: > > Add helpers drivers can use to calculate the BW allocation overhead - > > due to SSC, FEC, DSC and data alignment on symbol cycles - and the > > channel coding efficiency

[Intel-gfx] [PATCH] drm/i915/gt: Remove prohibited space after opening parenthesis

2023-10-27 Thread Dorcas AnonoLitunya
Removes space after opening parenthesis. Fixes the checkpatch.pl error: ERROR: space prohibited after that opening parenthesis '(' Signed-off-by: Dorcas AnonoLitunya --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Intel-gfx] [PATCH 25/29] drm/i915: Factor out function to clear pipe update flags

2023-10-27 Thread Imre Deak
On Fri, Oct 27, 2023 at 06:42:20PM +0300, Ville Syrjälä wrote: > On Tue, Oct 24, 2023 at 04:09:21AM +0300, Imre Deak wrote: > > Factor out a helper to clear the pipe update flags, used by a follow-up > > patch to modeset an MST topology. > > > > Signed-off-by: Imre Deak > > --- > >

Re: [Intel-gfx] [PATCH] i915/perf: Fix NULL deref bugs with drm_dbg() calls

2023-10-27 Thread Harshit Mogalapalli
Hi Tvrtko, On 27/10/23 8:17 pm, Tvrtko Ursulin wrote: On 27/10/2023 15:11, Andrzej Hajda wrote: On 27.10.2023 16:07, Harshit Mogalapalli wrote: When i915 perf interface is not available dereferencing it will lead to NULL dereferences. Fix this by using DRM_DEBUG() which the scenario before

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable Darkscreen Feature (rev2)

2023-10-27 Thread Patchwork
== Series Details == Series: Enable Darkscreen Feature (rev2) URL : https://patchwork.freedesktop.org/series/125563/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:1:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/pmu: add pmu_to_i915() helper (rev4)

2023-10-27 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/pmu: add pmu_to_i915() helper (rev4) URL : https://patchwork.freedesktop.org/series/125464/ State : success == Summary == CI Bug Log - changes from CI_DRM_13806 -> Patchwork_125464v4

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Darkscreen Feature (rev2)

2023-10-27 Thread Patchwork
== Series Details == Series: Enable Darkscreen Feature (rev2) URL : https://patchwork.freedesktop.org/series/125563/ State : warning == Summary == Error: dim checkpatch failed d1982e22b77c drm/i915/display: Add support for darskscreen detection Traceback (most recent call last): File

Re: [Intel-gfx] [PATCH v2] i915/perf: Fix NULL deref bugs with drm_dbg() calls

2023-10-27 Thread Tvrtko Ursulin
On 27/10/2023 18:28, Harshit Mogalapalli wrote: When i915 perf interface is not available dereferencing it will lead to NULL dereferences. As returning -ENOTSUPP is pretty clear return when perf interface is not available. Fixes: 2fec539112e8 ("i915/perf: Replace DRM_DEBUG with driver

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Apply notify_guc to all GTs (rev3)

2023-10-27 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Apply notify_guc to all GTs (rev3) URL : https://patchwork.freedesktop.org/series/125560/ State : success == Summary == CI Bug Log - changes from CI_DRM_13806 -> Patchwork_125560v3 Summary ---

[Intel-gfx] [PATCH v4] drm/i915/mtl: Add Wa_14019821291

2023-10-27 Thread Dnyaneshwar Bhadane
This workaround is primarily implemented by the BIOS. However if the BIOS applies the workaround it will reserve a small piece of our DSM (which should be at the top, right below the WOPCM); we just need to keep that region reserved so that nothing else attempts to re-use it. v2: Declare regs in

Re: [Intel-gfx] [PATCH v3] drm/i915/mtl: Add Wa_14019821291

2023-10-27 Thread Bhadane, Dnyaneshwar
> -Original Message- > From: Roper, Matthew D > Sent: Wednesday, October 25, 2023 11:41 PM > To: Bhadane, Dnyaneshwar > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v3] drm/i915/mtl: Add Wa_14019821291 > > On Wed, Oct 25, 2023 at 04:06:46PM +0530, Dnyaneshwar

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Add Wa_14019821291 (rev4)

2023-10-27 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add Wa_14019821291 (rev4) URL : https://patchwork.freedesktop.org/series/125282/ State : success == Summary == CI Bug Log - changes from CI_DRM_13806 -> Patchwork_125282v4 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev2)

2023-10-27 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev2) URL : https://patchwork.freedesktop.org/series/123813/ State : success == Summary == CI Bug Log - changes from CI_DRM_13806 -> Patchwork_123813v2 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for i915/perf: Fix NULL deref bugs with drm_dbg() calls (rev2)

2023-10-27 Thread Patchwork
== Series Details == Series: i915/perf: Fix NULL deref bugs with drm_dbg() calls (rev2) URL : https://patchwork.freedesktop.org/series/125692/ State : success == Summary == CI Bug Log - changes from CI_DRM_13806 -> Patchwork_125692v2

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Remove prohibited space after opening parenthesis

2023-10-27 Thread Patchwork
== Series Details == Series: drm/i915/gt: Remove prohibited space after opening parenthesis URL : https://patchwork.freedesktop.org/series/125707/ State : success == Summary == CI Bug Log - changes from CI_DRM_13806 -> Patchwork_125707v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Apply Wa_16018031267 / Wa_16018063123 (rev3)

2023-10-27 Thread Patchwork
== Series Details == Series: Apply Wa_16018031267 / Wa_16018063123 (rev3) URL : https://patchwork.freedesktop.org/series/125650/ State : warning == Summary == Error: dim checkpatch failed b1c2cbf3e4bd drm/i915: Reserve some kernel space per vm f174d3fba54d drm/i915: Add WABB blit for

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Apply Wa_16018031267 / Wa_16018063123 (rev3)

2023-10-27 Thread Patchwork
== Series Details == Series: Apply Wa_16018031267 / Wa_16018063123 (rev3) URL : https://patchwork.freedesktop.org/series/125650/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for Apply Wa_16018031267 / Wa_16018063123 (rev3)

2023-10-27 Thread Patchwork
== Series Details == Series: Apply Wa_16018031267 / Wa_16018063123 (rev3) URL : https://patchwork.freedesktop.org/series/125650/ State : success == Summary == CI Bug Log - changes from CI_DRM_13806 -> Patchwork_125650v3 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: Add Wa_14019821291 (rev4)

2023-10-27 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add Wa_14019821291 (rev4) URL : https://patchwork.freedesktop.org/series/125282/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev2)

2023-10-27 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev2) URL : https://patchwork.freedesktop.org/series/123813/ State : warning == Summary == Error: dim checkpatch failed 2cf2fda84a87 drm/i915: Enable Wa_16019325821 d54c40303399 drm/i915/guc: Add support for w/a

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev2)

2023-10-27 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev2) URL : https://patchwork.freedesktop.org/series/123813/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsb: DSB code refactoring (rev4)

2023-10-27 Thread Patchwork
== Series Details == Series: drm/i915/dsb: DSB code refactoring (rev4) URL : https://patchwork.freedesktop.org/series/124141/ State : success == Summary == CI Bug Log - changes from CI_DRM_13806 -> Patchwork_124141v4 Summary ---

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Enable Wa_16019325821

2023-10-27 Thread John Harrison
On 10/6/2023 17:10, Belgaumkar, Vinay wrote: On 9/15/2023 2:55 PM, john.c.harri...@intel.com wrote: From: John Harrison Some platforms require holding RCS context switches until CCS is idle (the reverse w/a of Wa_14014475959). Some platforms require both versions. Signed-off-by: John

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Move the g45 PEG band gap HPD workaround to the HPD code (rev5)

2023-10-27 Thread Patchwork
== Series Details == Series: drm/i915: Move the g45 PEG band gap HPD workaround to the HPD code (rev5) URL : https://patchwork.freedesktop.org/series/125053/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13806 -> Patchwork_125053v5

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Improve BW management on MST links (rev7)

2023-10-27 Thread Patchwork
== Series Details == Series: drm/i915: Improve BW management on MST links (rev7) URL : https://patchwork.freedesktop.org/series/125490/ State : success == Summary == CI Bug Log - changes from CI_DRM_13806 -> Patchwork_125490v7 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsb: DSB code refactoring (rev4)

2023-10-27 Thread Patchwork
== Series Details == Series: drm/i915/dsb: DSB code refactoring (rev4) URL : https://patchwork.freedesktop.org/series/124141/ State : warning == Summary == Error: dim checkpatch failed b71324c00655 drm/i915/dsb: DSB code refactoring Traceback (most recent call last): File

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dsb: DSB code refactoring (rev4)

2023-10-27 Thread Patchwork
== Series Details == Series: drm/i915/dsb: DSB code refactoring (rev4) URL : https://patchwork.freedesktop.org/series/124141/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 3/4] drm/i915/guc: Add support for w/a KLVs

2023-10-27 Thread John Harrison
On 10/6/2023 17:38, Belgaumkar, Vinay wrote: On 9/15/2023 2:55 PM, john.c.harri...@intel.com wrote: From: John Harrison To prevent running out of bits, new w/a enable flags are being added via a KLV system instead of a 32 bit flags word. Signed-off-by: John Harrison ---  

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bios: Clamp VBT HDMI level shift on BDW (rev4)

2023-10-27 Thread Patchwork
== Series Details == Series: drm/i915/bios: Clamp VBT HDMI level shift on BDW (rev4) URL : https://patchwork.freedesktop.org/series/125120/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13806 -> Patchwork_125120v4 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: DPLL code cleanups (rev5)

2023-10-27 Thread Patchwork
== Series Details == Series: drm/i915: DPLL code cleanups (rev5) URL : https://patchwork.freedesktop.org/series/125052/ State : success == Summary == CI Bug Log - changes from CI_DRM_13806 -> Patchwork_125052v5 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enable Darkscreen Feature (rev2)

2023-10-27 Thread Patchwork
== Series Details == Series: Enable Darkscreen Feature (rev2) URL : https://patchwork.freedesktop.org/series/125563/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13806 -> Patchwork_125563v2 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Improve BW management on MST links (rev7)

2023-10-27 Thread Patchwork
== Series Details == Series: drm/i915: Improve BW management on MST links (rev7) URL : https://patchwork.freedesktop.org/series/125490/ State : warning == Summary == Error: dim checkpatch failed 204af169ab67 drm/dp_mst: Fix fractional DSC bpp handling 2560fe42da5d drm/dp_mst: Add helper to

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Improve BW management on MST links (rev7)

2023-10-27 Thread Patchwork
== Series Details == Series: drm/i915: Improve BW management on MST links (rev7) URL : https://patchwork.freedesktop.org/series/125490/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v2 4/4] drm/i915/mtl: Add module parameter override for Wa_16019325821/Wa_14019159160

2023-10-27 Thread John . C . Harrison
From: John Harrison These w/a's can have signficant performance implications for any workload which uses both RCS and CCS. On the other hand, the hang itself is only seen in one or two very specific workloads. So add a module parameter to control whether the w/a's are enabled or not and default

[Intel-gfx] [PATCH v2 3/4] drm/i915/guc: Enable Wa_14019159160

2023-10-27 Thread John . C . Harrison
From: John Harrison Use the new w/a KLV support to enable a MTL w/a. Note, this w/a is a super-set of Wa_16019325821, so requires turning that one as well as setting the new flag for Wa_14019159160 itself. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 3 ++

[Intel-gfx] [PATCH v2 2/4] drm/i915/guc: Add support for w/a KLVs

2023-10-27 Thread John . C . Harrison
From: John Harrison To prevent running out of bits, new w/a enable flags are being added via a KLV system instead of a 32 bit flags word. Signed-off-by: John Harrison --- .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h | 1 + drivers/gpu/drm/i915/gt/uc/intel_guc.h| 2 +

[Intel-gfx] [PATCH v2 0/4] Enable Wa_14019159160 and Wa_16019325821 for MTL

2023-10-27 Thread John . C . Harrison
From: John Harrison Enable Wa_14019159160 and Wa_16019325821 for MTL RCS/CCS workarounds for MTL. v2: Fix bug in WA KLV implementation (offset not being reset to start of list). Add better comment to prep patch about how KLVs can be added. Add a module parameter override and disable the w/a

[Intel-gfx] [PATCH v2 1/4] drm/i915: Enable Wa_16019325821

2023-10-27 Thread John . C . Harrison
From: John Harrison Some platforms require holding RCS context switches until CCS is idle (the reverse w/a of Wa_14014475959). Some platforms require both versions. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 19 +++

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: DPLL code cleanups (rev5)

2023-10-27 Thread Patchwork
== Series Details == Series: drm/i915: DPLL code cleanups (rev5) URL : https://patchwork.freedesktop.org/series/125052/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.