Re: ✗ Fi.CI.IGT: failure for drm/i915/dp: Fix connector DSC HW state readout (rev2)

2024-03-05 Thread Imre Deak
On Fri, Mar 01, 2024 at 08:00:41PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dp: Fix connector DSC HW state readout (rev2) > URL : https://patchwork.freedesktop.org/series/129540/ > State : failure Thanks for the report/testing and review, patch is pushed to

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Use drm_printer more (rev5)

2024-03-05 Thread Patchwork
== Series Details == Series: drm/i915: Use drm_printer more (rev5) URL : https://patchwork.freedesktop.org/series/129956/ State : warning == Summary == Error: dim checkpatch failed 3de64739aac8 drm/i915: Indicate which pipe failed the fastset check overall 84cc770bca09 drm/i915: Include CRTC

✗ Fi.CI.SPARSE: warning for drm/i915: Use drm_printer more (rev5)

2024-03-05 Thread Patchwork
== Series Details == Series: drm/i915: Use drm_printer more (rev5) URL : https://patchwork.freedesktop.org/series/129956/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH v3] drm/i915/guc: Use context hints for GT frequency

2024-03-05 Thread Ivan Briano
On Mon, Mar 4, 2024, at 3:34 PM, Vinay Belgaumkar wrote: > Allow user to provide a low latency context hint. When set, KMD > sends a hint to GuC which results in special handling for this > context. SLPC will ramp the GT frequency aggressively every time > it switches to this context. The down

✓ Fi.CI.BAT: success for drm/i915/dsi: Go back to the previous INIT_OTP/DISPLAY_ON order, mostly

2024-03-05 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Go back to the previous INIT_OTP/DISPLAY_ON order, mostly URL : https://patchwork.freedesktop.org/series/130714/ State : success == Summary == CI Bug Log - changes from CI_DRM_14392 -> Patchwork_130714v1

Re: [PATCH 2/2] drm/i915: Implement vblank synchronized MBUS join changes

2024-03-05 Thread Paz Zcharya
On Wed, Feb 28, 2024 at 10:02:13AM +0200, Stanislav Lisovskiy wrote: > Currently we can't change MBUS join status without doing a modeset, > because we are lacking mechanism to synchronize those with vblank. > However then this means that we can't do a fastset, if there is a need > to change MBUS

✗ Fi.CI.BAT: failure for drm/i915: Make crtc disable more atomic

2024-03-05 Thread Patchwork
== Series Details == Series: drm/i915: Make crtc disable more atomic URL : https://patchwork.freedesktop.org/series/130715/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14392 -> Patchwork_130715v1 Summary ---

Re: [PATCH v3 2/4] drm/i915/gt: Do not exposed fused off engines.

2024-03-05 Thread Matt Roper
On Fri, Mar 01, 2024 at 12:28:57AM +0100, Andi Shyti wrote: > Some of the CCS engines are disabled. They should not be listed > in the uabi_engine list, that is the list of engines that the > user can see. Fused off engines already aren't visible to userspace (or to the kernel for that matter).

✗ Fi.CI.CHECKPATCH: warning for drm/ci: update device type for volteer devices (rev2)

2024-03-05 Thread Patchwork
== Series Details == Series: drm/ci: update device type for volteer devices (rev2) URL : https://patchwork.freedesktop.org/series/130723/ State : warning == Summary == Error: dim checkpatch failed 1f2ef535a742 drm/ci: update device type for volteer devices -:16: WARNING:BAD_FIXES_TAG: Please

✗ Fi.CI.BAT: failure for drm/ci: update device type for volteer devices (rev2)

2024-03-05 Thread Patchwork
== Series Details == Series: drm/ci: update device type for volteer devices (rev2) URL : https://patchwork.freedesktop.org/series/130723/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14393 -> Patchwork_130723v2 Summary

Re: [PATCH v3 3/4] drm/ttm, drm/amdgpu, drm/xe: Consider hitch moves within bulk sublist moves

2024-03-05 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip] [cannot apply to drm-intel/for-linux-next-fixes linus/master v6.8-rc7 next-20240305] [If your patch

✗ Fi.CI.BAT: failure for drm/i915: Use drm_printer more (rev5)

2024-03-05 Thread Patchwork
== Series Details == Series: drm/i915: Use drm_printer more (rev5) URL : https://patchwork.freedesktop.org/series/129956/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14393 -> Patchwork_129956v5 Summary ---

Re: [PATCH v3] drm/i915/guc: Use context hints for GT frequency

2024-03-05 Thread Rodrigo Vivi
On Mon, Mar 04, 2024 at 03:34:50PM -0800, Vinay Belgaumkar wrote: > Allow user to provide a low latency context hint. When set, KMD > sends a hint to GuC which results in special handling for this > context. SLPC will ramp the GT frequency aggressively every time > it switches to this context. The

✗ Fi.CI.BAT: failure for drm/i915/dp: Enable AUX based backlight for HDR

2024-03-05 Thread Patchwork
== Series Details == Series: drm/i915/dp: Enable AUX based backlight for HDR URL : https://patchwork.freedesktop.org/series/130729/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14393 -> Patchwork_130729v1 Summary ---

✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: Go back to the previous INIT_OTP/DISPLAY_ON order, mostly

2024-03-05 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Go back to the previous INIT_OTP/DISPLAY_ON order, mostly URL : https://patchwork.freedesktop.org/series/130714/ State : warning == Summary == Error: dim checkpatch failed 916e57569f78 drm/i915/dsi: Go back to the previous INIT_OTP/DISPLAY_ON order,

Re: [PATCH 1/2] drm/i915: Update mbus in intel_dbuf_mbus_update and do it properly

2024-03-05 Thread Paz Zcharya
On Wed, Feb 28, 2024 at 10:02:12AM +0200, Stanislav Lisovskiy wrote: > According to BSpec we need to do correspondent MBUS updates before > or after DBUF reallocation, depending on whether we are reducing > or increasing amount of pipes(typical scenario is swithing between > multiple and single

✗ Fi.CI.BUILD: failure for drm: enable W=1 warnings by default across the subsystem (rev4)

2024-03-05 Thread Patchwork
== Series Details == Series: drm: enable W=1 warnings by default across the subsystem (rev4) URL : https://patchwork.freedesktop.org/series/127072/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/127072/revisions/4/mbox/ not applied Applying: drm:

✗ Fi.CI.SPARSE: warning for drm/i915: Fix VMA UAF on destroy against deactivate race (rev5)

2024-03-05 Thread Patchwork
== Series Details == Series: drm/i915: Fix VMA UAF on destroy against deactivate race (rev5) URL : https://patchwork.freedesktop.org/series/129026/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH v2 3/3] drm/i915/bios: abstract child device expected size

2024-03-05 Thread Chauhan, Shekhar
On 3/5/2024 16:43, Jani Nikula wrote: On Tue, 05 Mar 2024, "Chauhan, Shekhar" wrote: On 2/26/2024 23:28, Jani Nikula wrote: Add a function to return the expected child device size. Flip the if ladder around and use the same versions as in documentation to make it easier to verify. Return an

✗ Fi.CI.SPARSE: warning for IO and fast wake lines calculation and increase fw sync length (rev3)

2024-03-05 Thread Patchwork
== Series Details == Series: IO and fast wake lines calculation and increase fw sync length (rev3) URL : https://patchwork.freedesktop.org/series/130173/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.SPARSE: warning for drm/i915: Unpin cursor fb only after vblank.

2024-03-05 Thread Patchwork
== Series Details == Series: drm/i915: Unpin cursor fb only after vblank. URL : https://patchwork.freedesktop.org/series/130746/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Unpin cursor fb only after vblank.

2024-03-05 Thread Patchwork
== Series Details == Series: drm/i915: Unpin cursor fb only after vblank. URL : https://patchwork.freedesktop.org/series/130746/ State : warning == Summary == Error: dim checkpatch failed eb5c989a767b drm: Add drm_vblank_work_flush_all(). -:33: WARNING:WAITQUEUE_ACTIVE: waitqueue_active

[PATCH v4] drm/i915/guc: Use context hints for GT frequency

2024-03-05 Thread Vinay Belgaumkar
Allow user to provide a low latency context hint. When set, KMD sends a hint to GuC which results in special handling for this context. SLPC will ramp the GT frequency aggressively every time it switches to this context. The down freq threshold will also be lower so GuC will ramp down the GT freq

✗ Fi.CI.CHECKPATCH: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev4)

2024-03-05 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev4) URL : https://patchwork.freedesktop.org/series/130335/ State : warning == Summary == Error: dim checkpatch failed cae3f3729701 drm/i915: Enable Wa_16019325821 2048664461bf drm/i915/guc: Add support for w/a

✗ Fi.CI.SPARSE: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev4)

2024-03-05 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev4) URL : https://patchwork.freedesktop.org/series/130335/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for drm/i915: Unpin cursor fb only after vblank.

2024-03-05 Thread Patchwork
== Series Details == Series: drm/i915: Unpin cursor fb only after vblank. URL : https://patchwork.freedesktop.org/series/130746/ State : success == Summary == CI Bug Log - changes from CI_DRM_14393 -> Patchwork_130746v1 Summary ---

[PATCH 3/4] drm/xe: Use gsc_proxy_init_done to check proxy status

2024-03-05 Thread Suraj Kandpal
Expose gsc_proxy_init_done so that we can check if gsc proxy has been initialized or not. --v2 -Check if GSC FW is enabled before taking forcewake ref [Daniele] --v3 -Directly call proxy check function inside if condition Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy Reviewed-by:

[PATCH 1/4] drm/i915/hdcp: Move intel_hdcp_gsc_message def away from header file

2024-03-05 Thread Suraj Kandpal
Move intel_hdcp_gsc_message definition into intel_hdcp_gsc.c so that intel_hdcp_gsc_message can be redefined for xe as needed. --v2 -Correct commit message to reflect what patch is actually doing [Arun] Signed-off-by: Suraj Kandpal Acked-by: Jani Nikula ---

[PATCH 0/4] XE HDCP Enablement

2024-03-05 Thread Suraj Kandpal
This patch series enables HDCP on XE. Mainly includes rewriting functions that were responsible for sending hdcp messages via gsc cs. Signed-off-by: Suraj Kandpal Acked-by: Lucas De Marchi Suraj Kandpal (4): drm/i915/hdcp: Move intel_hdcp_gsc_message def away from header file drm/xe/hdcp:

[PATCH 4/4] drm/xe/hdcp: Enable HDCP for XE

2024-03-05 Thread Suraj Kandpal
Enable HDCP for Xe by defining functions which take care of interaction of HDCP as a client with the GSC CS interface. Add intel_hdcp_gsc_message to Makefile and add corresponding changes to xe_hdcp_gsc.c to make it build. --v2 -add kfree at appropriate place [Daniele] -remove useless define

[PATCH 2/4] drm/xe/hdcp: Use xe_device struct

2024-03-05 Thread Suraj Kandpal
Use xe_device struct instead of drm_i915_private so as to not cause confusion and comply with Xe standards as drm_i915_private is xe_device under the hood. --v2 -Fix commit message [Daniele] Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy --- drivers/gpu/drm/xe/display/xe_hdcp_gsc.c |

[PATCH 1/4] drm/i915/hdcp: Move intel_hdcp_gsc_message def away from header file

2024-03-05 Thread Suraj Kandpal
Move intel_hdcp_gsc_message definition into intel_hdcp_gsc.c so that intel_hdcp_gsc_message can be redefined for xe as needed. --v2 -Correct commit message to reflect what patch is actually doing [Arun] Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy Acked-by: Jani Nikula ---

✗ Fi.CI.BUILD: failure for TTM unlockable restartable LRU list iteration (rev3)

2024-03-05 Thread Patchwork
== Series Details == Series: TTM unlockable restartable LRU list iteration (rev3) URL : https://patchwork.freedesktop.org/series/130001/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC [M]

✗ Fi.CI.BUILD: failure for Regression on linux-next (next-20240228)

2024-03-05 Thread Patchwork
== Series Details == Series: Regression on linux-next (next-20240228) URL : https://patchwork.freedesktop.org/series/130763/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/130763/revisions/1/mbox/ not applied Applying: Regression on linux-next

✓ Fi.CI.BAT: success for IO and fast wake lines calculation and increase fw sync length (rev3)

2024-03-05 Thread Patchwork
== Series Details == Series: IO and fast wake lines calculation and increase fw sync length (rev3) URL : https://patchwork.freedesktop.org/series/130173/ State : success == Summary == CI Bug Log - changes from CI_DRM_14393 -> Patchwork_130173v3

[PATCH v4 0/3] Disable automatic load CCS load balancing

2024-03-05 Thread Andi Shyti
Hi, I have to admit that v3 was a lazy attempt. This one should be on the right path. this series does basically two things: 1. Disables automatic load balancing as adviced by the hardware workaround. 2. Assigns all the CCS slices to one single user engine. The user will then be able to

[PATCH v4 1/3] drm/i915/gt: Disable HW load balancing for CCS

2024-03-05 Thread Andi Shyti
The hardware should not dynamically balance the load between CCS engines. Wa_14019159160 recommends disabling it across all platforms. Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement") Signed-off-by: Andi Shyti Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Matt Roper Cc: # v6.2+

✗ Fi.CI.BAT: failure for drm/i915: Fix VMA UAF on destroy against deactivate race (rev5)

2024-03-05 Thread Patchwork
== Series Details == Series: drm/i915: Fix VMA UAF on destroy against deactivate race (rev5) URL : https://patchwork.freedesktop.org/series/129026/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14393 -> Patchwork_129026v5

[PATCH v4 3/3] drm/i915/gt: Enable only one CCS for compute workload

2024-03-05 Thread Andi Shyti
Enable only one CCS engine by default with all the compute sices allocated to it. While generating the list of UABI engines to be exposed to the user, exclude any additional CCS engines beyond the first instance. This change can be tested with igt i915_query. Fixes: d2eae8e98d59 ("drm/i915/dg2:

[PATCH v4 2/3] drm/i915/gt: Refactor uabi engine class/instance list creation

2024-03-05 Thread Andi Shyti
For the upcoming changes we need a cleaner way to build the list of uabi engines. Suggested-by: Tvrtko Ursulin Signed-off-by: Andi Shyti Cc: # v6.2+ --- drivers/gpu/drm/i915/gt/intel_engine_user.c | 29 - 1 file changed, 17 insertions(+), 12 deletions(-) diff --git

[PATCH] drm/i915/display: Fixed a screen flickering when turning on display from off

2024-03-05 Thread gareth . yu
From: Gareth Yu Turn on the panel from zero brightness of the last state, the panel was set a maximum PWM in the flow. Once the panel initialization is completed, the backlight is restored to zero brightness. There is a flckering generated. Set the brightness to the minimum value when the

[PATCH 3/3] drm/i915/dsb: Always set DSB_SKIP_WAITS_EN

2024-03-05 Thread Ville Syrjala
From: Ville Syrjälä Bspec asks us to always set the DSB_SKIP_WAITS_EN bit in DSB_CHICKEN. This seems to instruct DSB to skip vblank and scanline waits when PSR is entered. I don't think we have any cases currently where we would want to enter PSR while DSB is waiting for something, but let's

[PATCH 2/3] drm/i915/dsb: Fix DSB vblank waits when using VRR

2024-03-05 Thread Ville Syrjala
From: Ville Syrjälä Looks like the undelayed vblank gets signalled exactly when the active period ends. That is a problem for DSB+VRR when we are already in vblank and expect DSB to start executing as soon as we send the push. Instead of starting the DSB just keeps on waiting for the undelayed

[PATCH 0/3] drm/i915: Fix DSB vblank waits with VRR

2024-03-05 Thread Ville Syrjala
From: Ville Syrjälä Make DSB vblank waits work correctly when VRR is enabled. Ville Syrjälä (3): drm/i915/vrr: Generate VRR "safe window" for DSB drm/i915/dsb: Fix DSB vblank waits when using VRR drm/i915/dsb: Always set DSB_SKIP_WAITS_EN drivers/gpu/drm/i915/display/intel_dsb.c | 15

[PATCH 1/3] drm/i915/vrr: Generate VRR "safe window" for DSB

2024-03-05 Thread Ville Syrjala
From: Ville Syrjälä Looks like TRANS_CHICKEN bit 31 means something totally different depending on the platform: TGL: generate VRR "safe window" for DSB ADL/DG2: make TRANS_SET_CONTEXT_LATENCY effective with VRR So far we've only set this on ADL/DG2, but when using DSB+VRR we also need to set

✗ Fi.CI.CHECKPATCH: warning for Disable automatic load CCS load balancing (rev5)

2024-03-05 Thread Patchwork
== Series Details == Series: Disable automatic load CCS load balancing (rev5) URL : https://patchwork.freedesktop.org/series/129951/ State : warning == Summary == Error: dim checkpatch failed 5b93f1cd8989 drm/i915/gt: Disable HW load balancing for CCS 380b317702a8 drm/i915/gt: Refactor uabi

✗ Fi.CI.BAT: failure for Disable automatic load CCS load balancing (rev5)

2024-03-05 Thread Patchwork
== Series Details == Series: Disable automatic load CCS load balancing (rev5) URL : https://patchwork.freedesktop.org/series/129951/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14395 -> Patchwork_129951v5 Summary ---

[PATCH v4 2/4] drm/ttm: Use LRU hitches

2024-03-05 Thread Thomas Hellström
Have iterators insert themselves into the list they are iterating over using hitch list nodes. Since only the iterator owner can remove these list nodes from the list, it's safe to unlock the list and when continuing, use them as a starting point. Due to the way LRU bumping works in TTM, newly

[PATCH v4 4/4] drm/ttm: Allow continued swapout after -ENOSPC falure

2024-03-05 Thread Thomas Hellström
The -ENOSPC failure from ttm_bo_swapout() meant that the lru_lock was dropped and simply restarting the iteration meant we'd likely hit the same error again on the same resource. Now that we can restart the iteration even if the lock was dropped, do that. Cc: Christian König Cc: Somalapuram

[PATCH v4 1/4] drm/ttm: Allow TTM LRU list nodes of different types

2024-03-05 Thread Thomas Hellström
To be able to handle list unlocking while traversing the LRU list, we want the iterators not only to point to the next position of the list traversal, but to insert themselves as list nodes at that point to work around the fact that the next node might otherwise disappear from the list while the

[PATCH v4 3/4] drm/ttm, drm/amdgpu, drm/xe: Consider hitch moves within bulk sublist moves

2024-03-05 Thread Thomas Hellström
To address the problem with hitches moving when bulk move sublists are lru-bumped, register the list cursors with the ttm_lru_bulk_move structure when traversing its list, and when lru-bumping the list, move the cursor hitch to the tail. This also means it's mandatory for drivers to call

[PATCH v4 0/4] TTM unlockable restartable LRU list iteration

2024-03-05 Thread Thomas Hellström
This patch-set is a prerequisite for a standalone TTM shrinker and for exhaustive TTM eviction using sleeping dma_resv locks, which is the motivation for it. Currently when unlocking the TTM lru list lock, iteration needs to be restarted from the beginning, rather from the next LRU list node.

[bug report] drm/i915/dp: Add support for DP tunnel BW allocation

2024-03-05 Thread Dan Carpenter
Hello Imre Deak, The patch 91888b5b1ad2: "drm/i915/dp: Add support for DP tunnel BW allocation" from Feb 26, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/i915/display/intel_dp_tunnel.c:793 intel_dp_tunnel_mgr_init() warn: 'tunnel_mgr'

Re: [PATCH v3 3/5] drm/i915/psr: Calculate IO wake and fast wake lines for DISPLAY_VER < 12

2024-03-05 Thread kernel test robot
Hi Jouni, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip next-20240305] [cannot apply to drm-intel/for-linux-next-fixes linus/master v6.8-rc7] [If your patch is applied to the wrong git

✗ Fi.CI.BAT: failure for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev4)

2024-03-05 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev4) URL : https://patchwork.freedesktop.org/series/130335/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14395 -> Patchwork_130335v4 Summary

✗ Fi.CI.SPARSE: warning for drm/i915/guc: Use context hints for GT frequency (rev2)

2024-03-05 Thread Patchwork
== Series Details == Series: drm/i915/guc: Use context hints for GT frequency (rev2) URL : https://patchwork.freedesktop.org/series/130698/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for drm/i915/guc: Use context hints for GT frequency (rev2)

2024-03-05 Thread Patchwork
== Series Details == Series: drm/i915/guc: Use context hints for GT frequency (rev2) URL : https://patchwork.freedesktop.org/series/130698/ State : success == Summary == CI Bug Log - changes from CI_DRM_14395 -> Patchwork_130698v2 Summary

✗ Fi.CI.SPARSE: warning for XE HDCP Enablement (rev10)

2024-03-05 Thread Patchwork
== Series Details == Series: XE HDCP Enablement (rev10) URL : https://patchwork.freedesktop.org/series/129456/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./arch/x86/include/asm/bitops.h:116:1:

Re: [PATCH 5/8] drm/i915: Precompute disable_pipes bitmask in intel_commit_modeset_disables()

2024-03-05 Thread Lisovskiy, Stanislav
On Fri, Mar 01, 2024 at 04:35:57PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Copy the pipe bitmask based approach skl_commit_modeset_enables() > into intel_commit_modeset_disables(). This avoids doing so many > duplicated checks in all the loops, and also let's us WARN at the > end

Re: [PATCH 1/8] drm/i915: Rename the crtc/crtc_states in the top level DDI hooks/etc

2024-03-05 Thread Ville Syrjälä
On Tue, Mar 05, 2024 at 10:41:49AM +0200, Lisovskiy, Stanislav wrote: > On Fri, Mar 01, 2024 at 04:35:53PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > In preparation for doing a more sensible pipe vs. transcoder > > handling for bigjoiner let's rename the crtc/crtc_state in the >

Re: [PATCH 7/8] drm/i915: Simplify intel_old_crtc_state_disables() calling convention

2024-03-05 Thread Lisovskiy, Stanislav
On Fri, Mar 01, 2024 at 04:35:59PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Stop passing in so much redundant stuff to > intel_old_crtc_state_disables(). Top level atomic state + crtc > is all we need. > > Signed-off-by: Ville Syrjälä Reviewed-by: Stanislav Lisovskiy > --- >

[RESEND v3 1/2] drm: enable (most) W=1 warnings by default across the subsystem

2024-03-05 Thread Jani Nikula
At least the i915 and amd drivers enable a bunch more compiler warnings than the kernel defaults. Extend most of the W=1 warnings to the entire drm subsystem by default. Use the copy-pasted warnings from scripts/Makefile.extrawarn with s/KBUILD_CFLAGS/subdir-ccflags-y/ to make it easier to

[RESEND v3 2/2] drm: Add CONFIG_DRM_WERROR

2024-03-05 Thread Jani Nikula
Add kconfig to enable -Werror subsystem wide. This is useful for development and CI to keep the subsystem warning free, while avoiding issues outside of the subsystem that kernel wide CONFIG_WERROR=y might hit. v2: Don't depend on COMPILE_TEST Reviewed-by: Hamza Mahfooz # v1 Signed-off-by: Jani

Re: [PATCH 1/8] drm/i915: Rename the crtc/crtc_states in the top level DDI hooks/etc

2024-03-05 Thread Lisovskiy, Stanislav
On Tue, Mar 05, 2024 at 10:50:01AM +0200, Ville Syrjälä wrote: > On Tue, Mar 05, 2024 at 10:41:49AM +0200, Lisovskiy, Stanislav wrote: > > On Fri, Mar 01, 2024 at 04:35:53PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > In preparation for doing a more sensible pipe vs.

Re: [PATCH 1/8] drm/i915: Rename the crtc/crtc_states in the top level DDI hooks/etc

2024-03-05 Thread Lisovskiy, Stanislav
On Fri, Mar 01, 2024 at 04:35:53PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > In preparation for doing a more sensible pipe vs. transcoder > handling for bigjoiner let's rename the crtc/crtc_state in the > top level crtc_enable/disable and the DDI encoder hooks to > include "master"

[PATCH 0/3] drm/i915: Make crtc disable more atomic

2024-03-05 Thread Ville Syrjala
From: Ville Syrjälä Make the crtc disable more atomic (in terms of plane disable). And also also track which pipes need disabling in the same way as skl_commit_modeset_enables(), which should make the whole thing bit less messy as we don't have to keep on checking the same conditions multiple

[PATCH 1/3] drm/i915: Precompute disable_pipes bitmask in intel_commit_modeset_disables()

2024-03-05 Thread Ville Syrjala
From: Ville Syrjälä Copy the pipe bitmask based approach skl_commit_modeset_enables() into intel_commit_modeset_disables(). This avoids doing so many duplicated checks in all the loops, and also let's us WARN at the end if we screwed up somewhere and forgot to disable some pipe. Signed-off-by:

[PATCH 2/3] drm/i915: Disable planes more atomically during modesets

2024-03-05 Thread Ville Syrjala
From: Ville Syrjälä Follow in the footsteps of commit c610e841f19d ("drm/i915: Do plane/etc. updates more atomically across pipes") and do the plane disables back to back for all pipes also when we are disabling pipes. This should provide for a potentially more atomic user experience, which

[PATCH 3/3] drm/i915: Simplify intel_old_crtc_state_disables() calling convention

2024-03-05 Thread Ville Syrjala
From: Ville Syrjälä Stop passing in so much redundant stuff to intel_old_crtc_state_disables(). Top level atomic state + crtc is all we need. And while at it constify the states to make it clear they should not be mutated. Signed-off-by: Ville Syrjälä ---

Re: [PATCH 3/8] drm/i915: Extract intel_ddi_post_disable_hdmi_or_sst()

2024-03-05 Thread Lisovskiy, Stanislav
On Fri, Mar 01, 2024 at 04:35:55PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Extract the "not-MST" stuff from intel_ddi_post_disable() so that > the whole thing isn't so cluttered. > > The bigjoiner slave handling was outside of the !MST check, > but it really should have been

[RESEND v3 0/2] drm: enable W=1 warnings by default across the subsystem

2024-03-05 Thread Jani Nikula
Resend of [1] with an intent to merge after the CI results come in. This is aiming for v6.10, so we'll have maximal time to find all the issues my configs didn't catch. I built this on x86-64 (both gcc and clang), arm and arm64, and everything passed. BR, Jani. [1]

[PATCH] drm/i915/dsi: Go back to the previous INIT_OTP/DISPLAY_ON order, mostly

2024-03-05 Thread Ville Syrjala
From: Ville Syrjälä Reinstate commit 88b065943cb5 ("drm/i915/dsi: Do display on sequence later on icl+"), for the most part. Turns out some machines (eg. Chuwi Minibook X) really do need that updated order. It is also the order the Windows driver uses. However we can't just undo the revert

Re: [PATCH] MAINTAINERS: Update email address for Tvrtko Ursulin

2024-03-05 Thread Daniel Vetter
On Wed, Feb 28, 2024 at 02:22:40PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > I will lose access to my @.*intel.com e-mail addresses soon so let me > adjust the maintainers entry and update the mailmap too. > > While at it consolidate a few other of my old emails to point to the >

Re: [PATCH 6/8] drm/i915: Disable planes more atomically during modesets

2024-03-05 Thread Lisovskiy, Stanislav
On Fri, Mar 01, 2024 at 04:35:58PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Follow in the footsteps of commit c610e841f19d ("drm/i915: > Do plane/etc. updates more atomically across pipes") and > do the plane disables back to back for all pipes also when > we are disabling pipes. >

Re: [PATCH 08/12] drm/i915: Convert the remaining state dump to drm_printer

2024-03-05 Thread Jani Nikula
On Thu, 15 Feb 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Plumb the drm_printer to all the little helpers called > by intel_crtc_state_dump() and use it there as well. > > The exceptions are the ELD and infoframe stuff as they > call helpers outside of the drm and thus can't use >

Re: [PATCH 1/8] drm/i915: Rename the crtc/crtc_states in the top level DDI hooks/etc

2024-03-05 Thread Ville Syrjälä
On Tue, Mar 05, 2024 at 11:08:56AM +0200, Lisovskiy, Stanislav wrote: > On Tue, Mar 05, 2024 at 10:50:01AM +0200, Ville Syrjälä wrote: > > On Tue, Mar 05, 2024 at 10:41:49AM +0200, Lisovskiy, Stanislav wrote: > > > On Fri, Mar 01, 2024 at 04:35:53PM +0200, Ville Syrjala wrote: > > > > From: Ville

[PATCH v2] drm/ci: update device type for volteer devices

2024-03-05 Thread Vignesh Raman
Volteer devices in the collabora lab are categorized under the asus-cx9400-volteer device type. The majority of these units has an Intel Core i5-1130G7 CPU, while some of them have a Intel Core i7-1160G7 CPU instead. So due to this difference, new device type template is added for the Intel Core

[PATCH] drm/i915/dp: Enable AUX based backlight for HDR

2024-03-05 Thread Suraj Kandpal
As of now whenerver HDR is switched on we use the PWM to change the backlight as opposed to AUX based backlight changes in terms of nits. This patch writes to the appropriate DPCD registers to enable aux based backlight using values in nits. Signed-off-by: Suraj Kandpal ---

Re: [RESEND v3 0/2] drm: enable W=1 warnings by default across the subsystem

2024-03-05 Thread Maxime Ripard
On Tue, 5 Mar 2024 11:07:34 +0200, Jani Nikula wrote: > Resend of [1] with an intent to merge after the CI results come in. This > is aiming for v6.10, so we'll have maximal time to find all the issues > my configs didn't catch. > > I built this on x86-64 (both gcc and clang), arm and arm64, and

[PATCH v2 3/4] drm/ttm, drm/amdgpu, drm/xe: Consider hitch moves within bulk sublist moves

2024-03-05 Thread Thomas Hellström
To address the problem with hitches moving when bulk move sublists are lru-bumped, register the list cursors with the ttm_lru_bulk_move structure when traversing its list, and when lru-bumping the list, move the cursor hitch to the tail. This also means it's mandatory for drivers to call

[PATCH v2 1/4] drm/ttm: Allow TTM LRU list nodes of different types

2024-03-05 Thread Thomas Hellström
To be able to handle list unlocking while traversing the LRU list, we want the iterators not only to point to the next position of the list traversal, but to insert themselves as list nodes at that point to work around the fact that the next node might otherwise disappear from the list while the

[PATCH v2 0/4] TTM unlockable restartable LRU list iteration

2024-03-05 Thread Thomas Hellström
This patch-set is a prerequisite for a standalone TTM shrinker and for exhaustive TTM eviction using sleeping dma_resv locks, which is the motivation for it. Currently when unlocking the TTM lru list lock, iteration needs to be restarted from the beginning, rather from the next LRU list node.

[PATCH v2 2/4] drm/ttm: Use LRU hitches

2024-03-05 Thread Thomas Hellström
Have iterators insert themselves into the list they are iterating over using hitch list nodes. Since only the iterator owner can remove these list nodes from the list, it's safe to unlock the list and when continuing, use them as a starting point. Due to the way LRU bumping works in TTM, newly

[PATCH v2 4/4] drm/ttm: Allow continued swapout after -ENOSPC falure

2024-03-05 Thread Thomas Hellström
The -ENOSPC failure from ttm_bo_swapout() meant that the lru_lock was dropped and simply restarting the iteration meant we'd likely hit the same error again on the same resource. Now that we can restart the iteration even if the lock was dropped, do that. Cc: Christian König Cc: Somalapuram

Reminder: 2024 X.Org Board of Directors Elections timeline extended, request for nominations

2024-03-05 Thread Christopher Michael
This is a reminder that we are still looking for candidates for the upcoming X.Org Board of Directors elections, and that membership renewals are still open and will be needed to vote on those elections. Please read below for more details. Cheers, Christopher Michael, on behalf of the X.Org

Re: [PATCH v8 3/3] drm/buddy: Add user for defragmentation

2024-03-05 Thread Paneer Selvam, Arunpravin
On 3/5/2024 4:33 PM, Paneer Selvam, Arunpravin wrote: Hi Christian, On 3/4/2024 10:09 PM, Christian König wrote: Am 04.03.24 um 17:32 schrieb Arunpravin Paneer Selvam: Add amdgpu driver as user for the drm buddy defragmentation. Signed-off-by: Arunpravin Paneer Selvam ---  

Re: [PATCH v2 3/3] drm/i915/bios: abstract child device expected size

2024-03-05 Thread Jani Nikula
On Tue, 05 Mar 2024, "Chauhan, Shekhar" wrote: > On 2/26/2024 23:28, Jani Nikula wrote: >> Add a function to return the expected child device size. Flip the if >> ladder around and use the same versions as in documentation to make it >> easier to verify. Return an error for unknown versions. No

Re: [RESEND v3 2/2] drm: Add CONFIG_DRM_WERROR

2024-03-05 Thread Javier Martinez Canillas
Jani Nikula writes: Hello Jani, > Add kconfig to enable -Werror subsystem wide. This is useful for > development and CI to keep the subsystem warning free, while avoiding > issues outside of the subsystem that kernel wide CONFIG_WERROR=y might > hit. > > v2: Don't depend on COMPILE_TEST > >

Re: [PATCH v3 1/4] drm/i915/gt: Refactor uabi engine class/instance list creation

2024-03-05 Thread Joonas Lahtinen
Quoting Andi Shyti (2024-03-01 01:28:56) > For the upcoming changes we need a cleaner way to build the list > of uabi engines. > > Suggested-by: Tvrtko Ursulin > Signed-off-by: Andi Shyti > --- > drivers/gpu/drm/i915/gt/intel_engine_user.c | 29 - > 1 file changed, 17

Re: [PATCH v3 1/4] drm/i915/gt: Refactor uabi engine class/instance list creation

2024-03-05 Thread Andi Shyti
Hi Joonas, ... > > void intel_engines_driver_register(struct drm_i915_private *i915) > > { > > - u16 name_instance, other_instance = 0; > > + u16 class_instance[I915_LAST_UABI_ENGINE_CLASS + 1] = { }; > > Do you mean this to be size I915_LAST_UABI_ENGINE_CLASS + 2? Because ...

Re: [PATCH v8 3/3] drm/buddy: Add user for defragmentation

2024-03-05 Thread Paneer Selvam, Arunpravin
Hi Christian, On 3/4/2024 10:09 PM, Christian König wrote: Am 04.03.24 um 17:32 schrieb Arunpravin Paneer Selvam: Add amdgpu driver as user for the drm buddy defragmentation. Signed-off-by: Arunpravin Paneer Selvam ---   drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 17 +++--  

[PATCH v3 3/5] drm/i915/psr: Calculate IO wake and fast wake lines for DISPLAY_VER < 12

2024-03-05 Thread Jouni Högander
Bspec mentions 50 us for IO wake time and 32 us for fast wake time. 32 us is most probably wrong as it doesn't meet the specification as fast wake time is calculated in Bspec like this: 10..16 us (precharge) + 8 us (preamble) + 4 us (phy_wake) + 20 us (tfw_exit_latency) Instead of using these

[PATCH v3 4/5] drm/i915/psr: Add IO buffer wake times for LunarLake and beyond

2024-03-05 Thread Jouni Högander
IO buffer wake time used for IO wake calculation is dependent on port clock on LunarLake and beyond. Take this into account in get_io_buffer_wake_time. Bspec: 65450 Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 9 - 1 file changed, 8 insertions(+), 1

[PATCH v3 5/5] drm/i915/display: Increase number of fast wake precharge pulses

2024-03-05 Thread Jouni Högander
Increasing number of fast wake sync pulses seem to fix problems with certain PSR panels. This should be ok for other panels as well as the eDP specification allows 10...16 precharge pulses and we are still within that range. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9739

[PATCH] drm/ci: update device type for volteer devices

2024-03-05 Thread Vignesh Raman
Volteer devices in the collabora lab are categorized under the asus-cx9400-volteer device type. The majority of these units has an Intel Core i5-1130G7 CPU, while some of them have a Intel Core i7-1160G7 CPU instead. So due to this difference, new device type template is added for the Intel Core

Re: [PATCH] drm/ci: update device type for volteer devices

2024-03-05 Thread Vignesh Raman
Hi, Below is the pipeline with the job passing, https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1119672 Regards, Vignesh On 05/03/24 15:46, Vignesh Raman wrote: Volteer devices in the collabora lab are categorized under the asus-cx9400-volteer device type. The majority of these

[PATCH v3 0/5] IO and fast wake lines calculation and increase fw sync length

2024-03-05 Thread Jouni Högander
This patch set is improving IO and fast wake lines calculation in PSR code: Use actual fast wake sync pulse count in calculation Implement getter for IO buffer wake times and use that. Better presentation on how these are calculated. Use calculation for display version < 12 as well. Also

[PATCH v3 1/5] drm/i915/display: Make intel_dp_aux_fw_sync_len available for PSR code

2024-03-05 Thread Jouni Högander
ALPM AUX-Wake fast wake sync pulse count is needed by PSR to calculate IO wake and fast wake lines. Convert intel_dp_aux_fw_sync_len as non-static to make it available for PSR code. v2: use int instead of u8 Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_dp_aux.c | 2 +-

[PATCH v3 2/5] drm/i915/psr: Improve fast and IO wake lines calculation

2024-03-05 Thread Jouni Högander
Current fast and IO wake lines calculation is assuming fast wake sync length is 18 pulses. Let's improve this by checking actual length. Add getter for IO buffer wake time and return 10 us there which was assumed with static 42 us IO wake time. Upcoming patches will extent this for different

Re: [PATCH v8 3/3] drm/buddy: Add user for defragmentation

2024-03-05 Thread Christian König
Am 05.03.24 um 12:14 schrieb Paneer Selvam, Arunpravin: On 3/5/2024 4:33 PM, Paneer Selvam, Arunpravin wrote: Hi Christian, On 3/4/2024 10:09 PM, Christian König wrote: Am 04.03.24 um 17:32 schrieb Arunpravin Paneer Selvam: Add amdgpu driver as user for the drm buddy defragmentation.

  1   2   >