Re: [Intel-gfx] [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too
At Fri, 16 Mar 2012 16:18:03 -0700, Keith Packard wrote: #part sign=pgpmime On Fri, 16 Mar 2012 22:41:12 +0100, Takashi Iwai ti...@suse.de wrote: +/* read the initial LVDS register value for the given panel mode */ +static unsigned int get_lvds_reg_val(const struct bdb_header *bdb, +const struct bdb_lvds_lfp_data_ptrs *ptrs, +int index, +struct drm_display_mode *mode) To follow the style of intel_bios.c, I think it would make sense to have the function: static const struct lvds_dvo_timing * get_lvds_fp_timing(const struct bdb_lvds_lfp_data *lvds_lfp_data, const struct bdb_lvds_lfp_data_ptrs *lvds_lfp_data_ptrs, int index) then use the results of this in parse_lfp_panel_data, instead of putting the whole computation into this new function. Well, the LVDS reg data isn't in lvds_dvo_timing but in lvds_fp_timing, thus you need to look at a different entry in anyway. I'd also like to see this code only use the BDB value when the LVDS is disabled at startup time; otherwise, we'll be changing the behavior for all LVDS users, and as BIOS tables are notoriously unreliable, I fear that we'll cause a lot more problems than we solve. I skipped it to simplify the code, but that'd be safer, indeed. (Though, the chance of getting a wrong value is fairly small since the function verifies whether the resolution of the entry matches with the given mode, too.) thanks, Takashi ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add lvds_channel module option
At Fri, 16 Mar 2012 22:51:22 -0300, Eugeni Dodonov wrote: [1 text/plain; ISO-8859-1 (7bit)] On Fri, Mar 16, 2012 at 18:41, Takashi Iwai ti...@suse.de wrote: Add a new module optoin lvds_channel to specify the LVDS channel mode explicitly instead of probing the LVDS register value set by BIOS. This will be helpful when VBT is broken or incompatible with the current code. Signed-off-by: Takashi Iwai ti...@suse.de --- drivers/gpu/drm/i915/i915_drv.c |6 ++ drivers/gpu/drm/i915/i915_drv.h |1 + drivers/gpu/drm/i915/intel_display.c |5 + 3 files changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 308f819..eee6804 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -80,6 +80,12 @@ MODULE_PARM_DESC(lvds_downclock, Use panel (LVDS/eDP) downclocking for power savings (default: false)); +int i915_lvds_channel __read_mostly; +module_param_named(lvds_channel, i915_lvds_channel, int, 0400); As a minor bikeshedding, perhaps this variable would make more sense if called 'i915_lvds_channel_mode' instead? I am fine with either spelling though, it just looks more semantically correct to me. But in any case, OK, I'll fix in the next spin. thanks, Takashi Reviewed-by: Eugeni Dodonov eugeni.dodo...@intel.com -- Eugeni Dodonov http://eugeni.dodonov.net/ [2 text/html; ISO-8859-1 (quoted-printable)] ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] VA-API brightness property
Please, can anyone tell me if there is a list for user questions about VAAPI? I have several questions... Greets, Kiste Am 09.03.2012 08:04, schrieb Oliver Seitz: Hi! I'm using the patched, VA-API enabled MPlayer on SandyBridge. System is Debian Wheezy. Works great, decodes BluRay-like quality with neglectable CPU load (below 5%). Now, I'm trying to adjust brightness. I think I've read that VA-API defines a brightness property, but MPlayer can not set it. Is this feature still missing in the driver, or is MPlayer calling for it in the wrong way? Thanks for any hints! Greets, Kiste ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] Sandy bridge GPU does not support alpha channel?
When I read document about Sandy Bridge GPU's mannual, I found that it does not support ALPHA channel when setting pixel format. Is it true? -- The simplest is not all best but the best is surely the simplest! ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too
#part sign=pgpmime On Sat, 17 Mar 2012 08:59:56 +0100, Takashi Iwai ti...@suse.de wrote: Well, the LVDS reg data isn't in lvds_dvo_timing but in lvds_fp_timing, thus you need to look at a different entry in anyway. Right, a parallel function which returns the lvds_fp_timing structure instead of pulling the data out of it. Just makes the code look more like the existing stuff. And, if we need more data from the lvds_fp_timing in the future, we'll have it available directly. I skipped it to simplify the code, but that'd be safer, indeed. Reducing the chances for regressions is my primary concern here; most people boot their machines with the lid open, so if we avoid the new code in that case, we'll be more likely to not break things. -- keith.pack...@intel.com ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
