Re: [Intel-gfx] [Alsa-user] intel-hda: sound via HDMI only when using interlaced modes

2013-02-09 Thread David Härdeman
On Thu, Feb 07, 2013 at 11:00:13AM +0100, Daniel Vetter wrote: >On Wed, Feb 06, 2013 at 10:35:33PM +0100, David Härdeman wrote: >> I'll break etiquette here and include the entire original message below >> (and top-post!) since I'm sending this to intel-gfx as well. >> >> Since the previous mail I

Re: [Intel-gfx] [PATCH v3] drm/i915: Extract ring init from hw_init

2013-02-09 Thread Daniel Vetter
On Fri, Feb 08, 2013 at 11:49:24AM -0800, Ben Widawsky wrote: > The ring initialization will differ a bit in upcoming generations, and > this split will prepare the code for what's needed. > > This patch also fixes a bug introduced in: > commit 99433931950f33039d9e1a52b4ed9af3f1b58e84 > Author: Mi

Re: [Intel-gfx] [PATCH] drm/i915: Fix gen2 mappable calculations

2013-02-09 Thread Daniel Vetter
On Fri, Feb 08, 2013 at 11:32:47AM -0800, Ben Widawsky wrote: > When I refactored the code initially, I forgot that gen2 uses a > different bar for the CPU mappable aperture. The agp-less code knows > nothing of generations less than 5, so we have to expand the gtt_probe > function to include the m

Re: [Intel-gfx] [PATCH 3/4] drm/i915: handle walking compact dma scatter lists

2013-02-09 Thread Imre Deak
On Sat, 2013-02-09 at 23:51 +0100, Daniel Vetter wrote: > On Sat, Feb 09, 2013 at 05:27:35PM +0200, Imre Deak wrote: > > So far the assumption was that each dma scatter list entry contains only > > a single page. This might not hold in the future, when we'll introduce > > compact scatter lists, so

Re: [Intel-gfx] [PATCH 1/4] drm: add helper to walk a dma scatter list a page at a time

2013-02-09 Thread Imre Deak
On Sat, 2013-02-09 at 19:56 +0100, Daniel Vetter wrote: > Hi Imre! > > On Sat, Feb 09, 2013 at 05:27:33PM +0200, Imre Deak wrote: > > Add a helper to walk through a scatter list a page at a time. Needed by > > upcoming patches fixing the scatter list walking logic in the i915 driver. > > Nice pat

Re: [Intel-gfx] [PATCH 3/4] drm/i915: handle walking compact dma scatter lists

2013-02-09 Thread Daniel Vetter
On Sat, Feb 09, 2013 at 05:27:35PM +0200, Imre Deak wrote: > So far the assumption was that each dma scatter list entry contains only > a single page. This might not hold in the future, when we'll introduce > compact scatter lists, so prepare for this everywhere in the i915 code > where we walk suc

Re: [Intel-gfx] [PATCH 4/4] drm/i915: create compact dma scatter lists for gem objects

2013-02-09 Thread Imre Deak
On Sat, 2013-02-09 at 19:59 +0100, Daniel Vetter wrote: > On Sat, Feb 09, 2013 at 05:27:36PM +0200, Imre Deak wrote: > > So far we created a sparse dma scatter list for gem objects, where each > > scatter list entry represented only a single page. In the future we'll > > have to handle compact scat

Re: [Intel-gfx] [PATCH] drm/i915: detect wrong MCH watermark values

2013-02-09 Thread Ben Widawsky
On Sat, Feb 09, 2013 at 09:03:42PM +0100, Daniel Vetter wrote: > Some early bios versions seem to ship with the wrong tuning values for > the MCH, possible resulting in pipe underruns under load. Especially > on DP outputs this can lead to black screen, since DP really doesn't > like an occasional

[Intel-gfx] [PATCH] drm/i915: detect wrong MCH watermark values

2013-02-09 Thread Daniel Vetter
Some early bios versions seem to ship with the wrong tuning values for the MCH, possible resulting in pipe underruns under load. Especially on DP outputs this can lead to black screen, since DP really doesn't like an occasional whack from an underrun. Unfortunately the registers seem to be locked

Re: [Intel-gfx] [PATCH 08/10] drm/i915: print PCH FIFO underrun interrupts

2013-02-09 Thread Daniel Vetter
On Fri, Feb 08, 2013 at 05:35:19PM -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > Also add an "ignore" bit that avoids printing the message in two > cases: > - When the message is in fact expected. > - After we get the first message. In tihs case, we expect to get > hundreds of conse

Re: [Intel-gfx] [PATCH 05/10] drm/i915: also disable south interrupts when handling them

2013-02-09 Thread Daniel Vetter
On Fri, Feb 08, 2013 at 05:35:16PM -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > From the docs: > "Only the rising edge of the PCH Display interrupt will cause the > North Display IIR (DEIIR) PCH Display Interrupt even bit to be set, > so all PCH Display Interrupts, including back to

Re: [Intel-gfx] [PATCH 04/10] drm/i915: add ibx_irq_postinstall

2013-02-09 Thread Daniel Vetter
On Sat, Feb 09, 2013 at 09:27:22AM -0800, Ben Widawsky wrote: > On Fri, 8 Feb 2013 17:35:15 -0200 > Paulo Zanoni wrote: > > > From: Paulo Zanoni > > > > So we can remove duplicated code. Note that this function is used not > > only on IBX, but also CPT and LPT. > > > > Signed-off-by: Paulo Za

Re: [Intel-gfx] [PATCH 4/4] drm/i915: create compact dma scatter lists for gem objects

2013-02-09 Thread Daniel Vetter
On Sat, Feb 09, 2013 at 05:27:36PM +0200, Imre Deak wrote: > So far we created a sparse dma scatter list for gem objects, where each > scatter list entry represented only a single page. In the future we'll > have to handle compact scatter lists too where each entry can consist of > multiple pages,

Re: [Intel-gfx] [PATCH 1/4] drm: add helper to walk a dma scatter list a page at a time

2013-02-09 Thread Daniel Vetter
Hi Imre! On Sat, Feb 09, 2013 at 05:27:33PM +0200, Imre Deak wrote: > Add a helper to walk through a scatter list a page at a time. Needed by > upcoming patches fixing the scatter list walking logic in the i915 driver. Nice patch, but I think this would make a rather nice addition to the common s

Re: [Intel-gfx] [PATCH 10/10] drm/i915: also POSTING_READ(DEIER) on ivybridge_irq_handler

2013-02-09 Thread Ben Widawsky
On Fri, 8 Feb 2013 17:35:21 -0200 Paulo Zanoni wrote: > From: Paulo Zanoni > > This is already done on ironlake_irq_handler. We want to make sure the > interrupts are disabled before we check any of the other interrupt > registers. > > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH 07/10] drm/i915: print Gen5+ CPU poison interrupts

2013-02-09 Thread Ben Widawsky
On Fri, 8 Feb 2013 11:42:39 -0800 Jesse Barnes wrote: > On Fri, 8 Feb 2013 17:35:18 -0200 > Paulo Zanoni wrote: > > > From: Paulo Zanoni > > > > On ILK/SNB all we need to do is to enable the "poison" bit, but on > > IVB/HSW we need to enable the CPU error interrupt register, which is > > res

Re: [Intel-gfx] [PATCH 04/10] drm/i915: add ibx_irq_postinstall

2013-02-09 Thread Ben Widawsky
On Fri, 8 Feb 2013 17:35:15 -0200 Paulo Zanoni wrote: > From: Paulo Zanoni > > So we can remove duplicated code. Note that this function is used not > only on IBX, but also CPT and LPT. > > Signed-off-by: Paulo Zanoni Reviewed-by: Ben Widawsky [snip]

Re: [Intel-gfx] [PATCH 03/10] drm/i915: clear the FPGA_DBG_RM_NOCLAIM bit at driver init

2013-02-09 Thread Ben Widawsky
On Fri, 8 Feb 2013 17:35:14 -0200 Paulo Zanoni wrote: > From: Paulo Zanoni > > Otherwise, if the BIOS did anything wrong, our first I915_{WRITE,READ} > will give us "unclaimed register" messages. > > V2: Even earlier. > > Bugzilla: http://bugs.freedesktop.org/show_bug.cgi?id=58897 > Signed-

Re: [Intel-gfx] [PATCH 3/4] drm/i915: handle walking compact dma scatter lists

2013-02-09 Thread Chris Wilson
On Sat, Feb 09, 2013 at 05:27:35PM +0200, Imre Deak wrote: > So far the assumption was that each dma scatter list entry contains only > a single page. This might not hold in the future, when we'll introduce > compact scatter lists, so prepare for this everywhere in the i915 code > where we walk suc

[Intel-gfx] [PATCH 4/4] drm/i915: create compact dma scatter lists for gem objects

2013-02-09 Thread Imre Deak
So far we created a sparse dma scatter list for gem objects, where each scatter list entry represented only a single page. In the future we'll have to handle compact scatter lists too where each entry can consist of multiple pages, for example for objects imported through PRIME. The previous patch

[Intel-gfx] [PATCH 3/4] drm/i915: handle walking compact dma scatter lists

2013-02-09 Thread Imre Deak
So far the assumption was that each dma scatter list entry contains only a single page. This might not hold in the future, when we'll introduce compact scatter lists, so prepare for this everywhere in the i915 code where we walk such a list. We'll fix the place _creating_ these lists separately in

[Intel-gfx] [PATCH 2/4] drm: handle compact dma scatter lists in drm_clflush_sg()

2013-02-09 Thread Imre Deak
So far the assumption was that each scatter list entry contains a single page. This might not hold in the future, when we'll introduce compact scatter lists, so prepare for this here. Reference: http://www.spinics.net/lists/dri-devel/msg33917.html Signed-off-by: Imre Deak --- drivers/gpu/drm/drm

[Intel-gfx] [PATCH 1/4] drm: add helper to walk a dma scatter list a page at a time

2013-02-09 Thread Imre Deak
Add a helper to walk through a scatter list a page at a time. Needed by upcoming patches fixing the scatter list walking logic in the i915 driver. Signed-off-by: Imre Deak --- include/drm/drmP.h | 44 1 file changed, 44 insertions(+) diff --git a/i

[Intel-gfx] [PATCH 0/4] drm/i915: handle compact dma scatter lists

2013-02-09 Thread Imre Deak
This series adds support for handling compact dma scatter lists to the i915 driver. This is a dependency for the related upcoming change in the PRIME interface: http://www.spinics.net/lists/dri-devel/msg33917.html Imre Deak (4): drm: add helper to walk a dma scatter list a page at a time drm

Re: [Intel-gfx] [PATCH] drm/i915: Fix sprite_scaling_enabled for multiple sprites

2013-02-09 Thread Daniel Vetter
On Fri, Feb 08, 2013 at 09:26:30PM +, Chris Wilson wrote: > On Fri, Feb 08, 2013 at 11:13:35PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > We have more than one sprite, so a boolean simply won't cut it. > > Turn sprite_scaling_enabled into a bitmask and track t

Re: [Intel-gfx] [PATCH 2/2] drm/i915: clean up panel fitter handling in lvds

2013-02-09 Thread Daniel Vetter
On Fri, Feb 8, 2013 at 3:35 PM, Mika Kuoppala wrote: > commit c1d1f5aeda2033d96e872f416388653f05d4c16d > Author: Mika Kuoppala > Date: Tue Feb 5 17:26:52 2013 +0200 > > drm/i915: disable shared panel fitter for pipe You can't cite the sha1 of a patch which isn't merged yet, since the sha1

Re: [Intel-gfx] [PATCH 1/2] drm/i915: disable shared panel fitter for pipe

2013-02-09 Thread Daniel Vetter
On Fri, Feb 8, 2013 at 3:35 PM, Mika Kuoppala wrote: > If encoder is switched off by BIOS, but the panel fitter is left on, > we never try to turn off the panel fitter and leave it still attached > to the pipe - which can cause blurry output elsewhere. > > Based on work by Chris Wilson > > Bugzil