Re: [Intel-gfx] [PATCH 28/31] drm/i915: s/pre_pll/pre/ on the lvds port enable function

2013-06-15 Thread Imre Deak
On Wed, 2013-06-05 at 13:34 +0200, Daniel Vetter wrote: i9xx doesn't use pre_enable at all, so we can fold this in now. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch I managed to review 23-28 for now, so on those apart from the two nitpicks: Reviewed-by: Imre Deak imre.d...@intel.com

Re: [Intel-gfx] [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Aaron Lu
On 06/15/2013 12:19 PM, Matthew Garrett wrote: On Sat, Jun 15, 2013 at 12:14:42PM +0800, Aaron Lu wrote: On 06/15/2013 09:38 AM, Matthew Garrett wrote: Well, Windows 8 will only use the ACPI backlight interface if the GPU driver decides to, right? So the logic for deciding whether to remove