[Intel-gfx] [PATCH intel-gpu-tools] Depend on libdrm_intel >= 2.4.47.

2013-10-11 Thread Matt Turner
--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 9777bcc..36765f0 100644 --- a/configure.ac +++ b/configure.ac @@ -70,7 +70,7 @@ if test "x$GCC" = "xyes"; then fi AC_SUBST(ASSEMBLER_WARN_CFLAGS) -PKG_CHECK_MODULES(DRM, [libd

Re: [Intel-gfx] [PATCH] drm/i915: protect HSW power well check with IS_HASWELL in redisable_vga

2013-10-11 Thread Jesse Barnes
On Fri, 11 Oct 2013 18:39:01 -0300 Paulo Zanoni wrote: > 2013/10/11 Jesse Barnes : > > This may need work if other platforms do the same thing, but in the > > meantime we should avoid looking at HSW specific bits in this generic > > function. > > > > Signed-off-by: Jesse Barnes > > --- > > driv

Re: [Intel-gfx] [PATCH 1/2] drm/i915: make backlight functions take a connector v3

2013-10-11 Thread Daniel Vetter
On Sat, Oct 12, 2013 at 1:55 AM, Daniel Vetter wrote: > On Sat, Oct 12, 2013 at 1:19 AM, Jesse Barnes > wrote: >> On Fri, 11 Oct 2013 14:34:35 -0700 >> Jesse Barnes wrote: >> >>> > Ideas: >>> > - Make sure all lvds/edp connectors are enabled and bash on all backlight >>> > interfaces (with ig

Re: [Intel-gfx] [PATCH 1/2] drm/i915: make backlight functions take a connector v3

2013-10-11 Thread Daniel Vetter
On Sat, Oct 12, 2013 at 1:19 AM, Jesse Barnes wrote: > On Fri, 11 Oct 2013 14:34:35 -0700 > Jesse Barnes wrote: > >> > Ideas: >> > - Make sure all lvds/edp connectors are enabled and bash on all backlight >> > interfaces (with igt_fork it's easy to do that concurrently). >> > - Race the above w

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix scanoutpos calculations

2013-10-11 Thread Mario Kleiner
Yes. On Oct 12, 2013 1:18 AM, "Daniel Vetter" wrote: > > On Fri, Oct 11, 2013 at 04:31:38PM +0200, Mario Kleiner wrote: > > Daniel, Ville, > > > > i tested Ville's patch series for the scanoutpos improvements on a > > GMA-950, on top of airlied's current drm-next branch. > > > > There's one issue:

Re: [Intel-gfx] [PATCH 1/2] drm/i915: make backlight functions take a connector v3

2013-10-11 Thread Jesse Barnes
On Fri, 11 Oct 2013 14:34:35 -0700 Jesse Barnes wrote: > > Ideas: > > - Make sure all lvds/edp connectors are enabled and bash on all backlight > > interfaces (with igt_fork it's easy to do that concurrently). > > - Race the above with output changes: dpms on/off and changing the crtc > > aro

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix scanoutpos calculations

2013-10-11 Thread Daniel Vetter
On Fri, Oct 11, 2013 at 04:31:38PM +0200, Mario Kleiner wrote: > Daniel, Ville, > > i tested Ville's patch series for the scanoutpos improvements on a > GMA-950, on top of airlied's current drm-next branch. > > There's one issue: The variable "position" in > i915_get_crtc_scanoutpos() must be tur

Re: [Intel-gfx] [PATCH v5 0/4] Fix Win8 backlight issue

2013-10-11 Thread Rafael J. Wysocki
On Friday, October 11, 2013 06:01:43 PM Josh Boyer wrote: > On Fri, Oct 11, 2013 at 6:10 PM, Rafael J. Wysocki wrote: > > On Friday, October 11, 2013 12:42:43 PM Josh Boyer wrote: > >> On Fri, Oct 11, 2013 at 9:27 AM, Aaron Lu wrote: > >> > v5: > >> > 1 Introduce video.use_native_backlight module

Re: [Intel-gfx] [PATCH v5 0/4] Fix Win8 backlight issue

2013-10-11 Thread Rafael J. Wysocki
On Saturday, October 12, 2013 02:53:38 AM Igor Gnatenko wrote: > On Sat, 2013-10-12 at 00:45 +0200, Rafael J. Wysocki wrote: > > On Friday, October 11, 2013 06:01:43 PM Josh Boyer wrote: > > > On Fri, Oct 11, 2013 at 6:10 PM, Rafael J. Wysocki > > > wrote: > > > > On Friday, October 11, 2013 12:4

Re: [Intel-gfx] [PATCH v5 0/4] Fix Win8 backlight issue

2013-10-11 Thread Igor Gnatenko
On Sat, 2013-10-12 at 00:45 +0200, Rafael J. Wysocki wrote: > On Friday, October 11, 2013 06:01:43 PM Josh Boyer wrote: > > On Fri, Oct 11, 2013 at 6:10 PM, Rafael J. Wysocki > > wrote: > > > On Friday, October 11, 2013 12:42:43 PM Josh Boyer wrote: > > >> On Fri, Oct 11, 2013 at 9:27 AM, Aaron L

Re: [Intel-gfx] [PATCH intel-gpu-tools] configure: Don't bail if libdrm_nouveau isn't available.

2013-10-11 Thread Chad Versace
On 10/11/2013 03:51 PM, Chad Versace wrote: On 10/11/2013 02:29 PM, Matt Turner wrote: On Fri, Oct 11, 2013 at 2:24 PM, Daniel Vetter wrote: On Fri, Oct 11, 2013 at 12:51:34PM -0700, Matt Turner wrote: On Fri, Oct 11, 2013 at 12:40 AM, Daniel Vetter wrote: On Fri, Oct 11, 2013 at 5:56 AM, M

Re: [Intel-gfx] [PATCH intel-gpu-tools] configure: Don't bail if libdrm_nouveau isn't available.

2013-10-11 Thread Chad Versace
On 10/11/2013 02:29 PM, Matt Turner wrote: On Fri, Oct 11, 2013 at 2:24 PM, Daniel Vetter wrote: On Fri, Oct 11, 2013 at 12:51:34PM -0700, Matt Turner wrote: On Fri, Oct 11, 2013 at 12:40 AM, Daniel Vetter wrote: On Fri, Oct 11, 2013 at 5:56 AM, Matt Turner wrote: We were seriously *requir

Re: [Intel-gfx] [PATCH] drm/i915: make backlight functions take a connector v4

2013-10-11 Thread Jesse Barnes
On Fri, 11 Oct 2013 14:46:36 -0700 Jesse Barnes wrote: > On VLV/BYT, backlight controls a per-pipe, so when adjusting the > backlight we need to pass the correct info. So make the externally > visible backlight functions take a connector argument, which can be used > internally to figure out the

Re: [Intel-gfx] [PATCH v5 0/4] Fix Win8 backlight issue

2013-10-11 Thread Rafael J. Wysocki
On Friday, October 11, 2013 06:01:43 PM Josh Boyer wrote: > On Fri, Oct 11, 2013 at 6:10 PM, Rafael J. Wysocki wrote: > > On Friday, October 11, 2013 12:42:43 PM Josh Boyer wrote: > >> On Fri, Oct 11, 2013 at 9:27 AM, Aaron Lu wrote: > >> > v5: > >> > 1 Introduce video.use_native_backlight module

Re: [Intel-gfx] [PATCH v5 0/4] Fix Win8 backlight issue

2013-10-11 Thread Rafael J. Wysocki
On Friday, October 11, 2013 12:42:43 PM Josh Boyer wrote: > On Fri, Oct 11, 2013 at 9:27 AM, Aaron Lu wrote: > > v5: > > 1 Introduce video.use_native_backlight module parameter and set its > > value to false by default as suggested by Rafael. For Win8 systems > > which have broken ACPI video b

[Intel-gfx] [PATCH] drm/i915: make backlight functions take a connector v4

2013-10-11 Thread Jesse Barnes
On VLV/BYT, backlight controls a per-pipe, so when adjusting the backlight we need to pass the correct info. So make the externally visible backlight functions take a connector argument, which can be used internally to figure out the pipe backlight to adjust. v2: make connector pipe lookup check

Re: [Intel-gfx] [PATCH] drm/i915: Fix pre-CTG vblank counter

2013-10-11 Thread Daniel Vetter
On Thu, Sep 26, 2013 at 07:32:58PM +0200, Mario Kleiner wrote: > On 25.09.13 22:55, Daniel Vetter wrote: > >On Wed, Sep 25, 2013 at 07:55:26PM +0300, ville.syrj...@linux.intel.com > >wrote: > >>From: Ville Syrjälä > >> > >>The old style frame counter increments at the start of active video. > >>H

Re: [Intel-gfx] [PATCH] drm/i915: protect HSW power well check with IS_HASWELL in redisable_vga

2013-10-11 Thread Paulo Zanoni
2013/10/11 Jesse Barnes : > This may need work if other platforms do the same thing, but in the > meantime we should avoid looking at HSW specific bits in this generic > function. > > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel_display.c | 2 +- > 1 file changed, 1 insertion(+)

Re: [Intel-gfx] [PATCH] drm/i915: Kconfig option to disable the legacy fbdev support

2013-10-11 Thread Daniel Vetter
On Fri, Oct 11, 2013 at 01:53:36PM +0800, Lee, Chon Ming wrote: > On 10/09 09:18, Daniel Vetter wrote: > > Boots Just Fine (tm)! > > > > The only glitch seems to be that at least on Fedora the boot splash > > gets confused and doesn't display much at all. > > > > And since there's no ugly console

Re: [Intel-gfx] [PATCH 1/3] drm: Add separate Kconfig option for fbdev helpers

2013-10-11 Thread Daniel Vetter
On Tue, Oct 08, 2013 at 12:52:53PM -0400, Rob Clark wrote: > On Tue, Oct 8, 2013 at 11:44 AM, Daniel Vetter wrote: > > For drivers which might want to disable fbdev legacy support. > > > > Select the new option in all drivers for now, so this shouldn't result > > in any change. Drivers need some w

Re: [Intel-gfx] [PATCH 1/2] drm/i915: make backlight functions take a connector v3

2013-10-11 Thread Jesse Barnes
On Fri, 11 Oct 2013 23:31:10 +0200 Daniel Vetter wrote: > On Fri, Oct 11, 2013 at 11:31:53AM -0700, Jesse Barnes wrote: > > [snip] > > > static int intel_panel_get_brightness(struct backlight_device *bd) > > { > > - struct drm_device *dev = bl_get_data(bd); > > - return intel_panel_get_ba

Re: [Intel-gfx] [PATCH 1/2] drm/i915: don't save/restore CACHE_MODE_0 on gen7+

2013-10-11 Thread Daniel Vetter
On Fri, Oct 11, 2013 at 05:09:57PM -0300, Paulo Zanoni wrote: > 2013/10/11 Jesse Barnes : > > On gen7+, CACHE_MODE_0 moved, so we're clobbering some other reg rather > > than restoring CACHE_MODE_0. Don't do that. > > > > Signed-off-by: Jesse Barnes > > Reviewed-by: Paulo Zanoni I really loath

Re: [Intel-gfx] [PATCH 1/2] drm/i915: make backlight functions take a connector v3

2013-10-11 Thread Daniel Vetter
On Fri, Oct 11, 2013 at 11:31:53AM -0700, Jesse Barnes wrote: [snip] > static int intel_panel_get_brightness(struct backlight_device *bd) > { > - struct drm_device *dev = bl_get_data(bd); > - return intel_panel_get_backlight(dev); > + struct intel_connector *connector = bl_get_data(

Re: [Intel-gfx] [PATCH intel-gpu-tools] configure: Don't bail if libdrm_nouveau isn't available.

2013-10-11 Thread Matt Turner
On Fri, Oct 11, 2013 at 2:24 PM, Daniel Vetter wrote: > On Fri, Oct 11, 2013 at 12:51:34PM -0700, Matt Turner wrote: >> On Fri, Oct 11, 2013 at 12:40 AM, Daniel Vetter wrote: >> > On Fri, Oct 11, 2013 at 5:56 AM, Matt Turner wrote: >> >> We were seriously *requiring* libdrm_nouveau unless explic

Re: [Intel-gfx] [PATCH intel-gpu-tools] configure: Don't bail if libdrm_nouveau isn't available.

2013-10-11 Thread Daniel Vetter
On Fri, Oct 11, 2013 at 12:51:34PM -0700, Matt Turner wrote: > On Fri, Oct 11, 2013 at 12:40 AM, Daniel Vetter wrote: > > On Fri, Oct 11, 2013 at 5:56 AM, Matt Turner wrote: > >> We were seriously *requiring* libdrm_nouveau unless explicitly disabled? > > > > I've had a bit of hilarious fail with

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix pipe off timeout handling for pre-gen4

2013-10-11 Thread Daniel Vetter
On Fri, Oct 11, 2013 at 12:43:54PM +0100, Chris Wilson wrote: > On Fri, Oct 11, 2013 at 02:21:31PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > The current pre-gen4 pipe off code might break out of the loop > > due to the timeout, but then the fail to print the warn

Re: [Intel-gfx] [PATCH] drm/i915: increase the SWSCI DSLP default timeout to 50ms

2013-10-11 Thread Daniel Vetter
On Fri, Oct 11, 2013 at 05:29:17PM -0300, Paulo Zanoni wrote: > 2013/10/10 Jani Nikula : > > On Wed, 09 Oct 2013, Paulo Zanoni wrote: > >> From: Paulo Zanoni > >> > >> The spec says the default timeout should be 2ms, but on my machine > >> this doesn't seem to be enough. Sometimes it works, somet

[Intel-gfx] [PATCH] drm/i915: protect HSW power well check with IS_HASWELL in redisable_vga

2013-10-11 Thread Jesse Barnes
This may need work if other platforms do the same thing, but in the meantime we should avoid looking at HSW specific bits in this generic function. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu

Re: [Intel-gfx] [PATCH v5 0/4] Fix Win8 backlight issue

2013-10-11 Thread Igor Gnatenko
On Fri, 2013-10-11 at 12:42 -0400, Josh Boyer wrote: > On Fri, Oct 11, 2013 at 9:27 AM, Aaron Lu wrote: > > v5: > > 1 Introduce video.use_native_backlight module parameter and set its > > value to false by default as suggested by Rafael. For Win8 systems > > which have broken ACPI video backli

Re: [Intel-gfx] [PATCH 1/2] drm/i915: check for power well in redisable VGA with generic fn

2013-10-11 Thread Paulo Zanoni
2013/10/11 Jesse Barnes : > On Fri, 11 Oct 2013 17:16:55 -0300 > Paulo Zanoni wrote: > >> 2013/10/11 Jesse Barnes : >> > Rather than using a HSW specific check. >> > >> > Signed-off-by: Jesse Barnes >> > --- >> > drivers/gpu/drm/i915/intel_display.c | 3 +-- >> > 1 file changed, 1 insertion(+),

Re: [Intel-gfx] [PATCH 1/2] drm/i915: check for power well in redisable VGA with generic fn

2013-10-11 Thread Jesse Barnes
On Fri, 11 Oct 2013 17:16:55 -0300 Paulo Zanoni wrote: > 2013/10/11 Jesse Barnes : > > Rather than using a HSW specific check. > > > > Signed-off-by: Jesse Barnes > > --- > > drivers/gpu/drm/i915/intel_display.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/dr

Re: [Intel-gfx] [PATCH] drm/i915: increase the SWSCI DSLP default timeout to 50ms

2013-10-11 Thread Paulo Zanoni
2013/10/10 Jani Nikula : > On Wed, 09 Oct 2013, Paulo Zanoni wrote: >> From: Paulo Zanoni >> >> The spec says the default timeout should be 2ms, but on my machine >> this doesn't seem to be enough. Sometimes it works, sometimes I get >> these messages when booting: >> - SWSCI request timed out

Re: [Intel-gfx] [PATCH 1/2] drm/i915: check for power well in redisable VGA with generic fn

2013-10-11 Thread Paulo Zanoni
2013/10/11 Jesse Barnes : > Rather than using a HSW specific check. > > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel_display.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.

Re: [Intel-gfx] [PATCH 1/2] drm/i915: don't save/restore CACHE_MODE_0 on gen7+

2013-10-11 Thread Paulo Zanoni
2013/10/11 Jesse Barnes : > On gen7+, CACHE_MODE_0 moved, so we're clobbering some other reg rather > than restoring CACHE_MODE_0. Don't do that. > > Signed-off-by: Jesse Barnes Reviewed-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/i915_suspend.c | 7 +-- > 1 file changed, 5 insertions(+

Re: [Intel-gfx] [PATCH intel-gpu-tools] configure: Don't bail if libdrm_nouveau isn't available.

2013-10-11 Thread Matt Turner
On Fri, Oct 11, 2013 at 12:40 AM, Daniel Vetter wrote: > On Fri, Oct 11, 2013 at 5:56 AM, Matt Turner wrote: >> We were seriously *requiring* libdrm_nouveau unless explicitly disabled? > > I've had a bit of hilarious fail with optional testcases that > automatically get disabled when depencies ar

Re: [Intel-gfx] [PATCH 11/16] drm/i915: Init HSW watermark tracking in intel_modeset_setup_hw_state()

2013-10-11 Thread Paulo Zanoni
2013/10/11 Ville Syrjälä : > On Fri, Oct 11, 2013 at 03:15:48PM -0300, Paulo Zanoni wrote: >> 2013/10/11 Ville Syrjälä : >> > On Fri, Oct 11, 2013 at 01:45:27PM -0300, Paulo Zanoni wrote: >> >> 2013/10/9 : >> >> > From: Ville Syrjälä >> >> > >> >> > Fill out the HSW watermark s/w tracking structu

[Intel-gfx] [PATCH 1/2] drm/i915: check for power well in redisable VGA with generic fn

2013-10-11 Thread Jesse Barnes
Rather than using a HSW specific check. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_display.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 53c4ea8..5452b34 100644 --- a/driv

[Intel-gfx] [PATCH 2/2] drm/i915: move gt powersave init out of save_state and modeset_init_hw

2013-10-11 Thread Jesse Barnes
We need to do this at init and resume time, but it's not modeset related. Since we'll need the modeset functions for managing save/restore after the power well is toggled, we want to keep them separate from GT related state save/restore to keep from affecting GT activity while the display is off.

Re: [Intel-gfx] [PATCH 14/16] drm/i915: Add watermark tracepoints

2013-10-11 Thread Paulo Zanoni
2013/10/9 : > From: Ville Syrjälä > > We may want to know what kind of watermarks got computed and programmed > into the hardware. Using tracepoints is much leaner than debug prints. > > Also add trace call for the watermark state we read out of the > hardware during init, though I;m not sure the

Re: [Intel-gfx] [PATCH] drm/i915: Fix VLV frame counter registers

2013-10-11 Thread Jesse Barnes
On Fri, 11 Oct 2013 22:24:41 +0300 ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Supposedly VLV uses the CTG+ style frame counter registers instead of > the old gen3/4 style. Add the magic offset to the correct registers. > > We should already be taking the correct codepaths fo

[Intel-gfx] [PATCH] drm/i915: Fix VLV frame counter registers

2013-10-11 Thread ville . syrjala
From: Ville Syrjälä Supposedly VLV uses the CTG+ style frame counter registers instead of the old gen3/4 style. Add the magic offset to the correct registers. We should already be taking the correct codepaths for .get_vblank_counter() and .get_scanout_position(). Signed-off-by: Ville Syrjälä -

Re: [Intel-gfx] [PATCH 11/16] drm/i915: Init HSW watermark tracking in intel_modeset_setup_hw_state()

2013-10-11 Thread Ville Syrjälä
On Fri, Oct 11, 2013 at 03:15:48PM -0300, Paulo Zanoni wrote: > 2013/10/11 Ville Syrjälä : > > On Fri, Oct 11, 2013 at 01:45:27PM -0300, Paulo Zanoni wrote: > >> 2013/10/9 : > >> > From: Ville Syrjälä > >> > > >> > Fill out the HSW watermark s/w tracking structures with the current > >> > hardwar

[Intel-gfx] [PATCH 2/2] drm/i915/vlv: add doc names to sideband file

2013-10-11 Thread Jesse Barnes
So digging out the right ones is a little easier. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_sideband.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_sideband.c b/drivers/gpu/drm/i915/intel_sideband.c index acd1cfe..9944d81 10

[Intel-gfx] [PATCH 1/2] drm/i915: don't save/restore CACHE_MODE_0 on gen7+

2013-10-11 Thread Jesse Barnes
On gen7+, CACHE_MODE_0 moved, so we're clobbering some other reg rather than restoring CACHE_MODE_0. Don't do that. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_suspend.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_suspend.c

[Intel-gfx] [PATCH 2/2] drm/i915: Don't pretend that gen2 has a hardware frame counter

2013-10-11 Thread ville . syrjala
From: Ville Syrjälä Gen2 doesn't have a hardware frame counter that can be read out. Just provide a stub .get_vblank_counter() that always returns 0 instead of trying to read non-existing registers. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_irq.c | 11 ++- 1 file chang

[Intel-gfx] [PATCH 1/2] drm/i915: Fix gen2 scanout position readout

2013-10-11 Thread ville . syrjala
From: Ville Syrjälä Gen2 doesn't have the pixelcount register that gen3 and gen4 have. Instead we must use the scanline counter like we do for ctg+. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_irq.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) di

[Intel-gfx] [PATCH 0/2] drm/i915: Gen2 vblank stuff

2013-10-11 Thread ville . syrjala
Continuing a bit with improving the vblank timestamp stuff, I decided that it's also time to fix gen2 properly. All this time we've been pretending it has the same pixel+frame counter that gen3 and gen4 have, when in fact it doesn't. Luckily the same offset has nothing else on gen2, so it has just

[Intel-gfx] [PATCH 2/2] drm/i915/vlv: use per-pipe backlight controls v2

2013-10-11 Thread Jesse Barnes
With the connector and pipe passed around, we can now set the backlight on the right pipe on VLV/BYT. v2: drop combination mode check for VLV (Jani) add save/restore code for VLV backlight regs (Jani) check for existing modulation freq when initializing backlight regs (Jani) Signed-off-by

[Intel-gfx] [PATCH 1/2] drm/i915: make backlight functions take a connector v3

2013-10-11 Thread Jesse Barnes
On VLV/BYT, backlight controls a per-pipe, so when adjusting the backlight we need to pass the correct info. So make the externally visible backlight functions take a connector argument, which can be used internally to figure out the pipe backlight to adjust. v2: make connector pipe lookup check

Re: [Intel-gfx] [PATCH 11/16] drm/i915: Init HSW watermark tracking in intel_modeset_setup_hw_state()

2013-10-11 Thread Paulo Zanoni
2013/10/11 Ville Syrjälä : > On Fri, Oct 11, 2013 at 01:45:27PM -0300, Paulo Zanoni wrote: >> 2013/10/9 : >> > From: Ville Syrjälä >> > >> > Fill out the HSW watermark s/w tracking structures with the current >> > hardware state in intel_modeset_setup_hw_state(). This allows us to skip >> > the H

Re: [Intel-gfx] [PATCH v2 10/16] drm/i915: Improve watermark dirtyness checks

2013-10-11 Thread Paulo Zanoni
2013/10/11 : > From: Ville Syrjälä > > Currently hsw_write_vm_values() may write to certain watermark > registers needlessly. For instance if only, say, LP3 changes, > the current code will again disable all LP1+ watermarks even > though only LP3 needs to be reconfigured. > > Add an easy to read

Re: [Intel-gfx] [PATCH 17/16] drm/i915: Check 5/6 DDB split only when sprites are enabled

2013-10-11 Thread Paulo Zanoni
2013/10/11 : > From: Ville Syrjälä > > Using the 5/6 DDB split make sense only when sprites are enabled. > So check that before we waste any cycles computing the merged > watermarks with the 5/6 DDB split. > > Signed-off-by: Ville Syrjälä Reviewed-by: Paulo Zanoni > --- > drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH 11/16] drm/i915: Init HSW watermark tracking in intel_modeset_setup_hw_state()

2013-10-11 Thread Ville Syrjälä
On Fri, Oct 11, 2013 at 01:45:27PM -0300, Paulo Zanoni wrote: > 2013/10/9 : > > From: Ville Syrjälä > > > > Fill out the HSW watermark s/w tracking structures with the current > > hardware state in intel_modeset_setup_hw_state(). This allows us to skip > > the HW state readback during watermark p

Re: [Intel-gfx] [PATCH 16/16] drm/i915: Rename ilk_check_wm to ilk_validate_wm_level

2013-10-11 Thread Paulo Zanoni
2013/10/9 : > From: Ville Syrjälä > > Makes the behaviour of the function more clear. > > Signed-off-by: Ville Syrjälä Thanks :) Reviewed-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/intel_pm.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/

Re: [Intel-gfx] [PATCH 15/16] drm/i915: Rename ilk_wm_max to ilk_compute_wm_maximums

2013-10-11 Thread Paulo Zanoni
2013/10/9 : > From: Ville Syrjälä > > Makes the intention more clear. > > Signed-off-by: Ville Syrjälä Thanks! Reviewed-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/intel_pm.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/int

Re: [Intel-gfx] [PATCH v2 13/16] drm/i915: Adjust watermark register masks

2013-10-11 Thread Paulo Zanoni
2013/10/9 : > From: Ville Syrjälä > > We want to be able to use the masks to decode the register contents > regardless of the hardware generation. So just expand the masks to > cover all available bits, even if those are reserved on some > generations. > > v2: Don't extend WM1_LP_SR_MASK so far,

Re: [Intel-gfx] [PATCH 12/16] drm/i915: Remove a somewhat silly debug print from watermark code

2013-10-11 Thread Paulo Zanoni
2013/10/9 : > From: Ville Syrjälä > > This debug print just adds overhead to the watermark merging process, > and doesn't really give enough information to be useful. Just kill > and let's add something much better a bit later. > > Signed-off-by: Ville Syrjälä Reviewed-by: Paulo Zanoni > ---

Re: [Intel-gfx] [PATCH 11/16] drm/i915: Init HSW watermark tracking in intel_modeset_setup_hw_state()

2013-10-11 Thread Paulo Zanoni
2013/10/9 : > From: Ville Syrjälä > > Fill out the HSW watermark s/w tracking structures with the current > hardware state in intel_modeset_setup_hw_state(). This allows us to skip > the HW state readback during watermark programming and just use the values > we keep around in dev_priv->wm. Reduc

[Intel-gfx] [PATCH v2 10/16] drm/i915: Improve watermark dirtyness checks

2013-10-11 Thread ville . syrjala
From: Ville Syrjälä Currently hsw_write_vm_values() may write to certain watermark registers needlessly. For instance if only, say, LP3 changes, the current code will again disable all LP1+ watermarks even though only LP3 needs to be reconfigured. Add an easy to read function that will compute t

Re: [Intel-gfx] [PATCH] drm/i915: Disable all GEM timers and work on unload

2013-10-11 Thread Chris Wilson
On Fri, Oct 11, 2013 at 06:22:55PM +0200, Daniel Vetter wrote: > On Fri, Oct 11, 2013 at 11:14 AM, Chris Wilson > wrote: > > > > void > > @@ -4711,11 +4707,9 @@ i915_gem_lastclose(struct drm_device *dev) > > if (drm_core_check_feature(dev, DRIVER_MODESET)) > > return; > >

[Intel-gfx] [Dell Inspiron 15R 5521] Can't toggle backlight brightness

2013-10-11 Thread Nicolas Devillers
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This mail is a follow-up of https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1225811 - - Summary of the problem: [Dell Inspiron 15R 5521] (using i915 drv) Can't toggle backlight brightness - - Full description of the problem/report: Since Ubun

Re: [Intel-gfx] [PATCH] drm/i915: Disable all GEM timers and work on unload

2013-10-11 Thread Daniel Vetter
On Fri, Oct 11, 2013 at 11:14 AM, Chris Wilson wrote: > > void > @@ -4711,11 +4707,9 @@ i915_gem_lastclose(struct drm_device *dev) > if (drm_core_check_feature(dev, DRIVER_MODESET)) > return; > > - mutex_lock(&dev->struct_mutex); > - ret = i915_gem_idle(dev); >

Re: [Intel-gfx] [PATCH 10/16] drm/i915: Improve watermark dirtyness checks

2013-10-11 Thread Paulo Zanoni
2013/10/11 Ville Syrjälä : > On Fri, Oct 11, 2013 at 12:02:53PM -0300, Paulo Zanoni wrote: >> 2013/10/9 : >> > From: Ville Syrjälä >> > >> > Currently hsw_write_vm_values() may write to certain watermark >> > registers needlessly. For instance it will disable LP1+ watermarks >> > around WM_PIPE c

[Intel-gfx] [PATCH v2 2/3] drm/i915: Fix scanoutpos calculations

2013-10-11 Thread ville . syrjala
From: Ville Syrjälä The reported scanout position must be relative to the end of vblank. Currently we manage to fumble that in a few ways. First we don't consider the case when vtotal != vbl_end. While that isn't very common (happens maybe only w/ old panel fitting hardware), we can fix it easil

Re: [Intel-gfx] [PATCH] drm: add support for additional stereo 3D modes

2013-10-11 Thread Damien Lespiau
On Thu, Oct 10, 2013 at 02:19:15PM +0100, Thomas Wood wrote: > + if ((multi_present == 1 || multi_present == 2) && You could use the awesome binary literals gcc extension here and 0b01 and 0b10 to be even closer to the spec wording. There's a precedent in drivers/watchdog/sunxi_wdt.c! -- Da

Re: [Intel-gfx] [PATCH 10/16] drm/i915: Improve watermark dirtyness checks

2013-10-11 Thread Ville Syrjälä
On Fri, Oct 11, 2013 at 12:02:53PM -0300, Paulo Zanoni wrote: > 2013/10/9 : > > From: Ville Syrjälä > > > > Currently hsw_write_vm_values() may write to certain watermark > > registers needlessly. For instance it will disable LP1+ watermarks > > around WM_PIPE changes even though that's not neede

Re: [Intel-gfx] [PATCH 10/16] drm/i915: Improve watermark dirtyness checks

2013-10-11 Thread Paulo Zanoni
2013/10/9 : > From: Ville Syrjälä > > Currently hsw_write_vm_values() may write to certain watermark > registers needlessly. For instance it will disable LP1+ watermarks > around WM_PIPE changes even though that's not needed. Also if only, > say, LP3 changes, the current code will again disable a

Re: [Intel-gfx] BUG: sleeping function called from invalid context on 3.10.10-rt7

2013-10-11 Thread Steven Rostedt
On Fri, 11 Oct 2013 15:30:22 +0200 Sebastian Andrzej Siewior wrote: > On 10/11/2013 02:37 PM, Steven Rostedt wrote: > > On Fri, 11 Oct 2013 12:18:00 +0200 > > Sebastian Andrzej Siewior wrote: > > > >> * Mario Kleiner | 2013-09-26 18:16:47 [+0200]: > >> > >>> Good! I will do that. Thanks for cla

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix scanoutpos calculations

2013-10-11 Thread Mario Kleiner
Daniel, Ville, i tested Ville's patch series for the scanoutpos improvements on a GMA-950, on top of airlied's current drm-next branch. There's one issue: The variable "position" in i915_get_crtc_scanoutpos() must be turned from a u32 into a int, otherwise funny sign errors happen and we end

Re: [Intel-gfx] [PATCH 09/16] drm/i915: Store current watermark state in dev_priv->wm

2013-10-11 Thread Paulo Zanoni
2013/10/9 : > From: Ville Syrjälä > > To make it easier to check what watermark updates are actually > necessary, keep copies of the relevant bits that match the current > hardware state. > > Also add DDB partitioning into hsw_wm_values as that's another piece > of state we want to track. > > We

Re: [Intel-gfx] [PATCH 05/16] drm/i915: Move some computations out from hsw_compute_wm_parameters()

2013-10-11 Thread Paulo Zanoni
2013/10/11 Ville Syrjälä : > On Thu, Oct 10, 2013 at 07:34:38PM -0300, Paulo Zanoni wrote: >> 2013/10/9 : >> > From: Ville Syrjälä >> > >> > Move the watermark max computations into haswell_update_wm(). This >> > allows keeping the 1/2 vs. 5/6 split code in one place, and avoid having >> > to pas

Re: [Intel-gfx] [PATCH v2 01/16] drm/i915: Add intel_pipe_wm and prepare for watermark pre-compute

2013-10-11 Thread Paulo Zanoni
2013/10/11 Ville Syrjälä : > On Thu, Oct 10, 2013 at 06:43:55PM -0300, Paulo Zanoni wrote: >> 2013/10/9 : >> > From: Ville Syrjälä >> > >> > Introduce a new struct intel_pipe_wm which contains all the >> > watermarks for a single pipe. Use it to unify the LP0 and LP1+ >> > watermark computations

Re: [Intel-gfx] BUG: sleeping function called from invalid context on 3.10.10-rt7

2013-10-11 Thread Mario Kleiner
On 10/11/2013 03:30 PM, Sebastian Andrzej Siewior wrote: On 10/11/2013 02:37 PM, Steven Rostedt wrote: On Fri, 11 Oct 2013 12:18:00 +0200 Sebastian Andrzej Siewior wrote: * Mario Kleiner | 2013-09-26 18:16:47 [+0200]: Good! I will do that. Thanks for clarifying the irq and constraints on ra

Re: [Intel-gfx] BUG: sleeping function called from invalid context on 3.10.10-rt7

2013-10-11 Thread Sebastian Andrzej Siewior
On 10/11/2013 02:37 PM, Steven Rostedt wrote: > On Fri, 11 Oct 2013 12:18:00 +0200 > Sebastian Andrzej Siewior wrote: > >> * Mario Kleiner | 2013-09-26 18:16:47 [+0200]: >> >>> Good! I will do that. Thanks for clarifying the irq and constraints >>> on raw locks in the other thread. >> >> Are ther

[Intel-gfx] [PATCH v5 4/4] thinkpad-acpi: fix handle locate for video and query of _BCL

2013-10-11 Thread Aaron Lu
The tpacpi_acpi_handle_locate function makes use of acpi_get_devices to locate handle for ACPI video by HID, the problem is, ACPI video node doesn't really have HID defined(i.e. no _HID control method is defined for video device), so.. that function would fail. This can be solved by enhancing the c

[Intel-gfx] [PATCH v5 3/4] ACPI / video: Do not register backlight if win8 and native interface exists

2013-10-11 Thread Aaron Lu
According to Matthew Garrett, "Windows 8 leaves backlight control up to individual graphics drivers rather than making ACPI calls itself. There's plenty of evidence to suggest that the Intel driver for Windows [8] doesn't use the ACPI interface, including the fact that it's broken on a bunch of mac

[Intel-gfx] [PATCH v5 2/4] ACPI / video: seperate backlight control and event interface

2013-10-11 Thread Aaron Lu
The backlight control and event delivery functionality provided by ACPI video module is mixed together and registered all during video device enumeration time. As a result, the two functionality are also removed together on module unload time or by the acpi_video_unregister function. The two functi

[Intel-gfx] [PATCH v5 1/4] backlight: introduce backlight_device_registered

2013-10-11 Thread Aaron Lu
Introduce a new API for modules to query if a specific type of backlight device has been registered. This is useful for some backlight device provider module(e.g. ACPI video) to know if a native control interface(e.g. the interface created by i915) is available and then do things accordingly(e.g. a

[Intel-gfx] [PATCH v5 0/4] Fix Win8 backlight issue

2013-10-11 Thread Aaron Lu
v5: 1 Introduce video.use_native_backlight module parameter and set its value to false by default as suggested by Rafael. For Win8 systems which have broken ACPI video backlight control, the parameter can be set to 1 in kernel cmdline to skip registering ACPI video's backlight interface. Du

Re: [Intel-gfx] BUG: sleeping function called from invalid context on 3.10.10-rt7

2013-10-11 Thread Steven Rostedt
On Fri, 11 Oct 2013 12:18:00 +0200 Sebastian Andrzej Siewior wrote: > * Mario Kleiner | 2013-09-26 18:16:47 [+0200]: > > >Good! I will do that. Thanks for clarifying the irq and constraints > >on raw locks in the other thread. > > Are there any suggestions for "now"? preempt_disable_nort() lik

[Intel-gfx] [PATCH 17/16] drm/i915: Check 5/6 DDB split only when sprites are enabled

2013-10-11 Thread ville . syrjala
From: Ville Syrjälä Using the 5/6 DDB split make sense only when sprites are enabled. So check that before we waste any cycles computing the merged watermarks with the 5/6 DDB split. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 de

Re: [Intel-gfx] [PATCH i-g-t] testdisplay: Allow getopt to print error messages

2013-10-11 Thread Damien Lespiau
On Thu, Oct 10, 2013 at 12:23:19PM +0100, Thomas Wood wrote: > By not assigning opterr, getopt will print its own error message that > includes information about whether an option is unknown or just requires > an additional argument. > > Signed-off-by: Thomas Wood Look good to me, pushed. Thanks

Re: [Intel-gfx] [PATCH] drm: add support for additional stereo 3D modes

2013-10-11 Thread Damien Lespiau
On Fri, Oct 11, 2013 at 02:12:14PM +0300, Ville Syrjälä wrote: > On Thu, Oct 10, 2013 at 02:19:15PM +0100, Thomas Wood wrote: > > +static int add_3d_struct_modes(struct drm_connector *connector, u16 > > structure, > > + const u8 *video_db, u8 video_len, u8 video_index) > >

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix pipe off timeout handling for pre-gen4

2013-10-11 Thread Chris Wilson
On Fri, Oct 11, 2013 at 02:21:31PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The current pre-gen4 pipe off code might break out of the loop > due to the timeout, but then the fail to print the warning. > > Refactor the code a bit to use wait_for() to avoid the problem

[Intel-gfx] [PATCH v2] drm/i915: Fix pipe off timeout handling for pre-gen4

2013-10-11 Thread ville . syrjala
From: Ville Syrjälä The current pre-gen4 pipe off code might break out of the loop due to the timeout, but then the fail to print the warning. Refactor the code a bit to use wait_for() to avoid the problem, and that we also re-check the condition after the timeout has expired. v2: Use wait_for(

Re: [Intel-gfx] [PATCH] drm: add support for additional stereo 3D modes

2013-10-11 Thread Ville Syrjälä
On Thu, Oct 10, 2013 at 02:19:15PM +0100, Thomas Wood wrote: > Parse the 3D_Structure_ALL and 3D_MASK fields of the HDMI Vendor > Specific Data Block to expose more stereo 3D modes. > > Signed-off-by: Thomas Wood > --- > drivers/gpu/drm/drm_edid.c | 93 >

Re: [Intel-gfx] 845G - call trace every boot

2013-10-11 Thread Felix Miata
On 2013-10-11 13:00 (GMT+0300) Ville Syrjälä composed: On Fri, Oct 11, 2013 at 12:24:04AM -0400, Felix Miata wrote: Are these happening to everyone using recent kernels and 845G? openSUSE only? 2013-10-11T00:05:50.929822-04:00 gx260 kernel: [2.621885] [ cut here ]--

Re: [Intel-gfx] BUG: sleeping function called from invalid context on 3.10.10-rt7

2013-10-11 Thread Sebastian Andrzej Siewior
* Mario Kleiner | 2013-09-26 18:16:47 [+0200]: >Good! I will do that. Thanks for clarifying the irq and constraints >on raw locks in the other thread. Are there any suggestions for "now"? preempt_disable_nort() like Luis suggesed? >-mario Sebastian _

Re: [Intel-gfx] HPD flood warning since b8f102e8b

2013-10-11 Thread Jiri Kosina
On Thu, 3 Oct 2013, Daniel Vetter wrote: > Can you please attach full dmesg from boot up to the first WARN with > drm.debug=0xe? This really shouldn't happen and indicates a bug > somewhere ... OK, I haven't been able to reproduce this any more for ~week ... so please disregard this, and I'll re

Re: [Intel-gfx] 845G - call trace every boot

2013-10-11 Thread Ville Syrjälä
On Fri, Oct 11, 2013 at 12:24:04AM -0400, Felix Miata wrote: > Are these happening to everyone using recent kernels and 845G? openSUSE only? > > 2013-10-11T00:05:50.929822-04:00 gx260 kernel: [2.621885] > [ cut here ] > WARNING: CPU: 0 PID: 107 at > /home/abuild/rpmbui

[Intel-gfx] [PATCH] drm/i915: Disable all GEM timers and work on unload

2013-10-11 Thread Chris Wilson
We have two once very similar functions, i915_gpu_idle() and i915_gem_idle(). The former is used as the lower level operation to flush work on the GPU, whereas the latter is the high level interface to flush the GEM bookkeeping in addition to flushing the GPU. As such i915_gem_idle() also clears ou

Re: [Intel-gfx] [PATCH 05/16] drm/i915: Move some computations out from hsw_compute_wm_parameters()

2013-10-11 Thread Ville Syrjälä
On Thu, Oct 10, 2013 at 07:34:38PM -0300, Paulo Zanoni wrote: > 2013/10/9 : > > From: Ville Syrjälä > > > > Move the watermark max computations into haswell_update_wm(). This > > allows keeping the 1/2 vs. 5/6 split code in one place, and avoid having > > to pass around so many things. We also sa

Re: [Intel-gfx] [PATCH 07/16] drm/i915: Refactor wm_lp to level calculation

2013-10-11 Thread Ville Syrjälä
On Thu, Oct 10, 2013 at 07:42:22PM -0300, Paulo Zanoni wrote: > 2013/10/9 : > > From: Ville Syrjälä > > > > On HSW the LP1,LP2,LP3 levels are either 1,2,3 or 1,3,4. We make the > > conversion from LPn to to the level at one point current. Later we're > > going to do it in a few places, so move it

Re: [Intel-gfx] [PATCH v2 01/16] drm/i915: Add intel_pipe_wm and prepare for watermark pre-compute

2013-10-11 Thread Ville Syrjälä
On Thu, Oct 10, 2013 at 06:43:55PM -0300, Paulo Zanoni wrote: > 2013/10/9 : > > From: Ville Syrjälä > > > > Introduce a new struct intel_pipe_wm which contains all the > > watermarks for a single pipe. Use it to unify the LP0 and LP1+ > > watermark computations so that we can just iterate through

Re: [Intel-gfx] [PATCH intel-gpu-tools] configure: Don't bail if libdrm_nouveau isn't available.

2013-10-11 Thread Daniel Vetter
On Fri, Oct 11, 2013 at 5:56 AM, Matt Turner wrote: > We were seriously *requiring* libdrm_nouveau unless explicitly disabled? I've had a bit of hilarious fail with optional testcases that automatically get disabled when depencies aren't around. Hence why they're all required by default with the

Re: [Intel-gfx] [Alsa-user] intel-hda: sound via HDMI only when using interlaced modes

2013-10-11 Thread Jani Nikula
On Fri, 11 Oct 2013, Jasper Smet wrote: > I managed to get a custom build but overriding the edid did not seem > to work at first glance (the override itself...) can't really say why > but the pioneer receiver was still visible in the kernel logs... So > maybe the kernel option was faulty or somet