[Intel-gfx] [PULL] drm-intel-next

2013-10-14 Thread Daniel Vetter
Hi Dave, New feature pile for 3.12! Highlights: - Stereo/3d support for hdmi from Damien, both the drm core bits and the i915 integration. - Manual boost/deboost logic for gpu turbo (Chris) - Fixed up clock readout support for vlv (Chris). - Tons of little fixes and improvements for vlv in

Re: [Intel-gfx] [PATCH] drm/i915: Add breadcrumbs for why the backlight is being set

2013-10-14 Thread Jani Nikula
On Sun, 13 Oct 2013, Chris Wilson ch...@chris-wilson.co.uk wrote: At the moment we have 3 paths that lead to actually_set_backlight(), from modesetting, ACPI/OpRegion requests and our very own intel_backlight interface, and we have no way of distinguishing them in the debug log. So add a debug

Re: [Intel-gfx] [PATCH] drm/i915: Add breadcrumbs for why the backlight is being set

2013-10-14 Thread Daniel Vetter
On Sun, Oct 13, 2013 at 12:56:31PM +0100, Chris Wilson wrote: At the moment we have 3 paths that lead to actually_set_backlight(), from modesetting, ACPI/OpRegion requests and our very own intel_backlight interface, and we have no way of distinguishing them in the debug log. So add a debug

Re: [Intel-gfx] [Dell Inspiron 15R 5521] Can't toggle backlight brightness

2013-10-14 Thread Jani Nikula
On Thu, 10 Oct 2013, Nicolas Devillers devillers.nico...@gmail.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This mail is a follow-up of https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1225811 - - Summary of the problem: [Dell Inspiron 15R 5521] (using i915 drv) Can't

Re: [Intel-gfx] [PATCH] drm/i915: Add breadcrumbs for why the backlight is being set

2013-10-14 Thread Jani Nikula
On Mon, 14 Oct 2013, Chris Wilson ch...@chris-wilson.co.uk wrote: On Mon, Oct 14, 2013 at 10:42:37AM +0300, Jani Nikula wrote: On Sun, 13 Oct 2013, Chris Wilson ch...@chris-wilson.co.uk wrote: diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c index

Re: [Intel-gfx] [Dell Inspiron 15R 5521] Can't toggle backlight brightness

2013-10-14 Thread Jani Nikula
On Mon, 14 Oct 2013, Nicolas Devillers devillers.nico...@gmail.com wrote: Unfortunately this seems to cause others unpexected issue like ACPI unstability and crash on suspend/resume. I reported the issue in the following bug https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1214287 I can

Re: [Intel-gfx] [PATCH 0/2] drm/i915: Gen2 vblank stuff

2013-10-14 Thread Chris Wilson
On Fri, Oct 11, 2013 at 09:52:42PM +0300, ville.syrj...@linux.intel.com wrote: Continuing a bit with improving the vblank timestamp stuff, I decided that it's also time to fix gen2 properly. All this time we've been pretending it has the same pixel+frame counter that gen3 and gen4 have, when

Re: [Intel-gfx] [PATCH 11/16] drm/i915: Init HSW watermark tracking in intel_modeset_setup_hw_state()

2013-10-14 Thread Ville Syrjälä
On Fri, Oct 11, 2013 at 04:46:58PM -0300, Paulo Zanoni wrote: 2013/10/11 Ville Syrjälä ville.syrj...@linux.intel.com: On Fri, Oct 11, 2013 at 03:15:48PM -0300, Paulo Zanoni wrote: 2013/10/11 Ville Syrjälä ville.syrj...@linux.intel.com: On Fri, Oct 11, 2013 at 01:45:27PM -0300, Paulo Zanoni

Re: [Intel-gfx] Macmini6, 1 with i915 2:2.20.0-0ubuntu0~precise1 Hard Freezing and drm_ioctl Debug Message Help

2013-10-14 Thread Jani Nikula
On Thu, 10 Oct 2013, Preston Connors prestonconn...@gmail.com wrote: I am having an issue where my Macmini6,1 is hard freezing (no keyboard control, have to power off and power back on using the power button) when attempting to display a random video at random times but always freezing when

[Intel-gfx] [PATCH 2/2] drm/i915: Use vlv_clock() in vlv_crtc_clock_get()

2013-10-14 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Avoid some code duplication. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH 1/2] drm/i915: Use DIV_ROUND_CLOSEST() to calculate dot/vco

2013-10-14 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Rounding down when calculating the dot/vco frequencies doesn't make much sense. Round to closest should give slightly nicer answers. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm/i915/intel_display.c | 12

[Intel-gfx] [PATCH v2 11/16] drm/i915: Init HSW watermark tracking in intel_modeset_setup_hw_state()

2013-10-14 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Fill out the HSW watermark s/w tracking structures with the current hardware state in intel_modeset_setup_hw_state(). This allows us to skip the HW state readback during watermark programming and just use the values we keep around in dev_priv-wm.

Re: [Intel-gfx] [PATCH 6/9] drm: Add drm_rotation_simplify()

2013-10-14 Thread Imre Deak
On Mon, 2013-09-30 at 17:44 +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com drm_rotation_simplify() can be used to eliminate unsupported rotation flags. It will check if any unsupported flags are present, and if so it will modify the rotation to

Re: [Intel-gfx] [PATCH 6/9] drm: Add drm_rotation_simplify()

2013-10-14 Thread Ville Syrjälä
On Mon, Oct 14, 2013 at 04:46:50PM +0300, Imre Deak wrote: On Mon, 2013-09-30 at 17:44 +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com drm_rotation_simplify() can be used to eliminate unsupported rotation flags. It will check if any

Re: [Intel-gfx] [PATCH v2 11/16] drm/i915: Init HSW watermark tracking in intel_modeset_setup_hw_state()

2013-10-14 Thread Paulo Zanoni
2013/10/14 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com Fill out the HSW watermark s/w tracking structures with the current hardware state in intel_modeset_setup_hw_state(). This allows us to skip the HW state readback during watermark programming and just

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Add rotation property for sprites

2013-10-14 Thread Imre Deak
On Mon, 2013-09-30 at 17:44 +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Sprite planes support 180 degree rotation. The lower layers are now in place, so hook in the standard rotation property to expose the feature to the users.

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Add rotation property for sprites

2013-10-14 Thread Ville Syrjälä
On Mon, Oct 14, 2013 at 04:59:13PM +0300, Imre Deak wrote: On Mon, 2013-09-30 at 17:44 +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Sprite planes support 180 degree rotation. The lower layers are now in place, so hook in the standard

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Use DIV_ROUND_CLOSEST() to calculate dot/vco

2013-10-14 Thread Jesse Barnes
On Mon, 14 Oct 2013 14:50:30 +0300 ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Rounding down when calculating the dot/vco frequencies doesn't make much sense. Round to closest should give slightly nicer answers. Signed-off-by: Ville Syrjälä

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use vlv_clock() in vlv_crtc_clock_get()

2013-10-14 Thread Jesse Barnes
On Mon, 14 Oct 2013 14:50:31 +0300 ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Avoid some code duplication. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3

[Intel-gfx] linux-next: manual merge of the drm-intel tree

2013-10-14 Thread Thierry Reding
Today's linux-next merge of the drm-intel tree got conflicts in: drivers/gpu/drm/i915/i915_dma.c drivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h caused by commits e1264eb (Revert drm/i915: Delay disabling of VGA memory until vgacon-fbcon handoff is done)

[Intel-gfx] linux-next: manual merge of the drm tree

2013-10-14 Thread Thierry Reding
Today's linux-next merge of the drm tree got conflicts in drivers/gpu/drm/i915/intel_drv.h caused by commits e1264eb (Revert drm/i915: Delay disabling of VGA memory until vgacon-fbcon handoff is done), 20ddf66 (drm/i915: Make intel_crtc_active() available outside intel_pm.c), 18442d0

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use vlv_clock() in vlv_crtc_clock_get()

2013-10-14 Thread Daniel Vetter
On Mon, Oct 14, 2013 at 07:44:16AM -0700, Jesse Barnes wrote: On Mon, 14 Oct 2013 14:50:31 +0300 ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Avoid some code duplication. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com ---

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Add rotation property for sprites

2013-10-14 Thread Imre Deak
On Mon, 2013-10-14 at 17:39 +0300, Ville Syrjälä wrote: On Mon, Oct 14, 2013 at 04:59:13PM +0300, Imre Deak wrote: On Mon, 2013-09-30 at 17:44 +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Sprite planes support 180 degree rotation. The

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix scanoutpos calculations

2013-10-14 Thread Daniel Vetter
On Sat, Oct 12, 2013 at 01:22:40AM +0200, Mario Kleiner wrote: Yes. On Oct 12, 2013 1:18 AM, Daniel Vetter dan...@ffwll.ch wrote: On Fri, Oct 11, 2013 at 04:31:38PM +0200, Mario Kleiner wrote: Daniel, Ville, i tested Ville's patch series for the scanoutpos improvements on a

Re: [Intel-gfx] [PATCH 0/2] drm/i915: Gen2 vblank stuff

2013-10-14 Thread Daniel Vetter
On Mon, Oct 14, 2013 at 11:01:11AM +0100, Chris Wilson wrote: On Fri, Oct 11, 2013 at 09:52:42PM +0300, ville.syrj...@linux.intel.com wrote: Continuing a bit with improving the vblank timestamp stuff, I decided that it's also time to fix gen2 properly. All this time we've been pretending

[Intel-gfx] [PATCH 1/2] drm/i915: pass mode to write eld

2013-10-14 Thread Jani Nikula
Signed-off-by: Jani Nikula jani.nik...@intel.com --- drivers/gpu/drm/i915/i915_drv.h |3 ++- drivers/gpu/drm/i915/intel_display.c | 11 +++ 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index

[Intel-gfx] [PATCH 2/2] drm/i915: set hdmi audio clock

2013-10-14 Thread Jani Nikula
Signed-off-by: Jani Nikula jani.nik...@intel.com --- drivers/gpu/drm/i915/i915_reg.h | 12 - drivers/gpu/drm/i915/intel_display.c | 47 +++--- 2 files changed, 54 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 0/2] drm/i915: fix hdmi audio pixel clock config

2013-10-14 Thread Jani Nikula
This is a completely untested and possibly naïve attempt at fixing [1] and [2]. Based on top of drm-intel-nightly branch of [3]. David, Jasper, please give it a try. Thanks, Jani. [1] http://mid.gmane.org/cagpeb3ep1lrzetpxhgrfbdqr5ts2tac8gcukwwuguf1u5ny...@mail.gmail.com [2]

[Intel-gfx] [PATCH 1/2] drm/i915: Do a fuller init after reset

2013-10-14 Thread Ben Widawsky
From: Ben Widawsky b...@bwidawsk.net I had this lying around from he original PPGTT series, and thought we might try to get it in by itself. It's convenient to just call i915_gem_init_hw at reset because we'll be adding new things to that function, and having just one function to call instead of

[Intel-gfx] [PATCH 2/2] drm/i915: cleanup context fini

2013-10-14 Thread Ben Widawsky
From: Ben Widawsky b...@bwidawsk.net I had this lying around from he original PPGTT series, and thought we might try to get it in by itself. With the introduction of context refcounting we never explicitly ref/unref the backing object. As such, the previous fix was a bit wonky. Aside from

Re: [Intel-gfx] [PATCH] drm/i915/lvds: don't restore hw state in the lid notifier for pch platforms

2013-10-14 Thread Roland Dreier
On Mon, Oct 14, 2013 at 10:14 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: It's not a crash, and it's been there since forever - we've simply added tons more self-consistency checks to the driver in 3.10 (and extended those checks even more in recent kernels). At least the current patch

[Intel-gfx] [PATCH] drm/i915: make backlight functions take a connector v5

2013-10-14 Thread Jesse Barnes
On VLV/BYT, backlight controls a per-pipe, so when adjusting the backlight we need to pass the correct info. So make the externally visible backlight functions take a connector argument, which can be used internally to figure out the pipe backlight to adjust. v2: make connector pipe lookup check

Re: [Intel-gfx] [PATCH] drm/i915/lvds: don't restore hw state in the lid notifier for pch platforms

2013-10-14 Thread Daniel Vetter
On Mon, Oct 14, 2013 at 7:31 PM, Roland Dreier rol...@kernel.org wrote: On Mon, Oct 14, 2013 at 10:14 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: It's not a crash, and it's been there since forever - we've simply added tons more self-consistency checks to the driver in 3.10 (and extended

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Do a fuller init after reset

2013-10-14 Thread Chris Wilson
On Mon, Oct 14, 2013 at 10:01:36AM -0700, Ben Widawsky wrote: From: Ben Widawsky b...@bwidawsk.net I had this lying around from he original PPGTT series, and thought we might try to get it in by itself. This conflicts with Mika's work to replay pending operations after the reset. But I

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Do a fuller init after reset

2013-10-14 Thread Ben Widawsky
On Mon, Oct 14, 2013 at 10:24:17PM +0100, Chris Wilson wrote: On Mon, Oct 14, 2013 at 10:01:36AM -0700, Ben Widawsky wrote: From: Ben Widawsky b...@bwidawsk.net I had this lying around from he original PPGTT series, and thought we might try to get it in by itself. This conflicts with

[Intel-gfx] [RFC] Runtime display PM for VLV/BYT

2013-10-14 Thread Jesse Barnes
This set adds bits needed for runtime power support, currently only lightly tested on VLV/BYT: 1) suspend/resume callbacks for different platforms 2) save/restore of display state across a power well toggle 3) get/put of display power well in critical places The TODO list still has a few

[Intel-gfx] [PATCH 2/5] drm/i915: add display power well report out to debugfs

2013-10-14 Thread Jesse Barnes
For tracking current state. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/i915_debugfs.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 5fd6a5d..9f81e80 100644 ---

[Intel-gfx] [PATCH 3/5] drm/i915/vlv: suspend/resume fixes for VLV/BYT

2013-10-14 Thread Jesse Barnes
We were missing a few bits around power well handling and Gunit save/restore. The code added should be sufficient for runtime D3 as well (though that requires additional changes to how we handle save/restore of state). Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org ---

[Intel-gfx] [PATCH 4/5] drm/i915: take power well refs when needed

2013-10-14 Thread Jesse Barnes
When accessing the display regs for hw state readout or cross check, we need to make sure the power well is enabled so we can read valid register state. Likewise, in an actual mode set, we need to take a ref on the appropriate power well so that the mode set succeeds. From then on, the power

[Intel-gfx] [PATCH 1/5] drm/i915/vlv: power well support for VLV/BYT

2013-10-14 Thread Jesse Barnes
Had to conditionalize some HSW bits and add virtual functions for get/set on the power wells. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/i915_drv.h | 10 +- drivers/gpu/drm/i915/intel_drv.h| 2 + drivers/gpu/drm/i915/intel_pm.c | 128

[Intel-gfx] [PATCH 5/5] drm/i915/vlv: support save/restore of display state around power well toggle

2013-10-14 Thread Jesse Barnes
If we disable the power well at runtime, we need to save enough display state so we can restore it when the power well comes back again. Add support for that on VLV by reusing some of the _freeze and _thaw code. Note we need to drop the power well lock in this path around the restore, since

Re: [Intel-gfx] Patch for crashing intel server

2013-10-14 Thread Bas Wijnen
On Sun, Oct 13, 2013 at 10:43:49AM +0100, Chris Wilson wrote: My X server was crashing when playing video, and I wrote a patch to fix it. Please find the background and the patch at http://bugs.debian.org/724944 . Ok, I can see the allocation failure that leads to the crash:

[Intel-gfx] [PATCH] drm/i915: Replace has_bsd/blt/vebox with a mask

2013-10-14 Thread Ben Widawsky
From: Ben Widawsky b...@bwidawsk.net I've sent this patch several times for various reasons. It essentially cleans up a lot of code where we need to do something per ring, and want to query whether or not the ring exists on that hardware. It has various uses coming up, but for now it shouldn't