Re: [Intel-gfx] [PATCH 3/7] drm/i915: keep freq/opcode conversion function more generic

2014-07-09 Thread Deepak S
On Thursday 10 July 2014 11:58 AM, Daniel Vetter wrote: On Fri, Jul 11, 2014 at 09:56:35AM +0530, Deepak S wrote: On Wednesday 09 July 2014 05:33 PM, Daniel Vetter wrote: On Thu, Jul 10, 2014 at 01:16:23PM +0530, deepa...@linux.intel.com wrote: From: Deepak S Since freq/encode conversion fo

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add missing locking to primary plane handlers

2014-07-09 Thread Daniel Vetter
On Wed, Jul 09, 2014 at 04:22:10PM -0700, Matt Roper wrote: > intel_primary_plane_{setplane,disable} were lacking struct_mutex locking > around their GEM operations. > > Signed-off-by: Matt Roper Both merged with a reported-by: Damien added to this one here. Btw have you checked that your primar

Re: [Intel-gfx] [PATCH] drm/i915: get/put runtime PM at i915_semaphore_status

2014-07-09 Thread Daniel Vetter
On Wed, Jul 09, 2014 at 02:02:27PM -0700, Ben Widawsky wrote: > On Wed, Jul 09, 2014 at 02:31:57PM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > Otherwise we will print some WARNs when we read registers and the > > machine is suspended. > > Do all register reads really require this?

Re: [Intel-gfx] [PATCH 3/7] drm/i915: keep freq/opcode conversion function more generic

2014-07-09 Thread Daniel Vetter
On Fri, Jul 11, 2014 at 09:56:35AM +0530, Deepak S wrote: > > On Wednesday 09 July 2014 05:33 PM, Daniel Vetter wrote: > >On Thu, Jul 10, 2014 at 01:16:23PM +0530, deepa...@linux.intel.com wrote: > >>From: Deepak S > >> > >>Since freq/encode conversion formula changes from platform to platform, >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: fix D_COMP usage on BDW

2014-07-09 Thread Daniel Vetter
On Wed, Jul 09, 2014 at 05:35:52PM +0100, Damien Lespiau wrote: > On Fri, Jul 04, 2014 at 11:59:58AM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > On HSW, the D_COMP register can be accessed through the mailbox (read > > and write) or through MMIO on a MCHBAR offset (read only). On BD

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Set M2_N2 registers during mode set

2014-07-09 Thread Vandana Kannan
On Jul-10-2014 2:42 AM, Jesse Barnes wrote: > On Mon, 7 Jul 2014 14:59:45 +0530 > Vandana Kannan wrote: > >> For Gen < 8, set M2_N2 registers on every mode set. This is required to make >> sure M2_N2 registers are set during boot, resume from sleep for cross- >> checking the state. The register

Re: [Intel-gfx] [PATCH 3/7] drm/i915: keep freq/opcode conversion function more generic

2014-07-09 Thread Deepak S
On Wednesday 09 July 2014 05:33 PM, Daniel Vetter wrote: On Thu, Jul 10, 2014 at 01:16:23PM +0530, deepa...@linux.intel.com wrote: From: Deepak S Since freq/encode conversion formula changes from platform to platform, create a generic wrapper function and having platform check inside this hel

[Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-09 Thread Daisy Sun
BDW supports GT C0 residency reporting in constant time unit. Driver calculates GT utilization based on C0 residency and adjusts RP frequency up/down accordingly. Signed-off-by: Daisy Sun [torourke: rebased on latest and resolved conflict] Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/i9

[Intel-gfx] [PATCH 2/2] drm/i915: Add a couple WARN()'s to catch missing locks

2014-07-09 Thread Matt Roper
Add !mutex_is_locked() checks to intel_pin_and_fence_fb_obj() and intel_unpin_fb_obj() to help catch failures to grab struct_mutex when operating on fb objects. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/intel_display.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/

[Intel-gfx] [PATCH 1/2] drm/i915: Add missing locking to primary plane handlers

2014-07-09 Thread Matt Roper
intel_primary_plane_{setplane,disable} were lacking struct_mutex locking around their GEM operations. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/intel_display.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Don't set the 8to6 dither flag when not scaling"

2014-07-09 Thread Pavel Machek
On Wed 2014-07-09 22:35:53, Daniel Vetter wrote: > This reverts commit 773875bfb6737982903c42d1ee88cf60af80089c. > > It is very much needed and the lack of dithering has been reported by > a large list of people with various gen2/3 hardware. > > Also, the original patch was complete non-sense sin

Re: [Intel-gfx] [PATCH 1/3] drm/crtc: Add property for aspect ratio

2014-07-09 Thread Jesse Barnes
Daniel, looks like this series has some r-bs; iirc this fixed some Asus HDMI monitors too (and who knows how many TVs). Jesse On Thu, 22 May 2014 16:50:48 +0530 Vandana Kannan wrote: > Added a property to enable user space to set aspect ratio. > This patch contains declaration of the property a

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Set M2_N2 registers during mode set

2014-07-09 Thread Jesse Barnes
On Mon, 7 Jul 2014 14:59:45 +0530 Vandana Kannan wrote: > For Gen < 8, set M2_N2 registers on every mode set. This is required to make > sure M2_N2 registers are set during boot, resume from sleep for cross- > checking the state. The register is set only if DRRS is supported. > > v2: Patch reba

Re: [Intel-gfx] [PATCH] drm/i915: get/put runtime PM at i915_semaphore_status

2014-07-09 Thread Ben Widawsky
On Wed, Jul 09, 2014 at 02:31:57PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Otherwise we will print some WARNs when we read registers and the > machine is suspended. Do all register reads really require this? If so, shouldn't it work similarly to forcewake? I didn't follow any of the

[Intel-gfx] [PATCH] Revert "drm/i915: Don't set the 8to6 dither flag when not scaling"

2014-07-09 Thread Daniel Vetter
This reverts commit 773875bfb6737982903c42d1ee88cf60af80089c. It is very much needed and the lack of dithering has been reported by a large list of people with various gen2/3 hardware. Also, the original patch was complete non-sense since the WARNING backtraces in the references bugzilla are abou

[Intel-gfx] [PATCH] tests/gem_render_copy_redux needs legacy drm nodes

2014-07-09 Thread Daniel Vetter
... since it uses flink. Fixes a regression due to: commit 6d6dfcfb883818b40b58bac61cc72cab428a7a03 Author: David Herrmann AuthorDate: Sun Mar 16 14:38:40 2014 +0100 drm: enable render-nodes by default Cc: David Herrmann Signed-off-by: Daniel Vetter --- tests/gem_render_copy_redux.c

[Intel-gfx] [PATCH 6/5] drm/i915: Add batch pool details to i915_gem_objects debugfs

2014-07-09 Thread bradley . d . volkin
From: Brad Volkin To better account for the potentially large memory consumption of the batch pool. Signed-off-by: Brad Volkin --- drivers/gpu/drm/i915/i915_debugfs.c | 45 + 1 file changed, 36 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v3 1/5] drm/i915: Implement a framework for batch buffer pools

2014-07-09 Thread bradley . d . volkin
From: Brad Volkin This adds a small module for managing a pool of batch buffers. The only current use case is for the command parser, as described in the kerneldoc in the patch. The code is simple, but separating it out makes it easier to change the underlying algorithms and to extend to future u

[Intel-gfx] [PATCH] drm/i915: get/put runtime PM at i915_semaphore_status

2014-07-09 Thread Paulo Zanoni
From: Paulo Zanoni Otherwise we will print some WARNs when we read registers and the machine is suspended. Testcase: igt/pm_rpm/debugfs-read Cc: Ben Widawsky Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_debugfs.c | 2 ++ 1 file changed, 2 insertions(+) I still dream with the day

Re: [Intel-gfx] [PATCH 2/2] intel-gpu-tools: Re-use igt_subtest_init for simple tests

2014-07-09 Thread Damien Lespiau
On Wed, Jul 09, 2014 at 04:23:50PM +0200, Daniel Vetter wrote: > For me the only trouble with this disdinction is that people consistently > place tests in the wrong Makefile target. Hence I'd like to see those two > Makefile targets being unified (which requires adjustements in piglit, > too) to v

Re: [Intel-gfx] [PATCH 2/2] drm/i915: fix D_COMP usage on BDW

2014-07-09 Thread Damien Lespiau
On Fri, Jul 04, 2014 at 11:59:58AM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > On HSW, the D_COMP register can be accessed through the mailbox (read > and write) or through MMIO on a MCHBAR offset (read only). On BDW, the > access should be done through MMIO on another address. So to acco

Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix hsw_write_dcomp() error message

2014-07-09 Thread Damien Lespiau
On Fri, Jul 04, 2014 at 11:59:57AM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > That function can be used to write anything on D_COMP, not just > disable it, so print a more appropriate message. > > Signed-off-by: Paulo Zanoni Reviewed-by: Damien Lespiau > --- > drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Add a batch pool debugfs file

2014-07-09 Thread Chris Wilson
On Wed, Jul 09, 2014 at 08:56:31AM -0700, Volkin, Bradley D wrote: > On Wed, Jul 09, 2014 at 12:36:38AM -0700, Chris Wilson wrote: > > On Tue, Jul 08, 2014 at 03:26:38PM -0700, bradley.d.vol...@intel.com wrote: > > > From: Brad Volkin > > > > > > It provides some useful information about the buff

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915: Implement a framework for batch buffer pools

2014-07-09 Thread Chris Wilson
On Wed, Jul 09, 2014 at 08:59:29AM -0700, Volkin, Bradley D wrote: > On Wed, Jul 09, 2014 at 08:30:08AM -0700, Chris Wilson wrote: > > You need to check that the shrinker hasn't truncated your backing > > storage whilst it was marked DONTNEED. It just amounts to checking for > > obj->madv == __I915

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Add a batch pool debugfs file

2014-07-09 Thread Volkin, Bradley D
On Wed, Jul 09, 2014 at 12:36:38AM -0700, Chris Wilson wrote: > On Tue, Jul 08, 2014 at 03:26:38PM -0700, bradley.d.vol...@intel.com wrote: > > From: Brad Volkin > > > > It provides some useful information about the buffers in > > the global command parser batch pool. > > > > v2: rebase on globa

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915: Implement a framework for batch buffer pools

2014-07-09 Thread Volkin, Bradley D
On Wed, Jul 09, 2014 at 08:30:08AM -0700, Chris Wilson wrote: > On Wed, Jul 09, 2014 at 08:10:47AM -0700, Volkin, Bradley D wrote: > > On Wed, Jul 09, 2014 at 12:37:08AM -0700, Chris Wilson wrote: > > > On Tue, Jul 08, 2014 at 03:26:36PM -0700, bradley.d.vol...@intel.com > > > wrote: > > > > From:

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915: Implement a framework for batch buffer pools

2014-07-09 Thread Chris Wilson
On Wed, Jul 09, 2014 at 08:10:47AM -0700, Volkin, Bradley D wrote: > On Wed, Jul 09, 2014 at 12:37:08AM -0700, Chris Wilson wrote: > > On Tue, Jul 08, 2014 at 03:26:36PM -0700, bradley.d.vol...@intel.com wrote: > > > From: Brad Volkin > > > > > > This adds a small module for managing a pool of ba

Re: [Intel-gfx] [PATCH 4/4] drm/i915: remove i915_rstdby_delays debugfs entry

2014-07-09 Thread Jesse Barnes
On Wed, 9 Jul 2014 15:10:46 +0300 Mika Kuoppala wrote: > CHV hard hangs on reading on 0x11100 > > References: https://bugs.freedesktop.org/show_bug.cgi?id=80893 > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_debugfs.c | 24 > 1 file changed, 24 del

Re: [Intel-gfx] [PATCH 3/4] drm/i915: remove i915_gfxec debugfs entry

2014-07-09 Thread Jesse Barnes
On Wed, 9 Jul 2014 15:10:45 +0300 Mika Kuoppala wrote: > CHV hard hangs on reading on 0x112f4. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=80893 > Suggested-by: Daniel Vetter > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_debugfs.c | 21 --

Re: [Intel-gfx] [PATCH 1/4] drm/i915: remove i915_delayedfreq_table debugfs entry

2014-07-09 Thread Jesse Barnes
On Wed, 9 Jul 2014 15:10:43 +0300 Mika Kuoppala wrote: > CHV hard hangs on reading these registers. As these have not > been used since cantiga & ilk, remove the debugfs entry. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=80893 > Suggested-by: Jesse Barnes > Signed-off-by: Mika

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915: Implement a framework for batch buffer pools

2014-07-09 Thread Volkin, Bradley D
On Wed, Jul 09, 2014 at 12:37:08AM -0700, Chris Wilson wrote: > On Tue, Jul 08, 2014 at 03:26:36PM -0700, bradley.d.vol...@intel.com wrote: > > From: Brad Volkin > > > > This adds a small module for managing a pool of batch buffers. > > The only current use case is for the command parser, as desc

Re: [Intel-gfx] [RFC] libdrm_intel: Add support for userptr objects

2014-07-09 Thread Chris Wilson
On Wed, Jul 09, 2014 at 04:25:55PM +0200, Daniel Vetter wrote: > On Wed, Jul 09, 2014 at 02:16:59PM +0100, Damien Lespiau wrote: > > On Wed, Jul 09, 2014 at 02:08:08PM +0100, Tvrtko Ursulin wrote: > > > > > > On 06/19/2014 12:13 PM, Damien Lespiau wrote: > > > >On Wed, Feb 26, 2014 at 04:41:41PM +

Re: [Intel-gfx] [RFC] libdrm_intel: Add support for userptr objects

2014-07-09 Thread Daniel Vetter
On Wed, Jul 09, 2014 at 02:16:59PM +0100, Damien Lespiau wrote: > On Wed, Jul 09, 2014 at 02:08:08PM +0100, Tvrtko Ursulin wrote: > > > > On 06/19/2014 12:13 PM, Damien Lespiau wrote: > > >On Wed, Feb 26, 2014 at 04:41:41PM +, Tvrtko Ursulin wrote: > > >>From: Tvrtko Ursulin > > >> > > >>Allo

Re: [Intel-gfx] [PATCH 2/2] intel-gpu-tools: Re-use igt_subtest_init for simple tests

2014-07-09 Thread Daniel Vetter
On Wed, Jul 09, 2014 at 01:23:46PM +, Gore, Tim wrote: > Some comments on Daniels' comments inline > > > -Original Message- > > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > > Not sure whether forcing the reuse of igt_subtest_init makes a lot of sense > > si

Re: [Intel-gfx] [PATCH 1/2] intel-gpu-tools: pass argc/argv to simple main

2014-07-09 Thread Daniel Vetter
On Wed, Jul 09, 2014 at 01:50:30PM +, Gore, Tim wrote: > Some inline comments > > Tim > > > -Original Message- > > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > > Vetter > > Sent: Monday, July 07, 2014 5:12 PM > > To: Gore, Tim > > Cc: intel-gfx@lists.fre

Re: [Intel-gfx] [RFC 10/44] drm/i915: Prepare retire_requests to handle out-of-order seqnos

2014-07-09 Thread Daniel Vetter
On Mon, Jul 07, 2014 at 09:05:50PM +0200, Daniel Vetter wrote: > On Thu, Jun 26, 2014 at 06:24:01PM +0100, john.c.harri...@intel.com wrote: > > From: John Harrison > > > > A major point of the GPU scheduler is that it re-orders batch buffers after > > they > > have been submitted to the driver.

Re: [Intel-gfx] [PATCH 1/2] intel-gpu-tools: pass argc/argv to simple main

2014-07-09 Thread Gore, Tim
Some inline comments Tim > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > Vetter > Sent: Monday, July 07, 2014 5:12 PM > To: Gore, Tim > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 1/2] intel-gpu-tools: pass argc/

Re: [Intel-gfx] [PATCH 2/2] intel-gpu-tools: Re-use igt_subtest_init for simple tests

2014-07-09 Thread Gore, Tim
Some comments on Daniels' comments inline > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > Vetter > Sent: Monday, July 07, 2014 5:10 PM > To: Gore, Tim > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 2/2] intel-gpu-too

Re: [Intel-gfx] [RFC] libdrm_intel: Add support for userptr objects

2014-07-09 Thread Damien Lespiau
On Wed, Jul 09, 2014 at 02:08:08PM +0100, Tvrtko Ursulin wrote: > > On 06/19/2014 12:13 PM, Damien Lespiau wrote: > >On Wed, Feb 26, 2014 at 04:41:41PM +, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>Allow userptr objects to be created and used via libdrm_intel. > >> > >>At the mom

Re: [Intel-gfx] [RFC] libdrm_intel: Add support for userptr objects

2014-07-09 Thread Tvrtko Ursulin
On 06/19/2014 12:13 PM, Damien Lespiau wrote: On Wed, Feb 26, 2014 at 04:41:41PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Allow userptr objects to be created and used via libdrm_intel. At the moment tiling and mapping to GTT aperture is not supported due hardware limitations across

Re: [Intel-gfx] [PATCH 0/4] remove obsolete debugfs entries

2014-07-09 Thread Daniel Vetter
On Wed, Jul 09, 2014 at 03:10:42PM +0300, Mika Kuoppala wrote: > These are accessing registers that the chv doesn't seem to > have. Read access on these regions cause a system hard hang. > > If some of these are still on use just nack and I do > gen check patch instead. For the first two we could

Re: [Intel-gfx] [PATCH i-g-t 1/4] core: Free buffer allocated with vasprintf()

2014-07-09 Thread Daniel Vetter
On Wed, Jul 09, 2014 at 01:06:08PM +0100, Damien Lespiau wrote: > On Wed, Jul 09, 2014 at 01:56:02PM +0200, Daniel Vetter wrote: > > On Wed, Jul 09, 2014 at 11:45:18AM +0100, Damien Lespiau wrote: > > > We were leaking a bit. > > > > > > Signed-off-by: Damien Lespiau > > > --- > > > lib/igt_core

[Intel-gfx] [PATCH 0/4] remove obsolete debugfs entries

2014-07-09 Thread Mika Kuoppala
These are accessing registers that the chv doesn't seem to have. Read access on these regions cause a system hard hang. If some of these are still on use just nack and I do gen check patch instead. Mika Kuoppala (4): drm/i915: remove i915_delayedfreq_table debugfs entry drm/i915: remove i915_

[Intel-gfx] [PATCH 3/4] drm/i915: remove i915_gfxec debugfs entry

2014-07-09 Thread Mika Kuoppala
CHV hard hangs on reading on 0x112f4. References: https://bugs.freedesktop.org/show_bug.cgi?id=80893 Suggested-by: Daniel Vetter Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_debugfs.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 1/4] drm/i915: remove i915_delayedfreq_table debugfs entry

2014-07-09 Thread Mika Kuoppala
CHV hard hangs on reading these registers. As these have not been used since cantiga & ilk, remove the debugfs entry. References: https://bugs.freedesktop.org/show_bug.cgi?id=80893 Suggested-by: Jesse Barnes Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_debugfs.c | 27 ---

[Intel-gfx] [PATCH 4/4] drm/i915: remove i915_rstdby_delays debugfs entry

2014-07-09 Thread Mika Kuoppala
CHV hard hangs on reading on 0x11100 References: https://bugs.freedesktop.org/show_bug.cgi?id=80893 Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_debugfs.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/g

Re: [Intel-gfx] [PATCH i-g-t 1/4] core: Free buffer allocated with vasprintf()

2014-07-09 Thread Damien Lespiau
On Wed, Jul 09, 2014 at 01:56:02PM +0200, Daniel Vetter wrote: > On Wed, Jul 09, 2014 at 11:45:18AM +0100, Damien Lespiau wrote: > > We were leaking a bit. > > > > Signed-off-by: Damien Lespiau > > --- > > lib/igt_core.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/lib/igt_c

Re: [Intel-gfx] [PATCH 3/7] drm/i915: keep freq/opcode conversion function more generic

2014-07-09 Thread Daniel Vetter
On Thu, Jul 10, 2014 at 01:16:23PM +0530, deepa...@linux.intel.com wrote: > From: Deepak S > > Since freq/encode conversion formula changes from platform to platform, > create a generic wrapper function and having platform check inside this > help to simpilfy adding newer platform freq/opcode con

Re: [Intel-gfx] [PATCH i-g-t 4/4] core: Apply the same treatment to the in errno message in __igt_fail_assert()

2014-07-09 Thread Daniel Vetter
On Wed, Jul 09, 2014 at 11:45:21AM +0100, Damien Lespiau wrote: > Just like the it was done for the requirement message, display the errno > message only if errno is set, and display it at the end of the assert > message. > > Signed-off-by: Damien Lespiau Patches 2&4 are Reviewed-by: Daniel Vett

Re: [Intel-gfx] [PATCH i-g-t 3/4] core: Only display the errno message if errno is set

2014-07-09 Thread Daniel Vetter
On Wed, Jul 09, 2014 at 11:45:20AM +0100, Damien Lespiau wrote: > Signed-off-by: Damien Lespiau > --- > lib/igt_core.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/lib/igt_core.c b/lib/igt_core.c > index 4dbcb1a..e66d096 100644 > --- a/lib/igt_core.c >

Re: [Intel-gfx] [PATCH i-g-t 1/4] core: Free buffer allocated with vasprintf()

2014-07-09 Thread Daniel Vetter
On Wed, Jul 09, 2014 at 11:45:18AM +0100, Damien Lespiau wrote: > We were leaking a bit. > > Signed-off-by: Damien Lespiau > --- > lib/igt_core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/igt_core.c b/lib/igt_core.c > index 7ac7ebe..364cdd0 100644 > --- a/lib/igt_core.c > +

[Intel-gfx] [PATCH] drm/i915/chv: calculate rc6 residency correctly

2014-07-09 Thread Mika Kuoppala
The register to read cz count is different from vlv. Also the counts returned from CCK_CTL1 for BSW are (ticks in 30ns - 1). czcount_30ns of value 1 is a special case for 320Mhz. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80703 Suggested-by: Deepak S Cc: Jesse Barnes Signed-off-by: M

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make use of intel_fb_obj() (v2)

2014-07-09 Thread Daniel Vetter
On Wed, Jul 09, 2014 at 10:29:09AM +0100, Chris Wilson wrote: > On Tue, Jul 08, 2014 at 07:50:07AM -0700, Matt Roper wrote: > > This should hopefully simplify the display code slightly and also > > solves at least one mistake in intel_pipe_set_base() where > > to_intel_framebuffer(fb)->obj is refer

[Intel-gfx] [PATCH i-g-t 1/4] core: Free buffer allocated with vasprintf()

2014-07-09 Thread Damien Lespiau
We were leaking a bit. Signed-off-by: Damien Lespiau --- lib/igt_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/igt_core.c b/lib/igt_core.c index 7ac7ebe..364cdd0 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -591,6 +591,8 @@ void __igt_skip_check(const char *file, const

[Intel-gfx] [PATCH i-g-t 2/4] core: Put the requirement failure messages together

2014-07-09 Thread Damien Lespiau
The errno message was a bit in the middle here, it makes more sense to group the messages about why the test requirement wasn't met together. Signed-off-by: Damien Lespiau --- lib/igt_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/igt_core.c b/lib/igt

[Intel-gfx] [PATCH i-g-t 4/4] core: Apply the same treatment to the in errno message in __igt_fail_assert()

2014-07-09 Thread Damien Lespiau
Just like the it was done for the requirement message, display the errno message only if errno is set, and display it at the end of the assert message. Signed-off-by: Damien Lespiau --- lib/igt_core.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/igt_core.c

[Intel-gfx] [PATCH i-g-t 3/4] core: Only display the errno message if errno is set

2014-07-09 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- lib/igt_core.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 4dbcb1a..e66d096 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -575,6 +575,10 @@ void __igt_skip_check(const char *file,

[Intel-gfx] [PATCH i-g-t] kms_plane: Specify the pipe when grabbing reference CRCs

2014-07-09 Thread Damien Lespiau
When changing the pipe we were using, test_grab_crc() wasn't correctly setting the pipe constraint before waiting for the CRC on the pipe, and so we ended up waiting for a CRC on a pipe that wasn't lit up. Signed-off-by: Damien Lespiau --- tests/kms_plane.c | 12 +++- 1 file changed, 7 i

Re: [Intel-gfx] Grab GPU output

2014-07-09 Thread Chris Wilson
On Mon, Jul 07, 2014 at 10:17:44AM -0600, reza wrote: > Hi, > We're working on Video Wall project on Linux, I need to know if it's > possible to grab Intel gpu output frames or not ? Not without a video grabber or some other hardware device. Usually people choose a software approach as below. > I

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make use of intel_fb_obj() (v2)

2014-07-09 Thread Chris Wilson
On Tue, Jul 08, 2014 at 07:50:07AM -0700, Matt Roper wrote: > This should hopefully simplify the display code slightly and also > solves at least one mistake in intel_pipe_set_base() where > to_intel_framebuffer(fb)->obj is referenced during local variable > initialization, before 'if (!fb)' gets c

[Intel-gfx] [PULL] drm-intel-fixes

2014-07-09 Thread Daniel Vetter
Hi Dave, Fixes for regressions and black screens, cc: stable where applicapable (the last minute rebase was to sprinkle missing stable tags). A bit more than what I'd wish for, but excluding vlv and that the first 3 patches are just quirks for 1 regression it looks much better. There's still a "o

[Intel-gfx] [PATCH 6/7] drm/i915/chv: Add basic PM interrupt support for CHV

2014-07-09 Thread deepak . s
From: Deepak S Enabled PM interrupt programming for CHV. Re-using gen8 code and extending same for CHV. Signed-off-by: Deepak S --- drivers/gpu/drm/i915/i915_irq.c | 2 +- drivers/gpu/drm/i915/intel_pm.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i

[Intel-gfx] [PATCH 1/7] drm/i915: Read guaranteed freq for valleyview

2014-07-09 Thread deepak . s
From: Deepak S Reading RP1 for valleyview to help us enable "pm_rps" i-g-t testcase execution. Signed-off-by: Deepak S --- drivers/gpu/drm/i915/intel_pm.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c ind

[Intel-gfx] [PATCH 5/7] drm/i915: CHV GPU frequency to opcode functions

2014-07-09 Thread deepak . s
From: Deepak S Adding chv specific fre/encode conversion. Signed-off-by: Deepak S --- drivers/gpu/drm/i915/intel_pm.c | 68 +++-- 1 file changed, 59 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH 7/7] drm/i915: Add RP1 render P state thresholds in CHV

2014-07-09 Thread deepak . s
From: Deepak S This is useful for userspace utilities to verify and micromanaging the increase/decrease frequncy. Signed-off-by: Deepak S --- drivers/gpu/drm/i915/intel_pm.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i

[Intel-gfx] [PATCH 0/7] Enable RP1/RPn/RP0 sysfs and enable CHV PM interrupt

2014-07-09 Thread deepak . s
From: Deepak S Enable RP1/RPn/RP0 sysfs and enable CHV PM interrupt for verifying the freq on VLV and CHV Deepak S (7): drm/i915: Read guaranteed freq for valleyview drm/i915: Add RP0/RP1/RPn render P state thresholds in VLV sysfs drm/i915: keep freq/opcode conversion function more generi

[Intel-gfx] [PATCH 4/7] drm/i915: populate mem_freq/cz_clock for chv

2014-07-09 Thread deepak . s
From: Deepak S We need mem_freq or cz clock for freq/opcode conversion Signed-off-by: Deepak S --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_reg.h | 6 ++ drivers/gpu/drm/i915/intel_pm.c | 29 + 3 files changed, 36 insertions(+) diff --

[Intel-gfx] [PATCH 3/7] drm/i915: keep freq/opcode conversion function more generic

2014-07-09 Thread deepak . s
From: Deepak S Since freq/encode conversion formula changes from platform to platform, create a generic wrapper function and having platform check inside this help to simpilfy adding newer platform freq/opcode conversion. Signed-off-by: Deepak S --- drivers/gpu/drm/i915/i915_debugfs.c | 14 +++

[Intel-gfx] [PATCH 2/7] drm/i915: Add RP0/RP1/RPn render P state thresholds in VLV sysfs

2014-07-09 Thread deepak . s
From: Deepak S This is useful for userspace utilities to verify and micromanaging the increase/decrease frequncy. Signed-off-by: Deepak S --- drivers/gpu/drm/i915/i915_sysfs.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_sysf

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915: Implement a framework for batch buffer pools

2014-07-09 Thread Chris Wilson
On Tue, Jul 08, 2014 at 03:26:36PM -0700, bradley.d.vol...@intel.com wrote: > From: Brad Volkin > > This adds a small module for managing a pool of batch buffers. > The only current use case is for the command parser, as described > in the kerneldoc in the patch. The code is simple, but separatin

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Add a batch pool debugfs file

2014-07-09 Thread Chris Wilson
On Tue, Jul 08, 2014 at 03:26:38PM -0700, bradley.d.vol...@intel.com wrote: > From: Brad Volkin > > It provides some useful information about the buffers in > the global command parser batch pool. > > v2: rebase on global pool instead of per-ring pools Include the counts in i915_gem_objects as

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915: Implement a framework for batch buffer pools

2014-07-09 Thread Chris Wilson
On Tue, Jul 08, 2014 at 03:26:36PM -0700, bradley.d.vol...@intel.com wrote: > +void i915_gem_batch_pool_fini(struct i915_gem_batch_pool *pool) > +{ > + struct drm_i915_gem_object *obj, *next; > + > + WARN_ON(!mutex_is_locked(&pool->dev->struct_mutex)); > + WARN_ON(!list_empty(&pool->act