[Intel-gfx] [PATCH] drm/i915: Update comment in clear_intel_crtc_state()

2015-05-20 Thread Ander Conselvan de Oliveira
Explain why a few fields of the new pipe_config have their values preserved, while the others are zeroed. Signed-off-by: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com --- drivers/gpu/drm/i915/intel_display.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

Re: [Intel-gfx] [PATCH] Documentation/drm: Update rotation property with 90/270 and description

2015-05-20 Thread Jindal, Sonika
On 5/13/2015 9:57 AM, Jindal, Sonika wrote: On 5/12/2015 6:20 PM, Ville Syrjälä wrote: On Wed, Apr 15, 2015 at 04:05:19PM +0530, Sonika Jindal wrote: Cc: dri-de...@lists.freedesktop.org Signed-off-by: Sonika Jindal sonika.jin...@intel.com --- Documentation/DocBook/drm.tmpl |7 +--

Re: [Intel-gfx] [PATCH i-g-t] libs/igt_core.c: Fix compile warnings in igt_core.c

2015-05-20 Thread Daniel Vetter
On Tue, May 19, 2015 at 01:35:41PM +, Gore, Tim wrote: -Original Message- From: Morton, Derek J Sent: Tuesday, May 19, 2015 12:21 PM To: intel-gfx@lists.freedesktop.org Cc: Wood, Thomas; Gore, Tim; Morton, Derek J Subject: [PATCH i-g-t] libs/igt_core.c: Fix compile

Re: [Intel-gfx] [PATCH i-g-t] libs/igt_core.c: Fix compile warnings in igt_core.c

2015-05-20 Thread Jani Nikula
On Tue, 19 May 2015, Derek Morton derek.j.mor...@intel.com wrote: Fixed variables incorrectly declared as signed instead of unsigned. Fixed 'unused parameter' warning from signal handlers that were not using the signal parameter. v2: Addressed comments from Tim Gore Signed-off-by: Derek

Re: [Intel-gfx] [PATCH 08/12] drm/i915: Add NV12 support to intel_framebuffer_init

2015-05-20 Thread Daniel Vetter
On Tue, May 19, 2015 at 04:31:54PM +, Konduru, Chandra wrote: -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Tuesday, May 19, 2015 1:24 AM To: Konduru, Chandra Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel;

Re: [Intel-gfx] [PATCH] drm/i915: Update comment in clear_intel_crtc_state()

2015-05-20 Thread Jani Nikula
On Wed, 20 May 2015, Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com wrote: Explain why a few fields of the new pipe_config have their values preserved, while the others are zeroed. Signed-off-by: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com ---

Re: [Intel-gfx] [PATCH] drm/i915/dp: make link rate printing prettier

2015-05-20 Thread Jani Nikula
On Tue, 19 May 2015, David Weinehall david.weineh...@linux.intel.com wrote: On Mon, May 18, 2015 at 04:01:45PM +0300, Jani Nikula wrote: Turn [drm:intel_dp_print_rates] source rates: 162000,27,54, [drm:intel_dp_print_rates] sink rates: 162000,27,

Re: [Intel-gfx] Experiencing FIFO underruns on Intel Skylake platform

2015-05-20 Thread Rainer Koenig
Am 19.05.2015 um 13:41 schrieb Jani Nikula: For brand new platforms you should be running drm-intel-nightly branch from http://cgit.freedesktop.org/drm-intel. Thanks, will try out next. Double check that you have either i915.preliminary_hw_support=1 module parameter set or

Re: [Intel-gfx] [PATCH 2/4] drm/i915/skl: add F0 stepping ID

2015-05-20 Thread Daniel Vetter
On Tue, May 19, 2015 at 03:42:45PM +0100, Damien Lespiau wrote: On Tue, May 19, 2015 at 03:05:00PM +0300, Imre Deak wrote: Signed-off-by: Imre Deak imre.d...@intel.com Reviewed-by: Damien Lespiau damien.lesp...@intel.com Merged the first 2 patches from this series to dinq, thanks. -Daniel

Re: [Intel-gfx] [PATCH] drm/i915: Update comment in clear_intel_crtc_state()

2015-05-20 Thread Daniel Vetter
On Wed, May 20, 2015 at 09:03:27AM +0300, Ander Conselvan de Oliveira wrote: Explain why a few fields of the new pipe_config have their values preserved, while the others are zeroed. Signed-off-by: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com Queued for -next, thanks

Re: [Intel-gfx] [PATCH] drm/i915: Update comment in clear_intel_crtc_state()

2015-05-20 Thread Ander Conselvan De Oliveira
On Wed, 2015-05-20 at 10:37 +0300, Jani Nikula wrote: On Wed, 20 May 2015, Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com wrote: Explain why a few fields of the new pipe_config have their values preserved, while the others are zeroed. Signed-off-by: Ander Conselvan de

[Intel-gfx] [PATCH] drm/plane-helper: Adapt cursor hack to transitional helpers

2015-05-20 Thread Daniel Vetter
In commit f02ad907cd9e7fe3a6405d2d005840912f1ed258 Author: Daniel Vetter daniel.vet...@ffwll.ch Date: Thu Jan 22 16:36:23 2015 +0100 drm/atomic-helpers: Recover full cursor plane behaviour we've added a hack to atomic helpers to never to vblank waits for cursor updates through the legacy

Re: [Intel-gfx] [PATCH i-g-t v3] libs/igt_core.c: Fix compile warnings in igt_core.c

2015-05-20 Thread Chris Wilson
On Wed, May 20, 2015 at 10:00:31AM +0100, Derek Morton wrote: Fixed variables incorrectly declared as signed instead of unsigned. Objection. If those array_sizes were larger than INT_MAX we have serious problems. It would have been cleaner to keep the int (since you cast to it anyway as the

Re: [Intel-gfx] [PATCH i-g-t] libs/igt_core.c: Fix compile warnings in igt_core.c

2015-05-20 Thread Gore, Tim
-Original Message- From: Lespiau, Damien Sent: Wednesday, May 20, 2015 10:48 AM To: Morton, Derek J Cc: Daniel Vetter; Gore, Tim; intel-gfx@lists.freedesktop.org; Wood, Thomas Subject: Re: [Intel-gfx] [PATCH i-g-t] libs/igt_core.c: Fix compile warnings in igt_core.c On Wed,

Re: [Intel-gfx] [PATCH i-g-t] libs/igt_core.c: Fix compile warnings in igt_core.c

2015-05-20 Thread Jani Nikula
On Wed, 20 May 2015, Gore, Tim tim.g...@intel.com wrote: -Original Message- From: Lespiau, Damien Sent: Wednesday, May 20, 2015 10:48 AM To: Morton, Derek J Cc: Daniel Vetter; Gore, Tim; intel-gfx@lists.freedesktop.org; Wood, Thomas Subject: Re: [Intel-gfx] [PATCH i-g-t]

[Intel-gfx] [PATCH] drm/i915: Force clean compilation with -Werror

2015-05-20 Thread Chris Wilson
Our driver compiles clean (nowadays thanks to 0day) but for me, at least, it would be beneficial if the compiler threw an error rather than a warning when it found a piece of suspect code. (I use this to compile-check patch series and want to break on the first compiler error in order to fix the

Re: [Intel-gfx] Experiencing FIFO underruns on Intel Skylake platform

2015-05-20 Thread Rainer Koenig
Am 19.05.2015 um 13:41 schrieb Jani Nikula: +intel-gfx For brand new platforms you should be running drm-intel-nightly branch from http://cgit.freedesktop.org/drm-intel. Tested now, drm-intel-nightly solves the problem. Thanks a lot Rainer -- Dipl.-Inf. (FH) Rainer Koenig Project Manager

Re: [Intel-gfx] [PATCH] drm/i915: Swapping 90 and 270 to be compliant with Xrandr

2015-05-20 Thread Daniel Vetter
On Wed, May 20, 2015 at 01:40:48PM +0530, Sonika Jindal wrote: Since DRM_ROTATE is counter clockwise (which is compliant with Xrandr), and HW rotation is clockwise, swapping 90/270 to work as expected from userspace. v2: Rebased Suggested-by: Ville Syrjälä ville.syrj...@linux.intel.com

Re: [Intel-gfx] [PATCH] drm/i915: Update comment in clear_intel_crtc_state()

2015-05-20 Thread Daniel Vetter
On Wed, May 20, 2015 at 10:43:20AM +0300, Ander Conselvan De Oliveira wrote: On Wed, 2015-05-20 at 10:37 +0300, Jani Nikula wrote: On Wed, 20 May 2015, Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com wrote: Explain why a few fields of the new pipe_config have their

[Intel-gfx] [PATCH i-g-t v3] libs/igt_core.c: Fix compile warnings in igt_core.c

2015-05-20 Thread Derek Morton
Fixed variables incorrectly declared as signed instead of unsigned. v2: Addressed comments from Tim Gore v3: Removed 'unused parameter' changes Signed-off-by: Derek Morton derek.j.mor...@intel.com --- lib/igt_core.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff

Re: [Intel-gfx] [PATCH i-g-t] libs/igt_core.c: Fix compile warnings in igt_core.c

2015-05-20 Thread Daniel Vetter
On Wed, May 20, 2015 at 08:37:56AM +, Morton, Derek J wrote: -Original Message- From: Morton, Derek J Sent: Tuesday, May 19, 2015 12:21 PM To: intel-gfx@lists.freedesktop.org Cc: Wood, Thomas; Gore, Tim; Morton, Derek J Subject: [PATCH i-g-t] libs/igt_core.c: Fix

Re: [Intel-gfx] [PATCH i-g-t] libs/igt_core.c: Fix compile warnings in igt_core.c

2015-05-20 Thread Damien Lespiau
On Wed, May 20, 2015 at 08:37:56AM +, Morton, Derek J wrote: -Original Message- From: Morton, Derek J Sent: Tuesday, May 19, 2015 12:21 PM To: intel-gfx@lists.freedesktop.org Cc: Wood, Thomas; Gore, Tim; Morton, Derek J Subject: [PATCH i-g-t] libs/igt_core.c: Fix

[Intel-gfx] [PATCH] drm/i915: Swapping 90 and 270 to be compliant with Xrandr

2015-05-20 Thread Sonika Jindal
Since DRM_ROTATE is counter clockwise (which is compliant with Xrandr), and HW rotation is clockwise, swapping 90/270 to work as expected from userspace. v2: Rebased Suggested-by: Ville Syrjälä ville.syrj...@linux.intel.com Cc: Ville Syrjälä ville.syrj...@linux.intel.com Signed-off-by: Sonika

Re: [Intel-gfx] Experiencing FIFO underruns on Intel Skylake platform

2015-05-20 Thread Jani Nikula
On Wed, 20 May 2015, Rainer Koenig rainer.koe...@ts.fujitsu.com wrote: Am 19.05.2015 um 13:41 schrieb Jani Nikula: +intel-gfx For brand new platforms you should be running drm-intel-nightly branch from http://cgit.freedesktop.org/drm-intel. Tested now, drm-intel-nightly solves the

Re: [Intel-gfx] [PATCH] Documentation/drm: Update rotation property with 90/270 and description

2015-05-20 Thread Jindal, Sonika
On 5/13/2015 9:57 AM, Jindal, Sonika wrote: On 5/12/2015 6:20 PM, Ville Syrjälä wrote: On Wed, Apr 15, 2015 at 04:05:19PM +0530, Sonika Jindal wrote: Cc: dri-de...@lists.freedesktop.org Signed-off-by: Sonika Jindal sonika.jin...@intel.com --- Documentation/DocBook/drm.tmpl |7 +--

Re: [Intel-gfx] [PATCH i-g-t] libs/igt_core.c: Fix compile warnings in igt_core.c

2015-05-20 Thread Morton, Derek J
-Original Message- From: Morton, Derek J Sent: Tuesday, May 19, 2015 12:21 PM To: intel-gfx@lists.freedesktop.org Cc: Wood, Thomas; Gore, Tim; Morton, Derek J Subject: [PATCH i-g-t] libs/igt_core.c: Fix compile warnings in igt_core.c Fixed variables incorrectly

Re: [Intel-gfx] [RFC PATCH v2] perf: Add PERF_EVENT_IOC_FLUSH ioctl

2015-05-20 Thread Ingo Molnar
* Robert Bragg rob...@sixbynine.org wrote: To allow for pmus that may have internal buffering (e.g. the hardware itself writes out data to its own circular buffer which is only periodically forwarded to userspace via perf) this ioctl enables userspace to explicitly ensure it has received all

[Intel-gfx] [PATCH i-g-t v4] libs/igt_core.c: Fix compile warnings in igt_core.c

2015-05-20 Thread Derek Morton
Fixed variables incorrectly declared as int instead of size_t. v2: Addressed comments from Tim Gore v3: Removed 'unused parameter' changes v4: Changed to size_t Signed-off-by: Derek Morton derek.j.mor...@intel.com --- lib/igt_core.c | 14 +++--- 1 file changed, 7 insertions(+), 7

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add 90/270 rotation for NV12 format.

2015-05-20 Thread Ville Syrjälä
On Mon, May 18, 2015 at 07:19:19PM +, Runyan, Arthur J wrote: The statement is correct - the X offset must always be even for YUV422+NV12, and the Y offset must be even when rotated 90/270 degrees. Hmm. Can you elaborate a bit? I'm curious where this limitation comes from. From:

[Intel-gfx] [PATCH] drm/i915: Map the execlists context regs once during pinning

2015-05-20 Thread Chris Wilson
When we pin the execlists context on queuing, it the ideal time to map the register page that we need to update when we submit the request to the hardware (and keep it around for future requests). This avoids having to do an atomic kmap on every submission. On the other hand, it does depend upon

[Intel-gfx] [PATCH] drm/i915: Force clean compilation with -Werror

2015-05-20 Thread Chris Wilson
Our driver compiles clean (nowadays thanks to 0day) but for me, at least, it would be beneficial if the compiler threw an error rather than a warning when it found a piece of suspect code. (I use this to compile-check patch series and want to break on the first compiler error in order to fix the

Re: [Intel-gfx] [PATCH] drm/i915: Map the execlists context regs once during pinning

2015-05-20 Thread Chris Wilson
On Wed, May 20, 2015 at 02:12:37PM +0100, Chris Wilson wrote: When we pin the execlists context on queuing, it the ideal time to map the register page that we need to update when we submit the request to the hardware (and keep it around for future requests). This avoids having to do an

[Intel-gfx] [PATCH] drm/i915: Fix ilk watermarks calculation when primary plane is disabled

2015-05-20 Thread Ander Conselvan de Oliveira
On Fedora 21 or 22, when the transition from the X server to the wayland compositor is done, the CRTC with the login screen is left active with a disabled fb. A cursor ioctl after the transition causes the watermarks to be updated, but due to the logic in intel_crtc_active() checking for the

Re: [Intel-gfx] [PATCH] drm/i915: Force clean compilation with -Werror

2015-05-20 Thread Damien Lespiau
On Wed, May 20, 2015 at 11:35:28AM +0100, Chris Wilson wrote: Our driver compiles clean (nowadays thanks to 0day) but for me, at least, it would be beneficial if the compiler threw an error rather than a warning when it found a piece of suspect code. (I use this to compile-check patch series

[Intel-gfx] [PATCH v3 02/22] drm/i915: get rid of intel_crtc_disable and related code, v2

2015-05-20 Thread Maarten Lankhorst
Now that the dpll updates are (mostly) atomic, the .off() code is a noop, and intel_crtc_disable does mostly the same as intel_modeset_update_state. Move all logic for connectors_active and setting dpms to that function. Changes since v1: - Move drm_atomic_helper_swap_state up. Changes since v2:

[Intel-gfx] [PATCH v3 03/22] drm/i915: use intel_crtc_control everywhere, v2.

2015-05-20 Thread Maarten Lankhorst
Having a single path for everything makes it a lot easier to keep crtc_state-active in sync with intel_crtc-active. A crtc cannot be changed to active when not enabled, because it means no mode is set and no connectors are connected. This should also make intel_crtc-active match

[Intel-gfx] [PATCH v3 08/22] drm/i915: Zap call to drm_plane_helper_disable.

2015-05-20 Thread Maarten Lankhorst
The primary plane can still be configured when crtc is off, furthermore this is also a noop now that affected planes are added on modesets. Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com --- drivers/gpu/drm/i915/intel_display.c | 2 -- 1 file changed, 2 deletions(-) diff

[Intel-gfx] [PATCH 0/5] SKL S3, take 2.5

2015-05-20 Thread Damien Lespiau
I fell into a well crafted trap in the previous series, breaking a resume ordering constraint for VLV/CHV. Might as well split the series in two then as we really want the SKL S3 stuff in sooner rather than later. -- Damien Damien Lespiau (5): drm/i915/bxt: Also add bxt_resume_prepare() to

[Intel-gfx] [PATCH 00/03] Preventing zero GPU virtual address allocation

2015-05-20 Thread David Weinehall
This patch series (one patch each for libdrm, the kernel, and beignet) aims to provide a means to add a context-specific means to prevent a mapping to GPU virtual address zero. This is needed at least by Beignet (possibly in other use-cases too, though I don't know of any other) to allow use of

Re: [Intel-gfx] [PATCH] drm/i915: Force clean compilation with -Werror

2015-05-20 Thread Damien Lespiau
On Wed, May 20, 2015 at 02:12:47PM +0100, Chris Wilson wrote: Our driver compiles clean (nowadays thanks to 0day) but for me, at least, it would be beneficial if the compiler threw an error rather than a warning when it found a piece of suspect code. (I use this to compile-check patch series

[Intel-gfx] [PATCH 02/03] libdrm: export context_{get, set}param and I915_CONTEXT_PARAM_NO_ZEROMAP

2015-05-20 Thread David Weinehall
Provide helper functions for the context_{get,set}param ioctls, as well as the I915_CONTEXT_PARAM_NO_ZEROMAP parameter. Signed-off-by: David Weinehall david.weineh...@intel.com --- configure.ac |2 - include/drm/i915_drm.h |1 intel/intel_bufmgr.h |4 +++

Re: [Intel-gfx] [PATCH 00/03] Preventing zero GPU virtual address allocation

2015-05-20 Thread Chris Wilson
On Wed, May 20, 2015 at 04:54:19PM +0300, David Weinehall wrote: This patch series (one patch each for libdrm, the kernel, and beignet) aims to provide a means to add a context-specific means to prevent a mapping to GPU virtual address zero. This is needed at least by Beignet (possibly in

[Intel-gfx] DP MST oops

2015-05-20 Thread Jani Nikula
Dave - My Haswell oopses when power cycling an MST enabled Dell P2415Q display. I haven't been able to get a picture on screen when either the sink or the source has MST enabled, but one thing at a time... Below is the only snippet of dmesg I've been able to squeeze out at this time, maybe it

[Intel-gfx] [PATCH 2/5] drm/i915: Add a space after ', ' and don't capitalize mid-sentence

2015-05-20 Thread Damien Lespiau
Couldn't let it go! Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/i915_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 77f9818..442dd6c 100644 ---

[Intel-gfx] [PATCH 5/5] drm/i915/skl: Deinit/init the display at suspend/resume

2015-05-20 Thread Damien Lespiau
We need to re-init the display hardware when going out of suspend. This includes: - Hooking the PCH to the reset logic - Restoring CDCDLK - Enabling the DDB power Among those, only the CDCDLK one is a bit tricky. There's some complexity in that: - DPLL0 (which is the source for CDCLK)

Re: [Intel-gfx] [PATCH] drm/i915: Fix ilk watermarks calculation when primary plane is disabled

2015-05-20 Thread Jani Nikula
On Wed, 20 May 2015, Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com wrote: On Fedora 21 or 22, when the transition from the X server to the wayland compositor is done, the CRTC with the login screen is left active with a disabled fb. A cursor ioctl after the transition

Re: [Intel-gfx] [PATCH] Documentation/drm: Update rotation property with 90/270 and description

2015-05-20 Thread Ville Syrjälä
On Wed, May 20, 2015 at 01:19:34PM +0530, Jindal, Sonika wrote: On 5/13/2015 9:57 AM, Jindal, Sonika wrote: On 5/12/2015 6:20 PM, Ville Syrjälä wrote: On Wed, Apr 15, 2015 at 04:05:19PM +0530, Sonika Jindal wrote: Cc: dri-de...@lists.freedesktop.org Signed-off-by: Sonika Jindal

[Intel-gfx] [PATCH 03/03] beignet: set I915_CONTEXT_PARAM_NO_ZEROMAP when initializing context

2015-05-20 Thread David Weinehall
Set the I915_CONTEXT_PARAM_NO_ZEROMAP context parameter to disable zero mappings if libdrm is new enough to expose such functionality. Signed-off-by: David Weinehall david.weineh...@intel.com --- CMakeLists.txt |6 ++ src/CMakeLists.txt |5 +

Re: [Intel-gfx] [PATCH 00/03] Preventing zero GPU virtual address allocation

2015-05-20 Thread Chris Wilson
On Wed, May 20, 2015 at 03:09:43PM +0100, Chris Wilson wrote: On Wed, May 20, 2015 at 04:54:19PM +0300, David Weinehall wrote: This patch series (one patch each for libdrm, the kernel, and beignet) aims to provide a means to add a context-specific means to prevent a mapping to GPU virtual

[Intel-gfx] [PATCH v3 01/22] drm/i915: get rid of put_shared_dpll

2015-05-20 Thread Maarten Lankhorst
Now that the pll updates are staged the put_shared_dpll function consists only of checks that are done in check_shared_dpll_state after a modeset too. The changes to pll-config are overwritten by intel_shared_dpll_commit, so this entire function is a noop. Signed-off-by: Maarten Lankhorst

[Intel-gfx] [PATCH v3 06/22] drm/i915: Set mode_changed for audio in intel_modeset_pipe_config()

2015-05-20 Thread Maarten Lankhorst
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com A follow up patch will make intel_modeset_compute_config() deal with multiple crtcs, so move crtc specific stuff into the lower level crtc specific function. Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com

[Intel-gfx] [PATCH v3 05/22] drm/i915: Make __intel_set_mode() take only atomic state as argument

2015-05-20 Thread Maarten Lankhorst
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com With the use of drm_atomic_helper_update_legacy_modeset_state the last user of modeset_crtc is removed from this function. Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com ---

[Intel-gfx] [PATCH v3 07/22] drm/i915: Use crtc_state-active instead of crtc_state-enable

2015-05-20 Thread Maarten Lankhorst
crtc_state-enable means a crtc is configured, but it may be turned off for dpms. Until the commit use intel_crtc_control everywhere crtc_state-active was not updated on crtc off, but now crtc_state-active should be used for tracking whether a crtc is scanning out or not. A few commits from now

[Intel-gfx] [PATCH v3 04/22] drm/i915: Use drm_atomic_helper_update_legacy_modeset_state, v2.

2015-05-20 Thread Maarten Lankhorst
Now that the helper is exported there's no need to duplicate this code any more. Changes since v1: - move intel_modeset_update_staged_output_state call to the right place. Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com --- drivers/gpu/drm/i915/intel_display.c | 61

[Intel-gfx] [PATCH v3 00/22] drm/i915: Convert to atomic, part 2.

2015-05-20 Thread Maarten Lankhorst
The goal of this patch series is to implement hardware readout using atomic state, and restore sw state with a single call to intel_set_mode. After that's done intel_crtc_control can be safely converted to atomic modeset, because nothing relies on transitional state any more. This patch series

[Intel-gfx] [PATCH v3 09/22] drm/i915: calculate primary visibility changes instead of calling from set_config

2015-05-20 Thread Maarten Lankhorst
This should be much cleaner, with the same effects. Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com --- drivers/gpu/drm/i915/intel_display.c | 46 ++-- 1 file changed, 7 insertions(+), 39 deletions(-) diff --git

[Intel-gfx] [PATCH 1/5] drm/i915/bxt: Also add bxt_resume_prepare() to the S3/S4 path

2015-05-20 Thread Damien Lespiau
Currently bxt_resume_prepare() is only used in the runtime-resume path. Add it to the full S3/S4 path as well. v2: Rebase on top of the vlv_resume_prepare() shuffling around Cc: Imre Deak imre.d...@intel.com Reviewed-by: Imre Deak imre.d...@intel.com (v1) Signed-off-by: Damien Lespiau

[Intel-gfx] [PATCH 3/5] drm/i915: Kill the dev variable in intel_suspend_complete()

2015-05-20 Thread Damien Lespiau
The macros we use there are the magic ones that can take either dev or dev_priv. We'd like to move as much as possible towards dev_priv though. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/i915_drv.c | 9 - 1 file changed, 4 insertions(+), 5

[Intel-gfx] [PATCH 4/5] drm/i915: Store boot CDCLK in dev_priv on DDI platforms

2015-05-20 Thread Damien Lespiau
Right not we don't initialize the stored CDCLK on DDI platforms. Fix that. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/intel_ddi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ddi.c

[Intel-gfx] [PATCH 01/03] drm/i915: add a context parameter to {en, dis}able zero address mapping

2015-05-20 Thread David Weinehall
Export a new context parameter that can be set/queried through the context_{get,set}param ioctls. This parameter is passed as a context flag and decides whether or not a GPU address mapping is allowed to be made at address zero. The default is to allow such mappings. Signed-off-by: David

Re: [Intel-gfx] [PATCH] drm/i915: Fix ilk watermarks calculation when primary plane is disabled

2015-05-20 Thread Josh Boyer
On Wed, May 20, 2015 at 9:53 AM, Jani Nikula jani.nik...@intel.com wrote: On Wed, 20 May 2015, Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com wrote: On Fedora 21 or 22, when the transition from the X server to the wayland compositor is done, the CRTC with the login screen

Re: [Intel-gfx] still experiencing oops connecting Laptop to docking Station

2015-05-20 Thread Daniel Vetter
On Wed, May 20, 2015 at 5:05 PM, Nicolas Kalkhof nkalk...@web.de wrote: Hallo, I'm still getting oops with drm-intel-nightly when I try to connect my Laptop to its docking station or when I boot up and the Laptop is already connected. kdump doesn't seem to work with current

[Intel-gfx] [PATCH v3 11/22] drm/i915: Use global atomic state for staged pll config, v2.

2015-05-20 Thread maarten . lankhorst
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com Now that we can subclass drm_atomic_state we can also use it to keep track of all the pll settings. atomic_state is a better place to hold all shared state than keeping pll-new_config everywhere. Changes since v1: - Assert

[Intel-gfx] [PATCH v3 22/22] drm/i915: use calculated state for vblank evasion

2015-05-20 Thread maarten . lankhorst
From: Maarten Lankhorst maarten.lankho...@linux.intel.com crtc-active will be gone eventually, and this check should be just as good. Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com --- drivers/gpu/drm/i915/intel_display.c | 3 ++- 1 file changed, 2 insertions(+), 1

[Intel-gfx] [PATCH v3 13/22] drm/i915: Swap planes on each crtc separately.

2015-05-20 Thread maarten . lankhorst
From: Maarten Lankhorst maarten.lankho...@linux.intel.com Repeated calls to begin_crtc_commit can cause warnings like this: [ 169.127746] BUG: sleeping function called from invalid context at kernel/locking/mutex.c:616 [ 169.127835] in_atomic(): 0, irqs_disabled(): 1, pid: 1947, name: kms_flip

[Intel-gfx] [PATCH v3 10/22] drm/i915: Support modeset across multiple pipes

2015-05-20 Thread maarten . lankhorst
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com Compute new pipe_configs for all crtcs in the atomic state. The commit part of the mode set (__intel_set_mode()) is already enabled to support multiple pipes, the only thing missing was calculating a new pipe_config for every

[Intel-gfx] [PATCH v3 18/22] drm/i915: Use crtc-hwmode for vblanks, v2.

2015-05-20 Thread maarten . lankhorst
From: Maarten Lankhorst maarten.lankho...@linux.intel.com intel_crtc-config will be removed eventually, so use crtc-hwmode. drm_atomic_helper_update_legacy_modeset_state updates hwmode, but crtc-active will eventually be gone too. Set dotclock to zero to indicate the crtc is inactive. Changes

[Intel-gfx] [PATCH v3 17/22] drm/i915: move swap state to the right place

2015-05-20 Thread maarten . lankhorst
From: Maarten Lankhorst maarten.lankho...@linux.intel.com This is a preparation for passing crtc state to the helpers. When converting all users of crtc-config to use the old or new state it's easier to find regressions when swap_state is done first. If crtc-config is swapped at the same place

[Intel-gfx] [PATCH v3 19/22] drm/i915: Remove use of crtc-config from i915_debugfs.c

2015-05-20 Thread maarten . lankhorst
From: Maarten Lankhorst maarten.lankho...@linux.intel.com crtc-config is updated to always contain to the active crtc_state and only differs from crtc_state during crtc_disable. It will eventually be removed, so start with some low hanging fruit. For crtc-active the situation is the same; it

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Simple IPS pixel_rate x 0.95 cdclk restriction

2015-05-20 Thread Ville Syrjälä
On Wed, May 20, 2015 at 09:42:57AM -0700, Rodrigo Vivi wrote: Broadwell Workaround : Do not enable IPS when the pipe pixel rate is greater than 95% of the CDCLK frequency. The pipe pixel rate is the port pixel rate multiplied by the pipe scaler down scale amount. Or just merge my patch doing

[Intel-gfx] [PATCH v3 21/22] drm/i915: Use atomic state for calculating DVO_2X_MODE on i830.

2015-05-20 Thread maarten . lankhorst
From: Maarten Lankhorst maarten.lankho...@linux.intel.com This is a small behavioral change because it leaves DVO_2X_MODE set between crtc_disable and crtc_enable. This is probably harmless though and if not should be fixed by calculating 2x mode before enable/disable pll. This is needed because

[Intel-gfx] [PATCH v3 12/22] drm/i915: Use drm_atomic_helper_swap_state in intel_atomic_commit.

2015-05-20 Thread maarten . lankhorst
From: Maarten Lankhorst maarten.lankho...@linux.intel.com And update crtc-config to point to the new state. There is no point in swapping only part of the state when the rest of the state should be untouched. Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com ---

[Intel-gfx] [PATCH v3 14/22] drm/i915: Move cdclk and pll setup to intel_modeset_compute_config()

2015-05-20 Thread maarten . lankhorst
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com It makes more sense there, since these are computation steps that can fail. Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com --- drivers/gpu/drm/i915/intel_display.c | 70

[Intel-gfx] [PATCH v3 15/22] drm/i915: Read hw state into an atomic state struct

2015-05-20 Thread maarten . lankhorst
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com To make this work we load the new hardware state into the atomic_state, then swap it with the sw state. This lets us change the force restore path in setup_hw_state() to use a single call to intel_mode_set() to restore all

[Intel-gfx] [PATCH v3 20/22] drm/i915: Calculate haswell plane workaround, v3.

2015-05-20 Thread maarten . lankhorst
From: Maarten Lankhorst maarten.lankho...@linux.intel.com This needs to be a global check because at the time of crtc checking not all modesets have to be calculated yet. Use intel_crtc-atomic because there's no reason to keep it in state. Changes since v1: - Use intel_crtc-atomic as a place to

[Intel-gfx] [PATCH v3 16/22] drm/i915: Implement intel_crtc_control using atomic state, v3

2015-05-20 Thread maarten . lankhorst
From: Maarten Lankhorst maarten.lankho...@linux.intel.com Assume the callers lock everything with drm_modeset_lock_all. This change had to be done after converting suspend/resume to use atomic_state so the atomic state is preserved, otherwise all transitional state is erased. Now all callers of

Re: [Intel-gfx] [PATCH] drm/plane-helper: Adapt cursor hack to transitional helpers

2015-05-20 Thread Pekka Paalanen
On Wed, 20 May 2015 10:36:32 +0200 Daniel Vetter daniel.vet...@ffwll.ch wrote: In commit f02ad907cd9e7fe3a6405d2d005840912f1ed258 Author: Daniel Vetter daniel.vet...@ffwll.ch Date: Thu Jan 22 16:36:23 2015 +0100 drm/atomic-helpers: Recover full cursor plane behaviour we've added

Re: [Intel-gfx] still experiencing oops connecting Laptop to docking Station

2015-05-20 Thread Nicolas Kalkhof
Hi Daniel, ok here is the first oops showing up on the screen. Image is not too good though. http://imgur.com/O0kutIE Btw. did you take a look at the stacktrace I've posted below complaining about complaining about pipe state doesn't match? Regards Nic Gesendet: Mittwoch, 20. Mai 2015 um

Re: [Intel-gfx] still experiencing oops connecting Laptop to docking Station

2015-05-20 Thread Daniel Vetter
On Wed, May 20, 2015 at 6:00 PM, Nicolas Kalkhof nkalk...@web.de wrote: Hi Daniel, ok here is the first oops showing up on the screen. Image is not too good though. http://imgur.com/O0kutIE Btw. did you take a look at the stacktrace I've posted below complaining about complaining about

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Store boot CDCLK in dev_priv on DDI platforms

2015-05-20 Thread Daniel Vetter
On Wed, May 20, 2015 at 05:53:42PM +0200, Daniel Vetter wrote: On Wed, May 20, 2015 at 02:45:17PM +0100, Damien Lespiau wrote: Right not we don't initialize the stored CDCLK on DDI platforms. Fix that. Signed-off-by: Damien Lespiau damien.lesp...@intel.com Merged up to this patch,

[Intel-gfx] [PATCH] drm/i915/bdw: Simple IPS pixel_rate x 0.95 cdclk restriction

2015-05-20 Thread Rodrigo Vivi
Broadwell Workaround : Do not enable IPS when the pipe pixel rate is greater than 95% of the CDCLK frequency. The pipe pixel rate is the port pixel rate multiplied by the pipe scaler down scale amount. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com --- drivers/gpu/drm/i915/intel_display.c |

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Store boot CDCLK in dev_priv on DDI platforms

2015-05-20 Thread Daniel Vetter
On Wed, May 20, 2015 at 02:45:17PM +0100, Damien Lespiau wrote: Right not we don't initialize the stored CDCLK on DDI platforms. Fix that. Signed-off-by: Damien Lespiau damien.lesp...@intel.com Merged up to this patch, thanks, Daniel --- drivers/gpu/drm/i915/intel_ddi.c | 4 ++-- 1 file

Re: [Intel-gfx] [PATCH 00/03] Preventing zero GPU virtual address allocation

2015-05-20 Thread Daniel Vetter
On Wed, May 20, 2015 at 03:14:06PM +0100, Chris Wilson wrote: On Wed, May 20, 2015 at 03:09:43PM +0100, Chris Wilson wrote: On Wed, May 20, 2015 at 04:54:19PM +0300, David Weinehall wrote: This patch series (one patch each for libdrm, the kernel, and beignet) aims to provide a means to

Re: [Intel-gfx] [PATCH 00/03] Preventing zero GPU virtual address allocation

2015-05-20 Thread Chris Wilson
On Wed, May 20, 2015 at 06:00:43PM +0200, Daniel Vetter wrote: On Wed, May 20, 2015 at 03:14:06PM +0100, Chris Wilson wrote: On Wed, May 20, 2015 at 03:09:43PM +0100, Chris Wilson wrote: On Wed, May 20, 2015 at 04:54:19PM +0300, David Weinehall wrote: This patch series (one patch each

Re: [Intel-gfx] still experiencing oops connecting Laptop to docking Station

2015-05-20 Thread Nicolas Kalkhof
Two things: - Can you please boot with drm.debug=0xff and enable full debug output to the console with dmesg -n debug and try to recapture? I'd like to know what exactly happened right before. There should be lots of debug output right before the oops. There ya go. dmesg with drm.debug=0xff

Re: [Intel-gfx] [RFC 09/12] drm/i915/config: Add VBT settings configuration.

2015-05-20 Thread Bob Paauwe
On Fri, 15 May 2015 12:39:20 +0300 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Tue, Feb 24, 2015 at 09:52:16PM +0100, Daniel Vetter wrote: On Tue, Feb 24, 2015 at 10:37:10AM -0800, Bob Paauwe wrote: On Tue, 24 Feb 2015 14:57:48 +0100 Daniel Vetter dan...@ffwll.ch wrote: As

Re: [Intel-gfx] still experiencing oops connecting Laptop to docking Station

2015-05-20 Thread Chris Wilson
On Wed, May 20, 2015 at 06:39:26PM +0200, Daniel Vetter wrote: On Wed, May 20, 2015 at 6:00 PM, Nicolas Kalkhof nkalk...@web.de wrote: Hi Daniel, ok here is the first oops showing up on the screen. Image is not too good though. http://imgur.com/O0kutIE Btw. did you take a look at the

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Simple IPS pixel_rate x 0.95 cdclk restriction

2015-05-20 Thread Ville Syrjälä
On Wed, May 20, 2015 at 08:38:25PM +, Vivi, Rodrigo wrote: On Wed, 2015-05-20 at 20:26 +0300, Ville Syrjälä wrote: On Wed, May 20, 2015 at 09:42:57AM -0700, Rodrigo Vivi wrote: Broadwell Workaround : Do not enable IPS when the pipe pixel rate is greater than 95% of the CDCLK

Re: [Intel-gfx] [PATCH 1/2] i965/gen9: Pass alignment as function parameter in drm_intel_gem_bo_alloc_internal()

2015-05-20 Thread Anuj Phogat
On Fri, Apr 10, 2015 at 5:20 PM, Anuj Phogat anuj.pho...@gmail.com wrote: and use it to initialize the align variable in drm_intel_bo. In case of YF/YS tiled buffers libdrm need not know about the tiling format because these buffers don't have hardware support to be tiled or detiled through a

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't enable IPS when pixel rate exceeds 95% of cdclk

2015-05-20 Thread Rodrigo Vivi
I'm convinced Unclaimed regs Paulo saw came from somewhere else since I just got it with pm_rpm rte with no patch applied So I'd suggest to merge this patch... Although it also doesn't fix the flicker I see here so the bug would still be open... Anyway, Reviewed-by: Rodrigo Vivi

Re: [Intel-gfx] [PATCH 2/2] Set alignment value in drm_intel_add_validate_buffer()

2015-05-20 Thread Anuj Phogat
On Fri, Apr 10, 2015 at 5:20 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- intel/intel_bufmgr_gem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c index

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Simple IPS pixel_rate x 0.95 cdclk restriction

2015-05-20 Thread Vivi, Rodrigo
On Wed, 2015-05-20 at 20:26 +0300, Ville Syrjälä wrote: On Wed, May 20, 2015 at 09:42:57AM -0700, Rodrigo Vivi wrote: Broadwell Workaround : Do not enable IPS when the pipe pixel rate is greater than 95% of the CDCLK frequency. The pipe pixel rate is the port pixel rate multiplied by the

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't enable IPS when pixel rate exceeds 95% of cdclk

2015-05-20 Thread Paulo Zanoni
2015-05-20 17:40 GMT-03:00 Rodrigo Vivi rodrigo.v...@gmail.com: I'm convinced Unclaimed regs Paulo saw came from somewhere else since I just got it with pm_rpm rte with no patch applied So I'd suggest to merge this patch... Although it also doesn't fix the flicker I see here so the bug

Re: [Intel-gfx] [PATCH] drm/i915/hsw: Fix workaround for server AUX channel clock divisor

2015-05-20 Thread Todd Previte
Hi Jim, I checked the BSpec as well and there's nothing indicating that these two bits are mutually exclusive. They are both sticky though, and if the loop times out 5 times, both _DONE and _TIMEOUT may very well be set. In that case the current code would just exit and never bother to change

[Intel-gfx] [PATCH] drm/edid: Fix DDC probe for passive DP dongles

2015-05-20 Thread Todd Previte
Passive DP-DVI/HDMI dongles show up to the system as HDMI devices, as they do not have a sink device in them to respond to any AUX traffic. When probing these dongles over the DDC, sometimes they will NAK the first attempt even though the transaction is valid and they support the DDC protocol. The

Re: [Intel-gfx] [RFC PATCH 00/11] drm/i915: Expose OA metrics via perf PMU

2015-05-20 Thread Robert Bragg
On Tue, May 19, 2015 at 3:53 PM, Peter Zijlstra pet...@infradead.org wrote: On Fri, May 15, 2015 at 02:07:29AM +0100, Robert Bragg wrote: On Fri, May 8, 2015 at 5:24 PM, Peter Zijlstra pet...@infradead.org wrote: On Thu, May 07, 2015 at 03:15:43PM +0100, Robert Bragg wrote: I've changed

Re: [Intel-gfx] [PATCH 08/12] drm/i915: Add NV12 support to intel_framebuffer_init

2015-05-20 Thread Konduru, Chandra
-Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Wednesday, May 20, 2015 12:37 AM To: Konduru, Chandra Cc: Daniel Vetter; intel-gfx@lists.freedesktop.org; Vetter, Daniel; Syrjala, Ville Subject: Re: [Intel-gfx] [PATCH 08/12]

[Intel-gfx] [RFC 07/15] drm/i915: Eliminate usage of pipe_wm_parameters from ILK-style WM

2015-05-20 Thread Matt Roper
Just pull the info out of the CRTC state structure rather than staging it in an additional structure. Signed-off-by: Matt Roper matthew.d.ro...@intel.com --- drivers/gpu/drm/i915/intel_pm.c | 98 ++--- 1 file changed, 34 insertions(+), 64 deletions(-) diff

[Intel-gfx] [RFC 03/15] drm/i915: Update sprite watermarks outside vblank evasion

2015-05-20 Thread Matt Roper
We never removed the sprite watermark updates from our low-level foo_update_plane() functions; since our hardware updates happen under vblank evasion, we're not supposed to be calling potentially sleeping functions there (since interrupts are disabled). Ensure that we properly set the

[Intel-gfx] [RFC 13/15] drm/i915: Introduce intel_schedule_vblank_job()

2015-05-20 Thread Matt Roper
Various places in the driver need the ability to schedule actions to run on a future vblank (updating watermarks, unpinning buffers, etc.). The long term goal is to add such a mechanism in the DRM core that can be shared by all drivers. Paulo Zanoni has already written some preliminary patches

  1   2   >