Re: [Intel-gfx] [PATCH 02/21] drm/i915/gtt: Workaround for HW preload not flushing pdps

2015-08-10 Thread Zhiyuan Lv
Hi Mika/Dave/Michel, I saw the patch of using LRI for root pointer update has been merged to drm-intel. When we consider i915 driver to run inside a virtual machine, e.g. with XenGT, we may still need Mika's this patch like below: if (intel_vgpu_active(ppgtt-base.dev))

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Enable querying offset of UV plane with intel_plane_obj_offset

2015-08-10 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6929 -Summary- Platform Delta drm-intel-nightly Series Applied ILK -1

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915: Add audio set_ncts callback

2015-08-10 Thread Yang, Libin
-Original Message- From: Yang, Libin Sent: Tuesday, August 11, 2015 10:41 AM To: 'Jani Nikula'; alsa-de...@alsa-project.org; ti...@suse.de; intel- g...@lists.freedesktop.org; daniel.vet...@ffwll.ch Subject: RE: [Intel-gfx] [PATCH v2 1/4] drm/i915: Add audio set_ncts callback Hi

Re: [Intel-gfx] [PATCH 2/2] drm/doc: Update docs about device instance setup

2015-08-10 Thread Daniel Vetter
On Mon, Aug 10, 2015 at 02:34:18PM +0200, Thierry Reding wrote: On Mon, Aug 10, 2015 at 02:07:49PM +0200, Daniel Vetter wrote: On Mon, Aug 10, 2015 at 01:59:07PM +0200, Thierry Reding wrote: On Mon, Aug 10, 2015 at 11:55:38AM +0200, Daniel Vetter wrote: -load is depracated, bus

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Implement WaPixelRepeatModeFixForC0:chv

2015-08-10 Thread Ville Syrjälä
On Mon, Jul 13, 2015 at 11:44:44AM +0530, Sivakumar Thulasimani wrote: On 6/29/2015 5:55 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com DPLL_MD(PIPE_C) is AWOL on CHV. Instead of fixing it someone added chicken bits to propagate the pixel

Re: [Intel-gfx] [PATCH] drm/i915: Remove the failed context from the fpriv-context_idr

2015-08-10 Thread Mika Kuoppala
Chris Wilson ch...@chris-wilson.co.uk writes: If we encounter an allocation failure during ppggt creation (trivial even with 16Gib+ RAM!), we need to remove the dead context from the fpriv-context_idr along with the references. gem_exec_ctx: page allocation failure: order:0, mode:0x8004

Re: [Intel-gfx] [PATCH] drm/i915: Postpone plane readout until after encoder readout

2015-08-10 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6911 -Summary- Platform Delta drm-intel-nightly Series Applied ILK -1

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Adding intel_panel_scale_none() helper function

2015-08-10 Thread Rodrigo Vivi
I believe this function could be added along with the next patch that is the first to use it... Or it would be good to have a good commit message explaining why this function is needed and what is be used for... more bikeshedings inline: On Mon, Aug 10, 2015 at 12:39 AM Xiong Zhang

[Intel-gfx] [PATCH] drm/i915: fix stolen bios_reserved checks

2015-08-10 Thread Paulo Zanoni
I started digging this when I noticed that the BDW code was just reserving 1mb by coincidence since it was reading reserved fields. Then I noticed we didn't have any values set for SNB and earlier, and that the HSW sizes were wrong. After that, I noticed that the reserved area has a specific

Re: [Intel-gfx] [PATCH] drm/i915: fix stolen bios_reserved checks

2015-08-10 Thread Chris Wilson
On Mon, Aug 10, 2015 at 02:57:32PM -0300, Paulo Zanoni wrote: I started digging this when I noticed that the BDW code was just reserving 1mb by coincidence since it was reading reserved fields. Then I noticed we didn't have any values set for SNB and earlier, and that the HSW sizes were wrong.

[Intel-gfx] [PATCH] drm/i915: Treat foreign dma-buf imports as uncached

2015-08-10 Thread Chris Wilson
If the set of pages is being imported from another device, we cannot assume that it is fully coherent with the CPU cache, so mark it as such. However, if the source is the shared memory vgem allocator, we could treat the buffer as being cached (so long as all parties agree in the case the same

Re: [Intel-gfx] [PATCH] drm/i915/gen9: Update null batch to follow VF state restriction

2015-08-10 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6912 -Summary- Platform Delta drm-intel-nightly Series Applied ILK -1

Re: [Intel-gfx] [PATCH mesa v3] i965/gen8+: bo in state base address must be in 32-bit address range

2015-08-10 Thread Kristian Høgsberg
On Mon, Aug 10, 2015 at 2:21 AM, Michel Thierry michel.thie...@intel.com wrote: Hi, Thanks for the comments, On 8/7/2015 11:46 PM, Kristian Høgsberg wrote: On Fri, Aug 7, 2015 at 2:45 AM, Michel Thierry michel.thie...@intel.com wrote: Gen8+ supports 48-bit virtual addresses, but some

Re: [Intel-gfx] [PATCH v4 4/4] drm/i915: set proper N/CTS in modeset

2015-08-10 Thread Yang, Libin
Hi Jani, Thanks for careful reviewing for all the patches, please see my comments. -Original Message- From: Jani Nikula [mailto:jani.nik...@linux.intel.com] Sent: Monday, August 10, 2015 8:10 PM To: Yang, Libin; alsa-de...@alsa-project.org; ti...@suse.de; intel-

Re: [Intel-gfx] [PATCH] drm/i915: Update HAS_PSR macro to include all gen=8 platforms

2015-08-10 Thread Jindal, Sonika
I replied to Daniel last time. Pasting it on mailing list as well: Yes this is tested on android with HW tracking. Not sure about enabling by default part. But this patch will be anyways required. Regards, Sonika -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On

Re: [Intel-gfx] [PATCH] drm/i915/vlv: Add RPS debugfs disabling for vlv/chv

2015-08-10 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6923 -Summary- Platform Delta drm-intel-nightly Series Applied ILK -2

Re: [Intel-gfx] [alsa-devel] [PATCH 3/4] ALSA: hda - display audio call ncts callback

2015-08-10 Thread Yang, Libin
Hi Raymond, From: Raymond Yau [mailto:superquad.vort...@gmail.com] Sent: Monday, August 10, 2015 12:23 PM To: Yang, Libin Cc: alsa-de...@alsa-project.org; Takashi Iwai; Lin, Mengdong; intel-gfx@lists.freedesktop.org Subject: RE: [alsa-devel] [PATCH 3/4] ALSA: hda - display audio call ncts

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915: Add audio set_ncts callback

2015-08-10 Thread Yang, Libin
Hi Jani, Thanks for reviewing, please see my comments -Original Message- From: Jani Nikula [mailto:jani.nik...@linux.intel.com] Sent: Monday, August 10, 2015 7:46 PM To: Yang, Libin; alsa-de...@alsa-project.org; ti...@suse.de; intel- g...@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: implement set_ncts callback

2015-08-10 Thread Yang, Libin
Hi Jani, -Original Message- From: Jani Nikula [mailto:jani.nik...@linux.intel.com] Sent: Monday, August 10, 2015 8:00 PM To: Yang, Libin; alsa-de...@alsa-project.org; ti...@suse.de; intel- g...@lists.freedesktop.org; daniel.vet...@ffwll.ch Subject: Re: [Intel-gfx] [PATCH v2 2/4]

Re: [Intel-gfx] [PATCH v3 3/4] ALSA: hda - display audio call ncts callback

2015-08-10 Thread Yang, Libin
Hi Jani, -Original Message- From: Jani Nikula [mailto:jani.nik...@linux.intel.com] Sent: Monday, August 10, 2015 8:03 PM To: Yang, Libin; alsa-de...@alsa-project.org; ti...@suse.de; intel- g...@lists.freedesktop.org; daniel.vet...@ffwll.ch Subject: Re: [Intel-gfx] [PATCH v3 3/4]

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: implement set_ncts callback

2015-08-10 Thread Yang, Libin
Hi Jani, -Original Message- From: Jani Nikula [mailto:jani.nik...@linux.intel.com] Sent: Monday, August 10, 2015 8:17 PM To: Yang, Libin; alsa-de...@alsa-project.org; ti...@suse.de; intel- g...@lists.freedesktop.org; daniel.vet...@ffwll.ch Subject: Re: [Intel-gfx] [PATCH v2 2/4]

Re: [Intel-gfx] [PATCH 2/2] drm/doc: Update docs about device instance setup

2015-08-10 Thread Thierry Reding
On Mon, Aug 10, 2015 at 02:07:49PM +0200, Daniel Vetter wrote: On Mon, Aug 10, 2015 at 01:59:07PM +0200, Thierry Reding wrote: On Mon, Aug 10, 2015 at 11:55:38AM +0200, Daniel Vetter wrote: -load is depracated, bus functionst are deprecated and everyone should use drm_dev_allocregister.

Re: [Intel-gfx] [PATCH] drm/i915: Spam less on dp aux send/receive problems

2015-08-10 Thread Jani Nikula
On Thu, 06 Aug 2015, Mika Kuoppala mika.kuopp...@linux.intel.com wrote: If we encounter frequent problems with dp aux channel communications, we end up spamming the dmesg with the exact similar trace and status. Inject a new backtrace only if we have new information to share as otherwise we

Re: [Intel-gfx] [PATCH v4 4/4] drm/i915: set proper N/CTS in modeset

2015-08-10 Thread Yang, Libin
-Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Monday, August 10, 2015 4:04 PM To: Yang, Libin Cc: alsa-de...@alsa-project.org; intel-gfx@lists.freedesktop.org; daniel.vet...@ffwll.ch Subject: Re: [PATCH v4 4/4] drm/i915: set proper N/CTS in modeset On Mon,

[Intel-gfx] [PATCH v3 2/3] drm/i915: Fix userptr deadlock with aliased GTT mmappings

2015-08-10 Thread Chris Wilson
Michał Winiarski found a really evil way to trigger a struct_mutex deadlock with userptr. He found that if he allocated a userptr bo and then GTT mmaped another bo, or even itself, at the same address as the userptr using MAP_FIXED, he could then cause a deadlock any time we then had to invalidate

[Intel-gfx] [PATCH v3 1/3] drm/i915: Only update the current userptr worker

2015-08-10 Thread Chris Wilson
The userptr worker allows for a slight race condition where upon there may two or more threads calling get_user_pages for the same object. When we have the array of pages, then we serialise the update of the object. However, the worker should only overwrite the obj-userptr.work pointer if and only

Re: [Intel-gfx] [alsa-devel] DP MST audio support

2015-08-10 Thread Yang, Libin
Hi Dave, Sorry for interrupt. I'm currently testing the MST audio with HSW. Could you please help tell how I can say DP1.2 works? I connect a DP1.2 monitor to HSW and a DP1.1 monitor to DP1.2 monitor output. In this mode, can I make the 2 monitors show different contents? Thanks. Regards,

Re: [Intel-gfx] [PATCH mesa v3] i965/gen8+: bo in state base address must be in 32-bit address range

2015-08-10 Thread Michel Thierry
Hi, Thanks for the comments, On 8/7/2015 11:46 PM, Kristian Høgsberg wrote: On Fri, Aug 7, 2015 at 2:45 AM, Michel Thierry michel.thie...@intel.com wrote: Gen8+ supports 48-bit virtual addresses, but some objects must always be allocated inside the 32-bit address range. In specific, any

Re: [Intel-gfx] [PATCH] drm/i915:gen9: Add WA for disable gather at set shader bit

2015-08-10 Thread Siluvery, Arun
On 08/08/2015 06:35, Ben Widawsky wrote: On Fri, Aug 07, 2015 at 06:33:37PM +0100, Arun Siluvery wrote: This WA doesn't have a name. According to the spec, driver need to reset disable gather at set shader bit in per ctx WA batch. It is to be noted that the default value is already '0' for this

Re: [Intel-gfx] [PATCH v4 4/4] drm/i915: set proper N/CTS in modeset

2015-08-10 Thread Takashi Iwai
On Mon, 10 Aug 2015 09:32:11 +0200, libin.y...@intel.com wrote: From: Libin Yang libin.y...@intel.com When modeset occurs and the TMDS frequency is set to some speical value, the N/CTS need to be set manually if audio is playing. Signed-off-by: Libin Yang libin.y...@intel.com ---

Re: [Intel-gfx] [PATCH i-g-t] Revert tests/gem_ctx_param_basic: fix invalid params

2015-08-10 Thread David Weinehall
On Fri, Aug 07, 2015 at 10:04:47AM -0300, Paulo Zanoni wrote: 2015-08-06 18:33 GMT-03:00 Daniel Vetter daniel.vet...@ffwll.ch: This reverts commit 0b45b0746f45deea11670a8b2c949776bbbef55c. The point of testing for LAST_FLAG + 1 is to catch abi extensions - despite our best efforts we

Re: [Intel-gfx] [PATCH 0/3] HDMI optimization series

2015-08-10 Thread Daniel Vetter
On Mon, Aug 10, 2015 at 04:50:37AM +, Jindal, Sonika wrote: Hi Daniel, That patch was already merged: http://lists.freedesktop.org/archives/intel-gfx/2015-July/071142.html For SKL, the above patch helped in getting the correct ISR bits set. One option is to enable the HDMI

Re: [Intel-gfx] [PATCH 0/3] HDMI optimization series

2015-08-10 Thread Jindal, Sonika
On 8/10/2015 1:38 PM, Daniel Vetter wrote: On Mon, Aug 10, 2015 at 04:50:37AM +, Jindal, Sonika wrote: Hi Daniel, That patch was already merged: http://lists.freedesktop.org/archives/intel-gfx/2015-July/071142.html For SKL, the above patch helped in getting the correct ISR bits set. One

[Intel-gfx] [PATCH 1/2] drm/edid: Use ARRAY_SIZE in drm_add_modes_noedid

2015-08-10 Thread Daniel Vetter
Spotted while reading code for random reasons. Signed-off-by: Daniel Vetter daniel.vet...@intel.com --- drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 4a403eb90ded..4780b1924bef 100644

[Intel-gfx] [PATCH 2/2] drm/doc: Update docs about device instance setup

2015-08-10 Thread Daniel Vetter
-load is depracated, bus functionst are deprecated and everyone should use drm_dev_allocregister. So update the .tmpl (and pull a bunch of the overview docs into the sourcecode to increase chances that it'll stay in sync in the future) and add notes to functions which are deprecated. I didn't

[Intel-gfx] [PATCH 5/6 v2] drm/i915/skl: enable DDI-E hotplug

2015-08-10 Thread Xiong Zhang
v2: fix one error found by checkpath.pl Signed-off-by: Xiong Zhang xiong.y.zh...@intel.com Reviewed-by: Rodrigo Vivi rodrigo.v...@intel.com --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_irq.c | 48 +---

Re: [Intel-gfx] [PATCH] drm/i915: Retry port as HDMI if dp_is_edp turns out to be false

2015-08-10 Thread Sivakumar Thulasimani
hi Mengdong, is there any reason why you cannot modify VBT ? unless it is shipped version you can just flash the modified VBT along with BIOS. Chris, i would be even more surprised if VBIOS/GOP can enable some display when it is configured incorrectly in VBT. Give me a day to check

[Intel-gfx] [PATCH v2 1/4] drm/i915: Add audio set_ncts callback

2015-08-10 Thread libin . yang
From: Libin Yang libin.y...@intel.com Add the set_ncts callback. With the callback, audio driver can trigger i915 driver to set the proper N/CTS based on different sample rates. Signed-off-by: Libin Yang libin.y...@intel.com --- include/drm/i915_component.h | 2 ++ 1 file changed, 2

[Intel-gfx] [PATCH v4 4/4] drm/i915: set proper N/CTS in modeset

2015-08-10 Thread libin . yang
From: Libin Yang libin.y...@intel.com When modeset occurs and the TMDS frequency is set to some speical value, the N/CTS need to be set manually if audio is playing. Signed-off-by: Libin Yang libin.y...@intel.com --- drivers/gpu/drm/i915/i915_reg.h| 6 ++

Re: [Intel-gfx] [PATCH libdrm v3 1/2] intel: Add EXEC_OBJECT_SUPPORTS_48B_ADDRESS flag

2015-08-10 Thread Winiarski, Michal
On Fri, 2015-08-07 at 12:36 +0100, Michel Thierry wrote: Hi Michał, Ben suggested having the set/clear in emit reloc as this is the only place mesa cares about these wa. But I see your point, this will be used not only by mesa, so we should have something that is good for all the

Re: [Intel-gfx] [PATCH] drm/i915: Clean up lrc context init

2015-08-10 Thread Nick Hoath
On 07/08/2015 11:13, Chris Wilson wrote: On Fri, Aug 07, 2015 at 11:05:24AM +0100, Nick Hoath wrote: Clean up lrc context init by: - Move context initialisation in to i915_gem_init_hw - Move one off initialisation for render ring to i915_gem_validate_context - Move default

[Intel-gfx] [PATCH 2/4] drm/i915: Adding Panel Filter function for DP

2015-08-10 Thread Xiong Zhang
Only internal eDP, LVDS, DVI screen could set scalling mode, some customers need to set scalling mode for external DP, HDMI, VGA screen. Let's fulfill this. bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90989 Signed-off-by: Xiong Zhang xiong.y.zh...@intel.com ---

[Intel-gfx] [PATCH 4/4] drm/i915: Adding panel filter for VGA

2015-08-10 Thread Xiong Zhang
Signed-off-by: Xiong Zhang xiong.y.zh...@intel.com --- drivers/gpu/drm/i915/intel_crt.c | 81 ++-- 1 file changed, 77 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c index 521af2c..f8eedfc 100644

[Intel-gfx] [PATCH 3/4] drm/i915: Adding panel filter for HDMI

2015-08-10 Thread Xiong Zhang
Signed-off-by: Xiong Zhang xiong.y.zh...@intel.com --- drivers/gpu/drm/i915/intel_drv.h | 2 + drivers/gpu/drm/i915/intel_hdmi.c | 79 --- 2 files changed, 76 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_drv.h

[Intel-gfx] [PATCH 1/4] drm/i915: Adding intel_panel_scale_none() helper function

2015-08-10 Thread Xiong Zhang
From: dell dell@localhost.localdomain Signed-off-by: Xiong Zhang xiong.y.zh...@intel.com --- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_panel.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_drv.h

[Intel-gfx] [PATCH v2 2/4] drm/i915: implement set_ncts callback

2015-08-10 Thread libin . yang
From: Libin Yang libin.y...@intel.com Display audio may not work at some frequencies with the HW provided N/CTS. This patch sets the proper N value for the given audio sample rate at the impacted frequencies. At other frequencies, it will use the N/CTS value which HW provides. Signed-off-by:

[Intel-gfx] [PATCH v3 3/4] ALSA: hda - display audio call ncts callback

2015-08-10 Thread libin . yang
From: Libin Yang libin.y...@intel.com On some Intel platforms, display audio need set N/CTS manually at some TMDS frequencies. Signed-off-by: Libin Yang libin.y...@intel.com --- sound/pci/hda/patch_hdmi.c | 23 +++ 1 file changed, 23 insertions(+) diff --git

[Intel-gfx] [PATCH 6/6 v2] drm/i915: Enable HDMI on DDI-E

2015-08-10 Thread Xiong Zhang
DDI-E doesn't have the correspondent GMBUS pin. We rely on VBT to tell us which one it being used instead. The DVI/HDMI on shared port couldn't exist. This patch isn't tested without hardware wchich has HDMI on DDI-E. v2: fix trailing whitespace Signed-off-by: Xiong Zhang

[Intel-gfx] [PATCH 1/4] drm/i915: Adding intel_panel_scale_none() helper function

2015-08-10 Thread Xiong Zhang
Signed-off-by: Xiong Zhang xiong.y.zh...@intel.com --- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_panel.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index 47cef0e..f57a0b4 100644

Re: [Intel-gfx] [PATCH 02/18] drm/cma-helper: Fix locking in drm_fb_cma_debugfs_show

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:34PM +0200, Daniel Vetter wrote: This function takes two locks, both of them the wrong ones. This wasn't an oversight from my fb locking rework since both patches landed in parallel. We really only need fb_lock when walking that list, since everything we can reach

Re: [Intel-gfx] [PATCH 03/18] drm/gem: Be more friendly with locking checks

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:35PM +0200, Daniel Vetter wrote: BUG_ON kills the driver, WARN_ON is much friendly. And usually nothing bad happens when the locking is lightly busted. s/much friendly/much friendlier/, s/lightly/slightly/? Otherwise: Reviewed-by: Thierry Reding

Re: [Intel-gfx] [PATCH] drm/i915: Retry port as HDMI if dp_is_edp turns out to be false

2015-08-10 Thread Chris Wilson
On Mon, Aug 10, 2015 at 04:05:31PM +0530, Sivakumar Thulasimani wrote: Chris, After asking few people found that the simplest explanation and plausible root cause being that PORT D is set for both eDP and HDMI :). in which case the proper fix is to check in intel_dp_is_edp, if PORT D is

Re: [Intel-gfx] [PATCH 18/18] drm/amdgpu: don't grab dev-struct_mutex in pm functions

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:50PM +0200, Daniel Vetter wrote: Similar to radeon, except that amdgpu doesn't even use struct_mutex to protect anything like the shared z buffer (sane gpu architecture, yay!). And the code already grabs the globa adev-ring_lock, so this code can't race with

Re: [Intel-gfx] [PATCH 17/18] drm/amdgpu: Don't take dev-struct_mutex in bo_force_delete

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:49PM +0200, Daniel Vetter wrote: It really doesn't protect anything which doesn't have other locks already. Also this is run from driver unload code so not much need for locks anyway. Same changes as for readone really. s/radeone/radeon/ Otherwise:

Re: [Intel-gfx] [PATCH 09/18] drm/cma-helper: Don't grab dev-struct_mutex for in mmap offset ioctl

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:41PM +0200, Daniel Vetter wrote: Since David Herrmann's mmap vma manager rework we don't need to grab dev-struct_mutex any more to prevent races when looking up the mmap offset. Drop it and instead don't forget to use the unref_unlocked variant (since the drm core

Re: [Intel-gfx] [PATCH 08/18] drm/cirrus: Don't grab dev-struct_mutex for in mmap offset ioctl

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:40PM +0200, Daniel Vetter wrote: Since David Herrmann's mmap vma manager rework we don't need to grab dev-struct_mutex any more to prevent races when looking up the mmap offset. Drop it and instead don't forget to use the unref_unlocked variant (since the drm core

Re: [Intel-gfx] [PATCH 13/18] drm/nouveau: Don't take dev-struct_mutex in ttm_fini

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:45PM +0200, Daniel Vetter wrote: This is only called in driver load/unload paths, no need to grab any locks at all. Also, ttm takes care of itself anyway. Cc: Ben Skeggs bske...@redhat.com Signed-off-by: Daniel Vetter daniel.vet...@intel.com ---

Re: [Intel-gfx] [PATCH 10/18] drm/rockchip: Don't grab dev-struct_mutex for in mmap offset ioctl

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:42PM +0200, Daniel Vetter wrote: Since David Herrmann's mmap vma manager rework we don't need to grab dev-struct_mutex any more to prevent races when looking up the mmap offset. Drop it and instead don't forget to use the unref_unlocked variant (since the drm core

Re: [Intel-gfx] [PATCH] drm/i915: Spam less on dp aux send/receive problems

2015-08-10 Thread Jani Nikula
On Mon, 10 Aug 2015, Jani Nikula jani.nik...@linux.intel.com wrote: On Thu, 06 Aug 2015, Mika Kuoppala mika.kuopp...@linux.intel.com wrote: If we encounter frequent problems with dp aux channel communications, we end up spamming the dmesg with the exact similar trace and status. Inject a new

Re: [Intel-gfx] [PATCH 11/18] drm/armada: Don't grab dev-struct_mutex for in mmap offset ioctl

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:43PM +0200, Daniel Vetter wrote: Since David Herrmann's mmap vma manager rework we don't need to grab dev-struct_mutex any more to prevent races when looking up the mmap offset. Drop it and instead don't forget to use the unref_unlocked variant (since the drm core

Re: [Intel-gfx] [PATCH] drm/i915: disable_shared_pll doesn't work on pre-gen5

2015-08-10 Thread Chris Wilson
On Mon, Aug 03, 2015 at 01:09:11PM -0700, Jesse Barnes wrote: Looks like commit eddfcbcdc27fbecb33bff098967bbdd7ca75bfa6 Author: Maarten Lankhorst maarten.lankho...@linux.intel.com Date: Mon Jun 15 12:33:53 2015 +0200 drm/i915: Update less state during modeset. introduced the

Re: [Intel-gfx] [PATCH 1/2] drm/tegra: don't take dev-struct_mutex in mmap offset ioctl

2015-08-10 Thread Thierry Reding
On Wed, Jul 15, 2015 at 03:38:51PM +0200, Daniel Vetter wrote: Since David Herrmann's mmap vma manager rework we don't need to grab dev-struct_mutex any more to prevent races when looking up the mmap offset. Drop it and instead don't forget to use the unref_unlocked variant (since the drm core

Re: [Intel-gfx] [PATCH] drm/i915: Retry port as HDMI if dp_is_edp turns out to be false

2015-08-10 Thread Sivakumar Thulasimani
Chris, After asking few people found that the simplest explanation and plausible root cause being that PORT D is set for both eDP and HDMI :). in which case the proper fix is to check in intel_dp_is_edp, if PORT D is again set for any other display and return false if that is the case or

Re: [Intel-gfx] [PATCH 05/18] drm/bochs: Don't grab dev-struct_mutex for in mmap offset ioctl

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:37PM +0200, Daniel Vetter wrote: Since David Herrmann's mmap vma manager rework we don't need to grab dev-struct_mutex any more to prevent races when looking up the mmap offset. Drop it and instead don't forget to use the unref_unlocked variant (since the drm core

Re: [Intel-gfx] [PATCH 04/18] drm/ast: Don't grab dev-struct_mutex for in mmap offset ioctl

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:36PM +0200, Daniel Vetter wrote: Since David Herrmann's mmap vma manager rework we don't need to grab dev-struct_mutex any more to prevent races when looking up the mmap offset. Drop it and instead don't forget to use the unref_unlocked variant (since the drm core

Re: [Intel-gfx] [PATCH 07/18] drm/mga200g: Hold a proper reference for cursor_set

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:39PM +0200, Daniel Vetter wrote: Looking up an obj, immediate dropping the acquired reference and then continuing to use it isn't how this is supposed to work. Fix this by holding a reference for the entire function. While at it stop grabbing dev-struct_mutex,

Re: [Intel-gfx] [PATCH 06/18] drm/mga200g: Don't grab dev-struct_mutex for in mmap offset ioctl

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:38PM +0200, Daniel Vetter wrote: Since David Herrmann's mmap vma manager rework we don't need to grab dev-struct_mutex any more to prevent races when looking up the mmap offset. Drop it and instead don't forget to use the unref_unlocked variant (since the drm core

Re: [Intel-gfx] [PATCH 15/18] drm/radeon: Don't take dev-struct_mutex in bo_force_delete

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:47PM +0200, Daniel Vetter wrote: It really doesn't protect anything which doesn't have other locks already. Also this is run from driver unload code so not much need for locks anyway. Cc: Alex Deucher alexander.deuc...@amd.com Cc: Christian König

Re: [Intel-gfx] [PATCH 16/18] drm/radeon: Don't take dev-struct_mutex in pm functions

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:48PM +0200, Daniel Vetter wrote: We already grab 2 device-global locks (write-sema rdev-pm.mclk_lock and rdev-ring_lock), adding another global mutex won't serialize this code more. And since there's really nothing interesting that gets protected in radeon by

Re: [Intel-gfx] [PATCH 14/18] drm/qxl: Don't take dev-struct_mutex in bo_force_delete

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:46PM +0200, Daniel Vetter wrote: It really doesn't protect anything which doesn't have other locks already. It also doesn't seem to be wired up into the driver unload code fwiw, but that's a different issue. Signed-off-by: Daniel Vetter daniel.vet...@intel.com

Re: [Intel-gfx] [PATCH v3 11/11] drm/i915: Max DOT clock frequency to debugfs

2015-08-10 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6910 -Summary- Platform Delta drm-intel-nightly Series Applied ILK -2

Re: [Intel-gfx] [PATCH 11/18] drm/armada: Don't grab dev-struct_mutex for in mmap offset ioctl

2015-08-10 Thread Russell King - ARM Linux
On Thu, Jul 09, 2015 at 11:32:43PM +0200, Daniel Vetter wrote: Since David Herrmann's mmap vma manager rework we don't need to grab dev-struct_mutex any more to prevent races when looking up the mmap offset. Drop it and instead don't forget to use the unref_unlocked variant (since the drm core

Re: [Intel-gfx] [PATCH 1/2] drm/tegra: don't take dev-struct_mutex in mmap offset ioctl

2015-08-10 Thread Daniel Vetter
On Mon, Aug 10, 2015 at 12:30:21PM +0200, Thierry Reding wrote: On Wed, Jul 15, 2015 at 03:38:51PM +0200, Daniel Vetter wrote: Since David Herrmann's mmap vma manager rework we don't need to grab dev-struct_mutex any more to prevent races when looking up the mmap offset. Drop it and instead

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Dont enable hpd for eDP

2015-08-10 Thread Jani Nikula
On Mon, 10 Aug 2015, Sivakumar Thulasimani sivakumar.thulasim...@intel.com wrote: Reviewed-by: Sivakumar Thulasimani sivakumar.thulasim...@intel.com On 8/10/2015 10:35 AM, Sonika Jindal wrote: With HPD support added for all ports including PORT_A, setting hpd_pin will result in enabling of

Re: [Intel-gfx] [PATCH 01/18] drm/gem: rip out drm vma accounting for gem mmaps

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:33PM +0200, Daniel Vetter wrote: Doesn't really add anything which can't be figured out through proc files. And more clearly separates the new gem mmap handling code from the old drm maps mmap handling code, which is surely a good thing. Cc: Martin Peres

[Intel-gfx] [PATCH] drm/i915: Use CONFIG_DRM_FBDEV_EMULATION

2015-08-10 Thread Daniel Vetter
Instead of our own duplicated one. This fixes a bug in the driver unload code if DRM_FBDEV_EMULATION=n but DRM_I915_FBDEV=y because we try to unregister the nonexistent fbdev drm_framebuffer. Cc: Archit Taneja arch...@codeaurora.org Cc: Maarten Lankhorst maarten.lankho...@linux.intel.com

Re: [Intel-gfx] [PATCH 1/2] drm/tegra: don't take dev-struct_mutex in mmap offset ioctl

2015-08-10 Thread Thierry Reding
On Mon, Aug 10, 2015 at 01:31:42PM +0200, Daniel Vetter wrote: On Mon, Aug 10, 2015 at 12:30:21PM +0200, Thierry Reding wrote: On Wed, Jul 15, 2015 at 03:38:51PM +0200, Daniel Vetter wrote: Since David Herrmann's mmap vma manager rework we don't need to grab dev-struct_mutex any more to

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Dont enable hpd for eDP

2015-08-10 Thread Sivakumar Thulasimani
On 8/10/2015 5:07 PM, Jani Nikula wrote: On Mon, 10 Aug 2015, Sivakumar Thulasimani sivakumar.thulasim...@intel.com wrote: Reviewed-by: Sivakumar Thulasimani sivakumar.thulasim...@intel.com On 8/10/2015 10:35 AM, Sonika Jindal wrote: With HPD support added for all ports including PORT_A,

Re: [Intel-gfx] [PATCH] drm/i915: Use CONFIG_DRM_FBDEV_EMULATION

2015-08-10 Thread Thierry Reding
On Mon, Aug 10, 2015 at 01:34:08PM +0200, Daniel Vetter wrote: Instead of our own duplicated one. This fixes a bug in the driver unload code if DRM_FBDEV_EMULATION=n but DRM_I915_FBDEV=y because we try to unregister the nonexistent fbdev drm_framebuffer. Cc: Archit Taneja

Re: [Intel-gfx] [PATCH v3 3/4] ALSA: hda - display audio call ncts callback

2015-08-10 Thread Jani Nikula
On Mon, 10 Aug 2015, libin.y...@intel.com wrote: From: Libin Yang libin.y...@intel.com On some Intel platforms, display audio need set N/CTS manually at some TMDS frequencies. Signed-off-by: Libin Yang libin.y...@intel.com --- sound/pci/hda/patch_hdmi.c | 23 +++ 1

Re: [Intel-gfx] [PATCH 2/2] drm/doc: Update docs about device instance setup

2015-08-10 Thread Thierry Reding
On Mon, Aug 10, 2015 at 11:55:38AM +0200, Daniel Vetter wrote: -load is depracated, bus functionst are deprecated and everyone should use drm_dev_allocregister. Why would you want to deprecated -load()? Even if you use drm_dev_alloc() and drm_dev_register(), there's still use for -load()

Re: [Intel-gfx] [PATCH 00/18] dev-struct_mutex crusade

2015-08-10 Thread Daniel Vetter
On Mon, Aug 10, 2015 at 01:35:58PM +0200, Thierry Reding wrote: On Thu, Jul 09, 2015 at 11:32:32PM +0200, Daniel Vetter wrote: Hi all, I wanted to take another look at struct_mutex usage in modern (gem) drivers and noticed that for a fair lot we're very to be completely struct_mutex

Re: [Intel-gfx] [PATCH v4 4/4] drm/i915: set proper N/CTS in modeset

2015-08-10 Thread Jani Nikula
On Mon, 10 Aug 2015, libin.y...@intel.com wrote: From: Libin Yang libin.y...@intel.com When modeset occurs and the TMDS frequency is set to some speical value, the N/CTS need to be set manually if audio is playing. When modeset occurs, we disable everything, and then re-enable everything,

Re: [Intel-gfx] [PATCH 2/2] drm/doc: Update docs about device instance setup

2015-08-10 Thread Daniel Vetter
On Mon, Aug 10, 2015 at 01:59:07PM +0200, Thierry Reding wrote: On Mon, Aug 10, 2015 at 11:55:38AM +0200, Daniel Vetter wrote: -load is depracated, bus functionst are deprecated and everyone should use drm_dev_allocregister. Why would you want to deprecated -load()? Even if you use

Re: [Intel-gfx] [PATCH] drm/atomic: Call ww_acquire_done after check phase is complete

2015-08-10 Thread Daniel Vetter
On Thu, Aug 06, 2015 at 03:06:40PM +0200, Daniel Vetter wrote: We want to make sure that no one tries to acquire more locks and states, and ww mutexes provide debug facilities for that. So use them. v2: Only call acquire_done when -atomic_check was successful to avoid falling over an

Re: [Intel-gfx] [PATCH] drm/atomic: Paper over locking WARN in default_state_clear

2015-08-10 Thread Daniel Vetter
On Fri, Jul 31, 2015 at 03:41:15PM +0200, Daniel Vetter wrote: On Fri, Jul 31, 2015 at 10:34:43AM +0200, Maarten Lankhorst wrote: Hey, Op 29-07-15 om 12:51 schreef Daniel Vetter: In commit 6f75cea66c8dd043ced282016b21a639af176642 Author: Daniel Vetter daniel.vet...@ffwll.ch

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: implement set_ncts callback

2015-08-10 Thread Jani Nikula
On Mon, 10 Aug 2015, libin.y...@intel.com wrote: From: Libin Yang libin.y...@intel.com Display audio may not work at some frequencies with the HW provided N/CTS. This patch sets the proper N value for the given audio sample rate at the impacted frequencies. At other frequencies, it will

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Dont enable hpd for eDP

2015-08-10 Thread Ville Syrjälä
On Mon, Aug 10, 2015 at 03:14:36PM +0300, Jani Nikula wrote: On Mon, 10 Aug 2015, Sivakumar Thulasimani sivakumar.thulasim...@intel.com wrote: On 8/10/2015 5:07 PM, Jani Nikula wrote: On Mon, 10 Aug 2015, Sivakumar Thulasimani sivakumar.thulasim...@intel.com wrote: Reviewed-by:

Re: [Intel-gfx] [PATCH 00/18] dev-struct_mutex crusade

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:32PM +0200, Daniel Vetter wrote: Hi all, I wanted to take another look at struct_mutex usage in modern (gem) drivers and noticed that for a fair lot we're very to be completely struct_mutex free. This pile here is the the simple part, which mostly just

Re: [Intel-gfx] [PATCH 03/18] drm/gem: Be more friendly with locking checks

2015-08-10 Thread Daniel Vetter
On Mon, Aug 10, 2015 at 12:42:30PM +0200, Thierry Reding wrote: On Thu, Jul 09, 2015 at 11:32:35PM +0200, Daniel Vetter wrote: BUG_ON kills the driver, WARN_ON is much friendly. And usually nothing bad happens when the locking is lightly busted. s/much friendly/much friendlier/,

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915: Add audio set_ncts callback

2015-08-10 Thread Jani Nikula
On Mon, 10 Aug 2015, libin.y...@intel.com wrote: From: Libin Yang libin.y...@intel.com Add the set_ncts callback. With the callback, audio driver can trigger i915 driver to set the proper N/CTS based on different sample rates. Signed-off-by: Libin Yang libin.y...@intel.com ---

Re: [Intel-gfx] [PATCH 00/18] dev-struct_mutex crusade

2015-08-10 Thread Chris Wilson
On Mon, Aug 10, 2015 at 01:35:58PM +0200, Thierry Reding wrote: On Thu, Jul 09, 2015 at 11:32:32PM +0200, Daniel Vetter wrote: Hi all, I wanted to take another look at struct_mutex usage in modern (gem) drivers and noticed that for a fair lot we're very to be completely struct_mutex

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: implement set_ncts callback

2015-08-10 Thread Jani Nikula
On Mon, 10 Aug 2015, libin.y...@intel.com wrote: From: Libin Yang libin.y...@intel.com Display audio may not work at some frequencies with the HW provided N/CTS. This patch sets the proper N value for the given audio sample rate at the impacted frequencies. At other frequencies, it will

Re: [Intel-gfx] [PATCH 00/18] dev-struct_mutex crusade

2015-08-10 Thread Thierry Reding
On Mon, Aug 10, 2015 at 12:53:23PM +0100, Chris Wilson wrote: On Mon, Aug 10, 2015 at 01:35:58PM +0200, Thierry Reding wrote: On Thu, Jul 09, 2015 at 11:32:32PM +0200, Daniel Vetter wrote: Hi all, I wanted to take another look at struct_mutex usage in modern (gem) drivers and

Re: [Intel-gfx] [PATCH 1/2] drm/edid: Use ARRAY_SIZE in drm_add_modes_noedid

2015-08-10 Thread Thierry Reding
On Mon, Aug 10, 2015 at 11:55:37AM +0200, Daniel Vetter wrote: Spotted while reading code for random reasons. Signed-off-by: Daniel Vetter daniel.vet...@intel.com --- drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_edid.c

Re: [Intel-gfx] [PATCH 1/2] drm/edid: Use ARRAY_SIZE in drm_add_modes_noedid

2015-08-10 Thread Daniel Vetter
On Mon, Aug 10, 2015 at 01:57:21PM +0200, Thierry Reding wrote: On Mon, Aug 10, 2015 at 11:55:37AM +0200, Daniel Vetter wrote: Spotted while reading code for random reasons. Signed-off-by: Daniel Vetter daniel.vet...@intel.com --- drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1

Re: [Intel-gfx] [PATCH] drm/i915: Use CONFIG_DRM_FBDEV_EMULATION

2015-08-10 Thread Daniel Vetter
On Mon, Aug 10, 2015 at 01:48:53PM +0200, Thierry Reding wrote: On Mon, Aug 10, 2015 at 01:34:08PM +0200, Daniel Vetter wrote: Instead of our own duplicated one. This fixes a bug in the driver unload code if DRM_FBDEV_EMULATION=n but DRM_I915_FBDEV=y because we try to unregister the

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Dont enable hpd for eDP

2015-08-10 Thread Jani Nikula
On Mon, 10 Aug 2015, Sivakumar Thulasimani sivakumar.thulasim...@intel.com wrote: On 8/10/2015 5:07 PM, Jani Nikula wrote: On Mon, 10 Aug 2015, Sivakumar Thulasimani sivakumar.thulasim...@intel.com wrote: Reviewed-by: Sivakumar Thulasimani sivakumar.thulasim...@intel.com On 8/10/2015 10:35

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Dont enable hpd for eDP

2015-08-10 Thread Sivakumar Thulasimani
On 8/10/2015 5:44 PM, Jani Nikula wrote: On Mon, 10 Aug 2015, Sivakumar Thulasimani sivakumar.thulasim...@intel.com wrote: On 8/10/2015 5:07 PM, Jani Nikula wrote: On Mon, 10 Aug 2015, Sivakumar Thulasimani sivakumar.thulasim...@intel.com wrote: Reviewed-by: Sivakumar Thulasimani

Re: [Intel-gfx] [PATCH i-g-t 4/3] tests/gem_ctx_param_basic: Expand ctx_param tests

2015-08-10 Thread David Weinehall
On Thu, Aug 06, 2015 at 02:33:31PM -0700, Jesse Barnes wrote: On 08/06/2015 02:30 PM, Daniel Vetter wrote: On Fri, May 29, 2015 at 09:52:52AM +0200, Daniel Vetter wrote: On Thu, May 28, 2015 at 05:53:17PM +0300, David Weinehall wrote: On Wed, May 27, 2015 at 01:32:10PM +0200, Daniel Vetter

  1   2   >