[Intel-gfx] [PATCH 1/1] drm/i915: Fix fb object's frontbuffer-bits

Shared frontbuffer bits are causing warnings when same FB is displayed in another plane without clearing the bits from previous plane. Change-Id: Ic2df80747f314b82afd22f8326297c57d1e652c6 Signed-off-by: Sagar Arun Kamble Signed-off-by: Kumar, Mahesh

Re: [Intel-gfx] [PATCH i-g-t v2] tools: install the register definition files

On Fri, 04 Sep 2015, Thomas Wood wrote: > Install the register definition files and use them by default in > intel_reg. > > v2: remove redundant path check > > Suggested-by: Jani Nikula > Signed-off-by: Thomas Wood

Re: [Intel-gfx] [PATCH v4 0/5] drm: Add decoding for DRM/KMS and i915 ioctls

On Mon, 24 Aug 2015 14:42:45 +0200 Patrik Jakobsson wrote: > This set of patches adds a dispatcher for handling DRM ioctls. The > kernel headers for DRM might not be available on all distributions > so we depend on libdrm for those. If libdrm is not available we

Re: [Intel-gfx] [PATCH] drm/i915: remove excessive scaler debugging messages

On 08/14/2015 01:59 PM, Jani Nikula wrote: There's so much scaler debugging messages that it makes other debugging hard. Remove them. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_atomic.c | 3 --- drivers/gpu/drm/i915/intel_display.c | 2 -- 2 files

Re: [Intel-gfx] [DMC_BUGFIX_SKL_V2 3/5] drm/i915/skl: Making DC6 entry is the last call in suspend flow.

On Wednesday 26 August 2015 01:36 AM, Animesh Manna wrote: Mmio register access after dc6/dc5 entry is not allowed when DC6 power states are enabled according to bspec (bspec-id 0527), so enabling dc6 as the last call in suspend flow. v1: Initial version. v2: Based on review comment from

Re: [Intel-gfx] [DMC_BUGFIX_SKL_V2 4/5] drm/i915/skl: Do not disable cdclk PLL if csr firmware is present

On Wednesday 26 August 2015 01:36 AM, Animesh Manna wrote: While display engine entering into low power state no need to disable cdclk pll as CSR firmware of dmc will take care. If pll is already enabled firmware execution sequence will be blocked. This is one of the criteria for dmc to work

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests/gem_pwrite_snooped: fix const cast warning

On Mon, Sep 07, 2015 at 12:34:12PM +0100, Thomas Wood wrote: > Signed-off-by: Thomas Wood > --- > tests/gem_pwrite_snooped.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/gem_pwrite_snooped.c b/tests/gem_pwrite_snooped.c > index

Re: [Intel-gfx] [PATCH] drm/i915: Detect virtual south bridge

On 02/09/2015 11:11, Daniel Vetter wrote: On Fri, Aug 28, 2015 at 01:10:22PM +0100, robert.beck...@intel.com wrote: From: Robert Beckett Virtualized systems often use a virtual P2X4 south bridge. Detect this in intel_detect_pch and make a best guess as to which PCH

[Intel-gfx] [PATCH i-g-t 1/2] build: fix unused-result warnings

Signed-off-by: Thomas Wood --- benchmarks/kms_vblank.c| 7 --- debugger/eudb.c| 4 +++- lib/igt_aux.c | 8 ++-- overlay/gpu-top.c | 4 +++- overlay/overlay.c | 4 ++-- tools/intel_l3_udev_listener.c

[Intel-gfx] [PATCH i-g-t 2/2] tests/gem_pwrite_snooped: fix const cast warning

Signed-off-by: Thomas Wood --- tests/gem_pwrite_snooped.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/gem_pwrite_snooped.c b/tests/gem_pwrite_snooped.c index d3f6223..29142c3 100644 --- a/tests/gem_pwrite_snooped.c +++

Re: [Intel-gfx] [DMC_BUGFIX_SKL_V2 1/5] drm/i915/skl: Added a check for the hardware status of csr fw before loading.

On Wednesday 26 August 2015 01:36 AM, Animesh Manna wrote: Dmc will restore the csr program except DC9, cold boot, warm reset, PCI function level reset, and hibernate/suspend. intel_csr_load_program() function is used to load the firmware data from kernel memory to csr address space. All

Re: [Intel-gfx] [DMC_BUGFIX_SKL_V2 2/5] drm/i915/skl Remove the call for csr uninitialization from suspend path

On Wednesday 26 August 2015 01:36 AM, Animesh Manna wrote: This patch remove the function call to set the firmware loading status as uninitialized during suspend. Dmc firmware will restore the firmware in normal suspend. In previous patch added a check to directly read the hardware status and

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests/gem_pwrite_snooped: fix const cast warning

On Mon, Sep 07, 2015 at 12:34:12PM +0100, Thomas Wood wrote: > Signed-off-by: Thomas Wood > --- > tests/gem_pwrite_snooped.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/gem_pwrite_snooped.c b/tests/gem_pwrite_snooped.c > index

Re: [Intel-gfx] [PATCH] libdrm: Add framebuffer modifiers uapi

On 08/03/2015 10:48 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Sync up with new kernel features as per commits: e3eb3250d84ef97b766312345774367b6a310db8 93b81f5102a7cd270a305c2741b17c8d44bb0629 b5ff6e1637b683d5996ae11ac29afe406c0bee90

Re: [Intel-gfx] [PATCH] drm/i915: Call encoder hot_plug hook only for hdmi

On Mon, Sep 07, 2015 at 10:34:34AM +0530, Sonika Jindal wrote: > If the same port is enumerated as hdmi as well as DP, this will call > hot_plug hook for DP as well which is not required here. > This splitting of edid read and detect is done only for HDMI with this > series. > > v2: Avoid

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests/gem_pwrite_snooped: fix const cast warning

On Mon, Sep 07, 2015 at 03:49:58PM +0100, Thomas Wood wrote: > On 7 September 2015 at 13:53, Ville Syrjälä > wrote: > > On Mon, Sep 07, 2015 at 12:34:12PM +0100, Thomas Wood wrote: > >> Signed-off-by: Thomas Wood > >> --- > >>

[Intel-gfx] [PATCH 1/3] drm: Make some modes const when iterating through them

From: Ville Syrjälä valid_inferred_mode() don't change the modes over which it iterates, so make the iterator const. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Intel-gfx] [PATCH 2/3] drm: Remove the 'mode' argument from drm_select_eld()

From: Ville Syrjälä drm_select_eld() doesn't look at the passed in mode, so don't pass it in. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 4 +--- drivers/gpu/drm/i915/intel_audio.c | 2 +-

[Intel-gfx] [PATCH 3/3] drm: Make drm_av_sync_delay() 'mode' argument const

From: Ville Syrjälä drm_av_sync_delay() doesn't change the passed in mode, so make it const. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 2 +- include/drm/drm_edid.h | 2 +- 2 files changed, 2 insertions(+), 2

Re: [Intel-gfx] [RFC] drm/i915: Render decompression support for Gen9 and above

On Sat, Sep 05, 2015 at 01:12:50AM +0530, Vandana Kannan wrote: > This patch includes enabling render decompression after checking all the > requirements (format, tiling, rotation etc.). Along with this, the WAs > mentioned in BSpec Workaround page have been implemented. > > This patch has been

[Intel-gfx] intel_pm.c:3326 warning in skl_update_pipe_wm

Hi, Using drm-intel-nightly or drm-intel-next-fixes, I get a warning on boot in intel_pm.c skl_updatE_pipe_wm. p->pixel_rate == 0. This is with a new Skylake i7 6700K on an Asus Z170-DELUXE. The monitor is connected via the HDMI 2.0 port to a 1080p monitor with an HDMI-to-DVI cable. HDMI 2.0 is

[Intel-gfx] [PATCH i-g-t] intel_reg: ensure "intel_reg help" always works

Signed-off-by: Thomas Wood --- tools/intel_reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/intel_reg.c b/tools/intel_reg.c index 95760db..2b3c686 100644 --- a/tools/intel_reg.c +++ b/tools/intel_reg.c @@ -865,7 +865,7 @@ int main(int argc,

Re: [Intel-gfx] [PATCH 4/4] drm/i915/bxt: Clean up bxt_init_clock_gating

On Mon, Sep 07, 2015 at 02:55:08PM +0100, Nick Hoath wrote: > On 29/06/2015 15:29, Mika Kuoppala wrote: > >Nick Hoath writes: > > > >>Add stepping check for A0 workarounds, and remove the associated > >>FIXME tags. > >>Split out unrelated WAs for later condition

Re: [Intel-gfx] [DMC_BUGFIX_SKL_V2 1/5] drm/i915/skl: Added a check for the hardware status of csr fw before loading.

On Mon, Sep 07, 2015 at 04:34:30PM +0530, Sunil Kamath wrote: > On Wednesday 26 August 2015 01:36 AM, Animesh Manna wrote: > >Dmc will restore the csr program except DC9, cold boot, > >warm reset, PCI function level reset, and hibernate/suspend. > > > >intel_csr_load_program() function is used to

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: don't hard code vlv backlight frequency if unset

On Fri, Sep 04, 2015 at 03:42:54PM -0700, Clint Taylor wrote: > On 09/04/2015 06:55 AM, Jani Nikula wrote: > >Fall back to VBT based backlight modulation frequency if it's not > >set. Do not hard code. > > > >This could be a problem if there is no VBT. > > > >Cc: Clint Taylor

[Intel-gfx] Skylake 6700k Intel HD Graphics 530 Display Port Panic

Hello, I am currently trying to set up a newly built system with a Skylake 6700k CPU but am having an extremely reproducible kernel panic every time I connect a monitor to the display port connector of the Intel integrated graphics chip. This issue occurs either immediately upon connecting a

Re: [Intel-gfx] [PATCH 4/4] drm/i915/bxt: Clean up bxt_init_clock_gating

On 29/06/2015 15:29, Mika Kuoppala wrote: Nick Hoath writes: Add stepping check for A0 workarounds, and remove the associated FIXME tags. Split out unrelated WAs for later condition checking. v2: Fixed format (PeterL) v3: Corrected stepping check for

[Intel-gfx] [PATCH i-g-t] tests: remove gem_storedw_loop_* tests

These have been replaced by subtests in gem_storedw_loop. Signed-off-by: Thomas Wood --- tests/.gitignore| 4 -- tests/Makefile.sources | 4 -- tests/gem_storedw_loop_blt.c| 150 ---

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests/gem_pwrite_snooped: fix const cast warning

On 7 September 2015 at 13:53, Ville Syrjälä wrote: > On Mon, Sep 07, 2015 at 12:34:12PM +0100, Thomas Wood wrote: >> Signed-off-by: Thomas Wood >> --- >> tests/gem_pwrite_snooped.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Fix fb object's frontbuffer-bits

On Mon, Sep 07, 2015 at 01:33:51PM +0530, Sagar Arun Kamble wrote: > Shared frontbuffer bits are causing warnings when same FB is displayed > in another plane without clearing the bits from previous plane. This commit message is very confusing, since clearing FB bits isn't broken. What you

Re: [Intel-gfx] [PATCH i-g-t] tests: remove gem_storedw_loop_* tests

On Mon, Sep 07, 2015 at 03:01:39PM +0100, Thomas Wood wrote: > These have been replaced by subtests in gem_storedw_loop. > > Signed-off-by: Thomas Wood Reviewed-by: Daniel Vetter ... especially since I asked for this when reviewing Jesse BAT

Re: [Intel-gfx] [PATCH v4 2/5] drm: Add private data field to trace control block

On Mon, Aug 31, 2015 at 02:37:07PM +0200, Patrik Jakobsson wrote: [...] > Here's my take on it (I assume it needs some discussion): > > int > set_tcb_priv_data(struct tcb *tcp, void *priv_data) > { > /* A free callback is required before setting private data and private >* data must

Re: [Intel-gfx] [PATCH v4 4/5] drm: Add decoding of i915 ioctls

On Mon, Aug 24, 2015 at 02:42:49PM +0200, Patrik Jakobsson wrote: > +static int i915_getparam(struct tcb *tcp, const unsigned int code, long arg) > +{ > + struct drm_i915_getparam param; > + int value; > + > + if (umove(tcp, arg, )) > + return RVAL_DECODED; > + > + if

Re: [Intel-gfx] Skylake 6700k Intel HD Graphics 530 Display Port Panic

I see the similar error message on one SKL machine, but DP system works well and system doesn't panic. I resolved it by one of the following three method, maybe you could try it. 1) boot with i915.disable_power_well=0 2)delete /lib/firmware/i915/skl_dmc_ver1.bin 3) apply the patch set in

Re: [Intel-gfx] [PATCH v4 3/5] drm: Add dispatcher and driver identification for DRM

On Mon, Aug 24, 2015 at 02:42:48PM +0200, Patrik Jakobsson wrote: > * Makefile.am: Add compilation of drm.c. > * defs.h: Add extern declaration of drm_ioctl when drm headers are found. > * drm.c: New file. > * ioctl.c (ioctl_decode): Dispatch drm ioctls when drm headers are found. * defs.h

Re: [Intel-gfx] [PATCH] drm/i915: Call encoder hot_plug hook only for hdmi

On 9/7/2015 9:56 PM, Daniel Vetter wrote: On Mon, Sep 07, 2015 at 10:34:34AM +0530, Sonika Jindal wrote: If the same port is enumerated as hdmi as well as DP, this will call hot_plug hook for DP as well which is not required here. This splitting of edid read and detect is done only for HDMI

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

Hi all, On Thu, 3 Sep 2015 10:49:19 +1000 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c: In function > 'mdp5_plane_cleanup_fb': >

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

Op 08-09-15 om 01:42 schreef Stephen Rothwell: > Hi all, > > On Thu, 3 Sep 2015 10:49:19 +1000 Stephen Rothwell > wrote: >> After merging the drm-misc tree, today's linux-next build (arm >> multi_v7_defconfig) failed like this: >> >>

Re: [Intel-gfx] [PATCH v4 4/5] drm: Add decoding of i915 ioctls

On Tue, Sep 08, 2015 at 04:18:11AM +0300, Dmitry V. Levin wrote: [...] > So the whole function should look smth like this: > > static int i915_getparam(struct tcb *tcp, const unsigned int code, long arg) > { > struct drm_i915_getparam param; > > if (entering(tcp)) { >

[Intel-gfx] Temporary freezes

Hi all. I've got an Intel(R) Iris(TM) Pro Graphics 5200 ( in a Macbook ), and I'm running a 4.1.5-rt5 kernel, libdrm-2.4.64 and mesa-11.0.0_rc1. I use Enlightenment ( from git ), and on this particular system only, I get a couple of graphics-only freezes per day. When it happens, the mouse pointer

Re: [Intel-gfx] [PATCH i-g-t] tests: remove gem_storedw_loop_* tests

Yeah looks good, thanks. I thought it should be a separate patch, bur never got around to doing it. Thanks, Jesse Daniel Vetter wrote >On Mon, Sep 07, 2015 at 03:01:39PM +0100, Thomas Wood wrote: >> These have been replaced by subtests in gem_storedw_loop. >> >> Signed-off-by:

[Intel-gfx] [PATCH 3/6] drm/doc: Convert to markdown

DRM Docbook is now Markdown ready. This means its doc is able to use markdown text on it. * Documentation/DocBook/drm.tmpl: Contains a table duplicated from drivers/gpu/drm/i915/i915_reg.h. This is not needed anymore * drivers/gpu/drm/drm_modeset_lock.c: had a code example that used to look

[Intel-gfx] [PATCH 6/6] scripts/kernel-doc: Processing -nofunc for functions only

Docproc process EXPORT_SYMBOL(f1) macro and uses -nofunc f1 to avoid duplicated documentation in the next call. It works for most of the cases, but there are some specific situations where a struct has the same name of an already-exported function. Current kernel-doc behavior ignores those

[Intel-gfx] [PATCH 1/6] scripts/kernel-doc: Replacing highlights hash by an array

The "highlight" code is very sensible to the order of the hash keys, but the order of the keys cannot be predicted. It generates faulty DocBook entries like: - @device_for_each_child Sorting the result is not enough some times (as it's deterministic but we can't control it). We should use

[Intel-gfx] [PATCH 2/6] scripts/kernel-doc: Adding infrastructure for markdown support

Markdown support is given by calling an external tool, pandoc, for all highlighted text on kernel-doc. Pandoc converts Markdown text to proper Docbook tags, which will be later translated to pdf, html or other targets. This adds the capability of adding human-readle text highlight (bold,

[Intel-gfx] [PATCH 5/6] scripts/kernel-doc: Improve Markdown results

Using pandoc as the Markdown engine cause some minor side effects as pandoc includes main tags for almost everything. Original Markdown support approach removes those main tags, but it caused some inconsistencies when that tag is not the main one, like: .. ... As kernel-doc was already

[Intel-gfx] [PATCH 4/6] drm/doc: Fixing xml documentation warning

"/**" should be used for kernel-doc documentation only. It causes a warning with the new "in struct body" format. Signed-off-by: Danilo Cesar Lemes de Paula Cc: Randy Dunlap Cc: Daniel Vetter Cc: Laurent Pinchart

[Intel-gfx] [PATCH 0/6] scripts/kernel-doc: Kernel-doc improvements

The following series contains: * kernel-doc: markdown support and improvements. * Fixing kernel-doc highlights. * Improve doc support for functions and structs with same name. * misc small fixes for drm docbook. Signed-off-by: Danilo Cesar Lemes de Paula Cc:

Re: [Intel-gfx] [PATCH] scripts/kernel-doc: Improve Markdown results

On 09/04/2015 05:39 PM, Jonathan Corbet wrote: > On Fri, 4 Sep 2015 14:53:34 -0300 > Danilo Cesar Lemes de Paula wrote: > >> In the last few days I sent three features: >> Markdown support (patch series 1) >> Cross-reference hyperlink support (patch series 1) >>

Re: [Intel-gfx] [DMC_BUGFIX_SKL_V2 5/5] drm/i915/skl: Block disable call for pw1 if dmc firmware is present.

On Wednesday 26 August 2015 01:36 AM, Animesh Manna wrote: Another interesting criteria to work dmc as expected is pw1 to be enabled by driver and dmc will shut it off in its execution sequence. If already disabled by driver dmc will get confuse and behave differently than expected found during

Re: [Intel-gfx] [PATCH v4 2/5] drm: Add private data field to trace control block

On Mon, Sep 7, 2015 at 6:51 PM, Dmitry V. Levin wrote: > On Mon, Aug 31, 2015 at 02:37:07PM +0200, Patrik Jakobsson wrote: > [...] >> Here's my take on it (I assume it needs some discussion): >> >> int >> set_tcb_priv_data(struct tcb *tcp, void *priv_data) >> { >> /* A

Re: [Intel-gfx] [git pull] drm for 4.3

On Fri, Sep 04, 2015 at 11:40:53PM +0100, Dave Airlie wrote: > > Hi Linus, > > This is the main pull request for the drm for 4.3. Nouveau is probably the > biggest > amount of changes in here, since it missed 4.2. Highlights below, along with > the usual > bunch of fixes. There are a