Re: [Intel-gfx] [PATCH v2 4/5] drm/i915: Change locking for struct_mutex, v2.

Op 02-11-15 om 14:06 schreef Chris Wilson: > On Mon, Nov 02, 2015 at 01:57:59PM +0100, Maarten Lankhorst wrote: >> struct_mutex is being locked for every plane in intel_prepare_plane_fb and >> intel_cleanup_plane_fb. This can be optimized by acquiring struct_mutex first >> before calling the

Re: [Intel-gfx] [PATCH] drm: Describe the Rotation property bits.

On mån, 2015-11-02 at 16:50 +0200, Ville Syrjälä wrote: > On Mon, Nov 02, 2015 at 03:24:15PM +0100, Robert Fekete wrote: > > Adds clarification of the rotation property bits. I.e. rotation is > > Counter clockwise and that reflects are applied before any rotation. > > > > Signed-off-by:

Re: [Intel-gfx] [PATCH v2] drm: Describe the Rotation property bits.

On Mon, Nov 02, 2015 at 04:14:08PM +0100, Robert Fekete wrote: > Adds clarification of the rotation property bits. I.e. rotation is > counter clockwise and that reflects are applied before any rotation. > > v2: Refer to the define names instead of the property values. > >

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Make prepare_plane_fb fully interruptible."

On Mon, Nov 02, 2015 at 01:41:03PM +0100, Maarten Lankhorst wrote: > Hey, > > Op 30-10-15 om 22:06 schreef ville.syrj...@linux.intel.com: > > From: Ville Syrjälä > > > > This reverts commit b26a6b35581c84124bd78b68cc02d171fbd572c9. > > > > commit b26a6b35581c

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Wait for object idle without locks in atomic_commit.

On Mon, Nov 02, 2015 at 02:13:48PM +0100, Maarten Lankhorst wrote: > Op 29-10-15 om 01:30 schreef Matt Roper: > > On Wed, Sep 23, 2015 at 01:27:12PM +0200, Maarten Lankhorst wrote: > >> diff --git a/drivers/gpu/drm/i915/intel_overlay.c > >> b/drivers/gpu/drm/i915/intel_overlay.c > >> index

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Wait for object idle without locks in atomic_commit.

On Mon, Nov 02, 2015 at 02:53:00PM +0100, Maarten Lankhorst wrote: > Op 02-11-15 om 14:46 schreef Chris Wilson: > > On Mon, Nov 02, 2015 at 02:13:48PM +0100, Maarten Lankhorst wrote: > >> Op 29-10-15 om 01:30 schreef Matt Roper: > >>> On Wed, Sep 23, 2015 at 01:27:12PM +0200, Maarten Lankhorst

Re: [Intel-gfx] [PATCH] igt/kms_rotation_crc: Add a subtest to validate Y-tiled obj + Y fb modifier (v3)

On 27 October 2015 at 10:37, Tvrtko Ursulin wrote: > > On 23/10/15 12:35, Daniel Vetter wrote: >> >> On Fri, Oct 23, 2015 at 09:51:06AM +0100, Tvrtko Ursulin wrote: >>> >>> >>> Hi, >>> >>> On 23/10/15 02:34, Vivek Kasireddy wrote: The main goal of this

[Intel-gfx] [PATCH] drm: Describe the Rotation property bits.

Adds clarification of the rotation property bits. I.e. rotation is Counter clockwise and that reflects are applied before any rotation. Signed-off-by: Robert Fekete --- include/drm/drm_crtc.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Wait for object idle without locks in atomic_commit.

Op 02-11-15 om 14:46 schreef Chris Wilson: > On Mon, Nov 02, 2015 at 02:13:48PM +0100, Maarten Lankhorst wrote: >> Op 29-10-15 om 01:30 schreef Matt Roper: >>> On Wed, Sep 23, 2015 at 01:27:12PM +0200, Maarten Lankhorst wrote: diff --git a/drivers/gpu/drm/i915/intel_overlay.c

Re: [Intel-gfx] [PATCH] drm/i915: Fall back to zero vswing/preemph if the sink doesn't like the last good values

On Mon, Nov 02, 2015 at 01:21:23PM +, Conselvan De Oliveira, Ander wrote: > On Fri, 2015-10-30 at 18:47 +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > My Lenovo STM STDP3100 miniDP->VGA dongle doesn't seem to like it when > > we try

Re: [Intel-gfx] [PATCH] RFC drm/i915: Slaughter the thundering i915_wait_request herd

On Mon, Nov 02, 2015 at 02:00:47PM +, Gong, Zhipeng wrote: > Attach the perf data for BDW async1 and async5 with or without patch. Hmm, I can see it is the i915_spin_request() consuming the time, but I was hoping to get the callgraph so I could see where the call to i915_wait_request was

[Intel-gfx] [PATCH v2] drm: Describe the Rotation property bits.

Adds clarification of the rotation property bits. I.e. rotation is counter clockwise and that reflects are applied before any rotation. v2: Refer to the define names instead of the property values. Signed-off-by: Robert Fekete ---

Re: [Intel-gfx] [PATCH] RFC drm/i915: Slaughter the thundering i915_wait_request herd

On Mon, Nov 02, 2015 at 02:57:47PM +, Gong, Zhipeng wrote: > > -Original Message- > > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > > Sent: Monday, November 02, 2015 10:16 PM > > To: Gong, Zhipeng > > Cc: intel-gfx@lists.freedesktop.org; Rogozhkin, Dmitry V > > Subject: Re:

[Intel-gfx] [PATCH v2 4/5] drm/i915: Change locking for struct_mutex, v2.

struct_mutex is being locked for every plane in intel_prepare_plane_fb and intel_cleanup_plane_fb. This can be optimized by acquiring struct_mutex first before calling the atomic helpers. This way the lock only needs to be acquired twice in ->atomic_commit(). Once for pinning new framebuffers at

Re: [Intel-gfx] [PATCH] drm/i915/skl: While sanitizing cdclock check the SWF18 as well

On Mon, 02 Nov 2015, Shobhit Kumar wrote: > SWF18 is set if the display has been intialized by the pre-os. It > also gives what configuration is enabled on which pipe. The DPLL and > CDCLK verification checks can fail as the pre-os does initialize the > DPLL for Audio

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Splitting intel_dp_detect

Hi Shubhangi, [auto build test WARNING on drm-intel/for-linux-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Shubhangi-Shrivastava/Fixing-sink-count-related-detection-over/20151102-205435 config

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915: Change locking for struct_mutex, v2.

On Mon, Nov 02, 2015 at 01:57:59PM +0100, Maarten Lankhorst wrote: > struct_mutex is being locked for every plane in intel_prepare_plane_fb and > intel_cleanup_plane_fb. This can be optimized by acquiring struct_mutex first > before calling the atomic helpers. This way the lock only needs to be

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Splitting intel_dp_check_link_status

Hi Shubhangi, [auto build test WARNING on drm-intel/for-linux-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Shubhangi-Shrivastava/Fixing-sink-count-related-detection-over/20151102-205435 config

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Wait for object idle without locks in atomic_commit.

Op 29-10-15 om 01:30 schreef Matt Roper: > On Wed, Sep 23, 2015 at 01:27:12PM +0200, Maarten Lankhorst wrote: >> Make pinning and waiting a separate step, and wait for object idle >> without struct_mutex held. >> >> Signed-off-by: Maarten Lankhorst >> --- >>

Re: [Intel-gfx] [PATCH] drm/i915/skl: While sanitizing cdclock check the SWF18 as well

On 11/02/2015 06:40 PM, Jani Nikula wrote: On Mon, 02 Nov 2015, Shobhit Kumar wrote: SWF18 is set if the display has been intialized by the pre-os. It also gives what configuration is enabled on which pipe. The DPLL and CDCLK verification checks can fail as the pre-os

Re: [Intel-gfx] [PATCH] drm/i915: Fall back to zero vswing/preemph if the sink doesn't like the last good values

On Fri, 2015-10-30 at 18:47 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > My Lenovo STM STDP3100 miniDP->VGA dongle doesn't seem to like it when > we try to start link training with non-zero vswing/preemphasis. So when > the initial link

Re: [Intel-gfx] [PATCH] drm/i915/skl: While sanitizing cdclock check the SWF18 as well

On 11/2/2015 11:17 PM, Kumar, Shobhit wrote: On 11/02/2015 10:07 PM, Thulasimani, Sivakumar wrote: On 11/2/2015 6:49 PM, Kumar, Shobhit wrote: On 11/02/2015 06:40 PM, Jani Nikula wrote: On Mon, 02 Nov 2015, Shobhit Kumar wrote: SWF18 is set if the display has

Re: [Intel-gfx] [PATCH] drm/i915/skl: While sanitizing cdclock check the SWF18 as well

On 11/02/2015 10:07 PM, Thulasimani, Sivakumar wrote: On 11/2/2015 6:49 PM, Kumar, Shobhit wrote: On 11/02/2015 06:40 PM, Jani Nikula wrote: On Mon, 02 Nov 2015, Shobhit Kumar wrote: SWF18 is set if the display has been intialized by the pre-os. It also gives what

[Intel-gfx] [PATCH v2 01/14] drm/i915: Use passed plane state for sprite planes, v3.

Don't use plane->state directly, use the pointer from commit_plane. Changes since v1: - Fix uses of plane->state->rotation and color key to use the passed state too. - Only pass crtc_state and plane_state to update_plane. Changes since v2: - Rebased. Signed-off-by: Maarten Lankhorst

[Intel-gfx] [PATCH v2 02/14] drm/i915: Extend DSL readout fix to BDW and SKL.

Those platforms have the same bug as haswell, and the same fix applies to them. Signed-off-by: Maarten Lankhorst Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91579 --- drivers/gpu/drm/i915/i915_irq.c | 2 +- 1 file changed, 1 insertion(+), 1

[Intel-gfx] [PATCH v2 14/14] drm/i915/skl: Do not allow scaling when crtc is disabled.

This fixes a warning when the crtc is turned off. In that case fb will be NULL, and crtc_clock will be 0. Because the crtc is no longer active this is not a bug, and shouldn't trigger the WARN_ON. Also remove handling a null crtc_state, with all transitional helpers gone this can no longer

[Intel-gfx] [PATCH v2 08/14] drm/i915: Remove intel_crtc->atomic.disable_ips.

This is already handled in pre_disable_primary, disabling it twice is useless. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 16 +--- drivers/gpu/drm/i915/intel_drv.h | 1 - 2 files changed, 1 insertion(+), 16

[Intel-gfx] [PATCH v2 11/14] drm/i915: Remove some post-commit members from intel_crtc->atomic.

fb_bits is useful to have in the crtc_state for cs flips later on, so keep it alive there. The other stuff can be calculated in post_plane_update, and aren't useful elsewhere. Currently there's a loop in post_plane_update, this should disappear with the changes to atomic wm's. At that point only

[Intel-gfx] [PATCH v2 00/14] Kill off intel_crtc->atomic, rework.

After fixing up some earlier patches it turns out I had to rework the rest and improved the individual patches. There were some changes in upstream, which meant I had to redo most of them. The order of patches is slightly changed, the update watermark comes before killing off wait_vblank because

[Intel-gfx] [PATCH v2 03/14] drm/i915: Do not acquire crtc state to check clock during modeset, v2.

Parallel modesets are still not allowed, but this will allow updating a different crtc during a modeset if the clock is not changed. Additionally when all pipes are DPMS off the cdclk will be lowered to the minimum allowed. Changes since v1: - Add dev_priv->active_crtcs for tracking which crtcs

[Intel-gfx] [PATCH v2 07/14] drm/i915: Kill off intel_crtc->atomic.wait_vblank.

By handling this after the atomic helper waits for vblanks there will be one less wait for vblank in the atomic path. Also get rid of the double wait_for_vblank on broadwell, looks like it's a bug doing the vblank wait twice. Signed-off-by: Maarten Lankhorst

[Intel-gfx] [PATCH v2 04/14] drm/i915: Handle cdclk limits on broadwell.

As the comment indicates this can only fail gracefully when called from compute_config. Fortunately this is now what's happening, so the fixme can be removed and the DRM_ERROR downgraded. Signed-off-by: Maarten Lankhorst ---

[Intel-gfx] [PATCH v2 06/14] drm/i915: Update watermark related members in the crtc_state, v2.

This removes another couple of hacks from intel_crtc->atomic, and creates proper atomic state for it. Changes since v1: - Rebase on top of wm changes. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic.c | 2 ++

[Intel-gfx] [PATCH v2 05/14] drm/i915/bxt: Use the bypass frequency if there are no active pipes.

Now that pixel clock is set to 0 when there are no active pipes it's easy to set the bypass frequency for this case. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[Intel-gfx] [PATCH v2 13/14] drm/i915/skl: Update watermarks before the crtc is disabled.

On skylake some of the registers are only writable when the correct power wells are enabled. Because of this watermarks have to be updated before the crtc turns off, or you get unclaimed register read and write warnings. This patch needs to be modified slightly to apply to -fixes. Bugzilla:

[Intel-gfx] [PATCH v2 10/14] drm/i915: Remove update_sprite_watermarks.

Commit 791a32be6eb2 ("drm/i915: Drop intel_update_sprite_watermarks") removes the use of this variable, but forgot to remove it. Cc: Matt Roper Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 6 +-

[Intel-gfx] [PATCH v2 09/14] drm/i915: Remove atomic.pre_disable_primary.

This can be derived from the atomic state in pre_plane_update, which makes it more clear when it's supposed to be called. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 28

[Intel-gfx] [PATCH v8 2/2] drm/dp: Set aux.dev to the drm_connector device, instead of drm_device.

So far, the i915 driver and some other drivers set it to the drm_device, which doesn't allow one to know which DP a given aux channel is related to. Changing this to be the drm_connector provides proper nesting, still allowing one to get the drm_device from it. Some drivers already set it to the

[Intel-gfx] [PATCH v8 1/2] drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers.

This module is heavily based on i2c-dev. Once loaded, it provides one dev node per DP AUX channel, named drm_dp_auxN, where N is an integer. It's possible to know which connector owns this aux channel by looking at the respective sysfs /sys/class/drm_aux_dev/drm_dp_auxN/connector, if the

[Intel-gfx] [PATCH v8 0/2] Add drm_dp_aux chardev support.

This series implement support to a drm_dp_aux chardev that allows reading and writing an arbitrary amount of bytes to arbitrary dpcd register addresses using regular read, write and lseek operations. Rafael Antognolli (2): drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers.

[Intel-gfx] [PATCH] Fix build issue with 15_10 config with amdgpu

From: Jim Bish Signed-off-by: Jim Bish --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c index 0587bb2..15dd6fd 100644 ---

Re: [Intel-gfx] [PATCH] drm/i915: Allow unready gpu to be reset on gen8

> From: Mika Kuoppala [mailto:mika.kuopp...@linux.intel.com] > Chris Wilson writes: > > So you are saying that's there no bugzilla for this... :-p > > Bugzilla fairy might surprise us after a good weekend rest. https://bugs.freedesktop.org/show_bug.cgi?id=92774

[Intel-gfx] Hardlock problems when switching monitor channels and questions (Skylake)

Hi everyone. I've been some hardlock problems when switching from the HDMI connection of my monitor (connected to another PC) and the displayport (connected to the problematic PC), several times a week at least. In an effort to narrow down the problem I've been tried looking at drm modeset debug

Re: [Intel-gfx] [PATCH] drm/i915: Fall back to zero vswing/preemph if the sink doesn't like the last good values

On Fri, 30 Oct 2015, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > My Lenovo STM STDP3100 miniDP->VGA dongle doesn't seem to like it when > we try to start link training with non-zero vswing/preemphasis. So when > the initial link training DPCD

Re: [Intel-gfx] [PATCH] drm/i915: add quirk to enable backlight on Dell Chromebook 11 (2015)

On Fri, 30 Oct 2015, Clint Taylor wrote: > On 10/30/2015 05:50 AM, Jani Nikula wrote: >> Reported-by: Keith Webb >> Suggested-by: Keith Webb >> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=106671 >> Signed-off-by: Jani

Re: [Intel-gfx] [PATCH i-g-t 1/8] kms_force_connector: use comparison macros to make debug output clearer

On 2 November 2015 at 11:48, Thomas Wood wrote: > Signed-off-by: Thomas Wood > --- > tests/kms_force_connector.c | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/tests/kms_force_connector.c

[Intel-gfx] [PATCH i-g-t 1/5] tests/kms_force_connector: free the display struct when no longer needed

Signed-off-by: Thomas Wood --- tests/kms_force_connector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index 7485ca8..f48b187 100644 --- a/tests/kms_force_connector.c +++

[Intel-gfx] [PATCH i-g-t 3/5] tests/kms_force_connector: skip if the required connector is connected

Signed-off-by: Thomas Wood --- tests/kms_force_connector.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index f48b187..1e5ec6f 100644 --- a/tests/kms_force_connector.c +++ b/tests/kms_force_connector.c @@

Re: [Intel-gfx] [PATCH] drm/i915/skl: While sanitizing cdclock check the SWF18 as well

On 11/2/2015 6:49 PM, Kumar, Shobhit wrote: On 11/02/2015 06:40 PM, Jani Nikula wrote: On Mon, 02 Nov 2015, Shobhit Kumar wrote: SWF18 is set if the display has been intialized by the pre-os. It also gives what configuration is enabled on which pipe. The DPLL and

Re: [Intel-gfx] [PATCH] drm: Add aux plane verification in addFB2

On 11/2/2015 3:20 PM, Vandana Kannan wrote: For render compression, userspace passes aux stride and offset values as an additional entry in the fb structure. This should not be treated as garbage and discarded as data belonging to no plane. This patch introduces a check related to AUX plane to

[Intel-gfx] [PATCH i-g-t 5/5] tests/kms_force_connector: use comparison macros

Use the comparison macros to make debug output clearer. v2: fix incorrect comparison Signed-off-by: Thomas Wood --- tests/kms_force_connector.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/tests/kms_force_connector.c

[Intel-gfx] [PATCH i-g-t 4/5] tests/kms_force_connector: add an option to reset connector force states

Signed-off-by: Thomas Wood --- tests/kms_force_connector.c | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index 1e5ec6f..2cb149a 100644 ---

[Intel-gfx] [PATCH i-g-t 2/5] lib: add documentation for igt_display_init/fini

Signed-off-by: Thomas Wood --- lib/igt_kms.c | 16 1 file changed, 16 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 51d735d..878e1fb 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -962,6 +962,15 @@ static int get_drm_plane_type(int

Re: [Intel-gfx] [PATCH] RFC drm/i915: Slaughter the thundering i915_wait_request herd

On Mon, Nov 02, 2015 at 03:28:22PM +, Chris Wilson wrote: > That should keep the worker alive for a further 10 jiffies, hopefully > long enough for the next wait to occur. The cost is that it keeps the > interrupt asserted (and to avoid that requires a little rearrangment and > probably a

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Make prepare_plane_fb fully interruptible."

Hey, Op 30-10-15 om 22:06 schreef ville.syrj...@linux.intel.com: > From: Ville Syrjälä > > This reverts commit b26a6b35581c84124bd78b68cc02d171fbd572c9. > > commit b26a6b35581c ("drm/i915: Make prepare_plane_fb fully interruptible.") > breaks GPU reset on gen3/4

Re: [Intel-gfx] [PATCH 1/1] drm/i915/dma: enforce pr_ consistency

On Sat, 31 Oct 2015, Ioan-Adrian Ratiu wrote: > One branch of the if clause uses pr_info, the other pr_err; change > the 'false' branch to also use pr_info. This minor oversight has gone > unfixed since the initial vga_switcheroo implementation in 6a9ee8af. > > Signed-off-by:

Re: [Intel-gfx] [PATCH] igt/kms_rotation_crc: Add a subtest to validate Y-tiled obj + Y fb modifier (v5)

On 31/10/15 01:45, Vivek Kasireddy wrote: Hi Tvrtko, On Fri, 30 Oct 2015 10:22:08 + Tvrtko Ursulin wrote: On 30/10/15 01:44, Vivek Kasireddy wrote: The main goal of this subtest is to trigger the following warning in the function

Re: [Intel-gfx] [PATCH] drm/i915: make A0 wa's applied to A1

Tim Gore  Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > Vetter > Sent: Friday, October 30, 2015 4:11 PM > To: Gore, Tim > Cc: intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH] RFC drm/i915: Slaughter the thundering i915_wait_request herd

On Mon, Nov 02, 2015 at 05:39:54AM +, Gong, Zhipeng wrote: > Chris- > > The patch cannot be applied on the latest drm-intel-nightly directly. > I modified it a little bit to make it applied. > The patch can help much in HSW, but a little bit in BDW. > The test is to transcode 26 streams,

[Intel-gfx] [PATCH] drm: Add aux plane verification in addFB2

For render compression, userspace passes aux stride and offset values as an additional entry in the fb structure. This should not be treated as garbage and discarded as data belonging to no plane. This patch introduces a check related to AUX plane to support the scenario of render compression.

Re: [Intel-gfx] [PATCH 19/26] drm/i915: move adjusted_mode checks from fbc_update to fbc_enable

Op 29-10-15 om 18:58 schreef Zanoni, Paulo R: > Em Qui, 2015-10-29 às 13:59 +0100, Maarten Lankhorst escreveu: >> Op 27-10-15 om 17:50 schreef Paulo Zanoni: >>> These things can't change without a full modeset. >> False! Fastset can update parameters too. Although I don't think it >> currently

[Intel-gfx] [PATCH] drm/i915: Allow unready gpu to be reset on gen8

Gen9 has had demonstrated cases where forcing a not ready gpu into reset has caused system hang [1]. Gen8 has never to this date demonstrated such behaviour. In our CI tests there have been two cases of bsw ending in a state where it claims it is not ready for reset, based on reset request,

Re: [Intel-gfx] [PATCH] RFC drm/i915: Slaughter the thundering i915_wait_request herd

On Mon, Nov 02, 2015 at 05:39:54AM +, Gong, Zhipeng wrote: > Chris- > > The patch cannot be applied on the latest drm-intel-nightly directly. > I modified it a little bit to make it applied. > The patch can help much in HSW, but a little bit in BDW. > The test is to transcode 26 streams,

[Intel-gfx] skylake + drm-next - warn city

Just booted drm-next on a Skylake laptop that happened to be on my desk for a few days. I wasn't impressed. I'm very disappointed. Doesn't anyone have any pride in the code they write anymore. Initially the previous sentence had a lot of curse words and was Linus like in it's stature, but I've

Re: [Intel-gfx] [PATCH] RFC drm/i915: Slaughter the thundering i915_wait_request herd

On Mon, Nov 02, 2015 at 11:26:29AM +, Gong, Zhipeng wrote: > > -Original Message- > > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > > Sent: Monday, November 02, 2015 5:59 PM > > To: Gong, Zhipeng > > Cc: intel-gfx@lists.freedesktop.org; Rogozhkin, Dmitry V > > Subject: Re:

Re: [Intel-gfx] [PATCH] RFC drm/i915: Slaughter the thundering i915_wait_request herd

Yeah, very likely. I wonder, how easy is to negotiate issue with inter-ring synchronization on BDW in the expectation of KMD Scheduler from John Harrison? -Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Monday, November 2, 2015 12:53 PM To: Gong, Zhipeng

Re: [Intel-gfx] [PATCH v3] drm/i915: Add extra plane information in debugfs.

Op 27-10-15 om 16:58 schreef Robert Fekete: > Extends i915_display_info so that for each active crtc also print > all planes associated with the pipe. This patch shows information > about each plane wrt format, size, position, rotation, and scaling. > This is very useful when debugging user space

[Intel-gfx] [PATCH] CDCLOCK Sanitization continued for SKL

The cdclock sanitization patch reviewed and merged at - http://patchwork.freedesktop.org/patch/msgid/1445344992-14658-1-git-send-email-shobhit.ku...@intel.com made the assumptions that DPLL should not be enabled when pre-os does not enable display and if it does then verify that the cdclock is

Re: [Intel-gfx] [PATCH] RFC drm/i915: Slaughter the thundering i915_wait_request herd

> -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Monday, November 02, 2015 5:59 PM > To: Gong, Zhipeng > Cc: intel-gfx@lists.freedesktop.org; Rogozhkin, Dmitry V > Subject: Re: [PATCH] RFC drm/i915: Slaughter the thundering > i915_wait_request herd > >

Re: [Intel-gfx] [PATCH] drm/i915: make A0 wa's applied to A1

On Mon, 02 Nov 2015, "Gore, Tim" wrote: >> -Original Message- >> From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel >> Vetter >> Sent: Friday, October 30, 2015 4:11 PM >> To: Gore, Tim >> Cc: intel-gfx@lists.freedesktop.org >> Subject: Re:

[Intel-gfx] [PATCH] drm/i915/skl: While sanitizing cdclock check the SWF18 as well

SWF18 is set if the display has been intialized by the pre-os. It also gives what configuration is enabled on which pipe. The DPLL and CDCLK verification checks can fail as the pre-os does initialize the DPLL for Audio codec initialization. So fisrt check if SWF18 is set and then follow through

[Intel-gfx] [PATCH i-g-t 7/8] lib: add PIPE_ANY to the pipe enum

This avoids compiler warnings about invalid enum values. Signed-off-by: Thomas Wood --- lib/igt_kms.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/lib/igt_kms.h b/lib/igt_kms.h index 09c08aa..965c47c 100644 --- a/lib/igt_kms.h +++

[Intel-gfx] [PATCH i-g-t 1/8] kms_force_connector: use comparison macros to make debug output clearer

Signed-off-by: Thomas Wood --- tests/kms_force_connector.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c index 7485ca8..4ba1e0b 100644 --- a/tests/kms_force_connector.c +++

[Intel-gfx] [PATCH i-g-t 3/8] Add missing noreturn attribute to various functions

Signed-off-by: Thomas Wood --- debugger/eudb.c | 2 +- lib/igt_core.c | 2 +- tests/gem_madvise.c | 2 +- tests/pm_rpm.c | 2 +- tests/testdisplay.c | 2 +- tools/intel_display_poller.c | 2 +-

[Intel-gfx] [PATCH i-g-t 5/8] tests: remove duplicate struct member initializers

Signed-off-by: Thomas Wood --- tests/kms_frontbuffer_tracking.c | 1 - tests/pm_lpsp.c | 1 - 2 files changed, 2 deletions(-) diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c index 15707b9..13b91ad 100644 ---

[Intel-gfx] [PATCH i-g-t 4/8] tests: remove unnecessary igt_exit calls

Signed-off-by: Thomas Wood --- tests/gem_render_linear_blits.c | 2 -- tests/gem_render_tiled_blits.c | 2 -- tests/kms_3d.c | 2 -- tests/kms_force_connector.c | 2 -- 4 files changed, 8 deletions(-) diff --git a/tests/gem_render_linear_blits.c

[Intel-gfx] [PATCH i-g-t 8/8] tests/kms_fbc_crc: ensure context is initialized correctly

Initialization was included in commit a976d7e (tests/kms_fbc_crc: refactor context handling code), but won't be executed since it is declared before the first label within a switch statement. kms_fbc_crc.c:178:2: warning: ‘context’ may be used uninitialized in this function

[Intel-gfx] [PATCH i-g-t 2/8] lib: highlight subtest results on terminals

Make subtest results easier to identify by making them bold when the output is a terminal. Signed-off-by: Thomas Wood --- lib/igt_core.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 59127ca..7123455

[Intel-gfx] [PATCH i-g-t 6/8] Fix comparison of unsigned integers

Signed-off-by: Thomas Wood --- benchmarks/gem_exec_reloc.c | 2 -- overlay/gem-interrupts.c| 7 +-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/benchmarks/gem_exec_reloc.c b/benchmarks/gem_exec_reloc.c index 5be482a..2ef6df5 100644 ---

[Intel-gfx] [PATCH] igt/kms_rotation_crc: Add a new subtest to exhaustively test for fence leaks

In this subtest, as a first step, MAX_FENCES+1 number of framebuffers are created backed up by objects that have multiple GGTT views (normal and rotated). Next, we have the i915 driver instantiate a normal view followed by a rotated view. We continue doing the above MAX_FENCES + 1 times. Cc:

Re: [Intel-gfx] [PATCH] drm: Describe the Rotation property bits.

On Mon, Nov 02, 2015 at 03:24:15PM +0100, Robert Fekete wrote: > Adds clarification of the rotation property bits. I.e. rotation is > Counter clockwise and that reflects are applied before any rotation. > > Signed-off-by: Robert Fekete > --- >

[Intel-gfx] [PATCH 6/6] drm/i915: force full detect on sink count change

This patch checks for changes in sink count between short pulse hpds and forces full detect when there is a change. This will allow both detection of hotplug and unplug of panels through dongles that give only short pulse for such events. v2: changed variable type from u8 to bool (Jani)

[Intel-gfx] [PATCH 4/6] drm/i915: Save sink_count for tracking changes to it

Sink count can change between short pulse hpd hence this patch adds a member variable to intel_dp so we can track any changes between short pulse interrupts. Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava

[Intel-gfx] [PATCH 5/6] drm/i915: read sink_count dpcd always

This patch reads sink_count dpcd always and removes its read operation based on values in downstream port dpcd. SINK_COUNT dpcd is not dependent on DOWNSTREAM_PORT_PRESENT dpcd. SINK_COUNT denotes if a display is attached, while DOWNSTREAM_PORT_PRESET indicates how many ports are available in the

[Intel-gfx] [PATCH 1/6] drm/i915: Splitting intel_dp_detect

This patch moves probing for panel, DPCD read etc to another function intel_dp_long_pulse, while intel_dp_detect returns the status as connected or disconnected depending on whether the edid is available or not. This change will be required by further patches in the series to avoid performing

[Intel-gfx] [PATCH 2/6] drm/i915: Cleaning up intel_dp_hpd_pulse

Current DP detection has DPCD operations split across intel_dp_hpd_pulse and intel_dp_detect which contains duplicates as well. Also intel_dp_detect is called during modes enumeration as well which will result in multiple dpcd operations. So this patch tries to solve both these by bringing all

[Intel-gfx] [PATCH 3/6] drm/i915: Splitting intel_dp_check_link_status

The link retraining part when EQ is not correct is retained to intel_dp_check_link_status whereas other operations are handled as part of intel_dp_short_pulse. This change is required to avoid performing all DPCD related operations on performing link retraining. Signed-off-by: Sivakumar

[Intel-gfx] [PATCH 0/6] Fixing sink count related detection over

This patch set cleans up DP detection logic to bring all DPCD operations at one place and to create a clear demarcation between handling of long and short pulses. This simplifies fixing of sink count related detection for DP panels. Patches: 1. First two patches clean up intel_dp_detect and form

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Make prepare_plane_fb fully interruptible."

Hey, Op 30-10-15 om 22:06 schreef ville.syrj...@linux.intel.com: > From: Ville Syrjälä > > This reverts commit b26a6b35581c84124bd78b68cc02d171fbd572c9. > > commit b26a6b35581c ("drm/i915: Make prepare_plane_fb fully interruptible.") > breaks GPU reset on gen3/4

[Intel-gfx] [PATCH 4/4] drm/i915: Add two-stage ILK-style watermark programming (v6)

In addition to calculating final watermarks, let's also pre-calculate a set of intermediate watermark values at atomic check time. These intermediate watermarks are a combination of the watermarks for the old state and the new state; they should satisfy the requirements of both states which means

[Intel-gfx] [PATCH 2/4] drm/i915: Add extra paranoia to ILK watermark calculations

Our low-level watermark calculation functions don't get called when the CRTC is disabled or the relevant plane is invisible, so they should never see a zero htotal or zero bpp. However add some checks to ensure this is true so that we don't wind up dividing by zero if we make a mistake elsewhere

[Intel-gfx] [PATCH 1/4] drm/i915: Convert hsw_compute_linetime_wm to use in-flight state

When watermark calculation was moved up to the atomic check phase, the code was updated to calculate based on in-flight atomic state rather than already-committed state. However the hsw_compute_linetime_wm() didn't get updated and continued to pull values out of the currently-committed CRTC

[Intel-gfx] [PATCH 0/4] Wrap up ILK-style atomic watermarks, try two

Patches #3 and #4 here are the final two patches from the atomic watermark series that was posted here: http://lists.freedesktop.org/archives/intel-gfx/2015-September/076634.html We had to pull those out when Jani reported a BDW boot regression (divide by zero during watermark calculation).

Re: [Intel-gfx] [PATCH] RFC drm/i915: Slaughter the thundering i915_wait_request herd

It seems that there are some gaps in the patch and first patch. Like there is no this line in the first patch. if (req->ring->seqno_barrier) I have tried to apply this patch. And here is the cpu utilization and perf data on BDW CPU util | w/o patch | w/ patch

Re: [Intel-gfx] [PATCH] CDCLOCK Sanitization continued for SKL

On 11/02/2015 05:25 PM, Shobhit Kumar wrote: The cdclock sanitization patch reviewed and merged at - http://patchwork.freedesktop.org/patch/msgid/1445344992-14658-1-git-send-email-shobhit.ku...@intel.com made the assumptions that DPLL should not be enabled when pre-os does not enable display

[Intel-gfx] [PATCH 3/4] drm/i915: Sanitize watermarks after hardware state readout

Although we can do a good job of reading out hardware state, the graphics firmware may have programmed the watermarks in a creative way that doesn't match how i915 would have chosen to program them. We shouldn't trust the firmware's watermark programming, but should rather re-calculate how we

Re: [Intel-gfx] [PATCH] drm/i915/skl: While sanitizing cdclock check the SWF18 as well

On 11/02/2015 11:48 PM, Thulasimani, Sivakumar wrote: On 11/2/2015 11:17 PM, Kumar, Shobhit wrote: On 11/02/2015 10:07 PM, Thulasimani, Sivakumar wrote: On 11/2/2015 6:49 PM, Kumar, Shobhit wrote: On 11/02/2015 06:40 PM, Jani Nikula wrote: On Mon, 02 Nov 2015, Shobhit Kumar