Re: [Intel-gfx] [PATCH RFC v3] drm: Add a new connector atomic property for link status

On Wed, Nov 23, 2016 at 11:28:21PM -0800, Manasi Navare wrote: > This is RFC patch for adding a connector link-status property > and making it atomic by adding it to the drm_connector_state. > This is to make sure its wired properly in drm_atomic_connector_set_property > and

Re: [Intel-gfx] [PATCH] drm/i915: Move the release of PT page to the upper caller

On Wed, Nov 23, 2016 at 07:43:21AM +, Tian, Kevin wrote: > It's also the style how CPU page table is managed... But it is not the style of how the GPU page table behaves, which is what the code expects. My only concern here is if the fact that the page is not idle has further rammifactions.

[Intel-gfx] [PATCH RFC v3] drm: Add a new connector atomic property for link status

This is RFC patch for adding a connector link-status property and making it atomic by adding it to the drm_connector_state. This is to make sure its wired properly in drm_atomic_connector_set_property and drm_atomic_connector_get_property functions. v3: * Fixed a build error (Jani Saarinen) v2: *

Re: [Intel-gfx] [PATCH] drm/i915: Always load guc by default.

On Wed, Nov 23, 2016 at 04:52:38PM -0800, Anusha Srivatsa wrote: > Remove the enable_guc_loading parameter. Load the GuC on > plaforms that have GuC. All issues we found so far are related > to GuC features like the command submission, but no bug is related > to the guc loading itself. > > This

Re: [Intel-gfx] [igvt-g-dev] [bug report] drm/i915/gvt: fix deadlock in workload_thread

Thanks Dan for pointing this code error. Zhenyu, your change looks fine to me. -Original Message- From: Zhenyu Wang [mailto:zhen...@linux.intel.com] Sent: Thursday, November 24, 2016 10:41 To: Dan Carpenter Cc: Zhang, Pei ;

[Intel-gfx] ✓ Fi.CI.BAT: success for GEN-9 Arbitrated Bandwidth WM WA's & IPC (rev2)

== Series Details == Series: GEN-9 Arbitrated Bandwidth WM WA's & IPC (rev2) URL : https://patchwork.freedesktop.org/series/15562/ State : success == Summary == Series 15562v2 GEN-9 Arbitrated Bandwidth WM WA's & IPC https://patchwork.freedesktop.org/api/1.0/series/15562/revisions/2/mbox/

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Add a new connector atomic property for link status (rev3)

== Series Details == Series: drm: Add a new connector atomic property for link status (rev3) URL : https://patchwork.freedesktop.org/series/15781/ State : failure == Summary == CC drivers/acpi/acpica/utpredef.o CONMK drivers/tty/vt/consolemap_deftbl.c CC

[Intel-gfx] [PATCH v6 4/8] drm/i915/bxt: Enable IPC support

This patch adds IPC support for platforms. This patch enables IPC only for BXT/KBL platform as for SKL recommendation is to keep is disabled. IPC (Isochronous Priority Control) is the hardware feature, which dynamically controles the memory read priority of Display. When IPC is enabled, plane

[Intel-gfx] [PATCH v6 2/8] drm/i915/bxt: IPC WA for Broxton

If IPC is enabled in BXT, display underruns are observed. WA: The Line Time programmed in the WM_LINETIME register should be half of the actual calculated Line Time. Programmed Line Time = 1/2*Calculated Line Time Signed-off-by: Mahesh Kumar Reviewed-by: Paulo Zanoni

[Intel-gfx] [PATCH v6 5/8] drm/i915/skl+: change WM calc to fixed point 16.16

This patch changes Watermak calculation to fixed point calculation. Problem with current calculation is during plane_blocks_per_line calculation we divide intermediate blocks with min_scanlines and takes floor of the result because of integer operation. hence we end-up assigning less blocks than

[Intel-gfx] [PATCH v6 6/8] drm/i915: Add intel_atomic_get_existing_crtc_state function

This patch Adds a function to extract intel_crtc_state from the atomic_state, if not available it returns NULL. Signed-off-by: Mahesh Kumar Reviewed-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_drv.h | 14 ++ 1 file changed, 14

[Intel-gfx] [PATCH v6 8/8] drm/i915/gen9: WM memory bandwidth related workaround

This patch implemnets Workariunds related to display arbitrated memory bandwidth. These WA are applicabe for all gen-9 based platforms. Changes since v1: - Rebase on top of Paulo's patch series Changes since v2: - Address review comments - Rebase/rework as per other patch changes in series

[Intel-gfx] [PATCH v6 3/8] drm/i915/kbl: IPC workaround for kabylake

IPC (Isoch Priority Control) may cause underflows. KBL WA: When IPC is enabled, watermark latency values must be increased by 4us across all levels. This brings level 0 up to 6us. Signed-off-by: Mahesh Kumar Reviewed-by: Paulo Zanoni ---

[Intel-gfx] [PATCH v6 1/8] drm/i915/skl: Add variables to check x_tile and y_tile

This patch adds variable to check for X_tiled & y_tiled planes, instead of always checking against framebuffer-modifiers. Changes: - Created separate patch as per Paulo's comment - Added x_tiled variable as well Changes since V2: - Incorporate Paulo's comments - Rebase Signed-off-by: Mahesh

[Intel-gfx] [PATCH v6 7/8] drm/i915: Decode system memory bandwidth

This patch adds support to decode system memory bandwidth which will be used for arbitrated display memory percentage calculation in GEN9 based system. Changes from v1: - Address comments from Paulo - implement decode function for SKL/KBL also Changes from v2: - Rewrite the code as per HW team

[Intel-gfx] [PATCH v5 0/8] GEN-9 Arbitrated Bandwidth WM WA's & IPC

This series implements following set of functionality Implement IPC WA's for Broxton/KBL Enable IPC in supported platforms Convert WM calculation to fixed point calculation Calculation of System memory Bandwidth for SKL/KBL/BXT Implementation of Arbitrated

Re: [Intel-gfx] [PATCH v2] drm/i915: Pass dev_priv to intel_setup_outputs()

Hi Ander, [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on next-20161123] [cannot apply to v4.9-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ander

Re: [Intel-gfx] [igvt-g-dev] [bug report] drm/i915/gvt: fix deadlock in workload_thread

On 2016.11.24 01:17:06 +0300, Dan Carpenter wrote: > Hello Pei Zhang, > > The patch 90d27a1b180e: "drm/i915/gvt: fix deadlock in > workload_thread" from Nov 14, 2016, leads to the following static > checker warning: > > drivers/gpu/drm/i915/gvt/scheduler.c:217 dispatch_workload() >

[Intel-gfx] [PATCH RFC v2] drm: Add a new connector atomic property for link status

This is RFC patch for adding a connector link-status property and making it atomic by adding it to the drm_connector_state. This is to make sure its wired properly in drm_atomic_connector_set_property and drm_atomic_connector_get_property functions. v2: * Removed connector->link_status (Daniel

Re: [Intel-gfx] [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams

On Wed, Nov 23, 2016 at 02:27:43PM -0800, Anusha Srivatsa wrote: > From: Peter Antoine > > This patch will allow for getparams to return the status of the HuC. > As the HuC has to be validated by the GuC this patch uses the validated > status to show when the HuC is

[Intel-gfx] [PATCH] drm/i915: Always load guc by default.

Remove the enable_guc_loading parameter. Load the GuC on plaforms that have GuC. All issues we found so far are related to GuC features like the command submission, but no bug is related to the guc loading itself. This addresses the case when we need GuC loaded even with no GuC feature in use,

[Intel-gfx] [PATCH] aubdump: Fix intel_aubdump -o

This looks like a mistake in 1f43677f895a88ae880b35f9b18cc7e6869d0ca6. --- tools/intel_aubdump.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) This code still looks really weird. ${foo:bar} means "the value of $foo, unless it's unset/empty, in which case 'bar'. But if $file is

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: kick out cmd_parser specific structs from i915_drv.h

== Series Details == Series: drm/i915: kick out cmd_parser specific structs from i915_drv.h URL : https://patchwork.freedesktop.org/series/15854/ State : success == Summary == Series 15854v1 drm/i915: kick out cmd_parser specific structs from i915_drv.h

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Add support for DP link training compliance

On Wed, Nov 23, 2016 at 03:07:30PM +0200, Jani Nikula wrote: > On Tue, 22 Nov 2016, Manasi Navare wrote: > > This patch adds support to handle automated DP compliance > > link training test requests. This patch has been tested with > > Unigraf DPR-120 DP Compliance

[Intel-gfx] [PATCH] drm/i915: kick out cmd_parser specific structs from i915_drv.h

No sense in keeping the cmd_descriptor and cmd_table structs in i915_drv.h, now that they are no longer referenced externally. Cc: Chris Wilson Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_cmd_parser.c | 96

[Intel-gfx] ✓ Fi.CI.BAT: success for HuC Loading Patches

== Series Details == Series: HuC Loading Patches URL : https://patchwork.freedesktop.org/series/15850/ State : success == Summary == Series 15850v1 HuC Loading Patches https://patchwork.freedesktop.org/api/1.0/series/15850/revisions/1/mbox/ fi-bdw-5557u total:244 pass:229 dwarn:0

[Intel-gfx] [PATCH 7/8] drm/i915/huc: Support HuC authentication

From: Peter Antoine The HuC authentication is done by host2guc call. The HuC RSA keys are sent to GuC for authentication. v2: rebased on top of drm-intel-nightly. changed name format and upped version 1.7. v3: rebased on top of drm-intel-nightly. v4: changed

[Intel-gfx] [PATCH 2/8] drm/i915/huc: Unified css_header struct for GuC and HuC

From: Peter Antoine HuC firmware css header has almost exactly same definition as GuC firmware except for the sw_version. Also, add a new member fw_type into intel_uc_fw to indicate what kind of fw it is. So, the loader will pull right sw_version from header. v2:

[Intel-gfx] [PATCH 6/8] drm/i915/huc: Add debugfs for HuC loading status check

From: Peter Antoine Add debugfs entry for HuC loading status check. v2: rebase on-top of drm-intel-nightly. v3: rebased again. v7: rebased. v8: rebased. v9: rebased. v10: rebased. Tested-by: Xiang Haihao Signed-off-by: Anusha Srivatsa

[Intel-gfx] [PATCH 4/8] drm/i915/huc: Add BXT HuC Loading Support

This patch adds the HuC Loading for the BXT by using the updated file construction. Version 1.7 of the HuC firmware. v2: rebased. Cc: Jeff Mcgee Signed-off-by: Anusha Srivatsa Reviewed-by: Jeff McGee ---

[Intel-gfx] [PATCH 3/8] drm/i915/huc: Add HuC fw loading support

From: Peter Antoine The HuC loading process is similar to GuC. The intel_uc_fw_fetch() is used for both cases. HuC loading needs to be before GuC loading. The WOPCM setting must be done early before loading any of them. v2: rebased on-top of drm-intel-nightly.

[Intel-gfx] [PATCH 5/8] drm/i915/HuC: Add KBL huC loading Support

This patch adds the support to load HuC on KBL Version 2.0 v2: rebased. Cc: Jeff Mcgee Signed-off-by: Anusha Srivatsa Reviewed-by: Jeff McGee --- drivers/gpu/drm/i915/intel_huc_loader.c | 16 1 file

[Intel-gfx] [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams

From: Peter Antoine This patch will allow for getparams to return the status of the HuC. As the HuC has to be validated by the GuC this patch uses the validated status to show when the HuC is loaded and ready for use. You cannot use the loaded status as with the GuC as

[Intel-gfx] [PATCH 0/8] HuC Loading Patches

These patches add HuC loading support. The userspace patches that check for a fully loaded HuC firmware and use it can be found at: https://lists.freedesktop.org/archives/libva/2016-September/004554.html https://lists.freedesktop.org/archives/libva/2016-September/004555.html v2: rebased. v3:

[Intel-gfx] [PATCH 1/8] drm/i915/guc: Make the GuC fw loading helper functions general. Always initialize action_lock

From: Peter Antoine Rename some of the GuC fw loading code to make them more general. We will utilise them for HuC loading as well. s/intel_guc_fw/intel_uc_fw/g s/GUC_FIRMWARE/UC_FIRMWARE/g Struct intel_guc_fw is renamed to intel_uc_fw. Prefix of tts members,

[Intel-gfx] [bug report] drm/i915/gvt: fix deadlock in workload_thread

Hello Pei Zhang, The patch 90d27a1b180e: "drm/i915/gvt: fix deadlock in workload_thread" from Nov 14, 2016, leads to the following static checker warning: drivers/gpu/drm/i915/gvt/scheduler.c:217 dispatch_workload() warn: inconsistent returns 'mutex:_priv->drm.struct_mutex'.

Re: [Intel-gfx] [PATCH 0/3] drm/i915: atomic_cdclk_freq fixes

On Mon, Nov 14, 2016 at 06:35:08PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > My little fix for populating intel_state->cdclk with > dev_priv->atomic_cdclk_freq became a little meatier after I realized > that we really need to protect it

Re: [Intel-gfx] [PATCH] drm/i915/bxt: Correct dual-link MIPI port control.

On Tue, Nov 22, 2016 at 03:00:14PM +0200, Ville Syrjälä wrote: > On Mon, Nov 21, 2016 at 02:24:06PM -0800, Bob Paauwe wrote: > > For BXT, there is only one bit that enables/disables dual-link mode > > and not different bits depending on which pipe is being used. > > > > Signed-off-by: Bob Paauwe

Re: [Intel-gfx] [PATCH v2 0/9] drm/i915: Add a per-pipe plane identifier enum (v2)

On Tue, Nov 22, 2016 at 06:01:55PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > I ended up tweaking quite a few of the patches (and even adding a new one) > based on Paulo's review, so figured I'd repost the entire thing. > > I didn't do

Re: [Intel-gfx] [PATCH] drm/i915: Make skl_write_{plane, cursor}_wm() static

On Wed, Nov 23, 2016 at 11:15:45AM +0100, Maarten Lankhorst wrote: > Op 22-11-16 om 21:28 schreef Lyude Paul: > > Reviewed-by: Lyude > > > > On Tue, 2016-11-22 at 22:21 +0200, ville.syrj...@linux.intel.com wrote: > >> From: Ville Syrjälä > >> > >>

Re: [Intel-gfx] [PATCH RFC] drm: Add a new connector atomic property for link status

On Wed, Nov 23, 2016 at 11:00:59AM +0100, Daniel Vetter wrote: > On Tue, Nov 22, 2016 at 05:30:21PM -0800, Manasi Navare wrote: > > This is RFC patch for adding a connector link-status property > > and making it atomic by adding it to the drm_connector_state. > > This is to make sure its wired

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make GPU pages movable

On Wed, 23 Nov 2016, Daniel Vetter wrote: > On Tue, Nov 22, 2016 at 09:26:11PM -0800, Hugh Dickins wrote: > > On Tue, 22 Nov 2016, Matthew Auld wrote: > > > On 9 November 2016 at 18:36, Hugh Dickins wrote: > > > > On Wed, 9 Nov 2016, Daniel Vetter wrote: > > > >> > > > >> Hi all

Re: [Intel-gfx] [PATCH 3/5] drm/i915/bxt: Added _DSM call to set HPD_CTL.

On Wed, Nov 23, 2016 at 09:48:25PM +0530, Animesh Manna wrote: > _DSM is added to program HPD_CTL(0x1094) register > of PMC from i915 driver which will be called > based on driver feature flag. PMC hpd control register > programming will enable PMC to get hpd interrupt > during dc9. > >

[Intel-gfx] ✗ Fi.CI.BAT: warning for HPD support during suspend for BXT/APL.

== Series Details == Series: HPD support during suspend for BXT/APL. URL : https://patchwork.freedesktop.org/series/15833/ State : warning == Summary == Series 15833v1 HPD support during suspend for BXT/APL. https://patchwork.freedesktop.org/api/1.0/series/15833/revisions/1/mbox/ Test

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: Wrap 64bit divides in do_div() (rev3)

== Series Details == Series: drm/i915/perf: Wrap 64bit divides in do_div() (rev3) URL : https://patchwork.freedesktop.org/series/15769/ State : success == Summary == Series 15769v3 drm/i915/perf: Wrap 64bit divides in do_div()

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Enable HPD interrupts with master ctl interrupt

On Wed, Nov 23, 2016 at 09:48:27PM +0530, Animesh Manna wrote: > While suspending the device hpd related interrupts are enabled > to get the interrupt when device is in suspend state. > > Though display is in DC9 but system can be in S0 or S0i3 state. > Hot plug during S0 state will generate

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Enable HPD interrupts with master ctl interrupt

On Wed, 2016-11-23 at 21:48 +0530, Animesh Manna wrote: > While suspending the device hpd related interrupts are enabled > to get the interrupt when device is in suspend state. > > Though display is in DC9 but system can be in S0 or S0i3 state. > Hot plug during S0 state will generate

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Pass dev_priv to intel_setup_outputs() (rev2)

== Series Details == Series: drm/i915: Pass dev_priv to intel_setup_outputs() (rev2) URL : https://patchwork.freedesktop.org/series/15820/ State : success == Summary == Series 15820v2 drm/i915: Pass dev_priv to intel_setup_outputs()

Re: [Intel-gfx] [PATCH 1/5] drm/i915/bxt: Corrected the guid for bxt.

On Wed, Nov 23, 2016 at 09:48:23PM +0530, Animesh Manna wrote: > Guid is changed for bxt platform, so corrected the guid for bxt. > > v1: Initial version as RFC. > > v2: Based on review comment from Jani and David, > have kept guid as binary format. > > Signed-off-by: Ananth Krishna R

Re: [Intel-gfx] [i-g-t PATCH v11 2/5] lib: add igt_dummyload

On Wed, Nov 23, 2016 at 05:53:50PM +0200, Abdiel Janulgue wrote: > +static int at_exit_drm_fd = -1; > + > +static void quiescent_gpu_at_exit(int sig) > +{ > + if (at_exit_drm_fd < 0) > + return; > + > + gem_quiescent_gpu(at_exit_drm_fd); > + at_exit_drm_fd = -1; > +} > + >

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/5] drm: Define drm_mm_for_each_node_in_range()

== Series Details == Series: series starting with [1/5] drm: Define drm_mm_for_each_node_in_range() URL : https://patchwork.freedesktop.org/series/15825/ State : warning == Summary == Series 15825v1 Series without cover letter

Re: [Intel-gfx] [PATCH RFC] drm: Add a new connector atomic property for link status

On Wed, Nov 23, 2016 at 4:52 PM, Jani Nikula wrote: >> Take the CDN DP driver in rockchip for example (posted yesterday). >> There's a worker in the driver that is responsible for handling >> hpd/extcon events from the USB-C port. Ideally, this worker should >> just

Re: [Intel-gfx] [PATCH RFC] drm: Add a new connector atomic property for link status

On Wed, Nov 23, 2016 at 10:52 AM, Jani Nikula wrote: > On Wed, 23 Nov 2016, Sean Paul wrote: >> On Wed, Nov 23, 2016 at 10:15 AM, Jani Nikula >> wrote: >>> On Wed, 23 Nov 2016, Sean Paul

[Intel-gfx] [PATCH 0/5] HPD support during suspend for BXT/APL.

Along with below patches sharing some background details/design. - On BXT, Display cannot generate an interrupt when in D3. - Without display in D3, S0ix can be achieved, Power impact will be zero if d3 is blocked. PMCSR for Graphics/Display is irrelevant, as the power management for them is

[Intel-gfx] [PATCH 3/5] drm/i915/bxt: Added _DSM call to set HPD_CTL.

_DSM is added to program HPD_CTL(0x1094) register of PMC from i915 driver which will be called based on driver feature flag. PMC hpd control register programming will enable PMC to get hpd interrupt during dc9. Signed-off-by: Animesh Manna ---

Re: [Intel-gfx] [PATCH RFC] drm: Add a new connector atomic property for link status

On Wed, Nov 23, 2016 at 10:43 AM, Ville Syrjälä wrote: > On Wed, Nov 23, 2016 at 10:32:44AM -0500, Sean Paul wrote: >> On Wed, Nov 23, 2016 at 10:15 AM, Jani Nikula >> wrote: >> > On Wed, 23 Nov 2016, Sean Paul

[Intel-gfx] [PATCH 4/5] drm/i915/bxt: Block D3 during suspend.

For BXT, display engine can not generate interrupt when in D3. On the othen hand S0ix can be achieved without display in D3. So, Display should not put into D3 for HPD to work and will not have any power impact. v1: Initial version as RFC. v2: Based on review comment from David, condition check

[Intel-gfx] [PATCH 5/5] drm/i915: Enable HPD interrupts with master ctl interrupt

While suspending the device hpd related interrupts are enabled to get the interrupt when device is in suspend state. Though display is in DC9 but system can be in S0 or S0i3 state. Hot plug during S0 state will generate de_port_interrupt but if system is in S0i3 state then display driver will get

[Intel-gfx] [PATCH 1/5] drm/i915/bxt: Corrected the guid for bxt.

Guid is changed for bxt platform, so corrected the guid for bxt. v1: Initial version as RFC. v2: Based on review comment from Jani and David, have kept guid as binary format. Signed-off-by: Ananth Krishna R Signed-off-by: Bharath K Veera

[Intel-gfx] [PATCH 2/5] drm/i915/bxt: VBT changes for hpd as wakeup feature

To support hpd during sleep a new feature flag is added in vbt and also in dev_priv for enabling/disabling inside driver. By default this feature will be disabled and based on oem request this feature can be enabled by changing vbt feature flag. v1: Initial version as RFC. v2: Based on review

[Intel-gfx] [i-g-t PATCH v11 2/5] lib: add igt_dummyload

A lot of igt testcases need some GPU workload to make sure a race window is big enough. Unfortunately having a fixed amount of workload leads to spurious test failures or overly long runtimes on some fast/slow platforms. This library contains functionality to submit GPU workloads that should

Re: [Intel-gfx] [PATCH RFC] drm: Add a new connector atomic property for link status

On Wed, 23 Nov 2016, Sean Paul wrote: > On Wed, Nov 23, 2016 at 10:15 AM, Jani Nikula > wrote: >> On Wed, 23 Nov 2016, Sean Paul wrote: >>> On Wed, Nov 23, 2016 at 3:09 AM, Daniel Vetter wrote: On

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs

== Series Details == Series: series starting with [1/3] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs URL : https://patchwork.freedesktop.org/series/15823/ State : success == Summary == Series 15823v1 Series without cover letter

Re: [Intel-gfx] [PATCH RFC] drm: Add a new connector atomic property for link status

On Wed, Nov 23, 2016 at 10:32:44AM -0500, Sean Paul wrote: > On Wed, Nov 23, 2016 at 10:15 AM, Jani Nikula > wrote: > > On Wed, 23 Nov 2016, Sean Paul wrote: > >> On Wed, Nov 23, 2016 at 3:09 AM, Daniel Vetter wrote: > >>> On

Re: [Intel-gfx] [PATCH RFC] drm: Add a new connector atomic property for link status

On Wed, Nov 23, 2016 at 10:15 AM, Jani Nikula wrote: > On Wed, 23 Nov 2016, Sean Paul wrote: >> On Wed, Nov 23, 2016 at 3:09 AM, Daniel Vetter wrote: >>> On Tue, Nov 22, 2016 at 09:27:35PM -0500, Sean Paul wrote: On Tue,

Re: [Intel-gfx] [PATCH v2] drm/i915: Remove all ->config dereferences from intel_hdmi, v2.

On Wed, Nov 23, 2016 at 03:57:00PM +0100, Maarten Lankhorst wrote: > In all cases we can now obtain the relevant crtc_state/conn_state > from the relevant callbacks, which means all the ->config accesses > can be removed and the code cleaned up. > > Changes since v1: > - cstate -> crtc_state > >

Re: [Intel-gfx] [PATCH RFC] drm: Add a new connector atomic property for link status

On Wed, 23 Nov 2016, Sean Paul wrote: > On Wed, Nov 23, 2016 at 3:09 AM, Daniel Vetter wrote: >> On Tue, Nov 22, 2016 at 09:27:35PM -0500, Sean Paul wrote: >>> On Tue, Nov 22, 2016 at 8:30 PM, Manasi Navare >>> wrote: >>> > This

[Intel-gfx] [PATCH v3] drm/i915/perf: Wrap 64bit divides in do_div()

Just a couple of naked 64bit divides causing link errors on 32bit builds, with: ERROR: "__udivdi3" [drivers/gpu/drm/i915/i915.ko] undefined! v2: do_div() is only u64/u32, we need a u32/u64! v3: div_u64() == u64/u32, div64_u64() == u64/u64 Reported-by: kbuild test robot

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Add support for DP Video pattern compliance tests

On Wed, Nov 23, 2016 at 03:17:53PM +0100, Daniel Vetter wrote: > On Wed, Nov 23, 2016 at 03:58:34PM +0200, Jani Nikula wrote: > > On Wed, 23 Nov 2016, Ville Syrjälä wrote: > > > On Wed, Nov 23, 2016 at 03:37:24PM +0200, Jani Nikula wrote: > > >> On Tue, 22 Nov 2016,

[Intel-gfx] [PATCH v2] drm/i915: Remove all ->config dereferences from intel_hdmi, v2.

In all cases we can now obtain the relevant crtc_state/conn_state from the relevant callbacks, which means all the ->config accesses can be removed and the code cleaned up. Changes since v1: - cstate -> crtc_state Signed-off-by: Maarten Lankhorst --- diff

Re: [Intel-gfx] [PATCH RFC] drm: Add a new connector atomic property for link status

On Wed, Nov 23, 2016 at 3:09 AM, Daniel Vetter wrote: > On Tue, Nov 22, 2016 at 09:27:35PM -0500, Sean Paul wrote: >> On Tue, Nov 22, 2016 at 8:30 PM, Manasi Navare >> wrote: >> > This is RFC patch for adding a connector link-status property >> > and

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Remove unused intel_guc_fw struct member

On 23/11/2016 10:45, Patchwork wrote: == Series Details == Series: drm/i915/guc: Remove unused intel_guc_fw struct member URL : https://patchwork.freedesktop.org/series/15803/ State : success == Summary == Series 15803v1 drm/i915/guc: Remove unused intel_guc_fw struct member

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: i915_gem_alloc_context_obj can be static (rev2)

On 23/11/2016 11:15, Patchwork wrote: == Series Details == Series: drm/i915: i915_gem_alloc_context_obj can be static (rev2) URL : https://patchwork.freedesktop.org/series/15804/ State : success == Summary == Series 15804v2 drm/i915: i915_gem_alloc_context_obj can be static

[Intel-gfx] [PATCH v2] drm/i915: Pass dev_priv to intel_setup_outputs()

Pass dev_priv to intel_setup_outputs() and functions called by it, since those are all intel i915 specific functions. Also, in the majority of the functions dev_priv is used more often than dev. In the rare cases where there are a few calls back into drm core, a local dev variable was added. v2:

Re: [Intel-gfx] [PATCH 1/3] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs

On Wed, 23 Nov 2016, Chris Wilson wrote: > +#define drm_fb_helper_for_each_connector(fbh, i__) \ > + for (({lockdep_assert_held(&(fbh)->dev->mode_config.mutex); 1;}), \ > + i__ = 0; i__ < (fbh)->connector_count; i__++) No comments on the substance, but just

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Add support for DP Video pattern compliance tests

On Wed, Nov 23, 2016 at 03:58:34PM +0200, Jani Nikula wrote: > On Wed, 23 Nov 2016, Ville Syrjälä wrote: > > On Wed, Nov 23, 2016 at 03:37:24PM +0200, Jani Nikula wrote: > >> On Tue, 22 Nov 2016, Manasi Navare wrote: > >> > The

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Moving scaler numbers to runtime init (rev3)

== Series Details == Series: drm/i915: Moving scaler numbers to runtime init (rev3) URL : https://patchwork.freedesktop.org/series/15726/ State : success == Summary == Series 15726v3 drm/i915: Moving scaler numbers to runtime init

[Intel-gfx] [PATCH 5/5] drm/i915: Tidy i915_gem_valid_gtt_space()

We can replace a couple of tests with an assertion that the passed in node is already allocated (as matches the existing call convention) and by a small bit of refactoring we can bring the line lengths to under 80cols. Signed-off-by: Chris Wilson ---

[Intel-gfx] [PATCH 4/5] drm/i915: Fix i915_gem_evict_for_vma (soft-pinning)

Soft-pinning depends upon being able to check for availabilty of an interval and evict overlapping object from a drm_mm range manager very quickly. Currently it uses a linear list, and so performance is dire and not suitable as a general replacement. Worse, the current code will oops if it tries

[Intel-gfx] [PATCH 1/5] drm: Define drm_mm_for_each_node_in_range()

Some clients would like to iterate over every node within a certain range. Make a nice little macro for them to hide the mixing of the rbtree search and linear walk. v2: Blurb Signed-off-by: Chris Wilson Cc: Daniel Vetter Cc:

[Intel-gfx] [PATCH 3/5] drm/i915: Mark all non-vma being inserted into the address spaces

We need to distinguish between full i915_vma structs and simple drm_mm_nodes when considering eviction (i.e. we must be careful not to treat a mere drm_mm_node as a much larger i915_vma causing memory corruption, if we are lucky). To do this, color these not-a-vma with -1 (I915_COLOR_UNEVICTABLE).

[Intel-gfx] [PATCH 2/5] drm: Check against color expansion in drm_mm_reserve_node()

Use the color_adjust callback when reserving a node to check if inserting a node into this hole requires any additional space, and so if that space then conflicts with an existing allocation. Signed-off-by: Chris Wilson Cc: Daniel Vetter Cc:

[Intel-gfx] [PATCH 2/3] drm: Pull together probe + setup for drm_fb_helper

drm_fb_helper_probe_connector_modes() is always called before drm_setup_crtcs(), so just move the call into drm_setup_crtcs for a small bit of code compaction. Signed-off-by: Chris Wilson --- drivers/gpu/drm/drm_fb_helper.c | 37 +++-- 1

[Intel-gfx] [PATCH 3/3] drm: Protect fb_helper list manipulation with a mutex

Though we only walk the kernel_fb_helper_list inside a panic (or single thread debugging), we still need to protect the list manipulation on creating/removing a framebuffer device in order to prevent list corruption. Signed-off-by: Chris Wilson ---

[Intel-gfx] [PATCH 1/3] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs

The fb_helper->connector_count is modified when a new connector is constructed following a hotplug event (e.g. DP-MST). This causes trouble for drm_setup_crtcs() and friends that assume that fb_helper is constant: [ 1250.872997] BUG: KASAN: slab-out-of-bounds in drm_setup_crtcs+0x320/0xf80 at

Re: [Intel-gfx] [PATCH] drm/i915: Pass dev_priv to intel_setup_outputs()

On Wed, Nov 23, 2016 at 03:48:30PM +0200, Ander Conselvan de Oliveira wrote: > Pass dev_priv to intel_setup_outputs() and functions called by it, since > those are all intel i915 specific functions. Also, in the majority of > the functions dev_priv is used more often than dev. In the rare cases >

Re: [Intel-gfx] [PATCH i-g-t] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

On Tue, 22 Nov 2016, Manasi Navare wrote: > + > +static void get_test_videopattern_data(void) > +{ > + int count = 0; > + uint16_t video_pattern_value[3]; > + char video_pattern_attribute[15]; > + > + if (!test_data_fp) > + fprintf(stderr,

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Add support for DP Video pattern compliance tests

On Wed, 23 Nov 2016, Ville Syrjälä wrote: > On Wed, Nov 23, 2016 at 03:37:24PM +0200, Jani Nikula wrote: >> On Tue, 22 Nov 2016, Manasi Navare wrote: >> > The intel_dp_autotest_video_pattern() function gets invoked through the >> >

Re: [Intel-gfx] [PATCH i-g-t 3/4 v6] tests/drv_module_reload: Convert sh script to C version.

On Wed, Nov 23, 2016 at 02:35:11PM +0200, Marius Vlad wrote: > v5: > - reword gem_info to gem_sanitychecks (Chris Wilson) > - remove subgroups/subtests for gem_exec_store and gem_sanitycheck > (Chris Wilson) > > v4: > - adjust test to make use of lib/igt_kmod > - replaced SW_FINISH with

Re: [Intel-gfx] [PATCH i-g-t 1/4 v6] lib/{igt_sysfs, igt_aux}: Make available to other users kick_fbcon() (unbind_fbcon()), and added helpers to lib/igt_aux, lib/igt_kmod.

On Wed, Nov 23, 2016 at 02:35:09PM +0200, Marius Vlad wrote: > +static void > +igt_show_stat(proc_t *info, const char *fn) > +{ > + static int display = 0; > + > + if (!display) { > + igt_info("%20.20s%11.11s%21.21s%11.11s%10.10s%22.22s%31.31s\n", > +

[Intel-gfx] [PATCH] drm/i915: Pass dev_priv to intel_setup_outputs()

Pass dev_priv to intel_setup_outputs() and functions called by it, since those are all intel i915 specific functions. Also, in the majority of the functions dev_priv is used more often than dev. In the rare cases where there are a few calls back into drm core, a local dev variable was added.

[Intel-gfx] [PATCH] drm/i915: Move number of scalers initialization to runtime init

In future patches, we require greater flexibility in describing the number of scalers available on each CRTC. To ease that transition we move the current assignment to intel_device_info. Scaler structure initialisation is done if scaler is available on the CRTC. Gen9 check is not required as

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Add support for DP Video pattern compliance tests

On Wed, Nov 23, 2016 at 03:37:24PM +0200, Jani Nikula wrote: > On Tue, 22 Nov 2016, Manasi Navare wrote: > > The intel_dp_autotest_video_pattern() function gets invoked through the > > compliance test handler on a HPD short pulse if the test type is > > set to

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Add support for DP Video pattern compliance tests

On Tue, 22 Nov 2016, Manasi Navare wrote: > The intel_dp_autotest_video_pattern() function gets invoked through the > compliance test handler on a HPD short pulse if the test type is > set to DP_TEST_VIDEO_PATTERN. This performs the DPCD registers > reads to read the

Re: [Intel-gfx] [PATCH i-g-t 2/4 v6] lib/igt_gvt: Make use of libkmod helpers and fix reading gvt parameter.

On Wed, Nov 23, 2016 at 02:35:10PM +0200, Marius Vlad wrote: > v2: > - use igt_sysfs_get_boolean() to get gvt status (Chris Wilson) > - do not hard-fail when i915 module could not be loaded/unloaded (Chris > Wilson) > > Signed-off-by: Marius Vlad > --- > lib/igt_gvt.c

Re: [Intel-gfx] [PATCH 4/5] drm: Add definitions for DP compliance Video pattern tests

On Tue, 22 Nov 2016, Manasi Navare wrote: > Cc: dri-de...@lists.freedesktop.org > Cc: Jani Nikula > Cc: Daniel Vetter > Cc: Ville Syrjala > Signed-off-by: Manasi Navare

Re: [Intel-gfx] [PATCH 3/5] Add support for forcing 6 bpc on DP pipes.

On Tue, 22 Nov 2016, Manasi Navare wrote: > From: Jim Bride > > For DP compliance we need to be able to control the output color > type for the pipe associated with the DP port. When a specific DP > compliance test is requested with specific

[Intel-gfx] [PATCH i-g-t 1/2] lib: Check format of framebuffer before SetPlane

Avoid setting a framebuffer in a format that the plane doesn't support, so we have better debug output in IGT and we don't have to dig into dmesg files to find out what's going on. I found this issue when kms_plane_scaling tried to use a cursor plane as a regular one in a Skylake machine with

[Intel-gfx] [PATCH i-g-t 0/2] Improve error report when there are less overlays than expected

Hi, kms_plane_scaling would happily try to use the cursor plane as if it was an overlay, and the first signal of it would be the kernel refusing the SetPlane call because of the pixel format not matching. To improve this situation, we check the format of the framebuffer before calling SetPlane

[Intel-gfx] [PATCH i-g-t 2/2] kms_plane_scaling: Skip if we don't have enough overlays

The test currently assumes that there are two overlay planes available, but that's not generally true and from the error that returns the kernel, it isn't obvious what's going on. Signed-off-by: Tomeu Vizoso --- tests/kms_plane_scaling.c | 4 1 file changed, 4

  1   2   >