Re: [Intel-gfx] [PATCH] drm/i915: forward hotplug events again

2018-01-04 Thread Chris Wilson
Quoting Rodrigo Vivi (2018-01-05 01:42:55) > As mentioned on commit '88be58be886f ("drm/i915/fbdev: > Always forward hotplug events") we have real valid cases > of hotplugs where fbdev is not fully setup yet. > > Unfortunately this remove the checkpoint after the sync point. > So probably we can l

Re: [Intel-gfx] [PATCH] drm/i915: Whitelist SLICE_COMMON_ECO_CHICKEN1 on Geminilake.

2018-01-04 Thread Vivi, Rodrigo
On Jan 4, 2018, at 10:07 PM, Kenneth Graunke mailto:kenn...@whitecape.org>> wrote: On Thursday, January 4, 2018 4:41:35 PM PST Rodrigo Vivi wrote: On Thu, Jan 04, 2018 at 11:39:23PM +, Kenneth Graunke wrote: On Thursday, January 4, 2018 1:23:06 PM PST Chris Wilson wrote: Quoting Kenneth Gra

Re: [Intel-gfx] [PATCH] drm/i915: Whitelist SLICE_COMMON_ECO_CHICKEN1 on Geminilake.

2018-01-04 Thread Kenneth Graunke
On Thursday, January 4, 2018 4:41:35 PM PST Rodrigo Vivi wrote: > On Thu, Jan 04, 2018 at 11:39:23PM +, Kenneth Graunke wrote: > > On Thursday, January 4, 2018 1:23:06 PM PST Chris Wilson wrote: > > > Quoting Kenneth Graunke (2018-01-04 19:38:05) > > > > Geminilake requires the 3D driver to sel

Re: [Intel-gfx] [PATCH v3 11/12] drm/i915/guc: Restore GuC interrupts across suspend/reset if enabled

2018-01-04 Thread Sagar Arun Kamble
On 1/4/2018 11:19 PM, Michal Wajdeczko wrote: On Thu, 04 Jan 2018 17:21:53 +0100, Sagar Arun Kamble wrote: In order to override the disable/enable control of GuC interrupts during suspend/reset cycle we are creating two new functions suspend/restore guc_interrupts which check if interrupts

Re: [Intel-gfx] [PATCH v3 10/12] drm/i915/guc: Add client support to enable/disable GuC interrupts

2018-01-04 Thread Sagar Arun Kamble
On 1/4/2018 11:09 PM, Michal Wajdeczko wrote: On Thu, 04 Jan 2018 17:21:52 +0100, Sagar Arun Kamble wrote: This patch adds support to enable/disable GuC interrupts for different features without impacting other's need. Currently GuC log capture and CT buffer receive mechanisms use the GuC i

Re: [Intel-gfx] [PATCH v3 03/12] drm/i915/guc: Pass intel_guc struct parameter to GuC interrupts functions

2018-01-04 Thread Sagar Arun Kamble
On 1/4/2018 10:52 PM, Michal Wajdeczko wrote: On Thu, 04 Jan 2018 17:21:45 +0100, Sagar Arun Kamble wrote: GuC interrupts handling functions are GuC specific functions hence update the parameter from dev_priv to intel_guc struct. v2-v3: Rebase. Signed-off-by: Sagar Arun Kamble Cc: Micha

Re: [Intel-gfx] [PATCH v3 09/12] drm/i915/guc: Make GuC log related functions depend only on log level

2018-01-04 Thread Sagar Arun Kamble
On 1/4/2018 10:45 PM, Michal Wajdeczko wrote: On Thu, 04 Jan 2018 17:21:51 +0100, Sagar Arun Kamble wrote: With GuC log level set properly only for cases where GuC is loaded we can remove the GuC submission checks from flush_guc_logs and guc_log_register, unregister and uc_fini_hw function

Re: [Intel-gfx] [PATCH v3 04/12] drm/i915/guc: Add description and comments about guc_log_level parameter

2018-01-04 Thread Sagar Arun Kamble
On 1/4/2018 10:22 PM, Michal Wajdeczko wrote: On Thu, 04 Jan 2018 17:21:46 +0100, Sagar Arun Kamble wrote: guc_log_level parameter takes effect when GuC is loaded which is controlled through enable_guc parameter. Add this relation info. ^^^ Extra "." in parameter description and document

Re: [Intel-gfx] [PATCH v3 12/12] HAX: drm/i915/guc: enable GuC submission/logging for CI

2018-01-04 Thread Sagar Arun Kamble
On 1/4/2018 9:59 PM, Chris Wilson wrote: Quoting Sagar Arun Kamble (2018-01-04 16:21:54) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 6c8da9d..c8460c5 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -2659,6 +2659,8 @

Re: [Intel-gfx] [PATCH v3 03/12] drm/i915/guc: Pass intel_guc struct parameter to GuC interrupts functions

2018-01-04 Thread Sagar Arun Kamble
On 1/4/2018 10:01 PM, Michal Wajdeczko wrote: On Thu, 04 Jan 2018 17:23:05 +0100, Chris Wilson wrote: Quoting Sagar Arun Kamble (2018-01-04 16:21:45) GuC interrupts handling functions are GuC specific functions hence update the parameter from dev_priv to intel_guc struct. v2-v3: Rebase.

Re: [Intel-gfx] [PATCH i-g-t 1/6] i-g-t: kms_plane_scaling: Fix basic scaling test

2018-01-04 Thread Srinivas, Vidya
> -Original Message- > From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > Sent: Thursday, January 4, 2018 8:27 PM > To: Srinivas, Vidya ; intel- > g...@lists.freedesktop.org > Cc: Vetter, Daniel > Subject: Re: [Intel-gfx] [PATCH i-g-t 1/6] i-g-t: kms_plane_scaling: Fix

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Introduce a non-blocking power domain for vblank interrupts

2018-01-04 Thread Rodrigo Vivi
On Wed, Jan 03, 2018 at 08:40:00PM +, Dhinakaran Pandiyan wrote: > When DC states are enabled and PSR is active, the hardware enters DC5/DC6 > states resulting in the frame counter resetting. The frame counter reset > mess up the vblank counting logic as the diff between the new frame > counter

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: forward hotplug events again

2018-01-04 Thread Patchwork
== Series Details == Series: drm/i915: forward hotplug events again URL : https://patchwork.freedesktop.org/series/36054/ State : failure == Summary == Series 36054v1 drm/i915: forward hotplug events again https://patchwork.freedesktop.org/api/1.0/series/36054/revisions/1/mbox/ Test debugfs_t

[Intel-gfx] [PATCH] drm/i915: forward hotplug events again

2018-01-04 Thread Rodrigo Vivi
As mentioned on commit '88be58be886f ("drm/i915/fbdev: Always forward hotplug events") we have real valid cases of hotplugs where fbdev is not fully setup yet. Unfortunately this remove the checkpoint after the sync point. So probably we can live without it. Or we need a more robust serialization.

[Intel-gfx] linux-next: manual merge of the drm tree with the drm-intel-fixes tree

2018-01-04 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/i915/intel_cdclk.c between commit: 30414f3010af ("drm/i915: Apply Display WA #1183 on skl, kbl, and cfl") from the drm-intel-fixes tree and commit: 2aa97491da8a ("drm/i915: Use cdclk_state->voltage on SK

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dmc: DMC 1.07 for Cannonlake (rev5)

2018-01-04 Thread Patchwork
== Series Details == Series: drm/i915/dmc: DMC 1.07 for Cannonlake (rev5) URL : https://patchwork.freedesktop.org/series/35651/ State : success == Summary == Test kms_plane: Subgroup plane-panning-bottom-right-suspend-pipe-a-planes: incomplete -> PASS (shard-hsw)

Re: [Intel-gfx] [PATCH] drm/dp: Power cycle display if LINK_ADDRESS fails.

2018-01-04 Thread Pandiyan, Dhinakaran
On Thu, 2018-01-04 at 23:46 +, Pandiyan, Dhinakaran wrote: > On Thu, 2018-01-04 at 18:21 -0500, Lyude Paul wrote: > > Sorry for the late reply, I've been having very similar issues on my own > > MST hub > > and I wanted to make sure that they were the same issue, although it seems > > like

Re: [Intel-gfx] [PATCH] drm/i915: Whitelist SLICE_COMMON_ECO_CHICKEN1 on Geminilake.

2018-01-04 Thread Rodrigo Vivi
On Thu, Jan 04, 2018 at 11:39:23PM +, Kenneth Graunke wrote: > On Thursday, January 4, 2018 1:23:06 PM PST Chris Wilson wrote: > > Quoting Kenneth Graunke (2018-01-04 19:38:05) > > > Geminilake requires the 3D driver to select whether barriers are > > > intended for compute shaders, or tessella

Re: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake

2018-01-04 Thread Rodrigo Vivi
On Thu, Jan 04, 2018 at 11:51:42PM +, Anusha Srivatsa wrote: > From: "Srivatsa, Anusha" > > There is a new version of DMC available for CNL. > > The release notes mentions: > 1. Fix for the issue where DC_STATE was getting enabled > even when disabled by driver causing data corruption > > v

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: DMC 1.07 for Cannonlake (rev5)

2018-01-04 Thread Patchwork
== Series Details == Series: drm/i915/dmc: DMC 1.07 for Cannonlake (rev5) URL : https://patchwork.freedesktop.org/series/35651/ State : success == Summary == Series 35651v5 drm/i915/dmc: DMC 1.07 for Cannonlake https://patchwork.freedesktop.org/api/1.0/series/35651/revisions/5/mbox/ Test debu

[Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake

2018-01-04 Thread Anusha Srivatsa
From: "Srivatsa, Anusha" There is a new version of DMC available for CNL. The release notes mentions: 1. Fix for the issue where DC_STATE was getting enabled even when disabled by driver causing data corruption v2: Since the firmware is merged to linux-firmware.git, add MODULE_FIRMWARE. v3: r

Re: [Intel-gfx] [PATCH] drm/dp: Power cycle display if LINK_ADDRESS fails.

2018-01-04 Thread Pandiyan, Dhinakaran
On Thu, 2018-01-04 at 18:21 -0500, Lyude Paul wrote: > Sorry for the late reply, I've been having very similar issues on my own MST > hub > and I wanted to make sure that they were the same issue, although it seems > like > they aren't. > > So; I've been doing a lot of MST debugging this week a

Re: [Intel-gfx] [PATCH] drm/i915: Whitelist SLICE_COMMON_ECO_CHICKEN1 on Geminilake.

2018-01-04 Thread Kenneth Graunke
On Thursday, January 4, 2018 1:23:06 PM PST Chris Wilson wrote: > Quoting Kenneth Graunke (2018-01-04 19:38:05) > > Geminilake requires the 3D driver to select whether barriers are > > intended for compute shaders, or tessellation control shaders, by > > whacking a "Barrier Mode" bit in SLICE_COMMO

Re: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake

2018-01-04 Thread Srivatsa, Anusha
>-Original Message- >From: Saarinen, Jani >Sent: Wednesday, January 3, 2018 11:52 PM >To: Srivatsa, Anusha ; intel- >g...@lists.freedesktop.org >Cc: Vivi, Rodrigo >Subject: RE: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake > >HI, >> -Original Message- >> From: Intel-g

Re: [Intel-gfx] [PATCH i-g-t 1/2] test/kms_psr_sink_crc - subtests psr_basic and psr_drrs need test cleanup

2018-01-04 Thread Pandiyan, Dhinakaran
Including a line about the atomic update failure in the commit message would be nice. Reviewed-by: Dhinakaran Pandiyan On Thu, 2018-01-04 at 16:07 +0200, Marta Lofstedt wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260 > > Signed-off-by: Marta Lofstedt > --- > tests/kms_

Re: [Intel-gfx] [PATCH] drm/dp: Power cycle display if LINK_ADDRESS fails.

2018-01-04 Thread Lyude Paul
Sorry for the late reply, I've been having very similar issues on my own MST hub and I wanted to make sure that they were the same issue, although it seems like they aren't. So; I've been doing a lot of MST debugging this week and last and something I've discovered needs to be taken into account s

Re: [Intel-gfx] Review https://patchwork.freedesktop.org/patch/160274/

2018-01-04 Thread Pandiyan, Dhinakaran
On Thu, 2018-01-04 at 06:36 +, Mustaffa, Mustamin B wrote: > Hi all, > > > > Please help to review a patch > https://patchwork.freedesktop.org/patch/160274/ > > That patch is several months old now, please resubmit the patch to the mailing list. I see that there were comments from Jan

[Intel-gfx] ✗ Fi.CI.IGT: failure for meson: use message() rather than warning()

2018-01-04 Thread Patchwork
== Series Details == Series: meson: use message() rather than warning() URL : https://patchwork.freedesktop.org/series/36040/ State : failure == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-offscren-pri-shrfb-draw-blt: fail -> PASS (shard-snb) f

Re: [Intel-gfx] [PATCH] drm/i915/glk: Disable Guc and HuC on GLK

2018-01-04 Thread Rodrigo Vivi
On Wed, Jan 03, 2018 at 07:03:45PM +, Anusha Srivatsa wrote: > Since the firmwares are not yet released to public repo, > disable them on Geminilake. > > v2: Remove the firmware versions (Michal) > > v3: Remove unwanted defines (Rodrigo) > Correct commit message (Michal) > > Cc: Michal Wajde

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dmc: DMC 1.07 for Cannonlake (rev4)

2018-01-04 Thread Patchwork
== Series Details == Series: drm/i915/dmc: DMC 1.07 for Cannonlake (rev4) URL : https://patchwork.freedesktop.org/series/35651/ State : failure == Summary == Applying: drm/i915/dmc: DMC 1.07 for Cannonlake error: sha1 information is lacking or useless (drivers/gpu/drm/i915/intel_csr.c). error

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Rename some shorthand lock classes

2018-01-04 Thread Patchwork
== Series Details == Series: drm/i915: Rename some shorthand lock classes URL : https://patchwork.freedesktop.org/series/36047/ State : success == Summary == Series 36047v1 drm/i915: Rename some shorthand lock classes https://patchwork.freedesktop.org/api/1.0/series/36047/revisions/1/mbox/ Te

Re: [Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier

2018-01-04 Thread Yaodong Li
On 01/03/2018 10:10 PM, Sagar Arun Kamble wrote: Since ring frequency programming needs consideration of both IA and GT frequency requests I think keeping the logic to program the ring frequency table in driver that monitors both IA/GT busyness and power budgets like intel_ips will be more appr

Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT

2018-01-04 Thread Pandiyan, Dhinakaran
+Art On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote: > > On 1/4/2018 2:48 AM, Rodrigo Vivi wrote: > > On Wed, Jan 03, 2018 at 08:31:10PM +, Pandiyan, Dhinakaran wrote: > >> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: > >>> From: Gaurav Singh > >>> > >>> On Apollolake,

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Whitelist SLICE_COMMON_ECO_CHICKEN1 on Geminilake.

2018-01-04 Thread Patchwork
== Series Details == Series: drm/i915: Whitelist SLICE_COMMON_ECO_CHICKEN1 on Geminilake. URL : https://patchwork.freedesktop.org/series/36039/ State : warning == Summary == Test kms_flip: Subgroup vblank-vs-modeset-suspend-interruptible: pass -> SKIP (shard

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Enable vblanks after verifying power domain states.

2018-01-04 Thread Pandiyan, Dhinakaran
On Thu, 2018-01-04 at 12:35 +0100, Maarten Lankhorst wrote: > Wouldn't it be better to make intel_power_domains_verify_state work > correctly with the vblank irq? I tried to :) Since I changed the domain_use_count to atomic_t and moved it outside of the locks, verify_state became racy. Let me tak

Re: [Intel-gfx] [PATCH] drm/i915: Rename some shorthand lock classes

2018-01-04 Thread Chris Wilson
Quoting Chris Wilson (2018-01-04 21:45:28) > +#define lockdep_rename(lock, name) \ > + lockdep_set_class_and_name(lock, (lock)->dep_map.key, name) Maybe lockdep_set_name() for similarity to the others. -Chris ___

[Intel-gfx] [PATCH] drm/i915: Rename some shorthand lock classes

2018-01-04 Thread Chris Wilson
By default, lockdep takes the stringified variable as the name for the lock class. Quite often, these are constructed from local variables that are chosen for their brevity resulting in less than distinct class names. Rename some of the worst offenders encountered in recent reports. Signed-off-by:

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Enable vblanks after verifying power domain states.

2018-01-04 Thread Pandiyan, Dhinakaran
On Wed, 2018-01-03 at 20:57 +, Chris Wilson wrote: > Quoting Dhinakaran Pandiyan (2018-01-03 20:39:59) > > Since we want to allow for a non-blocking power domain for vblanks, > > the power domain use count and power well use count will not be updated > > atomically inside the power domain mut

Re: [Intel-gfx] [PATCH] drm/i915: Whitelist SLICE_COMMON_ECO_CHICKEN1 on Geminilake.

2018-01-04 Thread Chris Wilson
Quoting Kenneth Graunke (2018-01-04 19:38:05) > Geminilake requires the 3D driver to select whether barriers are > intended for compute shaders, or tessellation control shaders, by > whacking a "Barrier Mode" bit in SLICE_COMMON_ECO_CHICKEN1 when > switching pipelines. Failure to do this properly

Re: [Intel-gfx] [PATCH i-g-t] meson: use message() rather than warning()

2018-01-04 Thread Rhys Kidd
On 4 January 2018 at 15:29, Lucas De Marchi wrote: > warning() was only added to the meson interpreter in 0.44 which is > currently the last version. Let's use message() as we are currently > requiring meson > 0.40. Otherwise we get the following error: > > Meson encountered an error in f

[Intel-gfx] ✓ Fi.CI.BAT: success for meson: use message() rather than warning()

2018-01-04 Thread Patchwork
== Series Details == Series: meson: use message() rather than warning() URL : https://patchwork.freedesktop.org/series/36040/ State : success == Summary == IGT patchset tested on top of latest successful build 6db24416fdcdf5571125f9005089241cc6ba2652 lib/gem: Reset the global seqno at the sta

[Intel-gfx] [PATCH i-g-t] meson: use message() rather than warning()

2018-01-04 Thread Lucas De Marchi
warning() was only added to the meson interpreter in 0.44 which is currently the last version. Let's use message() as we are currently requiring meson > 0.40. Otherwise we get the following error: Meson encountered an error in file overlay/meson.build, line 62, column 1: Unknown f

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Whitelist SLICE_COMMON_ECO_CHICKEN1 on Geminilake.

2018-01-04 Thread Patchwork
== Series Details == Series: drm/i915: Whitelist SLICE_COMMON_ECO_CHICKEN1 on Geminilake. URL : https://patchwork.freedesktop.org/series/36039/ State : success == Summary == Series 36039v1 drm/i915: Whitelist SLICE_COMMON_ECO_CHICKEN1 on Geminilake. https://patchwork.freedesktop.org/api/1.0/se

[Intel-gfx] [PATCH] drm/i915: Whitelist SLICE_COMMON_ECO_CHICKEN1 on Geminilake.

2018-01-04 Thread Kenneth Graunke
Geminilake requires the 3D driver to select whether barriers are intended for compute shaders, or tessellation control shaders, by whacking a "Barrier Mode" bit in SLICE_COMMON_ECO_CHICKEN1 when switching pipelines. Failure to do this properly can result in GPU hangs. Unfortunately, this means it

Re: [Intel-gfx] [PATCH] drm/i915: Pass DMA_ATTR_NO_WARN to dma_map_sg()

2018-01-04 Thread Chris Wilson
Quoting Matthew Auld (2018-01-04 17:20:16) > On 4 January 2018 at 16:38, Chris Wilson wrote: > > In some iommu, e.g. swiotlb, the available space can be quite limited. > > So we employ a trial-and-error approach to seeing if our large > > contiguous chunks can fit, and if that fails we try again w

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Pass DMA_ATTR_NO_WARN to dma_map_sg()

2018-01-04 Thread Patchwork
== Series Details == Series: drm/i915: Pass DMA_ATTR_NO_WARN to dma_map_sg() URL : https://patchwork.freedesktop.org/series/36025/ State : success == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-primscrn-pri-shrfb-draw-render: fail -> PASS (shar

Re: [Intel-gfx] linux-firmware Pull Request (CNL:DMC)

2018-01-04 Thread Srivatsa, Anusha
>-Original Message- >From: Josh Boyer [mailto:jwbo...@kernel.org] >Sent: Wednesday, January 3, 2018 12:27 PM >To: Srivatsa, Anusha >Cc: linux-firmw...@kernel.org; Intel Graphics Development g...@lists.freedesktop.org>; Ben Hutchings ; Kyle >McMartin >Subject: Re: linux-firmware Pull Req

Re: [Intel-gfx] [PATCH v3 11/12] drm/i915/guc: Restore GuC interrupts across suspend/reset if enabled

2018-01-04 Thread Michal Wajdeczko
On Thu, 04 Jan 2018 17:21:53 +0100, Sagar Arun Kamble wrote: In order to override the disable/enable control of GuC interrupts during suspend/reset cycle we are creating two new functions suspend/restore guc_interrupts which check if interrupts were enabled and disable them on suspend and ena

Re: [Intel-gfx] [PATCH v3 10/12] drm/i915/guc: Add client support to enable/disable GuC interrupts

2018-01-04 Thread Michal Wajdeczko
On Thu, 04 Jan 2018 17:21:52 +0100, Sagar Arun Kamble wrote: This patch adds support to enable/disable GuC interrupts for different features without impacting other's need. Currently GuC log capture and CT buffer receive mechanisms use the GuC interrupts. GuC interrupts are currently enabled

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Pass DMA_ATTR_NO_WARN to dma_map_sg()

2018-01-04 Thread Patchwork
== Series Details == Series: drm/i915: Pass DMA_ATTR_NO_WARN to dma_map_sg() URL : https://patchwork.freedesktop.org/series/36025/ State : success == Summary == Series 36025v1 drm/i915: Pass DMA_ATTR_NO_WARN to dma_map_sg() https://patchwork.freedesktop.org/api/1.0/series/36025/revisions/1/mbo

Re: [Intel-gfx] [PATCH v3 03/12] drm/i915/guc: Pass intel_guc struct parameter to GuC interrupts functions

2018-01-04 Thread Michal Wajdeczko
On Thu, 04 Jan 2018 17:21:45 +0100, Sagar Arun Kamble wrote: GuC interrupts handling functions are GuC specific functions hence update the parameter from dev_priv to intel_guc struct. v2-v3: Rebase. Signed-off-by: Sagar Arun Kamble Cc: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Tvrt

Re: [Intel-gfx] [PATCH] drm/i915: Pass DMA_ATTR_NO_WARN to dma_map_sg()

2018-01-04 Thread Matthew Auld
On 4 January 2018 at 16:38, Chris Wilson wrote: > In some iommu, e.g. swiotlb, the available space can be quite limited. > So we employ a trial-and-error approach to seeing if our large > contiguous chunks can fit, and if that fails we try again with smaller > chunks after trying to free our own l

Re: [Intel-gfx] [PATCH v3 09/12] drm/i915/guc: Make GuC log related functions depend only on log level

2018-01-04 Thread Michal Wajdeczko
On Thu, 04 Jan 2018 17:21:51 +0100, Sagar Arun Kamble wrote: With GuC log level set properly only for cases where GuC is loaded we can remove the GuC submission checks from flush_guc_logs and guc_log_register, unregister and uc_fini_hw functions. It is important to note that GuC log runtim

[Intel-gfx] [PATCH] drm/i915: Pass DMA_ATTR_NO_WARN to dma_map_sg()

2018-01-04 Thread Chris Wilson
In some iommu, e.g. swiotlb, the available space can be quite limited. So we employ a trial-and-error approach to seeing if our large contiguous chunks can fit, and if that fails we try again with smaller chunks after trying to free our own lazily allocated blobs. As we use a trial-and-error approa

[Intel-gfx] ✓ Fi.CI.IGT: success for kms_vblank: Move tests over from kms_flip. (rev2)

2018-01-04 Thread Patchwork
== Series Details == Series: kms_vblank: Move tests over from kms_flip. (rev2) URL : https://patchwork.freedesktop.org/series/36006/ State : success == Summary == Test kms_flip: Subgroup modeset-vs-vblank-race-interruptible: fail -> PASS (shard-hsw) fdo#1030

Re: [Intel-gfx] [PATCH v3 04/12] drm/i915/guc: Add description and comments about guc_log_level parameter

2018-01-04 Thread Michal Wajdeczko
On Thu, 04 Jan 2018 17:21:46 +0100, Sagar Arun Kamble wrote: guc_log_level parameter takes effect when GuC is loaded which is controlled through enable_guc parameter. Add this relation info. ^^^ Extra "." in parameter descrip

[Intel-gfx] ✗ Fi.CI.BAT: failure for GuC Interrupts/Log updates (rev2)

2018-01-04 Thread Patchwork
== Series Details == Series: GuC Interrupts/Log updates (rev2) URL : https://patchwork.freedesktop.org/series/32179/ State : failure == Summary == Series 32179v2 GuC Interrupts/Log updates https://patchwork.freedesktop.org/api/1.0/series/32179/revisions/2/mbox/ Test core_auth: Subgrou

Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT

2018-01-04 Thread Singh, Gaurav K
On 1/4/2018 2:48 AM, Rodrigo Vivi wrote: On Wed, Jan 03, 2018 at 08:31:10PM +, Pandiyan, Dhinakaran wrote: On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: From: Gaurav Singh On Apollolake, with stress test warm reboot, audio card was not getting enumerated after reboot. This wa

Re: [Intel-gfx] [PATCH v3 03/12] drm/i915/guc: Pass intel_guc struct parameter to GuC interrupts functions

2018-01-04 Thread Michal Wajdeczko
On Thu, 04 Jan 2018 17:23:05 +0100, Chris Wilson wrote: Quoting Sagar Arun Kamble (2018-01-04 16:21:45) GuC interrupts handling functions are GuC specific functions hence update the parameter from dev_priv to intel_guc struct. v2-v3: Rebase. Signed-off-by: Sagar Arun Kamble Cc: Michal W

Re: [Intel-gfx] [PATCH v3 12/12] HAX: drm/i915/guc: enable GuC submission/logging for CI

2018-01-04 Thread Chris Wilson
Quoting Sagar Arun Kamble (2018-01-04 16:21:54) > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 6c8da9d..c8460c5 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -2659,6 +2659,8 @@ static int intel_runtime_resume(st

Re: [Intel-gfx] [PATCH v3 03/12] drm/i915/guc: Pass intel_guc struct parameter to GuC interrupts functions

2018-01-04 Thread Chris Wilson
Quoting Sagar Arun Kamble (2018-01-04 16:21:45) > GuC interrupts handling functions are GuC specific functions hence update > the parameter from dev_priv to intel_guc struct. > > v2-v3: Rebase. > > Signed-off-by: Sagar Arun Kamble > Cc: Michal Wajdeczko > Cc: Daniele Ceraolo Spurio > Cc: Tvrtk

Re: [Intel-gfx] [PATCH 02/15] drm/i915/skl+: refactore WM calculation for NV12

2018-01-04 Thread Maarten Lankhorst
Op 07-01-18 om 10:59 schreef Vidya Srinivas: > From: Mahesh Kumar > > Current code calculates DDB for planar formats in such a way that we > store DDB of plane-0 in plane 1 & vice-versa. > In order to make this clean this patch refactors WM/DDB calculation for > NV12 planar formats. > > Signed-off

[Intel-gfx] [PATCH v3 09/12] drm/i915/guc: Make GuC log related functions depend only on log level

2018-01-04 Thread Sagar Arun Kamble
With GuC log level set properly only for cases where GuC is loaded we can remove the GuC submission checks from flush_guc_logs and guc_log_register, unregister and uc_fini_hw functions. It is important to note that GuC log runtime data has to be freed during driver unregister. Freeing of that data

[Intel-gfx] [PATCH v3 10/12] drm/i915/guc: Add client support to enable/disable GuC interrupts

2018-01-04 Thread Sagar Arun Kamble
This patch adds support to enable/disable GuC interrupts for different features without impacting other's need. Currently GuC log capture and CT buffer receive mechanisms use the GuC interrupts. GuC interrupts are currently enabled and disabled in different logging scenarios all gated by log level.

[Intel-gfx] [PATCH v3 11/12] drm/i915/guc: Restore GuC interrupts across suspend/reset if enabled

2018-01-04 Thread Sagar Arun Kamble
In order to override the disable/enable control of GuC interrupts during suspend/reset cycle we are creating two new functions suspend/restore guc_interrupts which check if interrupts were enabled and disable them on suspend and enable them on resume. They are used to restore interrupts across rese

[Intel-gfx] [PATCH v3 08/12] drm/i915/guc: Make guc_log_level parameter immutable

2018-01-04 Thread Sagar Arun Kamble
This patch introduces i915 internal state variable in GuC log struct, "level" which will be copied from guc_log_level modparam during i915 load and thereafter be available for user updates. This will make guc_log_level parameter immutable. Suggested-by: Tvrtko Ursulin Signed-off-by: Sagar Arun Ka

[Intel-gfx] [PATCH v3 12/12] HAX: drm/i915/guc: enable GuC submission/logging for CI

2018-01-04 Thread Sagar Arun Kamble
Also 1) revert ("drm/i915/guc: Assert that we switch between known ggtt->invalidate functions") 2) fix RPM resume interrupt enabling w.r.t GuC resume 3) disable guc log streaming DRM logs --- drivers/gpu/drm/i915/i915_drv.c | 4 ++-- drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++-- drivers/

[Intel-gfx] [PATCH v3 07/12] drm/i915/guc: Grab RPM wakelock while disabling GuC interrupts

2018-01-04 Thread Sagar Arun Kamble
Disabling GuC interrupts involves access to GuC IRQ control registers hence ensure device is RPM awake. v2: Add comment about need to synchronize flush work and log runtime destroy v3: Moved patch earlier in the series and removed comment about future work. (Tvrtko) Signed-off-by: Sagar Arun

[Intel-gfx] [PATCH v3 05/12] drm/i915/guc: Fix GuC interrupts disabling with logging

2018-01-04 Thread Sagar Arun Kamble
With guc_log_unregister disabling runtime logging and interrupts, there is no need to disable interrupts during uc_fini_hw hence it is removed. With GuC CT buffer mechanism, interrupt disabling can be added later at a point where CT mechanism ceases. v2: Rebase. v3: Moved this patch earlier in th

[Intel-gfx] [PATCH v3 02/12] drm/i915/guc: Move GuC interrupts related functions from i915_irq.c to intel_guc.c

2018-01-04 Thread Sagar Arun Kamble
GuC interrupts handling is core GuC functionality. Better to keep it with other core functions in intel_guc.c. Since they are used from uC functions, GuC logging and i915 irq handling keeping them grouped in intel_guc.c instead of intel_uc.c. v2-v3: Rebase. Suggested-by: Michal Wajdeczko Signed-

[Intel-gfx] [PATCH v3 04/12] drm/i915/guc: Add description and comments about guc_log_level parameter

2018-01-04 Thread Sagar Arun Kamble
guc_log_level parameter takes effect when GuC is loaded which is controlled through enable_guc parameter. Add this relation info. in parameter description and documentation. Earlier, this patch was added to sanitize guc_log_level like old GuC parameters enable_guc_loading/submission. With new param

[Intel-gfx] [PATCH v3 06/12] drm/i915/guc: Separate creation/release of runtime logging data from base logging data

2018-01-04 Thread Sagar Arun Kamble
GuC log runtime/relay channel data will get released during i915 unregister, and only GuC log vma needs to be released during fini. To achieve this, prepare separate helpers to create/destroy base and runtime logging. This separation is also needed to couple runtime log data and interrupts handling

[Intel-gfx] [PATCH v3 03/12] drm/i915/guc: Pass intel_guc struct parameter to GuC interrupts functions

2018-01-04 Thread Sagar Arun Kamble
GuC interrupts handling functions are GuC specific functions hence update the parameter from dev_priv to intel_guc struct. v2-v3: Rebase. Signed-off-by: Sagar Arun Kamble Cc: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Tvrtko Ursulin Cc: Chris Wilson Cc: Joonas Lahtinen Reviewed-by: Tvr

[Intel-gfx] [PATCH v3 01/12] drm/i915: Export low level PM IRQ functions to use from GuC functions

2018-01-04 Thread Sagar Arun Kamble
In order to separate GuC IRQ handling functions from i915_irq.c we need to export the low level pm irq handlers. Export pm_iir, reset_pm_iir and enable/disable_pm_irq functions. v2-v3: Rebase. Suggested-by: Michal Wajdeczko Signed-off-by: Sagar Arun Kamble Cc: Michal Wajdeczko Cc: Daniele Cera

[Intel-gfx] [PATCH v3 00/12] GuC Interrupts/Log updates

2018-01-04 Thread Sagar Arun Kamble
This series addresses following features/fixes: 1. Restructuring to move GuC interrupts related functions to guc.c 2. Making GuC interrupts enable/disable reference based and tying up with logging at all places. 3. Handle suspend/resume/reset for GuC interrupts. 4. Logging fixes about RPM wakere

[Intel-gfx] [PULL] drm-intel-fixes

2018-01-04 Thread Jani Nikula
Hi Dave, some more i915 fixes for the new year. drm-intel-fixes-2018-01-04: drm/i915 fixes for v4.15-rc7 - couple of documentation build fixes - serialize non-blocking modesets - prevent DMC from messing up GMBUS transfers - PSR regression fix BR, Jani. The following changes since commit 30a7ac

Re: [Intel-gfx] linux-firmware Pull Request (CNL:DMC)

2018-01-04 Thread Josh Boyer
On Tue, Jan 2, 2018 at 2:10 PM, Anusha Srivatsa wrote: > Hi Josh, Ben, Kyle, > > Please consider pulling i915 updates to linux-firmware.git. > The following changes since commit 2567e092339cd3403d697dc2e0967c31b7acb989: > > nvidia: add GP108 signed firmware (2017-12-21 08:08:05 -0500) > > are av

[Intel-gfx] ✓ Fi.CI.IGT: success for test/kms_psr_sink : HACK test if psr_drrs also need test_cleanup

2018-01-04 Thread Patchwork
== Series Details == Series: test/kms_psr_sink : HACK test if psr_drrs also need test_cleanup URL : https://patchwork.freedesktop.org/series/36004/ State : success == Summary == Test kms_flip: Subgroup plain-flip-ts-check-interruptible: pass -> FAIL (shard-h

Re: [Intel-gfx] [PATCH i-g-t 1/6] i-g-t: kms_plane_scaling: Fix basic scaling test

2018-01-04 Thread Maarten Lankhorst
Op 13-12-17 om 10:50 schreef Vidya Srinivas: > From: Mahesh Kumar > > PIPEC doesnt have 3rd plane in GEN9. So, we skip the > 3rd plane related scaling test where 2nd OVERLAY > plane is not available. > > Restricting downscaling to (9/10)x original size of the > image to avoid "Max pixel rate limit

[Intel-gfx] ✓ Fi.CI.BAT: success for kms_vblank: Move tests over from kms_flip. (rev2)

2018-01-04 Thread Patchwork
== Series Details == Series: kms_vblank: Move tests over from kms_flip. (rev2) URL : https://patchwork.freedesktop.org/series/36006/ State : success == Summary == IGT patchset tested on top of latest successful build 6db24416fdcdf5571125f9005089241cc6ba2652 lib/gem: Reset the global seqno at t

[Intel-gfx] [PATCH i-g-t v2 0/6] kms_vblank: Move tests over from kms_flip.

2018-01-04 Thread Maarten Lankhorst
kms_flip is meant for finding issues with page flip, but was used for finding bugs in the vblank ioctl too. Move over some tests from kms_flip to kms_vblank, and reduce their runtime to a minimum. Changes since v1: - Rebase on top of current head so the changes to kms_flip apply. - Move hang test

[Intel-gfx] [PATCH i-g-t v2 2/6] kms_vblank: Reorganize subtests by pipe

2018-01-04 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- tests/kms_vblank.c | 93 -- 1 file changed, 49 insertions(+), 44 deletions(-) diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c index 342e4ef23b97..e51e96c7f061 100644 --- a/tests/kms_vblank.c +++ b/tests

[Intel-gfx] [PATCH i-g-t v2 4/6] kms_vblank: Add tests implemented in kms_flip

2018-01-04 Thread Maarten Lankhorst
In kms_flip there are some tests for testing whether the vblank counter is monotonically increasing. Add these subtests to kms_vblank, where they belong. Signed-off-by: Maarten Lankhorst --- tests/kms_vblank.c | 84 +++--- 1 file changed, 80 insert

[Intel-gfx] [PATCH i-g-t v2 1/6] tests/kms_flip: Remove blt/rcs flip tests.

2018-01-04 Thread Maarten Lankhorst
With the removal of mmio flips, blt and rcs flips are no longer different from doing busy testing in kms_busy. Signed-off-by: Maarten Lankhorst --- tests/kms_flip.c | 40 +--- 1 file changed, 1 insertion(+), 39 deletions(-) diff --git a/tests/kms_flip.c b/tes

[Intel-gfx] [PATCH i-g-t v2 5/6] kms_flip: Remove redundant vblank tests.

2018-01-04 Thread Maarten Lankhorst
wf_vblank is redundant with wf_vblank-ts-check, which also performs a check but runs in the same way. The -EINVAL vblank tests are reproduced in kms_vblank, as are the vblank-vs-* tests. Signed-off-by: Maarten Lankhorst --- tests/kms_flip.c | 8 1 file changed, 8 deletions(-) diff --g

[Intel-gfx] [PATCH i-g-t v2 6/6] kms_vblank: Remove teardown code from cleanup_crtc

2018-01-04 Thread Maarten Lankhorst
New way of doing things is calling igt_display_reset() before any setup code. This way if the configuration stays the same, the initial modeset will be a noop. Signed-off-by: Maarten Lankhorst --- tests/kms_vblank.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/

[Intel-gfx] [PATCH i-g-t v2 3/6] tests/kms_flip: Move kms_flip.vblank-vs-hang to kms_vblank, v2.

2018-01-04 Thread Maarten Lankhorst
There's no need to test this more than once. Add a NOHANG flag which can be used to specify that a subtest can not be run when hanging. If it's set on either the subtest or the mode, the -hang test for this combination will not be generated. Changes since v1: - Merge the patch that renamed HANG to

[Intel-gfx] [PATCH i-g-t 1/2] test/kms_psr_sink_crc - subtests psr_basic and psr_drrs need test cleanup

2018-01-04 Thread Marta Lofstedt
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260 Signed-off-by: Marta Lofstedt --- tests/kms_psr_sink_crc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index 83a69f0b..26cf434a 100644 --- a/tests/kms_psr_sink_crc.c +++ b/

Re: [Intel-gfx] [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test test_cleanup(&data) for psr_basic

2018-01-04 Thread Lofstedt, Marta
Doesn't look like it is needed for the psr_drrs https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_744/all.html From: Lofstedt, Marta Sent: Thursday, January 04, 2018 1:37 PM To: Latvala, Petri Cc: intel-gfx@lists.freedesktop.org Subject: RE: [Intel-gfx] [PATCH

[Intel-gfx] ✗ Fi.CI.BAT: failure for kms_vblank: Move tests over from kms_flip.

2018-01-04 Thread Patchwork
== Series Details == Series: kms_vblank: Move tests over from kms_flip. URL : https://patchwork.freedesktop.org/series/36006/ State : failure == Summary == Applying: tests/kms_flip: Remove blt/rcs flip tests. Using index info to reconstruct a base tree... M tests/kms_flip.c Falling back

[Intel-gfx] ✓ Fi.CI.BAT: success for test/kms_psr_sink : HACK test if psr_drrs also need test_cleanup

2018-01-04 Thread Patchwork
== Series Details == Series: test/kms_psr_sink : HACK test if psr_drrs also need test_cleanup URL : https://patchwork.freedesktop.org/series/36004/ State : success == Summary == IGT patchset tested on top of latest successful build 6db24416fdcdf5571125f9005089241cc6ba2652 lib/gem: Reset the gl

[Intel-gfx] [PATCH i-g-t 3/7] kms_vblank: Reorganize subtests by pipe

2018-01-04 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- tests/kms_vblank.c | 102 - 1 file changed, 53 insertions(+), 49 deletions(-) diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c index 9a5a98743fa6..a83500635976 100644 --- a/tests/kms_vblank.c +++ b/tests

[Intel-gfx] [PATCH i-g-t 4/7] kms_vblank: Make the -hang tests work as intended

2018-01-04 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- tests/kms_vblank.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c index a83500635976..45301ca5110f 100644 --- a/tests/kms_vblank.c +++ b/tests/kms_vblank.c @@ -54,7 +

[Intel-gfx] [PATCH i-g-t 2/7] tests/kms_flip: Move kms_flip.vblank-vs-hang to kms_vblank

2018-01-04 Thread Maarten Lankhorst
There's no need to test this more than once. Signed-off-by: Maarten Lankhorst --- tests/kms_flip.c | 10 +- tests/kms_vblank.c | 18 ++ 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index 7689e65b521a..50c16b0debbf

[Intel-gfx] [PATCH i-g-t 6/7] kms_flip: Remove redundant vblank tests.

2018-01-04 Thread Maarten Lankhorst
wf_vblank is redundant with wf_vblank-ts-check, which also performs a check but runs in the same way. The -EINVAL vblank tests are reproduced in kms_vblank, as are the vblank-vs-* tests. Signed-off-by: Maarten Lankhorst --- tests/kms_flip.c | 8 1 file changed, 8 deletions(-) diff --g

[Intel-gfx] [PATCH i-g-t 5/7] kms_vblank: Add tests implemented in kms_flip

2018-01-04 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- tests/kms_vblank.c | 88 ++ 1 file changed, 82 insertions(+), 6 deletions(-) diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c index 45301ca5110f..f2fa11523d50 100644 --- a/tests/kms_vblank.c +++ b/tests/

[Intel-gfx] [PATCH i-g-t 0/7] kms_vblank: Move tests over from kms_flip.

2018-01-04 Thread Maarten Lankhorst
kms_flip is meant for finding issues with page flip, but was used for finding bugs in the vblank ioctl too. Move over some tests from kms_flip to kms_vblank, and reduce their runtime to a minimum. Maarten Lankhorst (7): tests/kms_flip: Remove blt/rcs flip tests. tests/kms_flip: Move kms_flip.v

[Intel-gfx] [PATCH i-g-t 7/7] kms_vblank: Remove teardown code from cleanup_crtc

2018-01-04 Thread Maarten Lankhorst
New way of doing things is calling igt_display_reset() before any setup code. This way if the configuration stays the same, the initial modeset will be a noop. Signed-off-by: Maarten Lankhorst --- tests/kms_vblank.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/

[Intel-gfx] [PATCH i-g-t 1/7] tests/kms_flip: Remove blt/rcs flip tests.

2018-01-04 Thread Maarten Lankhorst
With the removal of mmio flips, blt and rcs flips are no longer different from doing busy testing in kms_busy. Signed-off-by: Maarten Lankhorst --- tests/kms_flip.c | 37 + 1 file changed, 1 insertion(+), 36 deletions(-) diff --git a/tests/kms_flip.c b/tests/

[Intel-gfx] [PATCH i-g-t] test/kms_psr_sink : HACK test if psr_drrs also need test_cleanup

2018-01-04 Thread Marta Lofstedt
See previous PW: https://patchwork.freedesktop.org/series/36000/ Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260 Signed-off-by: Marta Lofstedt --- tests/intel-ci/fast-feedback.testlist | 575 +- 1 file changed, 288 insertions(+), 287 deletions(-) d

  1   2   >