Re: [Intel-gfx] [PATCH] drm/i915/gt: Clear the execlists timers before restarting

2020-12-02 Thread Chris Wilson
Quoting Chris Wilson (2020-12-03 00:57:31) > Across a reset, we stop the engine but not the timers. This leaves a > window where the timers have inconsistent state with the engine, causing > false timeslicing/preemption decisions to be made immediately upon > resume. > > Signed-off-by: Chris

[Intel-gfx] [PATCH v2 2/2] drm/i915/tgl: Add bound checks and simplify TGL REVID macros

2020-12-02 Thread Aditya Swarup
Add bound checks for TGL REV ID array. Since, there might be a possibility of using older kernels on latest platform revisions, resulting in out of bounds access for rev ID array. In this scenario, use the latest rev ID available and apply those WAs. Also, simplify GT macros for TGL rev ID to

[Intel-gfx] [PATCH v2 1/2] drm/i915/tgl: Fix REVID macros for TGL to fetch correct stepping

2020-12-02 Thread Aditya Swarup
Fix TGL REVID macros to fetch correct display/gt stepping based on SOC rev id from INTEL_REVID() macro. Previously, we were just returning the first element of the revid array instead of using the correct index based on SOC rev id. Fixes: ("drm/i915/tgl: Fix stepping WA matching") Cc: José

Re: [Intel-gfx] [PATCH] drm/i915/gvt: avoid useless use of inline

2020-12-02 Thread Zhenyu Wang
On 2020.11.30 13:13:53 +0200, Jani Nikula wrote: > In most cases, we are better off letting the compiler decide whether to > inline static functions in .c files or not. In this case, the inline > will be ignored anyway as mmio_pm_restore_handler() is passed as a > function pointer. > > Fixes:

Re: [Intel-gfx] [PATCH] drm/i915/rkl: Remove require_force_probe protection

2020-12-02 Thread Surendrakumar Upadhyay, TejaskumarX
Hi Jaswant, Can you please re-run resume run on CI as well as local setup and share results here? If it passes in full resume run in either of setup we are good go with. Thanks, Tejas > -Original Message- > From: Chris Wilson > Sent: 30 November 2020 20:31 > To: Pandey, Hariom ;

Re: [Intel-gfx] [PATCH 14/15] drm/vmwgfx: Remove references to struct drm_device.pdev

2020-12-02 Thread Zack Rusin
> On Dec 2, 2020, at 11:03, Daniel Vetter wrote: > > On Wed, Dec 2, 2020 at 4:37 PM Zack Rusin wrote: >> >> >> >>> On Dec 2, 2020, at 09:27, Thomas Zimmermann wrote: >>> >>> Hi >>> >>> Am 02.12.20 um 09:01 schrieb Thomas Zimmermann: Hi Am 30.11.20 um 21:59 schrieb Zack Rusin:

Re: [Intel-gfx] [PULL] drm-intel-fixes

2020-12-02 Thread Rodrigo Vivi
On Wed, Dec 02, 2020 at 04:36:24PM -0800, Rodrigo Vivi wrote: > Hi Dave and Daniel, > > Fixes for GPU hang, null dereference, suspend-resume, power consumption, and > use-after-free. > > The commit 6db58901c2aa ("drm/i915/display: return earlier from > intel_modeset_init() without display")

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gt: Clear the execlists timers before restarting

2020-12-02 Thread Patchwork
== Series Details == Series: drm/i915/gt: Clear the execlists timers before restarting URL : https://patchwork.freedesktop.org/series/84515/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK

[Intel-gfx] [PATCH] drm/i915/gt: Clear the execlists timers before restarting

2020-12-02 Thread Chris Wilson
Across a reset, we stop the engine but not the timers. This leaves a window where the timers have inconsistent state with the engine, causing false timeslicing/preemption decisions to be made immediately upon resume. Signed-off-by: Chris Wilson --- This fits the trace of a failure across reset,

[Intel-gfx] [PULL] drm-intel-fixes

2020-12-02 Thread Rodrigo Vivi
Hi Dave and Daniel, Fixes for GPU hang, null dereference, suspend-resume, power consumption, and use-after-free. The commit 6db58901c2aa ("drm/i915/display: return earlier from intel_modeset_init() without display") was not actually a crucial fix, but it allowed a clean pick of the

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Record the plane update times for debugging (rev10)

2020-12-02 Thread Patchwork
== Series Details == Series: drm/i915/display: Record the plane update times for debugging (rev10) URL : https://patchwork.freedesktop.org/series/84174/ State : success == Summary == CI Bug Log - changes from CI_DRM_9424_full -> Patchwork_19045_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add VRR_CTL_LINE_COUNT field to VRR_CTL register def

2020-12-02 Thread Patchwork
== Series Details == Series: drm/i915: Add VRR_CTL_LINE_COUNT field to VRR_CTL register def URL : https://patchwork.freedesktop.org/series/84503/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9424_full -> Patchwork_19044_full

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX

2020-12-02 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX URL : https://patchwork.freedesktop.org/series/84502/ State : success == Summary == CI Bug Log - changes from CI_DRM_9424_full -> Patchwork_19043_full

Re: [Intel-gfx] [PATCH 02/11] drm/i915/display/vrr: Create VRR file and add VRR capability check

2020-12-02 Thread Navare, Manasi
On Tue, Dec 01, 2020 at 02:21:56PM -0800, Navare, Manasi wrote: > On Tue, Nov 10, 2020 at 12:39:08PM +0200, Jani Nikula wrote: > > On Thu, 22 Oct 2020, Manasi Navare wrote: > > > We create a new file for all VRR related helpers. > > > Also add a function to check vrr capability based on > > >

Re: [Intel-gfx] [PATCH 05/11] drm/i915/display/dp: Compute VRR state in atomic_check

2020-12-02 Thread Navare, Manasi
On Tue, Dec 01, 2020 at 02:52:59PM -0800, Navare, Manasi wrote: > On Tue, Nov 10, 2020 at 12:47:46PM +0200, Jani Nikula wrote: > > On Thu, 22 Oct 2020, Manasi Navare wrote: > > > This forces a complete modeset if vrr drm crtc state goes > > > from enabled to disabled and vice versa. > > > This

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Record the plane update times for debugging (rev10)

2020-12-02 Thread Patchwork
== Series Details == Series: drm/i915/display: Record the plane update times for debugging (rev10) URL : https://patchwork.freedesktop.org/series/84174/ State : success == Summary == CI Bug Log - changes from CI_DRM_9424 -> Patchwork_19045

Re: [Intel-gfx] [PATCH v3] drm/i915/display: Record the plane update times for debugging

2020-12-02 Thread Chris Wilson
Quoting Chris Wilson (2020-12-02 21:28:14) > Since we try and estimate how long we require to update the registers to > perform a plane update, it is of vital importance that we measure the > distribution of plane updates to better guide our estimate. If we > underestimate how long it takes to

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX

2020-12-02 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX URL : https://patchwork.freedesktop.org/series/84501/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9424_full -> Patchwork_19042_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add support for DP-HDMI2.1 PCON (rev5)

2020-12-02 Thread Patchwork
== Series Details == Series: Add support for DP-HDMI2.1 PCON (rev5) URL : https://patchwork.freedesktop.org/series/82098/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9424_full -> Patchwork_19041_full Summary ---

[Intel-gfx] [PATCH v3] drm/i915/display: Record the plane update times for debugging

2020-12-02 Thread Chris Wilson
Since we try and estimate how long we require to update the registers to perform a plane update, it is of vital importance that we measure the distribution of plane updates to better guide our estimate. If we underestimate how long it takes to perform the plane update, we may slip into the next

[Intel-gfx] [PATCH v3] drm/i915/display: Record the plane update times for debugging

2020-12-02 Thread Chris Wilson
Since we try and estimate how long we require to update the registers to perform a plane update, it is of vital importance that we measure the distribution of plane updates to better guide our estimate. If we underestimate how long it takes to perform the plane update, we may slip into the next

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add the missing wakeref tracking for display power references (rev4)

2020-12-02 Thread Patchwork
== Series Details == Series: drm/i915: Add the missing wakeref tracking for display power references (rev4) URL : https://patchwork.freedesktop.org/series/84418/ State : success == Summary == CI Bug Log - changes from CI_DRM_9423_full -> Patchwork_19040_full

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Record the plane update times for debugging

2020-12-02 Thread Chris Wilson
Quoting Ville Syrjälä (2020-12-02 19:24:33) > On Fri, Nov 27, 2020 at 04:18:41PM +, Chris Wilson wrote: > > +#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_VBLANK_EVADE) > > +static void crtc_updates_info(struct seq_file *m, > > + struct intel_crtc *crtc, > > +

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Tidy prng constructor for client blits

2020-12-02 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Tidy prng constructor for client blits URL : https://patchwork.freedesktop.org/series/84498/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9423_full -> Patchwork_19039_full

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Record the plane update times for debugging

2020-12-02 Thread Ville Syrjälä
On Fri, Nov 27, 2020 at 04:18:41PM +, Chris Wilson wrote: > Since we try and estimate how long we require to update the registers to > perform a plane update, it is of vital importance that we measure the > distribution of plane updates to better guide our estimate. If we > underestimate how

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add VRR_CTL_LINE_COUNT field to VRR_CTL register def

2020-12-02 Thread Patchwork
== Series Details == Series: drm/i915: Add VRR_CTL_LINE_COUNT field to VRR_CTL register def URL : https://patchwork.freedesktop.org/series/84503/ State : success == Summary == CI Bug Log - changes from CI_DRM_9424 -> Patchwork_19044

Re: [Intel-gfx] [PATCH v1] vfio/pci: Add support for opregion v2.0+

2020-12-02 Thread Alex Williamson
On Thu, 3 Dec 2020 01:12:49 +0800 Fred Gao wrote: > When VBT data exceeds 6KB size and cannot be within mailbox #4 starting > from opregion v2.0+, Extended VBT region, next to opregion, is used to > hold the VBT data, so the total size will be opregion size plus > extended VBT region size. > >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX

2020-12-02 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX URL : https://patchwork.freedesktop.org/series/84502/ State : success == Summary == CI Bug Log - changes from CI_DRM_9424 -> Patchwork_19043

[Intel-gfx] [CI] drm/i915: Add VRR_CTL_LINE_COUNT field to VRR_CTL register def

2020-12-02 Thread Manasi Navare
VRR_CTL register only had a GENMASK but no field prep define for TRANS_VRR_CTL_LINE_COUNT field so add that Cc: Aditya Swarup Signed-off-by: Manasi Navare Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 1 + 1 file changed, 1 insertion(+) diff --git

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX

2020-12-02 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX URL : https://patchwork.freedesktop.org/series/84502/ State : warning == Summary == $ dim checkpatch origin/drm-tip a4095341b051 drm/i915/gem: Limit lmem scatterlist elements

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX

2020-12-02 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX URL : https://patchwork.freedesktop.org/series/84501/ State : success == Summary == CI Bug Log - changes from CI_DRM_9424 -> Patchwork_19042

[Intel-gfx] [CI 2/2] Revert "drm/i915/lmem: Limit block size to 4G"

2020-12-02 Thread Chris Wilson
Mixing I915_ALLOC_CONTIGUOUS and I915_ALLOC_MAX_SEGMENT_SIZE fared badly. The two directives conflict, with the contiguous request setting the min_order to the full size of the object, and the max-segment-size setting the max_order to the limit of the DMA mapper. This results in a situation where

[Intel-gfx] [CI 1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX

2020-12-02 Thread Chris Wilson
Adhere to the i915_sg_max_segment() limit on the lengths of individual scatterlist elements, and in doing so split up very large chunks of lmem into managable pieces for the dma-mapping backend. Reported-by: Venkata Sandeep Dhanalakota Suggested-by: Matthew Auld Signed-off-by: Chris Wilson Cc:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX

2020-12-02 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX URL : https://patchwork.freedesktop.org/series/84501/ State : warning == Summary == $ dim checkpatch origin/drm-tip a38d86f0fa1f drm/i915/gem: Limit lmem scatterlist elements

[Intel-gfx] ✓ Fi.CI.BAT: success for Add support for DP-HDMI2.1 PCON (rev5)

2020-12-02 Thread Patchwork
== Series Details == Series: Add support for DP-HDMI2.1 PCON (rev5) URL : https://patchwork.freedesktop.org/series/82098/ State : success == Summary == CI Bug Log - changes from CI_DRM_9424 -> Patchwork_19041 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH] drm/i915: wait PSR state back to idle when turn PSR off

2020-12-02 Thread Mun, Gwan-gyeong
On Fri, 2020-10-23 at 21:06 +, Souza, Jose wrote: > On Thu, 2020-10-22 at 13:56 +, Lee, Shawn C wrote: > > On Thu, Oct. 22, 2020, 3:24 a.m, Lee Shawn C wrote: > > > On Wed, Oct. 21, 2020, 5:13 p.m, Souza, Jose wrote: > > > > On Wed, 2020-10-21 at 22:24 +0800, Lee Shawn C wrote: > > > > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Spring clean debugfs

2020-12-02 Thread Patchwork
== Series Details == Series: drm/i915/gem: Spring clean debugfs URL : https://patchwork.freedesktop.org/series/84496/ State : success == Summary == CI Bug Log - changes from CI_DRM_9421_full -> Patchwork_19038_full Summary ---

Re: [Intel-gfx] [PATCH v2 2/2] Revert "drm/i915/lmem: Limit block size to 4G"

2020-12-02 Thread Chris Wilson
Quoting Matthew Auld (2020-12-02 16:40:36) > On Wed, 2 Dec 2020 at 15:51, Chris Wilson wrote: > > > > Mixing I915_ALLOC_CONTIGUOUS and I915_ALLOC_MAX_SEGMENT_SIZE fared > > badly. The two directives conflict, with the contiguous request setting > > the min_order to the full size of the object,

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add support for DP-HDMI2.1 PCON (rev5)

2020-12-02 Thread Patchwork
== Series Details == Series: Add support for DP-HDMI2.1 PCON (rev5) URL : https://patchwork.freedesktop.org/series/82098/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add support for DP-HDMI2.1 PCON (rev5)

2020-12-02 Thread Patchwork
== Series Details == Series: Add support for DP-HDMI2.1 PCON (rev5) URL : https://patchwork.freedesktop.org/series/82098/ State : warning == Summary == $ dim checkpatch origin/drm-tip c3aaa0e38802 drm/edid: Add additional HFVSDB fields for HDMI2.1 -:61: WARNING:FROM_SIGN_OFF_MISMATCH:

Re: [Intel-gfx] [PATCH v2 2/2] Revert "drm/i915/lmem: Limit block size to 4G"

2020-12-02 Thread Matthew Auld
On Wed, 2 Dec 2020 at 15:51, Chris Wilson wrote: > > Mixing I915_ALLOC_CONTIGUOUS and I915_ALLOC_MAX_SEGMENT_SIZE fared > badly. The two directives conflict, with the contiguous request setting > the min_order to the full size of the object, and the max-segment-size > setting the max_order to the

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX

2020-12-02 Thread Matthew Auld
On Wed, 2 Dec 2020 at 15:51, Chris Wilson wrote: > > Adhere to the i915_sg_max_segment() limit on the lengths of individual > scatterlist elements, and in doing so split up very large chunks of lmem > into managable pieces for the dma-mapping backend. > > Reported-by: Venkata Sandeep Dhanalakota

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Tidy prng constructor for client blits

2020-12-02 Thread Matthew Auld
On Wed, 2 Dec 2020 at 13:04, Chris Wilson wrote: > > Since we only initialise the prng once within the scope of the selftest, > we can use the default initialiser. > > Signed-off-by: Chris Wilson > Cc: Matthew Auld Reviewed-by: Matthew Auld ___

Re: [Intel-gfx] [PATCH 14/15] drm/vmwgfx: Remove references to struct drm_device.pdev

2020-12-02 Thread Daniel Vetter
On Wed, Dec 2, 2020 at 4:37 PM Zack Rusin wrote: > > > > > On Dec 2, 2020, at 09:27, Thomas Zimmermann wrote: > > > > Hi > > > > Am 02.12.20 um 09:01 schrieb Thomas Zimmermann: > >> Hi > >> Am 30.11.20 um 21:59 schrieb Zack Rusin: > >>> > >>> > On Nov 24, 2020, at 06:38, Thomas Zimmermann

[Intel-gfx] [PATCH v2 2/2] Revert "drm/i915/lmem: Limit block size to 4G"

2020-12-02 Thread Chris Wilson
Mixing I915_ALLOC_CONTIGUOUS and I915_ALLOC_MAX_SEGMENT_SIZE fared badly. The two directives conflict, with the contiguous request setting the min_order to the full size of the object, and the max-segment-size setting the max_order to the limit of the DMA mapper, resulting in a situation where

[Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX

2020-12-02 Thread Chris Wilson
Adhere to the i915_sg_max_segment() limit on the lengths of individual scatterlist elements, and in doing so split up very large chunks of lmem into managable pieces for the dma-mapping backend. Reported-by: Venkata Sandeep Dhanalakota Suggested-by: Matthew Auld Signed-off-by: Chris Wilson Cc:

Re: [Intel-gfx] [PATCH v3 10/10] drm/i915: remove last traces of I915_READ(), I915_WRITE() and POSTING_READ()

2020-12-02 Thread Jani Nikula
On Mon, 30 Nov 2020, Jani Nikula wrote: > Good riddance! Remove the macros and their remaining references in > comments. > > The following functions should be used instead, depending on the use > case: > > - intel_uncore_read(), intel_uncore_write(), intel_uncore_posting_read() > > -

Re: [Intel-gfx] [PATCH 14/15] drm/vmwgfx: Remove references to struct drm_device.pdev

2020-12-02 Thread Zack Rusin
> On Dec 2, 2020, at 09:27, Thomas Zimmermann wrote: > > Hi > > Am 02.12.20 um 09:01 schrieb Thomas Zimmermann: >> Hi >> Am 30.11.20 um 21:59 schrieb Zack Rusin: >>> >>> On Nov 24, 2020, at 06:38, Thomas Zimmermann wrote: Using struct drm_device.pdev is deprecated. Convert

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add the missing wakeref tracking for display power references (rev4)

2020-12-02 Thread Patchwork
== Series Details == Series: drm/i915: Add the missing wakeref tracking for display power references (rev4) URL : https://patchwork.freedesktop.org/series/84418/ State : warning == Summary == $ dim checkpatch origin/drm-tip fb819322d6eb drm/i915: Use CRTC index consistently during

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Tidy prng constructor for client blits

2020-12-02 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Tidy prng constructor for client blits URL : https://patchwork.freedesktop.org/series/84498/ State : success == Summary == CI Bug Log - changes from CI_DRM_9423 -> Patchwork_19039 Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX

2020-12-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX URL : https://patchwork.freedesktop.org/series/84495/ State : success == Summary == CI Bug Log - changes from CI_DRM_9420_full -> Patchwork_19037_full

[Intel-gfx] [PATCH v3 11/13] drm/i915: Read DSC capabilities of the HDMI2.1 PCON encoder

2020-12-02 Thread Ankit Nautiyal
This patch adds support to read and store the DSC capabilities of the HDMI2.1 PCon encoder. It also adds a new field to store these caps, The caps are read during dfp update and can later be used to get the PPS parameters for PCON-HDMI2.1 sink pair. Which inturn will be used to take a call to

[Intel-gfx] [PATCH v3 12/13] drm/i915: Add helper functions for calculating DSC parameters for HDMI2.1

2020-12-02 Thread Ankit Nautiyal
The DP-HDMI2.1 PCON spec provides way for a source to set PPS parameters: slice height, slice width and bits_per_pixel, based on the HDMI2.1 sink capabilities. The DSC encoder of the PCON will respect these parameters, while preparing the 128 byte PPS. This patch adds helper functions to

[Intel-gfx] [PATCH v3 13/13] drm/i915/display: Configure PCON for DSC1.1 to DSC1.2 encoding

2020-12-02 Thread Ankit Nautiyal
When a source supporting DSC1.1 is connected to DSC1.2 HDMI2.1 sink via DP HDMI2.1 PCON, the PCON can be configured to decode the DSC1.1 compressed stream and encode to DSC1.2. It then sends the DSC1.2 compressed stream to the HDMI2.1 sink. This patch configures the PCON for DSC1.1 to DSC1.2

[Intel-gfx] [PATCH v3 10/13] drm/i915: Add support for enabling link status and recovery

2020-12-02 Thread Ankit Nautiyal
From: Swati Sharma In this patch enables support for detecting link failures between PCON and HDMI sink in i915 driver. HDMI link loss indication to upstream DP source is indicated via IRQ_HPD. This is followed by reading of HDMI link configuration status (HDMI_TX_LINK_ACTIVE_STATUS). If the

[Intel-gfx] [PATCH v3 08/13] drm/i915: Add support for starting FRL training for HDMI2.1 via PCON

2020-12-02 Thread Ankit Nautiyal
This patch adds functions to start FRL training for an HDMI2.1 sink, connected via a PCON as a DP branch device. This patch also adds a new structure for storing frl training related data, when FRL training is completed. v2: As suggested by Uma Shankar: -renamed couple of variables for better

[Intel-gfx] [PATCH v3 09/13] drm/i915: Check for FRL training before DP Link training

2020-12-02 Thread Ankit Nautiyal
This patch calls functions to check FRL training requirements for an HDMI2.1 sink, when connected through PCON. The call is made before the DP link training. In case FRL is not required or failure during FRL training, the TMDS mode is selected for the pcon. v2: moved check_frl_training() just

[Intel-gfx] [PATCH v3 07/13] drm/i915: Capture max frl rate for PCON in dfp cap structure

2020-12-02 Thread Ankit Nautiyal
HDMI2.1 PCON advertises Max FRL bandwidth supported by the PCON and by the sink. This patch captures these in dfp cap structure in intel_dp and uses these to prune connector modes that cannot be supported by the PCON and sink FRL bandwidth. v2: Addressed review comments from Uma Shankar:

[Intel-gfx] [PATCH v3 06/13] drm/dp_helper: Add support for Configuring DSC for HDMI2.1 Pcon

2020-12-02 Thread Ankit Nautiyal
This patch adds registers for getting DSC encoder capability for a HDMI2.1 PCon. It also addes helper functions to configure DSC between the PCON and HDMI2.1 sink. v2: Corrected offset for DSC encoder bpc and minor changes. Also added helper functions for getting pcon dsc encoder capabilities as

[Intel-gfx] [PATCH v3 04/13] drm/dp_helper: Add Helpers for FRL Link Training support for DP-HDMI2.1 PCON

2020-12-02 Thread Ankit Nautiyal
This patch adds support for configuring a PCON device, connected as a DP branched device to enable FRL Link training with a HDMI2.1 + sink. v2: Fixed typos and addressed other review comments from Uma Shankar. -changed the commit message for better clarity (Uma Shankar) -removed unnecessary

[Intel-gfx] [PATCH v3 05/13] drm/dp_helper: Add support for link failure detection

2020-12-02 Thread Ankit Nautiyal
From: Swati Sharma There are specific DPCDs defined for detecting link failures between the PCON and HDMI sink and check the link status. In case of link failure, PCON will communicate the same using an IRQ_HPD to source. HDMI sink would have indicated the same to PCON using SCDC interrupt

[Intel-gfx] [PATCH v3 03/13] drm/edid: Parse DSC1.2 cap fields from HFVSDB block

2020-12-02 Thread Ankit Nautiyal
This patch parses HFVSDB fields for DSC1.2 capabilities of an HDMI2.1 sink. These fields are required by a source to understand the DSC capability of the sink, to set appropriate PPS parameters, before transmitting compressed data stream. v2: Addressed following issues as suggested by Uma

[Intel-gfx] [PATCH v3 02/13] drm/edid: Parse MAX_FRL field from HFVSDB block

2020-12-02 Thread Ankit Nautiyal
From: Swati Sharma This patch parses MAX_FRL field to get the MAX rate in Gbps that the HDMI 2.1 panel can support in FRL mode. Source need this field to determine the optimal rate between the source and sink during FRL training. v2: Fixed minor bugs, and removed extra wrapper function (Uma

[Intel-gfx] [PATCH v3 01/13] drm/edid: Add additional HFVSDB fields for HDMI2.1

2020-12-02 Thread Ankit Nautiyal
From: Swati Sharma The HDMI2.1 extends HFVSDB (HDMI Forum Vendor Specific Data block) to have fields related to newly defined methods of FRL (Fixed Rate Link) levels, number of lanes supported, DSC Color bit depth, VRR min/max, FVA (Fast Vactive), ALLM etc. This patch adds the new HFVSDB fields

[Intel-gfx] [PATCH v3 00/13] Add support for DP-HDMI2.1 PCON

2020-12-02 Thread Ankit Nautiyal
This patch series attempts to add support for a DP-HDMI2.1 Protocol Convertor. The VESA spec for the HDMI2.1 PCON are proposed in Errata E5 to DisplayPort_v2.0: https://vesa.org/join-vesamemberships/member-downloads/?action=stamp=42299 The details are mentioned in DP to HDMI2.1 PCON Enum/Config

Re: [Intel-gfx] [PATCH v2 01/20] drm/amdgpu: Fix trailing whitespaces

2020-12-02 Thread Thomas Zimmermann
Hi Am 02.12.20 um 15:02 schrieb Alex Deucher: On Wed, Dec 2, 2020 at 3:53 AM Thomas Zimmermann wrote: Hi Am 02.12.20 um 09:43 schrieb Christian König: Am 02.12.20 um 08:59 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 11:40 schrieb Christian König: Reviewed-by: Christian König on patch

Re: [Intel-gfx] [PATCH 14/15] drm/vmwgfx: Remove references to struct drm_device.pdev

2020-12-02 Thread Thomas Zimmermann
Hi Am 02.12.20 um 09:01 schrieb Thomas Zimmermann: Hi Am 30.11.20 um 21:59 schrieb Zack Rusin: On Nov 24, 2020, at 06:38, Thomas Zimmermann wrote: Using struct drm_device.pdev is deprecated. Convert vmwgfx to struct drm_device.dev. No functional changes. Signed-off-by: Thomas

Re: [Intel-gfx] [PATCH v2 13/13] drm/i915: Configure PCON for DSC1.1 to DSC1.2 encoding

2020-12-02 Thread Nautiyal, Ankit K
Thanks Uma for the comments. Please find my responses inline: On 11/26/2020 2:15 AM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Sunday, November 1, 2020 3:37 PM To: intel-gfx@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org; Shankar, Uma ;

Re: [Intel-gfx] [PATCH v2 12/13] drm/i915: Add helper functions for calculating DSC parameters for HDMI2.1

2020-12-02 Thread Nautiyal, Ankit K
Hi Uma, Thanks for the comments and spotting the errors. I agree to most of the comments and will address them in the next version. Please find my responses inline: On 11/26/2020 1:58 AM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Sunday, November 1,

Re: [Intel-gfx] [PATCH v2 01/20] drm/amdgpu: Fix trailing whitespaces

2020-12-02 Thread Alex Deucher
On Wed, Dec 2, 2020 at 3:53 AM Thomas Zimmermann wrote: > > Hi > > Am 02.12.20 um 09:43 schrieb Christian König: > > Am 02.12.20 um 08:59 schrieb Thomas Zimmermann: > >> Hi > >> > >> Am 01.12.20 um 11:40 schrieb Christian König: > >>> Reviewed-by: Christian König on patch #1 > >>> and #15. > >>>

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Spring clean debugfs

2020-12-02 Thread Patchwork
== Series Details == Series: drm/i915/gem: Spring clean debugfs URL : https://patchwork.freedesktop.org/series/84496/ State : success == Summary == CI Bug Log - changes from CI_DRM_9421 -> Patchwork_19038 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Record the plane update times for debugging

2020-12-02 Thread Chris Wilson
Quoting Chris Wilson (2020-11-27 16:18:41) > Since we try and estimate how long we require to update the registers to > perform a plane update, it is of vital importance that we measure the > distribution of plane updates to better guide our estimate. If we > underestimate how long it takes to

Re: [Intel-gfx] [v6 0/2] Re-enable FBC on TGL

2020-12-02 Thread Shankar, Uma
> -Original Message- > From: Souza, Jose > Sent: Wednesday, December 2, 2020 12:01 AM > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org > Cc: ville.syrj...@linux.intel.com > Subject: Re: [v6 0/2] Re-enable FBC on TGL > > LGTM, thanks for doing the changes. Pushed the series to

[Intel-gfx] [PATCH] drm/i915/selftests: Tidy prng constructor for client blits

2020-12-02 Thread Chris Wilson
Since we only initialise the prng once within the scope of the selftest, we can use the default initialiser. Signed-off-by: Chris Wilson Cc: Matthew Auld --- drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX

2020-12-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX URL : https://patchwork.freedesktop.org/series/84495/ State : success == Summary == CI Bug Log - changes from CI_DRM_9420 -> Patchwork_19037

Re: [Intel-gfx] [PATCH] drm/i915/gem: Spring clean debugfs

2020-12-02 Thread Andi Shyti
> Throw away all the debugfs entries that are not being actively used for > debugging/developing IGT. Note that a couple of these are already and > will remain available under the gt/ > > Files removed: > i915_gem_fence_regs > i915_gem_interrupt > i915_ring_freq_table >

[Intel-gfx] ✓ Fi.CI.IGT: success for vfio/pci: Add support for opregion v2.0+

2020-12-02 Thread Patchwork
== Series Details == Series: vfio/pci: Add support for opregion v2.0+ URL : https://patchwork.freedesktop.org/series/84494/ State : success == Summary == CI Bug Log - changes from CI_DRM_9418_full -> Patchwork_19036_full Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX

2020-12-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX URL : https://patchwork.freedesktop.org/series/84495/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7bf12e633b6b drm/i915/gem: Limit lmem scatterlist elements to

[Intel-gfx] [PATCH] drm/i915/gem: Spring clean debugfs

2020-12-02 Thread Chris Wilson
Throw away all the debugfs entries that are not being actively used for debugging/developing IGT. Note that a couple of these are already and will remain available under the gt/ Files removed: i915_gem_fence_regs i915_gem_interrupt i915_ring_freq_table

[Intel-gfx] [PATCH 1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX

2020-12-02 Thread Chris Wilson
Adhere to the i915_sg_max_segment() limit on the lengths of individual scatterlist elements, and in doing so split up very large chunks of lmem into managable pieces for the dma-mapping backend. Reported-by: Venkata Sandeep Dhanalakota Suggested-by: Matthew Auld Signed-off-by: Chris Wilson Cc:

[Intel-gfx] [PATCH 2/2] Revert "drm/i915/lmem: Limit block size to 4G"

2020-12-02 Thread Chris Wilson
Mixing I915_ALLOC_CONTIGUOUS and I915_ALLOC_MAX_SEGMENT_SIZE fared badly. The two directives conflict, with the contiguous request setting the min_order to the full size of the object, and the max-segment-size setting the max_order to the limit of the DMA mapper, resulting in a situation where

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX

2020-12-02 Thread Matthew Auld
On 01/12/2020 23:58, Chris Wilson wrote: Adhere to the i915_sg_max_segment() limit on the lengths of individual scatterlist elements, and in doing so split up very large chunks of lmem into managable pieces for the dma-mapping backend. Reported-by: Venkata Sandeep Dhanalakota Suggested-by:

[Intel-gfx] ✓ Fi.CI.BAT: success for vfio/pci: Add support for opregion v2.0+

2020-12-02 Thread Patchwork
== Series Details == Series: vfio/pci: Add support for opregion v2.0+ URL : https://patchwork.freedesktop.org/series/84494/ State : success == Summary == CI Bug Log - changes from CI_DRM_9418 -> Patchwork_19036 Summary ---

Re: [Intel-gfx] [PATCH 2/6] drm/i915/display/psr: Use plane damage clips to calculate damaged area

2020-12-02 Thread Mun, Gwan-gyeong
On Tue, 2020-12-01 at 13:15 -0800, Souza, Jose wrote: > On Tue, 2020-12-01 at 19:40 +, Mun, Gwan-gyeong wrote: > > On Tue, 2020-12-01 at 09:39 -0800, Souza, Jose wrote: > > > On Tue, 2020-12-01 at 17:26 +, Mun, Gwan-gyeong wrote: > > > > On Tue, 2020-10-27 at 13:12 -0700, Souza, Jose

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for vfio/pci: Add support for opregion v2.0+

2020-12-02 Thread Patchwork
== Series Details == Series: vfio/pci: Add support for opregion v2.0+ URL : https://patchwork.freedesktop.org/series/84494/ State : warning == Summary == $ dim checkpatch origin/drm-tip 94d751a62299 vfio/pci: Add support for opregion v2.0+ -:41: CHECK:LINE_SPACING: Please don't use multiple

Re: [Intel-gfx] [PATCH v3 09/10] drm/i915/gvt: replace I915_WRITE with intel_uncore_write

2020-12-02 Thread Jani Nikula
On Wed, 02 Dec 2020, Zhenyu Wang wrote: > On 2020.12.01 18:16:35 +0200, Jani Nikula wrote: >> On Mon, 30 Nov 2020, Jani Nikula wrote: >> > Let's avoid adding new I915_WRITE uses while we try to get rid of them. >> > >> > Fixes: 5f60b12edcd0 ("drm/i915/gvt: Save/restore HW status to support GVT

Re: [Intel-gfx] [PATCH] drm/i915/gem: Report error for vmap() failure

2020-12-02 Thread Matthew Auld
On 01/12/2020 21:54, Chris Wilson wrote: Convert the NULL pointer from a failed vmap() to ERR_PTR(-ENOMEM) for propagation. <1> [269.830447] BUG: kernel NULL pointer dereference, address: <1> [269.830455] #PF: supervisor write access in kernel mode <1> [269.830457] #PF:

[Intel-gfx] [PATCH v1] vfio/pci: Add support for opregion v2.0+

2020-12-02 Thread Fred Gao
When VBT data exceeds 6KB size and cannot be within mailbox #4 starting from opregion v2.0+, Extended VBT region, next to opregion, is used to hold the VBT data, so the total size will be opregion size plus extended VBT region size. For opregion 2.1+: since rvda is relative offset from opregion

Re: [Intel-gfx] [PATCH v2 01/20] drm/amdgpu: Fix trailing whitespaces

2020-12-02 Thread Thomas Zimmermann
Hi Am 02.12.20 um 09:43 schrieb Christian König: Am 02.12.20 um 08:59 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 11:40 schrieb Christian König: Reviewed-by: Christian König on patch #1 and #15. Acked-by: Christian König on patch #2 and #16. Could you add these patches to the AMD

Re: [Intel-gfx] [PATCH v2 01/20] drm/amdgpu: Fix trailing whitespaces

2020-12-02 Thread Christian König
Am 02.12.20 um 08:59 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 11:40 schrieb Christian König: Reviewed-by: Christian König on patch #1 and #15. Acked-by: Christian König on patch #2 and #16. Could you add these patches to the AMD tree? Alex is usually the one who picks such stuff

Re: [Intel-gfx] [PATCH v2 18/20] drm/virtgpu: Remove references to struct drm_device.pdev

2020-12-02 Thread Gerd Hoffmann
On Tue, Dec 01, 2020 at 11:35:40AM +0100, Thomas Zimmermann wrote: > Using struct drm_device.pdev is deprecated. Convert virtgpu to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Acked-by: Sam Ravnborg > Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann

[Intel-gfx] ✓ Fi.CI.IGT: success for i915/perf: Drop the check for report reason in OA

2020-12-02 Thread Patchwork
== Series Details == Series: i915/perf: Drop the check for report reason in OA URL : https://patchwork.freedesktop.org/series/84478/ State : success == Summary == CI Bug Log - changes from CI_DRM_9418_full -> Patchwork_19035_full Summary

Re: [Intel-gfx] [PATCH v2 14/20] drm/qxl: Remove references to struct drm_device.pdev

2020-12-02 Thread Gerd Hoffmann
On Tue, Dec 01, 2020 at 11:35:36AM +0100, Thomas Zimmermann wrote: > Using struct drm_device.pdev is deprecated. Convert qxl to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Acked-by: Sam Ravnborg > Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann

Re: [Intel-gfx] [PATCH v2 05/20] drm/cirrus: Remove references to struct drm_device.pdev

2020-12-02 Thread Gerd Hoffmann
On Tue, Dec 01, 2020 at 11:35:27AM +0100, Thomas Zimmermann wrote: > Using struct drm_device.pdev is deprecated. Convert cirrus to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Acked-by: Sam Ravnborg > Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann

Re: [Intel-gfx] [PATCH v2 04/20] drm/bochs: Remove references to struct drm_device.pdev

2020-12-02 Thread Gerd Hoffmann
On Tue, Dec 01, 2020 at 11:35:26AM +0100, Thomas Zimmermann wrote: > Using struct drm_device.pdev is deprecated. Convert bochs to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Acked-by: Sam Ravnborg > Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann > --- >

Re: [Intel-gfx] [PATCH 14/15] drm/vmwgfx: Remove references to struct drm_device.pdev

2020-12-02 Thread Thomas Zimmermann
Hi Am 30.11.20 um 21:59 schrieb Zack Rusin: On Nov 24, 2020, at 06:38, Thomas Zimmermann wrote: Using struct drm_device.pdev is deprecated. Convert vmwgfx to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Roland Scheidegger ---

Re: [Intel-gfx] [PATCH v2 01/20] drm/amdgpu: Fix trailing whitespaces

2020-12-02 Thread Thomas Zimmermann
Hi Am 01.12.20 um 11:40 schrieb Christian König: Reviewed-by: Christian König on patch #1 and #15. Acked-by: Christian König on patch #2 and #16. Could you add these patches to the AMD tree? Best regards Thomas Regards, Christian. Am 01.12.20 um 11:35 schrieb Thomas Zimmermann: