Hi all,
On Wed, 17 Mar 2021 14:08:24 +1100 Stephen Rothwell
wrote:
>
> Today's linux-next merge of the drm-intel tree got a conflict in:
>
> drivers/gpu/drm/i915/display/intel_sprite.c
>
> between commit:
>
> 92f1d09ca4ed ("drm: Switch to %p4cc format modifier")
>
> from the drm tree
Hi all,
Today's linux-next merge of the drm tree got a conflict in:
drivers/gpu/drm/omapdrm/dss/dsi.c
between commit:
690911544275 ("drm/omap: dsi: fix unsigned expression compared with zero")
from the drm-misc-fixes tree and commit:
bbd13d6a7b2e ("drm/omap: dsi: fix unreachable code
It's never been used by any real userspace. It's used by IGT as a
short-cut for sharing VMs and other stuff between contexts.
Signed-off-by: Jason Ekstrand
Cc: Tvrtko Ursulin
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 217 +---
include/uapi/drm/i915_drm.h
This reverts commit 88be76cdafc7e60e2e4ed883bfe7e8dd7f35fa3a. This API
has never been used by any real userspace.
Signed-off-by: Jason Ekstrand
---
drivers/gpu/drm/i915/Makefile | 1 -
drivers/gpu/drm/i915/gem/i915_gem_context.c | 94 ++-
From: Ashutosh Dixit
The rationale for this change is roughly as follows:
1. The functionality can be done entirely in userspace with a
combination of mmap + memcpy
2. The only reason anyone in userspace is still using it is because
someone implemented bo_subdata that way in libdrm
The Vulkan driver in Mesa for Intel hardware never uses relocations if
it's running on a version of i915 that supports at least softpin which
all versions of i915 supporting Gen12 do. On the OpenGL side, Gen12+ is
only supported by iris which never uses relocations. The older i965
driver in Mesa
libdrm has supported the newer execbuffer2 ioctl and using it by default
when it exists since libdrm commit b50964027bef which landed Mar 2, 2010.
The i915 and i965 drivers in Mesa at the time both used libdrm and so
did the Intel X11 back-end. The SNA back-end for X11 has always used
These patches clean up some of our uAPI mess in i915. The first patch
drops legacy execbuffer support which hasn't been used in 10 years. The
next two drop some legacy ioctls on new platforms. The last two drop APIs
which have never been used by userspace and shouldn't have landed in i915
in
== Series Details ==
Series: drm/i915/display: Not to try to re-enable PSR after being raised an irq
aux error
URL : https://patchwork.freedesktop.org/series/88072/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9866_full -> Patchwork_19803_full
== Series Details ==
Series: drm/i915: Fix DP LTTPR link training mode initialization (rev2)
URL : https://patchwork.freedesktop.org/series/88070/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9866_full -> Patchwork_19802_full
== Series Details ==
Series: drm/i915/display: Not to try to re-enable PSR after being raised an irq
aux error
URL : https://patchwork.freedesktop.org/series/88072/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9866 -> Patchwork_19803
== Series Details ==
Series: drm/i915/bios: vbt child device rework (rev2)
URL : https://patchwork.freedesktop.org/series/87165/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9866_full -> Patchwork_19801_full
Summary
If an irq aux error happens, it does not need to wait for PSR "IDLE state"
for re-enabling PSR. And it should not try to re-enable PSR.
The PSR interrupt handler sets irq_aux_error when the PSR error happens.
And it schedules the inter_psr_work(). but the current intel_psr_work() can
be scheduled
On Tue, Mar 16, 2021 at 11:46:38PM +, Daniel Stone wrote:
> On Tue, 16 Mar 2021 at 21:35, Daniel Vetter wrote:
>
> > On Tue, Mar 9, 2021 at 10:14 AM Pekka Paalanen
> > wrote:
> > > On Mon, 8 Mar 2021 16:52:58 -0800
> > > "Navare, Manasi" wrote:
> > > > Hmm well after the actual real
== Series Details ==
Series: drm/i915: Fix DP LTTPR link training mode initialization (rev2)
URL : https://patchwork.freedesktop.org/series/88070/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9866 -> Patchwork_19802
== Series Details ==
Series: Drop relocations for new gens (rev2)
URL : https://patchwork.freedesktop.org/series/88047/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9863_full -> Patchwork_19800_full
Summary
---
== Series Details ==
Series: drm/i915/bios: vbt child device rework (rev2)
URL : https://patchwork.freedesktop.org/series/87165/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9866 -> Patchwork_19801
Summary
---
On Wed, Mar 17, 2021 at 06:36:49PM +0200, Jani Nikula wrote:
These will be exposed to the rest of the driver and replace other
functions. Everything will operate on the child devices.
v2:
- Rebased, removed stray blank line
- Also abstracted intel_bios_encoder_supports_crt (Lucas)
Cc: Lucas De
On Wed, Mar 17, 2021 at 06:36:48PM +0200, Jani Nikula wrote:
We'll be needing it in the future.
Cc: Lucas De Marchi
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bios.c | 5 +
1 file changed, 5 insertions(+)
diff --git
== Series Details ==
Series: drm/i915/bios: vbt child device rework (rev2)
URL : https://patchwork.freedesktop.org/series/87165/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
ef7d9eda99d9 drm/i915/bios: mass convert dev_priv to i915
9b08439f2c5c drm/i915/bios: store bdb
On Wed, Mar 17, 2021 at 06:36:43PM +0200, Jani Nikula wrote:
Signed-off-by: Jani Nikula
Reviewed-by: Lucas De Marchi
Lucas De Marchi
---
drivers/gpu/drm/i915/display/intel_bios.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
On Wed, Mar 17, 2021 at 06:36:42PM +0200, Jani Nikula wrote:
Reduce indent with an early return. No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bios.c | 86 +++
1 file changed, 41 insertions(+), 45 deletions(-)
diff --git
On Wed, Mar 17, 2021 at 06:36:42PM +0200, Jani Nikula wrote:
Reduce indent with an early return. No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bios.c | 86 +++
1 file changed, 41 insertions(+), 45 deletions(-)
diff --git
By the specification the 0xF-0xF02FF range is only valid when the
DPCD revision is 1.4 or higher. Disable LTTPR support if this isn't so.
Trying to detect LTTPRs returned corrupted values for the above DPCD
range at least on a Skylake host with an LG 43UD79-B monitor with a DPCD
revision 1.2
By the specification the 0xF-0xF02FF range is only valid when the
DPCD revision is 1.4 or higher. Disable LTTPR support if this isn't so.
Trying to detect LTTPRs returned corrupted values for the above DPCD
range at least on a Skylake host with an LG 43UD79-B monitor with a DPCD
revision 1.2
The spec requires to use at least 3.2ms for the AUX timeout period if
there are LT-tunable PHY Repeaters on the link (2.11.2). An upcoming
spec update makes this more specific, by requiring a 3.2ms minimum
timeout period for the LTTPR detection reading the 0xF-0xF0007
range (3.6.5.1).
By the specification the 0xF - 0xF02FF range is only valid if the
LTTPR revision at 0xF is at least 1.4. Disable the LTTPR support
otherwise.
Fixes: 7b2a4ab8b0ef ("drm/i915: Switch to LTTPR transparent mode link training")
Cc: # v5.11
Cc: Ville Syrjälä
Signed-off-by: Imre Deak
---
This is v2 of
https://patchwork.freedesktop.org/series/88015/
also making sure that LTTPRs are detected and initialized only if the
DPCD and LTTPR revisions are > 1.4 as required by Display Port
specification.
Cc: Ville Syrjälä
Cc: # v5.11
Imre Deak (3):
drm/i915/ilk-glk: Fix link training
On Wed, Mar 17, 2021 at 07:57:32PM +0200, Jani Nikula wrote:
On Mon, 15 Mar 2021, Lucas De Marchi wrote:
On Thu, Mar 11, 2021 at 07:33:55AM -0800, Matt Roper wrote:
Use Coccinelle to convert most of the usage of INTEL_GEN() and IS_GEN()
in the display code to use DISPLAY_VER() comparisons
On Thu, 11 Mar 2021, Matt Roper wrote:
> From: Clinton Taylor
>
> Add 12 known PCI device IDs
>
> Bspec: 55376
> Cc: Caz Yokoyama
> Cc: Matt Atwood
> Cc: Matt Roper
> Signed-off-by: Clinton Taylor
> Signed-off-by: Matt Roper
> ---
> include/drm/i915_pciids.h | 20
> 1
On Fri, 12 Mar 2021, Matt Roper wrote:
> On Fri, Mar 12, 2021 at 12:42:27PM -0800, Srivatsa, Anusha wrote:
>>
>>
>> > -Original Message-
>> > From: Intel-gfx On Behalf Of Matt
>> > Roper
>> > Sent: Thursday, March 11, 2021 2:36 PM
>> > To: intel-gfx@lists.freedesktop.org
>> > Subject:
== Series Details ==
Series: Drop relocations for new gens (rev2)
URL : https://patchwork.freedesktop.org/series/88047/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9863 -> Patchwork_19800
Summary
---
**SUCCESS**
On Thu, 11 Mar 2021, Matt Roper wrote:
> Although we've long referred to platforms by a single "GEN" number, the
> hardware teams have recommended that we stop doing this since the
> various component IP blocks are going to start using independent number
> schemes with varying cadence. To
On Thu, 11 Mar 2021, Matt Roper wrote:
> Let's start preparing for upcoming platforms that will use an XE_LPD
> design.
>
> v2:
> - Use the now-preferred "XE_LPD" term to refer to this design
> - Utilize DISPLAY_VER() rather than a feature flag
> - Drop unused mbus_size field (Lucas)
>
>
On Mon, 08 Mar 2021, Lucas De Marchi wrote:
> On Mon, Mar 08, 2021 at 03:56:39PM +0200, Jani Nikula wrote:
>>gt/intel_workarounds.c is decidedly the wrong place for handling
>>stepping info. Add new intel_step.[ch] for the data, and move the
>>stepping arrays there. No functional changes.
>>
== Series Details ==
Series: Drop relocations for new gens (rev2)
URL : https://patchwork.freedesktop.org/series/88047/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9863 -> Patchwork_19800
Summary
---
**SUCCESS**
Re-reported.
-Original Message-
From: Deak, Imre
Sent: Wednesday, March 17, 2021 3:02 AM
To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana
Subject: Re: ✗ Fi.CI.IGT: failure for drm/i915/ilk-glk: Fix link training on
links with LTTPRs
Hi Lakshmi,
On Tue, Mar 16, 2021 at
Add intel_bios_encoder_data pointer to encoder, and use it for hdmi and
dp iboost. For starters, we only set the encoder->devdata for DDI
encoders, i.e. we can only use it for data that is used by DDI encoders.
Cc: Lucas De Marchi
Cc: Ville Syrjälä
Reviewed-by: Lucas De Marchi
Signed-off-by:
Stop caching the information in ddi_port_info. We're phasing out
ddi_port_info usage completely, and prefer using the VBT child device
information directly using the provided helpers.
v2:
- Remove supports_typec_usb & supports_tbt from ddi_vbt_port_info (Lucas)
Cc: Lucas De Marchi
Cc: Ville
Start using struct intel_bios_encoder_data directly. We'll start
sanitizing the child device data directly as well, instead of the cached
data in ddi_port_info[]. The one downside here is having to store a
non-const pointer back to intel_bios_encoder_data.
Eventually we'll be able to have a
We'll be needing the intel_bios_encoder_data pointer going forward, and
it's just easier to store the higher level pointer in the
ddi_vbt_port_info[] array.
Cc: Lucas De Marchi
Cc: Ville Syrjälä
Reviewed-by: Lucas De Marchi
Signed-off-by: Jani Nikula
---
These will be exposed to the rest of the driver and replace other
functions. Everything will operate on the child devices.
v2:
- Rebased, removed stray blank line
- Also abstracted intel_bios_encoder_supports_crt (Lucas)
Cc: Lucas De Marchi
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
We'll be needing it in the future.
Cc: Lucas De Marchi
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bios.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c
b/drivers/gpu/drm/i915/display/intel_bios.c
Make the naming suitable for exposing to the rest of the driver as an
opaque type. No functional changes.
Cc: Lucas De Marchi
Cc: Ville Syrjälä
Reviewed-by: Lucas De Marchi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bios.c | 30 +++
1 file changed,
Instead of initialing data directly in ddi_port_info array, create fake
child devices for default outputs when the VBT is missing. This makes
further unification of output handling easier.
This will make intel_bios_is_port_present() return true for the fake
child devices. This may cause subtle
There are two main cases where the default outputs are useful when the
VBT is missing:
- There are some DDI-platform Chromebooks out there that do not have a
VBT, which worked by coincidence because of the default outputs. The
machines need to continue to work.
- Early platform enabling when
We'll be needing the version in more places in the future, so avoid the
need to pass it around. No functional changes.
v2: Rebased
Cc: Lucas De Marchi
Cc: Ville Syrjälä
Reviewed-by: Ville Syrjälä # v1
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bios.c | 30
Pre-DDI and non-CHV aren't using the information created here anyway, so
don't bother setting the defaults for them. This should be a
non-functional change, but is separated here to catch any regressions in
a single commit.
Cc: Lucas De Marchi
Cc: Ville Syrjälä
Reviewed-by: Ville Syrjälä
Time to just yank out the bandage. No functional changes.
v2: Rebased
Cc: Lucas De Marchi
Cc: Ville Syrjälä
Reviewed-by: Ville Syrjälä # v1
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bios.c | 766 +++---
1 file changed, 383 insertions(+), 383
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bios.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c
b/drivers/gpu/drm/i915/display/intel_bios.c
index 5e7dc0899ab1..3db41fe0c546 100644
---
Reduce indent with an early return. No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bios.c | 86 +++
1 file changed, 41 insertions(+), 45 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c
v2 of https://patchwork.freedesktop.org/series/87165/
BR,
Jani.
Jani Nikula (14):
drm/i915/bios: mass convert dev_priv to i915
drm/i915/bios: store bdb version in i915
drm/i915/bios: reduce indent in sanitize_ddc_pin and sanitize_aux_ch
drm/i915/bios: move aux ch and ddc checks at a
== Series Details ==
Series: drm/i915/ilk-glk: Fix link training on links with LTTPRs
URL : https://patchwork.freedesktop.org/series/88015/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9862_full -> Patchwork_19796_full
== Series Details ==
Series: drm/i915/ilk-glk: Fix link training on links with LTTPRs
URL : https://patchwork.freedesktop.org/series/88015/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9862_full -> Patchwork_19796_full
On Wed, Mar 17, 2021 at 09:41:46AM -0500, Jason Ekstrand wrote:
> I should probably have said that the reviews are on v5 and it's very
> different in v6 so they should probably be considered dropped until
> re-confirmed.
You're checking relocation_count early in do_execbuffer() so imo there's
no
On Wed, Mar 17, 2021 at 04:06:07PM +0200, Ville Syrjälä wrote:
> On Tue, Mar 16, 2021 at 06:54:26PM +0200, Imre Deak wrote:
> > The spec requires to use at least 3.2ms for the AUX timeout period if
> > there are LT-tunable PHY Repeaters on the link (2.11.2). An upcoming
> > spec update makes this
I should probably have said that the reviews are on v5 and it's very
different in v6 so they should probably be considered dropped until
re-confirmed.
On Wed, Mar 17, 2021 at 9:39 AM Jason Ekstrand wrote:
>
> The Vulkan driver in Mesa for Intel hardware never uses relocations if
> it's running
The Vulkan driver in Mesa for Intel hardware never uses relocations if
it's running on a version of i915 that supports at least softpin which
all versions of i915 supporting Gen12 do. On the OpenGL side, Gen12+ is
only supported by iris which never uses relocations. The older i965
driver in Mesa
On Wed, Mar 17, 2021 at 2:55 AM Petri Latvala wrote:
>
> On Mon, Mar 15, 2021 at 10:29:20PM -0700, Ashutosh Dixit wrote:
> > From: Jason Ekstrand
> >
> > The Vulkan driver in Mesa for Intel hardware never uses relocations if
> > it's running on a version of i915 that supports at least softpin
== Series Details ==
Series: Drop relocations for new gens (rev2)
URL : https://patchwork.freedesktop.org/series/88047/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9863_full -> Patchwork_19800_full
Summary
---
On Tue, Mar 16, 2021 at 06:54:26PM +0200, Imre Deak wrote:
> The spec requires to use at least 3.2ms for the AUX timeout period if
> there are LT-tunable PHY Repeaters on the link (2.11.2). An upcoming
> spec update makes this more specific, by requiring a 3.2ms minimum
> timeout period for the
== Series Details ==
Series: Drop relocations for new gens (rev2)
URL : https://patchwork.freedesktop.org/series/88047/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9863 -> Patchwork_19800
Summary
---
**SUCCESS**
== Series Details ==
Series: Drop relocations for new gens (rev2)
URL : https://patchwork.freedesktop.org/series/88047/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
10b305262f30 drm/i915/gem: Drop relocation support on all new hardware
-:34: CHECK:PREFER_KERNEL_TYPES: Prefer
Ensure we don't pass any relocation data in execbuf for any
new hardware.
Patch likely is not optimal but is doing hard cut before
entering execbuf.
v2: fixing version (< 12 instead of incidentally tested < 9)
Signed-off-by: Zbigniew Kempczyński
Cc: Jason Ekstrand
Cc: Daniel Vetter
---
Patch likely is temporary - until Jason will figure out where
to put his code and avoid unnecessary walk over the objects array.
I need this to find out what tests will fail when we disallow
passing relocations data in execbuf.
Current patch
Ensure we don't pass any relocation data in execbuf for any
new hardware.
Patch likely is not optimal but is doing hard cut before
entering execbuf.
Signed-off-by: Zbigniew Kempczyński
Cc: Jason Ekstrand
Cc: Daniel Vetter
---
.../gpu/drm/i915/gem/i915_gem_execbuffer.c| 22
Patch likely is temporary - until Jason will figure out where
to put his code and avoid unnecessary walk over the objects array.
I need this to find out what tests will fail when we disallow
passing relocations data in execbuf.
Current patch
Hi Lakshmi,
On Tue, Mar 16, 2021 at 07:25:59PM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/ilk-glk: Fix link training on links with LTTPRs
> URL : https://patchwork.freedesktop.org/series/88015/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from
On Mon, Mar 15, 2021 at 10:29:20PM -0700, Ashutosh Dixit wrote:
> From: Jason Ekstrand
>
> The Vulkan driver in Mesa for Intel hardware never uses relocations if
> it's running on a version of i915 that supports at least softpin which
> all versions of i915 supporting Gen12 do. On the OpenGL
69 matches
Mail list logo
