[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Fix the dsc check while selecting min_cdclk

2021-09-14 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix the dsc check while selecting min_cdclk URL : https://patchwork.freedesktop.org/series/94683/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10586 -> Patchwork_21053 Summary

[Intel-gfx] [PATCH] drm/i915/display: Fix the dsc check while selecting min_cdclk

2021-09-14 Thread Vandita Kulkarni
The right parameter that selects second dsc engine is dsc_split. Hence use dsc_split instead of slice_count while selecting the cdclk in order to accommodate 1ppc limitaion of vdsc. Fixes: fe01883fdcef ("drm/i915: Get proper min cdclk if vDSC enabled") Suggested-by: Jani Nikula Signed-off-by: Van

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/1] tests/i915/query: Query, parse and validate the hwconfig table

2021-09-14 Thread Matthew Brost
On Mon, Jul 26, 2021 at 05:28:12PM -0700, john.c.harri...@intel.com wrote: > From: Rodrigo Vivi > > Newer platforms have an embedded table giving details about that > platform's hardware configuration. This table can be retrieved from > the KMD via the query API. So add a test for it as both an e

Re: [Intel-gfx] [PATCH V5 1/5] drm/i915/gt: Add support of mocs propagation

2021-09-14 Thread Matt Roper
On Fri, Sep 03, 2021 at 02:51:49PM +0530, Ayaz A Siddiqui wrote: > Now there are lots of Command and registers that require mocs index > programming. > So propagating mocs_index from mocs to gt so that it can be > used directly without having platform-specific checks. > > V2: > Changed 'i915_mocs_

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Update memory bandwidth parameters (rev2)

2021-09-14 Thread Patchwork
== Series Details == Series: drm/i915: Update memory bandwidth parameters (rev2) URL : https://patchwork.freedesktop.org/series/94620/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10586_full -> Patchwork_21051_full Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc/slpc: remove unneeded clflush calls (rev2)

2021-09-14 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: remove unneeded clflush calls (rev2) URL : https://patchwork.freedesktop.org/series/94668/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10586_full -> Patchwork_21050_full Sum

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915/display: split and constify vtable (rev5)

2021-09-14 Thread Patchwork
== Series Details == Series: i915/display: split and constify vtable (rev5) URL : https://patchwork.freedesktop.org/series/94459/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10586 -> Patchwork_21052 Summary --- **F

Re: [Intel-gfx] [PATCH] drm/i915/dp: add a delay before setting panel brightness after power on

2021-09-14 Thread Vasily Khoruzhick
On Tue, Sep 14, 2021 at 3:31 PM Jani Nikula wrote: > > On Tue, 14 Sep 2021, Lyude Paul wrote: > > On Tue, 2021-09-14 at 12:09 +0300, Jani Nikula wrote: > >> On Mon, 13 Sep 2021, Vasily Khoruzhick wrote: > >> > Panel in my Dell XPS 7590, that uses Intel's HDR backlight interface to > >> > control

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915/display: split and constify vtable (rev5)

2021-09-14 Thread Patchwork
== Series Details == Series: i915/display: split and constify vtable (rev5) URL : https://patchwork.freedesktop.org/series/94459/ State : warning == Summary == $ dim checkpatch origin/drm-tip e37b65685b48 drm/i915/uncore: split the fw get function into separate vfunc 870e9ca20427 drm/i915/pm:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Update memory bandwidth parameters (rev2)

2021-09-14 Thread Patchwork
== Series Details == Series: drm/i915: Update memory bandwidth parameters (rev2) URL : https://patchwork.freedesktop.org/series/94620/ State : success == Summary == CI Bug Log - changes from CI_DRM_10586 -> Patchwork_21051 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc/slpc: remove unneeded clflush calls (rev2)

2021-09-14 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: remove unneeded clflush calls (rev2) URL : https://patchwork.freedesktop.org/series/94668/ State : success == Summary == CI Bug Log - changes from CI_DRM_10586 -> Patchwork_21050 Summary -

Re: [Intel-gfx] [PATCH 3/4] drm/i915: rename debugfs_gt_pm files

2021-09-14 Thread Matt Roper
On Fri, Sep 10, 2021 at 10:52:57AM -0700, Lucas De Marchi wrote: > On Wed, Sep 08, 2021 at 05:49:40PM -0700, Lucas De Marchi wrote: > > We shouldn't be using debugfs_ namespace for this functionality. Rename > > debugfs_gt_pm.[ch] to intel_gt_pm_debugfs.[ch] and then make > > functions, defines and

[Intel-gfx] ✗ Fi.CI.IGT: failure for Update to DMC v2.12 for ADLP

2021-09-14 Thread Patchwork
== Series Details == Series: Update to DMC v2.12 for ADLP URL : https://patchwork.freedesktop.org/series/94675/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10585_full -> Patchwork_21049_full Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH 2/4] drm/i915/guc: Do error capture asynchronously

2021-09-14 Thread Matthew Brost
On Tue, Sep 14, 2021 at 04:25:08PM +0200, Daniel Vetter wrote: > On Mon, Sep 13, 2021 at 10:09:54PM -0700, Matthew Brost wrote: > > An error capture allocates memory, memory allocations depend on resets, > > and resets need to flush the G2H handlers to seal several races. If the > > error capture i

Re: [Intel-gfx] [PATCH 01/16] Revert "drm/i915/display: Disable audio, DRRS and PSR before planes"

2021-09-14 Thread Souza, Jose
On Tue, 2021-09-14 at 16:30 -0700, José Roberto de Souza wrote: > On Tue, 2021-09-14 at 11:20 +0300, Ville Syrjälä wrote: > > On Mon, Sep 13, 2021 at 04:28:35PM +, Souza, Jose wrote: > > > On Mon, 2021-09-13 at 17:44 +0300, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > > > > > > > Disa

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc/slpc: remove unneeded clflush calls (rev2)

2021-09-14 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: remove unneeded clflush calls (rev2) URL : https://patchwork.freedesktop.org/series/94668/ State : warning == Summary == $ dim checkpatch origin/drm-tip eeef49b011c8 drm/i915/guc/slpc: remove unneeded clflush calls -:6: WARNING:TYPO_SPELLING: 'wr

Re: [Intel-gfx] [PATCH 4/4] drm/i915/guc: Refcount context during error capture

2021-09-14 Thread Matthew Brost
On Tue, Sep 14, 2021 at 04:29:21PM +0200, Daniel Vetter wrote: > On Mon, Sep 13, 2021 at 10:09:56PM -0700, Matthew Brost wrote: > > From: John Harrison > > > > When i915 receives a context reset notification from GuC, it triggers > > an error capture before resetting any outstanding requsts of th

Re: [Intel-gfx] [PATCH 01/16] Revert "drm/i915/display: Disable audio, DRRS and PSR before planes"

2021-09-14 Thread Souza, Jose
On Tue, 2021-09-14 at 11:20 +0300, Ville Syrjälä wrote: > On Mon, Sep 13, 2021 at 04:28:35PM +, Souza, Jose wrote: > > On Mon, 2021-09-13 at 17:44 +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Disabling planes in the middle of the modeset seuqnece does not make > > > sense

Re: [Intel-gfx] [PATCH 4/4] drm/i915/guc: Refcount context during error capture

2021-09-14 Thread John Harrison
On 9/14/2021 07:29, Daniel Vetter wrote: On Mon, Sep 13, 2021 at 10:09:56PM -0700, Matthew Brost wrote: From: John Harrison When i915 receives a context reset notification from GuC, it triggers an error capture before resetting any outstanding requsts of that context. Unfortunately, the error

[Intel-gfx] ✓ Fi.CI.BAT: success for Update to DMC v2.12 for ADLP

2021-09-14 Thread Patchwork
== Series Details == Series: Update to DMC v2.12 for ADLP URL : https://patchwork.freedesktop.org/series/94675/ State : success == Summary == CI Bug Log - changes from CI_DRM_10585 -> Patchwork_21049 Summary --- **SUCCESS** No reg

Re: [Intel-gfx] [PATCH] drm/i915/dp: add a delay before setting panel brightness after power on

2021-09-14 Thread Jani Nikula
On Tue, 14 Sep 2021, Lyude Paul wrote: > On Tue, 2021-09-14 at 12:09 +0300, Jani Nikula wrote: >> On Mon, 13 Sep 2021, Vasily Khoruzhick wrote: >> > Panel in my Dell XPS 7590, that uses Intel's HDR backlight interface to >> > control brightness, apparently needs a delay before setting brightness

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add MOCS tables for XeHP SDV and DG2 (rev3)

2021-09-14 Thread Matt Roper
On Wed, Sep 08, 2021 at 03:47:43AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Add MOCS tables for XeHP SDV and DG2 (rev3) > URL : https://patchwork.freedesktop.org/series/94344/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_10557_full -> Pat

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/5] drm/i915/display/adlp: Fix PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR calculation

2021-09-14 Thread Patchwork
== Series Details == Series: series starting with [v2,1/5] drm/i915/display/adlp: Fix PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR calculation URL : https://patchwork.freedesktop.org/series/94674/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10585 -> Patchwork_21048 =

Re: [Intel-gfx] [v2] drm/i915: Update memory bandwidth parameters

2021-09-14 Thread Matt Roper
On Tue, Sep 14, 2021 at 03:07:44PM -0700, Radhakrishna Sripada wrote: > Earlier while calculating derated bw we would use 90% of the calculated > bw. Starting ADL-P we use a non standard derating. Updating the formulae > to reflect the same. > > Bspec: 64631 > > v2: Use the new derating value onl

[Intel-gfx] [v2] drm/i915: Update memory bandwidth parameters

2021-09-14 Thread Radhakrishna Sripada
Earlier while calculating derated bw we would use 90% of the calculated bw. Starting ADL-P we use a non standard derating. Updating the formulae to reflect the same. Bspec: 64631 v2: Use the new derating value only for ADL-P(MattR) Fixes: 4d32fe2f14a7 ("drm/i915/adl_p: Update memory bandwidth pa

Re: [Intel-gfx] [PATCH v2 1/9] vfio/ccw: Use functions for alloc/free of the vfio_ccw_private

2021-09-14 Thread Jason Gunthorpe
On Tue, Sep 14, 2021 at 05:50:25PM +0200, Cornelia Huck wrote: > On Fri, Sep 10 2021, Christoph Hellwig wrote: > > > On Thu, Sep 09, 2021 at 04:38:41PM -0300, Jason Gunthorpe wrote: > >> + > >> + private = kzalloc(sizeof(*private), GFP_KERNEL | GFP_DMA); > >> + if (!private) > >> + ret

[Intel-gfx] [PATCH 1/1] drm/i915/dmc: Update to DMC v2.12

2021-09-14 Thread Anusha Srivatsa
The release notes mentions that this version- 1. Fix for unblock indication to punit. 2. Robustness fix for DC6/6v abort scenarios. Cc: Imre Deak > Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

[Intel-gfx] [PATCH 0/1] Update to DMC v2.12 for ADLP

2021-09-14 Thread Anusha Srivatsa
linux-firmware: add frimware for mediatek bluetooth chip (MT7922) (2021-09-13 11:35:49 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware adlp_dmc_2_12 for you to fetch changes up to 09ab718bfa2b32a2186dd8f9e39e0cc9a9df7170: i915: Update ADLP DM

[Intel-gfx] [PATCH v2 5/5] drm/i915/display/adlp: Add new PSR2 workarounds

2021-09-14 Thread José Roberto de Souza
Wa_16014451276 fixes the starting coordinate for PSR2 selective updates. CHICKEN_TRANS definition of the workaround bit has a wrong name based on workaround definition and HSD. Wa_14014971508 allows the screen to continue to be updated when coming back from DC5/DC6 and SF_SINGLE_FULL_FRAME bit is

[Intel-gfx] [PATCH v2 4/5] drm/i915/display/psr: Use drm damage helpers to calculate plane damaged area

2021-09-14 Thread José Roberto de Souza
drm_atomic_helper_damage_iter_init() + drm_atomic_for_each_plane_damage() returns the full plane area in case no damaged area was set by userspace or it was discarted by driver. This is important to fix the rendering of userspace applications that does frontbuffer rendering and notify driver about

[Intel-gfx] [PATCH v2 3/5] drm/i915/display: Workaround cursor left overs with PSR2 selective fetch enabled

2021-09-14 Thread José Roberto de Souza
Not sure why but when moving the cursor fast it causes some artifacts of the cursor to be left in the cursor path, adding some pixels above the cursor to the damaged area fixes the issue, so leaving this as a workaround until proper fix is found. This is reproducile on TGL and ADL-P. Cc: Gwan-gye

[Intel-gfx] [PATCH v2 2/5] drm/i915/display: Wait at least 2 frames before selective update

2021-09-14 Thread José Roberto de Souza
BSpec states that the minimum number of frames before selective update is 2, so making sure this minimum limit is fulfilled. BSpec: 50422 Reviewed-by: Gwan-gyeong Mun Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 2 +- 1 file changed, 1

[Intel-gfx] [PATCH v2 1/5] drm/i915/display/adlp: Fix PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR calculation

2021-09-14 Thread José Roberto de Souza
As the SU_REGION_START begins at 0, the SU_REGION_END should be number of lines - 1. BSpec: 50424 Reviewed-by: Gwan-gyeong Mun Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Do not define vma on stack

2021-09-14 Thread Matthew Brost
On Tue, Sep 14, 2021 at 10:05:03PM +0200, Daniel Vetter wrote: > On Tue, Sep 14, 2021 at 08:36:56AM -0700, Matthew Brost wrote: > > On Tue, Sep 14, 2021 at 03:04:59PM +1000, Dave Airlie wrote: > > > On Tue, 14 Sept 2021 at 14:55, Matthew Brost > > > wrote: > > > > > > > > From: Venkata Sandeep Dh

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Suspend / resume backup- and restore of LMEM. (rev4)

2021-09-14 Thread Patchwork
== Series Details == Series: drm/i915: Suspend / resume backup- and restore of LMEM. (rev4) URL : https://patchwork.freedesktop.org/series/94278/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10584_full -> Patchwork_21046_full ==

Re: [Intel-gfx] [PATCH] drm/i915/dp: add a delay before setting panel brightness after power on

2021-09-14 Thread Lyude Paul
On Tue, 2021-09-14 at 12:09 +0300, Jani Nikula wrote: > On Mon, 13 Sep 2021, Vasily Khoruzhick wrote: > > Panel in my Dell XPS 7590, that uses Intel's HDR backlight interface to > > control brightness, apparently needs a delay before setting brightness > > after power on. Without this delay the pa

Re: [Intel-gfx] [PATCH] drm/i915: Update memory bandwidth parameters

2021-09-14 Thread Matt Roper
On Mon, Sep 13, 2021 at 10:42:54AM -0700, Radhakrishna Sripada wrote: > Earlier while calculating derated bw we would use 90% of the calculated > bw. Starting ADL-P we use a non standard derating. Updating the formulae > to reflect the same. > > Bspec: 64631 > > Fixes: 4d32fe2f14a7 ("drm/i915/adl

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc/slpc: remove unneeded clflush calls

2021-09-14 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: remove unneeded clflush calls URL : https://patchwork.freedesktop.org/series/94668/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10584 -> Patchwork_21047 Summary --- *

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc/slpc: remove unneeded clflush calls

2021-09-14 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: remove unneeded clflush calls URL : https://patchwork.freedesktop.org/series/94668/ State : warning == Summary == $ dim checkpatch origin/drm-tip a021bf892e8d drm/i915/guc/slpc: remove unneeded clflush calls -:6: WARNING:TYPO_SPELLING: 'writting'

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Suspend / resume backup- and restore of LMEM. (rev4)

2021-09-14 Thread Patchwork
== Series Details == Series: drm/i915: Suspend / resume backup- and restore of LMEM. (rev4) URL : https://patchwork.freedesktop.org/series/94278/ State : success == Summary == CI Bug Log - changes from CI_DRM_10584 -> Patchwork_21046 Summar

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Do not define vma on stack

2021-09-14 Thread Daniel Vetter
On Tue, Sep 14, 2021 at 08:36:56AM -0700, Matthew Brost wrote: > On Tue, Sep 14, 2021 at 03:04:59PM +1000, Dave Airlie wrote: > > On Tue, 14 Sept 2021 at 14:55, Matthew Brost > > wrote: > > > > > > From: Venkata Sandeep Dhanalakota > > > > > > Defining vma on stack can cause stack overflow, if >

Re: [Intel-gfx] [PATCH] drm/i915/guc: Refcount context during error capture

2021-09-14 Thread Daniel Vetter
On Mon, Sep 13, 2021 at 02:17:42PM -0700, Matthew Brost wrote: > On Mon, Sep 13, 2021 at 02:10:16PM -0700, john.c.harri...@intel.com wrote: > > From: John Harrison > > > > When i915 receives a context reset notification from GuC, it triggers > > an error capture before resetting any outstanding r

[Intel-gfx] [PATCH] drm/i915/guc/slpc: remove unneeded clflush calls

2021-09-14 Thread Lucas De Marchi
The clflush calls here aren't doing anything since we are not writting something and flushing the cache lines to be visible to GuC. Here the intention seems to be to make sure whatever GuC has written is visible to the CPU before we read them. However a clflush from the CPU side is the wrong instru

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Suspend / resume backup- and restore of LMEM. (rev4)

2021-09-14 Thread Patchwork
== Series Details == Series: drm/i915: Suspend / resume backup- and restore of LMEM. (rev4) URL : https://patchwork.freedesktop.org/series/94278/ State : warning == Summary == $ dim checkpatch origin/drm-tip c4b15f1489b7 drm/i915/ttm: Implement a function to copy the contents of two TTM-based

[Intel-gfx] [PATCH v3 6/6] drm/i915: Reduce the number of objects subject to memcpy recover

2021-09-14 Thread Thomas Hellström
We really only need memcpy restore for objects that affect the operability of the migrate context. That is, primarily the page-table objects of the migrate VM. Add an object flag, I915_BO_ALLOC_PM_EARLY for objects that need early restores using memcpy and a way to assign LMEM page-table object fl

[Intel-gfx] [PATCH v3 5/6] drm/i915: Don't back up pinned LMEM context images and rings during suspend

2021-09-14 Thread Thomas Hellström
Pinned context images are now reset during resume. Don't back them up, and assuming that rings can be assumed empty at suspend, don't back them up either. Introduce a new object flag, I915_BO_ALLOC_PM_VOLATILE meaning that an object is allowed to lose its content on suspend. v3: - Slight document

[Intel-gfx] [PATCH v3 4/6] drm/i915/gt: Register the migrate contexts with their engines

2021-09-14 Thread Thomas Hellström
Pinned contexts, like the migrate contexts need reset after resume since their context image may have been lost. Also the GuC needs to register pinned contexts. Add a list to struct intel_engine_cs where we add all pinned contexts on creation, and traverse that list at resume time to reset the pin

[Intel-gfx] [PATCH v3 3/6] drm/i915 Implement LMEM backup and restore for suspend / resume

2021-09-14 Thread Thomas Hellström
Just evict unpinned objects to system. For pinned LMEM objects, make a backup system object and blit the contents to that. Backup is performed in three steps, 1: Opportunistically evict evictable objects using the gpu blitter. 2: After gt idle, evict evictable objects using the gpu blitter. This w

[Intel-gfx] [PATCH v3 2/6] drm/i915/gem: Implement a function to process all gem objects of a region

2021-09-14 Thread Thomas Hellström
An upcoming common pattern is to traverse the region object list and perform certain actions on all objects in a region. It's a little tricky to get the list locking right, in particular since a gem object may change region unless it's pinned or the object lock is held. Define a function that does

[Intel-gfx] [PATCH v3 1/6] drm/i915/ttm: Implement a function to copy the contents of two TTM-based objects

2021-09-14 Thread Thomas Hellström
When backing up or restoring contents of pinned objects at suspend / resume time we need to allocate a new object as the backup. Add a function to facilitate copies between the two. Some data needs to be copied before the migration context is ready for operation, so make sure we can disable acceler

[Intel-gfx] [PATCH v3 0/6] drm/i915: Suspend / resume backup- and restore of LMEM.

2021-09-14 Thread Thomas Hellström
Implement backup and restore of LMEM during suspend / resume. What complicates things a bit is handling of pinned LMEM memory during suspend and the fact that we might be dealing with unmappable LMEM in the future, which makes us want to restrict the number of pinned objects that need memcpy resume

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915/display: split and constify vtable (rev4)

2021-09-14 Thread Patchwork
== Series Details == Series: i915/display: split and constify vtable (rev4) URL : https://patchwork.freedesktop.org/series/94459/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10584 -> Patchwork_21045 Summary --- **F

Re: [Intel-gfx] [PATCH v9 12/17] drm/i915/pxp: Enable PXP power management

2021-09-14 Thread Rodrigo Vivi
On Fri, Sep 10, 2021 at 08:36:22AM -0700, Daniele Ceraolo Spurio wrote: > From: "Huang, Sean Z" > > During the power event S3+ sleep/resume, hardware will lose all the > encryption keys for every hardware session, even though the > session state might still be marked as alive after resume. Theref

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915/display: split and constify vtable (rev4)

2021-09-14 Thread Patchwork
== Series Details == Series: i915/display: split and constify vtable (rev4) URL : https://patchwork.freedesktop.org/series/94459/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5757b633382c drm/i915/uncore: split the fw get function into separate vfunc 09e6590ba72b drm/i915/pm:

[Intel-gfx] [PATCH 24/24] drm/i915: constify display wm vtable

2021-09-14 Thread Jani Nikula
From: Dave Airlie Use a nop table for the cases where CxSR doesn't init properly. v2: use a nop table (Jani) Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 34 - drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH 21/24] drm/i915: drop unused function ptr and comments.

2021-09-14 Thread Jani Nikula
From: Dave Airlie There was some excess comments and an unused vtbl ptr. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/

[Intel-gfx] [PATCH 23/24] drm/i915: constify clock gating init vtable.

2021-09-14 Thread Jani Nikula
From: Dave Airlie I used a macro to avoid making any really silly mistakes here. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_pm.c | 78 +++-- 2 files changed

[Intel-gfx] [PATCH 22/24] drm/i915: constify display function vtable

2021-09-14 Thread Jani Nikula
From: Dave Airlie Make nice clear tables instead of having things in two places. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 81 drivers/gpu/drm/i915/i915_drv.h | 2 +- 2

[Intel-gfx] [PATCH 19/24] drm/i915: constify the dpll clock vtable

2021-09-14 Thread Jani Nikula
From: Dave Airlie Most the dpll vtable into read-only memory. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 6 +-- drivers/gpu/drm/i915/display/intel_dpll.c| 48 drivers/gpu/drm/i915

[Intel-gfx] [PATCH 20/24] drm/i915: constify the cdclk vtable

2021-09-14 Thread Jani Nikula
From: Dave Airlie This is a bit of a twisty one since each platform is slightly different, so might take some more review care. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 300 ++--- drivers/g

[Intel-gfx] [PATCH 18/24] drm/i915: constify the audio function vtable

2021-09-14 Thread Jani Nikula
From: Dave Airlie Move the functions into read-only tables. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_audio.c | 43 ++ drivers/gpu/drm/i915/i915_drv.h| 2 +- 2 files changed, 28 inser

[Intel-gfx] [PATCH 17/24] drm/i915: constify color function vtable.

2021-09-14 Thread Jani Nikula
From: Dave Airlie This clarifies quite well what functions get used on what platforms instead of having to decipher the old tree. v2: fixed IVB mistake (Jani) Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_color.c | 138

[Intel-gfx] [PATCH 16/24] drm/i915: constify hotplug function vtable.

2021-09-14 Thread Jani Nikula
From: Dave Airlie Use a macro to avoid mistakes, this type of macro is only used in a couple of places. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hotplug.c | 4 +-- drivers/gpu/drm/i915/i915_drv.h | 2

[Intel-gfx] [PATCH 15/24] drm/i915: constify fdi link training vtable

2021-09-14 Thread Jani Nikula
From: Dave Airlie Put the vtable into ro memory. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fdi.c | 20 drivers/gpu/drm/i915/i915_drv.h | 2 +- 2 files changed, 17 insertions(+), 5 delet

[Intel-gfx] [PATCH 14/24] drm/i915: split the dpll clock compute out from display vtable.

2021-09-14 Thread Jani Nikula
From: Dave Airlie this single function might be possible to merge later, but for now it's simple to just split it out. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 6 +++--- drivers/gpu/drm/i915/display/int

[Intel-gfx] [PATCH 13/24] drm/i915: split fdi link training from display vtable.

2021-09-14 Thread Jani Nikula
From: Dave Airlie It may make sense to merge this with display again later, however the fdi use of the vtable is limited to only a few generations. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fdi.c | 8 drive

[Intel-gfx] [PATCH 12/24] drm/i915: split irq hotplug function from display vtable

2021-09-14 Thread Jani Nikula
From: Dave Airlie This provide a service from irq to display, so make it separate Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hotplug.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h | 9 - drivers/gp

[Intel-gfx] [PATCH 11/24] drm/i915: split cdclk functions from display vtable.

2021-09-14 Thread Jani Nikula
From: Dave Airlie This moves all the cdclk related functions into their own vtable. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 142 ++--- drivers/gpu/drm/i915/i915_drv.h| 8 +-

[Intel-gfx] [PATCH 10/24] drm/i915: split audio functions from display vtable

2021-09-14 Thread Jani Nikula
From: Dave Airlie These are only used internally in the audio code Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_audio.c | 24 +++--- drivers/gpu/drm/i915/i915_drv.h| 19 +++-- 2 f

[Intel-gfx] [PATCH 09/24] drm/i915: split color functions from display vtable

2021-09-14 Thread Jani Nikula
From: Dave Airlie These are only used internally in the color module Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_color.c | 64 +++--- drivers/gpu/drm/i915/i915_drv.h| 39 +++-- 2 fil

[Intel-gfx] [PATCH 08/24] drm/i915: split watermark vfuncs from display vtable.

2021-09-14 Thread Jani Nikula
From: Dave Airlie These are the watermark api between display and pm. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 35 - drivers/gpu/drm/i915/i915_drv.h | 24 driver

[Intel-gfx] [PATCH 07/24] drm/i915: split clock gating init from display vtable

2021-09-14 Thread Jani Nikula
From: Dave Airlie This function is only used inside intel_pm.c Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 9 ++- drivers/gpu/drm/i915/intel_pm.c | 48 - 2 files changed, 32 insertio

[Intel-gfx] [PATCH 05/24] drm/i915: add wrappers around cdclk vtable funcs.

2021-09-14 Thread Jani Nikula
From: Dave Airlie This adds wrappers around all the vtable callers so they are in one place. Suggested by Jani. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c| 47 +++ drivers/gpu/drm/i915/dis

[Intel-gfx] [PATCH 06/24] drm/i915/display: add intel_fdi_link_train wrapper.

2021-09-14 Thread Jani Nikula
From: Dave Airlie This wraps the fdi link training vfunc to make it clearer. Suggested by Jani. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/intel_fdi.c | 8

[Intel-gfx] [PATCH 04/24] drm/i915/wm: provide wrappers around watermark vfuncs calls (v2)

2021-09-14 Thread Jani Nikula
From: Dave Airlie This moves one wrapper from the pm->display side, and creates wrappers for all the others, this should simplify things later. One thing to note is that the code checks the existance of some of these ptrs, so the wrappers are a bit complicated by that. Suggested by Jani. v2: f

[Intel-gfx] [PATCH 03/24] drm/i915: make update_wm take a dev_priv.

2021-09-14 Thread Jani Nikula
From: Dave Airlie The crtc was never being used here. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 10 +- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH 02/24] drm/i915/pm: drop get_fifo_size vfunc.

2021-09-14 Thread Jani Nikula
From: Dave Airlie The i845_update_wm code was always calling the i845 variant, and the i9xx_update_wm had only a choice between i830 and i9xx paths, hardly worth the vfunc overhead. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_d

[Intel-gfx] [PATCH 01/24] drm/i915/uncore: split the fw get function into separate vfunc

2021-09-14 Thread Jani Nikula
From: Dave Airlie constify it while here. drop the put function since it was never overloaded and always has done the same thing, no point in indirecting it for show. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_uncore.c | 70 +

[Intel-gfx] [PATCH 00/24] i915/display: split and constify vtable (v5)

2021-09-14 Thread Jani Nikula
This is Dave's series [1] with patch 2 (drm/i915/uncore: constify the register vtables.) dropped because it conflicts between drm-intel-next and drm-intel-gt-next. I want to get proper CI results on this before merging. We can do the leftover patch afterwards. Everything else is unmodified. BR, Ja

Re: [Intel-gfx] [PATCH 09/25] drm/i915: split watermark vfuncs from display vtable.

2021-09-14 Thread Jani Nikula
On Fri, 10 Sep 2021, Dave Airlie wrote: > From: Dave Airlie > > These are the watermark api between display and pm. > > Signed-off-by: Dave Airlie Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_display.c | 35 - > drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Move vfio_ccw to the new mdev API (rev3)

2021-09-14 Thread Patchwork
== Series Details == Series: Move vfio_ccw to the new mdev API (rev3) URL : https://patchwork.freedesktop.org/series/94520/ State : failure == Summary == Patch is empty. When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead.

Re: [Intel-gfx] [PATCH 08/27] drm/i915: Add logical engine mapping

2021-09-14 Thread Matthew Brost
On Tue, Sep 14, 2021 at 09:34:08AM +0100, Tvrtko Ursulin wrote: > > On 13/09/2021 17:50, Matthew Brost wrote: > > On Mon, Sep 13, 2021 at 10:24:43AM +0100, Tvrtko Ursulin wrote: > > > > > > On 10/09/2021 20:49, Matthew Brost wrote: > > > > On Fri, Sep 10, 2021 at 12:12:42PM +0100, Tvrtko Ursulin

Re: [Intel-gfx] [PATCH 1/2] drm/i915/xehpsdv: Define MOCS table for XeHP SDV

2021-09-14 Thread Clint Taylor
Appears to match latest BSPEC Reviewed-by: Clint Taylor -Clint On 9/3/21 5:35 PM, Matt Roper wrote: From: Lucas De Marchi Like DG1, XeHP SDV doesn't have LLC/eDRAM control values due to being a dgfx card. XeHP SDV adds 2 more bits: L3_GLBGO to "push the Go point to memory for L3 destined t

Re: [Intel-gfx] [PATCH v2 0/9] Move vfio_ccw to the new mdev API

2021-09-14 Thread Jason Gunthorpe
On Mon, Sep 13, 2021 at 04:31:54PM -0400, Eric Farman wrote: > > I rebased it and fixed it up here: > > > > https://github.com/jgunthorpe/linux/tree/vfio_ccw > > > > Can you try again? > > That does address the crash, but then why is it processing a BROKEN > event? Seems problematic. The stuff

Re: [Intel-gfx] [PATCH v2 2/7] drm/ttm: add TTM_PAGE_FLAG_SHMEM

2021-09-14 Thread Matthew Auld
On Tue, 14 Sept 2021 at 10:03, Christian König wrote: > > Am 14.09.21 um 10:50 schrieb Matthew Auld: > > Add new flag to indicate special shmem based tt, which can directly > > handle swapping itself, and should be visible to some shrinker. > > > > As part of this we should skip the ttm_pages_allo

Re: [Intel-gfx] [PATCH 07/25] drm/i915/display: add intel_fdi_link_train wrapper.

2021-09-14 Thread Jani Nikula
On Fri, 10 Sep 2021, Dave Airlie wrote: > From: Dave Airlie > > This wraps the fdi link training vfunc to make it clearer. > > Suggested by Jani. > > Signed-off-by: Dave Airlie Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_display.c | 2 +- > drivers/gpu/drm/i915/displ

Re: [Intel-gfx] [PATCH 06/25] drm/i915: add wrappers around cdclk vtable funcs.

2021-09-14 Thread Jani Nikula
On Fri, 10 Sep 2021, Dave Airlie wrote: > From: Dave Airlie > > This adds wrappers around all the vtable callers so they are in > one place. > > Suggested by Jani. > > Signed-off-by: Dave Airlie Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_cdclk.c| 47

Re: [Intel-gfx] [PATCH 05/25] drm/i915/wm: provide wrappers around watermark vfuncs calls (v2)

2021-09-14 Thread Jani Nikula
On Fri, 10 Sep 2021, Dave Airlie wrote: > From: Dave Airlie > > This moves one wrapper from the pm->display side, and creates > wrappers for all the others, this should simplify things later. > > One thing to note is that the code checks the existance of some > of these ptrs, so the wrappers are

Re: [Intel-gfx] [PATCH 0/3] drm/i915: Enable -Wsometimes-uninitialized

2021-09-14 Thread Jani Nikula
On Mon, 13 Sep 2021, Nathan Chancellor wrote: > On Tue, Aug 24, 2021 at 03:54:24PM -0700, Nathan Chancellor wrote: >> Commit 46e2068081e9 ("drm/i915: Disable some extra clang warnings") >> disabled -Wsometimes-uninitialized as noisy but there have been a few >> fixes to clang that make the false p

[Intel-gfx] ✗ Fi.CI.BAT: failure for Do error capture async, flush G2H processing on reset (rev3)

2021-09-14 Thread Patchwork
== Series Details == Series: Do error capture async, flush G2H processing on reset (rev3) URL : https://patchwork.freedesktop.org/series/94642/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10583 -> Patchwork_21043 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Do error capture async, flush G2H processing on reset (rev3)

2021-09-14 Thread Patchwork
== Series Details == Series: Do error capture async, flush G2H processing on reset (rev3) URL : https://patchwork.freedesktop.org/series/94642/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +dr

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enable GuC submission by default on DG1 (rev6)

2021-09-14 Thread Patchwork
== Series Details == Series: Enable GuC submission by default on DG1 (rev6) URL : https://patchwork.freedesktop.org/series/93325/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10583 -> Patchwork_21042 Summary --- **F

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable GuC submission by default on DG1 (rev6)

2021-09-14 Thread Patchwork
== Series Details == Series: Enable GuC submission by default on DG1 (rev6) URL : https://patchwork.freedesktop.org/series/93325/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/

Re: [Intel-gfx] [PATCH v2 1/9] vfio/ccw: Use functions for alloc/free of the vfio_ccw_private

2021-09-14 Thread Cornelia Huck
On Fri, Sep 10 2021, Christoph Hellwig wrote: > On Thu, Sep 09, 2021 at 04:38:41PM -0300, Jason Gunthorpe wrote: >> + >> +private = kzalloc(sizeof(*private), GFP_KERNEL | GFP_DMA); >> +if (!private) >> +return ERR_PTR(-ENOMEM); > > Nit: there is no need to add GFP_KERNEL when

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Do not define vma on stack

2021-09-14 Thread Matthew Brost
On Tue, Sep 14, 2021 at 03:04:59PM +1000, Dave Airlie wrote: > On Tue, 14 Sept 2021 at 14:55, Matthew Brost wrote: > > > > From: Venkata Sandeep Dhanalakota > > > > Defining vma on stack can cause stack overflow, if > > vma gets populated with new fields. > > Is there some higher level locking s

Re: [Intel-gfx] [RFC PATCH] drm/ttm: Add a private member to the struct ttm_resource

2021-09-14 Thread Thomas Hellström
On 9/14/21 4:07 PM, Daniel Vetter wrote: On Tue, Sep 14, 2021 at 12:38:00PM +0200, Thomas Hellström wrote: On Tue, 2021-09-14 at 10:53 +0200, Christian König wrote: Am 14.09.21 um 10:27 schrieb Thomas Hellström: On Tue, 2021-09-14 at 09:40 +0200, Christian König wrote: Am 13.09.21 um 14:41

Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC engine for higher moderates

2021-09-14 Thread Jani Nikula
On Tue, 14 Sep 2021, "Kulkarni, Vandita" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Tuesday, September 14, 2021 7:33 PM >> To: Lisovskiy, Stanislav >> Cc: Ville Syrjälä ; Kulkarni, Vandita >> ; intel-gfx@lists.freedesktop.org; Navare, >> Manasi D >> Subject: Re: [Intel-

Re: [Intel-gfx] [PATCH 1/4] drm/i915: rename debugfs_gt files

2021-09-14 Thread Jani Nikula
On Tue, 14 Sep 2021, Lucas De Marchi wrote: > On Tue, Sep 14, 2021 at 12:16:13PM +0300, Jani Nikula wrote: >>On Wed, 08 Sep 2021, Lucas De Marchi wrote: >>> We shouldn't be using debugfs_ namespace for this functionality. Rename >>> debugfs_gt.[ch] to intel_gt_debugfs.[ch] and then make functions

Re: [Intel-gfx] [PATCH 1/4] drm/i915: rename debugfs_gt files

2021-09-14 Thread Lucas De Marchi
On Tue, Sep 14, 2021 at 12:16:13PM +0300, Jani Nikula wrote: On Wed, 08 Sep 2021, Lucas De Marchi wrote: We shouldn't be using debugfs_ namespace for this functionality. Rename debugfs_gt.[ch] to intel_gt_debugfs.[ch] and then make functions, defines and structs follow suit. While at it and si

Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC engine for higher moderates

2021-09-14 Thread Kulkarni, Vandita
> -Original Message- > From: Nikula, Jani > Sent: Tuesday, September 14, 2021 7:33 PM > To: Lisovskiy, Stanislav > Cc: Ville Syrjälä ; Kulkarni, Vandita > ; intel-gfx@lists.freedesktop.org; Navare, > Manasi D > Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC > engin

  1   2   >