Re: [Intel-gfx] [PATCH v2] drm/i915/gt: move remaining debugfs interfaces into gt

2021-10-07 Thread Lucas De Marchi
On Thu, Oct 7, 2021 at 5:27 PM Andi Shyti wrote: > > From: Andi Shyti > > The following interfaces: > > i915_wedged > i915_forcewake_user > i915_gem_interrupt > > are dependent on gt values. Put them inside gt/ and drop the > "i915_" prefix name. This would be the new structure: > > dri/0

[Intel-gfx] ✗ Fi.CI.BAT: failure for Fixup header includes (rev2)

2021-10-07 Thread Patchwork
== Series Details == Series: Fixup header includes (rev2) URL : https://patchwork.freedesktop.org/series/95587/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10697 -> Patchwork_21289 Summary --- **FAILURE** Seriou

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fixup header includes (rev2)

2021-10-07 Thread Patchwork
== Series Details == Series: Fixup header includes (rev2) URL : https://patchwork.freedesktop.org/series/95587/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/gt/intel_engi

[Intel-gfx] [PATCH v2] drm/i915/gt: move remaining debugfs interfaces into gt

2021-10-07 Thread Andi Shyti
From: Andi Shyti The following interfaces: i915_wedged i915_forcewake_user i915_gem_interrupt are dependent on gt values. Put them inside gt/ and drop the "i915_" prefix name. This would be the new structure: dri/0/gt | +-- forcewake_user | +-- interrupt_info | \-- reset F

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: move remaining debugfs interfaces into gt (rev8)

2021-10-07 Thread Patchwork
== Series Details == Series: drm/i915/gt: move remaining debugfs interfaces into gt (rev8) URL : https://patchwork.freedesktop.org/series/75333/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10696_full -> Patchwork_21288_full ===

Re: [Intel-gfx] [PATCH] drm/i915/gem: Check function return in live_nop_switch

2021-10-07 Thread kernel test robot
Hi Oak, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip v5.15-rc4 next-20211007] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: move remaining debugfs interfaces into gt (rev8)

2021-10-07 Thread Patchwork
== Series Details == Series: drm/i915/gt: move remaining debugfs interfaces into gt (rev8) URL : https://patchwork.freedesktop.org/series/75333/ State : success == Summary == CI Bug Log - changes from CI_DRM_10696 -> Patchwork_21288 Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Simplify handling of modifiers (rev9)

2021-10-07 Thread Patchwork
== Series Details == Series: drm/i915: Simplify handling of modifiers (rev9) URL : https://patchwork.freedesktop.org/series/95579/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10696_full -> Patchwork_21287_full Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: move remaining debugfs interfaces into gt (rev8)

2021-10-07 Thread Patchwork
== Series Details == Series: drm/i915/gt: move remaining debugfs interfaces into gt (rev8) URL : https://patchwork.freedesktop.org/series/75333/ State : warning == Summary == $ dim checkpatch origin/drm-tip 81673b413127 drm/i915/gt: move remaining debugfs interfaces into gt -:125: WARNING:FILE

Re: [Intel-gfx] [PATCH 08/26] drm/i915/guc: Add multi-lrc context registration

2021-10-07 Thread Matthew Brost
On Thu, Oct 07, 2021 at 12:50:28PM -0700, John Harrison wrote: > On 10/4/2021 15:06, Matthew Brost wrote: > > Add multi-lrc context registration H2G. In addition a workqueue and > > process descriptor are setup during multi-lrc context registration as > > these data structures are needed for multi-

Re: [Intel-gfx] [PATCH 02/26] drm/i915/guc: Take GT PM ref when deregistering context

2021-10-07 Thread Matthew Brost
On Wed, Oct 06, 2021 at 08:37:03PM -0700, John Harrison wrote: > On 10/4/2021 15:06, Matthew Brost wrote: > > Taking a PM reference to prevent intel_gt_wait_for_idle from short > > circuiting while a deregister context H2G is in flight. To do this must > > issue the deregister H2G from a worker as

Re: [Intel-gfx] [PATCH 03/26] drm/i915/guc: Take engine PM when a context is pinned with GuC submission

2021-10-07 Thread Matthew Brost
On Thu, Oct 07, 2021 at 11:15:51AM -0700, John Harrison wrote: > On 10/7/2021 08:19, Matthew Brost wrote: > > On Wed, Oct 06, 2021 at 08:45:42PM -0700, John Harrison wrote: > > > On 10/4/2021 15:06, Matthew Brost wrote: > > > > Taking a PM reference to prevent intel_gt_wait_for_idle from short > >

Re: [Intel-gfx] [PATCH 10/26] drm/i915/guc: Assign contexts in parent-child relationship consecutive guc_ids

2021-10-07 Thread Matthew Brost
On Thu, Oct 07, 2021 at 03:03:04PM -0700, John Harrison wrote: > On 10/4/2021 15:06, Matthew Brost wrote: > > Assign contexts in parent-child relationship consecutive guc_ids. This > > is accomplished by partitioning guc_id space between ones that need to > > be consecutive (1/16 available guc_ids)

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Simplify handling of modifiers (rev9)

2021-10-07 Thread Patchwork
== Series Details == Series: drm/i915: Simplify handling of modifiers (rev9) URL : https://patchwork.freedesktop.org/series/95579/ State : success == Summary == CI Bug Log - changes from CI_DRM_10696 -> Patchwork_21287 Summary --- **

Re: [Intel-gfx] [PATCH 3/3] drm/i915/display: remove unused intel-mid.h include

2021-10-07 Thread Souza, Jose
On Thu, 2021-10-07 at 16:32 -0700, Lucas De Marchi wrote: > Nothing from intel-mid.h and this is only available on x86, so remove it > as we prepare support for other architectures. Whole series is Reviewed-by: José Roberto de Souza > > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH 03/26] drm/i915/guc: Take engine PM when a context is pinned with GuC submission

2021-10-07 Thread John Harrison
On 10/7/2021 08:19, Matthew Brost wrote: On Wed, Oct 06, 2021 at 08:45:42PM -0700, John Harrison wrote: On 10/4/2021 15:06, Matthew Brost wrote: Taking a PM reference to prevent intel_gt_wait_for_idle from short circuiting while a scheduling of user context could be enabled. I'm not sure what

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Simplify handling of modifiers (rev9)

2021-10-07 Thread Patchwork
== Series Details == Series: drm/i915: Simplify handling of modifiers (rev9) URL : https://patchwork.freedesktop.org/series/95579/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Simplify handling of modifiers (rev9)

2021-10-07 Thread Patchwork
== Series Details == Series: drm/i915: Simplify handling of modifiers (rev9) URL : https://patchwork.freedesktop.org/series/95579/ State : warning == Summary == $ dim checkpatch origin/drm-tip bdfa60b8fbc5 drm/i915: Add a table with a descriptor for all i915 modifiers e97b1f8c3ad0 drm/i915: Mo

[Intel-gfx] ✗ Fi.CI.BAT: failure for Fixup header includes

2021-10-07 Thread Patchwork
== Series Details == Series: Fixup header includes URL : https://patchwork.freedesktop.org/series/95587/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10696 -> Patchwork_21286 Summary --- **FAILURE** Serious unkno

[Intel-gfx] [PATCH v2 11/11] drm/i915: Add functions to check for RC CCS CC and MC CCS modifiers

2021-10-07 Thread Imre Deak
Instead of open-coding the checks add functions for this, simplifying the handling of CCS modifiers on future platforms. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_fb.c | 24 +++ drivers/gpu/drm/i915/display/intel_fb.h | 2 ++ .../drm/i915/displa

[Intel-gfx] [PATCH v2 03/11] drm/i915: Add tiling attribute to the modifier descriptor

2021-10-07 Thread Imre Deak
Add a tiling atttribute to the modifier descriptor, which let's us get the tiling without listing the modifiers twice. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_fb.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] [PATCH v2 10/11] drm/i915: Move is_ccs_modifier() to intel_fb.c

2021-10-07 Thread Imre Deak
Move the function to intel_fb.c and rename it adding the intel_fb_ prefix following the naming of exported functions. Signed-off-by: Imre Deak --- .../drm/i915/display/intel_display_types.h| 9 -- drivers/gpu/drm/i915/display/intel_fb.c | 29 ++- drivers/gpu/drm/i9

[Intel-gfx] [PATCH v2 07/11] drm/i915: Add a platform independent way to get the RC CCS CC plane

2021-10-07 Thread Imre Deak
On future platforms the index of the color-clear plane will change from the one used by the GEN12 RC CCS CC modifier, so add a way to retrieve the index independently of the platform/modifier. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_display.c | 10 +--- drivers/gpu/dr

[Intel-gfx] [PATCH v2 05/11] drm/i915: Unexport is_semiplanar_uv_plane()

2021-10-07 Thread Imre Deak
This function is only used by intel_fb.c, so unexport it. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_fb.c | 2 +- drivers/gpu/drm/i915/display/intel_fb.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/g

[Intel-gfx] [PATCH v2 09/11] drm/i915: Add a platform independent way to check for CCS control planes

2021-10-07 Thread Imre Deak
Future platforms change the location of CCS control planes in CCS framebuffers, so add intel_fb_is_rc_ccs_ctrl_plane() to query for these planes independently of the platform. This function can be used everywhere instead of is_ccs_plane() (or is_ccs_plane() && !cc_plane()), since all the callers ar

[Intel-gfx] [PATCH v2 01/11] drm/i915: Add a table with a descriptor for all i915 modifiers

2021-10-07 Thread Imre Deak
Add a table describing all the framebuffer modifiers used by i915 at one place. This has the benefit of deduplicating the listing of supported modifiers for each platform and checking the support of these modifiers on a given plane. This also simplifies in a similar way getting some attribute for a

[Intel-gfx] [PATCH v2 02/11] drm/i915: Move intel_get_format_info() to intel_fb.c

2021-10-07 Thread Imre Deak
Move the function retrieving the format override information for a given format/modifier to intel_fb.c. We can store a pointer to the format list in each modifier's descriptor instead of the corresponding switch/case logic, avoiding the listing of the modifiers twice. v2: Handle invalid modifiers

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fixup header includes

2021-10-07 Thread Patchwork
== Series Details == Series: Fixup header includes URL : https://patchwork.freedesktop.org/series/95587/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/gt/intel_engine_stat

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers

2021-10-07 Thread Patchwork
== Series Details == Series: drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers URL : https://patchwork.freedesktop.org/series/95578/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10696_full -> Patchwork_21282_full Summary --

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/pmu: Add a name to the execlists stats

2021-10-07 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/pmu: Add a name to the execlists stats URL : https://patchwork.freedesktop.org/series/95586/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10696 -> Patchwork_21285 ===

[Intel-gfx] [PATCH 3/3] drm/i915/display: remove unused intel-mid.h include

2021-10-07 Thread Lucas De Marchi
Nothing from intel-mid.h and this is only available on x86, so remove it as we prepare support for other architectures. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c

[Intel-gfx] [PATCH 1/3] drm/i915/gt: include tsc.h where used

2021-10-07 Thread Lucas De Marchi
We are currently using tsc_khz as a fallback so add the right include. For other architectures we may need to add a different fallback, but this is not being used by dgfx so we may as well just paper it over. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/intel_llc.c | 1 + 1 file ch

[Intel-gfx] [PATCH 0/3] Fixup header includes

2021-10-07 Thread Lucas De Marchi
Some low hanging fruits to start supporting other architectures. Let's make sure we include what we use, particularly when the header is arch-dependent. Lucas De Marchi (3): drm/i915/gt: include tsc.h where used drm/i915/gt: add asm/cacheflush.h for use of clflush() drm/i915/display: remove

[Intel-gfx] [PATCH 2/3] drm/i915/gt: add asm/cacheflush.h for use of clflush()

2021-10-07 Thread Lucas De Marchi
Let's include what we use instead of relying on other indirect includes. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/intel_engine.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gt/intel_engine.h b/drivers/gpu/drm/i915/gt/intel_engine.h index 452248884e

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915/pmu: Add a name to the execlists stats

2021-10-07 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/pmu: Add a name to the execlists stats URL : https://patchwork.freedesktop.org/series/95586/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gt/uc/intel_guc.h:167: warning: Funct

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/pmu: Add a name to the execlists stats

2021-10-07 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/pmu: Add a name to the execlists stats URL : https://patchwork.freedesktop.org/series/95586/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked se

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/pmu: Add a name to the execlists stats

2021-10-07 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/pmu: Add a name to the execlists stats URL : https://patchwork.freedesktop.org/series/95586/ State : warning == Summary == $ dim checkpatch origin/drm-tip ffc67cf0919d drm/i915/pmu: Add a name to the execlists stats 03bcbfdbe47d

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev7)

2021-10-07 Thread Patchwork
== Series Details == Series: drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev7) URL : https://patchwork.freedesktop.org/series/95127/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10696_full -> Patchwork_21281_full ===

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Connect engine busyness stats from GuC to pmu

2021-10-07 Thread Umesh Nerlige Ramappa
On Tue, Oct 05, 2021 at 04:14:23PM -0700, Matthew Brost wrote: On Tue, Oct 05, 2021 at 10:47:11AM -0700, Umesh Nerlige Ramappa wrote: With GuC handling scheduling, i915 is not aware of the time that a context is scheduled in and out of the engine. Since i915 pmu relies on this info to provide en

[Intel-gfx] [PATCH 1/2] drm/i915/pmu: Add a name to the execlists stats

2021-10-07 Thread Umesh Nerlige Ramappa
In preparation for GuC pmu stats, add a name to the execlists stats structure so that it can be differentiated from the GuC stats. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/gt/intel_engine_cs.c| 14 +++--- drivers/gpu/drm/i915/gt/intel_engine_stats.h | 33 +++-- d

[Intel-gfx] [PATCH 2/2] drm/i915/pmu: Connect engine busyness stats from GuC to pmu

2021-10-07 Thread Umesh Nerlige Ramappa
With GuC handling scheduling, i915 is not aware of the time that a context is scheduled in and out of the engine. Since i915 pmu relies on this info to provide engine busyness to the user, GuC shares this info with i915 for all engines using shared memory. For each engine, this info contains: - to

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gem: Check function return in live_nop_switch

2021-10-07 Thread Patchwork
== Series Details == Series: drm/i915/gem: Check function return in live_nop_switch URL : https://patchwork.freedesktop.org/series/95584/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compi

Re: [Intel-gfx] [PATCH 10/26] drm/i915/guc: Assign contexts in parent-child relationship consecutive guc_ids

2021-10-07 Thread John Harrison
On 10/4/2021 15:06, Matthew Brost wrote: Assign contexts in parent-child relationship consecutive guc_ids. This is accomplished by partitioning guc_id space between ones that need to be consecutive (1/16 available guc_ids) and ones that do not (15/16 of available guc_ids). The consecutive search

Re: [Intel-gfx] [PATCH 01/11] drm/i915: Add a table with a descriptor for all i915 modifiers

2021-10-07 Thread Imre Deak
On Fri, Oct 08, 2021 at 12:32:57AM +0300, Ville Syrjälä wrote: > On Fri, Oct 08, 2021 at 12:26:11AM +0300, Imre Deak wrote: > > On Fri, Oct 08, 2021 at 12:10:00AM +0300, Ville Syrjälä wrote: > > > On Thu, Oct 07, 2021 at 11:35:07PM +0300, Imre Deak wrote: > > > > Add a table describing all the fram

[Intel-gfx] [PATCH] drm/i915/gem: Check function return in live_nop_switch

2021-10-07 Thread Oak Zeng
Fail this test earlier if i915_request_await_dma_fence fails. Signed-off-by: Oak Zeng --- drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i91

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Simplify handling of modifiers

2021-10-07 Thread Patchwork
== Series Details == Series: drm/i915: Simplify handling of modifiers URL : https://patchwork.freedesktop.org/series/95579/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10696 -> Patchwork_21283 Summary --- **FAILURE

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Simplify handling of modifiers

2021-10-07 Thread Patchwork
== Series Details == Series: drm/i915: Simplify handling of modifiers URL : https://patchwork.freedesktop.org/series/95579/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/d

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Simplify handling of modifiers

2021-10-07 Thread Patchwork
== Series Details == Series: drm/i915: Simplify handling of modifiers URL : https://patchwork.freedesktop.org/series/95579/ State : warning == Summary == $ dim checkpatch origin/drm-tip b43f636afaea drm/i915: Add a table with a descriptor for all i915 modifiers 147f27b14377 drm/i915: Move inte

Re: [Intel-gfx] [PATCH 01/11] drm/i915: Add a table with a descriptor for all i915 modifiers

2021-10-07 Thread Ville Syrjälä
On Fri, Oct 08, 2021 at 12:26:11AM +0300, Imre Deak wrote: > On Fri, Oct 08, 2021 at 12:10:00AM +0300, Ville Syrjälä wrote: > > On Thu, Oct 07, 2021 at 11:35:07PM +0300, Imre Deak wrote: > > > Add a table describing all the framebuffer modifiers used by i915 at one > > > place. This has the benefit

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers

2021-10-07 Thread Patchwork
== Series Details == Series: drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers URL : https://patchwork.freedesktop.org/series/95578/ State : success == Summary == CI Bug Log - changes from CI_DRM_10696 -> Patchwork_21282 Summary --- *

Re: [Intel-gfx] [PATCH 01/11] drm/i915: Add a table with a descriptor for all i915 modifiers

2021-10-07 Thread Imre Deak
On Fri, Oct 08, 2021 at 12:10:00AM +0300, Ville Syrjälä wrote: > On Thu, Oct 07, 2021 at 11:35:07PM +0300, Imre Deak wrote: > > Add a table describing all the framebuffer modifiers used by i915 at one > > place. This has the benefit of deduplicating the listing of supported > > modifiers for each p

Re: [Intel-gfx] [PATCH 01/11] drm/i915: Add a table with a descriptor for all i915 modifiers

2021-10-07 Thread Ville Syrjälä
On Thu, Oct 07, 2021 at 11:35:07PM +0300, Imre Deak wrote: > Add a table describing all the framebuffer modifiers used by i915 at one > place. This has the benefit of deduplicating the listing of supported > modifiers for each platform and checking the support of these modifiers > on a given plane.

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers

2021-10-07 Thread Patchwork
== Series Details == Series: drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers URL : https://patchwork.freedesktop.org/series/95578/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -drivers/gpu/drm/

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers

2021-10-07 Thread Patchwork
== Series Details == Series: drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers URL : https://patchwork.freedesktop.org/series/95578/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8d34fdf1cc49 drm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN() 7cbf763b4871

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev7)

2021-10-07 Thread Patchwork
== Series Details == Series: drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev7) URL : https://patchwork.freedesktop.org/series/95127/ State : success == Summary == CI Bug Log - changes from CI_DRM_10696 -> Patchwork_21281 =

[Intel-gfx] [PATCH 11/11] drm/i915: Add functions to check for RC CCS CC and MC CCS modifiers

2021-10-07 Thread Imre Deak
Instead of open-coding the checks add functions for this, simplifying the handling of CCS modifiers on future platforms. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_fb.c | 24 +++ drivers/gpu/drm/i915/display/intel_fb.h | 2 ++ .../drm/i915/displa

[Intel-gfx] [PATCH 10/11] drm/i915: Move is_ccs_modifier() to intel_fb.c

2021-10-07 Thread Imre Deak
Move the function to intel_fb.c and rename it adding the intel_fb_ prefix following the naming of exported functions. Signed-off-by: Imre Deak --- .../drm/i915/display/intel_display_types.h| 9 -- drivers/gpu/drm/i915/display/intel_fb.c | 29 ++- drivers/gpu/drm/i9

[Intel-gfx] [PATCH 07/11] drm/i915: Add a platform independent way to get the RC CCS CC plane

2021-10-07 Thread Imre Deak
On future platforms the index of the color-clear plane will change from the one used by the GEN12 RC CCS CC modifier, so add a way to retrieve the index independently of the platform/modifier. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_display.c | 10 +--- drivers/gpu/dr

[Intel-gfx] [PATCH 09/11] drm/i915: Add a platform independent way to check for CCS control planes

2021-10-07 Thread Imre Deak
Future platforms change the location of CCS control planes in CCS framebuffers, so add intel_fb_is_rc_ccs_ctrl_plane() to query for these planes independently of the platform. This function can be used everywhere instead of is_ccs_plane() (or is_ccs_plane() && !cc_plane()), since all the callers ar

[Intel-gfx] [PATCH 06/11] drm/i915: Move intel_format_info_is_yuv_semiplanar() to intel_fb.c

2021-10-07 Thread Imre Deak
Move intel_format_info_is_yuv_semiplanar() to intel_fb.c . The number of planes for YUV semiplanar formats using CCS modifiers will change on future platforms. We can use the modifier descriptors to simplify getting the plane numbers for all modifiers, prepare for that here. Signed-off-by: Imre De

[Intel-gfx] [PATCH 08/11] drm/i915: Handle CCS CC planes separately from CCS control planes

2021-10-07 Thread Imre Deak
CCS CC planes are quite different from CCS control planes, even though we regard the CC planes as a linear buffer having a 64 byte stride. Thus it's clearer to check for either CCS plane types explicitly when we need to handle them; add the required CCS CC planes check here, while the next patch wi

[Intel-gfx] [PATCH 05/11] drm/i915: Unexport is_semiplanar_uv_plane()

2021-10-07 Thread Imre Deak
This function is only used by intel_fb.c, so unexport it. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_fb.c | 2 +- drivers/gpu/drm/i915/display/intel_fb.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/g

[Intel-gfx] [PATCH 04/11] drm/i915: Simplify the modifier check for interlaced scanout support

2021-10-07 Thread Imre Deak
Checking the modifiers that support interlacing makes the condition simpler and avoids us having to add new modifiers to the list (presuming all/most of the new modifiers won't support interlacing). Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/skl_universal_plane.c | 9 ++--- 1

[Intel-gfx] [PATCH 03/11] drm/i915: Add tiling attribute to the modifier descriptor

2021-10-07 Thread Imre Deak
Add a tiling atttribute to the modifier descriptor, which let's us get the tiling without listing the modifiers twice. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_fb.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] [PATCH 02/11] drm/i915: Move intel_get_format_info() to intel_fb.c

2021-10-07 Thread Imre Deak
Move the function retrieving the format override information for a given format/modifier to intel_fb.c. We can store a pointer to the format list in each modifier's descriptor instead of the corresponding switch/case logic, avoiding the listing of the modifiers twice. Signed-off-by: Imre Deak ---

[Intel-gfx] [PATCH 01/11] drm/i915: Add a table with a descriptor for all i915 modifiers

2021-10-07 Thread Imre Deak
Add a table describing all the framebuffer modifiers used by i915 at one place. This has the benefit of deduplicating the listing of supported modifiers for each platform and checking the support of these modifiers on a given plane. This also simplifies in a similar way getting some attribute for a

[Intel-gfx] [PATCH 00/11] drm/i915: Simplify handling of modifiers

2021-10-07 Thread Imre Deak
This patchset adds a descriptor table for all modifiers used by i915, which deduplicates the listing of supported modifiers during plane initialization and during checking for a modifier support on a plane. This also simplifies getting some modifier attributes like checking if a plane is a CCS modi

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev7)

2021-10-07 Thread Patchwork
== Series Details == Series: drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev7) URL : https://patchwork.freedesktop.org/series/95127/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked

Re: [Intel-gfx] [PATCH 09/26] drm/i915/guc: Ensure GuC schedule operations do not operate on child contexts

2021-10-07 Thread John Harrison
On 10/4/2021 15:06, Matthew Brost wrote: In GuC parent-child contexts the parent context controls the scheduling, ensure only the parent does the scheduling operations. Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 13 +

Re: [Intel-gfx] [PATCH 08/26] drm/i915/guc: Add multi-lrc context registration

2021-10-07 Thread John Harrison
On 10/4/2021 15:06, Matthew Brost wrote: Add multi-lrc context registration H2G. In addition a workqueue and process descriptor are setup during multi-lrc context registration as these data structures are needed for multi-lrc submission. v2: (John Harrison) - Move GuC specific fields into s

[Intel-gfx] [PATCH v3 20/20] drm: cleanup: remove acquire_ctx from drm_mode_config

2021-10-07 Thread Fernando Ramos
--- include/drm/drm_mode_config.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h index 48b7de80daf5..b214b07157f2 100644 --- a/include/drm/drm_mode_config.h +++ b/include/drm/drm_mode_config.h @@ -383,16 +383,6 @@ struct

[Intel-gfx] [PATCH v3 19/20] drm: cleanup: remove drm_modeset_(un)lock_all()

2021-10-07 Thread Fernando Ramos
Functions drm_modeset_lock_all() and drm_modeset_unlock_all() are no longer used anywhere and can be removed. Signed-off-by: Fernando Ramos --- drivers/gpu/drm/drm_modeset_lock.c | 94 +- include/drm/drm_modeset_lock.h | 2 - 2 files changed, 3 insertions(+), 93

[Intel-gfx] [PATCH v3 18/20] drm/amd: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() [part 3]

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() NOTE: While this change is similar to the one done two commits ago, it contains an important extra nuances that I'm going to explain next. T

[Intel-gfx] [PATCH v3 17/20] drm/amd: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() [part 2]

2021-10-07 Thread Fernando Ramos
Refactor places using drm_modeset_{lock,unlock}_all() so that they only appear once per function. This is needed so that in the next commit I can replace those functions by the new macros (which use labels that can only appear once per function). Signed-off-by: Fernando Ramos --- .../gpu/drm/am

[Intel-gfx] [PATCH v3 16/20] drm/amd: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 21 ++--- 1 file changed, 14 insertions(+),

[Intel-gfx] [PATCH v3 15/20] drm/gma500: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/gma500/psb_device.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions

[Intel-gfx] [PATCH v3 14/20] drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() [part 3]

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() NOTE: While the previous two commits were a simple "search and replace", this time I had to do a bit of refactoring as only one call to DRM_M

[Intel-gfx] [PATCH v3 13/20] drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() [part 2]

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() NOTE: I separated this change from the rest of modifications to the i915 driver to point out something special explained next. The only diff

[Intel-gfx] [PATCH v3 12/20] drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/i915/display/intel_audio.c| 16 --- .../drm/i915/display/intel_display_debugfs.c

[Intel-gfx] [PATCH v3 11/20] drm/msm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-)

[Intel-gfx] [PATCH v3 10/20] drm/nouveau: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 15 ++- 1 file changed, 10 i

[Intel-gfx] [PATCH v3 09/20] drm/omapdrm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/omapdrm/omap_fb.c | 9 ++--- 1 file changed, 6 insertions(+),

[Intel-gfx] [PATCH v3 08/20] drm/radeon: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/radeon/radeon_device.c | 21 +++-- drivers/gpu/drm/radeon/radeon_dp_mst.c

[Intel-gfx] [PATCH v3 07/20] drm/shmobile: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/shmobile/shmob_drm_drv.c | 6 -- 1 file changed, 4 insertions(

[Intel-gfx] [PATCH v3 06/20] drm/tegra: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul Reported-by: kernel test robot --- drivers/gpu/drm/tegra/dsi.c | 6 -- drivers/

[Intel-gfx] [PATCH v3 05/20] drm/vmwgfx: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 11 +++ drivers/gpu/drm/vmwgfx/vmw

[Intel-gfx] [PATCH v3 04/20] drm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/drm_client_modeset.c | 5 +++-- drivers/gpu/drm/drm_crtc_helper.c

[Intel-gfx] [PATCH v3 03/20] drm/msm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace the boilerplate code surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul Reported-by: kernel test robot --- drivers/gpu/drm/msm/disp/msm_

[Intel-gfx] [PATCH v3 02/20] drm/i915: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace the boilerplate code surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/i915/display/intel_display.c | 18 +--

[Intel-gfx] [PATCH v3 01/20] drm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace the boilerplate code surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/drm_client_modeset.c | 9 +++-- 1 file changed, 3 insertions(+),

[Intel-gfx] [PATCH v3 00/20] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers

2021-10-07 Thread Fernando Ramos
Hi all, One of the things in the DRM TODO list ("Documentation/gpu/todo.rst") was to "use DRM_MODESET_LOCAL_ALL_* helpers instead of boilerplate". That's what this patch series is about. You will find two types of changes here: - Replacing "drm_modeset_lock_all_ctx()" (and surrounding boilerpl

Re: [Intel-gfx] [PATCH 07/26] drm/i915/guc: Introduce context parent-child relationship

2021-10-07 Thread John Harrison
On 10/4/2021 15:06, Matthew Brost wrote: Introduce context parent-child relationship. Once this relationship is created all pinning / unpinning operations are directed to the parent context. The parent context is responsible for pinning all of its' No need for an apostrophe. children and itsel

Re: [Intel-gfx] [PATCH 05/26] drm/i915: Add logical engine mapping

2021-10-07 Thread John Harrison
On 10/4/2021 15:06, Matthew Brost wrote: Add logical engine mapping. This is required for split-frame, as workloads need to be placed on engines in a logically contiguous manner. v2: (Daniel Vetter) - Add kernel doc for new fields v3 (Tvrtko) - Update comment for new logical_mask field

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Fix up skl_program_plane() pxp stuff

2021-10-07 Thread Rodrigo Vivi
On Thu, Oct 07, 2021 at 02:57:02AM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > There's lots of expensive stuff inserted between the PLANE_CTL > and PLANE_SURF writes even though the comment before the PLANE_CTL > write says not to put stuff there. Move it all to a more apporiate > plac

Re: [Intel-gfx] [PATCH v3] drm/i915: remove IS_ACTIVE

2021-10-07 Thread Masahiro Yamada
On Wed, Oct 6, 2021 at 2:21 AM Lucas De Marchi wrote: > > When trying to bring IS_ACTIVE to linux/kconfig.h I thought it wouldn't > provide much value just encapsulating it in a boolean context. So I also > added the support for handling undefined macros as the IS_ENABLED() > counterpart. However

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v7,1/8] drm/i915/gem: Break out some shmem backend utils

2021-10-07 Thread Christian König
Am 07.10.21 um 17:53 schrieb Tvrtko Ursulin: On 07/10/2021 16:18, Vudum, Lakshminarayana wrote: -Original Message- From: Tvrtko Ursulin Sent: Thursday, October 7, 2021 6:41 AM To: Christian König ; intel-gfx@lists.freedesktop.org Cc: Vudum, Lakshminarayana Subject: Re: [Intel-gfx] ✗

Re: [Intel-gfx] [PATCH 01/26] drm/i915/guc: Move GuC guc_id allocation under submission state sub-struct

2021-10-07 Thread John Harrison
On 10/7/2021 08:05, Matthew Brost wrote: On Wed, Oct 06, 2021 at 08:06:41PM -0700, John Harrison wrote: On 10/4/2021 15:06, Matthew Brost wrote: Move guc_id allocation under submission state sub-struct as a future patch will reuse the spin lock as a global submission state lock. Moving this int

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/panelreplay: Added state checker for panel replay state

2021-10-07 Thread Jani Nikula
On Thu, 07 Oct 2021, Animesh Manna wrote: > has_panel_replay flag is used to check panel replay state > which is part of crtc_state structure. > > Signed-off-by: Animesh Manna > --- > drivers/gpu/drm/i915/display/intel_display.c | 1 + > drivers/gpu/drm/i915/display/intel_psr.c | 2 ++ > 2 f

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/panelreplay: enable/disable panel replay

2021-10-07 Thread Jani Nikula
On Thu, 07 Oct 2021, Animesh Manna wrote: > TRANS_DP2_CTL register is programmed to enable panel replay from source > and sink is enabled through panel replay dpcd configuration address. > > Signed-off-by: Animesh Manna > --- > drivers/gpu/drm/i915/display/intel_psr.c | 30 --

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/panelreplay: Initializaton and compute config for panel replay

2021-10-07 Thread Jani Nikula
On Thu, 07 Oct 2021, Animesh Manna wrote: > As panel replay feature similar to PSR feature of EDP panel, so currently > utilized existing psr framework for panel replay. > > v1: RFC version. > v2: optimized code, pr_enabled and pr_dpcd variable removed. [Jose] > > Signed-off-by: Animesh Manna > -

  1   2   >