Re: [Intel-gfx] [PATCH] drm/i915: Add checks to prevent NULL pointer dereference

2021-11-15 Thread Thomas Hellström
Hi, Harish, On 11/16/21 02:46, Harish Chegondi wrote: __sg_next() returns NULL if the input sg entry is the last entry in the list. Check the return pointer from __sg_next() to prevent NULL pointer dereference. Did you actually hit a NULL pointer dereference here? I can't see how we could hit

Re: [Intel-gfx] [PATCH v3 5/6] drm/i915/ttm: Implement asynchronous TTM moves

2021-11-15 Thread Thomas Hellström
On 11/15/21 18:16, Matthew Auld wrote: Thanks for reviewing, Matthew, I'll take a look at the comments. /Thomas On 14/11/2021 11:12, Thomas Hellström wrote: Don't wait sync while migrating, but rather make the GPU blit await the dependencies and add a moving fence to the object. This als

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add checks to prevent NULL pointer dereference

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915: Add checks to prevent NULL pointer dereference URL : https://patchwork.freedesktop.org/series/96943/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10882_full -> Patchwork_21593_full Su

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add checks to prevent NULL pointer dereference

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915: Add checks to prevent NULL pointer dereference URL : https://patchwork.freedesktop.org/series/96943/ State : success == Summary == CI Bug Log - changes from CI_DRM_10882 -> Patchwork_21593 Summary

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Add checks to prevent NULL pointer dereference

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915: Add checks to prevent NULL pointer dereference URL : https://patchwork.freedesktop.org/series/96943/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Excess function param

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/adlp: Remove require_force_probe protection

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915/adlp: Remove require_force_probe protection URL : https://patchwork.freedesktop.org/series/96939/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10882_full -> Patchwork_21592_full Summar

[Intel-gfx] [PATCH] drm/i915: Add checks to prevent NULL pointer dereference

2021-11-15 Thread Harish Chegondi
__sg_next() returns NULL if the input sg entry is the last entry in the list. Check the return pointer from __sg_next() to prevent NULL pointer dereference. Cc: Matthew Auld Cc: Thomas Hellström Signed-off-by: Harish Chegondi --- drivers/gpu/drm/i915/i915_scatterlist.c | 10 ++ 1 file

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/adlp: Remove require_force_probe protection

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915/adlp: Remove require_force_probe protection URL : https://patchwork.freedesktop.org/series/96939/ State : success == Summary == CI Bug Log - changes from CI_DRM_10882 -> Patchwork_21592 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pmu: Increase the live_engine_busy_stats sample period (rev2)

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Increase the live_engine_busy_stats sample period (rev2) URL : https://patchwork.freedesktop.org/series/96840/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10882_full -> Patchwork_21591_full ==

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/adlp: Remove require_force_probe protection

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915/adlp: Remove require_force_probe protection URL : https://patchwork.freedesktop.org/series/96939/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Excess function parameter

[Intel-gfx] [PATCH] drm/i915/adlp: Remove require_force_probe protection

2021-11-15 Thread clinton . a . taylor
From: Clint Taylor drm/i915/adlp: Remove require_force_probe protection Removing force probe protection from ADL_P platform. Did not observe warnings, errors, flickering or any visual defects while doing ordinary tasks like browsing and editing documents in a two monitor setu

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Increase the live_engine_busy_stats sample period (rev2)

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Increase the live_engine_busy_stats sample period (rev2) URL : https://patchwork.freedesktop.org/series/96840/ State : success == Summary == CI Bug Log - changes from CI_DRM_10882 -> Patchwork_21591

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/pmu: Increase the live_engine_busy_stats sample period (rev2)

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Increase the live_engine_busy_stats sample period (rev2) URL : https://patchwork.freedesktop.org/series/96840/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Excess f

[Intel-gfx] [PATCH] drm/i915/pmu: Increase the live_engine_busy_stats sample period

2021-11-15 Thread Umesh Nerlige Ramappa
Irrespective of the backend for request submissions, busyness for an engine with an active context is calculated using: busyness = total + (current_time - context_switch_in_time) In execlists mode of operation, the context switch events are handled by the CPU. Context switch in/out time and curre

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/hdcp: Pull HDCP auth/exchange/check into helpers (rev4)

2021-11-15 Thread Patchwork
== Series Details == Series: drm/hdcp: Pull HDCP auth/exchange/check into helpers (rev4) URL : https://patchwork.freedesktop.org/series/94712/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10882 -> Patchwork_21590 Summary -

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/hdcp: Pull HDCP auth/exchange/check into helpers (rev4)

2021-11-15 Thread Patchwork
== Series Details == Series: drm/hdcp: Pull HDCP auth/exchange/check into helpers (rev4) URL : https://patchwork.freedesktop.org/series/94712/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Excess function pa

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/hdcp: Pull HDCP auth/exchange/check into helpers (rev4)

2021-11-15 Thread Patchwork
== Series Details == Series: drm/hdcp: Pull HDCP auth/exchange/check into helpers (rev4) URL : https://patchwork.freedesktop.org/series/94712/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +dri

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/hdcp: Pull HDCP auth/exchange/check into helpers (rev4)

2021-11-15 Thread Patchwork
== Series Details == Series: drm/hdcp: Pull HDCP auth/exchange/check into helpers (rev4) URL : https://patchwork.freedesktop.org/series/94712/ State : warning == Summary == $ dim checkpatch origin/drm-tip afa25cacbd67 drm/hdcp: Add drm_hdcp_atomic_check() -:11: WARNING:BAD_SIGN_OFF: Duplicate

Re: [Intel-gfx] [PATCH 12/26] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2

2021-11-15 Thread Christian König
Am 15.11.21 um 15:08 schrieb Daniel Vetter: On Mon, Nov 15, 2021 at 03:03:53PM +0100, Sascha Hauer wrote: Hi, On Fri, Sep 17, 2021 at 02:34:59PM +0200, Christian König wrote: Simplifying the code a bit. v2: use dma_resv_for_each_fence Signed-off-by: Christian König --- drivers/gpu/drm/sch

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix fastsets on TypeC ports following a non-blocking modeset (rev2)

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915: Fix fastsets on TypeC ports following a non-blocking modeset (rev2) URL : https://patchwork.freedesktop.org/series/96867/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10882_full -> Patchwork_21589_full ==

[Intel-gfx] [PATCH v4.5 12/14] dt-bindings: msm/dp: Add bindings for HDCP registers

2021-11-15 Thread Sean Paul
From: Sean Paul This patch adds the bindings for the MSM DisplayPort HDCP registers which are required to write the HDCP key into the display controller as well as the registers to enable HDCP authentication/key exchange/encryption. We'll use a new compatible string for this since the fields are

Re: [Intel-gfx] [PATCH] drm/i915/gem: Don't try to map and fence large scanout buffers (v4)

2021-11-15 Thread Kasireddy, Vivek
Hi Ville, Tvrtko, Any further comments on v4 of this patch? > On platforms capable of allowing 8K (7680 x 4320) modes, pinning 2 or > more framebuffers/scanout buffers results in only one that is mappable/ > fenceable. Therefore, pageflipping between these 2 FBs where only one > is mappable/fenc

Re: [Intel-gfx] [PATCH] drm/i915: Disable D3Cold in s2idle and runtime pm

2021-11-15 Thread Rodrigo Vivi
On Mon, Nov 15, 2021 at 09:10:54PM +0530, Tilak Tangudu wrote: > s2idle and runtime pm puts the pci gfx device in D3Hot, ACPI runtime > monitors the pci tree,if it sees complete tree as D3Hot,it transitions > the device to D3Cold.But i915 do not have D3Cold support in S2idle or in > runtime pm. so

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Clean up PIPEMISC register defines

2021-11-15 Thread Rodrigo Vivi
On Fri, Nov 12, 2021 at 09:38:06PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Use REG_BIT() & co. for PIPEMISC* bits, and while at it > fill in the missing dithering bits since we already had some > of them defined. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/displ

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Clean up CRC register defines

2021-11-15 Thread Rodrigo Vivi
On Fri, Nov 12, 2021 at 09:38:11PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Use REG_BIT() & co. for the CRC registers. > > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_reg.h | 77 ++--- > 1 file changed, 41

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Clean up DPINVGTT/VLV_DPFLIPSTAT bits

2021-11-15 Thread Rodrigo Vivi
On Fri, Nov 12, 2021 at 09:38:12PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Use REG_BIT() & co. for DPINVTT/VLV_DPFLIPSTAT bits. > > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_irq.c | 2 +- > drivers/gpu/drm/i915/i915_reg.h | 94 ++

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Clean up FPGA_DBG/CLAIM_ER bits

2021-11-15 Thread Rodrigo Vivi
On Fri, Nov 12, 2021 at 09:38:13PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Use REG_BIT() & co. for FPGA_DBG/CLAIM_ER bits. > > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_reg.h | 8 > 1 file changed, 4 insertions(+), 4 dele

Re: [Intel-gfx] [PATCH 1/9] drm/i915: Bump DSL linemask to 20 bits

2021-11-15 Thread Rodrigo Vivi
On Fri, Nov 12, 2021 at 09:38:05PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Since tgl PIPE_DSL has 20 bits for the scanline. Let's bump our > definition to match. And while at it let's also add the define > for the current field readback. > > We can also get rid of the gen2 vs. gen3

Re: [Intel-gfx] [PATCH] drm/i915/dp: Perform 30ms delay after source OUI write

2021-11-15 Thread Lyude Paul
On Mon, 2021-11-15 at 12:53 +0200, Jani Nikula wrote: > On Fri, 12 Nov 2021, Lyude Paul wrote: > > While working on supporting the Intel HDR backlight interface, I noticed > > that there's a couple of laptops that will very rarely manage to boot up > > without detecting Intel HDR backlight support

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Disable D3Cold in s2idle and runtime pm

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915: Disable D3Cold in s2idle and runtime pm URL : https://patchwork.freedesktop.org/series/96914/ State : success == Summary == CI Bug Log - changes from CI_DRM_10882_full -> Patchwork_21588_full Summary -

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix fastsets on TypeC ports following a non-blocking modeset (rev2)

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915: Fix fastsets on TypeC ports following a non-blocking modeset (rev2) URL : https://patchwork.freedesktop.org/series/96867/ State : success == Summary == CI Bug Log - changes from CI_DRM_10882 -> Patchwork_21589

Re: [Intel-gfx] [PATCH] drm/i915: Don't read query SSEU for non-existent slice 0 on old platforms

2021-11-15 Thread Rodrigo Vivi
On Fri, Nov 12, 2021 at 08:01:07AM -0800, Matt Roper wrote: > Pre-HSW platforms don't use the gt SSEU structures; this means that > calling intel_sseu_get_subslices() on slice 0 for these platforms will > trip a GEM_BUG_ON(slice >= sseu->max_slices) warning. > > Let's move the DSS lookup for a DG2

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Fix fastsets on TypeC ports following a non-blocking modeset (rev2)

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915: Fix fastsets on TypeC ports following a non-blocking modeset (rev2) URL : https://patchwork.freedesktop.org/series/96867/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix fastsets on TypeC ports following a non-blocking modeset (rev2)

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915: Fix fastsets on TypeC ports following a non-blocking modeset (rev2) URL : https://patchwork.freedesktop.org/series/96867/ State : warning == Summary == $ dim checkpatch origin/drm-tip 16eaaf636f97 drm/i915: Fix fastsets on TypeC ports following a non-blo

[Intel-gfx] [PATCH v2] drm/i915: Fix fastsets on TypeC ports following a non-blocking modeset

2021-11-15 Thread Imre Deak
After a non-blocking modeset on a TypeC port's CRTC - possibly blocked later in drm_atomic_helper_wait_for_dependencies() - a fastset on the same CRTC may copy the state of CRTC before this gets updated to reflect the up-to-date DP-alt vs. TBT-alt TypeC mode DPLL used for the CRTC. In this case aft

Re: [Intel-gfx] [PATCH] drm/i915: Fix fastsets on TypeC ports following a non-blocking modeset

2021-11-15 Thread Imre Deak
On Mon, Nov 15, 2021 at 07:33:58PM +0200, Ville Syrjälä wrote: > On Mon, Nov 15, 2021 at 07:26:59PM +0200, Imre Deak wrote: > > On Mon, Nov 15, 2021 at 05:38:58PM +0200, Ville Syrjälä wrote: > > > On Mon, Nov 15, 2021 at 02:45:36PM +0200, Imre Deak wrote: > > > > On Fri, Nov 12, 2021 at 11:14:52PM

Re: [Intel-gfx] [PATCH] drm/i915: Fix fastsets on TypeC ports following a non-blocking modeset

2021-11-15 Thread Ville Syrjälä
On Mon, Nov 15, 2021 at 07:26:59PM +0200, Imre Deak wrote: > On Mon, Nov 15, 2021 at 05:38:58PM +0200, Ville Syrjälä wrote: > > On Mon, Nov 15, 2021 at 02:45:36PM +0200, Imre Deak wrote: > > > On Fri, Nov 12, 2021 at 11:14:52PM +0200, Ville Syrjälä wrote: > > > > On Fri, Nov 12, 2021 at 09:09:04PM

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/fbc: fix the FBC kernel-doc warnings

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915/fbc: fix the FBC kernel-doc warnings URL : https://patchwork.freedesktop.org/series/96911/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10882_full -> Patchwork_21587_full Summary -

Re: [Intel-gfx] [PATCH] drm/i915: Fix fastsets on TypeC ports following a non-blocking modeset

2021-11-15 Thread Imre Deak
On Mon, Nov 15, 2021 at 05:38:58PM +0200, Ville Syrjälä wrote: > On Mon, Nov 15, 2021 at 02:45:36PM +0200, Imre Deak wrote: > > On Fri, Nov 12, 2021 at 11:14:52PM +0200, Ville Syrjälä wrote: > > > On Fri, Nov 12, 2021 at 09:09:04PM +0200, Imre Deak wrote: > > > > After a non-blocking modeset on a T

Re: [Intel-gfx] [PATCH 0/3] drm/i915, agp/intel-ggt: clean up includes

2021-11-15 Thread Jani Nikula
On Mon, 15 Nov 2021, Jani Nikula wrote: > On Mon, 15 Nov 2021, Daniel Vetter wrote: >> On Mon, Nov 15, 2021 at 01:55:32PM +0200, Jani Nikula wrote: >>> On Mon, 15 Nov 2021, Jani Nikula wrote: >>> > Took Andy's patch [1] and expanded on it a bit. >>> > >>> > BR, >>> > Jani. >>> > >>> > >>> > [1]

Re: [Intel-gfx] [PATCH v3] drm/i915/display: Exit PSR when doing async flips

2021-11-15 Thread Ville Syrjälä
On Tue, Nov 09, 2021 at 07:13:34PM +, Souza, Jose wrote: > On Fri, 2021-11-05 at 19:55 +0200, Ville Syrjälä wrote: > > On Fri, Nov 05, 2021 at 05:44:21PM +, Souza, Jose wrote: > > > On Fri, 2021-11-05 at 15:46 +0200, Ville Syrjälä wrote: > > > > On Thu, Nov 04, 2021 at 05:56:52PM +, Sou

Re: [Intel-gfx] [PATCH v3 5/6] drm/i915/ttm: Implement asynchronous TTM moves

2021-11-15 Thread Matthew Auld
On 14/11/2021 11:12, Thomas Hellström wrote: Don't wait sync while migrating, but rather make the GPU blit await the dependencies and add a moving fence to the object. This also enables asynchronous VRAM management in that on eviction, rather than waiting for the moving fence to expire before fr

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Disable D3Cold in s2idle and runtime pm

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915: Disable D3Cold in s2idle and runtime pm URL : https://patchwork.freedesktop.org/series/96914/ State : success == Summary == CI Bug Log - changes from CI_DRM_10882 -> Patchwork_21588 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915, agp/intel-ggt: clean up includes

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915, agp/intel-ggt: clean up includes URL : https://patchwork.freedesktop.org/series/96907/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10882_full -> Patchwork_21586_full Summary ---

Re: [Intel-gfx] [PATCH 3/3] agp/intel-gtt: reduce intel-gtt dependencies more

2021-11-15 Thread Lucas De Marchi
On Mon, Nov 15, 2021 at 01:53:13PM +0200, Jani Nikula wrote: Don't include stuff on behalf of users if they're not strictly necessary for the header. Cc: Andy Shevchenko Signed-off-by: Jani Nikula Reviewed-by: Lucas De Marchi Lucas De Marchi

Re: [Intel-gfx] [PATCH 2/3] agp/intel-gtt: Replace kernel.h with the necessary inclusions

2021-11-15 Thread Lucas De Marchi
On Mon, Nov 15, 2021 at 01:53:12PM +0200, Jani Nikula wrote: From: Andy Shevchenko When kernel.h is used in the headers it adds a lot into dependency hell, especially when there are circular dependencies are involved. Replace kernel.h inclusion with the list of what is really being used. Sign

Re: [Intel-gfx] [PATCH 1/3] drm/i915: include intel-gtt.h only where needed

2021-11-15 Thread Lucas De Marchi
On Mon, Nov 15, 2021 at 01:53:11PM +0200, Jani Nikula wrote: Only intel_gt.c and intel_ggtt.c need the interface. Cc: Andy Shevchenko Signed-off-by: Jani Nikula Reviewed-by: Lucas De Marchi Lucas De Marchi

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Disable D3Cold in s2idle and runtime pm

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915: Disable D3Cold in s2idle and runtime pm URL : https://patchwork.freedesktop.org/series/96914/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Excess function parameter 'i

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/rpm: Enable runtime pm autosuspend by default (rev2)

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915/rpm: Enable runtime pm autosuspend by default (rev2) URL : https://patchwork.freedesktop.org/series/96741/ State : success == Summary == CI Bug Log - changes from CI_DRM_10882_full -> Patchwork_21585_full ===

Re: [Intel-gfx] [PATCH] drm/i915/fbc: fix the FBC kernel-doc warnings

2021-11-15 Thread Ville Syrjälä
On Mon, Nov 15, 2021 at 04:05:49PM +0200, Jani Nikula wrote: > Fix the recently introduced 'make htmldocs' warnings: > > $ make htmldocs 2>&1 > /dev/null | grep i915 > ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Excess function > parameter 'i915' description in 'intel_fbc_is_active'

[Intel-gfx] [PATCH] drm/i915: Disable D3Cold in s2idle and runtime pm

2021-11-15 Thread Tilak Tangudu
s2idle and runtime pm puts the pci gfx device in D3Hot, ACPI runtime monitors the pci tree,if it sees complete tree as D3Hot,it transitions the device to D3Cold.But i915 do not have D3Cold support in S2idle or in runtime pm. so disabling D3cold in above flows and its FIXME. Added pci D3Cold enable

Re: [Intel-gfx] [PATCH] drm/i915: Fix fastsets on TypeC ports following a non-blocking modeset

2021-11-15 Thread Ville Syrjälä
On Mon, Nov 15, 2021 at 02:45:36PM +0200, Imre Deak wrote: > On Fri, Nov 12, 2021 at 11:14:52PM +0200, Ville Syrjälä wrote: > > On Fri, Nov 12, 2021 at 09:09:04PM +0200, Imre Deak wrote: > > > After a non-blocking modeset on a TypeC port's CRTC - possibly blocked > > > later in drm_atomic_helper_wa

Re: [Intel-gfx] [PATCH 0/3] drm/i915, agp/intel-ggt: clean up includes

2021-11-15 Thread Andy Shevchenko
On Mon, Nov 15, 2021 at 01:53:10PM +0200, Jani Nikula wrote: > Took Andy's patch [1] and expanded on it a bit. Thank you! It's always good to have cleanups in the headers, Acked-by: Andy Shevchenko for your changes (including ones that you've done against my patch). > [1] > https://patchwork.fr

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915/rpm: Enable runtime pm autosuspend by default

2021-11-15 Thread Rodrigo Vivi
On Mon, Nov 15, 2021 at 01:44:57PM +0200, Jani Nikula wrote: > On Mon, 15 Nov 2021, Tilak Tangudu wrote: > > The actual commit message with explanations why it will work now and > didn't work before go here. The truth is that: 1. We don't have a good track of *all* the issues with the past atte

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbc: fix the FBC kernel-doc warnings

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915/fbc: fix the FBC kernel-doc warnings URL : https://patchwork.freedesktop.org/series/96911/ State : success == Summary == CI Bug Log - changes from CI_DRM_10882 -> Patchwork_21587 Summary --- **SU

Re: [Intel-gfx] [PATCH 0/3] drm/i915, agp/intel-ggt: clean up includes

2021-11-15 Thread Jani Nikula
On Mon, 15 Nov 2021, Daniel Vetter wrote: > On Mon, Nov 15, 2021 at 01:55:32PM +0200, Jani Nikula wrote: >> On Mon, 15 Nov 2021, Jani Nikula wrote: >> > Took Andy's patch [1] and expanded on it a bit. >> > >> > BR, >> > Jani. >> > >> > >> > [1] >> > https://patchwork.freedesktop.org/patch/msgid/

Re: [Intel-gfx] [PATCH 0/3] drm/i915, agp/intel-ggt: clean up includes

2021-11-15 Thread Daniel Vetter
On Mon, Nov 15, 2021 at 01:55:32PM +0200, Jani Nikula wrote: > On Mon, 15 Nov 2021, Jani Nikula wrote: > > Took Andy's patch [1] and expanded on it a bit. > > > > BR, > > Jani. > > > > > > [1] > > https://patchwork.freedesktop.org/patch/msgid/2020102857.59604-1-andriy.shevche...@linux.intel.c

Re: [Intel-gfx] [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-11-15 Thread Andy Shevchenko
On Mon, Nov 15, 2021 at 01:43:02PM +0200, Jani Nikula wrote: > On Mon, 15 Nov 2021, Andy Shevchenko > wrote: > > On Tue, Oct 05, 2021 at 02:34:23PM -0700, Lucas De Marchi wrote: > >> On Mon, Feb 15, 2021 at 04:21:35PM +0200, Andy Shevchenko wrote: > >> > We have already few similar implementation

[Intel-gfx] ✓ Fi.CI.IGT: success for Enable runtime pm autosuspend by default

2021-11-15 Thread Patchwork
== Series Details == Series: Enable runtime pm autosuspend by default URL : https://patchwork.freedesktop.org/series/96897/ State : success == Summary == CI Bug Log - changes from CI_DRM_10881_full -> Patchwork_21584_full Summary ---

Re: [Intel-gfx] [PATCH 12/26] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2

2021-11-15 Thread Sascha Hauer
Hi, On Fri, Sep 17, 2021 at 02:34:59PM +0200, Christian König wrote: > Simplifying the code a bit. > > v2: use dma_resv_for_each_fence > > Signed-off-by: Christian König > --- > drivers/gpu/drm/scheduler/sched_main.c | 26 ++ > 1 file changed, 6 insertions(+), 20 deleti

[Intel-gfx] [PATCH] drm/i915/fbc: fix the FBC kernel-doc warnings

2021-11-15 Thread Jani Nikula
Fix the recently introduced 'make htmldocs' warnings: $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Excess function parameter 'i915' description in 'intel_fbc_is_active' ./drivers/gpu/drm/i915/display/intel_fbc.c:1638: warning: Excess functi

Re: [Intel-gfx] [PATCH 12/26] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2

2021-11-15 Thread Daniel Vetter
On Mon, Nov 15, 2021 at 03:03:53PM +0100, Sascha Hauer wrote: > Hi, > > On Fri, Sep 17, 2021 at 02:34:59PM +0200, Christian König wrote: > > Simplifying the code a bit. > > > > v2: use dma_resv_for_each_fence > > > > Signed-off-by: Christian König > > --- > > drivers/gpu/drm/scheduler/sched_ma

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915, agp/intel-ggt: clean up includes

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915, agp/intel-ggt: clean up includes URL : https://patchwork.freedesktop.org/series/96907/ State : success == Summary == CI Bug Log - changes from CI_DRM_10882 -> Patchwork_21586 Summary --- **SUCCE

Re: [Intel-gfx] [PATCH v3 2/6] drm/i915: Add support for asynchronous moving fence waiting

2021-11-15 Thread Thomas Hellström
On 11/15/21 14:13, Matthew Auld wrote: On 15/11/2021 12:42, Thomas Hellström wrote: On 11/15/21 13:36, Matthew Auld wrote: On 14/11/2021 11:12, Thomas Hellström wrote: From: Maarten Lankhorst For now, we will only allow async migration when TTM is used, so the paths we care about are rela

Re: [Intel-gfx] [PATCH v3 2/6] drm/i915: Add support for asynchronous moving fence waiting

2021-11-15 Thread Matthew Auld
On 15/11/2021 12:42, Thomas Hellström wrote: On 11/15/21 13:36, Matthew Auld wrote: On 14/11/2021 11:12, Thomas Hellström wrote: From: Maarten Lankhorst For now, we will only allow async migration when TTM is used, so the paths we care about are related to TTM. The mmap path is handled by h

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915, agp/intel-ggt: clean up includes

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915, agp/intel-ggt: clean up includes URL : https://patchwork.freedesktop.org/series/96907/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Excess function parameter 'i915' de

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rpm: Enable runtime pm autosuspend by default (rev2)

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915/rpm: Enable runtime pm autosuspend by default (rev2) URL : https://patchwork.freedesktop.org/series/96741/ State : success == Summary == CI Bug Log - changes from CI_DRM_10882 -> Patchwork_21585 Summary

Re: [Intel-gfx] [PATCH] drm/i915: Fix fastsets on TypeC ports following a non-blocking modeset

2021-11-15 Thread Imre Deak
On Fri, Nov 12, 2021 at 11:14:52PM +0200, Ville Syrjälä wrote: > On Fri, Nov 12, 2021 at 09:09:04PM +0200, Imre Deak wrote: > > After a non-blocking modeset on a TypeC port's CRTC - possibly blocked > > later in drm_atomic_helper_wait_for_dependencies() - a fastset on the > > same CRTC may copy the

Re: [Intel-gfx] [PATCH v3 1/6] drm/i915: Add functions to set/get moving fence

2021-11-15 Thread Thomas Hellström
On 11/15/21 13:39, Matthew Auld wrote: On 14/11/2021 11:12, Thomas Hellström wrote: From: Maarten Lankhorst We want to get rid of i915_vma tracking to simplify the code and lifetimes. Add a way to set/put the moving fence, in preparation for removing the tracking. Signed-off-by: Maarten Lan

Re: [Intel-gfx] [PATCH v3 2/6] drm/i915: Add support for asynchronous moving fence waiting

2021-11-15 Thread Thomas Hellström
On 11/15/21 13:36, Matthew Auld wrote: On 14/11/2021 11:12, Thomas Hellström wrote: From: Maarten Lankhorst For now, we will only allow async migration when TTM is used, so the paths we care about are related to TTM. The mmap path is handled by having the fence in ttm_bo->moving, when pinni

Re: [Intel-gfx] [PATCH v3 1/6] drm/i915: Add functions to set/get moving fence

2021-11-15 Thread Matthew Auld
On 14/11/2021 11:12, Thomas Hellström wrote: From: Maarten Lankhorst We want to get rid of i915_vma tracking to simplify the code and lifetimes. Add a way to set/put the moving fence, in preparation for removing the tracking. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/gem/i91

Re: [Intel-gfx] [PATCH v3 2/6] drm/i915: Add support for asynchronous moving fence waiting

2021-11-15 Thread Matthew Auld
On 14/11/2021 11:12, Thomas Hellström wrote: From: Maarten Lankhorst For now, we will only allow async migration when TTM is used, so the paths we care about are related to TTM. The mmap path is handled by having the fence in ttm_bo->moving, when pinning, the binding only becomes available aft

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/rpm: Enable runtime pm autosuspend by default (rev2)

2021-11-15 Thread Patchwork
== Series Details == Series: drm/i915/rpm: Enable runtime pm autosuspend by default (rev2) URL : https://patchwork.freedesktop.org/series/96741/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Excess function

Re: [Intel-gfx] [PATCH 1/3] drm/i915/rpl-s: Add PCI IDS

2021-11-15 Thread Tvrtko Ursulin
On 12/11/2021 21:08, Anusha Srivatsa wrote: Adding PCI ids for RPL-S. Introducing RPL-S as a subplatform of ADL-S. From graphics POV,RPL-S is the same as ADL-S. BSpec: 53655 Cc: Matt Roper Cc: Swathi Dhanavanthri Signed-off-by: Anusha Srivatsa --- arch/x86/kernel/early-quirks.c

Re: [Intel-gfx] [PATCH 3/3] drm/i915/rpl-s: Enable guc submission by default

2021-11-15 Thread Jani Nikula
On Fri, 12 Nov 2021, Anusha Srivatsa wrote: > Though, RPL-S is defined as subplatform of ADL-S, unlike > ADL-S, it has GuC submission by default. > > Cc: Swathi Dhanavanthri > Signed-off-by: Anusha Srivatsa > --- > drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [Intel-gfx] [PATCH 2/3] drm/i915/rpl-s: Add PCH ID

2021-11-15 Thread Jani Nikula
On Fri, 12 Nov 2021, Anusha Srivatsa wrote: > Add the PCH ID for the same. The same as what? Please use use commit messages that are self-contained. > > Cc: Swathi Dhanavanthri > Signed-off-by: Anusha Srivatsa > --- > drivers/gpu/drm/i915/intel_pch.c | 1 + > drivers/gpu/drm/i915/intel_pch.h

Re: [Intel-gfx] [PATCH 1/3] drm/i915/rpl-s: Add PCI IDS

2021-11-15 Thread Jani Nikula
On Fri, 12 Nov 2021, Anusha Srivatsa wrote: > Adding PCI ids for RPL-S. Introducing RPL-S as a > subplatform of ADL-S. From graphics POV,RPL-S is > the same as ADL-S. The cover letter has a better description of what rpl-s is, but the cover letter does not get committed to git. Please at least me

Re: [Intel-gfx] [PATCH 0/3] drm/i915, agp/intel-ggt: clean up includes

2021-11-15 Thread Jani Nikula
On Mon, 15 Nov 2021, Jani Nikula wrote: > Took Andy's patch [1] and expanded on it a bit. > > BR, > Jani. > > > [1] > https://patchwork.freedesktop.org/patch/msgid/2020102857.59604-1-andriy.shevche...@linux.intel.com > > Cc: Andy Shevchenko > > Andy Shevchenko (1): > agp/intel-gtt: Replace

[Intel-gfx] [PATCH 3/3] agp/intel-gtt: reduce intel-gtt dependencies more

2021-11-15 Thread Jani Nikula
Don't include stuff on behalf of users if they're not strictly necessary for the header. Cc: Andy Shevchenko Signed-off-by: Jani Nikula --- drivers/char/agp/intel-gtt.c | 1 + drivers/gpu/drm/i915/gt/intel_ggtt.c | 1 + include/drm/intel-gtt.h | 3 +-- 3 files changed, 3 in

[Intel-gfx] [PATCH 2/3] agp/intel-gtt: Replace kernel.h with the necessary inclusions

2021-11-15 Thread Jani Nikula
From: Andy Shevchenko When kernel.h is used in the headers it adds a lot into dependency hell, especially when there are circular dependencies are involved. Replace kernel.h inclusion with the list of what is really being used. Signed-off-by: Andy Shevchenko Signed-off-by: Jani Nikula --- in

[Intel-gfx] [PATCH 1/3] drm/i915: include intel-gtt.h only where needed

2021-11-15 Thread Jani Nikula
Only intel_gt.c and intel_ggtt.c need the interface. Cc: Andy Shevchenko Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 1 + drivers/gpu/drm/i915/gt/intel_gt.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 1 - 3 files changed, 3 insertions(+), 1 deletion(-) diff --gi

[Intel-gfx] [PATCH 0/3] drm/i915, agp/intel-ggt: clean up includes

2021-11-15 Thread Jani Nikula
Took Andy's patch [1] and expanded on it a bit. BR, Jani. [1] https://patchwork.freedesktop.org/patch/msgid/2020102857.59604-1-andriy.shevche...@linux.intel.com Cc: Andy Shevchenko Andy Shevchenko (1): agp/intel-gtt: Replace kernel.h with the necessary inclusions Jani Nikula (2): dr

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable runtime pm autosuspend by default

2021-11-15 Thread Patchwork
== Series Details == Series: Enable runtime pm autosuspend by default URL : https://patchwork.freedesktop.org/series/96897/ State : success == Summary == CI Bug Log - changes from CI_DRM_10881 -> Patchwork_21584 Summary --- **SUCCESS

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915/rpm: Enable runtime pm autosuspend by default

2021-11-15 Thread Jani Nikula
On Mon, 15 Nov 2021, Tilak Tangudu wrote: The actual commit message with explanations why it will work now and didn't work before go here. Just the changelog will not be enough. BR, Jani. > v1: Enable runtime pm autosuspend by default for Gen12 > and later versions. > > v2: Enable runtime pm a

Re: [Intel-gfx] [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-11-15 Thread Jani Nikula
On Mon, 15 Nov 2021, Andy Shevchenko wrote: > On Tue, Oct 05, 2021 at 02:34:23PM -0700, Lucas De Marchi wrote: >> On Mon, Feb 15, 2021 at 04:21:35PM +0200, Andy Shevchenko wrote: >> > We have already few similar implementation and a lot of code that can >> > benefit >> > of the yesno() helper. C

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Enable runtime pm autosuspend by default

2021-11-15 Thread Patchwork
== Series Details == Series: Enable runtime pm autosuspend by default URL : https://patchwork.freedesktop.org/series/96897/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Excess function parameter 'i915' desc

Re: [Intel-gfx] [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-11-15 Thread Andy Shevchenko
On Tue, Oct 05, 2021 at 02:34:23PM -0700, Lucas De Marchi wrote: > On Mon, Feb 15, 2021 at 04:21:35PM +0200, Andy Shevchenko wrote: > > We have already few similar implementation and a lot of code that can > > benefit > > of the yesno() helper. Consolidate yesno() helpers under string.h hood. >

Re: [Intel-gfx] [PATCH] drm/i915/dp: Perform 30ms delay after source OUI write

2021-11-15 Thread Jani Nikula
On Fri, 12 Nov 2021, Lyude Paul wrote: > While working on supporting the Intel HDR backlight interface, I noticed > that there's a couple of laptops that will very rarely manage to boot up > without detecting Intel HDR backlight support - even though it's supported > on the system. One example of

Re: [Intel-gfx] [PATCH v3 4/6] drm/i915/ttm: Break refcounting loops at device region unref time

2021-11-15 Thread Matthew Auld
On 14/11/2021 11:12, Thomas Hellström wrote: There is an interesting refcounting loop: struct intel_memory_region has a struct ttm_resource_manager, ttm_resource_manager->move may hold a reference to i915_request, i915_request may hold a reference to intel_context, intel_context may hold a refere

Re: [Intel-gfx] [PATCH v3 3/6] drm/i915/ttm: Move the i915_gem_obj_copy_ttm() function

2021-11-15 Thread Matthew Auld
On 14/11/2021 11:12, Thomas Hellström wrote: Move the i915_gem_obj_copy_ttm() function to i915_gem_ttm_move.h. This will help keep a number of functions static when introducing async moves. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Weak parallel submission support for execlists

2021-11-15 Thread Tvrtko Ursulin
On 12/11/2021 17:59, Matthew Brost wrote: On Fri, Nov 12, 2021 at 02:13:50PM +, Tvrtko Ursulin wrote: On 11/11/2021 16:49, Matthew Brost wrote: On Mon, Nov 01, 2021 at 10:35:09AM +, Tvrtko Ursulin wrote: On 27/10/2021 21:10, Matthew Brost wrote: On Wed, Oct 27, 2021 at 01:04:49PM

[Intel-gfx] [PATCH v2 1/1] drm/i915/rpm: Enable runtime pm autosuspend by default

2021-11-15 Thread Tilak Tangudu
v1: Enable runtime pm autosuspend by default for Gen12 and later versions. v2: Enable runtime pm autosuspend by default for all platforms(Syrjala Ville) Signed-off-by: Tilak Tangudu --- drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/dr

[Intel-gfx] [PATCH v2 0/1] drm/i915/rpm: Enable runtime pm autosuspend by default

2021-11-15 Thread Tilak Tangudu
Enable runtime pm autosuspend by default for all platforms Signed-off-by: Tilak Tangudu Tilak Tangudu (1): drm/i915/rpm: Enable runtime pm autosuspend by default drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.25.1

[Intel-gfx] [PATCH 0/1] Enable runtime pm autosuspend by default

2021-11-15 Thread Tilak Tangudu
Enable runtime pm autosuspend by default Signed-off-by: Tilak Tangudu Tilak Tangudu (1): drm/i915/rpm: Enable runtime pm autosuspend by default drivers/gpu/drm/i915/intel_runtime_pm.c | 4 1 file changed, 4 insertions(+) -- 2.25.1

[Intel-gfx] [PATCH 1/1] drm/i915/rpm: Enable runtime pm autosuspend by default

2021-11-15 Thread Tilak Tangudu
Enable runtime pm autosuspend by default. Signed-off-by: Tilak Tangudu --- drivers/gpu/drm/i915/intel_runtime_pm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c index eaf7688f517d..ef75f24288ef 100644 --