Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 08/11] lib/store: Refactor common store code into helper function

2021-12-15 Thread Zbigniew Kempczyński
On Mon, Dec 13, 2021 at 03:29:11PM -0800, john.c.harri...@intel.com wrote: > From: John Harrison > > A lot of tests use almost identical code for creating a batch buffer > which does a single write to memory. This patch collects two such > instances into a common helper function. Unfortunately,

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 07/11] tests/i915/i915_hangman: Add alive-ness test after error capture

2021-12-15 Thread Zbigniew Kempczyński
On Mon, Dec 13, 2021 at 03:29:10PM -0800, john.c.harri...@intel.com wrote: > From: John Harrison > > Added a an extra step to the i915_hangman tests to check that the > system is still alive after the hang and recovery. This submits a > simple batch to each engine which does a write to memory

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg1: Read OPROM via SPI controller (rev3)

2021-12-15 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Read OPROM via SPI controller (rev3) URL : https://patchwork.freedesktop.org/series/94826/ State : success == Summary == CI Bug Log - changes from CI_DRM_11006 -> Patchwork_21857 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dg1: Read OPROM via SPI controller (rev3)

2021-12-15 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Read OPROM via SPI controller (rev3) URL : https://patchwork.freedesktop.org/series/94826/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v2] drm/i915/dg1: Read OPROM via SPI controller

2021-12-15 Thread Lucas De Marchi
From: Clint Taylor Read OPROM SPI through MMIO and find VBT entry since we can't use OpRegion and PCI mapping may not work on some systems due to most BIOSes not leaving the Option ROM mapped. v2: Remove message with allocation failure Cc: Ville Syrjälä Cc: Tomas Winkler Signed-off-by: Clint

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Check for wedged before doing stuff

2021-12-15 Thread Patchwork
== Series Details == Series: drm/i915/guc: Check for wedged before doing stuff URL : https://patchwork.freedesktop.org/series/98099/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11005_full -> Patchwork_21856_full Summary

Re: [Intel-gfx] [PATCH 3/4] drm/i915/guc: Flag an error if an engine reset fails

2021-12-15 Thread Daniele Ceraolo Spurio
On 12/10/2021 10:58 PM, john.c.harri...@intel.com wrote: From: John Harrison If GuC encounters an error during engine reset, the i915 driver promotes to full GT reset. This includes an info message about why the reset is happening. However, that is not treated as a failure by any of the CI

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Improve long running OCL w/a for GuC submission

2021-12-15 Thread Daniele Ceraolo Spurio
On 12/10/2021 10:58 PM, john.c.harri...@intel.com wrote: From: John Harrison A workaround was added to the driver to allow OpenCL workloads to run 'forever' by disabling pre-emption on the RCS engine for Gen12. It is not totally unbound as the heartbeat will kick in eventually and cause a

Re: [Intel-gfx] [PATCH] drm/i915/guc: Check for wedged before doing stuff

2021-12-15 Thread Matthew Brost
On Wed, Dec 15, 2021 at 02:45:56PM -0800, john.c.harri...@intel.com wrote: > From: John Harrison > > A fault injection probe test hit a BUG_ON in a GuC error path. It > showed that the GuC code could potentially attempt to do many things > when the device is actually wedged. So, add a check in

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Check for wedged before doing stuff

2021-12-15 Thread Patchwork
== Series Details == Series: drm/i915/guc: Check for wedged before doing stuff URL : https://patchwork.freedesktop.org/series/98099/ State : success == Summary == CI Bug Log - changes from CI_DRM_11005 -> Patchwork_21856 Summary ---

Re: [Intel-gfx] i915 Updates: ADL-P DMC v2.14

2021-12-15 Thread Tolakanahalli Pradeep, Madhumitha
Bump! :) Thanks, - Madhumitha On Wed, 2021-12-08 at 18:11 +, Srivatsa, Anusha wrote: > Ping :) > Can these updates be merged to linux-firmware? > > > Thanks, > Anusha > > > -Original Message- > > From: Tolakanahalli Pradeep, Madhumitha > > > > Sent: Thursday, December 2, 2021

[Intel-gfx] [PATCH] drm/i915/guc: Check for wedged before doing stuff

2021-12-15 Thread John . C . Harrison
From: John Harrison A fault injection probe test hit a BUG_ON in a GuC error path. It showed that the GuC code could potentially attempt to do many things when the device is actually wedged. So, add a check in to prevent that. Signed-off-by: John Harrison ---

[Intel-gfx] [CI] PR for new GuC v69.0.3

2021-12-15 Thread John . C . Harrison
The following changes since commit b0e898fbaf377c99a36aac6fdeb7250003648ca4: linux-firmware: Update firmware file for Intel Bluetooth 9462 (2021-11-23 12:31:45 -0500) are available in the Git repository at: ssh://git.freedesktop.org/git/drm/drm-firmware guc_v69.0.3 for you to fetch

Re: [Intel-gfx] [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error

2021-12-15 Thread Ira Weiny
On Tue, Dec 14, 2021 at 08:09:29AM +0100, Christian König wrote: > Am 14.12.21 um 04:37 schrieb Ira Weiny: > > On Mon, Dec 13, 2021 at 09:37:32PM +0100, Christian König wrote: > > > Am 11.12.21 um 00:24 schrieb ira.we...@intel.com: > > > > From: Ira Weiny > > > > > > > > The default case leaves

Re: [Intel-gfx] [PATCH 09/20] drm/i915/dp: Extract intel_dp_tmds_clock_valid()

2021-12-15 Thread Ville Syrjälä
On Fri, Dec 10, 2021 at 10:50:09AM +0530, Nautiyal, Ankit K wrote: > > On 10/15/2021 7:09 PM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We're currently duplicating the DFP min/max TMDS clock checks > > in .mode_valid() and .compute_config(). Extract a helper suitable > > for both use

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Use struct vma_resource instead of struct vma_snapshot

2021-12-15 Thread kernel test robot
tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Thomas-Hellstr-m/drm-i915-Asynchronous-vma-unbinding/20211215-183859 base: git://anongit.freedesktop.or

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Avoid using the i915_fence_array when collecting dependencies

2021-12-15 Thread kernel test robot
6-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Thomas-Hellstr-m/drm-i915-Asynchronous-vma-unbinding/202

[Intel-gfx] ✓ Fi.CI.IGT: success for Add driver for GSC controller

2021-12-15 Thread Patchwork
== Series Details == Series: Add driver for GSC controller URL : https://patchwork.freedesktop.org/series/98066/ State : success == Summary == CI Bug Log - changes from CI_DRM_11004_full -> Patchwork_21855_full Summary ---

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Avoid using the i915_fence_array when collecting dependencies

2021-12-15 Thread kernel test robot
tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Thomas-Hellstr-m/drm-i915-Asynchronous-vma-unbinding/20211215-183859 base: git://anongit.freedesktop.or

Re: [Intel-gfx] [PATCH v4 06/16] drm/i915/gt: Clear compress metadata for Xe_HP platforms

2021-12-15 Thread Robert Beckett
The fixes below fix gem_lmem_swapping@basic igt test On 09/12/2021 15:45, Ramalingam C wrote: From: Ayaz A Siddiqui Xe-HP and latest devices support Flat CCS which reserved a portion of the device memory to store compression metadata, during the clearing of device memory buffer object we also

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dg1: Read OPROM via SPI controller (rev2)

2021-12-15 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Read OPROM via SPI controller (rev2) URL : https://patchwork.freedesktop.org/series/94826/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11004_full -> Patchwork_21854_full Summary

Re: [Intel-gfx] [PATCH 2/2] drm/i915: clean up shrinker_release_pages

2021-12-15 Thread Matthew Auld
On 15/12/2021 15:55, Tvrtko Ursulin wrote: On 15/12/2021 11:07, Matthew Auld wrote: Add some proper flags for the different modes, and shorten the name to something more snappy. Looks good to me - but since it touches TTM I leave for Thomas to approve. Regards, Tvrtko P.S. I hope writing

Re: [Intel-gfx] [PATCH v4 12/16] uapi/drm/dg2: Introduce format modifier for DG2 clear color

2021-12-15 Thread Lionel Landwerlin
On 09/12/2021 17:45, Ramalingam C wrote: From: Mika Kahola DG2 clear color render compression uses Tile4 layout. Therefore, we need to define a new format modifier for uAPI to support clear color rendering. Signed-off-by: Mika Kahola cc: Anshuman Gupta Signed-off-by: Juha-Pekka Heikkilä

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Use struct vma_resource instead of struct vma_snapshot

2021-12-15 Thread kernel test robot
your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Thomas-Hellstr-m/drm-i915-Asynchronous-vma-unbinding/20211215-1

Re: [Intel-gfx] [PATCH 2/2] drm/i915: clean up shrinker_release_pages

2021-12-15 Thread Tvrtko Ursulin
On 15/12/2021 11:07, Matthew Auld wrote: Add some proper flags for the different modes, and shorten the name to something more snappy. Looks good to me - but since it touches TTM I leave for Thomas to approve. Regards, Tvrtko P.S. I hope writing the patch means you thought it is an

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: remove writeback hook

2021-12-15 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: remove writeback hook URL : https://patchwork.freedesktop.org/series/98061/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11004_full -> Patchwork_21853_full

[Intel-gfx] ✓ Fi.CI.BAT: success for Add driver for GSC controller

2021-12-15 Thread Patchwork
== Series Details == Series: Add driver for GSC controller URL : https://patchwork.freedesktop.org/series/98066/ State : success == Summary == CI Bug Log - changes from CI_DRM_11004 -> Patchwork_21855 Summary --- **WARNING**

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Asynchronous vma unbinding

2021-12-15 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding URL : https://patchwork.freedesktop.org/series/98055/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11004_full -> Patchwork_21851_full Summary ---

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/fbc: Parametrize FBC register offsets

2021-12-15 Thread Sarvela, Tomi P
> From: Sarvela, Tomi P > > From: Ville Syrjälä > > On Wed, Dec 15, 2021 at 09:05:03AM +, Sarvela, Tomi P wrote: > > > > From: Ville Syrjälä > > > > > > > > On Tue, Dec 14, 2021 at 06:25:43PM +0200, Ville Syrjälä wrote: > > > > > On Mon, Dec 13, 2021 at 09:54:04PM +0200, Jani Nikula wrote: >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add driver for GSC controller

2021-12-15 Thread Patchwork
== Series Details == Series: Add driver for GSC controller URL : https://patchwork.freedesktop.org/series/98066/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 1/5] drm/i915/gsc: add gsc as a mei platform device

2021-12-15 Thread Greg Kroah-Hartman
On Wed, Dec 15, 2021 at 03:56:18PM +0200, Alexander Usyskin wrote: > From: Tomas Winkler > > GSC is a graphics system controller, based on CSE, it provides > a chassis controller for graphics discrete cards, as well as it > supports media protection (HDCP 2.2) on selected devices. > > There are

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add driver for GSC controller

2021-12-15 Thread Patchwork
== Series Details == Series: Add driver for GSC controller URL : https://patchwork.freedesktop.org/series/98066/ State : warning == Summary == $ dim checkpatch origin/drm-tip 06f5f59f4a16 drm/i915/gsc: add gsc as a mei platform device -:51: WARNING:FILE_PATH_CHANGES: added, moved or deleted

[Intel-gfx] [PATCH 5/5] mei: gsc: retrieve the firmware version

2021-12-15 Thread Alexander Usyskin
GSC has a different MKHI client GUID with same message structure as MEI to retrieve the firmware version. Add a bus-fixup to retrieve the firmware version of the GSC devices. CC: Ashutosh Dixit Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus-fixup.c | 25

[Intel-gfx] [PATCH 4/5] mei: gsc: add runtime pm handlers

2021-12-15 Thread Alexander Usyskin
From: Tomas Winkler Implement runtime handlers for mei-gsc, to track idle state of the device properly. CC: Rodrigo Vivi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/misc/mei/gsc-me.c | 80 ++- 1 file changed, 79

[Intel-gfx] [PATCH 3/5] mei: gsc: setup char driver alive in spite of firmware handshake failure

2021-12-15 Thread Alexander Usyskin
Continue to char device setup in spite of firmware handshake failure. In order to provide access to the firmware status registers and other information are valuable for debug and manufacturing. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/gsc-me.c | 11

[Intel-gfx] [PATCH 2/5] mei: add gsc driver

2021-12-15 Thread Alexander Usyskin
From: Tomas Winkler GSC is a graphics system controller, based on CSE, it provides a chassis controller for graphics discrete cards, as well as it supports media protection (HDCP 2.2) on selected devices. mei_gsc binds to a platform devices exposed by Intel discrete driver i915 via MFD

[Intel-gfx] [PATCH 1/5] drm/i915/gsc: add gsc as a mei platform device

2021-12-15 Thread Alexander Usyskin
From: Tomas Winkler GSC is a graphics system controller, based on CSE, it provides a chassis controller for graphics discrete cards, as well as it supports media protection (HDCP 2.2) on selected devices. There are two MEI interfaces in GSC HECI1, the one that provides media protection and

[Intel-gfx] [PATCH 0/5] Add driver for GSC controller

2021-12-15 Thread Alexander Usyskin
GSC is a graphics system controller, based on CSE, it provides a chassis controller for graphics discrete cards, as well as it supports media protection (HDCP 2.2) on selected devices. There are two MEI interfaces in GSC: HECI1, the one that provides media protection and HECI2 the one that

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg1: Read OPROM via SPI controller (rev2)

2021-12-15 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Read OPROM via SPI controller (rev2) URL : https://patchwork.freedesktop.org/series/94826/ State : success == Summary == CI Bug Log - changes from CI_DRM_11004 -> Patchwork_21854 Summary ---

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/fbc: Parametrize FBC register offsets

2021-12-15 Thread Sarvela, Tomi P
> From: Ville Syrjälä > On Wed, Dec 15, 2021 at 09:05:03AM +, Sarvela, Tomi P wrote: > > > From: Ville Syrjälä > > > > > > On Tue, Dec 14, 2021 at 06:25:43PM +0200, Ville Syrjälä wrote: > > > > On Mon, Dec 13, 2021 at 09:54:04PM +0200, Jani Nikula wrote: > > > > > On Mon, 13 Dec 2021, Ville

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/fbc: Parametrize FBC register offsets

2021-12-15 Thread Ville Syrjälä
On Wed, Dec 15, 2021 at 09:05:03AM +, Sarvela, Tomi P wrote: > > From: Ville Syrjälä > > > > On Tue, Dec 14, 2021 at 06:25:43PM +0200, Ville Syrjälä wrote: > > > On Mon, Dec 13, 2021 at 09:54:04PM +0200, Jani Nikula wrote: > > > > On Mon, 13 Dec 2021, Ville Syrjala > > > > wrote: > > > > >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dg1: Read OPROM via SPI controller (rev2)

2021-12-15 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Read OPROM via SPI controller (rev2) URL : https://patchwork.freedesktop.org/series/94826/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg1: Read OPROM via SPI controller (rev2)

2021-12-15 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Read OPROM via SPI controller (rev2) URL : https://patchwork.freedesktop.org/series/94826/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0152dbed149b drm/i915/dg1: Read OPROM via SPI controller -:63: WARNING:OOM_MESSAGE: Possible

Re: [Intel-gfx] [PATCH] drm/i915/dg1: Read OPROM via SPI controller

2021-12-15 Thread Jani Nikula
On Tue, 14 Dec 2021, Lucas De Marchi wrote: > On Tue, Dec 14, 2021 at 11:42:41AM +0200, Jani Nikula wrote: >>On Fri, 17 Sep 2021, Lucas De Marchi wrote: >>> From: Clint Taylor >>> >>> Read OPROM SPI through MMIO and find VBT entry since we can't use >>> OpRegion and PCI mapping may not work on

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: remove writeback hook

2021-12-15 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: remove writeback hook URL : https://patchwork.freedesktop.org/series/98061/ State : success == Summary == CI Bug Log - changes from CI_DRM_11004 -> Patchwork_21853 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: remove writeback hook

2021-12-15 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: remove writeback hook URL : https://patchwork.freedesktop.org/series/98061/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/dp: Move DisplayPort helpers into own module (rev2)

2021-12-15 Thread Patchwork
== Series Details == Series: drm/dp: Move DisplayPort helpers into own module (rev2) URL : https://patchwork.freedesktop.org/series/97961/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Asynchronous vma unbinding

2021-12-15 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding URL : https://patchwork.freedesktop.org/series/98055/ State : success == Summary == CI Bug Log - changes from CI_DRM_11004 -> Patchwork_21851 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Asynchronous vma unbinding

2021-12-15 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding URL : https://patchwork.freedesktop.org/series/98055/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Asynchronous vma unbinding

2021-12-15 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding URL : https://patchwork.freedesktop.org/series/98055/ State : warning == Summary == $ dim checkpatch origin/drm-tip 40ccf1d6e849 drm/i915: Avoid using the i915_fence_array when collecting dependencies c45e38a63dd7 drm/i915:

Re: [Intel-gfx] [PATCH v2 3/5] drm/dp: Move DisplayPort helpers into separate helper module

2021-12-15 Thread Thomas Zimmermann
Hi Am 15.12.21 um 12:04 schrieb Jani Nikula: On Wed, 15 Dec 2021, Thomas Zimmermann wrote: * move DP helper code into dp/ (Jani) I suggested adding the subdirectory, but I'm going to bikeshed the name, which I didn't suggest. $ find drivers/gpu/drm -mindepth 1 -maxdepth 1 -type d |

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Break out the i915_deps utility

2021-12-15 Thread Jani Nikula
On Wed, 15 Dec 2021, Thomas Hellström wrote: > Since it's starting to be used outside the i915 TTM move code, move it > to a separate set of files. Sure, but why the top level instead of gem/? BR, Jani. > > Signed-off-by: Thomas Hellström > --- > drivers/gpu/drm/i915/Makefile

[Intel-gfx] [PATCH 2/2] drm/i915: clean up shrinker_release_pages

2021-12-15 Thread Matthew Auld
Add some proper flags for the different modes, and shorten the name to something more snappy. Suggested-by: Tvrtko Ursulin Signed-off-by: Matthew Auld --- .../gpu/drm/i915/gem/i915_gem_object_types.h | 23 --- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 8 +++

[Intel-gfx] [PATCH 1/2] drm/i915: remove writeback hook

2021-12-15 Thread Matthew Auld
Ditch the writeback hook and drop i915_gem_object_writeback(). We already support the shrinker_release_pages hook which can just call shmem_writeback directly. Suggested-by: Tvrtko Ursulin Signed-off-by: Matthew Auld Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_object.h

Re: [Intel-gfx] [PATCH v2 3/5] drm/dp: Move DisplayPort helpers into separate helper module

2021-12-15 Thread Jani Nikula
On Wed, 15 Dec 2021, Thomas Zimmermann wrote: > * move DP helper code into dp/ (Jani) I suggested adding the subdirectory, but I'm going to bikeshed the name, which I didn't suggest. $ find drivers/gpu/drm -mindepth 1 -maxdepth 1 -type d | wc -l 68 Assuming we move more of the drm

[Intel-gfx] [PATCH v2 5/5] drm/dp: Move DisplayPort AUX bus helpers into dp/

2021-12-15 Thread Thomas Zimmermann
Move drm_dp_aux_bus.c and its header file into the DP subdirectory and update all users. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Makefile | 2 -- drivers/gpu/drm/bridge/parade-ps8640.c | 2 +-

[Intel-gfx] [PATCH v2 2/5] drm/dp: Move DP declarations into separate header file

2021-12-15 Thread Thomas Zimmermann
Split the DP declarations from other helpers before moving the DP functions into a separate module. v2: * forward-declare struct drm_dp_aux (Jani) * add include guards in drm_dp_helper_internal.h Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_crtc_helper_internal.h |

[Intel-gfx] [PATCH v2 1/5] drm/dp_mst: Remove trailing whitespace.

2021-12-15 Thread Thomas Zimmermann
Fix coding style. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index f3d79eda94bb..7f0ff96261cf 100644 ---

[Intel-gfx] [PATCH v2 3/5] drm/dp: Move DisplayPort helpers into separate helper module

2021-12-15 Thread Thomas Zimmermann
Move DisplayPort functions into a separate module to reduce the size of the KMS helpers. Select DRM_DP_HELPER for all users of the code. To avoid naming conflicts, rename drm_dp_helper.c to drm_dp.c This change can help to reduce the size of the kernel binary. Some numbers from a x86-64 test

[Intel-gfx] [PATCH v2 0/5] drm/dp: Move DisplayPort helpers into own module

2021-12-15 Thread Thomas Zimmermann
Split-off DisplayPort functions from KMS helper library and move them into their own module. Reduces the size of drm_kms_helper.ko by ~50%. This patchset is part of an on-going effort to reduce the minimum binary size of the DRM core and helpers. It's helpful for systems with early-boot DRM

[Intel-gfx] [PATCH v2 4/5] drm/dp: Move public DisplayPort headers into dp/

2021-12-15 Thread Thomas Zimmermann
Move all public DisplayPort headers into dp and update users. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h| 4 ++--

[Intel-gfx] [PULL] drm-intel-fixes

2021-12-15 Thread Rodrigo Vivi
Hi Dave and Daniel, First, a heads up that I will be on vacation for the next weeks so Jani will cover the drm-intel-fixes for the next rounds. Now, here goes drm-intel-fixes-2021-12-15: Fix a bound check in the DMC fw load. Thanks, Rodrigo. The following changes since commit

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Increment composite fence seqno

2021-12-15 Thread Patchwork
== Series Details == Series: drm/i915: Increment composite fence seqno URL : https://patchwork.freedesktop.org/series/98034/ State : success == Summary == CI Bug Log - changes from CI_DRM_11003_full -> Patchwork_21850_full Summary ---

[Intel-gfx] [PATCH 7/7] drm/i915: Use struct vma_resource instead of struct vma_snapshot

2021-12-15 Thread Thomas Hellström
There is always a struct vma_resource guaranteed to be alive when we access a corresponding struct vma_snapshot. So ditch the latter and instead of allocating vma_snapshots, reference the already existning vma_resource. This requires a couple of extra members in struct vma_resource but that's a

[Intel-gfx] [PATCH 6/7] drm/i915: Use vma resources for async unbinding

2021-12-15 Thread Thomas Hellström
Implement async (non-blocking) unbinding by not syncing the vma before calling unbind on the vma_resource. Add the resulting unbind fence to the object's dma_resv from where it is picked up by the ttm migration code. Ideally these unbind fences should be coalesced with the migration blit fence to

[Intel-gfx] [PATCH 4/7] drm/i915: Initial introduction of vma resources

2021-12-15 Thread Thomas Hellström
Introduce vma resources, sort of similar to TTM resources, needed for asynchronous bind management. Initially we will use them to hold completion of unbinding when we capture data from a vma, but they will be used extensively in upcoming patches for asynchronous vma unbinding. Signed-off-by:

[Intel-gfx] [PATCH 5/7] drm/i915: Use the vma resource as argument for gtt binding / unbinding

2021-12-15 Thread Thomas Hellström
When introducing asynchronous unbinding, the vma itself may no longer be alive when the actual binding or unbinding takes place. Update the gtt i915_vma_ops accordingly to take a struct i915_vma_resource instead of a struct i915_vma for the bind_vma() and unbind_vma() ops. Similarly change the

[Intel-gfx] [PATCH 3/7] drm/i915: Require the vm mutex for i915_vma_bind()

2021-12-15 Thread Thomas Hellström
Protect updates of struct i915_vma flags and async binding / unbinding with the vm::mutex. This means that i915_vma_bind() needs to assert vm::mutex held. In order to make that possible drop the caching of kmap_atomic() maps around i915_vma_bind(). An alternative would be to use kmap_local() but

[Intel-gfx] [PATCH 2/7] drm/i915: Break out the i915_deps utility

2021-12-15 Thread Thomas Hellström
Since it's starting to be used outside the i915 TTM move code, move it to a separate set of files. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 181 +-

[Intel-gfx] [PATCH 1/7] drm/i915: Avoid using the i915_fence_array when collecting dependencies

2021-12-15 Thread Thomas Hellström
Since the gt migration code was using only a single fence for dependencies, these were collected in a dma_fence_array. However, it turns out that it's illegal to use some dma_fences in a dma_fence_array, in particular other dma_fence_arrays and dma_fence_chains, and this causes trouble for us

[Intel-gfx] [PATCH 0/7] drm/i915: Asynchronous vma unbinding

2021-12-15 Thread Thomas Hellström
This patch series introduces infrastructure for asynchronous vma unbinding. The single enabled use-case is initially at buffer object migration where we otherwise sync when unbinding vmas before migration. This in theory allows us to pipeline any number of migrations, but in practice the number is

Re: [Intel-gfx] [PATCH 0/3] drm/dp: Move DisplayPort helpers into own module

2021-12-15 Thread Jani Nikula
On Mon, 13 Dec 2021, Thomas Zimmermann wrote: > Hi > > Am 13.12.21 um 14:34 schrieb Jani Nikula: >> On Mon, 13 Dec 2021, Thomas Zimmermann wrote: >>> Split-off DisplayPort functions from KMS helper library and move them >>> into their own module. Reduces the size of drm_kms_helper.ko by ~50%.

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/fbc: Parametrize FBC register offsets

2021-12-15 Thread Sarvela, Tomi P
> From: Ville Syrjälä > > On Tue, Dec 14, 2021 at 06:25:43PM +0200, Ville Syrjälä wrote: > > On Mon, Dec 13, 2021 at 09:54:04PM +0200, Jani Nikula wrote: > > > On Mon, 13 Dec 2021, Ville Syrjala wrote: > > > > > > This one is only used in gvt, anyway. And that actually makes me wonder > > > if

Re: [Intel-gfx] [PATCH] drm/i915: remove writeback hook

2021-12-15 Thread Tvrtko Ursulin
On 14/12/2021 18:07, Matthew Auld wrote: Ditch the writeback hook and drop i915_gem_object_writeback(). We already support the shrinker_release_pages hook which can just call shmem_writeback directly. Looks like a good cleanup to me. Reviewed-by: Tvrtko Ursulin A couple of bike shedding