[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/snps: vswing value refined for SNPS phys

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915/snps: vswing value refined for SNPS phys URL : https://patchwork.freedesktop.org/series/98710/ State : success == Summary == CI Bug Log - changes from CI_DRM_11061_full -> Patchwork_21959_full Summary

Re: [Intel-gfx] [GIT PULL] GVT next changes for drm-intel-next-queued

2022-01-10 Thread Wang, Zhi A
On 1/11/2022 12:52 AM, Vivi, Rodrigo wrote: > On Fri, 2022-01-07 at 14:43 +, Wang, Zhi A wrote: >> Hi folks: >> >> Happy holidays! This pull mostly contains the code re-factors patches >> from Guenter Roeck and Rikard. Also a minor change from Zhenyu. >> >> Zhi >> >> The following changes

[Intel-gfx] ✓ Fi.CI.BAT: success for Start cleaning up register definitions (rev3)

2022-01-10 Thread Patchwork
== Series Details == Series: Start cleaning up register definitions (rev3) URL : https://patchwork.freedesktop.org/series/98575/ State : success == Summary == CI Bug Log - changes from CI_DRM_11061 -> Patchwork_21961 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC engine for higher moderates

2022-01-10 Thread Navare, Manasi
On Mon, Jan 10, 2022 at 08:24:54PM -0800, Kulkarni, Vandita wrote: > > -Original Message- > > From: Navare, Manasi D > > Sent: Tuesday, January 11, 2022 1:07 AM > > To: Kulkarni, Vandita > > Cc: Nikula, Jani ; Lisovskiy, Stanislav > > ; Ville Syrjälä > > ; > >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Start cleaning up register definitions (rev3)

2022-01-10 Thread Patchwork
== Series Details == Series: Start cleaning up register definitions (rev3) URL : https://patchwork.freedesktop.org/series/98575/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Start cleaning up register definitions (rev3)

2022-01-10 Thread Patchwork
== Series Details == Series: Start cleaning up register definitions (rev3) URL : https://patchwork.freedesktop.org/series/98575/ State : warning == Summary == $ dim checkpatch origin/drm-tip e41d2f04b72a drm/i915: Use parameterized GPR register definitions everywhere -:22:

[Intel-gfx] [PATCH v3 01/11] drm/i915: Use parameterized GPR register definitions everywhere

2022-01-10 Thread Matt Roper
Since we have an engine-parameterized macro GEN8_RING_CS_GPR, let's use that in place of the HSW_CS_GPR and BCS_GPR register definitions. Cc: Jani Nikula Signed-off-by: Matt Roper Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/i915_cmd_parser.c | 68 ++

[Intel-gfx] [PATCH v3 10/11] drm/i915: Move TC PHY registers to their own header

2022-01-10 Thread Matt Roper
Registers representing the MG/DKL TC PHYs (including the TC DPLLs which exist inside the PHY) are only needed in a couple files and on specific platforms; let's keep them separate from the general register pool. Cc: Jani Nikula Signed-off-by: Matt Roper ---

[Intel-gfx] [PATCH v3 03/11] drm/i915: Parameterize ECOSKPD

2022-01-10 Thread Matt Roper
Combine the separate render and blitter register definitions into a single definition. We already know we have some workarounds on an upcoming platform that will need to update the ECOSKPD register for other engines too, so this helps pave the way for that. Cc: Jani Nikula Signed-off-by: Matt

[Intel-gfx] [PATCH v3 09/11] drm/i915: Move combo PHY registers to their own header

2022-01-10 Thread Matt Roper
These registers are only needed in a couple files and on specific platforms; let's keep them separate from the general register pool. Cc: Jani Nikula Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/icl_dsi.c| 1 + .../gpu/drm/i915/display/intel_combo_phy.c| 1 +

[Intel-gfx] [PATCH v3 04/11] drm/i915: Use RING_PSMI_CTL rather than per-engine macros

2022-01-10 Thread Matt Roper
We have a parameterized macro for RING_PSMI_CTL; let's use that instead of the per-engine definitions where possible. Cc: Jani Nikula Signed-off-by: Matt Roper Reviewed-by: Jani Nikula --- .../gpu/drm/i915/gt/intel_ring_submission.c | 10 +-

[Intel-gfx] [PATCH v3 07/11] drm/i915/gt: Move engine registers to their own header

2022-01-10 Thread Matt Roper
Let's start breaking up and cleaning up the massive i915_reg.h file. We'll start by moving all registers that are defined in relation to an engine base to their own header. There are probably a bunch of other "engine registers" that we haven't moved yet (especially those that belong to the render

[Intel-gfx] [PATCH v3 08/11] drm/i915: Move SNPS PHY registers to their own header

2022-01-10 Thread Matt Roper
These registers are only needed in a couple files and on specific platforms; let's keep them separate from the general register pool. v2: - Don't forget to include i915_reg_defs.h (Jani) - Ensure include guard matches header name (Jani) Cc: Jani Nikula Signed-off-by: Matt Roper Reviewed-by:

[Intel-gfx] [PATCH v3 11/11] drm/i915: Drop unused _PORT3 and _PORT4 TC phy register offsets

2022-01-10 Thread Matt Roper
All MG/DKL PHY register regions are evenly spaced offset-wise (0x168000, 0x169000, 0x16A000, 0x16B000) so the _MMIO_PORT() macro we use to access their registers only needs the first two offsets. We can drop the _PORT3 and _PORT4 offsets which are never directly referenced. Cc: Jani Nikula

[Intel-gfx] [PATCH v3 06/11] drm/i915: Introduce i915_reg_defs.h

2022-01-10 Thread Matt Roper
We'd like to start splitting i915_reg.h into various domain-specific register files and cleaning them up. Let's move the basic macros and type definitions to their own header file that can be including in each of the new split headers. Cc: Jani Nikula Signed-off-by: Matt Roper ---

[Intel-gfx] [PATCH v3 02/11] drm/i915: Parameterize PWRCTX_MAXCNT

2022-01-10 Thread Matt Roper
Rather than having separate definitions for each engine, create a single parameterized macro that takes the engine base offset. This will also ensure we get to the proper offset if we ever need to use these registers on newer platforms (where the media engine offsets have changed). Cc: Jani

[Intel-gfx] [PATCH v3 05/11] drm/i915: Replace GFX_MODE_GEN7 with RING_MODE_GEN7

2022-01-10 Thread Matt Roper
It's preferable to use parameterized register macros where possible. Cc: Jani Nikula Signed-off-by: Matt Roper Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +- drivers/gpu/drm/i915/gvt/mmio_context.c | 4 ++-- drivers/gpu/drm/i915/i915_reg.h | 1

[Intel-gfx] [PATCH v3 00/11] Start cleaning up register definitions

2022-01-10 Thread Matt Roper
Let's start splitting up and cleaning up parts of i915_reg.h. Rather than starting with dead code removal as we did in v1, this time we'll switch a few macros to parameterized style, and then move a few types of registers (engine registers, SNPS PHY registers) off to their own header files. v3:

Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC engine for higher moderates

2022-01-10 Thread Kulkarni, Vandita
> -Original Message- > From: Navare, Manasi D > Sent: Tuesday, January 11, 2022 1:07 AM > To: Kulkarni, Vandita > Cc: Nikula, Jani ; Lisovskiy, Stanislav > ; Ville Syrjälä > ; > intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Asynchronous vma unbinding (rev7)

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding (rev7) URL : https://patchwork.freedesktop.org/series/98055/ State : success == Summary == CI Bug Log - changes from CI_DRM_11061_full -> Patchwork_21958_full Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for i915: make array flex_regs static const

2022-01-10 Thread Patchwork
== Series Details == Series: i915: make array flex_regs static const URL : https://patchwork.freedesktop.org/series/98688/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11061_full -> Patchwork_21956_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Use PM timestamp instead of RING TIMESTAMP for reference

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Use PM timestamp instead of RING TIMESTAMP for reference URL : https://patchwork.freedesktop.org/series/98714/ State : success == Summary == CI Bug Log - changes from CI_DRM_11061 -> Patchwork_21960

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/pmu: Use PM timestamp instead of RING TIMESTAMP for reference

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Use PM timestamp instead of RING TIMESTAMP for reference URL : https://patchwork.freedesktop.org/series/98714/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/fbc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE (rev2)

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915/fbc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE (rev2) URL : https://patchwork.freedesktop.org/series/98682/ State : success == Summary == CI Bug Log - changes from CI_DRM_11061_full -> Patchwork_21955_full

[Intel-gfx] [PATCH] drm/i915/pmu: Use PM timestamp instead of RING TIMESTAMP for reference

2022-01-10 Thread Umesh Nerlige Ramappa
All timestamps returned by GuC for GuC PMU busyness are captured from GUC PM TIMESTAMP. Since this timestamp does not tick when GuC goes idle, kmd uses RING_TIMESTAMP to measure busyness of an engine with an active context. In further stress testing, the MMIO read of the RING_TIMESTAMP is seen to

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Fix NULL vs IS_ERR checking for kernel_context

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fix NULL vs IS_ERR checking for kernel_context URL : https://patchwork.freedesktop.org/series/98685/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11061_full -> Patchwork_21952_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/snps: vswing value refined for SNPS phys

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915/snps: vswing value refined for SNPS phys URL : https://patchwork.freedesktop.org/series/98710/ State : success == Summary == CI Bug Log - changes from CI_DRM_11061 -> Patchwork_21959 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: fix potential refcnt issue of a dma_buf object

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915/selftests: fix potential refcnt issue of a dma_buf object URL : https://patchwork.freedesktop.org/series/98684/ State : success == Summary == CI Bug Log - changes from CI_DRM_11061_full -> Patchwork_21951_full

[Intel-gfx] [PATCH] drm/i915/snps: vswing value refined for SNPS phys

2022-01-10 Thread clinton . a . taylor
From: Clint Taylor Updated new values from BSPEC. BSPEC: 53920 Cc: Jani Nikula Cc: José Roberto de Souza Cc: Imre Deak Signed-off-by: Clint Taylor --- .../drm/i915/display/intel_ddi_buf_trans.c| 42 +-- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git

Re: [Intel-gfx] [GIT PULL] GVT next changes for drm-intel-next-queued

2022-01-10 Thread Vivi, Rodrigo
On Fri, 2022-01-07 at 14:43 +, Wang, Zhi A wrote: > Hi folks: > > Happy holidays! This pull mostly contains the code re-factors patches > from Guenter Roeck and Rikard. Also a minor change from Zhenyu. > > Zhi > > The following changes since commit >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Asynchronous vma unbinding (rev7)

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding (rev7) URL : https://patchwork.freedesktop.org/series/98055/ State : success == Summary == CI Bug Log - changes from CI_DRM_11061 -> Patchwork_21958 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Asynchronous vma unbinding (rev7)

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding (rev7) URL : https://patchwork.freedesktop.org/series/98055/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Asynchronous vma unbinding (rev7)

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding (rev7) URL : https://patchwork.freedesktop.org/series/98055/ State : warning == Summary == $ dim checkpatch origin/drm-tip fa2206c87130 drm/i915: Initial introduction of vma resources -:249: WARNING:FILE_PATH_CHANGES: added,

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: clean up i915_drv.h, part 2

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915: clean up i915_drv.h, part 2 URL : https://patchwork.freedesktop.org/series/98691/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11061 -> Patchwork_21957 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: clean up i915_drv.h, part 2

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915: clean up i915_drv.h, part 2 URL : https://patchwork.freedesktop.org/series/98691/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: clean up i915_drv.h, part 2

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915: clean up i915_drv.h, part 2 URL : https://patchwork.freedesktop.org/series/98691/ State : warning == Summary == $ dim checkpatch origin/drm-tip 69bb96496495 drm/i915: split out i915_gem.h declarations from i915_drv.h 480ab58f49c9 drm/i915: split out

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: make array flex_regs static const

2022-01-10 Thread Patchwork
== Series Details == Series: i915: make array flex_regs static const URL : https://patchwork.freedesktop.org/series/98688/ State : success == Summary == CI Bug Log - changes from CI_DRM_11061 -> Patchwork_21956 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: make array flex_regs static const

2022-01-10 Thread Patchwork
== Series Details == Series: i915: make array flex_regs static const URL : https://patchwork.freedesktop.org/series/98688/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4d8e56b193f6 i915: make array flex_regs static const -:23: WARNING:FROM_SIGN_OFF_MISMATCH:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE (rev2)

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915/fbc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE (rev2) URL : https://patchwork.freedesktop.org/series/98682/ State : success == Summary == CI Bug Log - changes from CI_DRM_11061 -> Patchwork_21955

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/fbc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE (rev2)

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915/fbc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE (rev2) URL : https://patchwork.freedesktop.org/series/98682/ State : warning == Summary == $ dim checkpatch origin/drm-tip 82610811562c drm/i915/fbc: replace DEFINE_SIMPLE_ATTRIBUTE with

Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC engine for higher moderates

2022-01-10 Thread Navare, Manasi
Thankf for revisiting this thread. The use of max_cdclk is currently in 2 places in DSC code 1. . if (adjusted_mode->crtc_clock > dev_priv->max_cdclk_freq) { if (pipe_config->dsc.slice_count > 1) { pipe_config->dsc.dsc_split = true; 2. if (bigjoiner) {

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Fix NULL vs IS_ERR checking for kernel_context

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fix NULL vs IS_ERR checking for kernel_context URL : https://patchwork.freedesktop.org/series/98685/ State : success == Summary == CI Bug Log - changes from CI_DRM_11061 -> Patchwork_21952

Re: [Intel-gfx] [TGL-U][iGFX] Monitoring the freq of iGFX with kernel 5.10 on TGL-U i5-1145GRE

2022-01-10 Thread Souza, Jose
On Mon, 2022-01-10 at 18:56 +, Schweikhardt, Markus wrote: > Hi all, >   > I would like to monitor the frequency of the iGPU of my TGL platform while > running glmark2 in bursts which means glmark2 is 5secrunning and 5sec not > running.I disabled RC6 by echo 0 >

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Add missing format_mod_supported functions (rev2)

2022-01-10 Thread Patchwork
== Series Details == Series: Add missing format_mod_supported functions (rev2) URL : https://patchwork.freedesktop.org/series/98680/ State : failure == Summary == Applying: drm/plane: Make format_mod_supported truly optional Using index info to reconstruct a base tree... M

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Discard large BIOS framebuffers causing display corruption. (rev2)

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Discard large BIOS framebuffers causing display corruption. (rev2) URL : https://patchwork.freedesktop.org/series/98683/ State : failure == Summary == Applying: drm/i915: Discard large BIOS framebuffers causing display corruption. error: patch failed:

[Intel-gfx] [TGL-U][iGFX] Monitoring the freq of iGFX with kernel 5.10 on TGL-U i5-1145GRE

2022-01-10 Thread Schweikhardt, Markus
Hi all, I would like to monitor the frequency of the iGPU of my TGL platform while running glmark2 in bursts which means glmark2 is 5sec running and 5sec not running. I disabled RC6 by echo 0 > /sys/class/drm/card0/gt_rc6_enable for my tests. Furthermore, I tried to lock the iGPU frequency to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: fix potential refcnt issue of a dma_buf object

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915/selftests: fix potential refcnt issue of a dma_buf object URL : https://patchwork.freedesktop.org/series/98684/ State : success == Summary == CI Bug Log - changes from CI_DRM_11061 -> Patchwork_21951

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/selftests: fix potential refcnt issue of a dma_buf object

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915/selftests: fix potential refcnt issue of a dma_buf object URL : https://patchwork.freedesktop.org/series/98684/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked

Re: [Intel-gfx] [RFC 7/7] drm/i915/guc: Print the GuC error capture output register list.

2022-01-10 Thread Teres Alexis, Alan Previn
On Mon, 2022-01-10 at 08:07 +, Tvrtko Ursulin wrote: > On 07/01/2022 17:03, Teres Alexis, Alan Previn wrote: > > On Fri, 2022-01-07 at 09:03 +, Tvrtko Ursulin wrote: > > > On 06/01/2022 18:33, Teres Alexis, Alan Previn wrote: > > > > On Thu, 2022-01-06 at 09:38 +, Tvrtko Ursulin

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gvt: Fix intel_vgpu_default_mmio_write() kernel-doc comment

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Fix intel_vgpu_default_mmio_write() kernel-doc comment URL : https://patchwork.freedesktop.org/series/98681/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11059_full -> Patchwork_21950_full

Re: [Intel-gfx] [PATCH v3 3/3] x86/quirks: Fix stolen detection with integrated + discrete GPU

2022-01-10 Thread Rodrigo Vivi
On Mon, Jan 10, 2022 at 11:32:11AM -0600, Bjorn Helgaas wrote: > On Mon, Jan 10, 2022 at 12:11:36PM -0500, Rodrigo Vivi wrote: > > On Fri, Jan 07, 2022 at 08:57:32PM -0600, Bjorn Helgaas wrote: > > > On Fri, Jan 07, 2022 at 01:05:16PM -0800, Lucas De Marchi wrote: > > > > early_pci_scan_bus() does

Re: [Intel-gfx] [PATCH v3 3/3] x86/quirks: Fix stolen detection with integrated + discrete GPU

2022-01-10 Thread Bjorn Helgaas
On Mon, Jan 10, 2022 at 12:11:36PM -0500, Rodrigo Vivi wrote: > On Fri, Jan 07, 2022 at 08:57:32PM -0600, Bjorn Helgaas wrote: > > On Fri, Jan 07, 2022 at 01:05:16PM -0800, Lucas De Marchi wrote: > > > early_pci_scan_bus() does a depth-first traversal, possibly calling > > > the quirk functions

[Intel-gfx] [PATCH v7 6/6] drm/i915: Use struct vma_resource instead of struct vma_snapshot

2022-01-10 Thread Thomas Hellström
There is always a struct vma_resource guaranteed to be alive when we access a corresponding struct vma_snapshot. So ditch the latter and instead of allocating vma_snapshots, reference the already existning vma_resource. This requires a couple of extra members in struct vma_resource but that's a

[Intel-gfx] [PATCH v7 5/6] drm/i915: Asynchronous migration selftest

2022-01-10 Thread Thomas Hellström
Add a selftest to exercise asynchronous migration and -unbining. Extend the gem_migrate selftest to perform the migrations while depending on a spinner and a bound vma set up on the migrated buffer object. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld ---

[Intel-gfx] [PATCH v7 4/6] drm/i915: Use vma resources for async unbinding

2022-01-10 Thread Thomas Hellström
Implement async (non-blocking) unbinding by not syncing the vma before calling unbind on the vma_resource. Add the resulting unbind fence to the object's dma_resv from where it is picked up by the ttm migration code. Ideally these unbind fences should be coalesced with the migration blit fence to

[Intel-gfx] [PATCH v7 3/6] drm/i915: Don't pin the object pages during pending vma binds

2022-01-10 Thread Thomas Hellström
A pin-count is already held by vma->pages so taking an additional pin during async binds is not necessary. When we introduce async unbinding we have other means of keeping the object pages alive. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/i915_vma.c | 5

[Intel-gfx] [PATCH v7 2/6] drm/i915: Use the vma resource as argument for gtt binding / unbinding

2022-01-10 Thread Thomas Hellström
When introducing asynchronous unbinding, the vma itself may no longer be alive when the actual binding or unbinding takes place. Update the gtt i915_vma_ops accordingly to take a struct i915_vma_resource instead of a struct i915_vma for the bind_vma() and unbind_vma() ops. Similarly change the

[Intel-gfx] [PATCH v7 1/6] drm/i915: Initial introduction of vma resources

2022-01-10 Thread Thomas Hellström
Introduce vma resources, sort of similar to TTM resources, needed for asynchronous bind management. Initially we will use them to hold completion of unbinding when we capture data from a vma, but they will be used extensively in upcoming patches for asynchronous vma unbinding. v6: - Some

[Intel-gfx] [PATCH v7 0/6] drm/i915: Asynchronous vma unbinding

2022-01-10 Thread Thomas Hellström
This patch series introduces infrastructure for asynchronous vma unbinding. The single enabled use-case is initially at buffer object migration where we otherwise sync when unbinding vmas before migration. This in theory allows us to pipeline any number of migrations, but in practice the number

Re: [Intel-gfx] [PATCH v3 2/3] x86/quirks: Improve line wrap on quirk conditions

2022-01-10 Thread Rodrigo Vivi
On Fri, Jan 07, 2022 at 01:05:15PM -0800, Lucas De Marchi wrote: > Remove extra parenthesis and wrap lines so it's easier to read what are > the conditions being checked. The call to the hook also had an extra > indentation: remove here to conform to coding style. > > Signed-off-by: Lucas De

Re: [Intel-gfx] [PATCH v3 3/3] x86/quirks: Fix stolen detection with integrated + discrete GPU

2022-01-10 Thread Rodrigo Vivi
On Fri, Jan 07, 2022 at 08:57:32PM -0600, Bjorn Helgaas wrote: > On Fri, Jan 07, 2022 at 01:05:16PM -0800, Lucas De Marchi wrote: > > early_pci_scan_bus() does a depth-first traversal, possibly calling > > the quirk functions for each device based on vendor, device and class > > from early_qrk

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2)

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2) URL : https://patchwork.freedesktop.org/series/98137/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11059_full -> Patchwork_21948_full

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Drop unused register definitions

2022-01-10 Thread Lucas De Marchi
On Mon, Jan 10, 2022 at 12:55:36PM +0200, Jani Nikula wrote: On Fri, 07 Jan 2022, Lucas De Marchi wrote: On Fri, Jan 07, 2022 at 12:46:48PM +0200, Jani Nikula wrote: I still tell people to 1) split out register definitions to separate patches, and 2) add macros for the entire feature and full

Re: [Intel-gfx] [PATCH 3/4] drm/i915/vga: switch to use VGA definitions from video/vga.h

2022-01-10 Thread Ville Syrjälä
On Mon, Jan 10, 2022 at 11:57:39AM +0200, Jani Nikula wrote: > The video/vga.h has macros for the VGA registers. Switch to use them. > > Suggested-by: Matt Roper > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_vga.c | 9 + > 1 file changed, 5 insertions(+), 4

Re: [Intel-gfx] [PATCH 2/2] drm/mst: use DP_GET_SINK_COUNT() for sink count in ESI

2022-01-10 Thread Ville Syrjälä
On Tue, Jan 04, 2022 at 08:48:57PM +0200, Jani Nikula wrote: > Take bit 7 into account when reading sink count from > DP_DEVICE_SERVICE_IRQ_VECTOR_ESI0. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [Intel-gfx] [PATCH 1/2] drm/dp: note that DPCD 0x2002-0x2003 match 0x200-0x201

2022-01-10 Thread Ville Syrjälä
On Tue, Jan 04, 2022 at 08:48:56PM +0200, Jani Nikula wrote: > DP_SINK_COUNT_ESI and DP_DEVICE_SERVICE_IRQ_VECTOR_ESI0 have the same > contents as DP_SINK_COUNT and DP_DEVICE_SERVICE_IRQ_VECTOR, > respectively. IIRC there was an oversight in the earlier spec revisions that showed bit 7 as

Re: [Intel-gfx] [PATCH 3/3] drm/atomic: Make private objs proper objects

2022-01-10 Thread Ville Syrjälä
On Fri, Dec 31, 2021 at 03:23:31PM +0200, Jani Nikula wrote: > On Wed, 12 Jul 2017, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Make the atomic private object stuff less special by introducing proper > > base classes for the object and its state. Drivers can embed these

[Intel-gfx] [PATCH 3/6] drm/i915: remove leftover i915_gem_pm.h declarations from i915_drv.h

2022-01-10 Thread Jani Nikula
Remove the duplicates. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 4 drivers/gpu/drm/i915/i915_gem.c | 1 + 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index

[Intel-gfx] [PATCH 6/6] drm/i915: split out gem/i915_gem_domain.h from i915_drv.h

2022-01-10 Thread Jani Nikula
We already have the gem/i915_gem_domain.c file. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dpt.c| 4 +++- drivers/gpu/drm/i915/display/intel_fb_pin.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_domain.c | 5 +++--

[Intel-gfx] [PATCH 5/6] drm/i915: split out gem/i915_gem_create.h from i915_drv.h

2022-01-10 Thread Jani Nikula
We already have the gem/i915_gem_create.c file. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gem/i915_gem_create.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_create.h | 17 + drivers/gpu/drm/i915/i915_driver.c | 1 +

[Intel-gfx] [PATCH 4/6] drm/i915: split out gem/i915_gem_dmabuf.h from i915_drv.h

2022-01-10 Thread Jani Nikula
We already have the gem/i915_gem_dmabuf.c file. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_dmabuf.h | 18 ++ drivers/gpu/drm/i915/gem/i915_gem_object.c | 2 ++

[Intel-gfx] [PATCH 2/6] drm/i915: split out i915_gem_internal.h from i915_drv.h

2022-01-10 Thread Jani Nikula
We already have the i915_gem_internal.c file. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dsb.c | 2 ++ drivers/gpu/drm/i915/display/intel_overlay.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_internal.c | 1 +

[Intel-gfx] [PATCH 1/6] drm/i915: split out i915_gem.h declarations from i915_drv.h

2022-01-10 Thread Jani Nikula
i915_gem.h should be the place for declarations for i915_gem.c, but looks like it's filled with all sorts of cruft. Even so, move the declarations where they belong. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 32 -

[Intel-gfx] [PATCH 0/6] drm/i915: clean up i915_drv.h, part 2

2022-01-10 Thread Jani Nikula
Next six patches from [1], chopping it up a bit. BR, Jani. [1] https://patchwork.freedesktop.org/series/98515/ Jani Nikula (6): drm/i915: split out i915_gem.h declarations from i915_drv.h drm/i915: split out i915_gem_internal.h from i915_drv.h drm/i915: remove leftover i915_gem_pm.h

Re: [Intel-gfx] [PATCH v6 4/6] drm/i915: Use vma resources for async unbinding

2022-01-10 Thread Thomas Hellström
On 1/10/22 14:21, Matthew Auld wrote: On 07/01/2022 14:23, Thomas Hellström wrote: Implement async (non-blocking) unbinding by not syncing the vma before calling unbind on the vma_resource. Add the resulting unbind fence to the object's dma_resv from where it is picked up by the ttm migration

Re: [Intel-gfx] [PATCH v6 5/6] drm/i915: Asynchronous migration selftest

2022-01-10 Thread Matthew Auld
On 10/01/2022 14:36, Thomas Hellström wrote: On 1/10/22 14:59, Matthew Auld wrote: On 07/01/2022 14:23, Thomas Hellström wrote: Add a selftest to exercise asynchronous migration and -unbining. Extend the gem_migrate selftest to perform the migrations while depending on a spinner and a bound

Re: [Intel-gfx] [PATCH v6 5/6] drm/i915: Asynchronous migration selftest

2022-01-10 Thread Thomas Hellström
On 1/10/22 14:59, Matthew Auld wrote: On 07/01/2022 14:23, Thomas Hellström wrote: Add a selftest to exercise asynchronous migration and -unbining. Extend the gem_migrate selftest to perform the migrations while depending on a spinner and a bound vma set up on the migrated buffer object.

Re: [Intel-gfx] [PATCH 2/4] drm/i915: split out vlv sideband registers from i915_reg.h

2022-01-10 Thread Jani Nikula
On Mon, 10 Jan 2022, Jani Nikula wrote: > Add a dedicated file vlv_sideband_reg.h for the VLV/CHV sideband > registers. The sideband registers macros are needed by the same files > that need vlv_sideband.h, so include the definitions from there. > > v2: Fix copyright year (Matt) > > Cc: Matt

Re: [Intel-gfx] [PATCH 0/5] drm/i915: clean up i915_drv.h, part 1

2022-01-10 Thread Jani Nikula
On Fri, 07 Jan 2022, Jani Nikula wrote: > On Fri, 07 Jan 2022, Jani Nikula wrote: >> First five patches from [1], chopping it up a bit. > > Aarrgh. Today I learned, the hard way, that you can actually specify > both files *and* rev-list to git send-email at the same time, and it'll > send all.

Re: [Intel-gfx] [PATCH v6 6/6] drm/i915: Use struct vma_resource instead of struct vma_snapshot

2022-01-10 Thread Matthew Auld
On Fri, 7 Jan 2022 at 14:24, Thomas Hellström wrote: > > There is always a struct vma_resource guaranteed to be alive when we > access a corresponding struct vma_snapshot. > > So ditch the latter and instead of allocating vma_snapshots, reference > the already existning vma_resource. > > This

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: Fix intel_vgpu_default_mmio_write() kernel-doc comment

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Fix intel_vgpu_default_mmio_write() kernel-doc comment URL : https://patchwork.freedesktop.org/series/98681/ State : success == Summary == CI Bug Log - changes from CI_DRM_11059 -> Patchwork_21950

Re: [Intel-gfx] [PATCH v6 5/6] drm/i915: Asynchronous migration selftest

2022-01-10 Thread Matthew Auld
On 07/01/2022 14:23, Thomas Hellström wrote: Add a selftest to exercise asynchronous migration and -unbining. Extend the gem_migrate selftest to perform the migrations while depending on a spinner and a bound vma set up on the migrated buffer object. Signed-off-by: Thomas Hellström ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2)

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2) URL : https://patchwork.freedesktop.org/series/98137/ State : success == Summary == CI Bug Log - changes from CI_DRM_11059 -> Patchwork_21948

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: remove questionable fence optimization during copy

2022-01-10 Thread Patchwork
== Series Details == Series: drm/i915: remove questionable fence optimization during copy URL : https://patchwork.freedesktop.org/series/98679/ State : failure == Summary == Applying: drm/i915: remove questionable fence optimization during copy Using index info to reconstruct a base tree... M

Re: [Intel-gfx] [PATCH] drm/i915: Discard large BIOS framebuffers causing display corruption.

2022-01-10 Thread Aditya Garg
On 07-Jan-2022, at 6:17 PM, Jani Nikula mailto:jani.nik...@linux.intel.com>> wrote: On Fri, 07 Jan 2022, Ashish Arora mailto:ashisharora.li...@outlook.com>> wrote: From: Ashish Arora mailto:ashisharora.li...@outlook.com>> On certain 4k panels, the BIOS framebuffer is larger than what panel

Re: [Intel-gfx] [PATCH] drm/i915: Discard large BIOS framebuffers causing display corruption.

2022-01-10 Thread Aditya Garg
> On 07-Jan-2022, at 6:17 PM, Jani Nikula wrote: > > On Fri, 07 Jan 2022, Ashish Arora wrote: >> From: Ashish Arora >> >> On certain 4k panels, the BIOS framebuffer is larger than what panel >> requires causing display corruption. Introduce a check for the same. > > This is quite thin on

[Intel-gfx] [PATCH v3 2/6] drm/plane: Fix typo in format_mod_supported documentation

2022-01-10 Thread José Expósito
Fix minor typo: "valdiate" -> "validate". Signed-off-by: José Expósito Reviewed-by: Simon Ser --- include/drm/drm_plane.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index 0c1102dc4d88..06759badf99f 100644 ---

[Intel-gfx] [PATCH v3 1/6] drm/plane: Make format_mod_supported truly optional

2022-01-10 Thread José Expósito
The documentation for "drm_plane_funcs.format_mod_supported" reads: This *optional* hook is used for the DRM to determine if the given format/modifier combination is valid for the plane. This allows the DRM to generate the correct format bitmask (which formats apply to which modifier),

[Intel-gfx] [PATCH v3 3/6] drm/simple-kms: Drop format_mod_supported function

2022-01-10 Thread José Expósito
The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/drm_simple_kms_helper.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c

[Intel-gfx] [PATCH] i915: make array flex_regs static const

2022-01-10 Thread Colin Ian King
Don't populate the read-only array flex_regs on the stack but instead it static const. Also makes the object code a little smaller. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/i915_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH - v2] drm/i915: Discard large BIOS framebuffers causing display corruption.

2022-01-10 Thread Ashish Arora
From: Ashish Arora On certain 4k panels, the BIOS framebuffer is larger than what panel requires causing display corruption. Introduce a check for the same. Signed-off-by: Ashish Arora --- drivers/gpu/drm/i915/display/intel_fbdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[Intel-gfx] [PATCH -next] drm/i915/fbc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2022-01-10 Thread Yang Li
Fix the following coccicheck warning: ./drivers/gpu/drm/i915/display/intel_fbc.c:1757:0-23: WARNING: intel_fbc_debugfs_false_color_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/i915/display/intel_fbc.c | 2 +- 1 file

Re: [Intel-gfx] [PATCH] drm/i915: Discard large BIOS framebuffers causing display corruption.

2022-01-10 Thread Ashish Arora
I believe I forgot to add Aditya to the conversation. So, I am sending the patch as an attachment for those who want to test :) 0001-drm.patch Description: 0001-drm.patch

Re: [Intel-gfx] [PATCH v3 4/4] drm/i915/fbc: Register per-crtc debugfs files

2022-01-10 Thread Nathan Chancellor
On Tue, Dec 21, 2021 at 06:05:34PM +0200, Ville Syrjälä wrote: > On Sat, Dec 18, 2021 at 06:00:47PM -0700, Nathan Chancellor wrote: > > Hi Ville, > > > > On Mon, Dec 13, 2021 at 05:14:35PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Expose FBC debugfs files for each crtc.

[Intel-gfx] [PATCH v3 5/6] drm: mxsfb: Drop format_mod_supported function

2022-01-10 Thread José Expósito
The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/gpu/drm/mxsfb/mxsfb_kms.c

[Intel-gfx] i915 hangs up every second time in deep suspend

2022-01-10 Thread Florian Dollinger
My Lenovo Thinkbook 13s-IWL is hanging up every second time when I put the device into the deep suspend mode. I put the device into suspend, the display is turning off, but the power button does not reach the slowly flashing mode. After a while the Laptop simply reboots. I was able to work

[Intel-gfx] [PATCH v2 6/6] drm/stm: ltdc: Drop format_mod_supported function

2022-01-10 Thread José Expósito
The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/stm/ltdc.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index

[Intel-gfx] [PATCH v3 4/6] drm/i915/display: Drop format_mod_supported function

2022-01-10 Thread José Expósito
The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/i915/display/intel_cursor.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cursor.c

Re: [Intel-gfx] [PATCH] drm/i915: Discard large BIOS framebuffers causing display corruption.

2022-01-10 Thread Ashish Arora
Hi Orlando Thanks for informing that the Macs are also affected :). I've sne the v2 of the patch. You may try out if you want to. Get Outlook for Android From: Orlando Chamberlain Sent: Saturday, January 8, 2022 10:41:50 AM To:

Re: [Intel-gfx] [PATCH - v2] drm/i915: Discard large BIOS framebuffers causing display corruption.

2022-01-10 Thread Ashish Arora
Hi Jani Please review the patch and tell is something else is required. From: Ashish Arora Sent: Friday, 7 January, 2022, 8:32 pm To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; rodrigo.v...@intel.com Cc: intel-gfx@lists.freedesktop.org;

  1   2   >