Re: [Intel-gfx] [PULL v2] gvt-next

2022-04-20 Thread Joonas Lahtinen
+ Tvrtko Quoting Christoph Hellwig (2022-04-21 08:47:38) > On Thu, Apr 21, 2022 at 04:57:34AM +, Wang, Zhi A wrote: > > Is it possible that I can send two different pull based on the same branch? > > I was thinking I can remove this line in the original patch and then add a > > small patch to

Re: [Intel-gfx] [PATCH 05/34] drm/i915/gvt: cleanup the Makefile

2022-04-20 Thread Joonas Lahtinen
+ Tvrtko Quoting Jason Gunthorpe (2022-04-13 17:45:48) > On Wed, Apr 13, 2022 at 02:26:23PM +, Wang, Zhi A wrote: > > On 4/13/22 1:43 PM, Jason Gunthorpe wrote: > > > On Wed, Apr 13, 2022 at 01:39:35PM +, Wang, Zhi A wrote: > > > > > >> It seems Jani's makefile clean patch has already inc

Re: [Intel-gfx] [PATCH] drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines

2022-04-20 Thread Joonas Lahtinen
Quoting Ville Syrjälä (2022-04-20 19:23:57) > On Wed, Apr 20, 2022 at 05:32:43PM +0200, Hans de Goede wrote: > > Hi Ville, > > > > On 4/20/22 16:03, Ville Syrjälä wrote: > > > On Mon, Apr 18, 2022 at 05:09:36PM +0200, Hans de Goede wrote: > > >> Commit 428cb15d5b00 ("drm/i915: Clean up pre-skl pri

Re: [Intel-gfx] [PATCH] drm/i915: Fix race in __i915_vma_remove_closed

2022-04-20 Thread kernel test robot
Hi Karol, I love your patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on linus/master v5.18-rc3 next-20220420] [cannot apply to drm-intel/for-linux-next linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915 writeback private framework (rev5)

2022-04-20 Thread Patchwork
== Series Details == Series: i915 writeback private framework (rev5) URL : https://patchwork.freedesktop.org/series/101425/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11530 -> Patchwork_101425v5 Summary --- **FAIL

Re: [Intel-gfx] [PULL v2] gvt-next

2022-04-20 Thread Christoph Hellwig
On Thu, Apr 21, 2022 at 04:57:34AM +, Wang, Zhi A wrote: > Is it possible that I can send two different pull based on the same branch? > I was thinking I can remove this line in the original patch and then add a > small patch to add this line back on the top. Then make two different tags > befo

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915 writeback private framework (rev5)

2022-04-20 Thread Patchwork
== Series Details == Series: i915 writeback private framework (rev5) URL : https://patchwork.freedesktop.org/series/101425/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915 writeback private framework (rev5)

2022-04-20 Thread Patchwork
== Series Details == Series: i915 writeback private framework (rev5) URL : https://patchwork.freedesktop.org/series/101425/ State : warning == Summary == Error: dim checkpatch failed 41097e64119f drm/i915: Creating writeback pipeline to bypass drm_writeback framework Traceback (most recent ca

Re: [Intel-gfx] [RFC PATCH v2 04/10] KVM: x86: mmu: tweak fast path for emulation of access to nested NPT pages

2022-04-20 Thread Maxim Levitsky
On Thu, 2022-04-21 at 08:12 +0300, Maxim Levitsky wrote: > --- > arch/x86/kvm/mmu/mmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > index 23f895d439cf5..b63398dfdac3b 100644 > --- a/arch/x86/kvm/mmu/mmu.c > +++ b/a

[Intel-gfx] [RFC PATCH v2 10/10] KVM: SVM: allow to avoid not needed updates to is_running

2022-04-20 Thread Maxim Levitsky
Allow optionally to make KVM not update is_running unless it is functionally needed which is only when a vCPU halts, or is in the guest mode. This means security wise that if a vCPU is scheduled out, other vCPUs could still send doorbell messages to the last physical CPU where this vCPU was last r

[Intel-gfx] [RFC PATCH v2 09/10] KVM: nSVM: implement support for nested AVIC

2022-04-20 Thread Maxim Levitsky
This implements initial support of using the AVIC in a nested guest Signed-off-by: Maxim Levitsky --- arch/x86/kvm/svm/avic.c | 850 +- arch/x86/kvm/svm/nested.c | 131 +- arch/x86/kvm/svm/svm.c| 18 + arch/x86/kvm/svm/svm.h| 150 +++ arch/x

[Intel-gfx] [RFC PATCH v2 07/10] KVM: x86: SVM: move avic state to separate struct

2022-04-20 Thread Maxim Levitsky
This will make the code a bit easier to read when nested AVIC support is added. No functional change intended. Signed-off-by: Maxim Levitsky --- arch/x86/kvm/svm/avic.c | 49 +++-- arch/x86/kvm/svm/svm.h | 14 +++- 2 files changed, 36 insertions(+),

[Intel-gfx] [RFC PATCH v2 08/10] KVM: x86: rename .set_apic_access_page_addr to reload_apic_access_page

2022-04-20 Thread Maxim Levitsky
This will be used on SVM to reload shadow page of the AVIC physid table No functional change intended Signed-off-by: Maxim Levitsky --- arch/x86/include/asm/kvm-x86-ops.h | 2 +- arch/x86/include/asm/kvm_host.h| 3 +-- arch/x86/kvm/vmx/vmx.c | 8 arch/x86/kvm/x86.c

[Intel-gfx] [RFC PATCH v2 06/10] KVM: x86: SVM: remove avic's broken code that updated APIC ID

2022-04-20 Thread Maxim Levitsky
Now that KVM doesn't allow to change APIC ID in case AVIC is enabled, remove buggy AVIC code that tried to do so. Signed-off-by: Maxim Levitsky --- arch/x86/kvm/svm/avic.c | 35 --- 1 file changed, 35 deletions(-) diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/k

[Intel-gfx] [RFC PATCH v2 05/10] KVM: x86: lapic: don't allow to change APIC ID when apic acceleration is enabled

2022-04-20 Thread Maxim Levitsky
No normal guest has any reason to change physical APIC IDs, and allowing this introduces bugs into APIC acceleration code. Signed-off-by: Maxim Levitsky --- arch/x86/kvm/lapic.c | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/arch/x86/kvm/lapic.c

[Intel-gfx] [RFC PATCH v2 04/10] KVM: x86: mmu: tweak fast path for emulation of access to nested NPT pages

2022-04-20 Thread Maxim Levitsky
--- arch/x86/kvm/mmu/mmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index 23f895d439cf5..b63398dfdac3b 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -5315,8 +5315,8 @@ int kvm_mmu_page_fault(struct

[Intel-gfx] [RFC PATCH v2 03/10] KVM: x86: mmu: add gfn_in_memslot helper

2022-04-20 Thread Maxim Levitsky
This is a tiny refactoring, and can be useful to check if a GPA/GFN is within a memslot a bit more cleanly. Signed-off-by: Maxim Levitsky --- include/linux/kvm_host.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h

[Intel-gfx] [RFC PATCH v2 02/10] x86: KVMGT: use kvm_page_track_write_tracking_enable

2022-04-20 Thread Maxim Levitsky
This allows to enable the write tracking only when KVMGT is actually used and doesn't carry any penalty otherwise. Tested by booting a VM with a kvmgt mdev device. Signed-off-by: Maxim Levitsky --- arch/x86/kvm/Kconfig | 3 --- arch/x86/kvm/mmu/mmu.c | 2 +- drivers/gpu/dr

[Intel-gfx] [RFC PATCH v2 01/10] KVM: x86: mmu: allow to enable write tracking externally

2022-04-20 Thread Maxim Levitsky
This will be used to enable write tracking from nested AVIC code and can also be used to enable write tracking in GVT-g module when it actually uses it as opposed to always enabling it, when the module is compiled in the kernel. No functional change intended. Signed-off-by: Maxim Levitsky --- a

[Intel-gfx] [RFC PATCH v2 00/10] RFCv2: nested AVIC

2022-04-20 Thread Maxim Levitsky
This patch series implement everything that is needed to use AMD's AVIC while a nested guest is running including ability of the nested guest to use it, and brings feature parity vs APICv. Compared to v1 of the series, there are lot of fixes, and refactoring. This version still use unconditional

[Intel-gfx] [RFC PATCH 3/3] drm/i915: Enabling WD Transcoder

2022-04-20 Thread Suraj Kandpal
Adding support for writeback transcoder to start capturing frames using interrupt mechanism Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_acpi.c | 1 + drivers/gpu/drm/i915/display/intel_display.c | 89 +- drive

[Intel-gfx] [RFC PATCH 2/3] drm/i915: Define WD trancoder for i915

2022-04-20 Thread Suraj Kandpal
Adding WD Types, WD transcoder to enum list and WD Transcoder offsets Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_display.h | 6 ++ drivers/gpu/drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/i915_reg.h| 2 ++ 3 files chang

[Intel-gfx] [RFC PATCH 1/3] drm/i915: Creating writeback pipeline to bypass drm_writeback framework

2022-04-20 Thread Suraj Kandpal
Changes to create a i915 private pipeline to enable the WD transcoder without relying on the current drm_writeback framework. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/Makefile | 1 + .../drm/i915/display/intel_display_types.h| 4 + .../gpu/drm/i915/display/in

[Intel-gfx] [RFC PATCH 0/3] i915 writeback private framework

2022-04-20 Thread Suraj Kandpal
A patch series was floated in the drm mailing list which aimed to change the drm_connector and drm_encoder fields to pointer in the drm_connector_writeback structure, this received a huge pushback from the community but since i915 expects each connector present in the drm_device list to be a intel_

Re: [Intel-gfx] [PULL v2] gvt-next

2022-04-20 Thread Wang, Zhi A
On 4/20/22 8:00 PM, Jason Gunthorpe wrote: > On Wed, Apr 20, 2022 at 02:46:00PM -0300, Jason Gunthorpe wrote: >> On Wed, Apr 20, 2022 at 11:40:33AM -0600, Alex Williamson wrote: >>> On Wed, 20 Apr 2022 13:43:51 -0300 >>> Jason Gunthorpe wrote: >>> On Wed, Apr 20, 2022 at 04:34:47PM +, Wan

Re: [Intel-gfx] [RFC v2 1/2] drm/doc/rfc: VM_BIND feature design document

2022-04-20 Thread Niranjana Vishwanathapura
On Wed, Mar 09, 2022 at 10:58:09AM -0500, Alex Deucher wrote: On Mon, Mar 7, 2022 at 3:30 PM Niranjana Vishwanathapura wrote: VM_BIND design document with description of intended use cases. Signed-off-by: Niranjana Vishwanathapura --- Documentation/gpu/rfc/i915_vm_bind.rst | 210 +++

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/4] drm/i915: consider min_page_size when migrating

2022-04-20 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: consider min_page_size when migrating URL : https://patchwork.freedesktop.org/series/102879/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11528_full -> Patchwork_102879v1_full ==

Re: [Intel-gfx] [RFC v2 1/2] drm/doc/rfc: VM_BIND feature design document

2022-04-20 Thread Niranjana Vishwanathapura
On Thu, Mar 31, 2022 at 01:37:08PM +0200, Daniel Vetter wrote: One thing I've forgotten, since it's only hinted at here: If/when we switch tlb flushing from the current dumb&synchronous implementation we now have in i915 in upstream to one with batching using dma_fence, then I think that should b

Re: [Intel-gfx] [RFC v2 1/2] drm/doc/rfc: VM_BIND feature design document

2022-04-20 Thread Niranjana Vishwanathapura
On Thu, Mar 31, 2022 at 10:28:48AM +0200, Daniel Vetter wrote: Adding a pile of people who've expressed interest in vm_bind for their drivers. Also note to the intel folks: This is largely written with me having my subsystem co-maintainer hat on, i.e. what I think is the right thing to do here f

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Disable DC5 before going to DC9

2022-04-20 Thread Patchwork
== Series Details == Series: drm/i915: Disable DC5 before going to DC9 URL : https://patchwork.freedesktop.org/series/102881/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/102881/revisions/1/mbox/ not applied Applying: drm/i915: Disable DC5 befor

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/4] drm/i915: consider min_page_size when migrating

2022-04-20 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: consider min_page_size when migrating URL : https://patchwork.freedesktop.org/series/102879/ State : success == Summary == CI Bug Log - changes from CI_DRM_11528 -> Patchwork_102879v1

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/doc: add rfc section for small BAR uapi

2022-04-20 Thread Patchwork
== Series Details == Series: drm/doc: add rfc section for small BAR uapi URL : https://patchwork.freedesktop.org/series/102875/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11528 -> Patchwork_102875v1 Summary --- **

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/doc: add rfc section for small BAR uapi

2022-04-20 Thread Patchwork
== Series Details == Series: drm/doc: add rfc section for small BAR uapi URL : https://patchwork.freedesktop.org/series/102875/ State : warning == Summary == Error: dim checkpatch failed 778440992ee2 drm/doc: add rfc section for small BAR uapi -:28: WARNING:FILE_PATH_CHANGES: added, moved or d

Re: [Intel-gfx] [RFC v2 2/2] drm/doc/rfc: VM_BIND uapi definition

2022-04-20 Thread Niranjana Vishwanathapura
On Wed, Mar 30, 2022 at 02:51:41PM +0200, Daniel Vetter wrote: On Mon, Mar 07, 2022 at 12:31:46PM -0800, Niranjana Vishwanathapura wrote: VM_BIND und related uapi definitions Signed-off-by: Niranjana Vishwanathapura --- Documentation/gpu/rfc/i915_vm_bind.h | 176 +++

Re: [Intel-gfx] [PATCH 7/9] drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-04-20 Thread Andrzej Hajda
On 20.04.2022 18:12, Dixit, Ashutosh wrote: On Wed, 20 Apr 2022 05:17:57 -0700, Andrzej Hajda wrote: Hi Ashutosh, Hi Andrzej, On 20.04.2022 07:21, Ashutosh Dixit wrote: All kmalloc'd kobjects need a kobject_put() to free memory. For example in previous code, kobj_gt_release() never gets c

Re: [Intel-gfx] [PATCH 03/15] dma-buf & drm/amdgpu: remove dma_resv workaround

2022-04-20 Thread Zack Rusin
On Wed, 2022-04-20 at 20:56 +0200, Christian König wrote: > ⚠ External Email > > Am 20.04.22 um 20:49 schrieb Christian König: > > Am 20.04.22 um 20:41 schrieb Zack Rusin: > > > On Wed, 2022-04-20 at 19:40 +0200, Christian König wrote: > > > > Am 20.04.22 um 19:38 schrieb Zack Rusin: > > > > > On

Re: [Intel-gfx] [PATCH] drm/i915: Disable DC5 before going to DC9

2022-04-20 Thread Rodrigo Vivi
On Wed, Apr 20, 2022 at 10:21:19PM +0300, Imre Deak wrote: > On Wed, Apr 20, 2022 at 03:09:21PM -0400, Rodrigo Vivi wrote: > > According to BSPec: > > Sequence to Allow DC9: > > 1. Follow Sequence to Disallow DC5. > > > > which is: > > Sequence to Disallow DC5 and DC6 > >

Re: [Intel-gfx] [PATCH] drm/i915: Disable DC5 before going to DC9

2022-04-20 Thread Imre Deak
On Wed, Apr 20, 2022 at 03:09:21PM -0400, Rodrigo Vivi wrote: > According to BSPec: > Sequence to Allow DC9: > 1. Follow Sequence to Disallow DC5. > > which is: > Sequence to Disallow DC5 and DC6 > Set DC_STATE_EN Dynamic DC State Enable = "Disable". > > I

Re: [Intel-gfx] [PATCH] drm/i915: Disable DC5 before going to DC9

2022-04-20 Thread Srivatsa, Anusha
> -Original Message- > From: Vivi, Rodrigo > Sent: Wednesday, April 20, 2022 12:09 PM > To: intel-gfx@lists.freedesktop.org > Cc: Vivi, Rodrigo ; Deak, Imre > ; Gupta, Anshuman ; > Srivatsa, Anusha > Subject: [PATCH] drm/i915: Disable DC5 before going to DC9 > > According to BSPec: >

[Intel-gfx] [PATCH] drm/i915: Disable DC5 before going to DC9

2022-04-20 Thread Rodrigo Vivi
According to BSPec: Sequence to Allow DC9: 1. Follow Sequence to Disallow DC5. which is: Sequence to Disallow DC5 and DC6 Set DC_STATE_EN Dynamic DC State Enable = "Disable". I understand that we haven't had any issue so far. But since DC9 is a soft

Re: [Intel-gfx] [PATCH 03/15] dma-buf & drm/amdgpu: remove dma_resv workaround

2022-04-20 Thread Zack Rusin
On Wed, 2022-04-20 at 19:40 +0200, Christian König wrote: > > Am 20.04.22 um 19:38 schrieb Zack Rusin: > > On Wed, 2022-04-20 at 09:37 +0200, Christian König wrote: > > > ⚠ External Email > > > > > > Hi Zack, > > > > > > Am 20.04.22 um 05:56 schrieb Zack Rusin: > > > > On Thu, 2022-04-07 at 10:5

[Intel-gfx] [CI 3/4] drm/i915/selftests: fixup min_alignment usage

2022-04-20 Thread Matthew Auld
Trying to cast the region id into the region type doesn't work too well, since the i915_vm_min_alignment() won't give us the correct value for the stolen-lmem case. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Nirmoy Das Cc: Ramalingam C --- drivers/gpu/drm/i915/selftests/i915_gem_gtt

[Intel-gfx] [CI 4/4] drm/i915/selftests: tweak the misaligned_case

2022-04-20 Thread Matthew Auld
The compact-pt layout restrictions should only apply to the ppGTT. Also make this play nice on platforms that only have the 64K GTT restriction, and not the compact-pt thing. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Nirmoy Das Cc: Ramalingam C --- drivers/gpu/drm/i915/selftests/i9

[Intel-gfx] [CI 2/4] drm/i915/buddy: sanity check the size

2022-04-20 Thread Matthew Auld
Ensure we check that the size is compatible with the requested page_size. For tiny objects that are automatically annotated with TTM_PL_FLAG_CONTIGUOUS(since they fit within a single page), we currently end up silently overriding the min_page_size, which ends up hiding bugs elsewhere. Signed-off-b

[Intel-gfx] [CI 1/4] drm/i915: consider min_page_size when migrating

2022-04-20 Thread Matthew Auld
We can only force migrate an object if the existing object size is compatible with the new destinations min_page_size for the region. Currently we blow up with something like: [ 2857.497462] kernel BUG at drivers/gpu/drm/i915/gt/intel_migrate.c:431! [ 2857.497497] invalid opcode: [#1] PREEMPT

Re: [Intel-gfx] [PULL v2] gvt-next

2022-04-20 Thread Alex Williamson
On Wed, 20 Apr 2022 13:43:51 -0300 Jason Gunthorpe wrote: > On Wed, Apr 20, 2022 at 04:34:47PM +, Wang, Zhi A wrote: > > Hi folks: > > > > Here is the PR of gvt-next. Thanks so much for the patience. > > > > Mostly it includes the patch bundle of GVT-g re-factor patches for adapting > > th

Re: [Intel-gfx] [PATCH 03/15] dma-buf & drm/amdgpu: remove dma_resv workaround

2022-04-20 Thread Zack Rusin
On Wed, 2022-04-20 at 09:37 +0200, Christian König wrote: > ⚠ External Email > > Hi Zack, > > Am 20.04.22 um 05:56 schrieb Zack Rusin: > > On Thu, 2022-04-07 at 10:59 +0200, Christian König wrote: > > > Rework the internals of the dma_resv object to allow adding more > > > than > > > one > > > wr

[Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

2022-04-20 Thread Matthew Auld
Add an entry for the new uapi needed for small BAR on DG2+. v2: - Some spelling fixes and other small tweaks. (Akeem & Thomas) - Rework error capture interactions, including no longer needing NEEDS_CPU_ACCESS for objects marked for capture. (Thomas) - Add probed_cpu_visible_size. (Lionel

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/2] drm/i915/display: Add workaround 22014263786 (rev3)

2022-04-20 Thread Souza, Jose
On Wed, 2022-04-20 at 15:49 +, Patchwork wrote: Patch Details Series: series starting with [v2,1/2] drm/i915/display: Add workaround 22014263786 (rev3) URL:https://patchwork.freedesktop.org/series/102835/ State: success Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_1

[Intel-gfx] [PULL v2] gvt-next

2022-04-20 Thread Wang, Zhi A
Hi folks: Here is the PR of gvt-next. Thanks so much for the patience. Mostly it includes the patch bundle of GVT-g re-factor patches for adapting the GVT-g with the new MDEV interfaces: - Separating the MMIO table from GVT-g. (Zhi) - GVT-g re-factor. (Christoph) - GVT-g mdev API cleanup. (Jaso

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-20 Thread Vivi, Rodrigo
On Tue, 2022-04-19 at 22:54 -0700, Dixit, Ashutosh wrote: > On Fri, 15 Apr 2022 03:21:26 -0700, Rodrigo Vivi wrote: > > On Thu, Apr 14, 2022 at 03:31:07PM -0700, Dixit, Ashutosh wrote: > > > On Thu, 14 Apr 2022 06:28:57 -0700, Jani Nikula wrote: > > > > > > > > On Wed, 13 Apr 2022, Ashutosh Dixit

Re: [Intel-gfx] [PATCH 7/9] drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-04-20 Thread Dixit, Ashutosh
On Wed, 20 Apr 2022 05:17:57 -0700, Andrzej Hajda wrote: > > Hi Ashutosh, Hi Andrzej, > On 20.04.2022 07:21, Ashutosh Dixit wrote: > > All kmalloc'd kobjects need a kobject_put() to free memory. For example in > > previous code, kobj_gt_release() never gets called. The requirement of > > kobject_

Re: [Intel-gfx] [PATCH] drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines

2022-04-20 Thread Ville Syrjälä
On Wed, Apr 20, 2022 at 05:32:43PM +0200, Hans de Goede wrote: > Hi Ville, > > On 4/20/22 16:03, Ville Syrjälä wrote: > > On Mon, Apr 18, 2022 at 05:09:36PM +0200, Hans de Goede wrote: > >> Commit 428cb15d5b00 ("drm/i915: Clean up pre-skl primary plane registers") > >> introduced DISP_POS_Y and DI

Re: [Intel-gfx] [PULL] gvt-next

2022-04-20 Thread Wang, Zhi A
On 4/20/22 3:02 PM, Jason Gunthorpe wrote: > On Wed, Apr 20, 2022 at 02:41:04PM +, Wang, Zhi A wrote: >> On 4/20/22 12:13 PM, Jason Gunthorpe wrote: >>> On Wed, Apr 20, 2022 at 08:04:31AM +, Wang, Zhi A wrote: Hi folks: Here is the PR of gvt-next. Mostly it includes

Re: [Intel-gfx] [PATCH 7/9] drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-04-20 Thread Dixit, Ashutosh
On Wed, 20 Apr 2022 05:17:57 -0700, Andrzej Hajda wrote: > > Hi Ashutosh, Hi Andrzej, > On 20.04.2022 07:21, Ashutosh Dixit wrote: > > All kmalloc'd kobjects need a kobject_put() to free memory. For example in > > previous code, kobj_gt_release() never gets called. The requirement of > > kobject_

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/2] drm/i915/display: Add workaround 22014263786 (rev3)

2022-04-20 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/display: Add workaround 22014263786 (rev3) URL : https://patchwork.freedesktop.org/series/102835/ State : success == Summary == CI Bug Log - changes from CI_DRM_11526_full -> Patchwork_102835v3_full ==

Re: [Intel-gfx] [PATCH] drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines

2022-04-20 Thread Hans de Goede
Hi Ville, On 4/20/22 16:03, Ville Syrjälä wrote: > On Mon, Apr 18, 2022 at 05:09:36PM +0200, Hans de Goede wrote: >> Commit 428cb15d5b00 ("drm/i915: Clean up pre-skl primary plane registers") >> introduced DISP_POS_Y and DISP_HEIGHT defines but accidentally set these >> their masks to REG_GENMASK(

Re: [Intel-gfx] [PULL] gvt-next

2022-04-20 Thread Wang, Zhi A
On 4/20/22 12:13 PM, Jason Gunthorpe wrote: > On Wed, Apr 20, 2022 at 08:04:31AM +, Wang, Zhi A wrote: >> Hi folks: >> >> Here is the PR of gvt-next. >> >> Mostly it includes the patch bundle of GVT-g re-factor patches for adapting >> the GVT-g with the >> new MDEV interfaces: >> >> - Separati

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/display: Add workaround 22014263786 (rev3)

2022-04-20 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/display: Add workaround 22014263786 (rev3) URL : https://patchwork.freedesktop.org/series/102835/ State : success == Summary == CI Bug Log - changes from CI_DRM_11526 -> Patchwork_102835v3

Re: [Intel-gfx] [PATCH] drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines

2022-04-20 Thread Ville Syrjälä
On Mon, Apr 18, 2022 at 05:09:36PM +0200, Hans de Goede wrote: > Commit 428cb15d5b00 ("drm/i915: Clean up pre-skl primary plane registers") > introduced DISP_POS_Y and DISP_HEIGHT defines but accidentally set these > their masks to REG_GENMASK(31, 0) instead of REG_GENMASK(31, 16). > > This breaks

Re: [Intel-gfx] [PATCH v4] drm/i915: program wm blocks to at least blocks required per line

2022-04-20 Thread Ville Syrjälä
On Sun, Apr 17, 2022 at 12:31:05PM +0300, Vinod Govindapillai wrote: > In configurations with single DRAM channel, for usecases like > 4K 60 Hz, FIFO underruns are observed quite frequently. Looks > like the wm0 watermark values need to bumped up because the wm0 > memory latency calculations are pr

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/i915/display: Add workaround 22014263786 (rev3)

2022-04-20 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/display: Add workaround 22014263786 (rev3) URL : https://patchwork.freedesktop.org/series/102835/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked sepa

[Intel-gfx] [PULL] drm-intel-fixes

2022-04-20 Thread Joonas Lahtinen
Hi Dave & Daniel, Here go drm-intel-fixes for v5.18-rc4. Two display fixes: Disable VRR if user disables it from panel settings and avoid claiming PSR2 is enabled when it is not supported by config. Regards, Joonas *** drm-intel-fixes-2022-04-20: - Unset enable_psr2_sel_fetch if PSR2 detectio

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix race in __i915_vma_remove_closed (rev2)

2022-04-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix race in __i915_vma_remove_closed (rev2) URL : https://patchwork.freedesktop.org/series/102845/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11526_full -> Patchwork_102845v2_full S

Re: [Intel-gfx] [PATCH 7/9] drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-04-20 Thread Andrzej Hajda
Hi Ashutosh, On 20.04.2022 07:21, Ashutosh Dixit wrote: All kmalloc'd kobjects need a kobject_put() to free memory. For example in previous code, kobj_gt_release() never gets called. The requirement of kobject_put() now results in a slightly different code organization. Cc: Andi Shyti Cc: Andr

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix race in __i915_vma_remove_closed (rev2)

2022-04-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix race in __i915_vma_remove_closed (rev2) URL : https://patchwork.freedesktop.org/series/102845/ State : success == Summary == CI Bug Log - changes from CI_DRM_11526 -> Patchwork_102845v2 Summary ---

[Intel-gfx] [PATCH v2] drm/i915: Fix race in __i915_vma_remove_closed

2022-04-20 Thread Karol Herbst
i915_vma_reopen checked if the vma is closed before without taking the lock. So multiple threads could attempt removing the vma. Instead the lock needs to be taken before actually checking. v2: move struct declaration Cc: Chris Wilson Cc: intel-gfx@lists.freedesktop.org Cc: dri-de...@lists.free

Re: [Intel-gfx] [PATCH] drm/i915: Fix race in __i915_vma_remove_closed

2022-04-20 Thread kernel test robot
. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Karol-Herbst/drm-i915-Fix-race-in-__i915_vma_remove_closed/20220420-074525 base: git://anongit.freedesktop.org/d

[Intel-gfx] [PULL] gvt-next

2022-04-20 Thread Wang, Zhi A
Hi folks: Here is the PR of gvt-next. Mostly it includes the patch bundle of GVT-g re-factor patches for adapting the GVT-g with the new MDEV interfaces: - Separating the MMIO table from GVT-g. (Zhi) - GVT-g re-factor. (Christoph) - GVT-g mdev API cleanup. (Jason) - GVT-g trace/makefile cleanup

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Media freq factor and per-gt enhancements/fixes (rev2)

2022-04-20 Thread Patchwork
== Series Details == Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev2) URL : https://patchwork.freedesktop.org/series/102665/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11523 -> Patchwork_102665v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Media freq factor and per-gt enhancements/fixes (rev2)

2022-04-20 Thread Patchwork
== Series Details == Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev2) URL : https://patchwork.freedesktop.org/series/102665/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Media freq factor and per-gt enhancements/fixes (rev2)

2022-04-20 Thread Patchwork
== Series Details == Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev2) URL : https://patchwork.freedesktop.org/series/102665/ State : warning == Summary == Error: dim checkpatch failed 2993d1f47961 drm/i915: Introduce has_media_ratio_mode bce07f6f7b01 drm/i915/gt: Add me

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v3

2022-04-20 Thread Wang, Zhi A
On 4/20/22 7:08 AM, Christoph Hellwig wrote: > On Thu, Apr 14, 2022 at 11:38:59AM -0300, Jason Gunthorpe wrote: >> pull requests can flow through more than one tree concurrently. The >> purpose of the topic branch is to allow all the commits to be in all >> the trees they need to be in at once. >>

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v3

2022-04-20 Thread Christoph Hellwig
On Thu, Apr 14, 2022 at 11:38:59AM -0300, Jason Gunthorpe wrote: > pull requests can flow through more than one tree concurrently. The > purpose of the topic branch is to allow all the commits to be in all > the trees they need to be in at once. > > So you should send this branch as a PR to the ne