Re: [Intel-gfx] [PATCH 7/9] drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-04-28 Thread Dixit, Ashutosh
On Thu, 28 Apr 2022 07:36:14 -0700, Andrzej Hajda wrote: > On 27.04.2022 22:46, Dixit, Ashutosh wrote: > > On Sun, 24 Apr 2022 15:36:23 -0700, Andi Shyti wrote: > >> Hi Andrzej and Ashutosh, > >> > >> b/drivers/gpu/drm/i915/gt/intel_gt_types.h > >> index 937b2e1a305e..4c72b4f983a6 100644 >

Re: [Intel-gfx] [PATCH 5/9] drm/i915/pcode: Add a couple of pcode helpers

2022-04-28 Thread Dixit, Ashutosh
On Sun, 24 Apr 2022 15:00:24 -0700, Andi Shyti wrote: > > Hi Ashutosh, > > On Tue, Apr 19, 2022 at 11:25:05PM -0700, Ashutosh Dixit wrote: > > From: Dale B Stimson > > > > Add a couple of helpers to help formatting pcode commands and improve code > > readability. > > Can you please add some more

Re: [Intel-gfx] [PATCH 3/9] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-28 Thread Dixit, Ashutosh
On Sun, 24 Apr 2022 12:08:18 -0700, Andi Shyti wrote: > > Hi Ashutosh, Hi Andi, > [...] > > > -static bool skl_pcode_try_request(struct drm_i915_private *i915, u32 mbox, > > - u32 request, u32 reply_mask, u32 reply, > > - u32 *status) > >

Re: [Intel-gfx] [PATCH 4/9] drm/i915/gt: Convert callers to user per-gt pcode functions

2022-04-28 Thread Dixit, Ashutosh
On Sun, 24 Apr 2022 14:54:22 -0700, Andi Shyti wrote: > > Hi Ashutosh, > > On Tue, Apr 19, 2022 at 11:25:04PM -0700, Ashutosh Dixit wrote: > > Convert appropriate callers to use per-gt pcode functions. Callers using > > pcode functions at "global scope", including *all* display functions are > >

Re: [Intel-gfx] [PATCH 6/9] drm/i915/gt: Add media RP0/RPn to per-gt sysfs

2022-04-28 Thread Dixit, Ashutosh
On Sun, 24 Apr 2022 15:05:47 -0700, Andi Shyti wrote: > > Hi Ashutosh, > > [...] > > > +static ssize_t media_RP0_freq_mhz_show(struct device *dev, > > + struct device_attribute *attr, > > + char *buff) > > +{ > > + struct intel_gt

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Media freq factor and per-gt enhancements/fixes (rev3)

2022-04-28 Thread Patchwork
== Series Details == Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev3) URL : https://patchwork.freedesktop.org/series/102665/ State : success == Summary == CI Bug Log - changes from CI_DRM_11550 -> Patchwork_102665v3

Re: [Intel-gfx] linux-next: manual merge of the amdgpu tree with the drm-misc tree

2022-04-28 Thread Stephen Rothwell
Hi all, On Wed, 13 Apr 2022 10:10:14 +1000 Stephen Rothwell wrote: > > On Wed, 6 Apr 2022 10:34:05 +1000 Stephen Rothwell > wrote: > > > > Today's linux-next merge of the amdgpu tree got a conflict in: > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > > > > between commit: > > > >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Media freq factor and per-gt enhancements/fixes (rev3)

2022-04-28 Thread Patchwork
== Series Details == Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev3) URL : https://patchwork.freedesktop.org/series/102665/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Media freq factor and per-gt enhancements/fixes (rev3)

2022-04-28 Thread Patchwork
== Series Details == Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev3) URL : https://patchwork.freedesktop.org/series/102665/ State : warning == Summary == Error: dim checkpatch failed 81e412ac8d3c drm/i915: Introduce has_media_ratio_mode 3ae6e0c36677 drm/i915/gt: Add

[Intel-gfx] [PATCH 6/9] drm/i915/gt: Add media RP0/RPn to per-gt sysfs

2022-04-28 Thread Ashutosh Dixit
From: Dale B Stimson Retrieve RP0 and RPn freq for media IP from PCODE and display in per-gt sysfs. This patch adds the following files to gt/gtN sysfs: * media_RP0_freq_mhz * media_RPn_freq_mhz v2: Fixed commit author (Rodrigo) v3: Convert to new uncore interface for pcode functions Cc:

[Intel-gfx] [PATCH 9/9] drm/i915/gt: Expose default value for media_freq_factor in per-gt sysfs

2022-04-28 Thread Ashutosh Dixit
Add the following sysfs file to gt/gtN/.defaults: * media_freq_factor Cc: Joonas Lahtinen Cc: Rodrigo Vivi Signed-off-by: Ashutosh Dixit --- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 18 ++ drivers/gpu/drm/i915/gt/intel_gt_types.h| 1 +

[Intel-gfx] [PATCH 8/9] drm/i915/gt: Expose per-gt RPS defaults in sysfs

2022-04-28 Thread Ashutosh Dixit
Create a gt/gtN/.defaults directory (similar to engine//.defaults) to expose default parameter values for each gt in sysfs. Populate the .defaults directory with RPS parameter default values in order to allow userspace to revert to default values when needed. This patch adds the following sysfs

[Intel-gfx] [PATCH 5/9] drm/i915/pcode: Add a couple of pcode helpers

2022-04-28 Thread Ashutosh Dixit
From: Dale B Stimson Some dGfx pcode commands take additional sub-commands and parameters. Add a couple of helpers to help formatting these commands to improve code readability. v2: Fixed commit author (Rodrigo) v3: Function rename and convert to new uncore interface for pcode functions

[Intel-gfx] [PATCH 4/9] drm/i915/gt: Convert callers to use per-gt pcode functions

2022-04-28 Thread Ashutosh Dixit
Convert appropriate callers to use per-gt pcode functions. Callers using pcode functions at "global scope", including *all* display functions are not converted, they continue to use the legacy pcode interface. v2: Convert to new uncore interface for pcode functions Cc: Andi Shyti Cc: Rodrigo

[Intel-gfx] [PATCH 7/9] drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-04-28 Thread Ashutosh Dixit
All kmalloc'd kobjects need a kobject_put() to free memory. For example in previous code, kobj_gt_release() never gets called. The requirement of kobject_put() now results in a slightly different code organization. v2: s/gtn/gt/ (Andi) Cc: Andi Shyti Cc: Andrzej Hajda Fixes: b770bcfae9ad

[Intel-gfx] [PATCH 3/9] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-28 Thread Ashutosh Dixit
Each gt contains an independent instance of pcode. Extend pcode functions to interface with pcode on different gt's. To avoid creating dependency of display functionality on intel_gt, new pcode function interfaces are exposed in terms of uncore rather than intel_gt. Previous struct

[Intel-gfx] [PATCH 2/9] drm/i915/gt: Add media freq factor to per-gt sysfs

2022-04-28 Thread Ashutosh Dixit
Expose new sysfs to program and retrieve media freq factor. Factor values of 0 (dynamic), 0.5 and 1.0 are supported via a u8.8 fixed point representation (corresponding to integer values of 0, 128 and 256 respectively). Media freq factor is converted to media_ratio_mode for GuC. It is programmed

[Intel-gfx] [PATCH 1/9] drm/i915: Introduce has_media_ratio_mode

2022-04-28 Thread Ashutosh Dixit
Media ratio mode (the ability for media IP to work at a different frequency from the GT) is available for a subset of dGfx platforms supporting GuC/SLPC. Introduce 'has_media_ratio_mode' flag in intel_device_info to identify these platforms and set it for XEHPSDV and DG2/ATS-M. Signed-off-by:

[Intel-gfx] [PATCH v3 0/9] drm/i915: Media freq factor and per-gt enhancements/fixes

2022-04-28 Thread Ashutosh Dixit
Some recent Intel dGfx platforms allow media IP to work at a different frequency from the base GT. This patch series exposes sysfs controls for this functionality in the new per-gt sysfs. Some enhancements and fixes to previous per-gt functionality are also included to complete the new

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/display: Do not schedule DRRS work thread when it is not active

2022-04-28 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display: Do not schedule DRRS work thread when it is not active URL : https://patchwork.freedesktop.org/series/103294/ State : success == Summary == CI Bug Log - changes from CI_DRM_11550_full -> Patchwork_103294v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/display: Do not schedule DRRS work thread when it is not active

2022-04-28 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display: Do not schedule DRRS work thread when it is not active URL : https://patchwork.freedesktop.org/series/103294/ State : success == Summary == CI Bug Log - changes from CI_DRM_11550 -> Patchwork_103294v1

Re: [Intel-gfx] [PULL] gvt-next

2022-04-28 Thread Alex Williamson
On Thu, 28 Apr 2022 15:35:58 -0600 Alex Williamson wrote: > On Tue, 26 Apr 2022 08:52:58 -0300 > Jason Gunthorpe wrote: > > > On Tue, Apr 26, 2022 at 08:42:25AM +, Wang, Zhi A wrote: > > > On 4/26/22 8:37 AM, Jani Nikula wrote: > > > > On Tue, 26 Apr 2022, "Wang, Zhi A" wrote: >

Re: [Intel-gfx] [PULL] gvt-next

2022-04-28 Thread Alex Williamson
On Tue, 26 Apr 2022 08:52:58 -0300 Jason Gunthorpe wrote: > On Tue, Apr 26, 2022 at 08:42:25AM +, Wang, Zhi A wrote: > > On 4/26/22 8:37 AM, Jani Nikula wrote: > > > On Tue, 26 Apr 2022, "Wang, Zhi A" wrote: > > >> Hi folks: > > >> > > >> Here is the pull of gvt-next which fixs the

[Intel-gfx] [PULL] gvt-next-2022-04-29

2022-04-28 Thread Wang, Zhi A
Hi folks: Here is the pull of gvt-next which fixes the compilation error and warnings for the the GVT-g refactor patches: - Fix a compiling warning of non-static function only having one caller. - Fix a potential NULL pointer reference in the code re-factor. - Fix a compiling error when

[Intel-gfx] [PATCH 2/3] drm/i915/display: Allow DRRS to be enabled during driver load

2022-04-28 Thread José Roberto de Souza
When driver takes over display from firmware it does some checks and if possible it tries to avoid a modeset to improve user boot experience. But even if DRRS is supported it was being left disabled as intel_crtc_copy_fastset() was overwritten new state with the old one (hardware readout). So

[Intel-gfx] [PATCH 3/3] drm/i915/display: Implement seamless mode switch

2022-04-28 Thread José Roberto de Souza
So far the i915's DRRS feature was automatically changing between preferred panel mode and downclock mode based on idleness but ChromeOS compositor team is asking to be in control of the mode switch. So for certain types of content it can switch to a mode with a lower refresh rate without the user

[Intel-gfx] [PATCH 1/3] drm/i915/display: Do not schedule DRRS work thread when it is not active

2022-04-28 Thread José Roberto de Souza
Frontbuffer updates were scheduling the execution of DRRS work thread even if DRRS is not active. There was no issues with it because intel_drrs_downclock_work() checks if DRRS is active but there is no reason to keep scheduling this work thread and wasting CPU time. Cc: Ville Syrjälä

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/i915/gvt: Fix missing static

2022-04-28 Thread Lucas De Marchi
On Thu, Apr 28, 2022 at 08:55:48PM +, Patchwork wrote: == Series Details == Series: series starting with [1/2] drm/i915/gvt: Fix missing static URL : https://patchwork.freedesktop.org/series/103293/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh CALL

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen region (rev5)

2022-04-28 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen region (rev5) URL : https://patchwork.freedesktop.org/series/102540/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11550 -> Patchwork_102540v5 Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/i915/gvt: Fix missing static

2022-04-28 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gvt: Fix missing static URL : https://patchwork.freedesktop.org/series/103293/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gvt: Fix missing static

2022-04-28 Thread Lucas De Marchi
On Thu, Apr 28, 2022 at 01:42:53PM -0700, Wang, Zhi A wrote: On 4/28/22 8:40 PM, De Marchi, Lucas wrote: Fix broken build: $ make W=1 drivers/gpu/drm/i915/gvt/handlers.o ... CC [M] drivers/gpu/drm/i915/gvt/handlers.o drivers/gpu/drm/i915/gvt/handlers.c:75:6: error:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: ttm for stolen region (rev5)

2022-04-28 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen region (rev5) URL : https://patchwork.freedesktop.org/series/102540/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gvt: Fix missing static

2022-04-28 Thread Wang, Zhi A
On 4/28/22 8:40 PM, De Marchi, Lucas wrote: > Fix broken build: > > $ make W=1 drivers/gpu/drm/i915/gvt/handlers.o > ... > CC [M] drivers/gpu/drm/i915/gvt/handlers.o > drivers/gpu/drm/i915/gvt/handlers.c:75:6: error: no previous prototype > for

[Intel-gfx] [PATCH 2/2] drm/i915/gvt: Fix wrong kernel doc

2022-04-28 Thread Lucas De Marchi
Fix function name when documenting it: drivers/gpu/drm/i915/gvt/handlers.c:3066: warning: expecting prototype for intel_t_default_mmio_write(). Prototype was for intel_vgpu_default_mmio_write() instead Fixes: e39c5add3221 ("drm/i915/gvt: vGPU MMIO virtualization")

[Intel-gfx] [PATCH 1/2] drm/i915/gvt: Fix missing static

2022-04-28 Thread Lucas De Marchi
Fix broken build: $ make W=1 drivers/gpu/drm/i915/gvt/handlers.o ... CC [M] drivers/gpu/drm/i915/gvt/handlers.o drivers/gpu/drm/i915/gvt/handlers.c:75:6: error: no previous prototype for ‘intel_gvt_match_device’ [-Werror=missing-prototypes] 75 |

[Intel-gfx] [PATCH v5 6/6] drm/i915: stolen memory use ttm backend

2022-04-28 Thread Robert Beckett
refactor stolen memory region to use ttm. this necessitates using ttm resources to track reserved stolen regions instead of drm_mm_nodes. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/display/intel_fbc.c | 78 +-- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 -

[Intel-gfx] [PATCH v5 5/6] drm/i915: allow memory region creators to alloc and free the region

2022-04-28 Thread Robert Beckett
add callbacks for alloc and free. this allows region creators to allocate any extra storage they may require. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/intel_memory_region.c | 16 +--- drivers/gpu/drm/i915/intel_memory_region.h | 2 ++ 2 files changed, 15

[Intel-gfx] [PATCH v5 4/6] drm/i915: ttm backend dont provide mmap_offset for kernel buffers

2022-04-28 Thread Robert Beckett
stolen/kernel buffers should not be mmapable by userland. do not provide callbacks to facilitate this for these buffers. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 32 + 1 file changed, 27 insertions(+), 5 deletions(-) diff --git

[Intel-gfx] [PATCH v5 3/6] drm/i915: ttm move/clear logic fix

2022-04-28 Thread Robert Beckett
ttm managed buffers start off with system resource definitions and ttm_tt tracking structures allocated (though unpopulated). currently this prevents clearing of buffers on first move to desired placements. The desired behaviour is to clear user allocated buffers and any kernel buffers that

[Intel-gfx] [PATCH v5 2/6] drm/i915: sanitize mem_flags for stolen buffers

2022-04-28 Thread Robert Beckett
Stolen regions are not page backed or considered iomem. Prevent flags indicating such. This correctly prevents stolen buffers from attempting to directly map them. See i915_gem_object_has_struct_page() and i915_gem_object_has_iomem() usage for where it would break otherwise. Signed-off-by:

[Intel-gfx] [PATCH v5 1/6] drm/i915: instantiate ttm ranger manager for stolen memory

2022-04-28 Thread Robert Beckett
prepare for ttm based stolen region by using ttm range manager as the resource manager for stolen region. Signed-off-by: Robert Beckett Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 6 ++-- drivers/gpu/drm/i915/intel_region_ttm.c | 31

[Intel-gfx] [PATCH v5 0/6] drm/i915: ttm for stolen region

2022-04-28 Thread Robert Beckett
This series refactors i915's stolen memory region to use ttm. v2: handle disabled stolen similar to legacy version. relying on ttm to fail allocs works fine, but is dmesg noisy and causes testing dmesg warning regressions. v3: rebase to latest drm-tip. fix v2

[Intel-gfx] PR for new GuC v70.1.2 for DG2

2022-04-28 Thread John . C . Harrison
The following changes since commit ac21ab5d1de0de34201c90d32eee436f873d1e5b: Mellanox: Add lc_ini_bundle for xx.2010.1006 (2022-04-25 07:36:16 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware guc_v70.1.2_dg2 for you to fetch changes up to

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Replace shmem memory region and object backend with TTM

2022-04-28 Thread Matthew Auld
On Thu, 28 Apr 2022 at 09:39, Adrian Larumbe wrote: > > Remove shmem region and object backend code as they are now unnecessary. > In the case of objects placed in SMEM and backed by kernel shmem files, the > file pointer has to be retrieved from the ttm_tt structure, so change this > as well.

Re: [Intel-gfx] [PATCH] i915/guc/reset: Make __guc_reset_context aware of guilty engines

2022-04-28 Thread Teres Alexis, Alan Previn
At a high level, this change looks good and simple. However, inside __guc_reset_context, i think there might be an observed change in behavior for parallel submission. (or perhaps this change is part the intent?): Unless my understanding is incorrect, assuming a parallel submission

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-04-28 Thread Vudum, Lakshminarayana
Addressed the failure and re-reported. Re-opened the issue https://gitlab.freedesktop.org/drm/intel/-/issues/5196 igt@syncobj_timeline@wait-all-for-submit-snapshot - fail - Failed assertion: __syncobj_timeline_wait_ioctl(wait->fd, >wait) == 0, error: -62 != 0 Filed a new issue

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-04-28 Thread Patchwork
== Series Details == Series: drm/i915/gt: Fix memory leaks in per-gt sysfs URL : https://patchwork.freedesktop.org/series/103236/ State : success == Summary == CI Bug Log - changes from CI_DRM_11550_full -> Patchwork_103236v1_full Summary

Re: [Intel-gfx] [PATCH 7/9] drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-04-28 Thread Andrzej Hajda
On 27.04.2022 22:46, Dixit, Ashutosh wrote: On Sun, 24 Apr 2022 15:36:23 -0700, Andi Shyti wrote: Hi Andrzej and Ashutosh, b/drivers/gpu/drm/i915/gt/intel_gt_types.h index 937b2e1a305e..4c72b4f983a6 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_types.h +++

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Convert ct buffer to iosys_map

2022-04-28 Thread Siva Mullati
On 14/04/22 17:41, Balasubramani Vivekanandan wrote: > On 04.04.2022 15:01, Mullati Siva wrote: >> From: Siva Mullati >> >> Convert CT commands and descriptors to use iosys_map rather >> than plain pointer and save it in the intel_guc_ct_buffer struct. >> This will help with ct_write and

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/xehp: Add compute engine ABI

2022-04-28 Thread Andi Shyti
Hi Matt, On Wed, Apr 27, 2022 at 09:19:25PM -0700, Matt Roper wrote: > We're now ready to start exposing compute engines to userspace. > > v2: > - Move kerneldoc for other engine classes to a separate patch. (Andi) > > Cc: Daniele Ceraolo Spurio > Cc: Tvrtko Ursulin > Cc: Vinay Belgaumkar

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/uapi: Add kerneldoc for engine class enum

2022-04-28 Thread Andi Shyti
Hi Matt, On Wed, Apr 27, 2022 at 09:19:23PM -0700, Matt Roper wrote: > We'll be adding a new type of engine soon. Let's document the existing > engine classes first to help make it clear what each type of engine is > used for. > > Cc: Andi Shyti > Signed-off-by: Matt Roper Reviewed-by: Andi

Re: [Intel-gfx] [RFC v2 1/2] drm/doc/rfc: VM_BIND feature design document

2022-04-28 Thread Daniel Vetter
On Wed, Apr 27, 2022 at 08:41:35AM -0700, Niranjana Vishwanathapura wrote: > On Wed, Apr 20, 2022 at 03:45:25PM -0700, Niranjana Vishwanathapura wrote: > > On Thu, Mar 31, 2022 at 10:28:48AM +0200, Daniel Vetter wrote: > > > Adding a pile of people who've expressed interest in vm_bind for their >

Re: [Intel-gfx] [PATCH 5/5] drm/i915/sseu: Disassociate internal subslice mask representation from uapi

2022-04-28 Thread Tvrtko Ursulin
Hi, On 28/04/2022 00:07, Matt Roper wrote: Rather than storing subslice masks internally as u8[] (inside the sseu structure) and u32 (everywhere else), let's move over to using an intel_sseu_ss_mask_t typedef compatible with the operations in linux/bitmap.h. We're soon going to start adding

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/xehp: Add register for compute engine's MMIO-based TLB invalidation

2022-04-28 Thread Kumar Valsan, Prathap
On Wed, Apr 27, 2022 at 09:19:24PM -0700, Matt Roper wrote: > Compute engines have a separate register that the driver should use to > perform MMIO-based TLB invalidation. > > Note that the term "context" in this register's bspec description is > used to refer to the engine instance (in the same

Re: [Intel-gfx] [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-04-28 Thread Daniel Vetter
On Thu, Apr 28, 2022 at 10:08:47AM +0200, Maxime Ripard wrote: > Hi Daniel, > > On Wed, Apr 13, 2022 at 01:20:11PM +0200, Daniel Vetter wrote: > > On Wed, 13 Apr 2022 at 01:36, Abhinav Kumar > > wrote: > > > On 4/8/2022 9:04 PM, Abhinav Kumar wrote: > > > > > > > > > > > > On 4/7/2022 4:12 PM,

Re: [Intel-gfx] [RFC PATCH 0/3] i915 writeback private framework

2022-04-28 Thread Laurent Pinchart
Hi Suraj, On Thu, Apr 28, 2022 at 05:51:47AM +, Kandpal, Suraj wrote: > ++Laurent ,Dmitry, and Abhinav > > Hi, > Can you have a look at the private implementation i915 is currently going > with till > we can figure out how to work with drm core . No, sorry, I barely have time to follow up

Re: [Intel-gfx] [RFC v2 1/2] drm/vrr: Attach vrr_enabled property to the drm crtc

2022-04-28 Thread Modem, Bhanuprakash
On Wed-27-04-2022 03:31 am, Navare, Manasi wrote: On Mon, Apr 25, 2022 at 12:16:11PM +0530, Bhanuprakash Modem wrote: Modern display hardware is capable of supporting variable refresh rates. This patch introduces helpers to attach and set "vrr_enabled" property on the crtc to allow userspace to

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

2022-04-28 Thread Tvrtko Ursulin
On 28/04/2022 11:25, Matthew Auld wrote: On 28/04/2022 09:55, Tvrtko Ursulin wrote: On 27/04/2022 18:36, Matthew Auld wrote: On 27/04/2022 09:36, Tvrtko Ursulin wrote: On 20/04/2022 18:13, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2:    - Some

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix -Wstringop-overflow warning in call to intel_read_wm_latency()

2022-04-28 Thread Patchwork
== Series Details == Series: drm/i915: Fix -Wstringop-overflow warning in call to intel_read_wm_latency() URL : https://patchwork.freedesktop.org/series/103260/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11550_full -> Patchwork_103260v1_full

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

2022-04-28 Thread Matthew Auld
On 28/04/2022 09:55, Tvrtko Ursulin wrote: On 27/04/2022 18:36, Matthew Auld wrote: On 27/04/2022 09:36, Tvrtko Ursulin wrote: On 20/04/2022 18:13, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2:    - Some spelling fixes and other small tweaks. (Akeem &

Re: [Intel-gfx] [RFC PATCH 1/3] drm/i915: Creating writeback pipeline to bypass drm_writeback framework

2022-04-28 Thread Kandpal, Suraj
++Laurent ,Dmitry, and Abhinav > Changes to create a i915 private pipeline to enable the WD transcoder > without relying on the current drm_writeback framework. > > Signed-off-by: Suraj Kandpal > --- > drivers/gpu/drm/i915/Makefile | 1 + >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix -Wstringop-overflow warning in call to intel_read_wm_latency()

2022-04-28 Thread Patchwork
== Series Details == Series: drm/i915: Fix -Wstringop-overflow warning in call to intel_read_wm_latency() URL : https://patchwork.freedesktop.org/series/103260/ State : success == Summary == CI Bug Log - changes from CI_DRM_11550 -> Patchwork_103260v1

[Intel-gfx] ✗ Fi.CI.BUILD: failure for i915/gvt: Fix NULL pointer dereference in init_mmio_block_handlers

2022-04-28 Thread Patchwork
== Series Details == Series: i915/gvt: Fix NULL pointer dereference in init_mmio_block_handlers URL : https://patchwork.freedesktop.org/series/103261/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/103261/revisions/1/mbox/ not applied Applying:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix -Wstringop-overflow warning in call to intel_read_wm_latency()

2022-04-28 Thread Patchwork
== Series Details == Series: drm/i915: Fix -Wstringop-overflow warning in call to intel_read_wm_latency() URL : https://patchwork.freedesktop.org/series/103260/ State : warning == Summary == Error: dim checkpatch failed bb6f50272286 drm/i915: Fix -Wstringop-overflow warning in call to

[Intel-gfx] ✗ Fi.CI.BAT: failure for Replace shmem memory region and object backend with TTM

2022-04-28 Thread Patchwork
== Series Details == Series: Replace shmem memory region and object backend with TTM URL : https://patchwork.freedesktop.org/series/103259/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11550 -> Patchwork_103259v1 Summary

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

2022-04-28 Thread Tvrtko Ursulin
On 27/04/2022 18:36, Matthew Auld wrote: On 27/04/2022 09:36, Tvrtko Ursulin wrote: On 20/04/2022 18:13, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2:    - Some spelling fixes and other small tweaks. (Akeem & Thomas)    - Rework error capture

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Replace shmem memory region and object backend with TTM

2022-04-28 Thread Patchwork
== Series Details == Series: Replace shmem memory region and object backend with TTM URL : https://patchwork.freedesktop.org/series/103259/ State : warning == Summary == Error: dim checkpatch failed d619a74d74ea drm/i915: Replace shmem memory region and object backend with TTM -:37:

[Intel-gfx] [PATCH] i915/gvt: Fix NULL pointer dereference in init_mmio_block_handlers

2022-04-28 Thread Wan Jiabing
Fix following coccicheck error: ./drivers/gpu/drm/i915/gvt/handlers.c:2925:35-41: ERROR: block is NULL but dereferenced. Use gvt->mmio.mmio_block instead of block to avoid NULL pointer dereference when find_mmio_block returns NULL. Fixes: e0f74ed4634d ("i915/gvt: Separate the MMIO tracking

[Intel-gfx] [PATCH][next] drm/i915: Fix -Wstringop-overflow warning in call to intel_read_wm_latency()

2022-04-28 Thread Gustavo A. R. Silva
Fix the following -Wstringop-overflow warnings when building with GCC-11: drivers/gpu/drm/i915/intel_pm.c:3106:9: warning: ‘intel_read_wm_latency’ accessing 16 bytes in a region of size 10 [-Wstringop-overflow=] 3106 | intel_read_wm_latency(dev_priv, dev_priv->wm.pri_latency); |

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

2022-04-28 Thread Christian König
Am 27.04.22 um 17:02 schrieb Matthew Auld: On 27/04/2022 07:55, Christian König wrote: Well usually we increment the drm minor version when adding some new flags on amdgpu. Additional to that just one comment from our experience with that: You don't just need one flag, but two. The first one

Re: [Intel-gfx] [PATCH v2] drm/doc: add rfc section for small BAR uapi

2022-04-28 Thread Christian König
Well usually we increment the drm minor version when adding some new flags on amdgpu. Additional to that just one comment from our experience with that: You don't just need one flag, but two. The first one is a hint which says "CPU access needed" and the second is a promise which says "CPU

[Intel-gfx] [PATCH 1/1] drm/i915: Replace shmem memory region and object backend with TTM

2022-04-28 Thread Adrian Larumbe
Remove shmem region and object backend code as they are now unnecessary. In the case of objects placed in SMEM and backed by kernel shmem files, the file pointer has to be retrieved from the ttm_tt structure, so change this as well. This means accessing an shmem-backed BO's file pointer requires

[Intel-gfx] [PATCH 0/1] Replace shmem memory region and object backend with TTM

2022-04-28 Thread Adrian Larumbe
This patch is an attempt at eliminating the old shmem memory region and GEM object backend, in favour of a TTM-based one that is able to manage objects placed on both system and local memory. Known issues: Many GPU hungs in machines of GEN <= 5. My assumption is this has something to do with a

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/xehp: Add register for compute engine's MMIO-based TLB invalidation

2022-04-28 Thread Tvrtko Ursulin
On 28/04/2022 05:19, Matt Roper wrote: Compute engines have a separate register that the driver should use to perform MMIO-based TLB invalidation. Note that the term "context" in this register's bspec description is used to refer to the engine instance (in the same way "context" is used on

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Fix the compiling error when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n

2022-04-28 Thread Jani Nikula
On Wed, 27 Apr 2022, Zhi Wang wrote: > A compiling error was reported when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n. > Fix the problem by using the pre-defined macro. > > Cc: Jason Gunthorpe > Cc: Jani Nikula > Signed-off-by: Zhi Wang We'll get this right, for now, but I do wonder if breaking these

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gvt: Make intel_gvt_match_device() static

2022-04-28 Thread Jani Nikula
On Wed, 27 Apr 2022, Zhi Wang wrote: > After the refactor of GVT-g, the reference of intel_gvt_match_device() > only happens in handlers.c. Make it static to let the compiler be > happy. > > Cc: Jason Gunthorpe > Cc: Jani Nikula > Cc: Robert Beckett > Signed-off-by: Zhi Wang Reviewed-by:

Re: [Intel-gfx] [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-04-28 Thread Maxime Ripard
Hi Daniel, On Wed, Apr 13, 2022 at 01:20:11PM +0200, Daniel Vetter wrote: > On Wed, 13 Apr 2022 at 01:36, Abhinav Kumar wrote: > > On 4/8/2022 9:04 PM, Abhinav Kumar wrote: > > > > > > > > > On 4/7/2022 4:12 PM, Rob Clark wrote: > > >> On Thu, Apr 7, 2022 at 3:59 PM Abhinav Kumar > > >> wrote:

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/xehp: Add compute engine ABI

2022-04-28 Thread Tvrtko Ursulin
On 28/04/2022 05:19, Matt Roper wrote: We're now ready to start exposing compute engines to userspace. v2: - Move kerneldoc for other engine classes to a separate patch. (Andi) Cc: Daniele Ceraolo Spurio Cc: Tvrtko Ursulin Cc: Vinay Belgaumkar Cc: Jordan Justen Cc: Szymon Morek UMD

[Intel-gfx] [PULL] drm-misc-next

2022-04-28 Thread Maxime Ripard
Hi Daniel, Dave, Here's this week drm-misc-next PR Maxime drm-misc-next-2022-04-28: drm-misc-next for 5.19: UAPI Changes: Cross-subsystem Changes: Core Changes: - Introduction of display-helper module, and rework of the DP, DSC, HDCP, HDMI and SCDC headers - doc: Improvements for

[Intel-gfx] ✓ Fi.CI.IGT: success for i915: Turn on compute engine support (rev4)

2022-04-28 Thread Patchwork
== Series Details == Series: i915: Turn on compute engine support (rev4) URL : https://patchwork.freedesktop.org/series/103011/ State : success == Summary == CI Bug Log - changes from CI_DRM_11550_full -> Patchwork_103011v4_full Summary

[Intel-gfx] [PULL] drm-intel-fixes

2022-04-28 Thread Joonas Lahtinen
Hi Dave & Daniel, Here goes drm-intel-fixes PR for v5.18-rc5. Fixes for backlight control on XMG Core 15 e21 (#5284, regression since 5.15) and black display plane on Acer One AO532h. Then two smaller display fixes picked up by tooling. Regards, Joonas *** drm-intel-fixes-2022-04-28: - Fix