[Intel-gfx] ✓ Fi.CI.BAT: success for drm/doc/rfc: i915 VM_BIND feature design + uapi

2022-06-30 Thread Patchwork
== Series Details == Series: drm/doc/rfc: i915 VM_BIND feature design + uapi URL : https://patchwork.freedesktop.org/series/105845/ State : success == Summary == CI Bug Log - changes from CI_DRM_11837 -> Patchwork_105845v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/doc/rfc: i915 VM_BIND feature design + uapi

2022-06-30 Thread Patchwork
== Series Details == Series: drm/doc/rfc: i915 VM_BIND feature design + uapi URL : https://patchwork.freedesktop.org/series/105845/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v8 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-30 Thread Niranjana Vishwanathapura
VM_BIND and related uapi definitions v2: Reduce the scope to simple Mesa use case. v3: Expand VM_UNBIND documentation and add I915_GEM_VM_BIND/UNBIND_FENCE_VALID and I915_GEM_VM_BIND_TLB_FLUSH flags. v4: Remove I915_GEM_VM_BIND_TLB_FLUSH flag and add additional documentation for

[Intel-gfx] [PATCH v8 2/3] drm/i915: Update i915 uapi documentation

2022-06-30 Thread Niranjana Vishwanathapura
Add some missing i915 upai documentation which the new i915 VM_BIND feature documentation will be refer to. Signed-off-by: Niranjana Vishwanathapura Reviewed-by: Matthew Auld Reviewed-by: Daniel Vetter --- include/uapi/drm/i915_drm.h | 205 1 file changed,

[Intel-gfx] [PATCH v8 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-30 Thread Niranjana Vishwanathapura
VM_BIND design document with description of intended use cases. v2: Reduce the scope to simple Mesa use case. v3: Expand documentation on dma-resv usage, TLB flushing and execbuf3. v4: Remove vm_bind tlb flush request support. v5: Update TLB flushing documentation. v6: Update out of order

[Intel-gfx] [PATCH v8 0/3] drm/doc/rfc: i915 VM_BIND feature design + uapi

2022-06-30 Thread Niranjana Vishwanathapura
This is the i915 driver VM_BIND feature design RFC patch series along with the required uapi definition and description of intended use cases. v2: Reduce the scope to simple Mesa use case. Remove all compute related uapi, vm_bind/unbind queue support and only support a timeline out fence

Re: [Intel-gfx] [PATCH] drm/i915: Fix NPD in PMU during driver teardown

2022-06-30 Thread Umesh Nerlige Ramappa
On Thu, Jun 30, 2022 at 09:00:28PM +, Stuart Summers wrote: In the driver teardown, we are unregistering the gt prior to unregistering the PMU. This means there is a small window of time in which the application can request metrics from the PMU, some of which are calling into the uapi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix NPD in PMU during driver teardown (rev3)

2022-06-30 Thread Patchwork
== Series Details == Series: drm/i915: Fix NPD in PMU during driver teardown (rev3) URL : https://patchwork.freedesktop.org/series/105790/ State : success == Summary == CI Bug Log - changes from CI_DRM_11836 -> Patchwork_105790v3 Summary

[Intel-gfx] [PATCH] drm/i915: Fix NPD in PMU during driver teardown

2022-06-30 Thread Stuart Summers
In the driver teardown, we are unregistering the gt prior to unregistering the PMU. This means there is a small window of time in which the application can request metrics from the PMU, some of which are calling into the uapi engines list, while the engines are not available. In this case we can

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix NPD in PMU during driver teardown (rev2)

2022-06-30 Thread Patchwork
== Series Details == Series: drm/i915: Fix NPD in PMU during driver teardown (rev2) URL : https://patchwork.freedesktop.org/series/105790/ State : success == Summary == CI Bug Log - changes from CI_DRM_11835 -> Patchwork_105790v2 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pvc: Implement w/a 16016694945

2022-06-30 Thread Patchwork
== Series Details == Series: drm/i915/pvc: Implement w/a 16016694945 URL : https://patchwork.freedesktop.org/series/105837/ State : success == Summary == CI Bug Log - changes from CI_DRM_11835 -> Patchwork_105837v1 Summary ---

[Intel-gfx] [PATCH] drm/i915: Fix NPD in PMU during driver teardown

2022-06-30 Thread Stuart Summers
In the driver teardown, we are unregistering the gt prior to unregistering the PMU. This means there is a small window of time in which the application can request metrics from the PMU, some of which are calling into the uapi engines list, while the engines are not available. In this case we can

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dg2: Add performance workaround 18019455067 (rev3)

2022-06-30 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add performance workaround 18019455067 (rev3) URL : https://patchwork.freedesktop.org/series/105512/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11829_full -> Patchwork_105512v3_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Clean up drm_crtc.h (rev6)

2022-06-30 Thread Patchwork
== Series Details == Series: drm: Clean up drm_crtc.h (rev6) URL : https://patchwork.freedesktop.org/series/105073/ State : success == Summary == CI Bug Log - changes from CI_DRM_11835 -> Patchwork_105073v6 Summary --- **SUCCESS**

[Intel-gfx] [PATCH] drm/i915/pvc: Implement w/a 16016694945

2022-06-30 Thread Gustavo Sousa
A new PVC-specific workaround has just been added to the BSpec. BSpec: 64027 Signed-off-by: Gustavo Sousa Reviewed-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 4 drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ 2 files changed, 7 insertions(+) diff --git

[Intel-gfx] [PATCH v2 3/4] drm: Remove linux/media-bus-format.h from drm_crtc.h

2022-06-30 Thread Ville Syrjala
From: Ville Syrjälä drm_crtc.h has no need for linux/media-bus-format.h, so don't include it. Avoids useless rebuilds of the entire universe when touching linux/media-bus-format.h. Quite a few placs do currently depend on linux/media-bus-format.h without actually including it directly. All of

[Intel-gfx] [PATCH v2 4/4] drm: Remove linux/i2c.h from drm_crtc.h

2022-06-30 Thread Ville Syrjala
From: Ville Syrjälä drm_crtc.h has no need for linux/i2c.h, so don't include it. Avoids useless rebuilds of the entire universe when touching linux/i2c.h. Quite a few placs do currently depend on linux/i2c.h without actually including it directly. All of those need to be fixed up. v2: imx and

[Intel-gfx] [PATCH v2 2/4] drm: Remove linux/fb.h from drm_crtc.h

2022-06-30 Thread Ville Syrjala
From: Ville Syrjälä drm_crtc.h has no need for linux/fb.h, so don't include it. Avoids useless rebuilds of the entire universe when touching linux/fb.h. Quite a few placs do currently depend on linux/fb.h or other headers pulled in by it without actually including any of it directly. All of

[Intel-gfx] [PATCH v2 1/4] drm/vmwgfx: Stop using 'TRUE'

2022-06-30 Thread Ville Syrjala
From: Ville Syrjälä Stop using the 'TRUE' define. This ultimately gets defined by acpi/actypes.h that gets included here via a convoluted chain of other headers. drm_crtc.h is part of that chain, and I'm trying to eliminate all unnecessary includes from it to avoid pointless rebuilds. v2: Split

[Intel-gfx] [PATCH v2 0/4] drm: Clean up drm_crtc.h

2022-06-30 Thread Ville Syrjala
From: Ville Syrjälä Eliminate unnecessary includes from drm_crtc.h to avoid pointless rebuilds of the entire universe when touching some random header. v2: Half the series already merged Fix up a few allmodconfig fails not spotted earlier Split the vmwgfx change into its own patch to

Re: [Intel-gfx] [PATCH] drm/i915: Fix NPD in PMU during driver teardown

2022-06-30 Thread Summers, Stuart
On Thu, 2022-06-30 at 11:29 +0100, Tvrtko Ursulin wrote: > On 29/06/2022 19:46, Stuart Summers wrote: > > In the driver teardown, we are unregistering the gt prior > > to unregistering the PMU. This means there is a small window > > of time in which the application can request metrics from the > >

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,v4,01/13] drm/doc: add rfc section for small BAR uapi

2022-06-30 Thread Vudum, Lakshminarayana
Re-reported. Filed a new issue https://gitlab.freedesktop.org/drm/intel/-/issues/6326 igt@i915_query@query-regions-garbage-items - fail - Failed assertion: info.rsvd1[j] == 0 Lakshmi. -Original Message- From: Auld, Matthew Sent: Thursday, June 30, 2022 5:39 AM To:

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,v4,01/13] drm/doc: add rfc section for small BAR uapi

2022-06-30 Thread Patchwork
== Series Details == Series: series starting with [CI,v4,01/13] drm/doc: add rfc section for small BAR uapi URL : https://patchwork.freedesktop.org/series/105787/ State : success == Summary == CI Bug Log - changes from CI_DRM_11825_full -> Patchwork_105787v1_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: free crtc on driver remove (rev2)

2022-06-30 Thread Patchwork
== Series Details == Series: drm/i915: free crtc on driver remove (rev2) URL : https://patchwork.freedesktop.org/series/105809/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11828_full -> Patchwork_105809v2_full Summary

Re: [Intel-gfx] [PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-30 Thread Niranjana Vishwanathapura
On Thu, Jun 30, 2022 at 10:45:12AM -0500, Jason Ekstrand wrote: On Sat, Jun 25, 2022 at 8:49 PM Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions v2: Reduce the scope to simple Mesa use case. v3: Expand VM_UNBIND documentation and add

Re: [Intel-gfx] [PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-30 Thread Niranjana Vishwanathapura
On Thu, Jun 30, 2022 at 10:12:47AM -0700, Zanoni, Paulo R wrote: On Thu, 2022-06-30 at 09:18 -0700, Niranjana Vishwanathapura wrote: On Wed, Jun 29, 2022 at 11:39:52PM -0700, Zanoni, Paulo R wrote: > On Wed, 2022-06-29 at 23:08 -0700, Niranjana Vishwanathapura wrote: > > On Wed, Jun 29, 2022 at

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: PCH type cleanup

2022-06-30 Thread Patchwork
== Series Details == Series: drm/i915: PCH type cleanup URL : https://patchwork.freedesktop.org/series/105822/ State : success == Summary == CI Bug Log - changes from CI_DRM_11834 -> Patchwork_105822v1 Summary --- **SUCCESS** No

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/2] iosys-map: Add per-word read (rev2)

2022-06-30 Thread Vudum, Lakshminarayana
Created new issue https://gitlab.freedesktop.org/drm/intel/-/issues/6328 igt@kms_cursor_legacy@flip-vs-cursor.* - fail - Timed out: Stuck page flip Lakshmi. -Original Message- From: De Marchi, Lucas Sent: Wednesday, June 29, 2022 5:23 PM To: intel-gfx@lists.freedesktop.org Cc: Vudum,

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: PCH type cleanup

2022-06-30 Thread Patchwork
== Series Details == Series: drm/i915: PCH type cleanup URL : https://patchwork.freedesktop.org/series/105822/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: stop HPD workers before display driver unregister (rev2)

2022-06-30 Thread Patchwork
== Series Details == Series: drm/i915/display: stop HPD workers before display driver unregister (rev2) URL : https://patchwork.freedesktop.org/series/105557/ State : success == Summary == CI Bug Log - changes from CI_DRM_11834 -> Patchwork_105557v2

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/reset: Handle reset timeouts under unrelated kernel hangs (rev2)

2022-06-30 Thread Patchwork
== Series Details == Series: drm/i915/reset: Handle reset timeouts under unrelated kernel hangs (rev2) URL : https://patchwork.freedesktop.org/series/105748/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11828_full -> Patchwork_105748v2_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Remove flush_scheduled_work() from live_execlists

2022-06-30 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Remove flush_scheduled_work() from live_execlists URL : https://patchwork.freedesktop.org/series/105816/ State : success == Summary == CI Bug Log - changes from CI_DRM_11834 -> Patchwork_105816v1

Re: [Intel-gfx] [PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-30 Thread Zanoni, Paulo R
On Thu, 2022-06-30 at 09:18 -0700, Niranjana Vishwanathapura wrote: > On Wed, Jun 29, 2022 at 11:39:52PM -0700, Zanoni, Paulo R wrote: > > On Wed, 2022-06-29 at 23:08 -0700, Niranjana Vishwanathapura wrote: > > > On Wed, Jun 29, 2022 at 05:33:49PM -0700, Zanoni, Paulo R wrote: > > > > On Sat,

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use short PCH names consistently

2022-06-30 Thread Ville Syrjälä
On Thu, Jun 30, 2022 at 03:50:15PM +, Murthy, Arun R wrote: > > From: Ville Syrjälä > > > > The comments regarding PCH compatibility use long vs. > > short names inconsistently. Just use short names always. > > > > Signed-off-by: Ville Syrjälä > > --- > > drivers/gpu/drm/i915/intel_pch.c

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Nuke PCH_JSP

2022-06-30 Thread Ville Syrjälä
On Thu, Jun 30, 2022 at 03:55:57PM +, Murthy, Arun R wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf Of Ville > > Syrjala > > Sent: Thursday, June 30, 2022 8:36 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [Intel-gfx] [PATCH 3/3] drm/i915: Nuke PCH_JSP > >

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] iosys-map: Add per-word read (rev2)

2022-06-30 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] iosys-map: Add per-word read (rev2) URL : https://patchwork.freedesktop.org/series/105746/ State : success == Summary == CI Bug Log - changes from CI_DRM_11823_full -> Patchwork_105746v2_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,v4,01/13] drm/doc: add rfc section for small BAR uapi

2022-06-30 Thread Patchwork
== Series Details == Series: series starting with [CI,v4,01/13] drm/doc: add rfc section for small BAR uapi URL : https://patchwork.freedesktop.org/series/105787/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11825_full -> Patchwork_105787v1_full

Re: [Intel-gfx] [PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-30 Thread Matthew Auld
On 30/06/2022 16:34, Jason Ekstrand wrote: On Thu, Jun 30, 2022 at 10:14 AM Matthew Auld > wrote: On 30/06/2022 06:11, Jason Ekstrand wrote: > On Sat, Jun 25, 2022 at 8:49 PM Niranjana Vishwanathapura > mailto:niranjana.vishwanathap...@intel.com>

Re: [Intel-gfx] [PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-30 Thread Niranjana Vishwanathapura
On Thu, Jun 30, 2022 at 08:59:09AM +0100, Tvrtko Ursulin wrote: On 30/06/2022 07:08, Niranjana Vishwanathapura wrote: On Wed, Jun 29, 2022 at 05:33:49PM -0700, Zanoni, Paulo R wrote: On Sat, 2022-06-25 at 18:49 -0700, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions v2:

Re: [Intel-gfx] [PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-30 Thread Niranjana Vishwanathapura
On Wed, Jun 29, 2022 at 11:39:52PM -0700, Zanoni, Paulo R wrote: On Wed, 2022-06-29 at 23:08 -0700, Niranjana Vishwanathapura wrote: On Wed, Jun 29, 2022 at 05:33:49PM -0700, Zanoni, Paulo R wrote: > On Sat, 2022-06-25 at 18:49 -0700, Niranjana Vishwanathapura wrote: > > VM_BIND and related

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-30 Thread Mauro Carvalho Chehab
Em Thu, 30 Jun 2022 09:12:41 +0100 Tvrtko Ursulin escreveu: > On 30/06/2022 08:32, Mauro Carvalho Chehab wrote: > > Em Wed, 29 Jun 2022 17:02:59 +0100 > > Tvrtko Ursulin escreveu: > > > >> On 29/06/2022 16:30, Mauro Carvalho Chehab wrote: > >>> On Tue, 28 Jun 2022 16:49:23 +0100 > >>>

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Nuke PCH_JSP

2022-06-30 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Thursday, June 30, 2022 8:36 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 3/3] drm/i915: Nuke PCH_JSP > > From: Ville Syrjälä > > JSP is based on ICP and we don't really need to

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use short PCH names consistently

2022-06-30 Thread Murthy, Arun R
> From: Ville Syrjälä > > The comments regarding PCH compatibility use long vs. > short names inconsistently. Just use short names always. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_pch.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff

Re: [Intel-gfx] [PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-30 Thread Jason Ekstrand
On Sat, Jun 25, 2022 at 8:49 PM Niranjana Vishwanathapura < niranjana.vishwanathap...@intel.com> wrote: > VM_BIND and related uapi definitions > > v2: Reduce the scope to simple Mesa use case. > v3: Expand VM_UNBIND documentation and add > I915_GEM_VM_BIND/UNBIND_FENCE_VALID > and

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,v4,01/13] drm/doc: add rfc section for small BAR uapi

2022-06-30 Thread Patchwork
== Series Details == Series: series starting with [CI,v4,01/13] drm/doc: add rfc section for small BAR uapi URL : https://patchwork.freedesktop.org/series/105787/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11825_full -> Patchwork_105787v1_full

Re: [Intel-gfx] [PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-30 Thread Jason Ekstrand
On Thu, Jun 30, 2022 at 10:14 AM Matthew Auld wrote: > On 30/06/2022 06:11, Jason Ekstrand wrote: > > On Sat, Jun 25, 2022 at 8:49 PM Niranjana Vishwanathapura > > > > wrote: > > > > VM_BIND and related uapi definitions > > > > v2: Reduce the

Re: [Intel-gfx] How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-30 Thread Rodrigo Vivi
On Thu, Jun 30, 2022 at 05:34:22PM +0300, Jani Nikula wrote: > On Thu, 30 Jun 2022, Rodrigo Vivi wrote: > > On Thu, Jun 30, 2022 at 02:09:02PM +0100, Tvrtko Ursulin wrote: > >> > >> On 30/06/2022 12:19, Tetsuo Handa wrote: > >> > On 2022/06/30 19:17, Tvrtko Ursulin wrote: > >> > > Could you give

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen (rev5)

2022-06-30 Thread Robert Beckett
On 30/06/2022 15:52, Hellstrom, Thomas wrote: Hi! On Thu, 2022-06-30 at 15:20 +0100, Robert Beckett wrote: On 29/06/2022 13:51, Robert Beckett wrote: On 28/06/2022 17:22, Robert Beckett wrote: On 28/06/2022 09:46, Tvrtko Ursulin wrote: On 27/06/2022 18:08, Robert Beckett wrote:

Re: [Intel-gfx] [PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-30 Thread Matthew Auld
On 30/06/2022 06:11, Jason Ekstrand wrote: On Sat, Jun 25, 2022 at 8:49 PM Niranjana Vishwanathapura > wrote: VM_BIND and related uapi definitions v2: Reduce the scope to simple Mesa use case. v3: Expand VM_UNBIND documentation and add

[Intel-gfx] [PATCH 3/3] drm/i915: Nuke PCH_JSP

2022-06-30 Thread Ville Syrjala
From: Ville Syrjälä JSP is based on ICP and we don't really need to differentiate between the two. So let's just delcare JSP to be ICP. The only slight change here is for Wa_14011294188 which we used to apply for JSP but now we'll only apply to MCC. This should be fine since the issue being

[Intel-gfx] [PATCH 2/3] drm/i915: Nuke PCH_MCC

2022-06-30 Thread Ville Syrjala
From: Ville Syrjälä MCC is derived from TGP, and we have no real need to differentiate between the two. Thus remove PCH_MCC and just declare it to be PCH_TGP compatible. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-

[Intel-gfx] [PATCH 1/3] drm/i915: Use short PCH names consistently

2022-06-30 Thread Ville Syrjala
From: Ville Syrjälä The comments regarding PCH compatibility use long vs. short names inconsistently. Just use short names always. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_pch.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[Intel-gfx] [PATCH 0/3] drm/i915: PCH type cleanup

2022-06-30 Thread Ville Syrjala
From: Ville Syrjälä Clear out some unnecessary PCH types. Ville Syrjälä (3): drm/i915: Use short PCH names consistently drm/i915: Nuke PCH_MCC drm/i915: Nuke PCH_JSP drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- .../gpu/drm/i915/display/intel_display_power.c | 2 +-

Re: [Intel-gfx] [PATCH v3] drm/i915/dg2: Add performance workaround 18019455067

2022-06-30 Thread Lucas De Marchi
"Add performance tuning for RT_CTRL" would be more accurate as this is handled as a workaround in the spec. On Thu, Jun 30, 2022 at 11:35:08AM +0300, Lionel Landwerlin wrote: The recommended number of stackIDs for Ray Tracing subsystem is 512 rather than 2048 (default HW programming). v2: Move

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/2] iosys-map: Add per-word read (rev2)

2022-06-30 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] iosys-map: Add per-word read (rev2) URL : https://patchwork.freedesktop.org/series/105746/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11823_full -> Patchwork_105746v2_full

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen (rev5)

2022-06-30 Thread Hellstrom, Thomas
Hi! On Thu, 2022-06-30 at 15:20 +0100, Robert Beckett wrote: > > > On 29/06/2022 13:51, Robert Beckett wrote: > > > > > > On 28/06/2022 17:22, Robert Beckett wrote: > > > > > > > > > On 28/06/2022 09:46, Tvrtko Ursulin wrote: > > > > > > > > On 27/06/2022 18:08, Robert Beckett wrote: > > >

Re: [Intel-gfx] [PATCH] drm: i915: fix a possible refcount leak in intel_dp_add_mst_connector()

2022-06-30 Thread Andrzej Hajda
On 24.06.2022 15:04, José Roberto de Souza wrote: From: Hangyu Hua If drm_connector_init fails, intel_connector_free will be called to take care of proper free. So it is necessary to drop the refcount of port before intel_connector_free. Fixes: 091a4f91942a ("drm/i915: Handle drm-layer errors

Re: [Intel-gfx] How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-30 Thread Jani Nikula
On Thu, 30 Jun 2022, Rodrigo Vivi wrote: > On Thu, Jun 30, 2022 at 02:09:02PM +0100, Tvrtko Ursulin wrote: >> >> On 30/06/2022 12:19, Tetsuo Handa wrote: >> > On 2022/06/30 19:17, Tvrtko Ursulin wrote: >> > > Could you give more context on reasoning here please? What is the >> > > difference >>

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: fix subtraction overflow bug

2022-06-30 Thread Andrzej Hajda
On 27.06.2022 21:59, Patchwork wrote: *Patch Details* *Series:* drm/i915/selftests: fix subtraction overflow bug *URL:* https://patchwork.freedesktop.org/series/105597/ *State:*failure *Details:*

Re: [Intel-gfx] [PATCH] drm/i915: Remove __dma_fence_is_chain()

2022-06-30 Thread Andrzej Hajda
On 29.06.2022 01:35, Rob Clark wrote: From: Rob Clark drive-by cleanup Signed-off-by: Rob Clark Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/fbdev: suspend HPD before fbdev unregistration

2022-06-30 Thread Murthy, Arun R
> HPD event after fbdev unregistration can cause registration of deferred fbdev > which will not be unregistered later, causing use-after-free. > To avoid it HPD handling should be suspended before fbdev unregistration. > > It should fix following GPF: > [272.634530] general protection fault,

Re: [Intel-gfx] [PATCH] drm/i915: Drain freed object after suspend display

2022-06-30 Thread Andrzej Hajda
On 29.06.2022 15:47, José Roberto de Souza wrote: Display is turned off by i915_drm_suspend() during the suspend procedure, removing the last reference of some gem objects that were used by display. The issue is that those objects are only actually freed when mm.free_work executed and that can

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen (rev5)

2022-06-30 Thread Robert Beckett
On 29/06/2022 13:51, Robert Beckett wrote: On 28/06/2022 17:22, Robert Beckett wrote: On 28/06/2022 09:46, Tvrtko Ursulin wrote: On 27/06/2022 18:08, Robert Beckett wrote: On 22/06/2022 10:05, Tvrtko Ursulin wrote: On 21/06/2022 20:11, Robert Beckett wrote: On 21/06/2022 18:37,

Re: [Intel-gfx] [PATCH 2/3] drm/i915/ttm: don't overwrite cache_dirty after setting coherency

2022-06-30 Thread Matthew Auld
On Tue, 28 Jun 2022 at 22:11, Robert Beckett wrote: > > > > On 14/06/2022 18:55, Matthew Auld wrote: > > On Tue, 14 Jun 2022 at 02:14, Adrian Larumbe > > wrote: > >> > >> When i915_gem_object_set_cache_level sets the GEM object's cache_dirty to > >> true, in the case of TTM that will sometimes

[Intel-gfx] [PATCH v2 1/2] drm/i915/hpd: postpone HPD cancel work after last user suspension

2022-06-30 Thread Andrzej Hajda
i915->hotplug.dig_port_work can be queued from intel_hpd_irq_handler called by IRQ handler or by intel_hpd_trigger_irq called from dp_mst. Since dp_mst is suspended after irq handler uninstall, a cleaner approach is to cancel hpd work after intel_dp_mst_suspend, otherwise we risk use-after-free.

[Intel-gfx] [PATCH v2 2/2] drm/i915/fbdev: suspend HPD before fbdev unregistration

2022-06-30 Thread Andrzej Hajda
HPD event after fbdev unregistration can cause registration of deferred fbdev which will not be unregistered later, causing use-after-free. To avoid it HPD handling should be suspended before fbdev unregistration. It should fix following GPF: [272.634530] general protection fault, probably for

[Intel-gfx] [PATCH v2 0/2] drm/i915/display: stop HPD workers before display driver unregister

2022-06-30 Thread Andrzej Hajda
Hi Jani, Ville, Arun, This patchset is replacement of patch "drm/i915/display: disable HPD workers before display driver unregister" [1]. Ive decided to split patch into two parts - fbdev and MST, there are different issues. Ive also dropped shutdown path, as it has slightly different

Re: [Intel-gfx] How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-30 Thread Rodrigo Vivi
On Thu, Jun 30, 2022 at 02:09:02PM +0100, Tvrtko Ursulin wrote: > > On 30/06/2022 12:19, Tetsuo Handa wrote: > > On 2022/06/30 19:17, Tvrtko Ursulin wrote: > > > Could you give more context on reasoning here please? What is the > > > difference > > > between using the system_wq and flushing it

Re: [Intel-gfx] How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-30 Thread Tvrtko Ursulin
On 30/06/2022 12:19, Tetsuo Handa wrote: On 2022/06/30 19:17, Tvrtko Ursulin wrote: Could you give more context on reasoning here please? What is the difference between using the system_wq and flushing it from a random context? Or concern is about flushing from specific contexts? Excuse me,

[Intel-gfx] [PATCH] drm/i915/selftests: Remove flush_scheduled_work() from live_execlists

2022-06-30 Thread Tvrtko Ursulin
From: Tvrtko Ursulin There are ongoing efforts to remove usages of flush_scheduled_work() from drivers in order to avoid several cases of potentential problems when flushing is done from certain contexts. Remove the call from the live_execlists selftest. Its purpose was to be thorough and sync

Re: [Intel-gfx] [PATCH v2] drm/i915: Support Async Flip on Linear buffers

2022-06-30 Thread Murthy, Arun R
> On Wed, Jun 01, 2022 at 09:54:11AM +0530, Arun R Murthy wrote: > > Starting from Gen12 Async Flip is supported on linear buffers. > > I was asking for justification for the gen12+ approach. Why not expose it on > earlier platforms? > Even Gen12- platforms do support async on linear, but the

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,v4,01/13] drm/doc: add rfc section for small BAR uapi

2022-06-30 Thread Matthew Auld
On 30/06/2022 10:42, Patchwork wrote: *Patch Details* *Series:* series starting with [CI,v4,01/13] drm/doc: add rfc section for small BAR uapi *URL:* https://patchwork.freedesktop.org/series/105787/ *State:*failure *Details:*

Re: [Intel-gfx] [PATCH v2] drm/i915: Support Async Flip on Linear buffers

2022-06-30 Thread Ville Syrjälä
On Wed, Jun 01, 2022 at 09:54:11AM +0530, Arun R Murthy wrote: > Starting from Gen12 Async Flip is supported on linear buffers. I was asking for justification for the gen12+ approach. Why not expose it on earlier platforms? > This patch enables support for async on linear buffer. > > UseCase:

Re: [Intel-gfx] [PATCH] drm/i915/bios: debug log ddi port info after parsing

2022-06-30 Thread Jani Nikula
On Thu, 23 Jun 2022, Ville Syrjälä wrote: > On Thu, Jun 23, 2022 at 08:04:54PM +0300, Jani Nikula wrote: >> On Thu, 23 Jun 2022, Ville Syrjälä wrote: >> > On Tue, Jun 21, 2022 at 03:37:32PM +0300, Jani Nikula wrote: >> >> The ddc pin and aux channel sanitization may disable DVI/HDMI and DP, >>

Re: [Intel-gfx] [PATCH v2] drm/i915: use DISPLAY_VER() instead of accessing match_info directly

2022-06-30 Thread Jani Nikula
On Tue, 28 Jun 2022, Jani Nikula wrote: > We've just set up device info in i915_driver_create() so we can use > DISPLAY_VER() intead of looking at match_info directly. > > Semantically we want to check the display version instead of the > graphics version, and for the earlier platforms they are

Re: [Intel-gfx] [PATCH v2] drm/i915: Support Async Flip on Linear buffers

2022-06-30 Thread Murthy, Arun R
Gentle reminder! Any review comments? Thanks and Regards, Arun R Murthy > -Original Message- > From: Murthy, Arun R > Sent: Tuesday, June 14, 2022 3:11 PM > To: intel-gfx@lists.freedesktop.org > Cc: ville.syrj...@linux.intel.com; B S, Karthik > Subject: RE: [PATCH

Re: [Intel-gfx] How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-30 Thread Tetsuo Handa
On 2022/06/30 19:17, Tvrtko Ursulin wrote: > Could you give more context on reasoning here please? What is the difference > between using the system_wq and flushing it from a random context? Or concern > is about flushing from specific contexts? Excuse me, but I couldn't catch what you want.

Re: [Intel-gfx] [PATCHv2] drm/i915: free crtc on driver remove

2022-06-30 Thread Murthy, Arun R
> >> >> > intel_crtc is being allocated as part of > >> >> > intel_modeset_init_nogem and not freed as part of driver remove. > This will lead to memory leak. > >> >> > Hence free up the allocated crtc on driver remove as part of > >> >> > intel_modeset_driver_remove_nogem. > >> >> > >> >> No,

Re: [Intel-gfx] [PATCHv2] drm/i915: free crtc on driver remove

2022-06-30 Thread Jani Nikula
On Thu, 30 Jun 2022, "Murthy, Arun R" wrote: >> On Thu, 30 Jun 2022, "Murthy, Arun R" wrote: >> >> > intel_crtc is being allocated as part of intel_modeset_init_nogem >> >> > and not freed as part of driver remove. This will lead to memory leak. >> >> > Hence free up the allocated crtc on driver

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix NPD in PMU during driver teardown

2022-06-30 Thread Patchwork
== Series Details == Series: drm/i915: Fix NPD in PMU during driver teardown URL : https://patchwork.freedesktop.org/series/105790/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11825_full -> Patchwork_105790v1_full

Re: [Intel-gfx] [PATCH] drm/i915: Fix NPD in PMU during driver teardown

2022-06-30 Thread Tvrtko Ursulin
On 29/06/2022 19:46, Stuart Summers wrote: In the driver teardown, we are unregistering the gt prior to unregistering the PMU. This means there is a small window of time in which the application can request metrics from the PMU, some of which are calling into the uapi engines list, while the

Re: [Intel-gfx] How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-30 Thread Tvrtko Ursulin
On 30/06/2022 09:06, Tetsuo Handa wrote: On 2022/06/30 16:46, Tvrtko Ursulin wrote: Hi, On 10/06/2022 15:57, Tetsuo Handa wrote: Hello. Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a macro") explains, we are removing flush_scheduled_work() calls. And now

Re: [Intel-gfx] [PATCHv2] drm/i915: free crtc on driver remove

2022-06-30 Thread Murthy, Arun R
> On Thu, 30 Jun 2022, "Murthy, Arun R" wrote: > >> > intel_crtc is being allocated as part of intel_modeset_init_nogem > >> > and not freed as part of driver remove. This will lead to memory leak. > >> > Hence free up the allocated crtc on driver remove as part of > >> >

Re: [Intel-gfx] [CI RESEND 00/10] drm/edid: expand on struct drm_edid usage

2022-06-30 Thread Jani Nikula
On Wed, 29 Jun 2022, Jani Nikula wrote: > Resend of [1] for CI, also sending without the i915 changes, to be > merged on top. And pushed to drm-misc-next. Thanks for the review! BR, Jani. > > BR, > Jani. > > [1] https://patchwork.freedesktop.org/series/104309/ > > > Jani Nikula (10): >

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,v4,01/13] drm/doc: add rfc section for small BAR uapi

2022-06-30 Thread Patchwork
== Series Details == Series: series starting with [CI,v4,01/13] drm/doc: add rfc section for small BAR uapi URL : https://patchwork.freedesktop.org/series/105787/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11825_full -> Patchwork_105787v1_full

Re: [Intel-gfx] [PATCHv2] drm/i915: free crtc on driver remove

2022-06-30 Thread Jani Nikula
On Thu, 30 Jun 2022, "Murthy, Arun R" wrote: >> > intel_crtc is being allocated as part of intel_modeset_init_nogem and >> > not freed as part of driver remove. This will lead to memory leak. >> > Hence free up the allocated crtc on driver remove as part of >> > intel_modeset_driver_remove_nogem.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg2: Add performance workaround 18019455067 (rev3)

2022-06-30 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add performance workaround 18019455067 (rev3) URL : https://patchwork.freedesktop.org/series/105512/ State : success == Summary == CI Bug Log - changes from CI_DRM_11829 -> Patchwork_105512v3

Re: [Intel-gfx] [PATCHv2] drm/i915: free crtc on driver remove

2022-06-30 Thread Murthy, Arun R
> > intel_crtc is being allocated as part of intel_modeset_init_nogem and > > not freed as part of driver remove. This will lead to memory leak. > > Hence free up the allocated crtc on driver remove as part of > > intel_modeset_driver_remove_nogem. > > No, there's no leak and this is not needed.

Re: [Intel-gfx] [PATCH v2] drm/i915/dg2: Add performance workaround 18019455067

2022-06-30 Thread Lionel Landwerlin
On 30/06/2022 01:16, Matt Roper wrote: On Mon, Jun 27, 2022 at 03:59:28PM +0300, Lionel Landwerlin wrote: The recommended number of stackIDs for Ray Tracing subsystem is 512 rather than 2048 (default HW programming). v2: Move the programming to dg2_ctx_gt_tuning_init() (Lucas) I'm not sure

[Intel-gfx] [PATCH v3] drm/i915/dg2: Add performance workaround 18019455067

2022-06-30 Thread Lionel Landwerlin
The recommended number of stackIDs for Ray Tracing subsystem is 512 rather than 2048 (default HW programming). v2: Move the programming to dg2_ctx_gt_tuning_init() (Lucas) v3: Move programming to general_render_compute_wa_init() (Matt) Signed-off-by: Lionel Landwerlin ---

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-30 Thread Tvrtko Ursulin
On 30/06/2022 08:32, Mauro Carvalho Chehab wrote: Em Wed, 29 Jun 2022 17:02:59 +0100 Tvrtko Ursulin escreveu: On 29/06/2022 16:30, Mauro Carvalho Chehab wrote: On Tue, 28 Jun 2022 16:49:23 +0100 Tvrtko Ursulin wrote: .. which for me means a different patch 1, followed by patch 6

Re: [Intel-gfx] How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-30 Thread Tetsuo Handa
On 2022/06/30 16:46, Tvrtko Ursulin wrote: > > Hi, > > On 10/06/2022 15:57, Tetsuo Handa wrote: >> Hello. >> >> Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using >> a macro") explains, we are removing flush_scheduled_work() calls. And now >> >>

Re: [Intel-gfx] [PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-30 Thread Tvrtko Ursulin
On 30/06/2022 07:08, Niranjana Vishwanathapura wrote: On Wed, Jun 29, 2022 at 05:33:49PM -0700, Zanoni, Paulo R wrote: On Sat, 2022-06-25 at 18:49 -0700, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions v2: Reduce the scope to simple Mesa use case. v3: Expand VM_UNBIND

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: free crtc on driver remove (rev2)

2022-06-30 Thread Patchwork
== Series Details == Series: drm/i915: free crtc on driver remove (rev2) URL : https://patchwork.freedesktop.org/series/105809/ State : success == Summary == CI Bug Log - changes from CI_DRM_11828 -> Patchwork_105809v2 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Drain freed object after suspend display (rev3)

2022-06-30 Thread Patchwork
== Series Details == Series: drm/i915: Drain freed object after suspend display (rev3) URL : https://patchwork.freedesktop.org/series/105779/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11825_full -> Patchwork_105779v3_full

Re: [Intel-gfx] How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-30 Thread Tvrtko Ursulin
Hi, On 10/06/2022 15:57, Tetsuo Handa wrote: Hello. Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a macro") explains, we are removing flush_scheduled_work() calls. And now drivers/gpu/drm/i915/display/intel_display.c

Re: [Intel-gfx] [PATCHv2] drm/i915: free crtc on driver remove

2022-06-30 Thread Jani Nikula
On Thu, 30 Jun 2022, Arun R Murthy wrote: > intel_crtc is being allocated as part of intel_modeset_init_nogem > and not freed as part of driver remove. This will lead to memory > leak. Hence free up the allocated crtc on driver remove as part of > intel_modeset_driver_remove_nogem. No, there's

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-30 Thread Mauro Carvalho Chehab
Em Wed, 29 Jun 2022 17:02:59 +0100 Tvrtko Ursulin escreveu: > On 29/06/2022 16:30, Mauro Carvalho Chehab wrote: > > On Tue, 28 Jun 2022 16:49:23 +0100 > > Tvrtko Ursulin wrote: > > > >> .. which for me means a different patch 1, followed by patch 6 (moved > >> to be patch 2) would be ideal

[Intel-gfx] [PULL] drm-misc-fixes

2022-06-30 Thread Maxime Ripard
Hi Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2022-06-30: A NULL pointer dereference fix for vc4, and 3 patches to improve the sysfb device behaviour when removing conflicting framebuffers The following changes since commit 85016f66af8506cb601fd4f4fde23ed327a266be: drm/sun4i:

[Intel-gfx] [PULL] drm-misc-next

2022-06-30 Thread Thomas Zimmermann
Hi Dave and Daniel, this is the drm-misc-next PR for this week. Best regards Thomas drm-misc-next-2022-06-30: drm-misc-next for v5.20: UAPI Changes: * fourcc: Update documentation Cross-subsystem Changes: * iosys-map: Rework iosys_map_{rd,wr} for improved performance * vfio: Use

  1   2   >