Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/2] drm/i915/gt: Add dedicated function for non-ctx register tuning settings

2022-08-16 Thread Matt Roper
On Tue, Aug 16, 2022 at 11:57:37PM +, Patchwork wrote: > == Series Details == > > Series: series starting with [v2,1/2] drm/i915/gt: Add dedicated function for > non-ctx register tuning settings > URL : https://patchwork.freedesktop.org/series/107342/ > State : success > > == Summary == >

Re: [Intel-gfx] [RFC 1/1] drm/i915/dgfx: Avoid parent bridge rpm on mmap mappings

2022-08-16 Thread Gupta, Anshuman
> -Original Message- > From: Vivi, Rodrigo > Sent: Tuesday, August 9, 2022 8:36 PM > To: Gupta, Anshuman > Cc: intel-gfx@lists.freedesktop.org; dan...@ffwll.ch; Wilson, Chris P > ; dri-de...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [RFC 1/1] drm/i915/dgfx: Avoid parent bridge

Re: [Intel-gfx] [PATCH 00/39] drm/i915: add display sub-struct to drm_i915_private

2022-08-16 Thread Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:11PM +0300, Jani Nikula wrote: Add display sub-struct to drm_i915_private, and start moving display related members there. This doesn't help with build dependencies yet, but adds a lot of clarity in organizing the display data, and who accesses display data and

Re: [Intel-gfx] [PATCH 28/39] drm/i915: move and group power related members under display.power

2022-08-16 Thread Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:39PM +0300, Jani Nikula wrote: Move display related members under drm_i915_private display sub-struct. Arguably chv_phy_control and chv_phy_assert could be placed in a phy substruct, but they are only used in the power code. Signed-off-by: Jani Nikula ---

Re: [Intel-gfx] [PATCH 24/39] drm/i915: move mipi_mmio_base to display.dsi

2022-08-16 Thread Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:35PM +0300, Jani Nikula wrote: Move display related members under drm_i915_private display sub-struct. Prefer adding anonymous sub-structs even for single members that aren't our own structs. Abstract mmio base member access in register definitions in a macro.

Re: [Intel-gfx] [PATCH 23/39] drm/i915: move backlight to display.backlight

2022-08-16 Thread Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:34PM +0300, Jani Nikula wrote: Move display related members under drm_i915_private display sub-struct. Prefer adding anonymous sub-structs even for single members that aren't our own structs. Signed-off-by: Jani Nikula For this and all previous patches (except

Re: [Intel-gfx] [PATCH 17/39] drm/i915: move hotplug to display.hotplug

2022-08-16 Thread Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:28PM +0300, Jani Nikula wrote: Move display related members under drm_i915_private display sub-struct. missed the mention that i915_hotplug is now intel_hotplug. For this and all previous patches (except patch 5, for clock_gating_funcs): Reviewed-by: Lucas De

Re: [Intel-gfx] [PATCH 13/39] drm/i915: move dpll under display.dpll

2022-08-16 Thread Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:24PM +0300, Jani Nikula wrote: Move display related members under drm_i915_private display sub-struct. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/icl_dsi.c| 12 +- drivers/gpu/drm/i915/display/intel_ddi.c | 24 ++--

[Intel-gfx] ✓ Fi.CI.IGT: success for Delay disabling scheduling on a context

2022-08-16 Thread Patchwork
== Series Details == Series: Delay disabling scheduling on a context URL : https://patchwork.freedesktop.org/series/107345/ State : success == Summary == CI Bug Log - changes from CI_DRM_11990_full -> Patchwork_107345v1_full Summary

Re: [Intel-gfx] [PATCH 10/39] drm/i915: move and group pps members under display.pps

2022-08-16 Thread Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:21PM +0300, Jani Nikula wrote: Move display related members under drm_i915_private display sub-struct. Signed-off-by: Jani Nikula Reviewed-by: Lucas De Marchi Lucas De Marchi

Re: [Intel-gfx] [PATCH 09/39] drm/i915: move and group gmbus members under display.gmbus

2022-08-16 Thread Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:20PM +0300, Jani Nikula wrote: Move display related members under drm_i915_private display sub-struct. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c| 6 +-- .../gpu/drm/i915/display/intel_display_core.h | 23 ++

Re: [Intel-gfx] [PATCH 08/39] drm/i915: move color_funcs to display.funcs

2022-08-16 Thread Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:19PM +0300, Jani Nikula wrote: Move display related members under drm_i915_private display sub-struct. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_color.c| 34 +-- .../gpu/drm/i915/display/intel_display_core.h | 4 +++

Re: [Intel-gfx] [PATCH 07/39] drm/i915: move fdi_funcs to display.funcs

2022-08-16 Thread Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:18PM +0300, Jani Nikula wrote: Move display related members under drm_i915_private display sub-struct. Signed-off-by: Jani Nikula Reviewed-by: Lucas De Marchi Lucas De Marchi

Re: [Intel-gfx] [PATCH 06/39] drm/i915: move wm_disp funcs to display.funcs

2022-08-16 Thread Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:17PM +0300, Jani Nikula wrote: Move display related members under drm_i915_private display sub-struct. Rename struct drm_i915_wm_disp_funcs to intel_wm_funcs while at it. Signed-off-by: Jani Nikula Reviewed-by: Lucas De Marchi Lucas De Marchi

Re: [Intel-gfx] [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Kai-Heng Feng
On Wed, Aug 17, 2022 at 9:49 AM Karol Herbst wrote: > > On Wed, Aug 17, 2022 at 3:18 AM Kai-Heng Feng > wrote: > > > > On Wed, Aug 17, 2022 at 2:50 AM Karol Herbst wrote: > > > > > > On Tue, Aug 16, 2022 at 4:53 AM Kai-Heng Feng > > > wrote: > > > > > > > > On mobile workstations like HP ZBook

[Intel-gfx] ✓ Fi.CI.BAT: success for Delay disabling scheduling on a context

2022-08-16 Thread Patchwork
== Series Details == Series: Delay disabling scheduling on a context URL : https://patchwork.freedesktop.org/series/107345/ State : success == Summary == CI Bug Log - changes from CI_DRM_11990 -> Patchwork_107345v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Delay disabling scheduling on a context

2022-08-16 Thread Patchwork
== Series Details == Series: Delay disabling scheduling on a context URL : https://patchwork.freedesktop.org/series/107345/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH 0/2] Delay disabling scheduling on a context

2022-08-16 Thread Alan Previn
This is a revival of the same series posted by Matthew Brost back in October 2021 (https://patchwork.freedesktop.org/series/96167/). Additional real world measured metrics is included this time around that has proven the effectiveness of this series. This series adds a delay before disabling

[Intel-gfx] [PATCH 1/2] drm/i915/selftests: Use correct selfest calls for live tests

2022-08-16 Thread Alan Previn
From: Matthew Brost This will help in an upcoming patch where the live selftest wrappers are extended to do more. Signed-off-by: Matthew Brost Signed-off-by: Alan Previn Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c | 2 +-

[Intel-gfx] [PATCH 2/2] drm/i915/guc: Add delay to disable scheduling after pin count goes to zero

2022-08-16 Thread Alan Previn
From: Matthew Brost Add a delay, configurable via debugfs (default 34ms), to disable scheduling of a context after the pin count goes to zero. Disable scheduling is a costly operation as it requires synchronizing with the GuC. So the idea is that a delay allows the user to resubmit something

Re: [Intel-gfx] [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Karol Herbst
On Wed, Aug 17, 2022 at 3:18 AM Kai-Heng Feng wrote: > > On Wed, Aug 17, 2022 at 2:50 AM Karol Herbst wrote: > > > > On Tue, Aug 16, 2022 at 4:53 AM Kai-Heng Feng > > wrote: > > > > > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > > > dGFX so external monitors are

Re: [Intel-gfx] [PATCH 05/39] drm/i915: move clock_gating_funcs to display.funcs

2022-08-16 Thread Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:16PM +0300, Jani Nikula wrote: Move display related members under drm_i915_private display sub-struct. Rename struct i915_clock_gating_funcs to intel_clock_gating_funcs while at it. Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_display_core.h | 4

Re: [Intel-gfx] [PATCH 04/39] drm/i915: move hotplug_funcs to display.funcs

2022-08-16 Thread Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:15PM +0300, Jani Nikula wrote: Move display related members under drm_i915_private display sub-struct. Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_display_core.h | 4 drivers/gpu/drm/i915/i915_drv.h | 4

Re: [Intel-gfx] [PATCH 01/39] drm/i915: add display sub-struct to drm_i915_private

2022-08-16 Thread Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:12PM +0300, Jani Nikula wrote: In another long-overdue cleanup, add a display sub-struct to drm_i915_private, and start moving display related members there. Start with display funcs that need a rename anyway to not collide with the new display member. Add a new

Re: [Intel-gfx] [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Kai-Heng Feng
On Wed, Aug 17, 2022 at 2:50 AM Karol Herbst wrote: > > On Tue, Aug 16, 2022 at 4:53 AM Kai-Heng Feng > wrote: > > > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > > dGFX so external monitors are routed to dGFX, and more monitors can be > > supported as result. > >

Re: [Intel-gfx] [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Kai-Heng Feng
On Wed, Aug 17, 2022 at 2:36 AM Lyude Paul wrote: > > On Tue, 2022-08-16 at 14:24 -0400, Lyude Paul wrote: > > On Tue, 2022-08-16 at 19:29 +0800, Kai-Heng Feng wrote: > > > On Tue, Aug 16, 2022 at 4:06 PM Jani Nikula > > > wrote: > > > > > > > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > >

Re: [Intel-gfx] [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Kai-Heng Feng
On Wed, Aug 17, 2022 at 2:24 AM Lyude Paul wrote: > > On Tue, 2022-08-16 at 19:29 +0800, Kai-Heng Feng wrote: > > On Tue, Aug 16, 2022 at 4:06 PM Jani Nikula > > wrote: > > > > > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Add delay to disable scheduling after pin count goes to zero

2022-08-16 Thread John Harrison
On 8/16/2022 16:55, Teres Alexis, Alan Previn wrote: On Tue, 2022-08-16 at 15:45 -0700, Harrison, John C wrote: On 8/15/2022 19:17, Alan Previn wrote: From: Matthew Brost Add a delay, configurable via debugfs (default 34ms), to disable (default is 3/4) of the guc_ids. are in use. my bad -

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Add delay to disable scheduling after pin count goes to zero

2022-08-16 Thread Teres Alexis, Alan Previn
On Tue, 2022-08-16 at 15:45 -0700, Harrison, John C wrote: > On 8/15/2022 19:17, Alan Previn wrote: > > From: Matthew Brost > > > > Add a delay, configurable via debugfs (default 34ms), to disable > > (default is 3/4) of the guc_ids. > are in use. > my bad - got clipped - will fix. > > ---

Re: [Intel-gfx] [PATCH] drm/i915/guc: skip scrub_ctbs selftest if reset is disabled

2022-08-16 Thread John Harrison
On 7/8/2022 15:41, Daniele Ceraolo Spurio wrote: The test needs GT reset to trigger the scrubbing logic, so we can only run it when reset is enabled. Signed-off-by: Daniele Ceraolo Spurio Cc: John Harrison Cc: Matthew Brost Reviewed-by: John Harrison ---

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Add delay to disable scheduling after pin count goes to zero

2022-08-16 Thread John Harrison
On 8/15/2022 19:17, Alan Previn wrote: From: Matthew Brost Add a delay, configurable via debugfs (default 34ms), to disable scheduling of a context after the pin count goes to zero. Disable scheduling is a costly operation as it requires synchronizing with the GuC. So the idea is that a delay

Re: [Intel-gfx] [PATCH 1/2] drm/i915/selftests: Use correct selfest calls for live tests

2022-08-16 Thread John Harrison
On 8/15/2022 19:17, Alan Previn wrote: From: Matthew Brost This will help in an upcoming patch where the live selftest wrappers are extended to do more. Signed-off-by: Matthew Brost Signed-off-by: Alan Previn Reviewed-by: John Harrison ---

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/gt: Add dedicated function for non-ctx register tuning settings

2022-08-16 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/gt: Add dedicated function for non-ctx register tuning settings URL : https://patchwork.freedesktop.org/series/107342/ State : success == Summary == CI Bug Log - changes from CI_DRM_11990 -> Patchwork_107342v1

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dsi: fix DSI DCS backlight port handling (rev2)

2022-08-16 Thread Patchwork
== Series Details == Series: drm/i915/dsi: fix DSI DCS backlight port handling (rev2) URL : https://patchwork.freedesktop.org/series/107334/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11989_full -> Patchwork_107334v2_full

[Intel-gfx] [PATCH v2 1/2] drm/i915/gt: Add dedicated function for non-ctx register tuning settings

2022-08-16 Thread Matt Roper
The bspec performance tuning section gives recommended settings that the driver should program for various MMIO registers. Although these settings aren't "workarounds" we use the workaround infrastructure to do this programming to make sure it is handled at the appropriate places and doesn't

[Intel-gfx] [PATCH v2 2/2] drm/i915/dg2: Add additional tuning settings

2022-08-16 Thread Matt Roper
Some additional MMIO tuning settings have appeared in the bspec's performance tuning guide section. One of the tuning settings here is also documented as formal workaround Wa_22012654132 for some steppings of DG2. However the tuning setting applies to all DG2 variants and steppings, making it a

[Intel-gfx] ✗ Fi.CI.BAT: failure for Drop version numbers from firmware files

2022-08-16 Thread Patchwork
== Series Details == Series: Drop version numbers from firmware files URL : https://patchwork.freedesktop.org/series/107340/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11990 -> Patchwork_107340v1 Summary ---

Re: [Intel-gfx] [PATCH 02/15] mei: add support to GSC extended header

2022-08-16 Thread Winkler, Tomas
> -Original Message- > From: Teres Alexis, Alan Previn > Sent: Thursday, August 04, 2022 01:08 > To: Ceraolo Spurio, Daniele ; intel- > g...@lists.freedesktop.org > Cc: Winkler, Tomas ; Lubart, Vitaly > > Subject: Re: [PATCH 02/15] mei: add support to GSC extended header > > I was

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Drop version numbers from firmware files

2022-08-16 Thread Patchwork
== Series Details == Series: Drop version numbers from firmware files URL : https://patchwork.freedesktop.org/series/107340/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Drop version numbers from firmware files

2022-08-16 Thread Patchwork
== Series Details == Series: Drop version numbers from firmware files URL : https://patchwork.freedesktop.org/series/107340/ State : warning == Summary == Error: dim checkpatch failed 2b35c15d2651 drm/i915/uc: Support for version reduced and multiple firmware files -:152:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix warning callstack for imbalance wakeref

2022-08-16 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix warning callstack for imbalance wakeref URL : https://patchwork.freedesktop.org/series/107211/ State : success == Summary == CI Bug Log - changes from CI_DRM_11986_full -> Patchwork_107211v1_full

[Intel-gfx] [PATCH 0/2] Drop version numbers from firmware files

2022-08-16 Thread John . C . Harrison
From: John Harrison Upstream direction is to include the bare minimum of version numbers in firmware files and to replace them in the repo rather than accumulating them. For HuC, that means going completely versionless. For GuC, the major version needs to be kept as that indicates a break in

[Intel-gfx] [PATCH 2/2] drm/i915/uc: Enable version reduced firmware files for newest platforms

2022-08-16 Thread John . C . Harrison
From: John Harrison Going forwards, the intention is for GuC firmware files to be named for their major version only and HuC firmware files to have no version number in the name at all. This patch adds those entries for DG2 and ADL-P/S. Signed-off-by: John Harrison ---

[Intel-gfx] [PATCH 1/2] drm/i915/uc: Support for version reduced and multiple firmware files

2022-08-16 Thread John . C . Harrison
From: John Harrison There was a misunderstanding in how firmware file compatibility should be managed within i915. This has been clarified as: i915 must support all existing firmware releases forever new minor firmware releases should replace prior versions only backwards compatibility

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Fix warning callstack for imbalance wakeref

2022-08-16 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix warning callstack for imbalance wakeref URL : https://patchwork.freedesktop.org/series/107211/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11986_full -> Patchwork_107211v1_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm: Fix all occurences of the "the the" typo

2022-08-16 Thread Patchwork
== Series Details == Series: drm: Fix all occurences of the "the the" typo URL : https://patchwork.freedesktop.org/series/107331/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11989_full -> Patchwork_107331v1_full Summary

Re: [Intel-gfx] [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Karol Herbst
On Tue, Aug 16, 2022 at 4:53 AM Kai-Heng Feng wrote: > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > dGFX so external monitors are routed to dGFX, and more monitors can be > supported as result. > > To switch the DP-IN to dGFX, the driver needs to invoke _DSM

Re: [Intel-gfx] [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Lyude Paul
On Tue, 2022-08-16 at 14:24 -0400, Lyude Paul wrote: > On Tue, 2022-08-16 at 19:29 +0800, Kai-Heng Feng wrote: > > On Tue, Aug 16, 2022 at 4:06 PM Jani Nikula > > wrote: > > > > > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can

Re: [Intel-gfx] [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Lyude Paul
On Tue, 2022-08-16 at 19:29 +0800, Kai-Heng Feng wrote: > On Tue, Aug 16, 2022 at 4:06 PM Jani Nikula > wrote: > > > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > > > dGFX so external monitors are routed to dGFX,

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: fix DSI DCS backlight port handling (rev2)

2022-08-16 Thread Patchwork
== Series Details == Series: drm/i915/dsi: fix DSI DCS backlight port handling (rev2) URL : https://patchwork.freedesktop.org/series/107334/ State : success == Summary == CI Bug Log - changes from CI_DRM_11989 -> Patchwork_107334v2 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: fix DSI DCS backlight port handling (rev2)

2022-08-16 Thread Patchwork
== Series Details == Series: drm/i915/dsi: fix DSI DCS backlight port handling (rev2) URL : https://patchwork.freedesktop.org/series/107334/ State : warning == Summary == Error: dim checkpatch failed e67b2b46ff9e drm/i915/dsi: filter invalid backlight and CABC ports -:21: WARNING:LONG_LINE:

[Intel-gfx] ✓ Fi.CI.IGT: success for i915-pmu: Add extra check engine

2022-08-16 Thread Patchwork
== Series Details == Series: i915-pmu: Add extra check engine URL : https://patchwork.freedesktop.org/series/107328/ State : success == Summary == CI Bug Log - changes from CI_DRM_11989_full -> Patchwork_107328v1_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Fix all occurences of the "the the" typo

2022-08-16 Thread Patchwork
== Series Details == Series: drm: Fix all occurences of the "the the" typo URL : https://patchwork.freedesktop.org/series/107331/ State : success == Summary == CI Bug Log - changes from CI_DRM_11989 -> Patchwork_107331v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Fix all occurences of the "the the" typo

2022-08-16 Thread Patchwork
== Series Details == Series: drm: Fix all occurences of the "the the" typo URL : https://patchwork.freedesktop.org/series/107331/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix all occurences of the "the the" typo

2022-08-16 Thread Patchwork
== Series Details == Series: drm/i915: Fix all occurences of the "the the" typo URL : https://patchwork.freedesktop.org/series/107329/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11989 -> Patchwork_107329v1 Summary

[Intel-gfx] [RESEND 3/3] drm/i915/dsi: use VBT backlight and CABC port definitions directly

2022-08-16 Thread Jani Nikula
Drop the intermediate values stored in intel_dsi and use the VBT values directly, now that they're conveniently stored in panel->vbt. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/icl_dsi.c | 4 drivers/gpu/drm/i915/display/intel_dsi.h | 3 ---

[Intel-gfx] [RESEND 0/3] drm/i915/dsi: fix DSI DCS backlight port handling

2022-08-16 Thread Jani Nikula
Hopefully fix a null pointer dereference in DSI DCS backlight handling. Resend because patchwork got confused with the first submission, for some reason. Jani Nikula (3): drm/i915/dsi: filter invalid backlight and CABC ports drm/i915/dsi: fix dual-link DSI backlight and CABC ports for

[Intel-gfx] [RESEND 2/3] drm/i915/dsi: fix dual-link DSI backlight and CABC ports for display 11+

2022-08-16 Thread Jani Nikula
The VBT dual-link DSI backlight and CABC still use ports A and C, both in Bspec and code, while display 11+ DSI only supports ports A and B. Assume port C actually means port B for display 11+ when parsing VBT. Bspec: 20154 Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6476 Cc:

[Intel-gfx] [RESEND 1/3] drm/i915/dsi: filter invalid backlight and CABC ports

2022-08-16 Thread Jani Nikula
Avoid using ports that aren't initialized in case the VBT backlight or CABC ports have invalid values. This fixes a NULL pointer dereference of intel_dsi->dsi_hosts[port] in such cases. Cc: sta...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/icl_dsi.c | 7 +++

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix all occurences of the "the the" typo

2022-08-16 Thread Patchwork
== Series Details == Series: drm/i915: Fix all occurences of the "the the" typo URL : https://patchwork.freedesktop.org/series/107329/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

[Intel-gfx] [PATCH 1/3] drm/i915/dsi: filter invalid backlight and CABC ports

2022-08-16 Thread Jani Nikula
Avoid using ports that aren't initialized in case the VBT backlight or CABC ports have invalid values. This fixes a NULL pointer dereference of intel_dsi->dsi_hosts[port] in such cases. Cc: sta...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/icl_dsi.c | 7 +++

[Intel-gfx] [PATCH 0/3] drm/i915/dsi: fix DSI DCS backlight port handling

2022-08-16 Thread Jani Nikula
Hopefully fix a null pointer dereference in DSI DCS backlight handling. Jani Nikula (3): drm/i915/dsi: filter invalid backlight and CABC ports drm/i915/dsi: fix dual-link DSI backlight and CABC ports for display 11+ drm/i915/dsi: use VBT backlight and CABC port definitions directly

[Intel-gfx] ✓ Fi.CI.BAT: success for i915-pmu: Add extra check engine

2022-08-16 Thread Patchwork
== Series Details == Series: i915-pmu: Add extra check engine URL : https://patchwork.freedesktop.org/series/107328/ State : success == Summary == CI Bug Log - changes from CI_DRM_11989 -> Patchwork_107328v1 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915-pmu: Add extra check engine

2022-08-16 Thread Patchwork
== Series Details == Series: i915-pmu: Add extra check engine URL : https://patchwork.freedesktop.org/series/107328/ State : warning == Summary == Error: dim checkpatch failed 8b3861fad72f i915-pmu: Add extra check engine -:6: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit

[Intel-gfx] [PATCH] drm: Fix all occurences of the "the the" typo

2022-08-16 Thread Bo Liu
There are double "the" in messages in file drm_dp_helper.c, i915_irq.c and panel-novatek-nt35510.c, fix it. Signed-off-by: Bo Liu --- drivers/gpu/drm/display/drm_dp_helper.c | 2 +- drivers/gpu/drm/i915/i915_irq.c | 2 +- drivers/gpu/drm/panel/panel-novatek-nt35510.c | 2 +-

[Intel-gfx] [PATCH] drm/i915: Fix all occurences of the "the the" typo

2022-08-16 Thread Bo Liu
There is an unexpected word "the" in the file i915_irq.c, fix it. Signed-off-by: Bo Liu --- drivers/gpu/drm/i915/i915_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 73cebc6aa650..783a6ca41a61

[Intel-gfx] [PATCH] i915-pmu: Add extra check engine

2022-08-16 Thread Denis Arefev
Return value of a function 'intel_engine_lookup_user' is dereferenced at i915_pmu.c:708 without checking for null, but it is usually checked for this function Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Denis Arefev --- drivers/gpu/drm/i915/i915_pmu.c | 6

Re: [Intel-gfx] [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Kai-Heng Feng
On Tue, Aug 16, 2022 at 4:06 PM Jani Nikula wrote: > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > > dGFX so external monitors are routed to dGFX, and more monitors can be > > supported as result. > > > > To switch the

Re: [Intel-gfx] [PATCH 3/3] i915-pmu: Add extra check NULL

2022-08-16 Thread Jani Nikula
On Tue, 16 Aug 2022, Denis Arefev wrote: > Found by Linux Verification Center (linuxtesting.org) with SVACE. The subject prefix should be something along the lines of "drm/i915/pmu". The subject is misleading; there are no functional changes here, just whitespace changes. I'm guessing you

[Intel-gfx] [PULL] drm-misc-fixes

2022-08-16 Thread Maxime Ripard
Hi Dave, Daniel, Here's the few patches that got stuck in drm-misc-fixes Maxime drm-misc-fixes-2022-08-16: One patch for imx/dcss to get rid of a warning message, one off-by-one fix and GA103 support for nouveau, a refcounting fix for meson, a NULL pointer dereference fix for ttm, a error check

Re: [Intel-gfx] [PATCH v6 5/8] drm/i915: Check for integer truncation on the configuration of ttm place

2022-08-16 Thread Gwan-gyeong Mun
On 8/15/22 5:03 PM, Jani Nikula wrote: On Sat, 13 Aug 2022, Gwan-gyeong Mun wrote: There is an impedance mismatch between the first/last valid page frame number of ttm place in unsigned and our memory/page accounting in unsigned long. As the object size is under the control of userspace, we

[Intel-gfx] [PATCH v7 5/8] drm/i915: Check for integer truncation on the configuration of ttm place

2022-08-16 Thread Gwan-gyeong Mun
There is an impedance mismatch between the first/last valid page frame number of ttm place in unsigned and our memory/page accounting in unsigned long. As the object size is under the control of userspace, we have to be prudent and catch the conversion errors. To catch the implicit truncation as

[Intel-gfx] [PATCH v7 0/8] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-08-16 Thread Gwan-gyeong Mun
This patch series fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation, etc. We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead

[Intel-gfx] [PATCH v7 4/8] drm/i915: Check for integer truncation on scatterlist creation

2022-08-16 Thread Gwan-gyeong Mun
From: Chris Wilson There is an impedance mismatch between the scatterlist API using unsigned int and our memory/page accounting in unsigned long. That is we may try to create a scatterlist for a large object that overflows returning a small table into which we try to fit very many pages. As the

[Intel-gfx] [PATCH v7 7/8] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

2022-08-16 Thread Gwan-gyeong Mun
The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big to add vma. The direct function that returns -ENOSPC is drm_mm_insert_node_in_range(). To handle the same error as other code returning -E2BIG when the size is too large, it converts return value to -E2BIG.

[Intel-gfx] [PATCH v7 8/8] drm/i915: Remove truncation warning for large objects

2022-08-16 Thread Gwan-gyeong Mun
From: Chris Wilson Having addressed the issues surrounding incorrect types for local variables and potential integer truncation in using the scatterlist API, we have closed all the loop holes we had previously identified with dangerously large object creation. As such, we can eliminate the

[Intel-gfx] [PATCH v7 2/8] util_macros: Add exact_type macro to catch type mis-match while compiling

2022-08-16 Thread Gwan-gyeong Mun
It adds exact_type and exactly_pgoff_t macro to catch type mis-match while compiling. The existing typecheck() macro outputs build warnings, but the newly added exact_type() macro uses the BUILD_BUG_ON() macro to generate a build break when the types are different and can be used to detect

[Intel-gfx] [PATCH v7 3/8] drm/i915/gem: Typecheck page lookups

2022-08-16 Thread Gwan-gyeong Mun
From: Chris Wilson We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead of a more suitable long. Be pedantic and add integer typechecking to the lookup so that we can be sure that we are safe.

[Intel-gfx] [PATCH v7 6/8] drm/i915: Check if the size is too big while creating shmem file

2022-08-16 Thread Gwan-gyeong Mun
The __shmem_file_setup() function returns -EINVAL if size is greater than MAX_LFS_FILESIZE. To handle the same error as other code that returns -E2BIG when the size is too large, it add a code that returns -E2BIG when the size is larger than the size that can be handled. v4: If BITS_PER_LONG is

Re: [Intel-gfx] [PATCH 12/39] drm/i915: move and split audio under display.audio and display.funcs

2022-08-16 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Tuesday, August 16, 2022 1:32 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Cc: De Marchi, Lucas > Subject: RE: [Intel-gfx] [PATCH 12/39] drm/i915: move and split audio under > display.audio and display.funcs > > On

Re: [Intel-gfx] [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Jani Nikula
On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > dGFX so external monitors are routed to dGFX, and more monitors can be > supported as result. > > To switch the DP-IN to dGFX, the driver needs to invoke _DSM function 20 > on

Re: [Intel-gfx] [PATCH i-g-t v2] tests/gem_lmem_swapping: add some coverage for big objects

2022-08-16 Thread Das, Nirmoy
LGTM Reviewed-by: Nirmoy Das On 8/9/2022 12:26 PM, Matthew Auld wrote: Everything we are testing here unfortunately fits within one packet (8M) which means we have zero coverage when we need to split the copy over multiple packets (including the aux CCS state). v2: - Add some coverage for

Re: [Intel-gfx] [PATCH 09/39] drm/i915: move and group gmbus members under display.gmbus

2022-08-16 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Tuesday, August 16, 2022 1:21 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Cc: De Marchi, Lucas > Subject: RE: [Intel-gfx] [PATCH 09/39] drm/i915: move and group gmbus > members under display.gmbus > > On Tue, 16 Aug

Re: [Intel-gfx] [PATCH 09/39] drm/i915: move and group gmbus members under display.gmbus

2022-08-16 Thread Jani Nikula
On Tue, 16 Aug 2022, "Murthy, Arun R" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Friday, August 12, 2022 12:26 PM >> To: Murthy, Arun R ; intel- >> g...@lists.freedesktop.org >> Cc: De Marchi, Lucas >> Subject: RE: [Intel-gfx] [PATCH 09/39] drm/i915: move and group

Re: [Intel-gfx] [PATCH 01/39] drm/i915: add display sub-struct to drm_i915_private

2022-08-16 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Tuesday, August 16, 2022 1:07 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Cc: De Marchi, Lucas > Subject: RE: [Intel-gfx] [PATCH 01/39] drm/i915: add display sub-struct to > drm_i915_private > > On Tue, 16 Aug 2022,

Re: [Intel-gfx] [PATCH 01/39] drm/i915: add display sub-struct to drm_i915_private

2022-08-16 Thread Jani Nikula
On Tue, 16 Aug 2022, "Murthy, Arun R" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Friday, August 12, 2022 12:10 PM >> To: Murthy, Arun R ; intel- >> g...@lists.freedesktop.org >> Cc: De Marchi, Lucas >> Subject: RE: [Intel-gfx] [PATCH 01/39] drm/i915: add display

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc/slpc: Allow SLPC to use efficient frequency (rev3)

2022-08-16 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Allow SLPC to use efficient frequency (rev3) URL : https://patchwork.freedesktop.org/series/107101/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11989 -> Patchwork_107101v3

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc/slpc: Allow SLPC to use efficient frequency (rev3)

2022-08-16 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Allow SLPC to use efficient frequency (rev3) URL : https://patchwork.freedesktop.org/series/107101/ State : warning == Summary == Error: dim checkpatch failed f70a4c92db9f drm/i915/guc/slpc: Allow SLPC to use efficient frequency -:45: