[Intel-gfx] ✓ Fi.CI.IGT: success for kvm/vfio: fix potential deadlock on vfio group lock

2023-01-09 Thread Patchwork
== Series Details == Series: kvm/vfio: fix potential deadlock on vfio group lock URL : https://patchwork.freedesktop.org/series/112568/ State : success == Summary == CI Bug Log - changes from CI_DRM_12560_full -> Patchwork_112568v1_full

Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2023-01-09 Thread Deepak R Varma
On Mon, Jan 09, 2023 at 02:06:13PM -0500, Rodrigo Vivi wrote: > On Sun, Jan 08, 2023 at 01:33:41AM +0530, Deepak R Varma wrote: > > On Thu, Jan 05, 2023 at 09:13:35AM +0100, Julia Lawall wrote: > > > > Hi Julia, thanks for helping here. > > > > > > > > So, my question is why this > > > > > > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable HDCP2.x via GSC CS (rev6)

2023-01-09 Thread Patchwork
== Series Details == Series: Enable HDCP2.x via GSC CS (rev6) URL : https://patchwork.freedesktop.org/series/111876/ State : success == Summary == CI Bug Log - changes from CI_DRM_12561 -> Patchwork_111876v6 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable HDCP2.x via GSC CS (rev6)

2023-01-09 Thread Patchwork
== Series Details == Series: Enable HDCP2.x via GSC CS (rev6) URL : https://patchwork.freedesktop.org/series/111876/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v6 6/6] drm/i915/mtl: Add HDCP GSC interface

2023-01-09 Thread Suraj Kandpal
MTL uses GSC command streamer i.e gsc cs to send HDCP/PXP commands to GSC f/w. It requires to keep hdcp display driver agnostic to content protection f/w (ME/GSC fw) in the form of i915_hdcp_fw_ops generic ops. Adding HDCP GSC CS interface by leveraging the i915_hdcp_fw_ops generic ops instead of

[Intel-gfx] [PATCH v6 5/6] drm/i915/mtl: Add function to send command to GSC CS

2023-01-09 Thread Suraj Kandpal
Add function that takes care of sending command to gsc cs. We start of with allocation of memory for our command intel_hdcp_gsc_message that contains gsc cs memory header as directed in specs followed by the actual payload hdcp message that we want to send. Spec states that we need to poll pending

[Intel-gfx] [PATCH v6 4/6] drm/i915/hdcp: Refactor HDCP API structures

2023-01-09 Thread Suraj Kandpal
It requires to move intel specific HDCP API structures to i915_cp_fw_hdcp_interface.h from driver/misc/mei/hdcp/mei_hdcp.h so that any content protection fw interfaces can use these structures. Cc: Tomas Winkler Cc: Rodrigo Vivi Cc: Uma Shankar Cc: Ankit Nautiyal Signed-off-by: Anshuman Gupta

[Intel-gfx] [PATCH v6 2/6] drm/i915/hdcp: Keep hdcp agonstic naming convention

2023-01-09 Thread Suraj Kandpal
From: Anshuman Gupta Change the include/drm/i915_mei_hdcp_interface.h to include/drm/i915_hdcp_interface.h --v6 -make each patch build individually [Jani] Cc: Tomas Winkler Cc: Rodrigo Vivi Cc: Uma Shankar Cc: Ankit Nautiyal Signed-off-by: Anshuman Gupta Signed-off-by: Suraj Kandpal

[Intel-gfx] [PATCH v6 3/6] i915/hdcp: HDCP2.x Refactoring to agnostic hdcp

2023-01-09 Thread Suraj Kandpal
As now we have more then one type of content protection secrity firmware. Let change the i915_cp_fw_hdcp_interface.h header naming convention to suit generic f/w type. %s/MEI_/HDCP_ %s/mei_dev/hdcp_dev As interface to CP FW can be either a non i915 component or i915 intergral component, change

[Intel-gfx] [PATCH v6 1/6] drm/i915/gsc: Create GSC request submission mechanism

2023-01-09 Thread Suraj Kandpal
HDCP and PXP will require a common function to allow it to submit commands to the gsc cs. Also adding the gsc mtl header that needs to be added on to the existing payloads of HDCP and PXP. --v4 -Seprate gsc load and heci cmd submission into different functions in different files for better

[Intel-gfx] [PATCH v6 0/7] Enable HDCP2.x via GSC CS

2023-01-09 Thread Suraj Kandpal
These patches enable HDCP2.x on machines MTL and above. >From MTL onwards CSME is spilt into GSC and CSC and now we use GSC CS instead of MEI to talk to firmware to start HDCP authentication --v2 -Fixing some checkpatch changes which I forgot before sending out the series --v3 -Drop cp and fw to

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Cover rest of SVG unit MCR registers (rev2)

2023-01-09 Thread Patchwork
== Series Details == Series: drm/i915/gt: Cover rest of SVG unit MCR registers (rev2) URL : https://patchwork.freedesktop.org/series/112440/ State : success == Summary == CI Bug Log - changes from CI_DRM_12559_full -> Patchwork_112440v2_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix timeslots argument for DP DSC SST case (rev2)

2023-01-09 Thread Patchwork
== Series Details == Series: drm/i915: Fix timeslots argument for DP DSC SST case (rev2) URL : https://patchwork.freedesktop.org/series/112349/ State : success == Summary == CI Bug Log - changes from CI_DRM_12559_full -> Patchwork_112349v2_full

Re: [Intel-gfx] [RFC 2/2] drm/i915/display: Add 480 MHz CDCLK steps for RPL-U

2023-01-09 Thread Matt Roper
On Sat, Jan 07, 2023 at 11:06:43AM +0530, Chaitanya Kumar Borah wrote: > A new step of 480MHz has been added on SKUs that have a RPL-U > device id to support 120Hz displays more efficiently. Use a > new quirk to identify the machine for which this change needs > to be applied. > > BSpec: 55409 >

Re: [Intel-gfx] [RFC 1/2] drm/i915: Add rplu sub platform

2023-01-09 Thread Matt Roper
On Sat, Jan 07, 2023 at 11:06:42AM +0530, Chaitanya Kumar Borah wrote: > Adding RPL-U as a sub platform. In RPL-U a new CDCLK step has > been added so we need to make a distinction between RPL-P > and RPL-U while CDCLK initialization. > > Adding a sub-platform, enables us to make this

[Intel-gfx] ✗ Fi.CI.BAT: failure for Add module oriented dmesg output (rev3)

2023-01-09 Thread Patchwork
== Series Details == Series: Add module oriented dmesg output (rev3) URL : https://patchwork.freedesktop.org/series/111050/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12560 -> Patchwork_111050v3 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add module oriented dmesg output (rev3)

2023-01-09 Thread Patchwork
== Series Details == Series: Add module oriented dmesg output (rev3) URL : https://patchwork.freedesktop.org/series/111050/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add module oriented dmesg output (rev3)

2023-01-09 Thread Patchwork
== Series Details == Series: Add module oriented dmesg output (rev3) URL : https://patchwork.freedesktop.org/series/111050/ State : warning == Summary == Error: dim checkpatch failed 77fe0b8dbc3f drm/i915/gt: Start adding module oriented dmesg output Traceback (most recent call last): File

[Intel-gfx] [PATCH v3 1/1] drm/i915/gt: Start adding module oriented dmesg output

2023-01-09 Thread John . C . Harrison
From: John Harrison When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a

[Intel-gfx] [PATCH v3 0/1] Add module oriented dmesg output

2023-01-09 Thread John . C . Harrison
From: John Harrison When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a

Re: [Intel-gfx] [PATCH v3] drm/i915: Do not cover all future platforms in TLB invalidation

2023-01-09 Thread Matt Roper
On Mon, Jan 09, 2023 at 12:24:42PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Revert to the original explicit approach and document the reasoning > behind it. > > v2: > * DG2 needs to be covered too. (Matt) > > v3: > * Full version check for Gen12 to avoid catching all future

[Intel-gfx] ✗ Fi.CI.BAT: failure for ACPI: Fix selecting the wrong ACPI fwnode for the iGPU on some Dell laptops

2023-01-09 Thread Patchwork
== Series Details == Series: ACPI: Fix selecting the wrong ACPI fwnode for the iGPU on some Dell laptops URL : https://patchwork.freedesktop.org/series/112572/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12560 -> Patchwork_112572v1

Re: [Intel-gfx] [PATCH 2/2] drm_print: fix stale macro-name in comment

2023-01-09 Thread jim . cromie
On Thu, Jan 5, 2023 at 5:46 AM Daniel Vetter wrote: > > On Mon, Dec 05, 2022 at 09:10:05AM -0700, Jim Cromie wrote: > > Cited commit uses stale macro name, fix this, and explain better. > > > > When DRM_USE_DYNAMIC_DEBUG=y, DYNDBG_CLASSMAP_DEFINE() maps DRM_UT_* > > onto BITs in drm.debug. This

[Intel-gfx] ✓ Fi.CI.BAT: success for kvm/vfio: fix potential deadlock on vfio group lock

2023-01-09 Thread Patchwork
== Series Details == Series: kvm/vfio: fix potential deadlock on vfio group lock URL : https://patchwork.freedesktop.org/series/112568/ State : success == Summary == CI Bug Log - changes from CI_DRM_12560 -> Patchwork_112568v1 Summary

Re: [Intel-gfx] [PATCH 1/2] KVM: async kvm_destroy_vm for vfio devices

2023-01-09 Thread Anthony Krowiak
LGTM Reviewed-by: Tony Krowiak On 1/9/23 3:10 PM, Matthew Rosato wrote: Currently it is possible that the final put of a KVM reference comes from vfio during its device close operation. This occurs while the vfio group lock is held; however, if the vfio device is still in the kvm device

Re: [Intel-gfx] [PATCH] ACPI: Fix selecting the wrong ACPI fwnode for the iGPU on some Dell laptops

2023-01-09 Thread Hans de Goede
p.s. This fixes a regression in 6.1, adding the regressions list to the Cc. Once we figure out the best way to fix this (this patch is more of a proposal how to fix this rather then a definitive fix), we should also backport the fix to 6.1.y. On 1/9/23 21:57, Hans de Goede wrote: > The Dell

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for kvm/vfio: fix potential deadlock on vfio group lock

2023-01-09 Thread Patchwork
== Series Details == Series: kvm/vfio: fix potential deadlock on vfio group lock URL : https://patchwork.freedesktop.org/series/112568/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] [PATCH] ACPI: Fix selecting the wrong ACPI fwnode for the iGPU on some Dell laptops

2023-01-09 Thread Hans de Goede
The Dell Latitude E6430 both with and without the optional NVidia dGPU has a bug in its ACPI tables which is causing Linux to assign the wrong ACPI fwnode / companion to the pci_device for the i915 iGPU. Specifically under the PCI root bridge there are these 2 ACPI Device()s : Scope (_SB.PCI0)

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-09 Thread Daniel Vetter
On Mon, Jan 09, 2023 at 06:17:48PM +0100, Boris Brezillon wrote: > Hi Jason, > > On Mon, 9 Jan 2023 09:45:09 -0600 > Jason Ekstrand wrote: > > > On Thu, Jan 5, 2023 at 1:40 PM Matthew Brost > > wrote: > > > > > On Mon, Jan 02, 2023 at 08:30:19AM +0100, Boris Brezillon wrote: > > > > On Fri,

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Add GuC CT specific debug print wrappers

2023-01-09 Thread John Harrison
On 1/9/2023 01:39, Tvrtko Ursulin wrote: On 06/01/2023 18:57, John Harrison wrote: On 12/6/2022 03:06, Tvrtko Ursulin wrote: On 05/12/2022 18:44, Michal Wajdeczko wrote: On 05.12.2022 14:16, Tvrtko Ursulin wrote: On 02/12/2022 20:14, John Harrison wrote: [snip] Random meaningless (to me)

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Add GuC CT specific debug print wrappers

2023-01-09 Thread John Harrison
On 1/9/2023 01:38, Jani Nikula wrote: On Fri, 06 Jan 2023, John Harrison wrote: On 12/6/2022 03:06, Tvrtko Ursulin wrote: On 05/12/2022 18:44, Michal Wajdeczko wrote: On 05.12.2022 14:16, Tvrtko Ursulin wrote: On 02/12/2022 20:14, John Harrison wrote: [snip] Random meaningless (to me)

Re: [Intel-gfx] [PATCH 1/2] KVM: async kvm_destroy_vm for vfio devices

2023-01-09 Thread Matthew Rosato
On 1/9/23 3:13 PM, Jason Gunthorpe wrote: > On Mon, Jan 09, 2023 at 03:10:36PM -0500, Matthew Rosato wrote: >> Currently it is possible that the final put of a KVM reference comes from >> vfio during its device close operation. This occurs while the vfio group >> lock is held; however, if the

Re: [Intel-gfx] [PATCH 1/2] KVM: async kvm_destroy_vm for vfio devices

2023-01-09 Thread Jason Gunthorpe
On Mon, Jan 09, 2023 at 03:10:36PM -0500, Matthew Rosato wrote: > Currently it is possible that the final put of a KVM reference comes from > vfio during its device close operation. This occurs while the vfio group > lock is held; however, if the vfio device is still in the kvm device list, >

[Intel-gfx] [PATCH 2/2] KVM: s390: pci: use asyncronous kvm put

2023-01-09 Thread Matthew Rosato
It's possible that the kvm refcount will reach 0 at this point while the associated device is still in kvm device list - this would result in a deadlock on the vfio group lock. Avoid this possibility by using kvm_put_kvm_async to do the kvm_destroy_vm asynchronously. Fixes: 09340b2fca00 ("KVM:

[Intel-gfx] [PATCH 0/2] kvm/vfio: fix potential deadlock on vfio group lock

2023-01-09 Thread Matthew Rosato
Hi Alex, Paolo, As reported by Alex [1], since commit 421cfe6596f6 it is possible for a kvm_put_kvm call to hit a refcount of 0 and trigger kvm_destroy_vm while the vfio group lock is held. However, if this occurs, and the associated group is still in the kvm device list, this thread of

[Intel-gfx] [PATCH 1/2] KVM: async kvm_destroy_vm for vfio devices

2023-01-09 Thread Matthew Rosato
Currently it is possible that the final put of a KVM reference comes from vfio during its device close operation. This occurs while the vfio group lock is held; however, if the vfio device is still in the kvm device list, then the following call chain could result in a deadlock: kvm_put_kvm ->

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Cover rest of SVG unit MCR registers (rev2)

2023-01-09 Thread Patchwork
== Series Details == Series: drm/i915/gt: Cover rest of SVG unit MCR registers (rev2) URL : https://patchwork.freedesktop.org/series/112440/ State : success == Summary == CI Bug Log - changes from CI_DRM_12559 -> Patchwork_112440v2 Summary

Re: [Intel-gfx] [PATCH v2 9/9] drm/i915/display/misc: use intel_de_rmw if possible

2023-01-09 Thread Rodrigo Vivi
On Thu, Jan 05, 2023 at 02:10:46PM +0100, Andrzej Hajda wrote: > The helper makes the code more compact and readable. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/i915/display/g4x_dp.c | 12 > drivers/gpu/drm/i915/display/intel_drrs.c | 12 +++- >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix timeslots argument for DP DSC SST case (rev2)

2023-01-09 Thread Patchwork
== Series Details == Series: drm/i915: Fix timeslots argument for DP DSC SST case (rev2) URL : https://patchwork.freedesktop.org/series/112349/ State : success == Summary == CI Bug Log - changes from CI_DRM_12559 -> Patchwork_112349v2

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Cover rest of SVG unit MCR registers (rev2)

2023-01-09 Thread Patchwork
== Series Details == Series: drm/i915/gt: Cover rest of SVG unit MCR registers (rev2) URL : https://patchwork.freedesktop.org/series/112440/ State : warning == Summary == Error: dim checkpatch failed 7dc367129881 drm/i915/gt: Cover rest of SVG unit MCR registers -:6: ERROR:GIT_COMMIT_ID:

Re: [Intel-gfx] [PATCH v2 8/9] drm/i915/display/interfaces: use intel_de_rmw if possible

2023-01-09 Thread Rodrigo Vivi
On Thu, Jan 05, 2023 at 02:10:45PM +0100, Andrzej Hajda wrote: > The helper makes the code more compact and readable. > > Signed-off-by: Andrzej Hajda more cases in this patch where we are now always cleaning the bits, but as every other place I believe this is the right thing to do.

Re: [Intel-gfx] [PATCH v2 7/9] drm/i915/display/panel: use intel_de_rmw if possible in panel related code

2023-01-09 Thread Rodrigo Vivi
On Thu, Jan 05, 2023 at 02:10:44PM +0100, Andrzej Hajda wrote: > The helper makes the code more compact and readable. > > Signed-off-by: Andrzej Hajda > --- > .../gpu/drm/i915/display/intel_backlight.c| 59 +++ > drivers/gpu/drm/i915/display/intel_pps.c | 14 ++--- >

Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2023-01-09 Thread Rodrigo Vivi
On Sun, Jan 08, 2023 at 01:33:41AM +0530, Deepak R Varma wrote: > On Thu, Jan 05, 2023 at 09:13:35AM +0100, Julia Lawall wrote: > > > Hi Julia, thanks for helping here. > > > > > > So, my question is why this > > > > > > make coccicheck M=drivers/gpu/drm/i915/ MODE=context > > >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix timeslots argument for DP DSC SST case (rev2)

2023-01-09 Thread Patchwork
== Series Details == Series: drm/i915: Fix timeslots argument for DP DSC SST case (rev2) URL : https://patchwork.freedesktop.org/series/112349/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-09 Thread Jason Ekstrand
On Mon, Jan 9, 2023 at 7:46 AM Tvrtko Ursulin < tvrtko.ursu...@linux.intel.com> wrote: > > On 06/01/2023 23:52, Matthew Brost wrote: > > On Thu, Jan 05, 2023 at 09:43:41PM +, Matthew Brost wrote: > >> On Tue, Jan 03, 2023 at 01:02:15PM +, Tvrtko Ursulin wrote: > >>> > >>> On 02/01/2023

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-09 Thread Boris Brezillon
Hi Jason, On Mon, 9 Jan 2023 09:45:09 -0600 Jason Ekstrand wrote: > On Thu, Jan 5, 2023 at 1:40 PM Matthew Brost > wrote: > > > On Mon, Jan 02, 2023 at 08:30:19AM +0100, Boris Brezillon wrote: > > > On Fri, 30 Dec 2022 12:55:08 +0100 > > > Boris Brezillon wrote: > > > > > > > On Fri, 30

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-09 Thread Jason Ekstrand
On Thu, Jan 5, 2023 at 1:40 PM Matthew Brost wrote: > On Mon, Jan 02, 2023 at 08:30:19AM +0100, Boris Brezillon wrote: > > On Fri, 30 Dec 2022 12:55:08 +0100 > > Boris Brezillon wrote: > > > > > On Fri, 30 Dec 2022 11:20:42 +0100 > > > Boris Brezillon wrote: > > > > > > > Hello Matthew, > > >

Re: [Intel-gfx] [PATCH] drm/i915: Implement workaround for DP2 UHBR bandwidth check

2023-01-09 Thread Lisovskiy, Stanislav
On Tue, Jan 03, 2023 at 11:32:28AM -0500, Rodrigo Vivi wrote: > > on the subject: This is not a hw workaround. Please remove the workaround from > the subject and the wrong comment. > > "The HSD given is a 'feature' rather than 'bugeco' so no workaround details > are > present here." > > > On

Re: [Intel-gfx] [PATCH] drm: Alloc high address for drm buddy topdown flag

2023-01-09 Thread Alex Deucher
On Mon, Jan 9, 2023 at 5:13 AM Christian König wrote: > > Am 07.01.23 um 16:15 schrieb Arunpravin Paneer Selvam: > > As we are observing low numbers in viewperf graphics benchmark, we > > are strictly not allowing the top down flag enabled allocations > > to steal the memory space from cpu

Re: [Intel-gfx] LOOKS GOOD: Possible regression in drm/i915 driver: memleak

2023-01-09 Thread Tvrtko Ursulin
On 25/12/2022 22:48, Mirsad Goran Todorovac wrote: On 22. 12. 2022. 09:04, Tvrtko Ursulin wrote: In the meantime definitely thanks a lot for testing this quickly and reporting back! Don't think much of it - anyone with CONFIG_KMEMLEAK enabled could have caught this bug. I was surprised

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Enable FBC for fbcon (rev2)

2023-01-09 Thread Patchwork
== Series Details == Series: drm/i915/display: Enable FBC for fbcon (rev2) URL : https://patchwork.freedesktop.org/series/112548/ State : success == Summary == CI Bug Log - changes from CI_DRM_12556_full -> Patchwork_112548v2_full Summary

[Intel-gfx] [PATCH] drm/i915: Fix timeslots argument for DP DSC SST case

2023-01-09 Thread Stanislav Lisovskiy
We now accept timeslots param exactly how the variable sounds: amount of timeslots, but not ratio timeslots/64. So for SST case(when we have all timeslots for use), it should be 64, but not 1. This caused some issues in the tests. v2: Fixed comments References:

Re: [Intel-gfx] [PATCH] drm/i915: Update docs in intel_wakeref.h

2023-01-09 Thread Andi Shyti
Hi Nirmoy, On Thu, Jan 05, 2023 at 09:38:43PM +0100, Nirmoy Das wrote: > Fix docs for __intel_wakeref_put() and intel_wakeref_get() to > reflect current behaviour. > > Signed-off-by: Nirmoy Das Thanks for adding also the change suggested by Ashutosh! Reviewed-by: Andi Shyti Andi > --- >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: use proper helper in igt_vma_move_to_active_unlocked

2023-01-09 Thread Andi Shyti
Hi Andrzej, On Tue, Dec 13, 2022 at 01:19:50PM +0100, Andrzej Hajda wrote: > There is no need to use _i915_vma_move_to_active. > No functional changes. > > Signed-off-by: Andrzej Hajda both patches pushed in drm-intel-gt-next. Thanks, Andi > --- >

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-09 Thread Tvrtko Ursulin
On 06/01/2023 23:52, Matthew Brost wrote: On Thu, Jan 05, 2023 at 09:43:41PM +, Matthew Brost wrote: On Tue, Jan 03, 2023 at 01:02:15PM +, Tvrtko Ursulin wrote: On 02/01/2023 07:30, Boris Brezillon wrote: On Fri, 30 Dec 2022 12:55:08 +0100 Boris Brezillon wrote: On Fri, 30 Dec

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/9] drm/i915/display/core: use intel_de_rmw if possible (rev2)

2023-01-09 Thread Patchwork
== Series Details == Series: series starting with [v2,1/9] drm/i915/display/core: use intel_de_rmw if possible (rev2) URL : https://patchwork.freedesktop.org/series/112438/ State : success == Summary == CI Bug Log - changes from CI_DRM_12556_full -> Patchwork_112438v2_full

Re: [Intel-gfx] [PATCH] drm/i915: Fix timeslots argument for DP DSC SST case

2023-01-09 Thread Lisovskiy, Stanislav
On Tue, Jan 03, 2023 at 11:14:16AM -0500, Rodrigo Vivi wrote: > On Mon, Jan 02, 2023 at 03:23:06PM +0200, Stanislav Lisovskiy wrote: > > We now accept timeslots param exactly how the variable > > sounds: amount of timeslots, but not ratio timeslots/64. > > So for SST case(when we have all

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Enable FBC for fbcon (rev2)

2023-01-09 Thread Patchwork
== Series Details == Series: drm/i915/display: Enable FBC for fbcon (rev2) URL : https://patchwork.freedesktop.org/series/112548/ State : success == Summary == CI Bug Log - changes from CI_DRM_12556 -> Patchwork_112548v2 Summary ---

[Intel-gfx] [PATCH v3] drm/i915: Do not cover all future platforms in TLB invalidation

2023-01-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Revert to the original explicit approach and document the reasoning behind it. v2: * DG2 needs to be covered too. (Matt) v3: * Full version check for Gen12 to avoid catching all future platforms. (Matt) Signed-off-by: Tvrtko Ursulin Cc: Matt Roper Cc: Balasubramani

[Intel-gfx] [PATCH fixed] drm/i915/display: Enable FBC for fbcon

2023-01-09 Thread Maarten Lankhorst
Remove frontbuffer invalidation code from FBC, and just use the dirtyfb helper. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_fbdev.c | 73 +- 1 file changed, 15 insertions(+), 58 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c

Re: [Intel-gfx] [PATCH v7 1/2] drm/i915/mtl: limit second scaler vertical scaling in ver >= 14

2023-01-09 Thread Coelho, Luciano
On Mon, 2023-01-09 at 09:06 +0200, Lisovskiy, Stanislav wrote: > On Fri, Dec 23, 2022 at 03:05:08PM +0200, Luca Coelho wrote: > > In newer hardware versions (i.e. display version >= 14), the second > > scaler doesn't support vertical scaling. > > > > The current implementation of the scaling

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/9] drm/i915/display/core: use intel_de_rmw if possible (rev2)

2023-01-09 Thread Patchwork
== Series Details == Series: series starting with [v2,1/9] drm/i915/display/core: use intel_de_rmw if possible (rev2) URL : https://patchwork.freedesktop.org/series/112438/ State : success == Summary == CI Bug Log - changes from CI_DRM_12556 -> Patchwork_112438v2

[Intel-gfx] [PATCH] drm/i915/display: Enable FBC for fbcon

2023-01-09 Thread Maarten Lankhorst
Remove frontbuffer invalidation code from FBC, and just use the dirtyfb helper. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_fbdev.c | 68 +- 1 file changed, 15 insertions(+), 53 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c

Re: [Intel-gfx] [PATCH v2 6/9] drm/i915/display/hdmi: use intel_de_rmw if possible

2023-01-09 Thread Jani Nikula
On Mon, 09 Jan 2023, Andrzej Hajda wrote: > On 06.01.2023 16:35, Rodrigo Vivi wrote: >> On Thu, Jan 05, 2023 at 02:10:43PM +0100, Andrzej Hajda wrote: >>> The helper makes the code more compact and readable. >>> >>> Signed-off-by: Andrzej Hajda >>> --- >>>

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/9] drm/i915/display/core: use intel_de_rmw if possible (rev2)

2023-01-09 Thread Patchwork
== Series Details == Series: series starting with [v2,1/9] drm/i915/display/core: use intel_de_rmw if possible (rev2) URL : https://patchwork.freedesktop.org/series/112438/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] [PATCH 5/5] drm/plane: Unexport drm_any_plane_has_format()

2023-01-09 Thread Maíra Canal
As the format validation is being dealt with exclusively inside framebuffer_check(), there is no need to export the drm_any_plane_has_format() symbol. Therefore, unexport the drm_any_plane_has_format() symbol, reinforcing that format validation is being dealt with by the DRM API. Signed-off-by:

[Intel-gfx] [PATCH 4/5] drm/vmwgfx: Remove redundant framebuffer format check

2023-01-09 Thread Maíra Canal
Now that framebuffer_check() verifies that the format is properly supported, there is no need to check it again on vmwgfx's inside helpers. Therefore, remove the redundant framebuffer format check from the vmw_kms_new_framebuffer_surface() and vmw_kms_new_framebuffer_bo() functions, letting

[Intel-gfx] [PATCH 3/5] drm/i915: Remove redundant framebuffer format check

2023-01-09 Thread Maíra Canal
Now that framebuffer_check() verifies that the format is properly supported, there is no need to check it again on i915's inside helpers. Therefore, remove the redundant framebuffer format check from the intel_framebuffer_init() function, letting framebuffer_check() perform the framebuffer

[Intel-gfx] [PATCH 2/5] drm/amdgpu: Remove redundant framebuffer format check

2023-01-09 Thread Maíra Canal
Now that framebuffer_check() verifies that the format is properly supported, there is no need to check it again on amdgpu's inside helpers. Therefore, remove the redundant framebuffer format check from the amdgpu_display_gem_fb_verify_and_init() function, letting framebuffer_check() perform the

[Intel-gfx] [PATCH 0/5] Check for valid framebuffer's format

2023-01-09 Thread Maíra Canal
This series is a follow-up of [1] in which I introduced a check for valid formats on drm_gem_fb_create(). During the discussion, I realized that would be a better idea to put the check inside framebuffer_check() so that it wouldn't be needed to hit any driver-specific code path when the check

[Intel-gfx] [PATCH 1/5] drm/framebuffer: Check for valid formats

2023-01-09 Thread Maíra Canal
Currently, framebuffer_check() doesn't check if the pixel format is supported, which can lead to the acceptance of invalid pixel formats e.g. the acceptance of invalid modifiers. Therefore, add a check for valid formats on framebuffer_check(), so that the ADDFB2 IOCTL rejects calls with invalid

Re: [Intel-gfx] [PATCH v2 6/9] drm/i915/display/hdmi: use intel_de_rmw if possible

2023-01-09 Thread Andrzej Hajda
On 06.01.2023 16:35, Rodrigo Vivi wrote: On Thu, Jan 05, 2023 at 02:10:43PM +0100, Andrzej Hajda wrote: The helper makes the code more compact and readable. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/display/g4x_hdmi.c | 8 ++--- drivers/gpu/drm/i915/display/intel_hdcp.c | 15

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: drop redundant display/ from #includes (rev3)

2023-01-09 Thread Patchwork
== Series Details == Series: drm/i915/display: drop redundant display/ from #includes (rev3) URL : https://patchwork.freedesktop.org/series/111803/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12556 -> Patchwork_111803v3

Re: [Intel-gfx] [PATCH v2 04/21] drm/i915/mtl: Add Support for C10 PHY message bus and pll programming

2023-01-09 Thread Kahola, Mika
> -Original Message- > From: Nikula, Jani > Sent: Monday, January 9, 2023 11:50 AM > To: Kahola, Mika ; intel-gfx@lists.freedesktop.org > Cc: Deak, Imre ; Sripada, Radhakrishna > ; Kahola, Mika ; > Shankar, Uma > Subject: Re: [PATCH v2 04/21] drm/i915/mtl: Add Support for C10 PHY message

Re: [Intel-gfx] [PATCH 03/27] drm/i915/gvt: Incorporate KVM memslot info into check for 2MiB GTT entry

2023-01-09 Thread Yan Zhao
On Fri, Jan 06, 2023 at 11:01:53PM +, Sean Christopherson wrote: > On Fri, Jan 06, 2023, Yan Zhao wrote: > > On Thu, Jan 05, 2023 at 05:40:32PM +, Sean Christopherson wrote: > > > On Thu, Jan 05, 2023, Yan Zhao wrote: > > > I'm totally fine if KVMGT's ABI is that VFIO is the source of

Re: [Intel-gfx] [PATCH] drm: Alloc high address for drm buddy topdown flag

2023-01-09 Thread Christian König
Am 07.01.23 um 16:15 schrieb Arunpravin Paneer Selvam: As we are observing low numbers in viewperf graphics benchmark, we are strictly not allowing the top down flag enabled allocations to steal the memory space from cpu visible region. The approach is, we are sorting each order list entries in

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Implement workaround for CDCLK PLL disable/enable

2023-01-09 Thread Lisovskiy, Stanislav
On Thu, Jan 05, 2023 at 03:05:40AM +0200, Srivatsa, Anusha wrote: > > > > -Original Message- > > From: Lisovskiy, Stanislav > > Sent: Thursday, December 15, 2022 2:14 AM > > To: Srivatsa, Anusha > > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani > > Subject: Re: [Intel-gfx] [PATCH

Re: [Intel-gfx] [PATCH v2 04/21] drm/i915/mtl: Add Support for C10 PHY message bus and pll programming

2023-01-09 Thread Jani Nikula
On Thu, 05 Jan 2023, Mika Kahola wrote: > +static int intel_cx0_wait_for_ack(struct drm_i915_private *i915, enum port > port, int lane, u32 *val) > +{ > + enum phy phy = intel_port_to_phy(i915, port); > + > + if (__intel_wait_for_register(>uncore, There's now an __intel_de_ variant of

Re: [Intel-gfx] [PATCH 11/13] drm/i915/dsb: Add mode DSB opcodes

2023-01-09 Thread Jani Nikula
On Thu, 05 Jan 2023, "Manna, Animesh" wrote: >> -Original Message- >> From: Intel-gfx On Behalf Of Ville >> Syrjala >> Sent: Friday, December 16, 2022 6:08 AM >> To: intel-gfx@lists.freedesktop.org >> Subject: [Intel-gfx] [PATCH 11/13] drm/i915/dsb: Add mode DSB opcodes >> >> From:

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Add GuC CT specific debug print wrappers

2023-01-09 Thread Tvrtko Ursulin
On 06/01/2023 18:57, John Harrison wrote: On 12/6/2022 03:06, Tvrtko Ursulin wrote: On 05/12/2022 18:44, Michal Wajdeczko wrote: On 05.12.2022 14:16, Tvrtko Ursulin wrote: On 02/12/2022 20:14, John Harrison wrote: [snip] Random meaningless (to me) message that is apparently a display

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Add GuC CT specific debug print wrappers

2023-01-09 Thread Jani Nikula
On Fri, 06 Jan 2023, John Harrison wrote: > On 12/6/2022 03:06, Tvrtko Ursulin wrote: >> On 05/12/2022 18:44, Michal Wajdeczko wrote: >>> On 05.12.2022 14:16, Tvrtko Ursulin wrote: On 02/12/2022 20:14, John Harrison wrote: [snip] > Random meaningless (to me) message that is