Re: [Intel-gfx] [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()

2023-03-15 Thread Nicolin Chen
On Thu, Mar 16, 2023 at 05:49:20AM +, Tian, Kevin wrote: > External email: Use caution opening links or attachments > > > > From: Nicolin Chen > > Sent: Thursday, March 16, 2023 1:44 PM > > > > On Thu, Mar 16, 2023 at 05:38:41AM +, Tian, Kevin wrote: > > > External email: Use caution

Re: [Intel-gfx] [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()

2023-03-15 Thread Tian, Kevin
> From: Nicolin Chen > Sent: Thursday, March 16, 2023 1:44 PM > > On Thu, Mar 16, 2023 at 05:38:41AM +, Tian, Kevin wrote: > > External email: Use caution opening links or attachments > > > > > > > From: Nicolin Chen > > > Sent: Thursday, March 16, 2023 1:33 PM > > > > > > Hi Kevin, > > > >

Re: [Intel-gfx] [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()

2023-03-15 Thread Nicolin Chen
On Thu, Mar 16, 2023 at 05:38:41AM +, Tian, Kevin wrote: > External email: Use caution opening links or attachments > > > > From: Nicolin Chen > > Sent: Thursday, March 16, 2023 1:33 PM > > > > Hi Kevin, > > > > I've fixed the other two commits. Here is the one that I am > > not sure about:

Re: [Intel-gfx] [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()

2023-03-15 Thread Tian, Kevin
> From: Nicolin Chen > Sent: Thursday, March 16, 2023 1:33 PM > > Hi Kevin, > > I've fixed the other two commits. Here is the one that I am > not sure about: > > On Thu, Mar 16, 2023 at 02:53:50AM +, Tian, Kevin wrote: > > > > [2] This adds iommufd_access_detach() in the cdev series: > >

Re: [Intel-gfx] [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()

2023-03-15 Thread Nicolin Chen
Hi Kevin, I've fixed the other two commits. Here is the one that I am not sure about: On Thu, Mar 16, 2023 at 02:53:50AM +, Tian, Kevin wrote: > > [2] This adds iommufd_access_detach() in the cdev series: > > "iommufd/device: Add iommufd_access_detach() API" > > > >

Re: [Intel-gfx] [PATCH v5 09/12] drm/i915/perf: Add engine class instance parameters to perf

2023-03-15 Thread Dixit, Ashutosh
On Wed, 15 Mar 2023 17:09:29 -0700, Umesh Nerlige Ramappa wrote: > > diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h > index 8df261c5ab9b..e8c258bfd4c9 100644 > --- a/include/uapi/drm/i915_drm.h > +++ b/include/uapi/drm/i915_drm.h > @@ -2758,6 +2758,25 @@ enum

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: keep same cache settings as timeline (rev2)

2023-03-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: keep same cache settings as timeline (rev2) URL : https://patchwork.freedesktop.org/series/114879/ State : success == Summary == CI Bug Log - changes from CI_DRM_12864_full -> Patchwork_114879v2_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Update engine_init_common documentation (rev3)

2023-03-15 Thread Patchwork
== Series Details == Series: drm/i915/gt: Update engine_init_common documentation (rev3) URL : https://patchwork.freedesktop.org/series/114926/ State : success == Summary == CI Bug Log - changes from CI_DRM_12864_full -> Patchwork_114926v3_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Disable PL1 power limit when loading GuC firmware (rev3)

2023-03-15 Thread Patchwork
== Series Details == Series: drm/i915/guc: Disable PL1 power limit when loading GuC firmware (rev3) URL : https://patchwork.freedesktop.org/series/115003/ State : success == Summary == CI Bug Log - changes from CI_DRM_12867 -> Patchwork_115003v3

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/guc: Disable PL1 power limit when loading GuC firmware (rev3)

2023-03-15 Thread Patchwork
== Series Details == Series: drm/i915/guc: Disable PL1 power limit when loading GuC firmware (rev3) URL : https://patchwork.freedesktop.org/series/115003/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-15 Thread Dixit, Ashutosh
On Tue, 14 Mar 2023 02:35:07 -0700, Jani Nikula wrote: > Hi Jani, Thanks for the review. I have posted v3, comments inline below. > On Mon, 13 Mar 2023, Ashutosh Dixit wrote: > > On dGfx, the PL1 power limit being enabled and set to a low value results > > in a low GPU operating freq. It also

[Intel-gfx] [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-15 Thread Ashutosh Dixit
On dGfx, the PL1 power limit being enabled and set to a low value results in a low GPU operating freq. It also negates the freq raise operation which is done before GuC firmware load. As a result GuC firmware load can time out. Such timeouts were seen in the GL #8062 bug below (where the PL1 power

[Intel-gfx] [offlist] RE: [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-15 Thread Liu, Yi L
> From: Tian, Kevin > Sent: Thursday, March 16, 2023 7:31 AM > > > From: Alex Williamson > > Sent: Thursday, March 16, 2023 6:53 AM > > > > On Wed, 8 Mar 2023 05:28:51 -0800 > > Yi Liu wrote: > > > > > This is another method to issue PCI hot reset for the users that bounds > > > device to a

Re: [Intel-gfx] [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()

2023-03-15 Thread Nicolin Chen
On Thu, Mar 16, 2023 at 02:53:50AM +, Tian, Kevin wrote: > > Please check if they look okay, so that Yi can integrate them > > accordingly to the emulated/cdev series. > > this split looks reasonable to me. Go ahead. Thanks for the review! I will address those comments and renew those

Re: [Intel-gfx] [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()

2023-03-15 Thread Tian, Kevin
> From: Nicolin Chen > Sent: Wednesday, March 15, 2023 5:03 PM > > Hi, > > On Wed, Mar 15, 2023 at 06:50:53AM +, Tian, Kevin wrote: > > > > So, this preparatory series will add a pair of simple attach() > > > and detach() APIs. Then the cdev series will add the locking > > > and the

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Clarify seemingly unaccounted obj refcount inc

2023-03-15 Thread Patchwork
== Series Details == Series: drm/i915/gem: Clarify seemingly unaccounted obj refcount inc URL : https://patchwork.freedesktop.org/series/115182/ State : success == Summary == CI Bug Log - changes from CI_DRM_12864_full -> Patchwork_115182v1_full

Re: [Intel-gfx] [Freedreno] [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-03-15 Thread Jessica Zhang
On 2/27/2023 1:24 PM, Abhinav Kumar wrote: On 2/27/2023 11:25 AM, Dmitry Baryshkov wrote: 27 февраля 2023 г. 19:59:35 GMT+02:00, Abhinav Kumar пишет: On 2/27/2023 4:45 AM, Dmitry Baryshkov wrote: On Mon, 27 Feb 2023 at 01:49, Abhinav Kumar wrote: On 2/26/2023 5:09 AM, Dmitry

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Use functions common with sysfs to read actual freq

2023-03-15 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Use functions common with sysfs to read actual freq URL : https://patchwork.freedesktop.org/series/115225/ State : success == Summary == CI Bug Log - changes from CI_DRM_12867 -> Patchwork_115225v1

[Intel-gfx] [PATCH v6 11/12] drm/i915/perf: Pass i915 object to perf revision helper

2023-03-15 Thread Umesh Nerlige Ramappa
In some cases, perf revision may rely on specific steppings of a platform. To determine the platform, pass i915 object to the perf revision helper. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_getparam.c | 2 +- drivers/gpu/drm/i915/i915_perf.c | 2 +-

[Intel-gfx] [PATCH v6 06/12] drm/i915/perf: Fail modprobe if i915_perf_init fails on OOM

2023-03-15 Thread Umesh Nerlige Ramappa
i915_perf_init can fail due to OOM. Fail driver init if i915_perf_init fails. v2: (Jani) - Reorder patch in the series Signed-off-by: Umesh Nerlige Ramappa Reviewed-by: Ashutosh Dixit --- drivers/gpu/drm/i915/i915_driver.c | 4 +++- drivers/gpu/drm/i915/i915_perf.c | 8 ++--

[Intel-gfx] [PATCH v6 09/12] drm/i915/perf: Add engine class instance parameters to perf

2023-03-15 Thread Umesh Nerlige Ramappa
One or more engines map to a specific OA unit. All reports from these engines are captured in the OA buffer managed by this OA unit. Current i915 OA implementation supports only the OAG unit. OAG primarily caters to render engine, so i915 OA uses render as the default engine in the OA

[Intel-gfx] [PATCH v6 08/12] drm/i915/perf: Handle non-power-of-2 reports

2023-03-15 Thread Umesh Nerlige Ramappa
Some of the newer OA formats are not powers of 2. For those formats, adjust the hw_tail accordingly when checking for new reports. v2: (Ashutosh) - Switch to OA_TAKEN for diff calculation - Use OA_BUFFER_SIZE instead of the vma size - Update comments Signed-off-by: Umesh Nerlige Ramappa

[Intel-gfx] [PATCH v6 05/12] drm/i915/perf: Group engines into respective OA groups

2023-03-15 Thread Umesh Nerlige Ramappa
Now that we may have multiple OA units in a single GT as well as on separate GTs, create an engine group that maps to a single OA unit. v2: (Jani) - Drop warning on ENOMEM - Reorder patch in the series v3: (Ashutosh) - Remove unused members from perf structs - Update comments - Update

[Intel-gfx] [PATCH v6 10/12] drm/i915/perf: Add support for OA media units

2023-03-15 Thread Umesh Nerlige Ramappa
MTL introduces additional OA units dedicated to media use cases. Add support for programming these OA units by passing the media engine class and instance parameters. UMD specific changes for GPUvis support: https://patchwork.freedesktop.org/patch/522827/?series=114023

[Intel-gfx] [PATCH v6 00/12] Add OAM support for MTL

2023-03-15 Thread Umesh Nerlige Ramappa
The OAM unit captures OA reports specific to the media engines. Add support to program the OAM unit on media tile on MTL. The OAM unit is selected by passing the class:instance of a media engine to perf parameters. Corresponding UMD changes are posted to the igt-dev repo as part of supporting the

[Intel-gfx] [PATCH v6 04/12] drm/i915/perf: Validate OA sseu config outside switch

2023-03-15 Thread Umesh Nerlige Ramappa
Once OA supports media engine class:instance, the engine can only be validated outside the switch since class and instance parameters are separate entities. Since OA sseu config depends on engine class:instance, validate OA sseu config outside the switch. v2: (Ashutosh) - Clarify commit message -

[Intel-gfx] [PATCH v6 07/12] drm/i915/perf: Parse 64bit report header formats correctly

2023-03-15 Thread Umesh Nerlige Ramappa
Now that OA formats come in flavor of 64 bit reports, the report header has 64 bit report-id, timestamp, context-id and gpu-ticks fields. When filtering these reports, use the right width for these fields. Note that upper dword of context id is reserved, so squash lower dword only. v2:

[Intel-gfx] [PATCH v6 12/12] drm/i915/perf: Wa_14017512683: Disable OAM if media C6 is enabled in BIOS

2023-03-15 Thread Umesh Nerlige Ramappa
OAM does not work with media C6 enabled on some steppings of MTL. Disable OAM if we detect that media C6 was enabled in bios. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_perf.c | 30 ++ 1 file changed, 30 insertions(+) diff --git

[Intel-gfx] [PATCH v6 02/12] drm/i915/mtl: Synchronize i915/BIOS on C6 enabling

2023-03-15 Thread Umesh Nerlige Ramappa
From: Vinay Belgaumkar If BIOS enables/disables C6, i915 should do the same. Also, retain this value across driver reloads. This is needed only for MTL as of now due to an existing bug in OA which needs C6 disabled for it to function. BIOS behavior is also different across platforms in terms of

[Intel-gfx] [PATCH v6 03/12] drm/i915/perf: Add helper to check supported OA engines

2023-03-15 Thread Umesh Nerlige Ramappa
With an intention to add more engines that are supported by OA, add helper to check for supported OA engines. v2: (Ashutosh) - Update commit message - Drop virtual engine check since we support only one render engine Signed-off-by: Umesh Nerlige Ramappa Reviewed-by: Ashutosh Dixit ---

[Intel-gfx] [PATCH v6 01/12] drm/i915/perf: Drop wakeref on GuC RC error

2023-03-15 Thread Umesh Nerlige Ramappa
From: Chris Wilson If we fail to adjust the GuC run-control on opening the perf stream, make sure we unwind the wakeref just taken. v2: Retain old goto label names (Ashutosh) Fixes: 01e742746785 ("drm/i915/guc: Support OA when Wa_16011777198 is enabled") Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH 1/2] drm/i915/pmu: Use functions common with sysfs to read actual freq

2023-03-15 Thread Dixit, Ashutosh
On Wed, 15 Mar 2023 02:43:30 -0700, Tvrtko Ursulin wrote: > > On 10/03/2023 00:59, Ashutosh Dixit wrote: > > Expose intel_rps_read_actual_frequency_fw to read the actual freq without > > taking forcewake for use by PMU. The code is refactored to use a common set > > of functions across sysfs and

[Intel-gfx] [PATCH] drm/i915/pmu: Use functions common with sysfs to read actual freq

2023-03-15 Thread Ashutosh Dixit
Expose intel_rps_read_actual_frequency_fw to read the actual freq without taking forcewake for use by PMU. The code is refactored to use a common set of functions across sysfs and PMU. Using common functions with sysfs in PMU solves the issues of missing support for MTL and missing support for

Re: [Intel-gfx] [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()

2023-03-15 Thread Nicolin Chen
On Wed, Mar 15, 2023 at 12:18:01PM +, Liu, Yi L wrote: > > OK. Basically I followed what Jason suggested by having three > > APIs and combined Kevin's inputs about the difference between > > the attach/replace(). I also updated the replace changes, and > > rebased all nesting (infrastructure,

Re: [Intel-gfx] [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()

2023-03-15 Thread Nicolin Chen
On Thu, Mar 16, 2023 at 12:17:11AM +, Tian, Kevin wrote: > > > > > > > > @@ -449,33 +450,18 @@ iommufd_access_create(struct > > > > iommufd_ctx > > > > > > > > refcount_inc(>obj.users); > > > > > > > > + mutex_init(>ioas_lock); > > > > > > > > access->ictx = ictx; > > > > > >

Re: [Intel-gfx] [BUG 6.3-rc1] Bad lock in ttm_bo_delayed_delete()

2023-03-15 Thread Steven Rostedt
On Wed, 15 Mar 2023 20:21:33 -0400 Steven Rostedt wrote: > On Wed, 15 Mar 2023 16:20:11 -0400 > Steven Rostedt wrote: > > > On Wed, 15 Mar 2023 20:51:49 +0100 > > Christian König wrote: > > > > > Steven please try the attached patch. > > > > I applied it, but as it's not always

Re: [Intel-gfx] [BUG 6.3-rc1] Bad lock in ttm_bo_delayed_delete()

2023-03-15 Thread Steven Rostedt
On Wed, 15 Mar 2023 16:20:11 -0400 Steven Rostedt wrote: > On Wed, 15 Mar 2023 20:51:49 +0100 > Christian König wrote: > > > Steven please try the attached patch. > > I applied it, but as it's not always reproducible, I'll have to give it > several runs before I give you my "tested-by" tag.

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/ttm: Small fixes / cleanups in prep for shrinking (rev2)

2023-03-15 Thread Patchwork
== Series Details == Series: drm/ttm: Small fixes / cleanups in prep for shrinking (rev2) URL : https://patchwork.freedesktop.org/series/114774/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12829_full -> Patchwork_114774v2_full

Re: [Intel-gfx] [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()

2023-03-15 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Wednesday, March 15, 2023 4:53 PM > > > From: Tian, Kevin > > Sent: Wednesday, March 15, 2023 2:52 PM > > > > > From: Nicolin Chen > > > Sent: Wednesday, March 15, 2023 2:22 PM > > > > > > On Wed, Mar 15, 2023 at 06:16:37AM +, Tian, Kevin wrote: > > > > External

Re: [Intel-gfx] [PATCH v5 00/12] Add OAM support for MTL

2023-03-15 Thread Umesh Nerlige Ramappa
Please ignore this series. Will post another one after rebase. Thanks, Umesh On Wed, Mar 15, 2023 at 05:09:20PM -0700, Umesh Nerlige Ramappa wrote: The OAM unit captures OA reports specific to the media engines. Add support to program the OAM unit on media tile on MTL. The OAM unit is

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Add OAM support for MTL

2023-03-15 Thread Patchwork
== Series Details == Series: Add OAM support for MTL URL : https://patchwork.freedesktop.org/series/115224/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/115224/revisions/1/mbox/ not applied Applying: drm/i915/perf: Drop wakeref on GuC RC error

[Intel-gfx] [PATCH v5 04/12] drm/i915/perf: Validate OA sseu config outside switch

2023-03-15 Thread Umesh Nerlige Ramappa
Once OA supports media engine class:instance, the engine can only be validated outside the switch since class and instance parameters are separate entities. Since OA sseu config depends on engine class:instance, validate OA sseu config outside the switch. v2: (Ashutosh) - Clarify commit message -

[Intel-gfx] [PATCH v5 10/12] drm/i915/perf: Add support for OA media units

2023-03-15 Thread Umesh Nerlige Ramappa
MTL introduces additional OA units dedicated to media use cases. Add support for programming these OA units by passing the media engine class and instance parameters. UMD specific changes for GPUvis support: https://patchwork.freedesktop.org/patch/522827/?series=114023

[Intel-gfx] [PATCH v5 11/12] drm/i915/perf: Pass i915 object to perf revision helper

2023-03-15 Thread Umesh Nerlige Ramappa
In some cases, perf revision may rely on specific steppings of a platform. To determine the platform, pass i915 object to the perf revision helper. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_getparam.c | 2 +- drivers/gpu/drm/i915/i915_perf.c | 2 +-

[Intel-gfx] [PATCH v5 12/12] drm/i915/perf: Wa_14017512683: Disable OAM if media C6 is enabled in BIOS

2023-03-15 Thread Umesh Nerlige Ramappa
OAM does not work with media C6 enabled on some steppings of MTL. Disable OAM if we detect that media C6 was enabled in bios. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_perf.c | 30 ++ 1 file changed, 30 insertions(+) diff --git

[Intel-gfx] [PATCH v5 07/12] drm/i915/perf: Parse 64bit report header formats correctly

2023-03-15 Thread Umesh Nerlige Ramappa
Now that OA formats come in flavor of 64 bit reports, the report header has 64 bit report-id, timestamp, context-id and gpu-ticks fields. When filtering these reports, use the right width for these fields. Note that upper dword of context id is reserved, so squash lower dword only. v2:

[Intel-gfx] [PATCH v5 08/12] drm/i915/perf: Handle non-power-of-2 reports

2023-03-15 Thread Umesh Nerlige Ramappa
Some of the newer OA formats are not powers of 2. For those formats, adjust the hw_tail accordingly when checking for new reports. v2: (Ashutosh) - Switch to OA_TAKEN for diff calculation - Use OA_BUFFER_SIZE instead of the vma size - Update comments Signed-off-by: Umesh Nerlige Ramappa

[Intel-gfx] [PATCH v5 09/12] drm/i915/perf: Add engine class instance parameters to perf

2023-03-15 Thread Umesh Nerlige Ramappa
One or more engines map to a specific OA unit. All reports from these engines are captured in the OA buffer managed by this OA unit. Current i915 OA implementation supports only the OAG unit. OAG primarily caters to render engine, so i915 OA uses render as the default engine in the OA

[Intel-gfx] [PATCH v5 06/12] drm/i915/perf: Fail modprobe if i915_perf_init fails on OOM

2023-03-15 Thread Umesh Nerlige Ramappa
i915_perf_init can fail due to OOM. Fail driver init if i915_perf_init fails. v2: (Jani) - Reorder patch in the series Signed-off-by: Umesh Nerlige Ramappa Reviewed-by: Ashutosh Dixit --- drivers/gpu/drm/i915/i915_driver.c | 4 +++- drivers/gpu/drm/i915/i915_perf.c | 8 ++--

[Intel-gfx] [PATCH v5 03/12] drm/i915/perf: Add helper to check supported OA engines

2023-03-15 Thread Umesh Nerlige Ramappa
With an intention to add more engines that are supported by OA, add helper to check for supported OA engines. v2: (Ashutosh) - Update commit message - Drop virtual engine check since we support only one render engine Signed-off-by: Umesh Nerlige Ramappa Reviewed-by: Ashutosh Dixit ---

[Intel-gfx] [PATCH v5 02/12] drm/i915/mtl: Synchronize i915/BIOS on C6 enabling

2023-03-15 Thread Umesh Nerlige Ramappa
From: Vinay Belgaumkar If BIOS enables/disables C6, i915 should do the same. Also, retain this value across driver reloads. This is needed only for MTL as of now due to an existing bug in OA which needs C6 disabled for it to function. BIOS behavior is also different across platforms in terms of

[Intel-gfx] [PATCH v5 05/12] drm/i915/perf: Group engines into respective OA groups

2023-03-15 Thread Umesh Nerlige Ramappa
Now that we may have multiple OA units in a single GT as well as on separate GTs, create an engine group that maps to a single OA unit. v2: (Jani) - Drop warning on ENOMEM - Reorder patch in the series v3: (Ashutosh) - Remove unused members from perf structs - Update comments - Update

[Intel-gfx] [PATCH v5 00/12] Add OAM support for MTL

2023-03-15 Thread Umesh Nerlige Ramappa
The OAM unit captures OA reports specific to the media engines. Add support to program the OAM unit on media tile on MTL. The OAM unit is selected by passing the class:instance of a media engine to perf parameters. Corresponding UMD changes are posted to the igt-dev repo as part of supporting the

[Intel-gfx] [PATCH v5 01/12] drm/i915/perf: Drop wakeref on GuC RC error

2023-03-15 Thread Umesh Nerlige Ramappa
From: Chris Wilson If we fail to adjust the GuC run-control on opening the perf stream, make sure we unwind the wakeref just taken. v2: Retain old goto label names (Ashutosh) Fixes: 01e742746785 ("drm/i915/guc: Support OA when Wa_16011777198 is enabled") Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Remove fallback to requested freq for SLPC

2023-03-15 Thread Dixit, Ashutosh
On Wed, 15 Mar 2023 02:50:17 -0700, Tvrtko Ursulin wrote: > > On 10/03/2023 00:59, Ashutosh Dixit wrote: > > The fallback to requested freq does not work for SLPC because SLPC does not > > use 'struct intel_rps'. Also for SLPC requested freq can only be obtained > > from a hw register after

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-15 Thread Tian, Kevin
> From: Alex Williamson > Sent: Thursday, March 16, 2023 6:53 AM > > On Wed, 8 Mar 2023 05:28:51 -0800 > Yi Liu wrote: > > > This is another method to issue PCI hot reset for the users that bounds > > device to a positive iommufd value. In such case, iommufd is a proof of > > device

Re: [Intel-gfx] [PATCH v5 00/19] Add vfio_device cdev for iommufd support

2023-03-15 Thread Nicolin Chen
On Tue, Mar 14, 2023 at 11:38:11AM +, Shameerali Kolothum Thodi wrote: > Hi Nicolin, > > I rebased your latest Qemu branch[1] on top of v7.2.0 and not observed > the above issue so far. However noticed couple of other issues when > we try to hot add/remove devices. > > (qemu) device_del

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix format for perf_limit_reasons

2023-03-15 Thread Patchwork
== Series Details == Series: drm/i915: Fix format for perf_limit_reasons URL : https://patchwork.freedesktop.org/series/115160/ State : success == Summary == CI Bug Log - changes from CI_DRM_12857_full -> Patchwork_115160v1_full Summary

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-15 Thread Alex Williamson
On Wed, 8 Mar 2023 05:28:51 -0800 Yi Liu wrote: > This is another method to issue PCI hot reset for the users that bounds > device to a positive iommufd value. In such case, iommufd is a proof of > device ownership. By passing a zero-length fd array, user indicates kernel > to do ownership

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Allow for very slow GuC loading

2023-03-15 Thread Ceraolo Spurio, Daniele
On 3/10/2023 5:01 PM, John Harrison wrote: On 3/3/2023 11:20, Ceraolo Spurio, Daniele wrote: On 2/17/2023 3:47 PM, john.c.harri...@intel.com wrote: From: John Harrison A failure to load the GuC is occasionally observed where the GuC log actually showed that the GuC had loaded just fine.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pxp: limit drm-errors or warning on firmware API failures (rev2)

2023-03-15 Thread Patchwork
== Series Details == Series: drm/i915/pxp: limit drm-errors or warning on firmware API failures (rev2) URL : https://patchwork.freedesktop.org/series/113680/ State : success == Summary == CI Bug Log - changes from CI_DRM_12857_full -> Patchwork_113680v2_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Plane cleanups and extra registers

2023-03-15 Thread Patchwork
== Series Details == Series: drm/i915: Plane cleanups and extra registers URL : https://patchwork.freedesktop.org/series/115127/ State : success == Summary == CI Bug Log - changes from CI_DRM_12857_full -> Patchwork_115127v1_full Summary

Re: [Intel-gfx] [BUG 6.3-rc1] Bad lock in ttm_bo_delayed_delete()

2023-03-15 Thread Steven Rostedt
On Wed, 15 Mar 2023 20:51:49 +0100 Christian König wrote: > Steven please try the attached patch. I applied it, but as it's not always reproducible, I'll have to give it several runs before I give you my "tested-by" tag. -- Steve

Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Use actual period when calculating client busyness

2023-03-15 Thread Umesh Nerlige Ramappa
On Wed, Mar 15, 2023 at 09:20:49AM +, Tvrtko Ursulin wrote: Hi Umesh, On 14/03/2023 18:25, Umesh Nerlige Ramappa wrote: lgtm, Reviewed-by: Umesh Nerlige Ramappa Thanks - I had one second thought though. See below please. On Tue, Mar 14, 2023 at 12:17:40PM +, Tvrtko Ursulin

Re: [Intel-gfx] [BUG 6.3-rc1] Bad lock in ttm_bo_delayed_delete()

2023-03-15 Thread Christian König
Am 15.03.23 um 20:15 schrieb Matthew Auld: On Wed, 15 Mar 2023 at 18:41, Christian König wrote: Am 08.03.23 um 13:43 schrieb Steven Rostedt: On Wed, 8 Mar 2023 07:17:38 +0100 Christian König wrote: What test case/environment do you run to trigger this? I'm running a 32bit x86 qemu

[Intel-gfx] ✓ Fi.CI.IGT: success for Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes (rev12)

2023-03-15 Thread Patchwork
== Series Details == Series: Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes (rev12) URL : https://patchwork.freedesktop.org/series/107550/ State : success == Summary == CI Bug Log - changes from CI_DRM_12857_full -> Patchwork_107550v12_full

Re: [Intel-gfx] [PATCH v2 01/27] drm/i915/gvt: Verify pfn is "valid" before dereferencing "struct page"

2023-03-15 Thread Sean Christopherson
On Wed, Mar 15, 2023, Andrzej Hajda wrote: > On 13.03.2023 16:37, Wang, Wei W wrote: > > On Saturday, March 11, 2023 8:23 AM, Sean Christopherson wrote: > > > diff --git a/drivers/gpu/drm/i915/gvt/gtt.c > > > b/drivers/gpu/drm/i915/gvt/gtt.c > > > index 4ec85308379a..58b9b316ae46 100644 > > > ---

Re: [Intel-gfx] [BUG 6.3-rc1] Bad lock in ttm_bo_delayed_delete()

2023-03-15 Thread Matthew Auld
On Wed, 15 Mar 2023 at 18:41, Christian König wrote: > > Am 08.03.23 um 13:43 schrieb Steven Rostedt: > > On Wed, 8 Mar 2023 07:17:38 +0100 > > Christian König wrote: > > > >> What test case/environment do you run to trigger this? > > I'm running a 32bit x86 qemu instance. Attached is the

[Intel-gfx] ✓ Fi.CI.IGT: success for DP2.0 SDP CRC16 for 128/132b link layer (rev5)

2023-03-15 Thread Patchwork
== Series Details == Series: DP2.0 SDP CRC16 for 128/132b link layer (rev5) URL : https://patchwork.freedesktop.org/series/113134/ State : success == Summary == CI Bug Log - changes from CI_DRM_12829_full -> Patchwork_113134v5_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: keep same cache settings as timeline (rev2)

2023-03-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: keep same cache settings as timeline (rev2) URL : https://patchwork.freedesktop.org/series/114879/ State : success == Summary == CI Bug Log - changes from CI_DRM_12864 -> Patchwork_114879v2

Re: [Intel-gfx] [BUG 6.3-rc1] Bad lock in ttm_bo_delayed_delete()

2023-03-15 Thread Christian König
Am 08.03.23 um 13:43 schrieb Steven Rostedt: On Wed, 8 Mar 2023 07:17:38 +0100 Christian König wrote: What test case/environment do you run to trigger this? I'm running a 32bit x86 qemu instance. Attached is the config. The libvirt xml file is here:

Re: [Intel-gfx] [BUG 6.3-rc1] Bad lock in ttm_bo_delayed_delete()

2023-03-15 Thread Christian König
Am 15.03.23 um 18:31 schrieb Steven Rostedt: On Wed, 15 Mar 2023 11:57:12 -0400 Steven Rostedt wrote: So I'm looking at the backtraces. The WARN_ON triggered: [ 21.481449] mpls_gso: MPLS GSO support [ 21.488795] IPI shorthand broadcast: enabled [ 21.488873] [ cut here

Re: [Intel-gfx] [BUG 6.3-rc1] Bad lock in ttm_bo_delayed_delete()

2023-03-15 Thread Christian König
Am 15.03.23 um 18:54 schrieb Steven Rostedt: On Wed, 15 Mar 2023 11:57:12 -0400 Steven Rostedt wrote: The WARN_ON triggered: [ 21.481449] mpls_gso: MPLS GSO support [ 21.488795] IPI shorthand broadcast: enabled [ 21.488873] [ cut here ] [ 21.490101]

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: keep same cache settings as timeline (rev2)

2023-03-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: keep same cache settings as timeline (rev2) URL : https://patchwork.freedesktop.org/series/114879/ State : warning == Summary == Error: dim checkpatch failed 7fda45cf3e09 drm/i915/selftests: keep same cache settings as timeline -:42:

Re: [Intel-gfx] [PATCH v2 01/27] drm/i915/gvt: Verify pfn is "valid" before dereferencing "struct page"

2023-03-15 Thread Andrzej Hajda
On 13.03.2023 16:37, Wang, Wei W wrote: On Saturday, March 11, 2023 8:23 AM, Sean Christopherson wrote: diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c index 4ec85308379a..58b9b316ae46 100644 --- a/drivers/gpu/drm/i915/gvt/gtt.c +++ b/drivers/gpu/drm/i915/gvt/gtt.c

[Intel-gfx] [PATCH] drm/i915/selftests: keep same cache settings as timeline

2023-03-15 Thread fei . yang
From: Fei Yang On MTL, objects allocated through i915_gem_object_create_internal() are mapped as uncached in GPU by default because HAS_LLC is false. However in the live_hwsp_read selftest these watcher objects are mapped as WB on CPU side. The conseqence is that the updates done by the GPU are

Re: [Intel-gfx] [PATCH 5.4.y] drm/i915: Don't use BAR mappings for ring buffers with LLC

2023-03-15 Thread Greg KH
On Wed, Mar 15, 2023 at 10:07:53AM -0700, John Harrison wrote: > On 3/15/2023 00:51, Greg KH wrote: > > On Mon, Mar 13, 2023 at 07:22:11PM -0700, john.c.harri...@intel.com wrote: > > > From: John Harrison > > > > > > Direction from hardware is that ring buffers should never be mapped > > > via

Re: [Intel-gfx] [BUG 6.3-rc1] Bad lock in ttm_bo_delayed_delete()

2023-03-15 Thread Steven Rostedt
On Wed, 15 Mar 2023 11:57:12 -0400 Steven Rostedt wrote: > The WARN_ON triggered: > > [ 21.481449] mpls_gso: MPLS GSO support > [ 21.488795] IPI shorthand broadcast: enabled > [ 21.488873] [ cut here ] > [ 21.490101] [ cut here ] > > [

Re: [Intel-gfx] [BUG 6.3-rc1] Bad lock in ttm_bo_delayed_delete()

2023-03-15 Thread Steven Rostedt
On Wed, 15 Mar 2023 11:57:12 -0400 Steven Rostedt wrote: So I'm looking at the backtraces. > The WARN_ON triggered: > > [ 21.481449] mpls_gso: MPLS GSO support > [ 21.488795] IPI shorthand broadcast: enabled > [ 21.488873] [ cut here ] > [ 21.490101]

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Update engine_init_common documentation (rev3)

2023-03-15 Thread Patchwork
== Series Details == Series: drm/i915/gt: Update engine_init_common documentation (rev3) URL : https://patchwork.freedesktop.org/series/114926/ State : success == Summary == CI Bug Log - changes from CI_DRM_12864 -> Patchwork_114926v3

Re: [Intel-gfx] [PATCH 5.4.y] drm/i915: Don't use BAR mappings for ring buffers with LLC

2023-03-15 Thread John Harrison
On 3/15/2023 00:51, Greg KH wrote: On Mon, Mar 13, 2023 at 07:22:11PM -0700, john.c.harri...@intel.com wrote: From: John Harrison Direction from hardware is that ring buffers should never be mapped via the BAR on systems with LLC. There are too many caching pitfalls due to the way BAR

Re: [Intel-gfx] [PATCH v2 20/27] KVM: x86/mmu: Use page-track notifiers iff there are external users

2023-03-15 Thread Sean Christopherson
On Wed, Mar 15, 2023, Yan Zhao wrote: > On Fri, Mar 10, 2023 at 04:22:51PM -0800, Sean Christopherson wrote: > > Disable the page-track notifier code at compile time if there are no > > external users, i.e. if CONFIG_KVM_EXTERNAL_WRITE_TRACKING=n. KVM itself > > now hooks emulated writes directly

Re: [Intel-gfx] [PATCH v2 20/27] KVM: x86/mmu: Use page-track notifiers iff there are external users

2023-03-15 Thread Sean Christopherson
On Wed, Mar 15, 2023, Yan Zhao wrote: > Nit: there is a typo in the commit header: "iff" -> "if" > > > -void kvm_page_track_write(struct kvm_vcpu *vcpu, gpa_t gpa, const u8 *new, > > - int bytes) > > +void __kvm_page_track_write(struct kvm *kvm, gpa_t gpa, const u8 *new, int

Re: [Intel-gfx] [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-15 Thread Rob Clark
On Wed, Mar 15, 2023 at 6:53 AM Jonas Ådahl wrote: > > On Fri, Mar 10, 2023 at 09:38:18AM -0800, Rob Clark wrote: > > On Fri, Mar 10, 2023 at 7:45 AM Jonas Ådahl wrote: > > > > > > On Wed, Mar 08, 2023 at 07:52:52AM -0800, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > Add a way to

[Intel-gfx] ✗ Fi.CI.IGT: failure for dma-fence: Deadline awareness

2023-03-15 Thread Patchwork
== Series Details == Series: dma-fence: Deadline awareness URL : https://patchwork.freedesktop.org/series/114863/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12829_full -> Patchwork_114863v1_full Summary ---

Re: [Intel-gfx] [BUG 6.3-rc1] Bad lock in ttm_bo_delayed_delete()

2023-03-15 Thread Steven Rostedt
On Wed, 15 Mar 2023 16:25:11 +0100 Christian König wrote: > >> > >> Thanks for the notice, > > I'm still getting this on Linus's latest tree. > > This must be some reference counting issue which only happens in your > particular use case. We have tested this quite extensively and couldn't

Re: [Intel-gfx] [PATCH v2 14/27] KVM: x86: Reject memslot MOVE operations if KVMGT is attached

2023-03-15 Thread Sean Christopherson
On Wed, Mar 15, 2023, Yan Zhao wrote: > On Fri, Mar 10, 2023 at 04:22:45PM -0800, Sean Christopherson wrote: > > Disallow moving memslots if the VM has external page-track users, i.e. if > > KVMGT is being used to expose a virtual GPU to the guest, as KVM doesn't > > correctly handle moving memory

Re: [Intel-gfx] [PATCH v2 11/27] KVM: x86/mmu: Don't rely on page-track mechanism to flush on memslot change

2023-03-15 Thread Sean Christopherson
On Wed, Mar 15, 2023, Yan Zhao wrote: > On Fri, Mar 10, 2023 at 04:22:42PM -0800, Sean Christopherson wrote: > ... > > -static void kvm_mmu_invalidate_zap_pages_in_memslot(struct kvm *kvm, > > - struct kvm_memory_slot *slot, > > - struct

Re: [Intel-gfx] [PATCH v2] drm/i915/mtl: Disable stolen memory backed FB for A0

2023-03-15 Thread Andrzej Hajda
On 10.03.2023 10:45, Nirmoy Das wrote: Stolen memory is not usable for MTL A0 stepping beyond certain access size and we have no control over userspace access size of /dev/fb which can be backed by stolen memory. So disable stolen memory backed fb by setting i915->dsm.usable_size to zero. v2:

Re: [Intel-gfx] [BUG 6.3-rc1] Bad lock in ttm_bo_delayed_delete()

2023-03-15 Thread Christian König
Am 15.03.23 um 16:09 schrieb Steven Rostedt: On Wed, 8 Mar 2023 07:17:38 +0100 Christian König wrote: Am 08.03.23 um 03:26 schrieb Steven Rostedt: On Tue, 7 Mar 2023 21:22:23 -0500 Steven Rostedt wrote: Looks like there was a lock possibly used after free. But as commit

Re: [Intel-gfx] [PATCH v2 19/27] KVM: x86/mmu: Move KVM-only page-track declarations to internal header

2023-03-15 Thread Sean Christopherson
On Wed, Mar 15, 2023, Yan Zhao wrote: > On Fri, Mar 10, 2023 at 04:22:50PM -0800, Sean Christopherson wrote: > > Bury the declaration of the page-track helpers that are intended only for > > internal KVM use in a "private" header. In addition to guarding against > > unwanted usage of the

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/mtl: Disable stolen memory backed FB for A0 (rev2)

2023-03-15 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Disable stolen memory backed FB for A0 (rev2) URL : https://patchwork.freedesktop.org/series/114925/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12836 -> Patchwork_114925v2

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: keep same cache settings as timeline

2023-03-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: keep same cache settings as timeline URL : https://patchwork.freedesktop.org/series/114879/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12829 -> Patchwork_114879v1 Summary

Re: [Intel-gfx] [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-15 Thread Jonas Ådahl
On Fri, Mar 10, 2023 at 09:38:18AM -0800, Rob Clark wrote: > On Fri, Mar 10, 2023 at 7:45 AM Jonas Ådahl wrote: > > > > On Wed, Mar 08, 2023 at 07:52:52AM -0800, Rob Clark wrote: > > > From: Rob Clark > > > > > > Add a way to hint to the fence signaler of an upcoming deadline, such as > > >

Re: [Intel-gfx] [PATCH v13 01/10] drm/shmem-helper: Switch to reservation lock

2023-03-15 Thread Dmitry Osipenko
On 3/14/23 05:26, Dmitry Osipenko wrote: > @@ -633,7 +605,10 @@ int drm_gem_shmem_mmap(struct drm_gem_shmem_object > *shmem, struct vm_area_struct > return ret; > } > > + dma_resv_lock(shmem->base.resv, NULL); > ret = drm_gem_shmem_get_pages(shmem); > +

Re: [Intel-gfx] [RFC 01/10] drm: Track clients by tgid and not tid

2023-03-15 Thread Christian König
Am 15.03.23 um 10:52 schrieb Tvrtko Ursulin: Hi, On 14/03/2023 15:33, Christian König wrote: Am 14.03.23 um 15:18 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Thread group id (aka pid from userspace point of view) is a more interesting thing to show as an owner of a DRM fd, so track and

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Clarify seemingly unaccounted obj refcount inc

2023-03-15 Thread Patchwork
== Series Details == Series: drm/i915/gem: Clarify seemingly unaccounted obj refcount inc URL : https://patchwork.freedesktop.org/series/115182/ State : success == Summary == CI Bug Log - changes from CI_DRM_12864 -> Patchwork_115182v1

[Intel-gfx] ✓ Fi.CI.IGT: success for High refresh rate PSR fixes

2023-03-15 Thread Patchwork
== Series Details == Series: High refresh rate PSR fixes URL : https://patchwork.freedesktop.org/series/115109/ State : success == Summary == CI Bug Log - changes from CI_DRM_12853_full -> Patchwork_115109v1_full Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/mtl: Add C10 and C20 phy support (rev7)

2023-03-15 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add C10 and C20 phy support (rev7) URL : https://patchwork.freedesktop.org/series/109714/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/109714/revisions/7/mbox/ not applied Applying: drm/i915/mtl:

[Intel-gfx] [PATCH 5.10 080/104] drm/i915: Dont use BAR mappings for ring buffers with LLC

2023-03-15 Thread Greg Kroah-Hartman
From: John Harrison commit 85636167e3206c3fbd52254fc432991cc4e90194 upstream. Direction from hardware is that ring buffers should never be mapped via the BAR on systems with LLC. There are too many caching pitfalls due to the way BAR accesses are routed. So it is safest to just not use it.

  1   2   >