Re: [Intel-gfx] [PATCH v6 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2023-03-27 Thread Kandpal, Suraj
> -Original Message- > From: Mark Yacoub > Sent: Saturday, March 25, 2023 12:57 AM > To: Kandpal, Suraj > Cc: quic_khs...@quicinc.com; linux-arm-...@vger.kernel.org; dri- > de...@lists.freedesktop.org; freedr...@lists.freedesktop.org; > devicet...@vger.kernel.org;

Re: [Intel-gfx] [PATCH v3 1/6] iommu/iommufd: Pass iommufd_ctx pointer in iommufd_get_ioas()

2023-03-27 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Monday, March 27, 2023 5:34 PM > > no need to pass the iommufd_ucmd pointer. > > Signed-off-by: Yi Liu Reviewed-by: Kevin Tian

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/display: Restore dsparb_lock.

2023-03-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: Restore dsparb_lock. URL : https://patchwork.freedesktop.org/series/115675/ State : success == Summary == CI Bug Log - changes from CI_DRM_12921_full -> Patchwork_115675v1_full

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/ips: Make IPS debugfs per-crtc

2023-03-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/ips: Make IPS debugfs per-crtc URL : https://patchwork.freedesktop.org/series/115669/ State : success == Summary == CI Bug Log - changes from CI_DRM_12921_full -> Patchwork_115669v1_full

Re: [Intel-gfx] [PATCH v6 05/24] kvm/vfio: Accept vfio device file from userspace

2023-03-27 Thread Liu, Yi L
> From: Xu, Yilun > Sent: Wednesday, March 22, 2023 10:11 PM > > On 2023-03-08 at 05:28:44 -0800, Yi Liu wrote: > > This defines KVM_DEV_VFIO_FILE* and make alias with > KVM_DEV_VFIO_GROUP*. > > Old userspace uses KVM_DEV_VFIO_GROUP* works as well. > > > > Signed-off-by: Yi Liu > > Reviewed-by:

Re: [Intel-gfx] [PATCH v2 10/10] vfio/pci: Add VFIO_DEVICE_GET_PCI_HOT_RESET_GROUP_INFO

2023-03-27 Thread Liu, Yi L
> From: Alex Williamson > Sent: Tuesday, March 28, 2023 4:41 AM > > On Mon, 27 Mar 2023 13:26:19 -0600 > Alex Williamson wrote: > [...] > > > diff --git a/drivers/vfio/pci/vfio_pci_core.c > b/drivers/vfio/pci/vfio_pci_core.c > > > index 19f5b075d70a..45edf4e9b98b 100644 > > > ---

Re: [Intel-gfx] [PATCH v2 10/10] vfio/pci: Add VFIO_DEVICE_GET_PCI_HOT_RESET_GROUP_INFO

2023-03-27 Thread Liu, Yi L
> From: Alex Williamson > Sent: Tuesday, March 28, 2023 3:26 AM > > On Mon, 27 Mar 2023 02:34:58 -0700 > Yi Liu wrote: > > > This is a preparation for vfio device cdev as cdev gives userspace the > > capability to open device cdev fd and management stack (e.g. libvirt) > > could pass the

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/3] drm/i915: Add a function to mmap framebuffer obj (rev2)

2023-03-27 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Add a function to mmap framebuffer obj (rev2) URL : https://patchwork.freedesktop.org/series/115542/ State : success == Summary == CI Bug Log - changes from CI_DRM_12921_full -> Patchwork_115542v2_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2,core-for-CI] Revert "Revert "drm/i915: Don't select BROKEN"" (rev2)

2023-03-27 Thread Patchwork
== Series Details == Series: series starting with [1/2,core-for-CI] Revert "Revert "drm/i915: Don't select BROKEN"" (rev2) URL : https://patchwork.freedesktop.org/series/115659/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12921_full -> Patchwork_115659v2_full

[Intel-gfx] [PATCH i-g-t 2/2] i915_pm_freq_api: Add some basic SLPC igt tests

2023-03-27 Thread Vinay Belgaumkar
Validate basic api for GT freq control. Also test interaction with GT reset. We skip rps tests with SLPC enabled, this will re-introduce some coverage. SLPC selftests are already covering some other workload related scenarios. v2: Rename test (Rodrigo) Cc: Rodrigo Vivi Signed-off-by: Vinay

[Intel-gfx] [PATCH i-g-t 1/2] lib/debugfs: Add per GT debugfs helpers

2023-03-27 Thread Vinay Belgaumkar
These can be used to open per-gt debugfs files. Signed-off-by: Tvrtko Ursulin Signed-off-by: Vinay Belgaumkar --- lib/igt_debugfs.c | 60 +++ lib/igt_debugfs.h | 4 2 files changed, 64 insertions(+) diff --git a/lib/igt_debugfs.c

[Intel-gfx] [PATCH i-g-t 0/2] tests/slpc: Add basic IGT test

2023-03-27 Thread Vinay Belgaumkar
Borrow some subtests from xe_guc_pc. Also add per GT debugfs helpers. Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (2): lib/debugfs: Add per GT debugfs helpers i915_pm_freq_api: Add some basic SLPC igt tests lib/igt_debugfs.c | 60 ++ lib/igt_debugfs.h

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform

2023-03-27 Thread Zhang, Rui
On Tue, 2023-03-28 at 09:14 +0800, Zhang Rui wrote: > Hi, Imre, > > Thanks for raising this. > > On Tue, 2023-03-28 at 00:26 +0300, Imre Deak wrote: > > Hi Rui, > > > > after applying your > > "x86/topology: fix erroneous smp_num_siblings on Intel Hybrid > > platform" > > > > fix on the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Fix MTL stolen memory GGTT mapping

2023-03-27 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Fix MTL stolen memory GGTT mapping URL : https://patchwork.freedesktop.org/series/115695/ State : success == Summary == CI Bug Log - changes from CI_DRM_12923 -> Patchwork_115695v1 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: Fix MTL stolen memory GGTT mapping

2023-03-27 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Fix MTL stolen memory GGTT mapping URL : https://patchwork.freedesktop.org/series/115695/ State : warning == Summary == Error: dim checkpatch failed 290c1809ab31 drm/i915/mtl: Fix MTL stolen memory GGTT mapping -:49: WARNING:AVOID_BUG: Do not crash

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: Add Support for C10 chips

2023-03-27 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add Support for C10 chips URL : https://patchwork.freedesktop.org/series/115664/ State : success == Summary == CI Bug Log - changes from CI_DRM_12921_full -> Patchwork_115664v1_full Summary

[Intel-gfx] [PATCH] drm/i915/mtl: Fix MTL stolen memory GGTT mapping

2023-03-27 Thread Daniele Ceraolo Spurio
The PTEs expect the offset from the base of the fake LMEM region (i.e. the base of stolen) and not from the base of the DSM. Quoting the specs: "Driver will set the Device Memory bit = 1 in the PTE when pointing to a page in DSM and program the PTE with offset from LMEM_BAR. Device Memory Offset

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform

2023-03-27 Thread Zhang, Rui
Hi, Imre, Thanks for raising this. On Tue, 2023-03-28 at 00:26 +0300, Imre Deak wrote: > Hi Rui, > > after applying your > "x86/topology: fix erroneous smp_num_siblings on Intel Hybrid > platform" > > fix on the drm-tip tree (see the patchwork URL below) the CI tests > show > some regression

Re: [Intel-gfx] [PATCH i-g-t 2/2] i915_guc_pc: Add some basic SLPC igt tests

2023-03-27 Thread Belgaumkar, Vinay
On 3/26/2023 4:04 AM, Rodrigo Vivi wrote: On Fri, Mar 24, 2023 at 03:49:59PM -0700, Vinay Belgaumkar wrote: Use the xe_guc_pc test for i915 as well. Validate basic api for GT freq control. Also test interaction with GT reset. We skip rps tests with SLPC enabled, this will re-introduce some

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/xe_guc_pc: Restore max freq first

2023-03-27 Thread Belgaumkar, Vinay
On 3/26/2023 3:51 AM, Rodrigo Vivi wrote: On Fri, Mar 24, 2023 at 05:34:42PM -0700, Vinay Belgaumkar wrote: When min/max are both at RPn, restoring min back to 300 will not work. Max needs to be increased first. why max needs to come first in this case? we should probably at least document

[Intel-gfx] ✓ Fi.CI.BAT: success for Report MMIO communication problems more clearly (rev3)

2023-03-27 Thread Patchwork
== Series Details == Series: Report MMIO communication problems more clearly (rev3) URL : https://patchwork.freedesktop.org/series/115421/ State : success == Summary == CI Bug Log - changes from CI_DRM_12922 -> Patchwork_115421v3 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/display: Restore dsparb_lock.

2023-03-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: Restore dsparb_lock. URL : https://patchwork.freedesktop.org/series/115675/ State : success == Summary == CI Bug Log - changes from CI_DRM_12921 -> Patchwork_115675v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/display: Restore dsparb_lock.

2023-03-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: Restore dsparb_lock. URL : https://patchwork.freedesktop.org/series/115675/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform

2023-03-27 Thread Imre Deak
Hi Rui, after applying your "x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform" fix on the drm-tip tree (see the patchwork URL below) the CI tests show some regression on a HSW and a KBL machine (see [2] and [4] below) in the i915 driver. However I think they can't be related

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/ips: Make IPS debugfs per-crtc

2023-03-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/ips: Make IPS debugfs per-crtc URL : https://patchwork.freedesktop.org/series/115669/ State : success == Summary == CI Bug Log - changes from CI_DRM_12921 -> Patchwork_115669v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/ips: Make IPS debugfs per-crtc

2023-03-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/ips: Make IPS debugfs per-crtc URL : https://patchwork.freedesktop.org/series/115669/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v2 10/10] vfio/pci: Add VFIO_DEVICE_GET_PCI_HOT_RESET_GROUP_INFO

2023-03-27 Thread Alex Williamson
On Mon, 27 Mar 2023 13:26:19 -0600 Alex Williamson wrote: > On Mon, 27 Mar 2023 02:34:58 -0700 > Yi Liu wrote: > > > This is a preparation for vfio device cdev as cdev gives userspace the > > capability to open device cdev fd and management stack (e.g. libvirt) > > could pass the device fd to

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm/i915: Add a function to mmap framebuffer obj (rev2)

2023-03-27 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Add a function to mmap framebuffer obj (rev2) URL : https://patchwork.freedesktop.org/series/115542/ State : success == Summary == CI Bug Log - changes from CI_DRM_12921 -> Patchwork_115542v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/3] drm/i915: Add a function to mmap framebuffer obj (rev2)

2023-03-27 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Add a function to mmap framebuffer obj (rev2) URL : https://patchwork.freedesktop.org/series/115542/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] drm/i915: Add a function to mmap framebuffer obj (rev2)

2023-03-27 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Add a function to mmap framebuffer obj (rev2) URL : https://patchwork.freedesktop.org/series/115542/ State : warning == Summary == Error: dim checkpatch failed 895e3b7fd231 drm/i915: Add a function to mmap framebuffer obj

Re: [Intel-gfx] [PATCH v2 5/6] drm/i915/vrr: Relocate VRR enable/disable

2023-03-27 Thread Golani, Mitulkumar Ajitkumar
Hi Ville, > -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: 21 March 2023 19:26 > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 5/6] drm/i915/vrr: Relocate VRR enable/disable > > From: Ville Syrjälä > > Move VRR enabling/disabling into

[Intel-gfx] [PATCH v3 2/2] drm/i915: Check for unreliable MMIO during forcewake

2023-03-27 Thread Andi Shyti
From: Matt Roper Although we now sanitycheck MMIO access during driver load to make sure the MMIO BAR isn't returning all 0x, there have been a few cases where (temporarily?) unreliable MMIO access has happened after GPU resets or power events. We'll often notice this on our next GT

[Intel-gfx] [PATCH v3 1/2] drm/i915: Sanitycheck MMIO access early in driver load

2023-03-27 Thread Andi Shyti
From: Matt Roper We occasionally see the PCI device in a non-accessible state at the point the driver is loaded. When this happens, all BAR accesses will read back as 0x. Rather than reading registers and misinterpreting their (invalid) values, let's specifically check for 0x

[Intel-gfx] [PATCH v3 0/2] Report MMIO communication problems more clearly

2023-03-27 Thread Andi Shyti
Hi, just copy pasting Matt's original cover letter. Thank you Andrzej and Jani for looking into this series. We're periodically facing problems in CI where all registers read back as 0x. In general this is what happens when the CPU is unable to communicate with a PCI device, so the

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2,core-for-CI] Revert "Revert "drm/i915: Don't select BROKEN"" (rev2)

2023-03-27 Thread Patchwork
== Series Details == Series: series starting with [1/2,core-for-CI] Revert "Revert "drm/i915: Don't select BROKEN"" (rev2) URL : https://patchwork.freedesktop.org/series/115659/ State : success == Summary == CI Bug Log - changes from CI_DRM_12921 -> Patchwork_115659v2

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2,core-for-CI] Revert "Revert "drm/i915: Don't select BROKEN"" (rev2)

2023-03-27 Thread Patchwork
== Series Details == Series: series starting with [1/2,core-for-CI] Revert "Revert "drm/i915: Don't select BROKEN"" (rev2) URL : https://patchwork.freedesktop.org/series/115659/ State : warning == Summary == Error: dim checkpatch failed c97f32bab9eb Revert "Revert "drm/i915: Don't select

Re: [Intel-gfx] [PATCH v2 10/10] vfio/pci: Add VFIO_DEVICE_GET_PCI_HOT_RESET_GROUP_INFO

2023-03-27 Thread Alex Williamson
On Mon, 27 Mar 2023 02:34:58 -0700 Yi Liu wrote: > This is a preparation for vfio device cdev as cdev gives userspace the > capability to open device cdev fd and management stack (e.g. libvirt) > could pass the device fd to the actual user (e.g. QEMU). As a result, > the actual user has no idea

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Add Support for C10 chips

2023-03-27 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add Support for C10 chips URL : https://patchwork.freedesktop.org/series/115664/ State : success == Summary == CI Bug Log - changes from CI_DRM_12921 -> Patchwork_115664v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: Add Support for C10 chips

2023-03-27 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add Support for C10 chips URL : https://patchwork.freedesktop.org/series/115664/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: Add Support for C10 chips

2023-03-27 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add Support for C10 chips URL : https://patchwork.freedesktop.org/series/115664/ State : warning == Summary == Error: dim checkpatch failed acf3d3886bcc drm/i915/mtl: Initial DDI port setup fa367a60b5f5 drm/i915/mtl: Add DP rates dd49f2562c22

Re: [Intel-gfx] [PATCH v10 00/15] dma-fence: Deadline awareness

2023-03-27 Thread Matt Turner
On Wed, Mar 8, 2023 at 10:53 AM Rob Clark wrote: > > From: Rob Clark > > This series adds a deadline hint to fences, so realtime deadlines > such as vblank can be communicated to the fence signaller for power/ > frequency management decisions. > > This is partially inspired by a trick i915 does,

[Intel-gfx] ✗ Fi.CI.BAT: failure for x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform

2023-03-27 Thread Patchwork
== Series Details == Series: x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform URL : https://patchwork.freedesktop.org/series/115661/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12921 -> Patchwork_115661v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform

2023-03-27 Thread Patchwork
== Series Details == Series: x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform URL : https://patchwork.freedesktop.org/series/115661/ State : warning == Summary == Error: dim checkpatch failed e89219f0529c x86/topology: fix erroneous smp_num_siblings on Intel Hybrid

Re: [Intel-gfx] [PATCH v8 00/24] Add vfio_device cdev for iommufd support

2023-03-27 Thread Nicolin Chen
On Mon, Mar 27, 2023 at 02:40:23AM -0700, Yi Liu wrote: > External email: Use caution opening links or attachments > > > Existing VFIO provides group-centric user APIs for userspace. Userspace > opens the /dev/vfio/$group_id first before getting device fd and hence > getting access to device.

Re: [Intel-gfx] [PATCH v3 0/6] vfio: Make emulated devices prepared for vfio device cdev

2023-03-27 Thread Nicolin Chen
On Mon, Mar 27, 2023 at 02:33:45AM -0700, Yi Liu wrote: > External email: Use caution opening links or attachments > > > The .bind_iommufd op of vfio emulated devices are either empty or does > nothing. This is different with the vfio physical devices, to add vfio > device cdev, need to make

Re: [Intel-gfx] [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-27 Thread Rodrigo Vivi
+Daniel On Mon, Mar 27, 2023 at 09:58:52AM -0700, Dixit, Ashutosh wrote: > On Sun, 26 Mar 2023 04:52:59 -0700, Rodrigo Vivi wrote: > > > > Hi Rodrigo, > > > On Fri, Mar 24, 2023 at 04:31:22PM -0700, Dixit, Ashutosh wrote: > > > On Fri, 24 Mar 2023 11:15:02 -0700, Belgaumkar, Vinay wrote: > >

Re: [Intel-gfx] [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-27 Thread Dixit, Ashutosh
On Sun, 26 Mar 2023 04:52:59 -0700, Rodrigo Vivi wrote: > Hi Rodrigo, > On Fri, Mar 24, 2023 at 04:31:22PM -0700, Dixit, Ashutosh wrote: > > On Fri, 24 Mar 2023 11:15:02 -0700, Belgaumkar, Vinay wrote: > > > > > > > Hi Vinay, > > > > Thanks for the review. Comments inline below. > > > > > On

Re: [Intel-gfx] [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-27 Thread Dixit, Ashutosh
On Fri, 24 Mar 2023 17:06:33 -0700, Belgaumkar, Vinay wrote: > Hi Vinay, > On 3/24/2023 4:31 PM, Dixit, Ashutosh wrote: > > On Fri, 24 Mar 2023 11:15:02 -0700, Belgaumkar, Vinay wrote: > > Hi Vinay, > > > > Thanks for the review. Comments inline below. > Sorry about asking the same questions all

Re: [Intel-gfx] [PATCH v3 1/6] iommu/iommufd: Pass iommufd_ctx pointer in iommufd_get_ioas()

2023-03-27 Thread Jason Gunthorpe
On Mon, Mar 27, 2023 at 02:33:46AM -0700, Yi Liu wrote: > no need to pass the iommufd_ucmd pointer. > > Signed-off-by: Yi Liu > --- > drivers/iommu/iommufd/ioas.c| 14 +++--- > drivers/iommu/iommufd/iommufd_private.h | 4 ++-- > drivers/iommu/iommufd/selftest.c| 6

Re: [Intel-gfx] [PATCH v6 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-03-27 Thread Tvrtko Ursulin
On 27/03/2023 08:07, Lionel Landwerlin wrote: On 26/03/2023 14:18, Rodrigo Vivi wrote: On Sat, Mar 25, 2023 at 02:19:21AM -0400, Teres Alexis, Alan Previn wrote: alan:snip @@ -353,8 +367,20 @@ int intel_pxp_start(struct intel_pxp *pxp) alan:snip +    if (HAS_ENGINE(pxp->ctrl_gt, GSC0)) { + 

[Intel-gfx] ✓ Fi.CI.IGT: success for Introduce new methods for verifying ownership in vfio PCI hot reset (rev2)

2023-03-27 Thread Patchwork
== Series Details == Series: Introduce new methods for verifying ownership in vfio PCI hot reset (rev2) URL : https://patchwork.freedesktop.org/series/115264/ State : success == Summary == CI Bug Log - changes from CI_DRM_12918_full -> Patchwork_115264v2_full

[Intel-gfx] [PATCH 2/2] drm/i915/i9xx_wm: Prefer intel_de functions over intel_uncore.

2023-03-27 Thread Rodrigo Vivi
Let's get rid of the intel_uncore calls on display side. v2: Fix multiple CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis Cc: Jani Nikula Signed-off-by: Rodrigo Vivi Reviewed-by: Ville Syrjälä Link:

[Intel-gfx] [PATCH 1/2] drm/i915/display: Restore dsparb_lock.

2023-03-27 Thread Rodrigo Vivi
uncore->lock only protects the forcewake domain itself, not the register accesses. uncore's _fw alternatives are for cases where the domains are not needed because we are sure that they are already awake. So the move towards the uncore's _fw alternatives seems right, however using the

Re: [Intel-gfx] [PATCH 2/2] drm/i915/ips: Add i915_ips_false_color debugfs file

2023-03-27 Thread Jani Nikula
On Mon, 27 Mar 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Similar to FBC let's expose an debugfs file to control > IPS false color. Enabling this provides an immediate visual > feedback on whether IPS is working or not. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula >

Re: [Intel-gfx] [PATCH 1/2] drm/i915/ips: Make IPS debugfs per-crtc

2023-03-27 Thread Jani Nikula
On Mon, 27 Mar 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > IPS is a per-pipe feature, so let's move the debugfs stuff > under the crtc directory, and only register it when IPS > is actually available. > > Signed-off-by: Ville Syrjälä Yay! Reviewed-by: Jani Nikula > --- >

[Intel-gfx] ✓ Fi.CI.IGT: success for vfio: Make emulated devices prepared for vfio device cdev (rev4)

2023-03-27 Thread Patchwork
== Series Details == Series: vfio: Make emulated devices prepared for vfio device cdev (rev4) URL : https://patchwork.freedesktop.org/series/114846/ State : success == Summary == CI Bug Log - changes from CI_DRM_12918_full -> Patchwork_114846v4_full

Re: [Intel-gfx] [PATCH 1/2] [core-for-CI] Revert "Revert "drm/i915: Don't select BROKEN""

2023-03-27 Thread Rodrigo Vivi
On Mon, Mar 27, 2023 at 01:53:29PM +0300, Jani Nikula wrote: > This reverts commit 211c4b0aba30d2eab9690ad61944c7bf20b33c16. > > Drop the commit from the topic/core-for-CI branch. We no longer need to > select BROKEN to enable DRM_I915_UNSTABLE. > > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc:

Re: [Intel-gfx] [PATCH 2/2] drm/i915: remove unused config DRM_I915_UNSTABLE

2023-03-27 Thread Rodrigo Vivi
On Mon, Mar 27, 2023 at 01:53:30PM +0300, Jani Nikula wrote: > Essentially this is a revert of commit d9d54a530a70 ("drm/i915: Put > future HW and their uAPIs under STAGING & BROKEN"). > > We currently have no users for this config option. The last one was > removed in 8c26491f5853 ("drm/i915:

[Intel-gfx] [PATCH 2/2] drm/i915/ips: Add i915_ips_false_color debugfs file

2023-03-27 Thread Ville Syrjala
From: Ville Syrjälä Similar to FBC let's expose an debugfs file to control IPS false color. Enabling this provides an immediate visual feedback on whether IPS is working or not. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/hsw_ips.c| 58 ++-

[Intel-gfx] [PATCH 1/2] drm/i915/ips: Make IPS debugfs per-crtc

2023-03-27 Thread Ville Syrjala
From: Ville Syrjälä IPS is a per-pipe feature, so let's move the debugfs stuff under the crtc directory, and only register it when IPS is actually available. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/hsw_ips.c| 15 +++

Re: [Intel-gfx] [PATCH 24/29] drm/i915/tc: Don't connect the PHY in intel_tc_port_connected()

2023-03-27 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Thursday, March 23, 2023 4:21 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 24/29] drm/i915/tc: Don't connect the PHY in > intel_tc_port_connected() > > Connecting the PHY for connector

Re: [Intel-gfx] [core-for-CI] x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform

2023-03-27 Thread Saarinen, Jani
Hi, > -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: maanantai 27. maaliskuuta 2023 15.11 > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [core-for-CI] x86/topology: fix erroneous > smp_num_siblings on > Intel Hybrid platform > > From: Zhang Rui >

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2,core-for-CI] Revert "Revert "drm/i915: Don't select BROKEN""

2023-03-27 Thread Patchwork
== Series Details == Series: series starting with [1/2,core-for-CI] Revert "Revert "drm/i915: Don't select BROKEN"" URL : https://patchwork.freedesktop.org/series/115659/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12918 -> Patchwork_115659v1

Re: [Intel-gfx] [PATCH 23/29] drm/i915/tc: Get power ref for reading the HPD live status register

2023-03-27 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Thursday, March 23, 2023 4:20 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 23/29] drm/i915/tc: Get power ref for reading the > HPD live status register > > Enable the power required for the

[Intel-gfx] [PATCH 6/7] drm/i915/mtl: Add vswing programming for C10 phys

2023-03-27 Thread Mika Kahola
From: Radhakrishna Sripada C10 phys uses direct mapping internally for voltage and pre-emphasis levels. Program the levels directly to the fields in the VDR Registers. Bspec: 65449 v2: From table "C10: Tx EQ settings for DP 1.4x" it shows level 1 and preemphasis 1 instead of two times of

[Intel-gfx] [PATCH 7/7] drm/i915/mtl: Add support for PM DEMAND

2023-03-27 Thread Mika Kahola
Display14 introduces a new way to instruct the PUnit with power and bandwidth requirements of DE. Add the functionality to program the registers and handle waits using interrupts. The current wait time for timeouts is programmed for 10 msecs to factor in the worst case scenarios. Changes made to

[Intel-gfx] [PATCH 5/7] drm/i915/mtl: Add C10 phy programming for HDMI

2023-03-27 Thread Mika Kahola
From: Radhakrishna Sripada Like DG2, we still don't have a proper algorithm that can be used for calculating PHY settings, but we do have tables of register values for a handful of the more common link rates. Some support is better than none, so let's go ahead and add/use these tables when we

[Intel-gfx] [PATCH 4/7] drm/i915/mtl: Add Support for C10 PHY message bus and pll programming

2023-03-27 Thread Mika Kahola
From: Radhakrishna Sripada XELPDP has C10 and C20 phys from Synopsys to drive displays. Each phy has a dedicated PIPE 5.2 Message bus for configuration. This message bus is used to configure the phy internal registers. XELPDP has C10 phys to drive output to the EDP and the native output from

[Intel-gfx] [PATCH 3/7] drm/i915/mtl: Create separate reg file for PICA registers

2023-03-27 Thread Mika Kahola
Create a separate file to store registers for PICA chips C10 and C20. v2: Rename file (Jani) v3: Use _PICK_EVEN_2RANGES() macro (Lucas) Coding style fixed (Lucas) Signed-off-by: Radhakrishna Sripada Signed-off-by: Mika Kahola --- .../gpu/drm/i915/display/intel_cx0_phy_regs.h | 131

[Intel-gfx] [PATCH 2/7] drm/i915/mtl: Add DP rates

2023-03-27 Thread Mika Kahola
Add DP rates for Meteorlake. Signed-off-by: Radhakrishna Sripada Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/display/intel_dp.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c

[Intel-gfx] [PATCH 1/7] drm/i915/mtl: Initial DDI port setup

2023-03-27 Thread Mika Kahola
From: Clint Taylor Initialization sequences and C10 phy are in place to be able to enable the first 2 ports of MTL. The other ports use C20 phy that still need to be properly added. Enable the first ports for now, keeping a TODO comment about the others. Cc: Radhakrishna Sripada Reviewed-by:

[Intel-gfx] [PATCH 0/7] drm/i915/mtl: Add Support for C10 chips

2023-03-27 Thread Mika Kahola
Phy programming support for C10 PICA chips. This is the first part of the series that adds support for PICA chips. Later the support for C20 chips are added. Signed-off-by: Mika Kahola Clint Taylor (1): drm/i915/mtl: Initial DDI port setup Mika Kahola (3): drm/i915/mtl: Add DP rates

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2,core-for-CI] Revert "Revert "drm/i915: Don't select BROKEN""

2023-03-27 Thread Patchwork
== Series Details == Series: series starting with [1/2,core-for-CI] Revert "Revert "drm/i915: Don't select BROKEN"" URL : https://patchwork.freedesktop.org/series/115659/ State : warning == Summary == Error: dim checkpatch failed 90424153487a Revert "Revert "drm/i915: Don't select BROKEN""

Re: [Intel-gfx] [PATCH 22/29] drm/i915/adlp/tc: Use the DE HPD ISR register for hotplug detection

2023-03-27 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Thursday, March 23, 2023 4:20 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 22/29] drm/i915/adlp/tc: Use the DE HPD ISR > register for hotplug detection > > The spec says to use the CPU ISR

[Intel-gfx] [core-for-CI] x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform

2023-03-27 Thread Imre Deak
From: Zhang Rui The SMT siblings value returned by CPUID.1F SMT level EBX differs among CPUs on Intel Hybrid platforms like AlderLake and MeteorLake. It returns 2 for Pcore CPUs which have SMT siblings and returns 1 for Ecore CPUs which do not have SMT siblings. Today, the CPU boot code sets

[Intel-gfx] ✓ Fi.CI.BAT: success for Introduce new methods for verifying ownership in vfio PCI hot reset (rev2)

2023-03-27 Thread Patchwork
== Series Details == Series: Introduce new methods for verifying ownership in vfio PCI hot reset (rev2) URL : https://patchwork.freedesktop.org/series/115264/ State : success == Summary == CI Bug Log - changes from CI_DRM_12918 -> Patchwork_115264v2

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Add vfio_device cdev for iommufd support (rev9)

2023-03-27 Thread Patchwork
== Series Details == Series: Add vfio_device cdev for iommufd support (rev9) URL : https://patchwork.freedesktop.org/series/113696/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/113696/revisions/9/mbox/ not applied Applying: vfio: Allocate per

Re: [Intel-gfx] [PATCH 21/29] drm/i915/tc: Add TC PHY hook to init the PHY

2023-03-27 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Thursday, March 23, 2023 4:20 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 21/29] drm/i915/tc: Add TC PHY hook to init the > PHY > > Add a hook for platform specific PHY initialization.

Re: [Intel-gfx] [PATCH 20/29] drm/i915/tc: Add asserts in TC PHY hooks that the required power is on

2023-03-27 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Thursday, March 23, 2023 7:08 PM > To: Jani Nikula > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 20/29] drm/i915/tc: Add asserts in TC PHY > hooks > that the required power is on > > On

Re: [Intel-gfx] [PATCH 19/29] drm/i915/tc: Add TC PHY hook to get the TC-cold blocking power domain

2023-03-27 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Thursday, March 23, 2023 4:20 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 19/29] drm/i915/tc: Add TC PHY hook to get the TC- > cold blocking power domain > > Instead of the corresponding if

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-27 Thread Liu, Yi L
> From: Liu, Yi L > Sent: Friday, March 24, 2023 5:25 PM > > > From: Jason Gunthorpe > > Sent: Thursday, March 23, 2023 8:02 PM > > > > On Thu, Mar 23, 2023 at 03:15:20AM +, Liu, Yi L wrote: > > > > From: Jason Gunthorpe > > > > Sent: Wednesday, March 22, 2023 9:43 PM > > > > > > > > On

Re: [Intel-gfx] [PATCH 18/29] drm/i915/tc: Drop tc_cold_block()/unblock()'s power domain parameter

2023-03-27 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Thursday, March 23, 2023 4:20 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 18/29] drm/i915/tc: Drop > tc_cold_block()/unblock()'s > power domain parameter > > Simplify

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce new methods for verifying ownership in vfio PCI hot reset (rev2)

2023-03-27 Thread Patchwork
== Series Details == Series: Introduce new methods for verifying ownership in vfio PCI hot reset (rev2) URL : https://patchwork.freedesktop.org/series/115264/ State : warning == Summary == Error: dim checkpatch failed 498fb1274097 vfio/pci: Update comment around group_fd get in

Re: [Intel-gfx] [PATCH 17/29] drm/i915/tc: Remove redundant wakeref=0 check from unblock_tc_cold()

2023-03-27 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Thursday, March 23, 2023 4:20 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 17/29] drm/i915/tc: Remove redundant wakeref=0 > check from unblock_tc_cold() > > After the previous patch

Re: [Intel-gfx] [PATCH 16/29] drm/i915/tc: Block/unblock TC-cold in the PHY connect/disconnect hooks

2023-03-27 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Thursday, March 23, 2023 4:20 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 16/29] drm/i915/tc: Block/unblock TC-cold in the > PHY connect/disconnect hooks > > Move blocking/unblocking the

[Intel-gfx] ✓ Fi.CI.BAT: success for vfio: Make emulated devices prepared for vfio device cdev (rev4)

2023-03-27 Thread Patchwork
== Series Details == Series: vfio: Make emulated devices prepared for vfio device cdev (rev4) URL : https://patchwork.freedesktop.org/series/114846/ State : success == Summary == CI Bug Log - changes from CI_DRM_12918 -> Patchwork_114846v4

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for vfio: Make emulated devices prepared for vfio device cdev (rev4)

2023-03-27 Thread Patchwork
== Series Details == Series: vfio: Make emulated devices prepared for vfio device cdev (rev4) URL : https://patchwork.freedesktop.org/series/114846/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for vfio: Make emulated devices prepared for vfio device cdev (rev4)

2023-03-27 Thread Patchwork
== Series Details == Series: vfio: Make emulated devices prepared for vfio device cdev (rev4) URL : https://patchwork.freedesktop.org/series/114846/ State : warning == Summary == Error: dim checkpatch failed b5391e6b2896 iommu/iommufd: Pass iommufd_ctx pointer in iommufd_get_ioas()

Re: [Intel-gfx] [PATCH 15/29] drm/i915/tc: Check TC mode instead of the VBT legacy flag

2023-03-27 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Thursday, March 23, 2023 4:20 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 15/29] drm/i915/tc: Check TC mode instead of the > VBT legacy flag > > After the previous patch the TC mode in the

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Program pipe A PIPE_MISC_A bit 9 Pixel Extension to 0

2023-03-27 Thread Patchwork
== Series Details == Series: drm/i915/display: Program pipe A PIPE_MISC_A bit 9 Pixel Extension to 0 URL : https://patchwork.freedesktop.org/series/115652/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12914_full -> Patchwork_115652v1_full

Re: [Intel-gfx] [PATCH 14/29] drm/i915/tc: Fix up the legacy VBT flag only in disconnected mode

2023-03-27 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Thursday, March 23, 2023 4:20 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 14/29] drm/i915/tc: Fix up the legacy VBT flag > only in > disconnected mode > > A follow-up patch simplifies the

Re: [Intel-gfx] [PATCH 13/29] drm/i915/tc: Add TC PHY hooks to connect/disconnect the PHY

2023-03-27 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Thursday, March 23, 2023 4:20 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 13/29] drm/i915/tc: Add TC PHY hooks to > connect/disconnect the PHY > > Add TC PHY hooks to connect/disconnect the

[Intel-gfx] [PATCH 2/2] drm/i915: remove unused config DRM_I915_UNSTABLE

2023-03-27 Thread Jani Nikula
Essentially this is a revert of commit d9d54a530a70 ("drm/i915: Put future HW and their uAPIs under STAGING & BROKEN"). We currently have no users for this config option. The last one was removed in 8c26491f5853 ("drm/i915: Kill the fake lmem support"). Drop it altogether; it's easy enough to

[Intel-gfx] [PATCH 1/2] [core-for-CI] Revert "Revert "drm/i915: Don't select BROKEN""

2023-03-27 Thread Jani Nikula
This reverts commit 211c4b0aba30d2eab9690ad61944c7bf20b33c16. Drop the commit from the topic/core-for-CI branch. We no longer need to select BROKEN to enable DRM_I915_UNSTABLE. Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Signed-off-by: Jani Nikula ---

[Intel-gfx] [PATCH v8 23/24] vfio: Compile group optionally

2023-03-27 Thread Yi Liu
group code is not needed for vfio device cdev, so with vfio device cdev introduced, the group infrastructures can be compiled out if only cdev is needed. Reviewed-by: Kevin Tian Tested-by: Terrence Xu Signed-off-by: Yi Liu --- drivers/iommu/iommufd/Kconfig | 4 +- drivers/vfio/Kconfig

[Intel-gfx] [PATCH v8 17/24] vfio-iommufd: Add detach_ioas support for emulated VFIO devices

2023-03-27 Thread Yi Liu
this prepares for adding DETACH ioctl for emulated VFIO devices. Reviewed-by: Kevin Tian Tested-by: Terrence Xu Tested-by: Nicolin Chen Tested-by: Matthew Rosato Signed-off-by: Yi Liu --- drivers/gpu/drm/i915/gvt/kvmgt.c | 1 + drivers/s390/cio/vfio_ccw_ops.c | 1 +

[Intel-gfx] [PATCH v8 22/24] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT

2023-03-27 Thread Yi Liu
This adds ioctl for userspace to attach device cdev fd to and detach from IOAS/hw_pagetable managed by iommufd. VFIO_DEVICE_ATTACH_IOMMUFD_PT: attach vfio device to IOAS, hw_pagetable managed by iommufd. Attach can be undo

[Intel-gfx] [PATCH v8 15/24] vfio-iommufd: Add detach_ioas support for physical VFIO devices

2023-03-27 Thread Yi Liu
this prepares for adding DETACH ioctl for physical VFIO devices. Reviewed-by: Kevin Tian Tested-by: Terrence Xu Tested-by: Nicolin Chen Tested-by: Matthew Rosato Signed-off-by: Yi Liu --- Documentation/driver-api/vfio.rst | 8 +--- drivers/vfio/fsl-mc/vfio_fsl_mc.c

[Intel-gfx] [PATCH v8 21/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-03-27 Thread Yi Liu
This adds ioctl for userspace to bind device cdev fd to iommufd. VFIO_DEVICE_BIND_IOMMUFD: bind device to an iommufd, hence gain DMA control provided by the iommufd. open_device op is called after bind_iommufd op.

[Intel-gfx] [PATCH v8 16/24] iommufd/device: Add iommufd_access_detach() API

2023-03-27 Thread Yi Liu
From: Nicolin Chen Previously, the detach routine is only done by the destroy(). And it was called by vfio_iommufd_emulated_unbind() when the device runs close(), so all the mappings in iopt were cleaned in that setup, when the call trace reaches this detach() routine. Now, there's a need of a

  1   2   >