On 3/31/2023 2:12 AM, Lionel Landwerlin wrote:
By default the indirect state sampler data (border colors) are stored
in the same heap as the SAMPLER_STATE structure. For userspace drivers
that can be 2 different heaps (dynamic state heap & bindless sampler
state heap). This means that border
> -Original Message-
> From: Murthy, Arun R
> Sent: Monday, April 3, 2023 8:28 PM
> To: Kandpal, Suraj ; intel-
> g...@lists.freedesktop.org
> Cc: Sharma, Swati2
> Subject: RE: [PATCH] drm/i915/display: Increase AUX timeout for Type-C
>
> > -Original Message-
> > From:
> -Original Message-
> From: Ville Syrjälä
> Sent: Monday, April 3, 2023 7:39 PM
> To: Kandpal, Suraj
> Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville
> Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/hdcp: Remove
> drm_modeset_lock in intel_conn_to_vcpi
>
> On Mon, Apr 03, 2023
On 4/4/2023 3:03 AM, Manasi Navare wrote:
On Thu, Mar 30, 2023 at 4:11 AM Nautiyal, Ankit K
wrote:
On 3/29/2023 5:05 PM, Ville Syrjälä wrote:
On Wed, Mar 29, 2023 at 05:00:55PM +0530, Nautiyal, Ankit K wrote:
On 3/29/2023 4:23 PM, Ville Syrjälä wrote:
On Wed, Mar 29, 2023 at 04:06:21PM
== Series Details ==
Series: drm/i915: enable kernel-doc warnings for CONFIG_DRM_I915_WERROR=y (rev2)
URL : https://patchwork.freedesktop.org/series/115928/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12961_full -> Patchwork_115928v2_full
== Series Details ==
Series: series starting with [1/2] drm/i915: rename intel_pm.[ch] to
intel_clock_gating.[ch]
URL : https://patchwork.freedesktop.org/series/116020/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12961_full -> Patchwork_116020v1_full
== Series Details ==
Series: drm/i915: move DSC RC tables to drm_dsc_helper.c (rev5)
URL : https://patchwork.freedesktop.org/series/114473/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12961_full -> Patchwork_114473v5_full
Hi Ville,
Thank you for the patch.
On Tue, Apr 04, 2023 at 01:36:52AM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Include the device and connector information in the SCDC
> debugs. Makes it easier to figure out who did what.
>
> v2: Rely on connector->ddc (Maxime)
>
> Cc: Andrzej
Hi Qiang,
On Mon, 3 Apr 2023 16:51:27 +0800 Qiang Yu wrote:
>
> I think you can just revert the following three lima commits when merge:
> * 4a66f3da99dc ("drm/lima: add show_fdinfo for drm usage stats")
> * 87767de835ed ("drm/lima: allocate unique id per drm_file")
> * bccafec957a5 ("drm/lima:
On Mon, Apr 03, 2023 at 02:33:34PM -0700, john.c.harri...@intel.com wrote:
> From: John Harrison
>
> A pair of pre-Gen12 registers were being included in the Gen12 capture
> list. GuC was rejecting those as being invalid and logging errors
> about them. So, stop doing it.
Looks like these
== Series Details ==
Series: drm/scdc-helper: Pimp SCDC debugs (rev2)
URL : https://patchwork.freedesktop.org/series/115807/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12962 -> Patchwork_115807v2
Summary
---
On Fri, Mar 31, 2023 at 12:24:16PM +0200, Maarten Lankhorst wrote:
Gen13 should probably be the same as gen12, not gen11.
there is no such thing as gen13. Please reword commit message to use
graphics version, although here it's probably more related to the
display engine (and hence
== Series Details ==
Series: drm/i915/guc: Don't capture Gen8 regs on Gen12 devices
URL : https://patchwork.freedesktop.org/series/116051/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12961 -> Patchwork_116051v1
Summary
From: Ville Syrjälä
Include the device and connector information in the SCDC
debugs. Makes it easier to figure out who did what.
v2: Rely on connector->ddc (Maxime)
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
Cc: Thierry
== Series Details ==
Series: drm/i915/guc: Don't capture Gen8 regs on Gen12 devices
URL : https://patchwork.freedesktop.org/series/116051/
State : warning
== Summary ==
Error: dim checkpatch failed
c238f339fd40 drm/i915/guc: Don't capture Gen8 regs on Gen12 devices
-:35: ERROR:COMPLEX_MACRO:
On 03/04/2023 21:22, Kalvala, Haridhar wrote:
On 3/31/2023 12:35 PM, Kalvala, Haridhar wrote:
On 3/30/2023 10:49 PM, Lionel Landwerlin wrote:
On 29/03/2023 01:49, Matt Atwood wrote:
On Tue, Mar 28, 2023 at 04:14:33PM +0530, Kalvala, Haridhar wrote:
On 3/9/2023 8:56 PM, Lionel Landwerlin
From: John Harrison
A pair of pre-Gen12 registers were being included in the Gen12 capture
list. GuC was rejecting those as being invalid and logging errors
about them. So, stop doing it.
Signed-off-by: John Harrison
Fixes: dce2bd542337 ("drm/i915/guc: Add Gen9 registers for GuC error state
On Thu, Mar 30, 2023 at 4:11 AM Nautiyal, Ankit K
wrote:
>
>
> On 3/29/2023 5:05 PM, Ville Syrjälä wrote:
> > On Wed, Mar 29, 2023 at 05:00:55PM +0530, Nautiyal, Ankit K wrote:
> >> On 3/29/2023 4:23 PM, Ville Syrjälä wrote:
> >>> On Wed, Mar 29, 2023 at 04:06:21PM +0530, Nautiyal, Ankit K wrote:
On Mon, Apr 03, 2023 at 01:35:40PM -0700, Matt Roper wrote:
> On Fri, Mar 31, 2023 at 12:24:16PM +0200, Maarten Lankhorst wrote:
> > Gen13 should probably be the same as gen12, not gen11.
> >
> > Signed-off-by: Maarten Lankhorst
> > Cc: intel-gfx@lists.freedesktop.org
> > ---
> >
== Series Details ==
Series: drm/i915: enable kernel-doc warnings for CONFIG_DRM_I915_WERROR=y (rev2)
URL : https://patchwork.freedesktop.org/series/115928/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12961 -> Patchwork_115928v2
On Fri, Mar 31, 2023 at 12:24:16PM +0200, Maarten Lankhorst wrote:
> Gen13 should probably be the same as gen12, not gen11.
>
> Signed-off-by: Maarten Lankhorst
> Cc: intel-gfx@lists.freedesktop.org
> ---
> drivers/gpu/drm/i915/soc/intel_dram.c | 2 +-
> 1 file changed, 1 insertion(+), 1
Since we are now using unversioned GuC/HuC, it's useful to be able to
dump the firmware blob and get that information from the CSS header.
Add a tool that decodes that information and dumps the raw header.
Example output:
$ tools/intel-gfx-fw-info /lib/firmware/i915/tgl_guc_70.bin
== Series Details ==
Series: series starting with [1/2] drm/i915: rename intel_pm.[ch] to
intel_clock_gating.[ch]
URL : https://patchwork.freedesktop.org/series/116020/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12961 -> Patchwork_116020v1
On Mon, Apr 03, 2023 at 11:21:51AM +0100, Tvrtko Ursulin wrote:
On 31/03/2023 21:02, Umesh Nerlige Ramappa wrote:
The underlying mechanism used to provide the client specific utilization
in fdinfo is context busyness. When a context switches out, the HW
records the runtime in the specific
== Series Details ==
Series: series starting with [1/2] drm/i915: rename intel_pm.[ch] to
intel_clock_gating.[ch]
URL : https://patchwork.freedesktop.org/series/116020/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked
== Series Details ==
Series: series starting with [1/2] drm/i915: rename intel_pm.[ch] to
intel_clock_gating.[ch]
URL : https://patchwork.freedesktop.org/series/116020/
State : warning
== Summary ==
Error: dim checkpatch failed
2704a1498adc drm/i915: rename intel_pm.[ch] to
On Mon, Apr 03, 2023 at 07:39:37PM +, Yang, Fei wrote:
> >Subject: Re: [PATCH 5/7] drm/i915: use pat_index instead of cache_level
> >
> >On Mon, Apr 03, 2023 at 04:57:21PM +, Yang, Fei wrote:
> >>> Subject: Re: [PATCH 5/7] drm/i915: use pat_index instead of
> >>> cache_level
> >>>
> >>> On
== Series Details ==
Series: drm/i915: move DSC RC tables to drm_dsc_helper.c (rev5)
URL : https://patchwork.freedesktop.org/series/114473/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12961 -> Patchwork_114473v5
Summary
>Subject: Re: [PATCH 5/7] drm/i915: use pat_index instead of cache_level
>
>On Mon, Apr 03, 2023 at 04:57:21PM +, Yang, Fei wrote:
>>> Subject: Re: [PATCH 5/7] drm/i915: use pat_index instead of
>>> cache_level
>>>
>>> On Fri, Mar 31, 2023 at 11:38:28PM -0700, fei.y...@intel.com wrote:
== Series Details ==
Series: drm/i915: move DSC RC tables to drm_dsc_helper.c (rev5)
URL : https://patchwork.freedesktop.org/series/114473/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/hdcp: Remove drm_modeset_lock in intel_conn_to_vcpi (rev2)
URL : https://patchwork.freedesktop.org/series/115240/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12958_full -> Patchwork_115240v2_full
+ Joonas for inputs
On Thu, Mar 30, 2023 at 11:31:53AM -0700, Umesh Nerlige Ramappa wrote:
+ Joonas for comments on this
On Thu, Mar 30, 2023 at 02:38:03PM +0100, Tvrtko Ursulin wrote:
On 30/03/2023 01:41, Umesh Nerlige Ramappa wrote:
MTL introduces separate GTs for render and media. This
== Series Details ==
Series: drm/i915/mtl: Add support for PM DEMAND
URL : https://patchwork.freedesktop.org/series/116012/
State : failure
== Summary ==
Error: make failed
CALLscripts/checksyscalls.sh
DESCEND objtool
INSTALL libsubcmd_headers
CC [M]
On Mon, Apr 03, 2023 at 02:10:26PM -0400, Souza, Jose wrote:
> On Mon, 2023-04-03 at 13:03 -0400, Rodrigo Vivi wrote:
> > On Mon, Apr 03, 2023 at 09:46:11AM -0700, José Roberto de Souza wrote:
> > > No behavior changes here, just adding a function to make clear
> > > what locks initialized here
On 3/31/2023 12:35 PM, Kalvala, Haridhar wrote:
On 3/30/2023 10:49 PM, Lionel Landwerlin wrote:
On 29/03/2023 01:49, Matt Atwood wrote:
On Tue, Mar 28, 2023 at 04:14:33PM +0530, Kalvala, Haridhar wrote:
On 3/9/2023 8:56 PM, Lionel Landwerlin wrote:
By default the indirect state sampler
On Mon, 2023-04-03 at 13:03 -0400, Rodrigo Vivi wrote:
> On Mon, Apr 03, 2023 at 09:46:11AM -0700, José Roberto de Souza wrote:
> > No behavior changes here, just adding a function to make clear
> > what locks initialized here are display related or not.
> >
> > Cc:
This spin lock will not be used in older display versions, so no need
to initialize it.
Cc: intel-gfx@lists.freedesktop.org
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/display/intel_dkl_phy.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
dsparb_lock it not used anymore, nuke it.
Cc: intel-gfx@lists.freedesktop.org
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/display/intel_display_core.h | 3 ---
drivers/gpu/drm/i915/i915_driver.c| 1 -
2 files changed, 4 deletions(-)
diff --git
Start to move the initialization of some lock from
i915_driver_early_probe().
This will also fix a warning in Xe kmd:
[ 201.894839] xe :00:02.0: [drm] [ENCODER:235:DDI A/PHY A] failed to
retrieve link info, disabling eDP
[ 202.136336] xe :00:02.0: [drm] *ERROR* Failed to write source
On Fri, Mar 31, 2023 at 07:41:46PM -0700, Ashutosh Dixit wrote:
> On ATSM the PL1 limit is disabled at power up. The previous uapi assumed
> that the PL1 limit is always enabled and therefore did not have a notion of
> a disabled PL1 limit. This results in erroneous PL1 limit values when the
> PL1
On 4/3/2023 8:36 AM, Dixit, Ashutosh wrote:
On Mon, 03 Apr 2023 08:23:45 -0700, Belgaumkar, Vinay wrote:
On 3/31/2023 4:56 PM, Dixit, Ashutosh wrote:
On Mon, 27 Mar 2023 19:00:28 -0700, Vinay Belgaumkar wrote:
Hi Vinay,
+/*
+ * Too many intermediate components and steps before freq is
On Mon, Apr 03, 2023 at 04:57:21PM +, Yang, Fei wrote:
> > Subject: Re: [PATCH 5/7] drm/i915: use pat_index instead of cache_level
> >
> > On Fri, Mar 31, 2023 at 11:38:28PM -0700, fei.y...@intel.com wrote:
> >> From: Fei Yang
> >>
> >> Currently the KMD is using enum i915_cache_level to set
On Mon, Apr 03, 2023 at 09:46:11AM -0700, José Roberto de Souza wrote:
> No behavior changes here, just adding a function to make clear
> what locks initialized here are display related or not.
>
> Cc: intel-gfx@lists.freedesktop.org
> Signed-off-by: José Roberto de Souza
> ---
>
> Subject: Re: [PATCH 5/7] drm/i915: use pat_index instead of cache_level
>
> On Fri, Mar 31, 2023 at 11:38:28PM -0700, fei.y...@intel.com wrote:
>> From: Fei Yang
>>
>> Currently the KMD is using enum i915_cache_level to set caching policy for
>> buffer objects. This is flaky because the PAT
On Mon, Apr 03, 2023 at 09:35:32AM -0700, Matt Roper wrote:
> On Mon, Apr 03, 2023 at 07:02:08PM +0300, Ville Syrjälä wrote:
> > On Fri, Mar 31, 2023 at 11:38:30PM -0700, fei.y...@intel.com wrote:
> > > From: Fei Yang
> > >
> > > To comply with the design that buffer objects shall have immutable
No behavior changes here, just adding a function to make clear
what locks initialized here are display related or not.
Cc: intel-gfx@lists.freedesktop.org
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/i915_driver.c | 23 +++
1 file changed, 15 insertions(+),
On Mon, Apr 03, 2023 at 07:02:08PM +0300, Ville Syrjälä wrote:
> On Fri, Mar 31, 2023 at 11:38:30PM -0700, fei.y...@intel.com wrote:
> > From: Fei Yang
> >
> > To comply with the design that buffer objects shall have immutable
> > cache setting through out its life cycle, {set, get}_caching
On Mon, 03 Apr 2023, Jani Nikula wrote:
> On Fri, 31 Mar 2023, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/gpu/drm/i915/i915_scatterlist.c:62: warning: Function parameter or
> > member 'size' not described in 'i915_refct_sgt_init'
> >
> > Cc: Jani
On Mon, Apr 03, 2023 at 09:32:18AM -0600, Alex Williamson wrote:
> > yes, this series is applied on [1]. I put the [1], this series and cdev
> > series
> > in https://github.com/yiliu1765/iommufd/commits/vfio_device_cdev_v9.
> >
> > Jason has taken [1] in the below branch. It is based on rc1. So
On Fri, Mar 31, 2023 at 11:38:30PM -0700, fei.y...@intel.com wrote:
> From: Fei Yang
>
> To comply with the design that buffer objects shall have immutable
> cache setting through out its life cycle, {set, get}_caching ioctl's
> are no longer supported from MTL onward. With that change caching
>
On Sat, 01 Apr 2023, Masahiro Yamada wrote:
> On Fri, Mar 31, 2023 at 7:15 PM Jani Nikula wrote:
>>
>> Increase awareness of kernel-doc issues by enabling doc check locally
>> when W= is *not* specified on the make command-line, but
>> CONFIG_DRM_I915_WERROR=y is enabled.
>>
>> Once the warnings
On Mon, 03 Apr 2023 08:23:45 -0700, Belgaumkar, Vinay wrote:
>
>
> On 3/31/2023 4:56 PM, Dixit, Ashutosh wrote:
> > On Mon, 27 Mar 2023 19:00:28 -0700, Vinay Belgaumkar wrote:
> > Hi Vinay,
> >
> >> +/*
> >> + * Too many intermediate components and steps before freq is adjusted
> >> + * Specially
On Fri, 31 Mar 2023, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/i915/i915_scatterlist.c:62: warning: Function parameter or
> member 'size' not described in 'i915_refct_sgt_init'
>
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc:
On Mon, 3 Apr 2023 15:22:03 +
"Liu, Yi L" wrote:
> > From: Alex Williamson
> > Sent: Monday, April 3, 2023 11:02 PM
> >
> > On Mon, 3 Apr 2023 09:25:06 +
> > "Liu, Yi L" wrote:
> >
> > > > From: Liu, Yi L
> > > > Sent: Saturday, April 1, 2023 10:44 PM
> > >
> > > > @@ -791,7
On 3/31/2023 4:56 PM, Dixit, Ashutosh wrote:
On Mon, 27 Mar 2023 19:00:28 -0700, Vinay Belgaumkar wrote:
Hi Vinay,
+/*
+ * Too many intermediate components and steps before freq is adjusted
+ * Specially if workload is under execution, so let's wait 100 ms.
+ */
+#define ACT_FREQ_LATENCY_US
> From: Alex Williamson
> Sent: Monday, April 3, 2023 11:02 PM
>
> On Mon, 3 Apr 2023 09:25:06 +
> "Liu, Yi L" wrote:
>
> > > From: Liu, Yi L
> > > Sent: Saturday, April 1, 2023 10:44 PM
> >
> > > @@ -791,7 +813,21 @@ static int vfio_pci_fill_devs(struct pci_dev *pdev,
> > > void
>
Am 02.04.23 um 18:48 schrieb Dmitry Osipenko:
Don't assert held dma-buf reservation lock on memory mapping of exported
buffer.
We're going to change dma-buf mmap() locking policy such that exporters
will have to handle the lock. The previous locking policy caused deadlock
problem for DRM
On Mon, 3 Apr 2023 09:25:06 +
"Liu, Yi L" wrote:
> > From: Liu, Yi L
> > Sent: Saturday, April 1, 2023 10:44 PM
>
> > @@ -791,7 +813,21 @@ static int vfio_pci_fill_devs(struct pci_dev *pdev,
> > void *data)
> > if (!iommu_group)
> > return -EPERM; /* Cannot reset
== Series Details ==
Series: drm/i915/display: Increase AUX timeout for Type-C
URL : https://patchwork.freedesktop.org/series/116010/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12958 -> Patchwork_116010v1
Summary
> -Original Message-
> From: Kandpal, Suraj
> Sent: Monday, April 3, 2023 1:32 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Murthy, Arun R ; Sharma, Swati2
> ; Kandpal, Suraj
> Subject: [PATCH] drm/i915/display: Increase AUX timeout for Type-C
>
> Type-C PHYs are taking longer than
On Fri, Mar 31, 2023 at 11:38:28PM -0700, fei.y...@intel.com wrote:
> From: Fei Yang
>
> Currently the KMD is using enum i915_cache_level to set caching policy for
> buffer objects. This is flaky because the PAT index which really controls
> the caching behavior in PTE has far more levels than
== Series Details ==
Series: drm/i915/hdcp: Remove drm_modeset_lock in intel_conn_to_vcpi (rev2)
URL : https://patchwork.freedesktop.org/series/115240/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12958 -> Patchwork_115240v2
From: Nirmoy Das
commit e92eb246feb9019b0b137706c934b8891cdfe3c2 upstream.
debug_active_activate() expected ref->count to be zero
which is not true anymore as __i915_active_activate() calls
debug_active_activate() after incrementing the count.
v2: No need to check for "ref->count == 1" as
On Mon, Apr 03, 2023 at 12:31:25PM +0530, Suraj Kandpal wrote:
> Remove drm_modeset_lock in intel_conn_to_vcpi as we don't need it
> anymore since all the required locks are taken in atomic check and
> prepare phases.
>
> --v2
> -take lock if hdcp function is called from legacy path [Ville]
>
>
Hi Dmitry,
On Sun, 2 Apr 2023 at 17:49, Dmitry Osipenko
wrote:
> -void drm_gem_shmem_put_pages(struct drm_gem_shmem_object *shmem)
> +static int drm_gem_shmem_pin_locked(struct drm_gem_shmem_object *shmem)
> {
> - mutex_lock(>pages_lock);
> - drm_gem_shmem_put_pages_locked(shmem);
On Mon, Apr 03, 2023 at 03:57:10PM +0300, Jani Nikula wrote:
> Increase awareness of kernel-doc issues by enabling doc check locally
> when CONFIG_DRM_I915_WERROR=y is enabled.
>
> Once the warnings have been fixed, we can pass -Werror to kernel-doc
> locally, and fail the build when there are
> -Original Message-
> From: Jani Nikula
> Sent: Monday, April 3, 2023 12:17 PM
> To: Kahola, Mika ; intel-gfx@lists.freedesktop.org
> Cc: De Marchi, Lucas ; Roper, Matthew D
>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Add support for PM DEMAND
>
> On Mon, 03 Apr 2023, Mika
Increase awareness of kernel-doc issues by enabling doc check locally
when CONFIG_DRM_I915_WERROR=y is enabled.
Once the warnings have been fixed, we can pass -Werror to kernel-doc
locally, and fail the build when there are kernel-doc warnings in i915.
v2: Don't check for KBUILD_EXTRA_WARN
Hi
Am 28.03.23 um 17:31 schrieb Jani Nikula:
On Tue, 28 Mar 2023, Thomas Zimmermann wrote:
Replace all code that initializes or releases fbdev emulation
throughout the driver. Instead initialize the fbdev client by a
single call to i915_fbdev_setup() after i915 has registered its
DRM device.
On Fri, 31 Mar 2023, fei.y...@intel.com wrote:
> From: Fei Yang
>
> On MTL, GT can no longer allocate on LLC - only the CPU can.
> This, along with addition of support for ADM/L4 cache calls a
> MOCS/PAT table update.
> Also add PTE encode functions for MTL as it has different PAT
> index
Observe that intel_pm.[ch] is now purely about clock gating, so rename
them to intel_clock_gating.[ch]. Rename the functions to
intel_clock_gating_*() to follow coding conventions.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile | 2 +-
Follow the contemporary naming style. Include some indentation fixes
while at it on the affected statements.
One function needs to keep using dev_priv due to implicit dev_priv usage
in a macro.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_clock_gating.c
On Mon, Mar 27, 2023 at 03:34:32PM +0300, Mika Kahola wrote:
> From: Radhakrishna Sripada
>
> C10 phys uses direct mapping internally for voltage and pre-emphasis levels.
> Program the levels directly to the fields in the VDR Registers.
>
> Bspec: 65449
>
> v2: From table "C10: Tx EQ settings
> -Original Message-
> From: Deak, Imre
> Sent: Monday, April 3, 2023 1:36 PM
> To: Kahola, Mika
> Cc: intel-gfx@lists.freedesktop.org; Sripada, Radhakrishna
> ; Shankar, Uma ;
> Sousa, Gustavo
> Subject: Re: [PATCH 4/7] drm/i915/mtl: Add Support for C10 PHY message bus
> and pll
On Mon, Apr 03, 2023 at 01:19:48PM +0300, Kahola, Mika wrote:
> > -Original Message-
> > From: Deak, Imre
> > Sent: Monday, April 3, 2023 1:12 PM
> > To: Kahola, Mika
> > Cc: intel-gfx@lists.freedesktop.org; Sripada, Radhakrishna
> > ; Shankar, Uma ;
> > Sousa, Gustavo
> > Subject: Re:
On Mon, Mar 27, 2023 at 03:34:31PM +0300, Mika Kahola wrote:
> From: Radhakrishna Sripada
>
> Like DG2, we still don't have a proper algorithm that can be used
> for calculating PHY settings, but we do have tables of register
> values for a handful of the more common link rates. Some support is
On 31/03/2023 21:02, Umesh Nerlige Ramappa wrote:
The underlying mechanism used to provide the client specific utilization
in fdinfo is context busyness. When a context switches out, the HW
records the runtime in the specific context field. This information is
accumulated in fdinfo. This
> -Original Message-
> From: Deak, Imre
> Sent: Monday, April 3, 2023 1:12 PM
> To: Kahola, Mika
> Cc: intel-gfx@lists.freedesktop.org; Sripada, Radhakrishna
> ; Shankar, Uma ;
> Sousa, Gustavo
> Subject: Re: [PATCH 4/7] drm/i915/mtl: Add Support for C10 PHY message bus
> and pll
On 4/2/23 19:48, Dmitry Osipenko wrote:
> This patchset makes dma-buf exporters responisble for taking care of
> the reservation lock. I also included patch that moves drm-shmem to use
> reservation lock, to let CI test the whole set. I'm going to take all
> the patches via the drm-misc tree,
On Mon, Mar 27, 2023 at 03:34:30PM +0300, Mika Kahola wrote:
> From: Radhakrishna Sripada
>
> XELPDP has C10 and C20 phys from Synopsys to drive displays. Each phy
> has a dedicated PIPE 5.2 Message bus for configuration. This message
> bus is used to configure the phy internal registers.
>
>
Hi Suraj,
Thanks for the patch, please find my comments inline:
On 4/3/2023 1:31 PM, Suraj Kandpal wrote:
Type-C PHYs are taking longer than expected for Aux IO Power Enabling.
Workaround: Increase the timeout.
WA: 14017271110
Lets use Wa_ as per convention.
Also I am wondering if we
> From: Liu, Yi L
> Sent: Saturday, April 1, 2023 10:44 PM
> @@ -791,7 +813,21 @@ static int vfio_pci_fill_devs(struct pci_dev *pdev, void
> *data)
> if (!iommu_group)
> return -EPERM; /* Cannot reset non-isolated devices */
Hi Alex,
Is disabling iommu a sane way to test
Add a helper setting config values which are typically constant across
operating modes (table E-4 of the standard) and mux_word_size (which is
a const according to 3.5.2).
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/display/drm_dsc_helper.c | 22 ++
Include RC parameters for YCbCr 4:2:2 and 4:2:0 configurations.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/display/drm_dsc_helper.c | 438 +++
include/drm/display/drm_dsc_helper.h | 2 +
2 files changed, 440 insertions(+)
diff --git
Move DSC RC tables to DRM DSC helper. No additional code changes
and/or cleanups are a part of this commit, it will be cleaned up in the
followup commits.
Reviewed-by: Jani Nikula
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/display/drm_dsc_helper.c | 372 ++
Switch to drm_dsc_set_const_params() to set some semi-constant
parameters. The rc_model_size, which is set beforehand, is preserved by
the helper. Also make use of drm_dsc_set_initial_scale_value().
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/i915/display/intel_vdsc.c | 15
The code was ignoring (up to some point for rc_model_size) the
rc_model_size, rc_tgt_offset_high, rc_tgt_offset_low and rc_edge_factor
parameters from struct drm_dsc_config. Actually use them instead of
resorting to predefined constants.
Signed-off-by: Dmitry Baryshkov
---
Next commits are going to add support for additional RC parameter lookup
tables. These tables are going to use different bpp/bpc combinations,
thus it makes little sense to keep the 2d array for RC parameters.
Switch to using the flat array.
Reviewed-by: Jani Nikula
Signed-off-by: Dmitry
The array of rc_parameters contains a mixture of parameters from DSC 1.1
and DSC 1.2 standards. Split these tow configuration arrays in
preparation to adding more configuration data.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/display/drm_dsc_helper.c | 127 ++
From: Jessica Zhang
Add helpers to calculate det_thresh_flatness and initial_scale_value as
these calculations are defined within the DSC spec.
Changes in v2:
- Renamed det_thresh_flatness to flatness_det_thresh
- Set initial_scale_value directly in helper
Signed-off-by: Jessica Zhang
DSC model contains pre-SCR RC parameters for other bpp/bpc combinations,
include them here for completeness.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/display/drm_dsc_helper.c | 72
1 file changed, 72 insertions(+)
diff --git
Stop using an interim structure rc_parameters for storing calculated
params and then setting drm_dsc_config using that structure. Instead put
calculated params into the struct drm_dsc_config directly.
Reviewed-by: Jani Nikula
Signed-off-by: Dmitry Baryshkov
---
After cross-checking DSC models (20150914, 20161212, 20210623) change
values in rc_parameters tables to follow config files present inside
the DSC model. Handle two places, where i915 tables diverged from the
model, by patching the rc values in the code.
Note: I left one case uncorrected,
The rc_buf_thresh values are common to all DSC implementations. Move
them to the common helper together with the code to propagage them to
the drm_dsc_config.
Reviewed-by: Jani Nikula
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/display/drm_dsc_helper.c | 35 +++
Other platforms (msm) will benefit from sharing the DSC config setup
functions. This series moves parts of static DSC config data from the
i915 driver to the common helpers to be used by other drivers.
Note: the RC parameters were cross-checked against config files found in
DSC model 2021062,
On Mon, 03 Apr 2023, Mika Kahola wrote:
> Display14 introduces a new way to instruct the PUnit with
> power and bandwidth requirements of DE. Add the functionality
> to program the registers and handle waits using interrupts.
> The current wait time for timeouts is programmed for 10 msecs to
>
On Sat, Apr 01, 2023 at 12:02:32AM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/tc: Align the ADLP TypeC sequences with bspec (rev2)
> URL : https://patchwork.freedesktop.org/series/115556/
> State : success
Thanks for the review, patchset is pushed to -din.
>
> ==
On 01.04.2023 20:02, Patchwork wrote:
Project List - Patchwork *Patch Details*
*Series:* drm/i915/gt: Hold a wakeref for the active VM (rev2)
*URL:* https://patchwork.freedesktop.org/series/115873/
*State:*failure
*Details:*
Display14 introduces a new way to instruct the PUnit with
power and bandwidth requirements of DE. Add the functionality
to program the registers and handle waits using interrupts.
The current wait time for timeouts is programmed for 10 msecs to
factor in the worst case scenarios. Changes made to
I think you can just revert the following three lima commits when merge:
* 4a66f3da99dc ("drm/lima: add show_fdinfo for drm usage stats")
* 87767de835ed ("drm/lima: allocate unique id per drm_file")
* bccafec957a5 ("drm/lima: add usage counting method to ctx_mgr")
Regards,
Qiang
On Mon, Apr 3,
1 - 100 of 110 matches
Mail list logo
