[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dp: prevent potential div-by-zero

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915/dp: prevent potential div-by-zero URL : https://patchwork.freedesktop.org/series/116821/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13043_full -> Patchwork_116821v1_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add support for MTL GSC SW Proxy (rev2)

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915: Add support for MTL GSC SW Proxy (rev2) URL : https://patchwork.freedesktop.org/series/115806/ State : success == Summary == CI Bug Log - changes from CI_DRM_13043 -> Patchwork_115806v2 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Add support for MTL GSC SW Proxy (rev2)

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915: Add support for MTL GSC SW Proxy (rev2) URL : https://patchwork.freedesktop.org/series/115806/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for MTL GSC SW Proxy (rev2)

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915: Add support for MTL GSC SW Proxy (rev2) URL : https://patchwork.freedesktop.org/series/115806/ State : warning == Summary == Error: dim checkpatch failed fa63c332dc60 drm/i915/mtl: Define GSC Proxy component interface Traceback (most recent call last):

[Intel-gfx] [PATCH v2 4/4] drm/i915/gsc: add support for GSC proxy interrupt

2023-04-21 Thread Daniele Ceraolo Spurio
The GSC notifies us of a proxy request via the HECI2 interrupt. The interrupt must be enabled both in the HECI layer and in our usual gt irq programming; for the latter, the interrupt is enabled via the same enable register as the GSC CS, but it does have its own mask register. When the interrupt

[Intel-gfx] [PATCH v2 2/4] mei: gsc_proxy: add gsc proxy driver

2023-04-21 Thread Daniele Ceraolo Spurio
From: Alexander Usyskin Add GSC proxy driver. It to allows messaging between GSC component on Intel graphics card and CSE device. Cc: Alan Previn Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler Signed-off-by: Daniele Ceraolo Spurio Acked-by: Greg Kroah-Hartman --- v2:

[Intel-gfx] [PATCH v2 3/4] drm/i915/gsc: add initial support for GSC proxy

2023-04-21 Thread Daniele Ceraolo Spurio
The GSC uC needs to communicate with the CSME to perform certain operations. Since the GSC can't perform this communication directly on platforms where it is integrated in GT, i915 needs to transfer the messages from GSC to CSME and back. The proxy flow is as follow: 1 - i915 submits a request to

[Intel-gfx] [PATCH v2 1/4] drm/i915/mtl: Define GSC Proxy component interface

2023-04-21 Thread Daniele Ceraolo Spurio
From: Alexander Usyskin GSC Proxy component is used for communication between the Intel graphics driver and MEI driver. Cc: Alan Previn Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler Signed-off-by: Daniele Ceraolo Spurio Acked-by: Greg Kroah-Hartman --- v2: Improve

[Intel-gfx] [PATCH v2 0/4] drm/i915: Add support for MTL GSC SW Proxy

2023-04-21 Thread Daniele Ceraolo Spurio
On platforms where the GSC is part of GT, it needs to communicate with CSME for some of its operations. However, there is no direct HW communication channel, so the i915 and mei drivers must carry the messages back and forth between the 2 units. The protocol is fully described in the i915 patch

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix memory leaks in i915 selftests (rev4)

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix memory leaks in i915 selftests (rev4) URL : https://patchwork.freedesktop.org/series/116513/ State : success == Summary == CI Bug Log - changes from CI_DRM_13043_full -> Patchwork_116513v4_full

[Intel-gfx] [PATCH i-g-t 3/4] i915_pm_freq_api: Add some basic SLPC igt tests

2023-04-21 Thread Vinay Belgaumkar
Validate basic api for GT freq control. Also test interaction with GT reset. We skip rps tests with SLPC enabled, this will re-introduce some coverage. SLPC selftests are already covering some other workload related scenarios. v2: Rename test (Rodrigo) v3: Review comments (Ashutosh) v4: Skip when

[Intel-gfx] [PATCH i-g-t 4/4] HAX: tests/i915: Try out the SLPC IGT tests

2023-04-21 Thread Vinay Belgaumkar
Trying out for CI. Do not review. Signed-off-by: Vinay Belgaumkar --- tests/intel-ci/fast-feedback.testlist | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index d9fcb62d..653668dd 100644 ---

[Intel-gfx] [PATCH i-g-t 2/4] lib: Make SLPC helper function per GT

2023-04-21 Thread Vinay Belgaumkar
Use default of 0 where GT id is not being used. Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/8308 v2: Add a helper for GT 0 (Ashutosh) v3: Additional review comments (Ashutosh) Signed-off-by: Vinay Belgaumkar Reviewed-by: Ashutosh Dixit --- lib/igt_pm.c | 34

[Intel-gfx] [PATCH i-g-t 1/4] lib/debugfs: Add per GT debugfs helpers

2023-04-21 Thread Vinay Belgaumkar
These can be used to open per-gt debugfs files. Reviewed-by: Ashutosh Dixit Signed-off-by: Tvrtko Ursulin Signed-off-by: Vinay Belgaumkar --- lib/igt_debugfs.c | 60 +++ lib/igt_debugfs.h | 4 2 files changed, 64 insertions(+) diff --git

[Intel-gfx] [PATCH v7 i-g-t 0/4] tests/slpc: Add basic IGT test

2023-04-21 Thread Vinay Belgaumkar
Borrow some subtests from xe_guc_pc. Also add per GT SLPC debugfs helpers. v3: Review comments and add HAX patch v4: Modify the condition for skipping the test v5: Update the SLPC helper to per GT v6: Review comments (Ashutosh) v6: Review comments for SLPC debugfs patch (Ashutosh) v7: More

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/rc6: throw out set() wrapper

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915/rc6: throw out set() wrapper URL : https://patchwork.freedesktop.org/series/116817/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13041_full -> Patchwork_116817v1_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Actually return an error if GuC version range check fails

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915/guc: Actually return an error if GuC version range check fails URL : https://patchwork.freedesktop.org/series/116848/ State : success == Summary == CI Bug Log - changes from CI_DRM_13043 -> Patchwork_116848v1

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: Restore HSW/BDW PSR1

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915/psr: Restore HSW/BDW PSR1 URL : https://patchwork.freedesktop.org/series/116814/ State : success == Summary == CI Bug Log - changes from CI_DRM_13041_full -> Patchwork_116814v1_full Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Actually return an error if GuC version range check fails

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915/guc: Actually return an error if GuC version range check fails URL : https://patchwork.freedesktop.org/series/116848/ State : warning == Summary == Error: dim checkpatch failed b0b33de7f7c8 drm/i915/guc: Actually return an error if GuC version range check

Re: [Intel-gfx] [PATCH 01/13] drm/i915/mtl: C20 PLL programming

2023-04-21 Thread Radhakrishna Sripada
Hi Mika, On Thu, Apr 20, 2023 at 03:40:38PM +0300, Mika Kahola wrote: > C20 phy PLL programming sequence for DP, DP2.0, HDMI2.x non-FRL and > HDMI2.x FRL. This enables C20 MPLLA and MPLLB programming sequence. add > 4 lane support for c20. > > Signed-off-by: José Roberto de Souza >

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v5,1/2] drm/i915/guc/slpc: Provide sysfs for efficient freq

2023-04-21 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm/i915/guc/slpc: Provide sysfs for efficient freq URL : https://patchwork.freedesktop.org/series/116840/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13043 -> Patchwork_116840v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v5,1/2] drm/i915/guc/slpc: Provide sysfs for efficient freq

2023-04-21 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm/i915/guc/slpc: Provide sysfs for efficient freq URL : https://patchwork.freedesktop.org/series/116840/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] [PATCH] drm/i915/guc: Actually return an error if GuC version range check fails

2023-04-21 Thread John . C . Harrison
From: John Harrison Dan Carpenter pointed out that 'err' was not being set in the case where the GuC firmware version range check fails. Fix that. Note that while this is bug fix for a previous patch (see Fixes tag below). It is an exceedingly low risk bug. The range check is asserting that the

[Intel-gfx] ✓ Fi.CI.BAT: success for Use i915 instead of dev_priv (rev2)

2023-04-21 Thread Patchwork
== Series Details == Series: Use i915 instead of dev_priv (rev2) URL : https://patchwork.freedesktop.org/series/116816/ State : success == Summary == CI Bug Log - changes from CI_DRM_13043 -> Patchwork_116816v2 Summary ---

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-21 Thread Jason Gunthorpe
On Thu, Apr 20, 2023 at 08:08:39AM -0600, Alex Williamson wrote: > > Hide this device in the list looks fine to me. But the calling user should > > not do any new device open before finishing hot-reset. Otherwise, user may > > miss a device that needs to do pre/post reset. I think this

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/display & drm/i915: more struct drm_edid conversions

2023-04-21 Thread Patchwork
== Series Details == Series: drm/display & drm/i915: more struct drm_edid conversions URL : https://patchwork.freedesktop.org/series/116813/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13041_full -> Patchwork_116813v1_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Use i915 instead of dev_priv (rev2)

2023-04-21 Thread Patchwork
== Series Details == Series: Use i915 instead of dev_priv (rev2) URL : https://patchwork.freedesktop.org/series/116816/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Use i915 instead of dev_priv (rev2)

2023-04-21 Thread Patchwork
== Series Details == Series: Use i915 instead of dev_priv (rev2) URL : https://patchwork.freedesktop.org/series/116816/ State : warning == Summary == Error: dim checkpatch failed a9e68a5b12c6 drm/i915/i915_drv: Use proper parameter naming in for_each_engine() -:24: ERROR:COMPLEX_MACRO: Macros

[Intel-gfx] ✓ Fi.CI.BAT: success for Define MOCS and PAT tables for MTL

2023-04-21 Thread Patchwork
== Series Details == Series: Define MOCS and PAT tables for MTL URL : https://patchwork.freedesktop.org/series/116837/ State : success == Summary == CI Bug Log - changes from CI_DRM_13043 -> Patchwork_116837v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Define MOCS and PAT tables for MTL

2023-04-21 Thread Patchwork
== Series Details == Series: Define MOCS and PAT tables for MTL URL : https://patchwork.freedesktop.org/series/116837/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Define MOCS and PAT tables for MTL (rev10)

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Define MOCS and PAT tables for MTL (rev10) URL : https://patchwork.freedesktop.org/series/115980/ State : success == Summary == CI Bug Log - changes from CI_DRM_13043 -> Patchwork_115980v10

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: Define MOCS and PAT tables for MTL (rev10)

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Define MOCS and PAT tables for MTL (rev10) URL : https://patchwork.freedesktop.org/series/115980/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: Define MOCS and PAT tables for MTL (rev10)

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Define MOCS and PAT tables for MTL (rev10) URL : https://patchwork.freedesktop.org/series/115980/ State : warning == Summary == Error: dim checkpatch failed 9e568e869ce8 drm/i915/mtl: Define MOCS and PAT tables for MTL 61f1e9e5a3cd drm/i915/mtl: fix

[Intel-gfx] ✗ Fi.CI.BAT: failure for Improvements to uc firmare management (rev3)

2023-04-21 Thread Patchwork
== Series Details == Series: Improvements to uc firmare management (rev3) URL : https://patchwork.freedesktop.org/series/116517/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13043 -> Patchwork_116517v3 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: use ref_tracker library for tracking wakerefs (rev8)

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915: use ref_tracker library for tracking wakerefs (rev8) URL : https://patchwork.freedesktop.org/series/100327/ State : success == Summary == CI Bug Log - changes from CI_DRM_13040_full -> Patchwork_100327v8_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Improvements to uc firmare management (rev3)

2023-04-21 Thread Patchwork
== Series Details == Series: Improvements to uc firmare management (rev3) URL : https://patchwork.freedesktop.org/series/116517/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Improvements to uc firmare management (rev3)

2023-04-21 Thread Patchwork
== Series Details == Series: Improvements to uc firmare management (rev3) URL : https://patchwork.freedesktop.org/series/116517/ State : warning == Summary == Error: dim checkpatch failed c9c1858ce1b5 drm/i915/guc: Decode another GuC load failure case 78137da72e02 drm/i915/guc: Print status

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Allow user to set cache at BO creation

2023-04-21 Thread Jordan Justen
On 2023-04-20 09:11:18, Yang, Fei wrote: > > On 20/04/2023 12:39, Andi Shyti wrote: > >> Hi Fei, > >> > >>> To comply with the design that buffer objects shall have immutable > >>> cache setting through out their life cycle, {set, get}_caching ioctl's > >>> are no longer supported from MTL onward.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: workaround coherency issue for Media (rev3)

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915/mtl: workaround coherency issue for Media (rev3) URL : https://patchwork.freedesktop.org/series/116751/ State : success == Summary == CI Bug Log - changes from CI_DRM_13043 -> Patchwork_116751v3

[Intel-gfx] [PATCH v5 2/2] drm/i915/selftest: Update the SLPC selftest

2023-04-21 Thread Vinay Belgaumkar
Use the new efficient frequency toggling interface. Also create a helper function to restore the frequencies after the test is done. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/selftest_slpc.c | 42 ++--- 1 file changed, 37 insertions(+), 5 deletions(-) diff

[Intel-gfx] [PATCH v5 1/2] drm/i915/guc/slpc: Provide sysfs for efficient freq

2023-04-21 Thread Vinay Belgaumkar
SLPC enables use of efficient freq at init by default. It is possible for GuC to request frequencies that are higher than the 'software' max if user has set it lower than the efficient level. Scenarios/tests that require strict fixing of freq below the efficient level will need to disable it

[Intel-gfx] ✓ Fi.CI.BAT: success for video/hdmi: minor fixes for *_infoframe_init functions (rev2)

2023-04-21 Thread Patchwork
== Series Details == Series: video/hdmi: minor fixes for *_infoframe_init functions (rev2) URL : https://patchwork.freedesktop.org/series/116819/ State : success == Summary == CI Bug Log - changes from CI_DRM_13043 -> Patchwork_116819v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for video/hdmi: minor fixes for *_infoframe_init functions (rev2)

2023-04-21 Thread Patchwork
== Series Details == Series: video/hdmi: minor fixes for *_infoframe_init functions (rev2) URL : https://patchwork.freedesktop.org/series/116819/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for video/hdmi: minor fixes for *_infoframe_init functions (rev2)

2023-04-21 Thread Patchwork
== Series Details == Series: video/hdmi: minor fixes for *_infoframe_init functions (rev2) URL : https://patchwork.freedesktop.org/series/116819/ State : warning == Summary == Error: dim checkpatch failed c9787366d4ea video/hdmi: minor fixes for *_infoframe_init functions -:218:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: prevent potential div-by-zero

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915/dp: prevent potential div-by-zero URL : https://patchwork.freedesktop.org/series/116821/ State : success == Summary == CI Bug Log - changes from CI_DRM_13043 -> Patchwork_116821v1 Summary ---

[Intel-gfx] [PATCH v2 2/2] drm/i915/i915_drv: Use i915 instead of dev_priv insied the file_priv structure

2023-04-21 Thread Andi Shyti
In the process of renaming all instances of 'dev_priv' to 'i915', start using 'i915' within the i915_drv.h file. Signed-off-by: Andi Shyti Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/i915_drv.h | 458 1 file changed, 229 insertions(+), 229 deletions(-)

[Intel-gfx] [PATCH v2 1/2] drm/i915/i915_drv: Use proper parameter naming in for_each_engine()

2023-04-21 Thread Andi Shyti
for_each_engine() loops through engines in the GT, not in dev_priv. Because it's misleading, call it "gt__" instead of "dev_priv__". Signed-off-by: Andi Shyti Reviewed-by: Rodrigo Vivi Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[Intel-gfx] [PATCH v2 0/2] Use i915 instead of dev_priv

2023-04-21 Thread Andi Shyti
Hi, just another "Friday patch". While reviewing some patches from Tejas I found a bit confusing the use of dev_priv__ inside the for_each_engine(), perhaps it should be moved inside the gt/? As I was at it I made the /dev_priv/i915/ change which is still harmless. Next in queue is to change the

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: Copy c10 phy pll sw state from master to slave for bigjoiner

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Copy c10 phy pll sw state from master to slave for bigjoiner URL : https://patchwork.freedesktop.org/series/116805/ State : success == Summary == CI Bug Log - changes from CI_DRM_13039_full -> Patchwork_116805v1_full

[Intel-gfx] [PATCH v2 2/2] drm/i915/mtl: fix mocs selftest

2023-04-21 Thread Andi Shyti
From: Fei Yang Media GT has a different base for MOCS register, need to apply gsi_offset to the mmio address if not using the intel_uncore_r/w functions for register access. Cc: Matt Roper Signed-off-by: Fei Yang Reviewed-by: Matt Roper Signed-off-by: Andi Shyti ---

[Intel-gfx] [PATCH v2 1/2] drm/i915/mtl: Define MOCS and PAT tables for MTL

2023-04-21 Thread Andi Shyti
From: Madhumitha Tolakanahalli Pradeep On MTL, GT can no longer allocate on LLC - only the CPU can. This, along with programming new register bits that MTL requires calls for a MOCS/PAT table update. Also the PAT index registers are multicasted for primary GT, and there is an address jump from

[Intel-gfx] [PATCH v2 0/2] Define MOCS and PAT tables for MTL

2023-04-21 Thread Andi Shyti
Hi, just extracting this patch from Fei's series. Andi Changelog: == v1 -> v2: Taken from Fei's new series: https://patchwork.freedesktop.org/series/115980/ - Removed unnecessary defines - Place the selftest patches in a different patch Fei Yang (1): drm/i915/mtl: fix mocs selftest

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix memory leaks in i915 selftests (rev4)

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix memory leaks in i915 selftests (rev4) URL : https://patchwork.freedesktop.org/series/116513/ State : success == Summary == CI Bug Log - changes from CI_DRM_13043 -> Patchwork_116513v4 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix memory leaks in i915 selftests (rev4)

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix memory leaks in i915 selftests (rev4) URL : https://patchwork.freedesktop.org/series/116513/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

Re: [Intel-gfx] [PATCH v4 8/8] drm/i915: Allow user to set cache at BO creation

2023-04-21 Thread Matt Roper
On Fri, Apr 21, 2023 at 10:38:01AM -0700, fei.y...@intel.com wrote: > From: Fei Yang > > To comply with the design that buffer objects shall have immutable > cache setting through out their life cycle, {set, get}_caching ioctl's > are no longer supported from MTL onward. With that change caching

Re: [Intel-gfx] [bug report] drm/i915/guc: Use GuC submission API version number

2023-04-21 Thread John Harrison
On 3/24/2023 02:12, Dan Carpenter wrote: Hello John Harrison, The patch 9bbba0667f37: "drm/i915/guc: Use GuC submission API version number" from Nov 29, 2022, leads to the following Smatch static checker warning: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:821 intel_uc_fw_fetch()

Re: [Intel-gfx] [PATCH v4 2/8] drm/i915/mtl: fix mocs selftest

2023-04-21 Thread Matt Roper
On Fri, Apr 21, 2023 at 10:37:55AM -0700, fei.y...@intel.com wrote: > From: Fei Yang > > Media GT has a different base for MOCS register, need to apply > gsi_offset to the mmio address if not using the intel_uncore_r/w > functions for register access. > > Cc: Matt Roper > Signed-off-by: Fei

Re: [Intel-gfx] [PATCH 3/8] drm/i915/mtl: Add PTE encode function

2023-04-21 Thread Matt Roper
On Fri, Apr 21, 2023 at 10:27:22AM -0700, Yang, Fei wrote: >> On Wed, Apr 19, 2023 at 04:00:53PM -0700, fei.y...@intel.com wrote: >>> From: Fei Yang >>> >>> PTE encode functions are platform dependent. This patch implements >>> PTE functions for MTL, and ensures the correct

[Intel-gfx] [PATCH v4 5/8] drm/i915: use pat_index instead of cache_level

2023-04-21 Thread fei . yang
From: Fei Yang Currently the KMD is using enum i915_cache_level to set caching policy for buffer objects. This is flaky because the PAT index which really controls the caching behavior in PTE has far more levels than what's defined in the enum. In addition, the PAT index is platform dependent,

[Intel-gfx] [PATCH v4 4/8] drm/i915: preparation for using PAT index

2023-04-21 Thread fei . yang
From: Fei Yang This patch is a preparation for replacing enum i915_cache_level with PAT index. Caching policy for buffer objects is set through the PAT index in PTE, the old i915_cache_level is not sufficient to represent all caching modes supported by the hardware. Preparing the transition by

[Intel-gfx] [PATCH v4 7/8] drm/i915/mtl: end support for set caching ioctl

2023-04-21 Thread fei . yang
From: Fei Yang The design is to keep Buffer Object's caching policy immutable through out its life cycle. This patch ends the support for set caching ioctl from MTL onward. While doing that we also set BO's to be 1-way coherent at creation time because GPU is no longer automatically snooping CPU

[Intel-gfx] [PATCH v4 8/8] drm/i915: Allow user to set cache at BO creation

2023-04-21 Thread fei . yang
From: Fei Yang To comply with the design that buffer objects shall have immutable cache setting through out their life cycle, {set, get}_caching ioctl's are no longer supported from MTL onward. With that change caching policy can only be set at object creation time. The current code applies a

[Intel-gfx] [PATCH v4 6/8] drm/i915: make sure correct pte encode is used

2023-04-21 Thread fei . yang
From: Fei Yang PTE encode is platform dependent. After replacing cache_level with pat_index, the newly introduced mtl_pte_encode is actually generic for all gen12 platforms, thus rename it to gen12_pte_encode and apply it to all gen12 platforms. Cc: Chris Wilson Cc: Matt Roper Signed-off-by:

[Intel-gfx] [PATCH v4 3/8] drm/i915/mtl: Add PTE encode function

2023-04-21 Thread fei . yang
From: Fei Yang PTE encode functions are platform dependent. This patch implements PTE functions for MTL, and ensures the correct PTE encode function is used by calling pte_encode function pointer instead of the hardcoded gen8 version of PTE encode. Signed-off-by: Fei Yang Reviewed-by: Andrzej

[Intel-gfx] [PATCH v4 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL

2023-04-21 Thread fei . yang
From: Fei Yang The series includes patches needed to enable MTL. Also add new extension for GEM_CREATE uAPI to let user space set cache policy for buffer objects. v2: addressing review comments and checkpatch warnings v3: make mtl_ggtt_pte_encode static v4: addressing more comments from Matt

[Intel-gfx] [PATCH v4 1/8] drm/i915/mtl: Define MOCS and PAT tables for MTL

2023-04-21 Thread fei . yang
From: Madhumitha Tolakanahalli Pradeep On MTL, GT can no longer allocate on LLC - only the CPU can. This, along with programming new register bits that MTL requires calls for a MOCS/PAT table update. Also the PAT index registers are multicasted for primary GT, and there is an address jump from

[Intel-gfx] [PATCH v4 2/8] drm/i915/mtl: fix mocs selftest

2023-04-21 Thread fei . yang
From: Fei Yang Media GT has a different base for MOCS register, need to apply gsi_offset to the mmio address if not using the intel_uncore_r/w functions for register access. Cc: Matt Roper Signed-off-by: Fei Yang --- drivers/gpu/drm/i915/gt/selftest_mocs.c | 3 ++- 1 file changed, 2

Re: [Intel-gfx] [PATCH 3/8] drm/i915/mtl: Add PTE encode function

2023-04-21 Thread Yang, Fei
> On Wed, Apr 19, 2023 at 04:00:53PM -0700, fei.y...@intel.com wrote: >> From: Fei Yang >> >> PTE encode functions are platform dependent. This patch implements >> PTE functions for MTL, and ensures the correct PTE encode function >> is used by calling pte_encode function pointer instead of the

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/mtl: Extend Wa_22011802037 to MTL A-step

2023-04-21 Thread Sripada, Radhakrishna
> -Original Message- > From: Roper, Matthew D > Sent: Friday, April 21, 2023 8:09 AM > To: Atwood, Matthew S > Cc: Sripada, Radhakrishna ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/mtl: Extend Wa_22011802037 > to MTL A-step > > On Fri, Apr

[Intel-gfx] [PATCH v2] drm/i915/mtl: workaround coherency issue for Media

2023-04-21 Thread Nirmoy Das
From: Fei Yang This patch implements Wa_22016122933. In MTL, memory writes initiated by the Media tile update the whole cache line, even for partial writes. This creates a coherency problem for cacheable memory if both CPU and GPU are writing data to different locations within a single cache

Re: [Intel-gfx] [PATCH v8 3/8] drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet to GSC

2023-04-21 Thread Ceraolo Spurio, Daniele
On 4/20/2023 10:34 PM, Alan Previn wrote: Add helper functions into a new file for heci-packet-submission. The helpers will handle generating the MTL GSC-CS Memory-Header and submission of the Heci-Cmd-Packet instructions to the engine. NOTE1: These common functions for

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rc6: throw out set() wrapper

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915/rc6: throw out set() wrapper URL : https://patchwork.freedesktop.org/series/116817/ State : success == Summary == CI Bug Log - changes from CI_DRM_13041 -> Patchwork_116817v1 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/rc6: throw out set() wrapper

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915/rc6: throw out set() wrapper URL : https://patchwork.freedesktop.org/series/116817/ State : warning == Summary == Error: dim checkpatch failed df045eca0cc1 drm/i915/rc6: throw out set() wrapper -:38: WARNING:LONG_LINE_COMMENT: line length of 104 exceeds

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: Set has_llc=0

2023-04-21 Thread Matt Roper
On Thu, Apr 20, 2023 at 02:49:16PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915/mtl: Set has_llc=0 > URL : https://patchwork.freedesktop.org/series/116747/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_13033_full -> Patchwork_116747v1_full >

[Intel-gfx] ✓ Fi.CI.BAT: success for Use i915 instead of dev_priv

2023-04-21 Thread Patchwork
== Series Details == Series: Use i915 instead of dev_priv URL : https://patchwork.freedesktop.org/series/116816/ State : success == Summary == CI Bug Log - changes from CI_DRM_13041 -> Patchwork_116816v1 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 2/2] drm/i915/i915_drv: Use i915 instead of dev_priv insied the file_priv structure

2023-04-21 Thread Andrzej Hajda
On 21.04.2023 15:46, Andi Shyti wrote: In the process of renaming all instances of 'dev_priv' to 'i915', start using 'i915' within the 'drm_i915_file_private' structure. Signed-off-by: Andi Shyti --- Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [Intel-gfx] [PATCH 1/2] drm/i915/i915_drv: Use proper parameter naming in for_each_gt()

2023-04-21 Thread Andrzej Hajda
On 21.04.2023 15:46, Andi Shyti wrote: for_each_gt() loops through engines in the GT, not in dev_priv. Because it's misleading, call it "gt__" instead of "dev_priv__". Signed-off-by: Andi Shyti With fixes mentioned by Rodrigo. Reviewed-by: Andrzej Hajda Regards Andrzej ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Use i915 instead of dev_priv

2023-04-21 Thread Patchwork
== Series Details == Series: Use i915 instead of dev_priv URL : https://patchwork.freedesktop.org/series/116816/ State : warning == Summary == Error: dim checkpatch failed 4f2ff1f3fb31 drm/i915/i915_drv: Use proper parameter naming in for_each_gt() -:22: ERROR:COMPLEX_MACRO: Macros with

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/mtl: Extend Wa_22011802037 to MTL A-step

2023-04-21 Thread Matt Roper
On Fri, Apr 21, 2023 at 08:05:50AM -0700, Matt Roper wrote: > On Wed, Apr 19, 2023 at 02:40:33PM -0700, Matt Atwood wrote: > > On Tue, Apr 18, 2023 at 03:04:45PM -0700, Radhakrishna Sripada wrote: > > > From: Madhumitha Tolakanahalli Pradeep > > > > > > > > > Wa_22011802037 was being applied to

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/mtl: Extend Wa_22011802037 to MTL A-step

2023-04-21 Thread Matt Roper
On Wed, Apr 19, 2023 at 02:40:33PM -0700, Matt Atwood wrote: > On Tue, Apr 18, 2023 at 03:04:45PM -0700, Radhakrishna Sripada wrote: > > From: Madhumitha Tolakanahalli Pradeep > > > > > > Wa_22011802037 was being applied to all graphics_ver 11 & 12. This patch > > updates the if statement to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Restore HSW/BDW PSR1

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915/psr: Restore HSW/BDW PSR1 URL : https://patchwork.freedesktop.org/series/116814/ State : success == Summary == CI Bug Log - changes from CI_DRM_13041 -> Patchwork_116814v1 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/rc6: throw out set() wrapper

2023-04-21 Thread Matt Roper
On Fri, Apr 21, 2023 at 04:59:48PM +0300, Jani Nikula wrote: > Remove useless indirection that's just misdirection for the readers. > > Signed-off-by: Jani Nikula Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_rc6.c | 157 ++-- > 1 file changed, 76

Re: [Intel-gfx] [PATCH 2/2] drm/i915/i915_drv: Use i915 instead of dev_priv insied the file_priv structure

2023-04-21 Thread Andi Shyti
On Fri, Apr 21, 2023 at 10:07:28AM -0400, Rodrigo Vivi wrote: > On Fri, Apr 21, 2023 at 03:46:54PM +0200, Andi Shyti wrote: > > In the process of renaming all instances of 'dev_priv' to 'i915', > > start using 'i915' within the 'drm_i915_file_private' structure. > > The patch looks good but the

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/psr: Restore HSW/BDW PSR1

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915/psr: Restore HSW/BDW PSR1 URL : https://patchwork.freedesktop.org/series/116814/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:1:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/psr: Restore HSW/BDW PSR1

2023-04-21 Thread Patchwork
== Series Details == Series: drm/i915/psr: Restore HSW/BDW PSR1 URL : https://patchwork.freedesktop.org/series/116814/ State : warning == Summary == Error: dim checkpatch failed 142f6d9f694b drm/i915: Re-init clock gating on coming out of PC8+ fceac0743cce drm/i915/psr: Fix BDW PSR AUX CH

Re: [Intel-gfx] [PATCH 1/2] drm/i915/i915_drv: Use proper parameter naming in for_each_gt()

2023-04-21 Thread Andi Shyti
Hi Rodrigo, On Fri, Apr 21, 2023 at 10:05:07AM -0400, Rodrigo Vivi wrote: > On Fri, Apr 21, 2023 at 10:00:29AM -0400, Rodrigo Vivi wrote: > > On Fri, Apr 21, 2023 at 03:46:53PM +0200, Andi Shyti wrote: > > > for_each_gt() loops through engines in the GT, not in dev_priv. > > > > typo here? ^ > >

Re: [Intel-gfx] [PATCH v7 2/7] lib/ref_tracker: improve printing stats

2023-04-21 Thread Andrzej Hajda
On 21.04.2023 16:21, Eric Dumazet wrote: On Fri, Apr 21, 2023 at 1:35 PM Andrzej Hajda wrote: In case the library is tracking busy subsystem, simply printing stack for every active reference will spam log with long, hard to read, redundant stack traces. To improve readabilty following

Re: [Intel-gfx] [PATCH v7 1/7] lib/ref_tracker: add unlocked leak print helper

2023-04-21 Thread Eric Dumazet
On Fri, Apr 21, 2023 at 1:35 PM Andrzej Hajda wrote: > > To have reliable detection of leaks, caller must be able to check under the > same > lock both: tracked counter and the leaks. dir.lock is natural candidate for > such > lock and unlocked print helper can be called with this lock taken. >

Re: [Intel-gfx] [PATCH v7 4/7] lib/ref_tracker: remove warnings in case of allocation failure

2023-04-21 Thread Eric Dumazet
On Fri, Apr 21, 2023 at 1:35 PM Andrzej Hajda wrote: > > Library can handle allocation failures. To avoid allocation warnings > __GFP_NOWARN has been added everywhere. Moreover GFP_ATOMIC has been > replaced with GFP_NOWAIT in case of stack allocation on tracker free > call. > > Signed-off-by:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/display & drm/i915: more struct drm_edid conversions

2023-04-21 Thread Patchwork
== Series Details == Series: drm/display & drm/i915: more struct drm_edid conversions URL : https://patchwork.freedesktop.org/series/116813/ State : success == Summary == CI Bug Log - changes from CI_DRM_13041 -> Patchwork_116813v1 Summary

Re: [Intel-gfx] [PATCH v7 2/7] lib/ref_tracker: improve printing stats

2023-04-21 Thread Eric Dumazet
On Fri, Apr 21, 2023 at 1:35 PM Andrzej Hajda wrote: > > In case the library is tracking busy subsystem, simply > printing stack for every active reference will spam log > with long, hard to read, redundant stack traces. To improve > readabilty following changes have been made: > - reports are

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/display & drm/i915: more struct drm_edid conversions

2023-04-21 Thread Patchwork
== Series Details == Series: drm/display & drm/i915: more struct drm_edid conversions URL : https://patchwork.freedesktop.org/series/116813/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [BUG?] INFO: rcu_sched detected expedited stalls on CPUs/tasks: { 0-.... } 3 jiffies s: 309 root: 0x1/.

2023-04-21 Thread Rui Salvaterra
Hi again, everyone. So, while preparing to file the bug report with the requested information, I got a trace completely unrelated to DRM (on a swapon call, it seems). [4.868340] rcu: INFO: rcu_sched detected expedited stalls on CPUs/tasks: { 4- } 3 jiffies s: 265 root: 0x10/. [

[Intel-gfx] [PATCH] video/hdmi: minor fixes for *_infoframe_init functions

2023-04-21 Thread Nikita Zhandarovich
Multiple hdmi_*_infoframe_init() functions that initialize different types of hdmi infoframes only return default 0 value (contrary to their descriptions). Yet these functions are still checked against possible errors in case of failure. This patch removes redundant checks for errors in calls to

[Intel-gfx] [PATCH] drm/i915: Fix memory leaks in i915 selftests

2023-04-21 Thread Cong Liu
Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") Signed-off-by: Cong Liu --- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c

[Intel-gfx] [PATCH] drm/i915/dp: prevent potential div-by-zero

2023-04-21 Thread Nikita Zhandarovich
drm_dp_dsc_sink_max_slice_count() may return 0 if something goes wrong on the part of the DSC sink and its DPCD register. This null value may be later used as a divisor in intel_dsc_compute_params(), which will lead to an error. In the unlikely event that this issue occurs, fix it by testing the

Re: [Intel-gfx] [PATCH v7 0/7] drm/i915: use ref_tracker library for tracking wakerefs

2023-04-21 Thread Jakub Kicinski
On Fri, 21 Apr 2023 13:35:04 +0200 Andrzej Hajda wrote: > Gently ping for network developers, could you look at ref_tracker patches, > as the ref_tracker library was developed for network. Putting Eric in the To: field, I know email so hard and confusing...

Re: [Intel-gfx] [PATCH 2/2] drm/i915/i915_drv: Use i915 instead of dev_priv insied the file_priv structure

2023-04-21 Thread Rodrigo Vivi
On Fri, Apr 21, 2023 at 03:46:54PM +0200, Andi Shyti wrote: > In the process of renaming all instances of 'dev_priv' to 'i915', > start using 'i915' within the 'drm_i915_file_private' structure. The patch looks good but the commit message seems off to me... One thing we need to take care with

[Intel-gfx] [PATCH v2] video/hdmi: minor fixes for *_infoframe_init functions

2023-04-21 Thread Nikita Zhandarovich
Multiple hdmi_*_infoframe_init() functions that initialize different types of hdmi infoframes only return default 0 value (contrary to their descriptions). Yet these functions are still checked against possible errors in case of failure. This patch removes redundant checks for errors in calls to

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-21 Thread Alex Williamson
[Appears the list got dropped, replying to my previous message to re-add] On Tue, 11 Apr 2023 13:32:16 -0300 Jason Gunthorpe wrote: > On Tue, Apr 11, 2023 at 09:54:17AM -0600, Alex Williamson wrote: > > On Tue, 11 Apr 2023 10:24:58 -0300 > > Jason Gunthorpe wrote: > > > > > On Thu, Apr 06,

  1   2   >