Re: [Intel-gfx] [PATCH v9 6/8] drm/i915/uapi/pxp: Add a GET_PARAM for PXP

2023-05-04 Thread Teres Alexis, Alan Previn
On Thu, 2023-04-27 at 16:48 -0700, Teres Alexis, Alan Previn wrote: > Because of the additional firmware, component-driver and > initialization depedencies required on MTL platform before a > PXP context can be created, UMD calling for PXP creation as a > way to get-caps can take a long time. An

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: Check if media_gt exists (rev4)

2023-05-04 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Check if media_gt exists (rev4) URL : https://patchwork.freedesktop.org/series/117189/ State : success == Summary == CI Bug Log - changes from CI_DRM_13110 -> Patchwork_117189v4 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Communicate display power demands to pcode (rev6)

2023-05-04 Thread Patchwork
== Series Details == Series: drm/i915/display: Communicate display power demands to pcode (rev6) URL : https://patchwork.freedesktop.org/series/115371/ State : success == Summary == CI Bug Log - changes from CI_DRM_13108_full -> Patchwork_115371v6_full

[Intel-gfx] [PATCH] drm/i915/hdcp: Check if media_gt exists

2023-05-04 Thread Suraj Kandpal
Check if media_gt exists if we are using gsc cs --v2 -correct typo [Ankit] -assign gsc variable if gt exists [Ankit] --v3 -declare gsc and gt variables in if block [Ankit] --v4 -add fixes tag [Ankit] Fixes: 883631771038 ("drm/i915/mtl: Add HDCP GSC interface") Cc: Tomas Winkler Cc: Rodrigo

[Intel-gfx] [linux-next:master] BUILD REGRESSION 145e5cddfe8b4bf607510b2dcf630d95f4db420f

2023-05-04 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 145e5cddfe8b4bf607510b2dcf630d95f4db420f Add linux-next specific files for 20230504 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202304102354.q4voxgte-...@intel.com https

Re: [Intel-gfx] [PATCH v3 1/8] drm/i915: fix the derating percentage for MTL

2023-05-04 Thread Matt Roper
On Thu, Apr 27, 2023 at 06:00:09PM +0300, Vinod Govindapillai wrote: > Follow the values from bspec for the percentage overhead for > efficiency in MTL BW calculations. > > Bspec: 64631 > > Signed-off-by: Vinod Govindapillai Looks like the bspec was updated with this new value on March 30th.

Re: [Intel-gfx] [PATCH v1.1] drm/i915/mtl: Implement Wa_14019141245

2023-05-04 Thread Matt Roper
On Tue, Apr 25, 2023 at 11:30:11AM -0700, Radhakrishna Sripada wrote: > Enable strict RAR to prevent spurious GPU hangs. There's no such workaround as "Wa_14019141245." Were you trying to implement Wa_22016670082 instead? Matt > > v1.1: Rebase > > Cc: Rodrigo Vivi > Cc: Umesh Nerlige

[Intel-gfx] ✗ Fi.CI.BAT: failure for Update MTL GuC firmware

2023-05-04 Thread Patchwork
== Series Details == Series: Update MTL GuC firmware URL : https://patchwork.freedesktop.org/series/117346/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13109 -> Patchwork_117346v1 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Update MTL GuC firmware

2023-05-04 Thread Patchwork
== Series Details == Series: Update MTL GuC firmware URL : https://patchwork.freedesktop.org/series/117346/ State : warning == Summary == Error: dim checkpatch failed ef083bce246a drm/i915/uc: Track patch level versions on reduced version firmware files -:62: CHECK:MACRO_ARG_REUSE: Macro

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: hotplug and display irq refactoring

2023-05-04 Thread Patchwork
== Series Details == Series: drm/i915: hotplug and display irq refactoring URL : https://patchwork.freedesktop.org/series/117344/ State : success == Summary == CI Bug Log - changes from CI_DRM_13109 -> Patchwork_117344v1 Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gvt: KVM: KVMGT fixes and page-track cleanups (rev6)

2023-05-04 Thread Patchwork
== Series Details == Series: drm/i915/gvt: KVM: KVMGT fixes and page-track cleanups (rev6) URL : https://patchwork.freedesktop.org/series/112196/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/112196/revisions/6/mbox/ not applied Applying:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: hotplug and display irq refactoring

2023-05-04 Thread Patchwork
== Series Details == Series: drm/i915: hotplug and display irq refactoring URL : https://patchwork.freedesktop.org/series/117344/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: hotplug and display irq refactoring

2023-05-04 Thread Patchwork
== Series Details == Series: drm/i915: hotplug and display irq refactoring URL : https://patchwork.freedesktop.org/series/117344/ State : warning == Summary == Error: dim checkpatch failed e6ea91131db7 drm/i915/irq: relocate gmbus and dp aux irq handlers fedea70421f6 drm/i915/irq: split out

[Intel-gfx] ✓ Fi.CI.BAT: success for Introduce sink_format and other fixes (rev2)

2023-05-04 Thread Patchwork
== Series Details == Series: Introduce sink_format and other fixes (rev2) URL : https://patchwork.freedesktop.org/series/117056/ State : success == Summary == CI Bug Log - changes from CI_DRM_13109 -> Patchwork_117056v2 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Introduce sink_format and other fixes (rev2)

2023-05-04 Thread Patchwork
== Series Details == Series: Introduce sink_format and other fixes (rev2) URL : https://patchwork.freedesktop.org/series/117056/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 10/24] drm/i915/gem: fix function pointer member kernel-doc

2023-05-04 Thread Jani Nikula
On Thu, 04 May 2023, Rodrigo Vivi wrote: > On Thu, May 04, 2023 at 12:20:41PM +0300, Jani Nikula wrote: >> On Wed, 03 May 2023, Rodrigo Vivi wrote: >> > On Tue, May 02, 2023 at 06:37:27PM +0300, Jani Nikula wrote: >> >> You can't document function pointer member as functions. >> >> >> >>

Re: [Intel-gfx] [PATCH 05/24] drm/i915/vma: fix struct i915_vma_bindinfo kernel-doc

2023-05-04 Thread Jani Nikula
On Thu, 04 May 2023, Rodrigo Vivi wrote: > On Thu, May 04, 2023 at 12:43:05PM +0300, Jani Nikula wrote: >> On Wed, 03 May 2023, Rodrigo Vivi wrote: >> > On Tue, May 02, 2023 at 06:37:22PM +0300, Jani Nikula wrote: >> >> You can't document both a sub-struct type and a struct member at the >> >>

Re: [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check

2023-05-04 Thread Andrzej Hajda
On 04.05.2023 12:28, Juha-Pekka Heikkila wrote: From: Pallavi Mishra Remove FLAT CCS check from XY_FAST_COLOR_BLT usage, thus enabling MTL to use it. Signed-off-by: Pallavi Mishra Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Andrzej Hajda Regards Andrzej ---

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Pick one HDMI port for infoframe/audio transmission on g4x

2023-05-04 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Tuesday, November 8, 2022 1:16 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 5/5] drm/i915: Pick one HDMI port for > infoframe/audio > transmission on g4x > > From: Ville Syrjälä >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: move DSC RC tables to drm_dsc_helper.c (rev6)

2023-05-04 Thread Patchwork
== Series Details == Series: drm/i915: move DSC RC tables to drm_dsc_helper.c (rev6) URL : https://patchwork.freedesktop.org/series/114473/ State : success == Summary == CI Bug Log - changes from CI_DRM_13109 -> Patchwork_114473v6 Summary

Re: [Intel-gfx] [PATCH 2/2] drm/i915/mtl: Update GuC firmware version for MTL to 70.6.6

2023-05-04 Thread John Harrison
On 5/4/2023 13:29, Lucas De Marchi wrote: On Thu, May 04, 2023 at 01:22:52PM -0700, john.c.harri...@intel.com wrote: From: John Harrison Also switch to using reduced version file naming as it is no longer such a work-in-progress and likely to change. Signed-off-by: John Harrison commit

Re: [Intel-gfx] [PATCH v2 05/27] drm/i915/gvt: Verify VFIO-pinned page is THP when shadowing 2M gtt entry

2023-05-04 Thread Sean Christopherson
On Fri, Mar 17, 2023, Yan Zhao wrote: > On Fri, Mar 10, 2023 at 04:22:36PM -0800, Sean Christopherson wrote: > > When shadowing a GTT entry with a 2M page, explicitly verify that the > > first page pinned by VFIO is a transparent hugepage instead of assuming > > that page observed by

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/connector: document enum drm_connector_tv_mode DRM_MODE_TV_MODE_MAX

2023-05-04 Thread Patchwork
== Series Details == Series: drm/connector: document enum drm_connector_tv_mode DRM_MODE_TV_MODE_MAX URL : https://patchwork.freedesktop.org/series/117332/ State : success == Summary == CI Bug Log - changes from CI_DRM_13109 -> Patchwork_117332v1

Re: [Intel-gfx] [PATCH v5 3/3] drm/i915: make sure correct pte encode is used

2023-05-04 Thread Matt Roper
On Wed, May 03, 2023 at 03:51:00PM -0700, fei.y...@intel.com wrote: > From: Fei Yang > > PTE encode is platform dependent. After replacing cache_level with > pat_index, the newly introduced mtl_pte_encode is actually generic > for all gen12 platforms, thus rename it to gen12_pte_encode and >

Re: [Intel-gfx] [PATCH 2/2] drm/i915/mtl: Update GuC firmware version for MTL to 70.6.6

2023-05-04 Thread Lucas De Marchi
On Thu, May 04, 2023 at 01:22:52PM -0700, john.c.harri...@intel.com wrote: From: John Harrison Also switch to using reduced version file naming as it is no longer such a work-in-progress and likely to change. Signed-off-by: John Harrison commit message here will be bogus as it will be the

Re: [Intel-gfx] [PATCH v2 06/12] drm/i915: Add support for disabling any CRTCs during HW readout/sanitization

2023-05-04 Thread Imre Deak
On Thu, May 04, 2023 at 08:15:01PM +0300, Ville Syrjälä wrote: > On Thu, May 04, 2023 at 02:10:42AM +0300, Imre Deak wrote: > > During HW readout/sanitization CRTCs can be disabled only if they don't > > have an attached encoder (and so the encoder disable hooks don't need to > > be called). An

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/connector: document enum drm_connector_tv_mode DRM_MODE_TV_MODE_MAX

2023-05-04 Thread Patchwork
== Series Details == Series: drm/connector: document enum drm_connector_tv_mode DRM_MODE_TV_MODE_MAX URL : https://patchwork.freedesktop.org/series/117332/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH 1/2] drm/i915/uc: Track patch level versions on reduced version firmware files

2023-05-04 Thread John . C . Harrison
From: John Harrison When reduced version firmware files were added (matching major component being the only strict requirement), the minor version was still tracked and a notification reported if it was older. However, the patch version should really be tracked as well for the same reasons. The

[Intel-gfx] [PATCH 2/2] drm/i915/mtl: Update GuC firmware version for MTL to 70.6.6

2023-05-04 Thread John . C . Harrison
From: John Harrison Also switch to using reduced version file naming as it is no longer such a work-in-progress and likely to change. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH 0/2] Update MTL GuC firmware

2023-05-04 Thread John . C . Harrison
From: John Harrison Update MTL to the latest GuC release and switch to using reduced version file names. Also, pull in a patch from an earlier series that is waiting to merge to prevent merge conflicts later. Signed-off-by: John Harrison John Harrison (2): drm/i915/uc: Track patch level

Re: [Intel-gfx] [PATCH 2/4] drm/i915/mtl: Add MTL for remapping CCS FBs

2023-05-04 Thread Sripada, Radhakrishna
> -Original Message- > From: Intel-gfx On Behalf Of Juha- > Pekka Heikkila > Sent: Thursday, May 4, 2023 3:28 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 2/4] drm/i915/mtl: Add MTL for remapping CCS FBs > > From: Clint Taylor > > Add support for

Re: [Intel-gfx] [PATCH 3/3] drm/i915/irq: split out display irq handling

2023-05-04 Thread kernel test robot
Hi Jani, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-i915-irq-relocate-gmbus-and-dp-aux-irq-handlers/20230505-005945 base: git://anongit.freedesktop.org/drm/drm-tip

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: avoid flush_scheduled_work() usage (rev4)

2023-05-04 Thread Patchwork
== Series Details == Series: drm/i915: avoid flush_scheduled_work() usage (rev4) URL : https://patchwork.freedesktop.org/series/114608/ State : success == Summary == CI Bug Log - changes from CI_DRM_13109 -> Patchwork_114608v4 Summary

Re: [Intel-gfx] [PATCH v5 2/3] drm/i915: use pat_index instead of cache_level

2023-05-04 Thread Matt Roper
On Wed, May 03, 2023 at 03:50:59PM -0700, fei.y...@intel.com wrote: > From: Fei Yang > > Currently the KMD is using enum i915_cache_level to set caching policy for > buffer objects. This is flaky because the PAT index which really controls > the caching behavior in PTE has far more levels than

Re: [Intel-gfx] [PATCH v2 12/12] drm/i915/tc: Reset TypeC PHYs left enabled in DP-alt mode after the sink disconnects

2023-05-04 Thread Imre Deak
On Thu, May 04, 2023 at 08:41:49PM +0300, Ville Syrjälä wrote: > On Thu, May 04, 2023 at 02:10:48AM +0300, Imre Deak wrote: > > If the output on a DP-alt link with its sink disconnected is kept > > enabled for too long (about 20 sec), then some IOM/TCSS firmware timeout > > will cause havoc on the

Re: [Intel-gfx] [PATCH v2 20/27] KVM: x86/mmu: Use page-track notifiers iff there are external users

2023-05-04 Thread Sean Christopherson
On Wed, Mar 15, 2023, Sean Christopherson wrote: > On Wed, Mar 15, 2023, Yan Zhao wrote: > > On Fri, Mar 10, 2023 at 04:22:51PM -0800, Sean Christopherson wrote: > > > Disable the page-track notifier code at compile time if there are no > > > external users, i.e. if

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: avoid flush_scheduled_work() usage (rev4)

2023-05-04 Thread Patchwork
== Series Details == Series: drm/i915: avoid flush_scheduled_work() usage (rev4) URL : https://patchwork.freedesktop.org/series/114608/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: taint kernel when force probing unsupported devices (rev2)

2023-05-04 Thread Patchwork
== Series Details == Series: drm/i915: taint kernel when force probing unsupported devices (rev2) URL : https://patchwork.freedesktop.org/series/117231/ State : success == Summary == CI Bug Log - changes from CI_DRM_13109 -> Patchwork_117231v2

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check

2023-05-04 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check URL : https://patchwork.freedesktop.org/series/117272/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13109 -> Patchwork_117272v1

Re: [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check

2023-05-04 Thread Das, Nirmoy
On 5/4/2023 12:28 PM, Juha-Pekka Heikkila wrote: From: Pallavi Mishra Remove FLAT CCS check from XY_FAST_COLOR_BLT usage, thus enabling MTL to use it. Signed-off-by: Pallavi Mishra Signed-off-by: Juha-Pekka Heikkila I think should fix the mtl migrate selftest failure.

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check

2023-05-04 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check URL : https://patchwork.freedesktop.org/series/117272/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check

2023-05-04 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/mtl: Drop FLAT CCS check URL : https://patchwork.freedesktop.org/series/117272/ State : warning == Summary == Error: dim checkpatch failed ba3e9fcba540 drm/i915/mtl: Drop FLAT CCS check 04d76f28c9fd drm/i915/mtl: Add MTL for

Re: [Intel-gfx] [PATCH 3/3] drm/i915/irq: split out display irq handling

2023-05-04 Thread kernel test robot
Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-i915-irq-relocate-gmbus-and-dp-aux-irq-handlers/20230505-005945 base: git://anongit.freedesktop.org/drm/drm-tip

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: fix kernel-doc warnings, enable kernel-doc -Werror (rev2)

2023-05-04 Thread Patchwork
== Series Details == Series: drm/i915: fix kernel-doc warnings, enable kernel-doc -Werror (rev2) URL : https://patchwork.freedesktop.org/series/117207/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/117207/revisions/2/mbox/ not applied Applying:

Re: [Intel-gfx] [PATCH v2 12/12] drm/i915/tc: Reset TypeC PHYs left enabled in DP-alt mode after the sink disconnects

2023-05-04 Thread Ville Syrjälä
On Thu, May 04, 2023 at 02:10:48AM +0300, Imre Deak wrote: > If the output on a DP-alt link with its sink disconnected is kept > enabled for too long (about 20 sec), then some IOM/TCSS firmware timeout > will cause havoc on the PCI bus, at least for other GFX devices on it > which will stop

Re: [Intel-gfx] [PATCH v2 04/12] drm/i915: Separate intel_crtc_disable_noatomic_begin/complete()

2023-05-04 Thread Ville Syrjälä
On Thu, May 04, 2023 at 02:10:40AM +0300, Imre Deak wrote: > Split calling the CRTC/encoder disabling hooks and updating the CRTC and > DPLL object states from updating the CRTC and atomic state and other > global state (BW, CDCLK, DBUF) into separate functions. When disabling a > bigjoiner

Re: [Intel-gfx] [PATCH v2 06/12] drm/i915: Add support for disabling any CRTCs during HW readout/sanitization

2023-05-04 Thread Ville Syrjälä
On Thu, May 04, 2023 at 02:10:42AM +0300, Imre Deak wrote: > During HW readout/sanitization CRTCs can be disabled only if they don't > have an attached encoder (and so the encoder disable hooks don't need to > be called). An upcoming patch will need to disable CRTCs also with an > attached an

Re: [Intel-gfx] [PATCH v2 02/12] drm/i915: Make the CRTC state consistent during sanitize-disabling

2023-05-04 Thread Imre Deak
On Thu, May 04, 2023 at 05:38:12PM +0300, Ville Syrjälä wrote: > On Thu, May 04, 2023 at 02:10:38AM +0300, Imre Deak wrote: > > Make sure that the CRTC state is reset correctly, as expected after > > disabling the CRTC. > > > > In particular this change will: > > - Zero all the CSC blob pointers

[Intel-gfx] [PATCH 3/3] drm/i915/irq: split out display irq handling

2023-05-04 Thread Jani Nikula
Split (non-hotplug) display irq handling out of i915_irq.[ch] into display/intel_display_irq.[ch]. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile |1 + drivers/gpu/drm/i915/display/i9xx_plane.c |2 +- drivers/gpu/drm/i915/display/intel_crtc.c |2

[Intel-gfx] [PATCH 2/3] drm/i915/irq: split out hotplug irq handling

2023-05-04 Thread Jani Nikula
Split hotplug irq handling out of i915_irq.[ch] into display/intel_hotplug_irq.[ch]. The line between the new intel_hotplug_irq.[ch] and the existing intel_hotplug.[ch] needs further clarification, but the first step is to move the stuff out of i915_irq.[ch]. Signed-off-by: Jani Nikula ---

[Intel-gfx] [PATCH 1/3] drm/i915/irq: relocate gmbus and dp aux irq handlers

2023-05-04 Thread Jani Nikula
Move gmbus and dp aux irq handlers to their respective files. It should be up to them what to do with the irq, not the generic irq code. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp_aux.c | 5 +++ drivers/gpu/drm/i915/display/intel_dp_aux.h | 3 ++

[Intel-gfx] [PATCH 0/3] drm/i915: hotplug and display irq refactoring

2023-05-04 Thread Jani Nikula
Move hotplug and display irq handling to their respective files under display/. This is a start, with mostly just code movement. Further work clarifying the borders between these files as well as renames is to be expected. BR, Jani. Jani Nikula (3): drm/i915/irq: relocate gmbus and dp aux

Re: [Intel-gfx] [PATCH v8 0/7] drm/i915: use ref_tracker library for tracking wakerefs

2023-05-04 Thread Andrzej Hajda
Hi maintainers of net and i915, On 25.04.2023 00:05, Andrzej Hajda wrote: This is revived patchset improving ref_tracker library and converting i915 internal tracker to ref_tracker. The old thread ended without consensus about small kernel allocations, which are performed under spinlock. I have

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Communicate display power demands to pcode (rev6)

2023-05-04 Thread Patchwork
== Series Details == Series: drm/i915/display: Communicate display power demands to pcode (rev6) URL : https://patchwork.freedesktop.org/series/115371/ State : success == Summary == CI Bug Log - changes from CI_DRM_13108 -> Patchwork_115371v6

Re: [Intel-gfx] [PATCH v5 2/5] drm/i915: use pat_index instead of cache_level

2023-05-04 Thread Yang, Fei
> On 04/05/2023 00:02, fei.y...@intel.com wrote: >> From: Fei Yang >> >> Currently the KMD is using enum i915_cache_level to set caching policy for >> buffer objects. This is flaky because the PAT index which really controls >> the caching behavior in PTE has far more levels than what's defined

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Communicate display power demands to pcode (rev6)

2023-05-04 Thread Patchwork
== Series Details == Series: drm/i915/display: Communicate display power demands to pcode (rev6) URL : https://patchwork.freedesktop.org/series/115371/ State : warning == Summary == Error: dim checkpatch failed 3b2d5c3df035 drm/i915/display: Communicate display power demands to pcode -:9:

[Intel-gfx] [PATCH v5 8/8] drm/display/dsc: add YCbCr 4:2:2 and 4:2:0 RC parameters

2023-05-04 Thread Dmitry Baryshkov
Include RC parameters for YCbCr 4:2:2 and 4:2:0 configurations. Reviewed-by: Suraj Kandpal Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 438 +++ include/drm/display/drm_dsc_helper.h | 2 + 2 files changed, 440 insertions(+) diff

[Intel-gfx] [PATCH v5 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-04 Thread Dmitry Baryshkov
The array of rc_parameters contains a mixture of parameters from DSC 1.1 and DSC 1.2 standards. Split these tow configuration arrays in preparation to adding more configuration data. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 127 ++

[Intel-gfx] [PATCH v5 7/8] drm/display/dsc: include the rest of pre-SCR parameters

2023-05-04 Thread Dmitry Baryshkov
DSC model contains pre-SCR RC parameters for other bpp/bpc combinations, include them here for completeness. The values were generated from the 'pre_scr_cfg_files_for_reference' files found in DSC models 20210623. The same fileset is a part of DSC model 20161212. Signed-off-by: Dmitry Baryshkov

[Intel-gfx] [PATCH v5 5/8] drm/display/dsc: use flat array for rc_parameters lookup

2023-05-04 Thread Dmitry Baryshkov
Next commits are going to add support for additional RC parameter lookup tables. These tables are going to use different bpp/bpc combinations, thus it makes little sense to keep the 2d array for RC parameters. Switch to using the flat array. Reviewed-by: Jani Nikula Signed-off-by: Dmitry

[Intel-gfx] [PATCH v5 4/8] drm/i915/dsc: stop using interim structure for calculated params

2023-05-04 Thread Dmitry Baryshkov
Stop using an interim structure rc_parameters for storing calculated params and then setting drm_dsc_config using that structure. Instead put calculated params into the struct drm_dsc_config directly. Reviewed-by: Jani Nikula Signed-off-by: Dmitry Baryshkov ---

[Intel-gfx] [PATCH v5 0/8] drm/i915: move DSC RC tables to drm_dsc_helper.c

2023-05-04 Thread Dmitry Baryshkov
Other platforms (msm) will benefit from sharing the DSC config setup functions. This series moves parts of static DSC config data from the i915 driver to the common helpers to be used by other drivers. Note: the RC parameters were cross-checked against config files found in DSC model 2021062,

[Intel-gfx] [PATCH v5 3/8] drm/i915/dsc: move DSC tables to DRM DSC helper

2023-05-04 Thread Dmitry Baryshkov
Move DSC RC tables to DRM DSC helper. No additional code changes and/or cleanups are a part of this commit, it will be cleaned up in the followup commits. Reviewed-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 372 ++

[Intel-gfx] [PATCH v5 1/8] drm/i915/dsc: change DSC param tables to follow the DSC model

2023-05-04 Thread Dmitry Baryshkov
After cross-checking DSC models (20150914, 20161212, 20210623) change values in rc_parameters tables to follow config files present inside the DSC model. Handle two places, where i915 tables diverged from the model, by patching the rc values in the code. Note: I left one case uncorrected,

[Intel-gfx] [PATCH v5 2/8] drm/i915/dsc: move rc_buf_thresh values to common helper

2023-05-04 Thread Dmitry Baryshkov
The rc_buf_thresh values are common to all DSC implementations. Move them to the common helper together with the code to propagage them to the drm_dsc_config. Reviewed-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 35 +++

Re: [Intel-gfx] [PATCH v2 11/12] drm/i915: Factor out a helper for handling atomic modeset locks/state

2023-05-04 Thread Ville Syrjälä
On Thu, May 04, 2023 at 02:10:47AM +0300, Imre Deak wrote: > This patch simplifying the handling of modeset locks and atomic state > for an atomic commit is based on > > https://lore.kernel.org/all/20210715184954.7794-2-ville.syrj...@linux.intel.com/ > > adding the helper to i915. I find this

Re: [Intel-gfx] [PATCH v2 10/12] drm/i915/dp: Factor out intel_dp_get_active_pipes()

2023-05-04 Thread Ville Syrjälä
On Thu, May 04, 2023 at 02:10:46AM +0300, Imre Deak wrote: > Factor out a helper used by a follow up patch to reset an active DP > link. > > No functional changes. > > Signed-off-by: Imre Deak Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_dp.c | 20

Re: [Intel-gfx] [PATCH v2 09/12] drm/i915/dp: Prevent link training fallback on disconnected port

2023-05-04 Thread Ville Syrjälä
On Thu, May 04, 2023 at 02:10:45AM +0300, Imre Deak wrote: > Prevent downgrading the link training maximum lane count/rate if the > sink is disconnected - and so the link training failure is expected. In > such cases modeset failures due to the reduced max link params would be > just confusing for

Re: [Intel-gfx] [PATCH v2 08/12] drm/i915/dp: Convert link training error to debug message on disconnected sink

2023-05-04 Thread Ville Syrjälä
On Thu, May 04, 2023 at 02:10:44AM +0300, Imre Deak wrote: > If a sink is disconnected it's expected that link training actions will > fail on it, so downgrade the error messages about such actions to be a > debug message. Such - expected - link training failures are more > frequent after a follow

Re: [Intel-gfx] [PATCH 22/24] drm/i915/scatterlist: fix kernel-doc

2023-05-04 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:39PM +0300, Jani Nikula wrote: > Can't document function pointer members as if they are functions. > > drivers/gpu/drm/i915/i915_scatterlist.h:160: warning: Incorrect use of > kernel-doc format: * release() - Free the memory of the struct > i915_refct_sgt

Re: [Intel-gfx] [PATCH v2 07/12] drm/i915/dp: Add link training debug and error printing helpers

2023-05-04 Thread Ville Syrjälä
On Thu, May 04, 2023 at 02:10:43AM +0300, Imre Deak wrote: > Add functions for printing link training debug and error messages, both > to prepare for the next patch, which downgrades an error to a debug > message if the sink is disconnected and to remove some code duplication. > > v2: (Ville) > -

Re: [Intel-gfx] [PATCH 10/24] drm/i915/gem: fix function pointer member kernel-doc

2023-05-04 Thread Rodrigo Vivi
On Thu, May 04, 2023 at 12:20:41PM +0300, Jani Nikula wrote: > On Wed, 03 May 2023, Rodrigo Vivi wrote: > > On Tue, May 02, 2023 at 06:37:27PM +0300, Jani Nikula wrote: > >> You can't document function pointer member as functions. > >> > >> drivers/gpu/drm/i915/gem/i915_gem_region.h:25: warning:

Re: [Intel-gfx] [PATCH 05/24] drm/i915/vma: fix struct i915_vma_bindinfo kernel-doc

2023-05-04 Thread Rodrigo Vivi
On Thu, May 04, 2023 at 12:43:05PM +0300, Jani Nikula wrote: > On Wed, 03 May 2023, Rodrigo Vivi wrote: > > On Tue, May 02, 2023 at 06:37:22PM +0300, Jani Nikula wrote: > >> You can't document both a sub-struct type and a struct member at the > >> same time. Separate them. > > > > another way

Re: [Intel-gfx] [PATCH v2 05/12] drm/i915: Factor out set_encoder_for_connector()

2023-05-04 Thread Ville Syrjälä
On Thu, May 04, 2023 at 02:10:41AM +0300, Imre Deak wrote: > Factor out a function setting the encoder and CRTC in the connector > atomic state, required by a follow up patch. > > No functional changes. > > Signed-off-by: Imre Deak Reviewed-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH v2 03/12] drm/i915: Update connector atomic state before crtc sanitize-disabling

2023-05-04 Thread Ville Syrjälä
On Thu, May 04, 2023 at 02:10:39AM +0300, Imre Deak wrote: > During HW state readout/sanitization an up-to-date connector atomic > state will be required by a follow-up patch, which can disable CRTCs > with an encoder (and calling the correct encoder hooks happens via the > connector atomic state

Re: [Intel-gfx] [PATCH v2 01/12] drm/i915: Fix PIPEDMC disabling for a bigjoiner configuration

2023-05-04 Thread Ville Syrjälä
On Thu, May 04, 2023 at 02:10:37AM +0300, Imre Deak wrote: > For a bigjoiner configuration display->crtc_disable() will be called > first for the slave CRTCs and then for the master CRTC. However slave > CRTCs will be actually disabled only after the master CRTC is disabled > (from the encoder

Re: [Intel-gfx] [PATCH v2 02/12] drm/i915: Make the CRTC state consistent during sanitize-disabling

2023-05-04 Thread Ville Syrjälä
On Thu, May 04, 2023 at 02:10:38AM +0300, Imre Deak wrote: > Make sure that the CRTC state is reset correctly, as expected after > disabling the CRTC. > > In particular this change will: > - Zero all the CSC blob pointers after intel_crtc_free_hw_state() > has freed them. > - Zero the shared

Re: [Intel-gfx] [PATCH v4 2/3] drm/i915: use pat_index instead of cache_level

2023-05-04 Thread Tvrtko Ursulin
On 03/05/2023 21:39, Yang, Fei wrote: [...] diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c index 8c70a0ec7d2f..27c948350b5b 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c @@ -54,6

Re: [Intel-gfx] [PATCH] drm/connector: document enum drm_connector_tv_mode DRM_MODE_TV_MODE_MAX

2023-05-04 Thread Simon Ser
Reviewed-by: Simon Ser

[Intel-gfx] [PULL] drm-intel-next-fixes

2023-05-04 Thread Joonas Lahtinen
Hi Dave & Daniel, One Cc stable DSI sequence fix and missing CPU transcoders for MTL plus a smaller GuC cornern case fix. Best Regards, Joonas *** drm-intel-next-fixes-2023-05-04-1: Add missing GPU transcoder masks for MTL and fix DSI power on sequence for Nextbook Ares 8A. Fix GuC version

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/ttm: fix i915_ttm_to_gem() kernel-doc

2023-05-04 Thread Patchwork
== Series Details == Series: drm/i915/ttm: fix i915_ttm_to_gem() kernel-doc URL : https://patchwork.freedesktop.org/series/117269/ State : success == Summary == CI Bug Log - changes from CI_DRM_13107_full -> Patchwork_117269v1_full Summary

Re: [Intel-gfx] [PATCH v5 2/5] drm/i915: use pat_index instead of cache_level

2023-05-04 Thread Tvrtko Ursulin
On 04/05/2023 00:02, fei.y...@intel.com wrote: From: Fei Yang Currently the KMD is using enum i915_cache_level to set caching policy for buffer objects. This is flaky because the PAT index which really controls the caching behavior in PTE has far more levels than what's defined in the enum.

[Intel-gfx] [PATCH] drm/connector: document enum drm_connector_tv_mode DRM_MODE_TV_MODE_MAX

2023-05-04 Thread Jani Nikula
Add documentation for the DRM_MODE_TV_MODE_MAX enumerator to fix the kernel-doc warning: include/drm/drm_connector.h:204: warning: Enum value 'DRM_MODE_TV_MODE_MAX' not described in enum 'drm_connector_tv_mode' Signed-off-by: Jani Nikula --- include/drm/drm_connector.h | 5 + 1 file

[Intel-gfx] 2023 X.Org Foundation Election vote results

2023-05-04 Thread Ricardo Garcia
The Board of Directors election and the vote on the By-laws concluded at 14:00 UTC on May 1st 2023 and these are the results: - We had 75 members this year, of which 55 cast a vote, so the turnout is 73.3%. - On the question "Do you accept the proposed By-Law changes to make SFC the new fiscal

Re: [Intel-gfx] PR for new GuC v70.6.6 for MTL

2023-05-04 Thread Josh Boyer
On Wed, May 3, 2023 at 12:58 PM wrote: > > The following changes since commit 312c61f5a6c9c6a313383a8f0c2b02711ec15262: > > amdgpu: update DCN 3.1.6 DMCUB firmware (2023-05-03 09:11:02 -0400) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-firmware

Re: [Intel-gfx] [PATCH v2] drm/i915/ttm: fix i915_ttm_to_gem() kernel-doc

2023-05-04 Thread Das, Nirmoy
On 5/4/2023 11:23 AM, Jani Nikula wrote: drivers/gpu/drm/i915/gem/i915_gem_ttm.h:50: warning: Function parameter or member 'bo' not described in 'i915_ttm_to_gem' v2: Fix return value documentation while at it (Rodrigo) Signed-off-by: Jani Nikula Reviewed-by: Nirmoy Das ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ttm: fix i915_ttm_to_gem() kernel-doc

2023-05-04 Thread Patchwork
== Series Details == Series: drm/i915/ttm: fix i915_ttm_to_gem() kernel-doc URL : https://patchwork.freedesktop.org/series/117269/ State : success == Summary == CI Bug Log - changes from CI_DRM_13107 -> Patchwork_117269v1 Summary ---

[Intel-gfx] [PATCH v2] drm/i915: taint kernel when force probing unsupported devices

2023-05-04 Thread Jani Nikula
For development and testing purposes, the i915.force_probe module parameter and DRM_I915_FORCE_PROBE kconfig option allow probing of devices that aren't supported by the driver. The i915.force_probe module parameter is "unsafe" and setting it taints the kernel. However, using the kconfig option

Re: [Intel-gfx] [PATCH] drm/i915/hdcp: Check if media_gt exists

2023-05-04 Thread Nautiyal, Ankit K
I think we can add fixes tag: Fixes: 883631771038 ("drm/i915/mtl: Add HDCP GSC interface") with relevant folks in CC. Otherwise, LGTM. Reviewed-by: Ankit Nautiyal On 5/3/2023 3:42 PM, Suraj Kandpal wrote: Check if media_gt exists if we are using gsc cs --v2 -correct typo [Ankit] -assign

[Intel-gfx] [PATCH 4/4] drm/i915/mtl: Add handling for MTL ccs modifiers

2023-05-04 Thread Juha-Pekka Heikkila
Add Tile4 ccs modifiers w/ auxbuffer handling Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/display/intel_fb.c | 42 ++- .../drm/i915/display/skl_universal_plane.c| 22 +- 2 files changed, 61 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH 3/4] drm/fourcc: define Intel Meteorlake related ccs modifiers

2023-05-04 Thread Juha-Pekka Heikkila
Add Tile4 type ccs modifiers with aux buffer needed for MTL Cc: dri-de...@lists.freedesktop.org Signed-off-by: Juha-Pekka Heikkila --- include/uapi/drm/drm_fourcc.h | 43 +++ 1 file changed, 43 insertions(+) diff --git a/include/uapi/drm/drm_fourcc.h

[Intel-gfx] [PATCH 2/4] drm/i915/mtl: Add MTL for remapping CCS FBs

2023-05-04 Thread Juha-Pekka Heikkila
From: Clint Taylor Add support for remapping CCS FBs on MTL to remove the restriction of the power-of-two sized stride and the 2MB surface offset alignment for these FBs. Signed-off-by: Clint Taylor Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/display/intel_fb.c |

[Intel-gfx] [PATCH 1/4] drm/i915/mtl: Drop FLAT CCS check

2023-05-04 Thread Juha-Pekka Heikkila
From: Pallavi Mishra Remove FLAT CCS check from XY_FAST_COLOR_BLT usage, thus enabling MTL to use it. Signed-off-by: Pallavi Mishra Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/gt/intel_migrate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Intel-gfx] [PATCH v5 5/5] drm/i915/gt: Make sure that errors are propagated through request chains

2023-05-04 Thread Andi Shyti
Hi Tvrtko, > Another option - maybe - is this related to revert of fence error > propagation? If it is and having that would avoid the need for this invasive > fix, maybe we unrevert 3761baae908a7b5012be08d70fa553cc2eb82305 with edits > to limit to special contexts? If doable.. I think that is

Re: [Intel-gfx] [PATCH 05/24] drm/i915/vma: fix struct i915_vma_bindinfo kernel-doc

2023-05-04 Thread Jani Nikula
On Wed, 03 May 2023, Rodrigo Vivi wrote: > On Tue, May 02, 2023 at 06:37:22PM +0300, Jani Nikula wrote: >> You can't document both a sub-struct type and a struct member at the >> same time. Separate them. > > another way would be to kill the 'i915_vma_bindinfo' name entirely and > document only

[Intel-gfx] [PATCH] drm/i915/display: Communicate display power demands to pcode

2023-05-04 Thread Stanislav Lisovskiy
Display to communicate display pipe count/CDCLK/voltage configuration to Pcode for more accurate power accounting for DG2. Existing sequence is only sending the voltage value to the Pcode. Adding new sequence with current cdclk associate with voltage value masking. Adding pcode request when any

Re: [Intel-gfx] [PATCH v5 5/5] drm/i915/gt: Make sure that errors are propagated through request chains

2023-05-04 Thread Andi Shyti
Hi Tvrtko, sorry for the very late reply, it's about time to bring this patch up. On Thu, Apr 13, 2023 at 12:56:00PM +0100, Tvrtko Ursulin wrote: > > On 12/04/2023 12:33, Andi Shyti wrote: > > Currently, when we perform operations such as clearing or copying > > large blocks of memory, we

Re: [Intel-gfx] [PATCH 11/24] drm/i915/ttm: fix i915_ttm_to_gem() kernel-doc

2023-05-04 Thread Jani Nikula
On Wed, 03 May 2023, Rodrigo Vivi wrote: > On Tue, May 02, 2023 at 06:37:28PM +0300, Jani Nikula wrote: >> drivers/gpu/drm/i915/gem/i915_gem_ttm.h:50: warning: Function parameter or >> member 'bo' not described in 'i915_ttm_to_gem' >> >> Signed-off-by: Jani Nikula >> --- >>

[Intel-gfx] [PATCH v2] drm/i915/ttm: fix i915_ttm_to_gem() kernel-doc

2023-05-04 Thread Jani Nikula
drivers/gpu/drm/i915/gem/i915_gem_ttm.h:50: warning: Function parameter or member 'bo' not described in 'i915_ttm_to_gem' v2: Fix return value documentation while at it (Rodrigo) Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gem/i915_gem_ttm.h | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Intel-gfx] [PATCH 10/24] drm/i915/gem: fix function pointer member kernel-doc

2023-05-04 Thread Jani Nikula
On Wed, 03 May 2023, Rodrigo Vivi wrote: > On Tue, May 02, 2023 at 06:37:27PM +0300, Jani Nikula wrote: >> You can't document function pointer member as functions. >> >> drivers/gpu/drm/i915/gem/i915_gem_region.h:25: warning: Incorrect use of >> kernel-doc format: * process_obj -

  1   2   >