LGTM.
Reviewed-by: Ankit Nautiyal
On 4/21/2023 5:17 PM, Jani Nikula wrote:
Convert the remaining uses of struct edid based drm_get_edid(),
drm_connector_update_edid_property() and drm_add_edid_modes() calls to
the struct drm_edid based drm_edid_read_ddc(),
drm_edid_connector_update() and
> From: Alex Williamson
> Sent: Thursday, May 25, 2023 4:20 AM
>
> On Mon, 22 May 2023 04:57:51 -0700
> Yi Liu wrote:
>
> > This is the way user to invoke hot-reset for the devices opened by cdev
> > interface. User should check the flag VFIO_PCI_HOT_RESET_FLAG_DEV_ID_OWNED
> > in the output
LGTM.
Reviewed-by: Ankit Nautiyal
On 4/21/2023 5:17 PM, Jani Nikula wrote:
Add a switcheroo variant to the struct drm_edid based EDID read
functions.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 29 +
include/drm/drm_edid.h | 2 ++
2 files
Hi,
On 2023/5/30 03:36, Sam Ravnborg wrote:
Hi Thomas,
On Wed, May 24, 2023 at 11:21:50AM +0200, Thomas Zimmermann wrote:
Implement dedicated fbdev helpers for framebuffer I/O instead
of using DRM's helpers. Use an fbdev generator macro for
deferred I/O to create the fbdev callbacks. i915 was
Hi all,
On Tue, 30 May 2023 11:57:52 +1000 Stephen Rothwell
wrote:
>
> @@@ -920,33 -587,8 +640,9 @@@ static const struct intel_device_info j
> #define GEN12_FEATURES \
> GEN11_FEATURES, \
> GEN(12), \
> - .display.abox_mask = GENMASK(2, 1), \
> - .__runtime.pipe_mask =
Hi all,
Today's linux-next merge of the drm-intel tree got a conflict in:
drivers/gpu/drm/i915/i915_drv.h
between commit:
66ca1d8f222b ("drm/i915/i915_drv: Use i915 instead of dev_priv insied the
file_priv structure")
from the drm tree and commits:
5af5169d7582 ("drm/i915: Convert
Hi all,
Today's linux-next merge of the drm-intel tree got a conflict in:
drivers/gpu/drm/i915/i915_pci.c
between commit:
5e352e32aec2 ("drm/i915: preparation for using PAT index")
from the drm tree and commits:
5af5169d7582 ("drm/i915: Convert INTEL_INFO()->display to a pointer")
Replace all drm-shmem locks with a GEM reservation lock. This makes locks
consistent with dma-buf locking convention where importers are responsible
for holding reservation lock for all operations performed over dma-bufs,
preventing deadlock between dma-buf importers and exporters.
Suggested-by:
Don't assert held dma-buf reservation lock on memory mapping of exported
buffer.
We're going to change dma-buf mmap() locking policy such that exporters
will have to handle the lock. The previous locking policy caused deadlock
problem for DRM drivers in a case of self-imported dma-bufs once these
Change locking policy of mmap() callback, making exporters responsible
for handling dma-buf reservation locking. Previous locking policy stated
that dma-buf is locked for both importers and exporters by the dma-buf
core, which caused a deadlock problem for DRM drivers in a case of
self-imported
Don't assert held dma-buf reservation lock on memory mapping of exported
buffer.
We're going to change dma-buf mmap() locking policy such that exporters
will have to handle the lock. The previous locking policy caused deadlock
problem for DRM drivers in a case of self-imported dma-bufs once these
Don't assert held dma-buf reservation lock on memory mapping of exported
buffer.
We're going to change dma-buf mmap() locking policy such that exporters
will have to handle the lock. The previous locking policy caused deadlock
problem for DRM drivers in a case of self-imported dma-bufs once these
Don't assert held dma-buf reservation lock on memory mapping of exported
buffer.
We're going to change dma-buf mmap() locking policy such that exporters
will have to handle the lock. The previous locking policy caused deadlock
problem for DRM drivers in a case of self-imported dma-bufs once these
This patchset makes dma-buf exporters responisble for taking care of
the reservation lock. I also included patch that moves drm-shmem to use
reservation lock, to let CI test the whole set. I'm going to take all
the patches via the drm-misc tree, please give an ack.
Previous policy stated that
On 5/22/23 16:02, Emil Velikov wrote:
>> -void drm_gem_shmem_put_pages(struct drm_gem_shmem_object *shmem)
>> +static int drm_gem_shmem_pin_locked(struct drm_gem_shmem_object *shmem)
>> +{
>> + int ret;
>> +
>> + dma_resv_assert_held(shmem->base.resv);
>> +
>> + ret =
Hi Thomas,
On Wed, May 24, 2023 at 11:21:50AM +0200, Thomas Zimmermann wrote:
> Implement dedicated fbdev helpers for framebuffer I/O instead
> of using DRM's helpers. Use an fbdev generator macro for
> deferred I/O to create the fbdev callbacks. i915 was the only
> caller of the DRM helpers, so
On Wed, May 24, 2023 at 11:21:48AM +0200, Thomas Zimmermann wrote:
> Export drm_fb_helper_damage() and drm_fb_helper_damage_range(), which
> handle damage areas for fbdev emulation. This is a temporary export
> that allows to move the DRM I/O helpers for fbdev into drivers. Only
> fbdev-generic
Hi Thomas.
> v4:
> * use initializer and generator macros for struct fb_ops
> * partially support damage handling in msm (Dmitri)
I like the macros. They make it simpler and we do not spread the _cfb_
misname to more files.
> v3:
> * fix Kconfig options (Jingfeng)
> *
Hi Thomas,
On Wed, May 24, 2023 at 11:21:50AM +0200, Thomas Zimmermann wrote:
> Implement dedicated fbdev helpers for framebuffer I/O instead
> of using DRM's helpers. Use an fbdev generator macro for
> deferred I/O to create the fbdev callbacks. i915 was the only
> caller of the DRM helpers, so
On Wed, May 24, 2023 at 11:21:40AM +0200, Thomas Zimmermann wrote:
> Use the regular fbdev helpers for framebuffer I/O instead of DRM's
> helpers. Armada does not use damage handling, so DRM's fbdev helpers
> are mere wrappers around the fbdev code.
>
> By using fbdev helpers directly within each
On Wed, May 24, 2023 at 11:21:39AM +0200, Thomas Zimmermann wrote:
> For framebuffers in I/O and system memory, add macros that set
> struct fb_ops to the respective callback functions.
>
> For deferred I/O, add macros that generate callback functions with
> damage handling. Add initializer
Hi Thomas,
On Wed, May 24, 2023 at 11:21:38AM +0200, Thomas Zimmermann wrote:
> Many fbdev drivers use the same set of fb_ops helpers. Add Kconfig
> options to select them at once. This will help with making DRM's
> fbdev emulation code more modular, but can also be used to simplify
> fbdev's
On Fri, May 26, 2023 at 03:50:55PM +0300, Vinod Govindapillai wrote:
> From: Mika Kahola
>
> MTL introduces a new way to instruct the PUnit with
> power and bandwidth requirements of DE. Add the functionality
> to program the registers and handle waits using interrupts.
> The current wait time
HW default for wake sync pulses is 18. 10 precarge and 8 preamble. There is
no reason to change this especially as it is causing problems with certain
eDP panels.
v2: Remove "fast wake" repeat from subject
Signed-off-by: Jouni Högander
Fixes: 605f7c731333 ("drm/i915: Fix fast wake AUX sync
On 5/27/2023 12:38 AM, Jani Nikula wrote:
Prepare for re-enabling -Wunused-but-set-variable.
Lacking a better idea, annotate the gma_bottom variables with
__maybe_unused.
Cc: Zhenyu Wang
Cc: Zhi Wang
Cc: intel-gvt-...@lists.freedesktop.org
Signed-off-by: Jani Nikula
---
Frankly I'm not
Remove unused variable gma_bottom in scan_workload() and scan_wa_ctx().
commit be1da7070aea ("drm/i915/gvt: vGPU command scanner") introduces
gma_bottom in several functions to calculate the size of the command
buffer. However, some of them are set but actually unused.
When compiling the code
== Series Details ==
Series: drm/i915: re-enable -Wunused-but-set-variable (rev4)
URL : https://patchwork.freedesktop.org/series/118439/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13198_full -> Patchwork_118439v4_full
== Series Details ==
Series: drm/i915_drm.h: fix a typo
URL : https://patchwork.freedesktop.org/series/118479/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13198_full -> Patchwork_118479v1_full
Summary
---
LGTM.
Reviewed-by: Ankit Nautiyal
On 4/21/2023 5:17 PM, Jani Nikula wrote:
It's a bit tedious to check for NULL before calling
drm_edid_duplicate(). Make it handle NULL parameter graciously.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 3 +++
1 file changed, 3
On 4/21/2023 5:17 PM, Jani Nikula wrote:
Convert the topology manager to use struct drm_edid, add
drm_dp_mst_edid_read() that returns drm_edid, and rewrite the old
drm_dp_mst_get_edid() to use it.
Note that the old drm_get_edid() ended up calling
drm_connector_update_edid_property(). This
HW default for wake sync pulses is 18. 10 precarge and 8 preamble. There is
no reason to change this especially as it is causing problems with certain
eDP panels.
Signed-off-by: Jouni Högander
Fixes: 605f7c731333 ("drm/i915: Fix fast wake AUX sync len")
Closes:
> -Original Message-
> From: Kandpal, Suraj
> Sent: Monday, May 29, 2023 4:38 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Kandpal, Suraj ; Borah, Chaitanya Kumar
> ; Nautiyal, Ankit K
> ; Nikula, Jani
> Subject: [PATCH v4 2/3] drm/i915/hdcp: Move away from master naming to
> arbiter
>
== Series Details ==
Series: Do not access i915_gem_object members from frontbuffer tracking
URL : https://patchwork.freedesktop.org/series/118475/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13198_full -> Patchwork_118475v1_full
Allocate a multipage object that can be used for input
and output for intel_hdcp_gsc_message so that corruption of
output message can be avoided by the current overwriting method.
--v2
-Change approach from allocating two objects to just one multipage
object [Daniele]
Cc: Ankit Nautiyal
Cc:
Modify intel_gsc_send_sync() to take into account header_out
and addr_out so as to use them to verify the message send status.
Cc: Daniele Ceraolo Spurio
Cc: Alan Previn
Cc: Ankit Nautiyal
Signed-off-by: Suraj Kandpal
---
drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 29 +++
Change HDCP GSC message memory allocation to use same object with
multiple pages one page pointing to input while other points to
output to avoid corruption of output message that can be caused by
overwriting.
Signed-off-by: Suraj Kandpal
Suraj Kandpal (2):
drm/i915/hdcp: Allocate a multipage
From: Maarten Lankhorst
We enable the DP aux channel during probe, but may free the connector
soon afterwards. Ensure the DP aux display power put (and any other
async put for that matter) is completed before everything is freed, to
prevent a use-after-free in icl_aux_pw_to_phy(), called from
'rbiter' -> 'arbiter'
Signed-off-by: Sui Jingfeng
---
include/drm/i915_drm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
index 7adce327c1c2..adff68538484 100644
--- a/include/drm/i915_drm.h
+++ b/include/drm/i915_drm.h
@@
Hi,
I'm just hesitating to so, thank you.
On 2023/5/29 18:06, Jani Nikula wrote:
On Mon, 29 May 2023, Sui Jingfeng <15330273...@189.cn> wrote:
Hi,
On 2023/5/29 16:06, Jani Nikula wrote:
On Mon, 29 May 2023, Sui Jingfeng wrote:
'rbiter' -> 'arbite'
Should be arbiter.
Yeah, should
Rename comp_mutex to hdcp_mutex as it does not just
protect component related variables which was a terminology
used when hdcp was to be binded as a mei component from MTL
we use gsc cs which does not use the component binding path
for HDCP.
Cc: Jani Nikula
Cc: Ankit Nautiyal
Signed-off-by:
Rename variables to move away from master convention to
arbiter
%s/hdcp.master/hdcp.arbiter
%s/i915_hdcp_master/i915_hdcp_arbiter
%s/comp_master/comp_arbiter
--v2
- delete i915_hdcp_comp_master redundant declaration [Chaitanya]
- use %s/foo/bar/ format in commit message to show changes
Rename dev_priv to i915 to keep up with latest code standards.
Cc: Ankit Nautiyal
Cc: Jani Nikula
Signed-off-by: Suraj Kandpal
Reviewed-by: Chaitanya Kumar Borah
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 630 +++---
drivers/gpu/drm/i915/display/intel_hdcp.h | 6 +-
2
Some basic cleanup of hdcp code.
Consists of
-rename dev_priv to i915.
-move away from master naming rename it to arbiter.
-rename comp_mutex to hdcp_mutex.
Signed-off-by: Suraj Kandpal
Suraj Kandpal (3):
drm/i915/hdcp: Rename dev_priv to i915
drm/i915/hdcp: Move away from master naming to
From: Maarten Lankhorst
enum i915_drm_suspend_mode suspend_mode is only used in
intel_display_power, while we only care about whether we perform a
s2idle. Remove it and use a simple bool.
v2: Rebase
Signed-off-by: Maarten Lankhorst
Reviewed-by: Rodrigo Vivi # v1
Signed-off-by: Jani Nikula
On Mon, 29 May 2023, Sui Jingfeng <15330273...@189.cn> wrote:
> Hi,
>
>
> On 2023/5/29 16:06, Jani Nikula wrote:
>> On Mon, 29 May 2023, Sui Jingfeng wrote:
>>> 'rbiter' -> 'arbite'
>> Should be arbiter.
>
> Yeah, should be arbiter.
>
> arbiter is a noun. Here, this arbiter may referrer to the
On Mon, 29 May 2023, Dan Carpenter wrote:
> Hi Jani,
>
> kernel test robot noticed the following build warnings:
Thanks, v2 already on the list:
https://patchwork.freedesktop.org/patch/msgid/20230526172218.1597394-1-jani.nik...@intel.com
>
> url:
>
== Series Details ==
Series: drm/i915/display: Set correct voltage level for 480MHz CDCLK (rev2)
URL : https://patchwork.freedesktop.org/series/114752/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13198_full -> Patchwork_114752v2_full
== Series Details ==
Series: drm/i915: re-enable -Wunused-but-set-variable (rev4)
URL : https://patchwork.freedesktop.org/series/118439/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13198 -> Patchwork_118439v4
Summary
Hi Jani,
kernel test robot noticed the following build warnings:
url:
https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-i915-plane-warn-on-non-zero-plane-offset/20230527-003951
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
patch link:
Hi Vinod,
kernel test robot noticed the following build warnings:
url:
https://github.com/intel-lab-lkp/linux/commits/Vinod-Govindapillai/drm-i915-fix-the-derating-percentage-for-MTL/20230526-205305
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
patch link:
== Series Details ==
Series: drm/i915: re-enable -Wunused-but-set-variable (rev4)
URL : https://patchwork.freedesktop.org/series/118439/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915_drm.h: fix a typo
URL : https://patchwork.freedesktop.org/series/118479/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13198 -> Patchwork_118479v1
Summary
---
**SUCCESS**
No
Hi,
On 2023/5/29 16:06, Jani Nikula wrote:
On Mon, 29 May 2023, Sui Jingfeng wrote:
'rbiter' -> 'arbite'
Should be arbiter.
Yeah, should be arbiter.
arbiter is a noun. Here, this arbiter may referrer to the
drivers/pci/vgaarb.c.
Can you help correct then apply it ? thanks.
== Series Details ==
Series: Do not access i915_gem_object members from frontbuffer tracking
URL : https://patchwork.freedesktop.org/series/118475/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13198 -> Patchwork_118475v1
On Mon, 29 May 2023, Sui Jingfeng wrote:
> 'rbiter' -> 'arbite'
Should be arbiter.
>
> Signed-off-by: Sui Jingfeng
> ---
> include/drm/i915_drm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
> index
== Series Details ==
Series: Do not access i915_gem_object members from frontbuffer tracking
URL : https://patchwork.freedesktop.org/series/118475/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Do not access i915_gem_object members from frontbuffer tracking
URL : https://patchwork.freedesktop.org/series/118475/
State : warning
== Summary ==
Error: make ARCH=i386 failed
CALLscripts/checksyscalls.sh
DESCEND objtool
INSTALL libsubcmd_headers
CC
'rbiter' -> 'arbite'
Signed-off-by: Sui Jingfeng
---
include/drm/i915_drm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
index 7adce327c1c2..3dcb1db519ae 100644
--- a/include/drm/i915_drm.h
+++ b/include/drm/i915_drm.h
@@
== Series Details ==
Series: drm/i915/display: Set correct voltage level for 480MHz CDCLK (rev2)
URL : https://patchwork.freedesktop.org/series/114752/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13198 -> Patchwork_114752v2
We want to stop touching directly i915_gem_object struct members in
intel_frontbuffer code. As a part of this we add helper macro to get i915
device from i915_gem_object.
Signed-off-by: Jouni Högander
---
.../gpu/drm/i915/display/intel_frontbuffer.c | 18 +-
Currently frontbuffer tracking code is directly iterating over object vmas
and clearing scanout flags for them. Add function to clear scanout flag for
vmas and use it from frontbuffer tracking code.
Signed-off-by: Jouni Högander
---
.../gpu/drm/i915/display/intel_frontbuffer.c | 8 +---
Now as we have removed all the references to internals of i915_gem_object
from the frontbuffer header we can also remove including
i915_gem_object_types.h.
Signed-off-by: Jouni Högander
---
drivers/gpu/drm/i915/display/intel_frontbuffer.h | 1 -
1 file changed, 1 deletion(-)
diff --git
Add getter/setter for i915_gem_object->frontbuffer and use it instead of
directly touching i915_gem_object->frontbuffer frontbuffer pointer.
Signed-off-by: Jouni Högander
---
.../gpu/drm/i915/display/intel_frontbuffer.c | 18 ++---
.../gpu/drm/i915/display/intel_frontbuffer.h | 27 ---
We are preparing for Xe driver. Binary objects will have differing
implementation in Xe driver. Due this we want to remove direct
accesses to i915_gem_object members and leave details to binary object
implementation.
Cc: Jani Nikula
Cc: Rodrigo Vivi
Cc: Maarten Lankhorst
Jouni Högander (4):
According to Bspec, the voltage level for 480MHz is to be set as 1
instead of 2.
BSpec: 49208
Fixes: 06f1b06dc5b7 ("drm/i915/display: Add 480 MHz CDCLK steps for RPL-U")
v2: rebase
Signed-off-by: Chaitanya Kumar Borah
---
drivers/gpu/drm/i915/display/intel_cdclk.c | 30 +++---
LGTM.
Reviewed-by: Ankit Nautiyal
On 4/21/2023 5:17 PM, Jani Nikula wrote:
Use the information stored in display info.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_sdvo.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git
LGTM.
Reviewed-by: Ankit Nautiyal
On 4/21/2023 5:17 PM, Jani Nikula wrote:
Use the information stored in display info.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_sdvo.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
67 matches
Mail list logo
