Re: [Intel-gfx] [PATCH v2] drm/i915: Replace kmap() with kmap_local_page()

2023-06-23 Thread Fabio M. De Francesco
On sabato 17 giugno 2023 20:04:20 CEST Sumitra Sharma wrote: > kmap() has been deprecated in favor of the kmap_local_page() > due to high cost, restricted mapping space, the overhead of a > global lock for synchronization, and making the process sleep > in the absence of free slots. > >

Re: [Intel-gfx] [PATCH v2] drm/i915: Extend Wa_14015795083 platforms

2023-06-23 Thread Matt Roper
On Thu, Jun 22, 2023 at 04:24:49PM +0530, Kalvala, Haridhar wrote: > > On 6/17/2023 4:20 AM, Matt Roper wrote: > > This workaround was already implemented for DG2, PVC, and some steppings > > of MTL, but the workaround database has now been updated to extend this > > workaround to TGL, RKL, DG1,

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Extend Wa_14015795083 platforms (rev5)

2023-06-23 Thread Patchwork
== Series Details == Series: drm/i915: Extend Wa_14015795083 platforms (rev5) URL : https://patchwork.freedesktop.org/series/118805/ State : success == Summary == CI Bug Log - changes from CI_DRM_13315_full -> Patchwork_118805v5_full

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Swap ggtt_vma during legacy cursor update

2023-06-23 Thread Souza, Jose
On Wed, 2023-06-21 at 13:48 +0200, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/display/intel_cursor.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_cursor.c >

Re: [Intel-gfx] [PATCH 24/29] mm: vmscan: make global slab shrink lockless

2023-06-23 Thread Dave Chinner
On Fri, Jun 23, 2023 at 09:10:57PM +0800, Qi Zheng wrote: > On 2023/6/23 14:29, Dave Chinner wrote: > > On Thu, Jun 22, 2023 at 05:12:02PM +0200, Vlastimil Babka wrote: > > > On 6/22/23 10:53, Qi Zheng wrote: > > Yes, I suggested the IDR route because radix tree lookups under RCU > > with

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Fix context workarounds with non-masked regs

2023-06-23 Thread Matt Roper
On Fri, Jun 23, 2023 at 02:05:20PM -0700, Lucas De Marchi wrote: > On Fri, Jun 23, 2023 at 12:48:13PM -0700, Kenneth Graunke wrote: > > On Friday, June 23, 2023 8:49:05 AM PDT Lucas De Marchi wrote: > > > On Thu, Jun 22, 2023 at 04:37:21PM -0700, Kenneth Graunke wrote: > > > >On Thursday, June 22,

[Intel-gfx] [PATCH 16/26] drm/i915/gvt: use array_size

2023-06-23 Thread Julia Lawall
Use array_size to protect against multiplication overflows. The changes were done using the following Coccinelle semantic patch: // @@ expression E1, E2; constant C1, C2; identifier alloc = {vmalloc,vzalloc}; @@ ( alloc(C1 * C2,...) | alloc( - (E1) * (E2)

[Intel-gfx] [PATCH 00/26] use array_size

2023-06-23 Thread Julia Lawall
Use array_size to protect against multiplication overflows. This follows up on the following patches by Kees Cook from 2018. 42bc47b35320 ("treewide: Use array_size() in vmalloc()") fad953ce0b22 ("treewide: Use array_size() in vzalloc()") The changes were done using the following Coccinelle

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Fix context workarounds with non-masked regs

2023-06-23 Thread Lucas De Marchi
On Fri, Jun 23, 2023 at 12:48:13PM -0700, Kenneth Graunke wrote: On Friday, June 23, 2023 8:49:05 AM PDT Lucas De Marchi wrote: On Thu, Jun 22, 2023 at 04:37:21PM -0700, Kenneth Graunke wrote: >On Thursday, June 22, 2023 11:27:30 AM PDT Lucas De Marchi wrote: >> Most of the context workarounds

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Fix context workarounds with non-masked regs

2023-06-23 Thread Kenneth Graunke
On Friday, June 23, 2023 8:49:05 AM PDT Lucas De Marchi wrote: > On Thu, Jun 22, 2023 at 04:37:21PM -0700, Kenneth Graunke wrote: > >On Thursday, June 22, 2023 11:27:30 AM PDT Lucas De Marchi wrote: > >> Most of the context workarounds tweak masked registers, but not all. For > >> masked

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Extend Wa_14015795083 platforms (rev5)

2023-06-23 Thread Patchwork
== Series Details == Series: drm/i915: Extend Wa_14015795083 platforms (rev5) URL : https://patchwork.freedesktop.org/series/118805/ State : success == Summary == CI Bug Log - changes from CI_DRM_13315 -> Patchwork_118805v5 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/gt: Remove incorrect hard coded cache coherrency setting

2023-06-23 Thread Dong, Zhanjun
Hi Fei, Thanks for review. I put my answers inline below. Regards, Zhanjun On 2023-06-22 6:20 p.m., Yang, Fei wrote: > The previouse i915_gem_object_create_internal already set it with proper > value before function return. This hard coded setting is incorrect for > platforms like MTL, thus

[Intel-gfx] ✓ Fi.CI.IGT: success for Update AUX invalidation sequence

2023-06-23 Thread Patchwork
== Series Details == Series: Update AUX invalidation sequence URL : https://patchwork.freedesktop.org/series/119798/ State : success == Summary == CI Bug Log - changes from CI_DRM_13312_full -> Patchwork_119798v1_full Summary ---

Re: [Intel-gfx] [PATCH v13 00/22] Add vfio_device cdev for iommufd support

2023-06-23 Thread Jason Gunthorpe
On Fri, Jun 16, 2023 at 02:39:24AM -0700, Yi Liu wrote: > Existing VFIO provides group-centric user APIs for userspace. Userspace > opens the /dev/vfio/$group_id first before getting device fd and hence > getting access to device. This is not the desired model for iommufd. Per > the conclusion of

Re: [Intel-gfx] [PATCH v12 23/24] vfio: Compile vfio_group infrastructure optionally

2023-06-23 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:16:52AM -0700, Yi Liu wrote: > vfio_group is not needed for vfio device cdev, so with vfio device cdev > introduced, the vfio_group infrastructures can be compiled out if only > cdev is needed. > > Tested-by: Yanting Jiang > Tested-by: Shameer Kolothum > Tested-by:

Re: [Intel-gfx] [PATCH v12 19/24] vfio: Add VFIO_DEVICE_[AT|DE]TACH_IOMMUFD_PT

2023-06-23 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:16:48AM -0700, Yi Liu wrote: > This adds ioctl for userspace to attach device cdev fd to and detach > from IOAS/hw_pagetable managed by iommufd. > > VFIO_DEVICE_ATTACH_IOMMUFD_PT: attach vfio device to IOAS, hw_pagetable > managed by

Re: [Intel-gfx] [PATCH v12 18/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-06-23 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:16:47AM -0700, Yi Liu wrote: > This adds ioctl for userspace to bind device cdev fd to iommufd. > > VFIO_DEVICE_BIND_IOMMUFD: bind device to an iommufd, hence gain DMA > control provided by the iommufd. open_device >

Re: [Intel-gfx] [PATCH v12 17/24] vfio: Add cdev for vfio_device

2023-06-23 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:16:46AM -0700, Yi Liu wrote: > This allows user to directly open a vfio device w/o using the legacy > container/group interface, as a prerequisite for supporting new iommu > features like nested translation. > > The device fd opened in this manner doesn't have the

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Extend Wa_14015795083 platforms (rev4)

2023-06-23 Thread Patchwork
== Series Details == Series: drm/i915: Extend Wa_14015795083 platforms (rev4) URL : https://patchwork.freedesktop.org/series/118805/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13314 -> Patchwork_118805v4 Summary ---

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Fix context workarounds with non-masked regs

2023-06-23 Thread Lucas De Marchi
On Thu, Jun 22, 2023 at 04:37:21PM -0700, Kenneth Graunke wrote: On Thursday, June 22, 2023 11:27:30 AM PDT Lucas De Marchi wrote: Most of the context workarounds tweak masked registers, but not all. For masked registers, when writing the value it's sufficient to just write the wa->set_bits

Re: [Intel-gfx] [PATCH v12 16/24] vfio: Move vfio_device_group_unregister() to be the first operation in unregister

2023-06-23 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:16:45AM -0700, Yi Liu wrote: > This avoids endless vfio_device refcount increasement by userspace, > which would keep blocking the vfio_unregister_group_dev(). > > Tested-by: Yanting Jiang > Tested-by: Shameer Kolothum > Tested-by: Terrence Xu > Signed-off-by: Yi Liu

Re: [Intel-gfx] [PATCH v12 15/24] vfio-iommufd: Add detach_ioas support for emulated VFIO devices

2023-06-23 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:16:44AM -0700, Yi Liu wrote: > This prepares for adding DETACH ioctl for emulated VFIO devices. > > Reviewed-by: Kevin Tian > Tested-by: Terrence Xu > Tested-by: Nicolin Chen > Tested-by: Matthew Rosato > Tested-by: Yanting Jiang > Tested-by: Shameer Kolothum >

Re: [Intel-gfx] [PATCH v12 14/24] iommufd/device: Add iommufd_access_detach() API

2023-06-23 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:16:43AM -0700, Yi Liu wrote: > From: Nicolin Chen > > Previously, the detach routine is only done by the destroy(). And it was > called by vfio_iommufd_emulated_unbind() when the device runs close(), so > all the mappings in iopt were cleaned in that setup, when the

Re: [Intel-gfx] [PATCH v12 13/24] vfio-iommufd: Add detach_ioas support for physical VFIO devices

2023-06-23 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:16:42AM -0700, Yi Liu wrote: > This prepares for adding DETACH ioctl for physical VFIO devices. > > Reviewed-by: Kevin Tian > Tested-by: Terrence Xu > Tested-by: Nicolin Chen > Tested-by: Matthew Rosato > Tested-by: Yanting Jiang > Tested-by: Shameer Kolothum >

[Intel-gfx] ✓ Fi.CI.BAT: success for Update AUX invalidation sequence

2023-06-23 Thread Patchwork
== Series Details == Series: Update AUX invalidation sequence URL : https://patchwork.freedesktop.org/series/119798/ State : success == Summary == CI Bug Log - changes from CI_DRM_13312 -> Patchwork_119798v1 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915/display/hotplug: use drm_kms_helper_connector_hotplug_event() (rev2)

2023-06-23 Thread Patchwork
== Series Details == Series: i915/display/hotplug: use drm_kms_helper_connector_hotplug_event() (rev2) URL : https://patchwork.freedesktop.org/series/119603/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13312 -> Patchwork_119603v2

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/dsc: Move rc param calculation for native_420

2023-06-23 Thread Nautiyal, Ankit K
On 5/24/2023 8:25 AM, Suraj Kandpal wrote: Move rc_param calculation for native_420 into calculate_rc_parameter. second_line_bpg_offset and second_line_offset_adj are both rc params and it would be better to have these calculated where all the other rc parameters are calculated. --v2 -Add the

[Intel-gfx] [PATCH RESEND 2/2] drm/i915/gt: Poll aux invalidation register bit on invalidation

2023-06-23 Thread Andi Shyti
From: Jonathan Cavitt For platforms that use Aux CCS, wait for aux invalidation to complete by checking the aux invalidation register bit is cleared. Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 17 +

[Intel-gfx] [PATCH RESEND 1/2] drm/i915/gt: Ensure memory quiesced before invalidation

2023-06-23 Thread Andi Shyti
From: Jonathan Cavitt All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS. Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Intel-gfx] [PATCH RESEND 0/2] Update AUX invalidation sequence

2023-06-23 Thread Andi Shyti
Hi, as there are new hardware directives, we need a little adaptation for the AUX invalidation sequence. This series was already proposed in the past but received no comment. Respinning it again :) Andi Jonathan Cavitt (2): drm/i915/gt: Ensure memory quiesced before invalidation

Re: [Intel-gfx] [PATCH v3 i-g-t] tests/i915_pm_freq_api: Add a suspend subtest

2023-06-23 Thread Kamil Konieczny
Hi Vinay, small nit, see below. On 2023-06-16 at 08:50:48 -0700, Vinay Belgaumkar wrote: > Verify that SLPC API works as expected after a suspend. Added > another subtest that does multiple GT resets and checks freq api > works as expected after each one. > > We now check requested frequency

Re: [Intel-gfx] [PATCH 05/29] drm/panfrost: dynamically allocate the drm-panfrost shrinker

2023-06-23 Thread Steven Price
On 22/06/2023 09:39, Qi Zheng wrote: > From: Qi Zheng > > In preparation for implementing lockless slab shrink, > we need to dynamically allocate the drm-panfrost shrinker, > so that it can be freed asynchronously using kfree_rcu(). > Then it doesn't need to wait for RCU read-side critical >

[Intel-gfx] [PATCH v2] i915/display/hotplug: use drm_kms_helper_connector_hotplug_event()

2023-06-23 Thread Simon Ser
This adds more information to the hotplug uevent and lets user-space know that it's about a particular connector only. v2: don't rely on the changed HPD pin bitmask to count changed connectors (Jani) Signed-off-by: Simon Ser Cc: Jani Nikula Cc: Ville Syrjälä Cc: Rodrigo Vivi Cc: Gustavo

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915/gt: Move wal_get_fw_for_rmw()

2023-06-23 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/gt: Move wal_get_fw_for_rmw() URL : https://patchwork.freedesktop.org/series/119766/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13309_full -> Patchwork_119766v1_full

Re: [Intel-gfx] [PATCH] i915/display/hotplug: use drm_kms_helper_connector_hotplug_event()

2023-06-23 Thread Simon Ser
On Wednesday, June 21st, 2023 at 14:26, Jani Nikula wrote: > On Wed, 21 Jun 2023, Simon Ser cont...@emersion.fr wrote: > > > On Wednesday, June 21st, 2023 at 14:11, Jani Nikula jani.nik...@intel.com > > wrote: > > > > > On Wed, 21 Jun 2023, Simon Ser cont...@emersion.fr wrote: > > > > > > >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/quirk: Add quirk for devices that cannot be dimmed (rev2)

2023-06-23 Thread Patchwork
== Series Details == Series: drm/i915/quirk: Add quirk for devices that cannot be dimmed (rev2) URL : https://patchwork.freedesktop.org/series/118971/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13309_full -> Patchwork_118971v2_full

Re: [Intel-gfx] [PATCH 3/4] drm/ttm: Don't leak a resource on eviction error

2023-06-23 Thread Andi Shyti
Hi Christian and Thomas, > > > > > diff --git a/drivers/gpu/drm/ttm/ttm_bo.c > > > > > b/drivers/gpu/drm/ttm/ttm_bo.c > > > > > index 615d30c4262d..89530f2a027f 100644 > > > > > --- a/drivers/gpu/drm/ttm/ttm_bo.c > > > > > +++ b/drivers/gpu/drm/ttm/ttm_bo.c > > > > > @@ -462,14 +462,14 @@ static

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Remove incorrect hard coded cache coherrency setting (rev2)

2023-06-23 Thread Patchwork
== Series Details == Series: drm/i915/gt: Remove incorrect hard coded cache coherrency setting (rev2) URL : https://patchwork.freedesktop.org/series/119485/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13309_full -> Patchwork_119485v2_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Extend Wa_14015795083 platforms (rev3)

2023-06-23 Thread Patchwork
== Series Details == Series: drm/i915: Extend Wa_14015795083 platforms (rev3) URL : https://patchwork.freedesktop.org/series/118805/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13309 -> Patchwork_118805v3 Summary ---

Re: [Intel-gfx] [PATCH 24/29] mm: vmscan: make global slab shrink lockless

2023-06-23 Thread Dave Chinner
On Thu, Jun 22, 2023 at 05:12:02PM +0200, Vlastimil Babka wrote: > On 6/22/23 10:53, Qi Zheng wrote: > > @@ -1067,33 +1068,27 @@ static unsigned long shrink_slab(gfp_t gfp_mask, > > int nid, > > if (!mem_cgroup_disabled() && !mem_cgroup_is_root(memcg)) > > return

[Intel-gfx] ✓ Fi.CI.IGT: success for i915: avoid unused-but-set-variable warning

2023-06-23 Thread Patchwork
== Series Details == Series: i915: avoid unused-but-set-variable warning URL : https://patchwork.freedesktop.org/series/119738/ State : success == Summary == CI Bug Log - changes from CI_DRM_13309_full -> Patchwork_119738v1_full Summary

Re: [Intel-gfx] [PATCH 02/29] mm: vmscan: introduce some helpers for dynamically allocating shrinker

2023-06-23 Thread Dave Chinner
On Thu, Jun 22, 2023 at 04:53:08PM +0800, Qi Zheng wrote: > Introduce some helpers for dynamically allocating shrinker instance, > and their uses are as follows: > > 1. shrinker_alloc_and_init() > > Used to allocate and initialize a shrinker instance, the priv_data > parameter is used to pass