[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests (rev5)

2023-07-12 Thread Patchwork
== Series Details == Series: drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests (rev5) URL : https://patchwork.freedesktop.org/series/117713/ State : success == Summary == CI Bug Log - changes from CI_DRM_13379_full -> Patchwork_117713v5_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests (rev5)

2023-07-12 Thread Patchwork
== Series Details == Series: drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests (rev5) URL : https://patchwork.freedesktop.org/series/117713/ State : success == Summary == CI Bug Log - changes from CI_DRM_13379 -> Patchwork_117713v5

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Introduce Wa_14011274333

2023-07-12 Thread Patchwork
== Series Details == Series: drm/i915: Introduce Wa_14011274333 URL : https://patchwork.freedesktop.org/series/120644/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC [M]

[Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

2023-07-12 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c between commit: 570b295248b0 ("drm/amdgpu: fix number of fence calculations") from Linus' tree and commit: ca6c1e210aa7 ("drm/amdgpu: use the new drm_exec object for CS v3")

[Intel-gfx] [PATCH] drm/i915: Introduce Wa_14011274333

2023-07-12 Thread Matt Atwood
Wa_14011274333 applies to RKL, ADL-S, ADL-P and TGL. ALlocate buffer pinned to GGTT and add WA to restore impacted registers. v2: use correct lineage number, more generically apply workarounds for all registers impacted, move workaround to gt/intel_workarounds.c (MattR) Based off patch by Tilak

Re: [Intel-gfx] [PATCH] drm: Replace drm_framebuffer plane size functions with its equivalents

2023-07-12 Thread André Almeida
Hi Carlos, Em 27/06/2023 15:22, Carlos Eduardo Gallo Filho escreveu: [...] So, replace each drm_framebuffer_plane_{width,height} and fb_plane_{width,height} call to drm_format_info_plane_{width,height} and remove them. I see that with this replace, there's a small code change from

[Intel-gfx] [PATCH v5] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-07-12 Thread Alan Previn
On MTL, if the GSC Proxy init flows haven't completed, submissions to the GSC engine will fail. Those init flows are dependent on the mei's gsc_proxy component that is loaded in parallel with i915 and a worker that could potentially start after i915 driver init is done. That said, all subsytems

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/gt: Support aux invalidation on all engines

2023-07-12 Thread Andi Shyti
Hi Nirmoy, > > @@ -301,11 +336,7 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 > > mode) > > cs = gen8_emit_pipe_control(cs, flags, LRC_PPHWSP_SCRATCH_ADDR); > > - if (!HAS_FLAT_CCS(rq->engine->i915)) { > > - /* hsdes: 1809175790 */ > > We

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: update request engine before removing virtual GuC engine

2023-07-12 Thread John Harrison
On 7/12/2023 09:27, Andrzej Hajda wrote: On 12.07.2023 14:35, Tvrtko Ursulin wrote: On 12/07/2023 13:18, Andrzej Hajda wrote: On 11.07.2023 17:27, Tvrtko Ursulin wrote: On 11/07/2023 14:58, Andrzej Hajda wrote: On 11.07.2023 13:34, Andi Shyti wrote: Hi Andrzej,

Re: [Intel-gfx] [PATCH v4] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-07-12 Thread Teres Alexis, Alan Previn
On Wed, 2023-07-12 at 10:19 +0100, Tvrtko Ursulin wrote: > On 11/07/2023 23:02, Alan Previn wrote: > > On MTL, if the GSC Proxy init flows haven't completed, submissions to the > > GSC engine will fail. Those init flows are dependent on the mei's > > gsc_proxy component that is loaded in parallel

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pxp/mtl: Update gsc-heci cmd size and timeout

2023-07-12 Thread Teres Alexis, Alan Previn
On Fri, 2023-07-07 at 23:43 +, Patchwork wrote: > Patch Details > Series: drm/i915/pxp/mtl: Update gsc-heci cmd size and timeout > URL:https://patchwork.freedesktop.org/series/120360/ > State: failure > Details: >

Re: [Intel-gfx] [v3] drm/i915/mtl: s/MTL/METEORLAKE for platform/subplatform defines

2023-07-12 Thread Srivatsa, Anusha
I Like the acronym replacement approach - despite making the macro names longer, it is consistent with how platform is referred everywhere in the driver. For that, Reviewed-by: Anusha Srivatsa > -Original Message- > From: Bhadane, Dnyaneshwar > Sent: Monday, July 10, 2023 6:44 AM >

Re: [Intel-gfx] [PATCH] drm/i915/huc: check HuC and GuC version compatibility on MTL

2023-07-12 Thread Ceraolo Spurio, Daniele
On 7/12/2023 3:03 AM, Andrzej Hajda wrote: On 11.07.2023 22:31, Daniele Ceraolo Spurio wrote: Due to a change in the auth flow on MTL, GuC 70.7.0 and newer will only be able to authenticate HuC 8.5.1 and newer. The plan is to update the 2 binaries sinchronously in linux-firmware so that the

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: update request engine before removing virtual GuC engine

2023-07-12 Thread Andrzej Hajda
On 12.07.2023 14:35, Tvrtko Ursulin wrote: On 12/07/2023 13:18, Andrzej Hajda wrote: On 11.07.2023 17:27, Tvrtko Ursulin wrote: On 11/07/2023 14:58, Andrzej Hajda wrote: On 11.07.2023 13:34, Andi Shyti wrote: Hi Andrzej,   drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 11

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-12 Thread Cavitt, Jonathan
-Original Message- From: Nirmoy Das Sent: Wednesday, July 12, 2023 7:18 AM To: Andi Shyti ; Cavitt, Jonathan Cc: Intel GFX ; Roper, Matthew D ; Chris Wilson ; Mika Kuoppala Subject: Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/gt: Ensure memory quiesced before invalidation > >Hi Andi

[Intel-gfx] ✗ Fi.CI.BUILD: failure for DRM cgroup controller with scheduling control and memory stats

2023-07-12 Thread Patchwork
== Series Details == Series: DRM cgroup controller with scheduling control and memory stats URL : https://patchwork.freedesktop.org/series/120604/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC [M]

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/gt: Support aux invalidation on all engines

2023-07-12 Thread Nirmoy Das
On 6/27/2023 11:43 AM, Andi Shyti wrote: Perform some refactoring with the purpose of keeping in one single place all the operations around the aux table invalidation. With this refactoring add more engines where the invalidation should be performed. Fixes: 972282c4cf24 ("drm/i915/gen12: Add

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/gt: Poll aux invalidation register bit on invalidation

2023-07-12 Thread Nirmoy Das
On 6/27/2023 11:43 AM, Andi Shyti wrote: From: Jonathan Cavitt For platforms that use Aux CCS, wait for aux invalidation to complete by checking the aux invalidation register bit is cleared. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by:

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-12 Thread Nirmoy Das
Hi Andi and Jonathan, On 6/27/2023 11:43 AM, Andi Shyti wrote: From: Jonathan Cavitt All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by:

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/gt: Cleanup aux invalidation registers

2023-07-12 Thread Nirmoy Das
On 6/27/2023 11:43 AM, Andi Shyti wrote: Fix the 'NV' definition postfix that is supposed to be INV. Take the chance to also order properly the registers based on their address and call the GEN12_GFX_CCS_AUX_INV address as GEN12_CCS_AUX_INV like all the other similar registers. Remove also

Re: [Intel-gfx] [PATCH v9 06/10] vfio: Mark cdev usage in vfio_device

2023-07-12 Thread Jason Gunthorpe
On Mon, Jul 10, 2023 at 07:31:22PM -0700, Yi Liu wrote: > This can be used to differentiate whether to report group_id or devid in > the revised VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl. At this moment, no > cdev path yet, so the vfio_device_cdev_opened() helper always returns false. > >

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display: Do not use stolen on MTL

2023-07-12 Thread Nirmoy Das
On 7/11/2023 5:59 PM, Tvrtko Ursulin wrote: On 10/07/2023 10:00, Nirmoy Das wrote: Hi Tvrkto, On 7/6/2023 3:43 PM, Tvrtko Ursulin wrote: On 06/07/2023 14:35, Nirmoy Das wrote: On 7/6/2023 3:32 PM, Tvrtko Ursulin wrote: On 30/06/2023 18:01, Nirmoy Das wrote: Use smem on MTL due to a

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: update request engine before removing virtual GuC engine

2023-07-12 Thread Tvrtko Ursulin
On 12/07/2023 13:18, Andrzej Hajda wrote: On 11.07.2023 17:27, Tvrtko Ursulin wrote: On 11/07/2023 14:58, Andrzej Hajda wrote: On 11.07.2023 13:34, Andi Shyti wrote: Hi Andrzej,   drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 11 +++   1 file changed, 11

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: update request engine before removing virtual GuC engine

2023-07-12 Thread Andrzej Hajda
On 11.07.2023 17:27, Tvrtko Ursulin wrote: On 11/07/2023 14:58, Andrzej Hajda wrote: On 11.07.2023 13:34, Andi Shyti wrote: Hi Andrzej,   drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 11 +++   1 file changed, 11 insertions(+) diff --git

[Intel-gfx] [PATCH 16/17] cgroup/drm: Expose memory stats

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin With a few DRM drivers exposing per client memory stats via the fdinfo interface already, we can add support for exposing the same data (albeit aggregated for cgroup hierarchies) via the drm cgroup controller. Add some driver callbacks and controller code to use them,

[Intel-gfx] [PATCH 15/17] cgroup/drm: Expose GPU utilisation

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To support container use cases where external orchestrators want to make deployment and migration decisions based on GPU load and capacity, we can expose the GPU load as seen by the controller in a new drm.active_us field. This field contains a monotonic cumulative time

[Intel-gfx] [PATCH 17/17] drm/i915: Wire up to the drm cgroup memory stats

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Simply refactor the existing helpers which collate the data for fdinfo and share them with thin drm cgroup controller callbacks. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_driver.c | 4 + drivers/gpu/drm/i915/i915_drm_client.c | 183

[Intel-gfx] [PATCH 14/17] drm/i915: Implement cgroup controller over budget throttling

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When notified by the drm core we are over our allotted time budget, i915 instance will check if any of the GPU engines it is reponsible for is fully saturated. If it is, and the client in question is using that engine, it will throttle it. For now throttling is done

[Intel-gfx] [PATCH 12/17] cgroup/drm: Introduce weight based drm cgroup control

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Similar to CPU scheduling, implement a concept of weight in the drm cgroup controller. Uses the same range and default as the CPU controller - CGROUP_WEIGHT_MIN, CGROUP_WEIGHT_DFL and CGROUP_WEIGHT_MAX. Later each cgroup is assigned a time budget proportionaly based on the

[Intel-gfx] [PATCH 13/17] drm/i915: Wire up with drm controller GPU time query

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Implement the drm_cgroup_ops->active_time_us callback. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_driver.c | 8 ++ drivers/gpu/drm/i915/i915_drm_client.c | 116 ++--- drivers/gpu/drm/i915/i915_drm_client.h | 2 + 3 files

[Intel-gfx] [PATCH 11/17] drm/cgroup: Only track clients which are providing drm_cgroup_ops

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To reduce the number of tracking going on, especially with drivers which will not support any sort of control from the drm cgroup controller side, lets express the funcionality as opt-in and use the presence of drm_cgroup_ops as activation criteria. Signed-off-by: Tvrtko

[Intel-gfx] [PATCH 10/17] drm/cgroup: Add over budget signalling callback

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add a new callback via which the drm cgroup controller is notifying the drm core that a certain process is above its allotted GPU time. Signed-off-by: Tvrtko Ursulin --- include/drm/drm_drv.h | 8 kernel/cgroup/drm.c | 16 2 files changed, 24

[Intel-gfx] [PATCH 06/17] drm: Update file owner during use

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin With the typical model where the display server opens the file descriptor and then hands it over to the client(*), we were showing stale data in debugfs. Fix it by updating the drm_file->pid on ioctl access from a different process. The field is also made RCU protected to

[Intel-gfx] [PATCH 09/17] drm/cgroup: Add ability to query drm cgroup GPU time

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add a driver callback and core helper which allow querying the time spent on GPUs for processes belonging to a group. Signed-off-by: Tvrtko Ursulin --- include/drm/drm_drv.h | 28 kernel/cgroup/drm.c | 20 2 files

[Intel-gfx] [PATCH 08/17] drm/cgroup: Track DRM clients per cgroup

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To enable propagation of settings from the cgroup DRM controller to DRM and vice-versa, we need to start tracking to which cgroups DRM clients belong. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/drm_file.c | 6 include/drm/drm_file.h | 6

[Intel-gfx] [PATCH 02/17] drm/i915: Record which client owns a VM

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To enable accounting of indirect client memory usage (such as page tables) in the following patch, lets start recording the creator of each PPGTT. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 11

[Intel-gfx] [PATCH 07/17] cgroup: Add the DRM cgroup controller

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Skeleton controller without any functionality. Signed-off-by: Tvrtko Ursulin --- include/linux/cgroup_drm.h| 9 ++ include/linux/cgroup_subsys.h | 4 +++ init/Kconfig | 7 kernel/cgroup/Makefile| 1 + kernel/cgroup/drm.c

[Intel-gfx] [PATCH 04/17] drm/i915: Account ring buffer and context state storage

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Account ring buffers and logical context space against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gt/intel_context.c | 14 ++ drivers/gpu/drm/i915/i915_drm_client.c | 10

[Intel-gfx] [PATCH 05/17] drm/i915: Implement fdinfo memory stats printing

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the newly added drm_print_memory_stats helper to show memory utilisation of our objects in drm/driver specific fdinfo output. To collect the stats we walk the per memory regions object lists and accumulate object size into the respective drm_memory_stats categories.

[Intel-gfx] [PATCH 03/17] drm/i915: Track page table backing store usage

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Account page table backing store against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gt/intel_gtt.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Intel-gfx] [PATCH 01/17] drm/i915: Add ability for tracking buffer objects per client

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In order to show per client memory usage lets add some infrastructure which enables tracking buffer objects owned by clients. We add a per client list protected by a new per client lock and to support delayed destruction (post client exit) we make tracked objects hold

[Intel-gfx] [RFC v5 00/17] DRM cgroup controller with scheduling control and memory stats

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This series contains a proposal for a DRM cgroup controller which implements a weight based hierarchical GPU usage budget based controller similar in concept to some of the existing controllers and also exposes GPU memory usage as a read- only field. Motivation mostly comes

Re: [Intel-gfx] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-12 Thread Javier Martinez Canillas
Uwe Kleine-König writes: [dropping some recipients since my SMTP server was complaining about the size] > Hello Thomas, > > On Wed, Jul 12, 2023 at 12:19:37PM +0200, Thomas Zimmermann wrote: >> Am 12.07.23 um 11:46 schrieb Uwe Kleine-König: >> > Hello, >> > >> > while I debugged an issue in

Re: [Intel-gfx] [PATCH] drm/i915/huc: check HuC and GuC version compatibility on MTL

2023-07-12 Thread Andrzej Hajda
On 11.07.2023 22:31, Daniele Ceraolo Spurio wrote: Due to a change in the auth flow on MTL, GuC 70.7.0 and newer will only be able to authenticate HuC 8.5.1 and newer. The plan is to update the 2 binaries sinchronously in linux-firmware so that the fw repo always has a matching pair that works;

Re: [Intel-gfx] [PATCH v4 0/3] Add rc_range_params for YUV420

2023-07-12 Thread Nautiyal, Ankit K
On 7/5/2023 10:44 AM, Suraj Kandpal wrote: Calculations for YUV420 were missing from calculate_rc_param, add them be in line with DSC 1.2a specs. Signed-off-by: Suraj Kandpal Suraj Kandpal (3): drm/i915/dsc: Move rc param calculation for native_420 drm/i915/drm: Fix comment for

Re: [Intel-gfx] [PATCH] drm/i915/vdsc: Remove FIXME in intel_dsc_compute_config

2023-07-12 Thread Nautiyal, Ankit K
On 6/26/2023 7:26 PM, Luca Coelho wrote: On Mon, 2023-06-26 at 18:35 +0530, Suraj Kandpal wrote: Remove the FIXME and the code related to it as after verification it does seem the previous values were typos and no hardware spec mentions using these particular rc_params. Signed-off-by: Suraj

Re: [Intel-gfx] [PATCH v4] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-07-12 Thread Tvrtko Ursulin
On 11/07/2023 23:02, Alan Previn wrote: On MTL, if the GSC Proxy init flows haven't completed, submissions to the GSC engine will fail. Those init flows are dependent on the mei's gsc_proxy component that is loaded in parallel with i915 and a worker that could potentially start after i915

Re: [Intel-gfx] [PATCH] drm/i915/perf: add sentinel to xehp_oa_b_counters

2023-07-12 Thread Andrzej Hajda
On 12.07.2023 00:10, Nirmoy Das wrote: On 7/11/2023 5:34 PM, Andrzej Hajda wrote: Arrays passed to reg_in_range_table should end with empty record. The patch solves KASAN detected bug with signature: BUG: KASAN: global-out-of-bounds in xehp_is_valid_b_counter_addr+0x2c7/0x350 [i915] Read of

Re: [Intel-gfx] [PATCH] drm/i915: Allow panel drrs modes to have differing sync polarities

2023-07-12 Thread Srinivas, Vidya
> -Original Message- > From: Nikula, Jani > Sent: Wednesday, July 12, 2023 1:44 PM > To: Srinivas, Vidya ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Allow panel drrs modes to have > differing sync polarities > > On Tue, 11 Jul 2023, Jani Nikula

Re: [Intel-gfx] [PATCH] drm/i915: Allow panel drrs modes to have differing sync polarities

2023-07-12 Thread Jani Nikula
On Tue, 11 Jul 2023, Jani Nikula wrote: > On Tue, 11 Jul 2023, Vidya Srinivas wrote: >> v2: Add Jani Nikula's change for quirk for sync polarity > > This was a quick hack suggestion to try. If it works, I think it works > by concidence, because a fastset won't update the sync flags in >