[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Add new DG2 PCI IDs

2023-10-10 Thread Patchwork
== Series Details == Series: drm/i915: Add new DG2 PCI IDs URL : https://patchwork.freedesktop.org/series/124937/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC arch/x86/kernel/early-quirks.o In file

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/lnl: Remove watchdog timers for PSR (rev3)

2023-10-10 Thread Patchwork
== Series Details == Series: drm/i915/lnl: Remove watchdog timers for PSR (rev3) URL : https://patchwork.freedesktop.org/series/124715/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13735_full -> Patchwork_124715v3_full

Re: [Intel-gfx] [PATCH 1/4] drm/i915/gvt: remove unused to_gvt() and reduce includes

2023-10-10 Thread Zhenyu Wang
On 2023.10.04 15:54:11 +0300, Jani Nikula wrote: > On Tue, 26 Sep 2023, Jani Nikula wrote: > > gvt.h has no need to include i915_drv.h once the unused to_gvt() has > > been removed. > > > > Signed-off-by: Jani Nikula > > Zhenyu, Zhi, ping? > Sorry for late reply, as last week was full holiday

[Intel-gfx] [PATCH] drm/i915: Add new DG2 PCI IDs

2023-10-10 Thread Shekhar Chauhan
Add new PCI IDs which are recently added. BSpec: 44477 Signed-off-by: Shekhar Chauhan --- include/drm/i915_pciids.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index 1256770d3827..deb2eb0b4979 100644 ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-10 Thread Patchwork
== Series Details == Series: drm/i915: Define and use GuC and CTB TLB invalidation routines URL : https://patchwork.freedesktop.org/series/124932/ State : success == Summary == CI Bug Log - changes from CI_DRM_13737 -> Patchwork_124932v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-10 Thread Patchwork
== Series Details == Series: drm/i915: Define and use GuC and CTB TLB invalidation routines URL : https://patchwork.freedesktop.org/series/124932/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-10 Thread Patchwork
== Series Details == Series: drm/i915: Define and use GuC and CTB TLB invalidation routines URL : https://patchwork.freedesktop.org/series/124932/ State : warning == Summary == Error: dim checkpatch failed 3f043e9037de drm/i915: Add GuC TLB Invalidation device info flags dcdab6a3e4e0

Re: [Intel-gfx] Regression in linux-next

2023-10-10 Thread Borah, Chaitanya Kumar
rc32_pclmul ghash_clmulni_intel i2c_i801 mei_me pps_core mei i2c_smbus wmi <4>[4.392057] CPU: 1 PID: 306 Comm: thermald Not tainted 6.6.0-rc5-next-20231010-next-20231010-gc0a6edb636cb+ #1 <4>[4.392061] Hardware name: System manufacturer System Product Name/Z170M-PLUS, BIOS 3610 03/29/

[Intel-gfx] ✓ Fi.CI.BAT: success for Use intel_crtc_destroy state

2023-10-10 Thread Patchwork
== Series Details == Series: Use intel_crtc_destroy state URL : https://patchwork.freedesktop.org/series/124919/ State : success == Summary == CI Bug Log - changes from CI_DRM_13737 -> Patchwork_124919v1 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Implement range-based TLB

2023-10-10 Thread Patchwork
== Series Details == Series: drm/i915: Implement range-based TLB URL : https://patchwork.freedesktop.org/series/124922/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC [M] drivers/gpu/drm/i915/i915_vma.o

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Use intel_crtc_destroy state

2023-10-10 Thread Patchwork
== Series Details == Series: Use intel_crtc_destroy state URL : https://patchwork.freedesktop.org/series/124919/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:1:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/1] drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev2)

2023-10-10 Thread Patchwork
== Series Details == Series: series starting with [v2,1/1] drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev2) URL : https://patchwork.freedesktop.org/series/123656/ State : success == Summary == CI Bug Log - changes from CI_DRM_13737 -> Patchwork_123656v2

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/1] drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev2)

2023-10-10 Thread Patchwork
== Series Details == Series: series starting with [v2,1/1] drm/i915/pxp: Add drm_dbgs for critical PXP events. (rev2) URL : https://patchwork.freedesktop.org/series/123656/ State : warning == Summary == Error: dim checkpatch failed afd41e939c6c drm/i915/pxp: Add drm_dbgs for critical PXP

Re: [Intel-gfx] [PATCH dii-client 1/2] drm/i915: Add generic interface for tlb invalidation

2023-10-10 Thread kernel test robot
Hi Jonathan, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Jonathan-Cavitt/drm-i915-Use-selective-tlb-invalidations-where-supported/20231011-034501 base:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-10 Thread Patchwork
== Series Details == Series: drm/i915: Define and use GuC and CTB TLB invalidation routines URL : https://patchwork.freedesktop.org/series/124917/ State : success == Summary == CI Bug Log - changes from CI_DRM_13737 -> Patchwork_124917v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-10 Thread Patchwork
== Series Details == Series: drm/i915: Define and use GuC and CTB TLB invalidation routines URL : https://patchwork.freedesktop.org/series/124917/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v11 2/7] drm/i915/guc: Add CT size delay helper

2023-10-10 Thread Jonathan Cavitt
Add a helper function to the GuC CT buffer that reports the expected time to process all outstanding requests. As of now, there is no functionality to check number of requests in the buffer, so the helper function just reports 2 seconds, or 1ms per request up to the maximum number of requests the

[Intel-gfx] [PATCH v11 5/7] drm/i915: No TLB invalidation on wedged GT

2023-10-10 Thread Jonathan Cavitt
It is not an error for GuC TLB invalidations to fail when the GT is wedged or disabled, so do not process a wait failure as one in guc_send_invalidate_tlb. Signed-off-by: Fei Yang Signed-off-by: Jonathan Cavitt CC: John Harrison Reviewed-by: Andi Shyti ---

[Intel-gfx] [PATCH v11 1/7] drm/i915: Add GuC TLB Invalidation device info flags

2023-10-10 Thread Jonathan Cavitt
Add device info flags for if GuC TLB Invalidation is enabled. Signed-off-by: Jonathan Cavitt Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/intel_device_info.h | 1 + 2 files changed, 3 insertions(+) diff --git

[Intel-gfx] [PATCH v11 7/7] drm/i915: Enable GuC TLB invalidations for MTL

2023-10-10 Thread Jonathan Cavitt
Enable GuC TLB invalidations for MTL. Though more platforms than just MTL support GuC TLB invalidations, MTL is presently the only platform that requires it for any purpose, so only enable it there for now to minimize cross-platform impact. Signed-off-by: Jonathan Cavitt Reviewed-by: Andi Shyti

[Intel-gfx] [PATCH v11 6/7] drm/i915/gt: Increase sleep in gt_tlb selftest sanitycheck

2023-10-10 Thread Jonathan Cavitt
For the gt_tlb live selftest, when operating on the GSC engine, increase the timeout from 10 ms to 200 ms because the GSC engine is a bit slower than the rest. Signed-off-by: Jonathan Cavitt Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gt/selftest_tlb.c | 11 +-- 1 file changed, 9

[Intel-gfx] [PATCH v11 0/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-10 Thread Jonathan Cavitt
Implement GuC-based TLB invalidations and use them on MTL. Some complexity in the implementation was introduced early on and will be required for range-based TLB invalidations. RFC: https://patchwork.freedesktop.org/series/124922/ v2: - Add missing supporting patches. v3: - Split suspend/resume

[Intel-gfx] [PATCH v11 3/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-10 Thread Jonathan Cavitt
From: Prathap Kumar Valsan The GuC firmware had defined the interface for Translation Look-Aside Buffer (TLB) invalidation. We should use this interface when invalidating the engine and GuC TLBs. Add additional functionality to intel_gt_invalidate_tlb, invalidating the GuC TLBs and falling back

[Intel-gfx] [PATCH v11 4/7] drm/i915: No TLB invalidation on suspended GT

2023-10-10 Thread Jonathan Cavitt
In case of GT is suspended, don't allow submission of new TLB invalidation request and cancel all pending requests. The TLB entries will be invalidated either during GuC reload or on system resume. Signed-off-by: Fei Yang Signed-off-by: Jonathan Cavitt CC: John Harrison Reviewed-by: Andi Shyti

Re: [Intel-gfx] [PATCH dii-client 1/2] drm/i915: Add generic interface for tlb invalidation

2023-10-10 Thread kernel test robot
Hi Jonathan, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Jonathan-Cavitt/drm-i915-Use-selective-tlb-invalidations-where-supported/20231011-034501 base:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Temporarily force MTL into uncached mode (rev2)

2023-10-10 Thread Patchwork
== Series Details == Series: drm/i915/gt: Temporarily force MTL into uncached mode (rev2) URL : https://patchwork.freedesktop.org/series/124866/ State : success == Summary == CI Bug Log - changes from CI_DRM_13736 -> Patchwork_124866v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gt: Temporarily force MTL into uncached mode (rev2)

2023-10-10 Thread Patchwork
== Series Details == Series: drm/i915/gt: Temporarily force MTL into uncached mode (rev2) URL : https://patchwork.freedesktop.org/series/124866/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v10 3/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-10 Thread John Harrison
On 10/10/2023 15:30, Cavitt, Jonathan wrote: -Original Message- From: Harrison, John C Sent: Tuesday, October 10, 2023 2:51 PM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Gupta, saurabhg ; chris.p.wil...@linux.intel.com; Iddamsetty, Aravind ; Yang, Fei ; Shyti, Andi ;

[Intel-gfx] ✓ Fi.CI.BAT: success for Add drm_dbg_ratelimited()

2023-10-10 Thread Patchwork
== Series Details == Series: Add drm_dbg_ratelimited() URL : https://patchwork.freedesktop.org/series/124894/ State : success == Summary == CI Bug Log - changes from CI_DRM_13736 -> Patchwork_124894v1 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add drm_dbg_ratelimited()

2023-10-10 Thread Patchwork
== Series Details == Series: Add drm_dbg_ratelimited() URL : https://patchwork.freedesktop.org/series/124894/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add drm_dbg_ratelimited()

2023-10-10 Thread Patchwork
== Series Details == Series: Add drm_dbg_ratelimited() URL : https://patchwork.freedesktop.org/series/124894/ State : warning == Summary == Error: dim checkpatch failed b31dca360377 drm/print: Add drm_dbg_ratelimited f2b0f288ffbb drm/i915: Ratelimit debug log in vm_fault_ttm -:9:

[Intel-gfx] ✓ Fi.CI.BAT: success for Framework for display parameters (rev2)

2023-10-10 Thread Patchwork
== Series Details == Series: Framework for display parameters (rev2) URL : https://patchwork.freedesktop.org/series/124645/ State : success == Summary == CI Bug Log - changes from CI_DRM_13736 -> Patchwork_124645v2 Summary ---

Re: [Intel-gfx] [PATCH v10 3/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-10 Thread Cavitt, Jonathan
-Original Message- From: Harrison, John C Sent: Tuesday, October 10, 2023 2:51 PM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Gupta, saurabhg ; chris.p.wil...@linux.intel.com; Iddamsetty, Aravind ; Yang, Fei ; Shyti, Andi ; Das, Nirmoy ; Krzysztofik, Janusz ; Roper,

Re: [Intel-gfx] [PATCH v2 00/15] sysctl: Remove sentinel elements from drivers

2023-10-10 Thread Luis Chamberlain
On Mon, Oct 02, 2023 at 10:55:17AM +0200, Joel Granados via B4 Relay wrote: > Changes in v2: > - Left the dangling comma in the ctl_table arrays. > - Link to v1: > https://lore.kernel.org/r/20230928-jag-sysctl_remove_empty_elem_drivers-v1-0-e59120fca...@samsung.com Thanks! Pushed onto

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Framework for display parameters (rev2)

2023-10-10 Thread Patchwork
== Series Details == Series: Framework for display parameters (rev2) URL : https://patchwork.freedesktop.org/series/124645/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Framework for display parameters (rev2)

2023-10-10 Thread Patchwork
== Series Details == Series: Framework for display parameters (rev2) URL : https://patchwork.freedesktop.org/series/124645/ State : warning == Summary == Error: dim checkpatch failed 6962346c45e5 drm/i915/display: Add framework to add parameters specific to display Traceback (most recent

Re: [Intel-gfx] [PATCH v10 6/7] drm/i915/gt: Increase sleep in gt_tlb selftest sanitycheck

2023-10-10 Thread John Harrison
On 10/10/2023 08:02, Jonathan Cavitt wrote: For the gt_tlb live selftest, when operating on the GSC engine, increase the timeout from 10 ms to 200 ms because the GSC engine is a bit slower than the rest. Additionally, increase the default timeout from 10 ms to 20 ms because msleep < 20ms can

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Store DSC DPCD capabilities in the connector (rev5)

2023-10-10 Thread Patchwork
== Series Details == Series: drm/i915: Store DSC DPCD capabilities in the connector (rev5) URL : https://patchwork.freedesktop.org/series/124723/ State : success == Summary == CI Bug Log - changes from CI_DRM_13736 -> Patchwork_124723v5

Re: [Intel-gfx] [PATCH v10 4/7] drm/i915: No TLB invalidation on suspended GT

2023-10-10 Thread Cavitt, Jonathan
-Original Message- From: Harrison, John C Sent: Tuesday, October 10, 2023 2:57 PM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Gupta, saurabhg ; chris.p.wil...@linux.intel.com; Iddamsetty, Aravind ; Yang, Fei ; Shyti, Andi ; Das, Nirmoy ; Krzysztofik, Janusz ; Roper,

Re: [Intel-gfx] [PATCH v10 4/7] drm/i915: No TLB invalidation on suspended GT

2023-10-10 Thread John Harrison
On 10/10/2023 08:02, Jonathan Cavitt wrote: In case of GT is suspended, don't allow submission of new TLB invalidation request and cancel all pending requests. The TLB entries will be invalidated either during GuC reload or on system resume. Signed-off-by: Fei Yang Signed-off-by: Jonathan

Re: [Intel-gfx] [PATCH v10 3/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-10 Thread John Harrison
On 10/10/2023 08:02, Jonathan Cavitt wrote: From: Prathap Kumar Valsan The GuC firmware had defined the interface for Translation Look-Aside Buffer (TLB) invalidation. We should use this interface when invalidating the engine and GuC TLBs. Add additional functionality to

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Store DSC DPCD capabilities in the connector (rev5)

2023-10-10 Thread Patchwork
== Series Details == Series: drm/i915: Store DSC DPCD capabilities in the connector (rev5) URL : https://patchwork.freedesktop.org/series/124723/ State : warning == Summary == Error: dim checkpatch failed a9998de0514d drm/i915/dp: Sanitize DPCD revision check in intel_dp_get_dsc_sink_cap()

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/print: Add drm_dbg_ratelimited (rev2)

2023-10-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/print: Add drm_dbg_ratelimited (rev2) URL : https://patchwork.freedesktop.org/series/112925/ State : success == Summary == CI Bug Log - changes from CI_DRM_13736 -> Patchwork_112925v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/print: Add drm_dbg_ratelimited (rev2)

2023-10-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/print: Add drm_dbg_ratelimited (rev2) URL : https://patchwork.freedesktop.org/series/112925/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/print: Add drm_dbg_ratelimited (rev2)

2023-10-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/print: Add drm_dbg_ratelimited (rev2) URL : https://patchwork.freedesktop.org/series/112925/ State : warning == Summary == Error: dim checkpatch failed ada8428ec944 drm/print: Add drm_dbg_ratelimited fbced019c190 drm/i915: Ratelimit

Re: [Intel-gfx] [PATCH RESEND v2 1/2] drm/print: Add drm_dbg_ratelimited

2023-10-10 Thread Hamza Mahfooz
On 10/10/23 08:15, Andi Shyti wrote: From: Nirmoy Das Add a function for ratelimitted debug print. Signed-off-by: Nirmoy Das Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Reviewed-by: Matthew Auld Reviewed-by: Andrzej Hajda

Re: [Intel-gfx] [PATCH RESEND v2 0/2] Add drm_dbg_ratelimited()

2023-10-10 Thread Andi Shyti
Hi John, On Tue, Oct 10, 2023 at 11:25:03AM -0700, John Harrison wrote: > On 10/10/2023 05:15, Andi Shyti wrote: > > Hi, > > > > I might have picked up the wrong series and missed some reviews > > and the extra patch from Nirmoy with a real use of the > > drm_dbg_ratelimited() that John was

Re: [Intel-gfx] [PATCH 2/2] drm/i915: More use of GT specific print helpers

2023-10-10 Thread Andi Shyti
Hi John, On Mon, Oct 09, 2023 at 12:57:55PM -0700, John Harrison wrote: > On 10/9/2023 12:54, Andi Shyti wrote: > > Hi John, > > > > ... > > > > > --- a/drivers/gpu/drm/i915/i915_driver.c > > > +++ b/drivers/gpu/drm/i915/i915_driver.c > > > @@ -71,6 +71,7 @@ > > > #include "gem/i915_gem_pm.h"

Re: [Intel-gfx] [PATCH v10 2/7] drm/i915/guc: Add CT size delay helper

2023-10-10 Thread John Harrison
On 10/10/2023 08:02, Jonathan Cavitt wrote: Add a helper function to the GuC CT buffer that reports the expected time to process all outstanding requests. As of now, there is no functionality to check number of requests in the buffer, so the helper function just reports 2 seconds, or 1ms per

Re: [Intel-gfx] [PATCH dii-client 2/2] drm/i915: Use selective tlb invalidations where supported

2023-10-10 Thread Cavitt, Jonathan
Ignore this. It's not a security hole: it's just a temporary patch I was using for rebasing purposes that got smuggled into this series on accident. It has a bad tag because of some stale gitconfig params that I've since removed. -Jonathan Cavitt -Original Message- From: Cavitt,

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/lnl: Remove watchdog timers for PSR (rev3)

2023-10-10 Thread Patchwork
== Series Details == Series: drm/i915/lnl: Remove watchdog timers for PSR (rev3) URL : https://patchwork.freedesktop.org/series/124715/ State : success == Summary == CI Bug Log - changes from CI_DRM_13735 -> Patchwork_124715v3 Summary

[Intel-gfx] [RFC PATCH 00/10] drm/i915: Implement range-based TLB

2023-10-10 Thread Jonathan Cavitt
Implement range-based TLB invalidations on top of GuC-based TLB invalidations. This is the future plan for GuC-based TLB invalidations because it helps improve performance over performing full tlb invalidations all the time. Jonathan Cavitt (7): drm/i915: Add GuC TLB Invalidation device info

[Intel-gfx] [RFC PATCH 03/10] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-10 Thread Jonathan Cavitt
From: Prathap Kumar Valsan The GuC firmware had defined the interface for Translation Look-Aside Buffer (TLB) invalidation. We should use this interface when invalidating the engine and GuC TLBs. Add additional functionality to intel_gt_invalidate_tlb, invalidating the GuC TLBs and falling back

[Intel-gfx] [RFC PATCH 09/10] drm/i915: Add generic interface for tlb invalidation

2023-10-10 Thread Jonathan Cavitt
From: Prathap Kumar Valsan This supports selective and full tlb invalidations. When GuC is enabled the tlb invalidations use guc ct otherwise use mmio interface. Signed-off-by: Prathap Kumar Valsan CC: Niranjana Vishwanathapura CC: Fei Yang Signed-off-by: Jonathan Cavitt ---

[Intel-gfx] [RFC PATCH 10/10] drm/i915: Use selective tlb invalidations where supported

2023-10-10 Thread Jonathan Cavitt
For platforms supporting selective tlb invalidations, we don't need to do a full tlb invalidation. Rather do a range based tlb invalidation for every unbind of purged vma belongs to an active vm. Signed-off-by: Prathap Kumar Valsan Cc: Niranjana Vishwanathapura Cc: Fei Yang Signed-off-by:

[Intel-gfx] [RFC PATCH 06/10] drm/i915/gt: Increase sleep in gt_tlb selftest sanitycheck

2023-10-10 Thread Jonathan Cavitt
For the gt_tlb live selftest, when operating on the GSC engine, increase the timeout from 10 ms to 200 ms because the GSC engine is a bit slower than the rest. Additionally, increase the default timeout from 10 ms to 20 ms because msleep < 20ms can sleep for up to 20ms. Signed-off-by: Jonathan

[Intel-gfx] [RFC PATCH 08/10] drm/i915: Define GuC Based TLB invalidation routines

2023-10-10 Thread Jonathan Cavitt
From: Prathap Kumar Valsan The GuC firmware has defined the interface for selective TLB invalidation support. This patch adds routines to interface with GuC. Signed-off-by: Prathap Kumar Valsan CC: Matthew Brost --- .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 2 +

[Intel-gfx] [RFC PATCH 07/10] drm/i915: Enable GuC TLB invalidations for MTL

2023-10-10 Thread Jonathan Cavitt
Enable GuC TLB invalidations for MTL. Though more platforms than just MTL support GuC TLB invalidations, MTL is presently the only platform that requires it for any purpose, so only enable it there for now to minimize cross-platform impact. Signed-off-by: Jonathan Cavitt ---

[Intel-gfx] [RFC PATCH 05/10] drm/i915: No TLB invalidation on wedged GT

2023-10-10 Thread Jonathan Cavitt
It is not an error for GuC TLB invalidations to fail when the GT is wedged or disabled, so do not process a wait failure as one in guc_send_invalidate_tlb. Signed-off-by: Fei Yang Signed-off-by: Jonathan Cavitt CC: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 18

[Intel-gfx] [RFC PATCH 02/10] drm/i915/guc: Add CT size delay helper

2023-10-10 Thread Jonathan Cavitt
Add a helper function to the GuC CT buffer that reports the expected time to process all outstanding requests. As of now, there is no functionality to check number of requests in the buffer, so the helper function just reports 2 seconds, or 1ms per request up to the maximum number of requests the

[Intel-gfx] [RFC PATCH 04/10] drm/i915: No TLB invalidation on suspended GT

2023-10-10 Thread Jonathan Cavitt
In case of GT is suspended, don't allow submission of new TLB invalidation request and cancel all pending requests. The TLB entries will be invalidated either during GuC reload or on system resume. Signed-off-by: Fei Yang Signed-off-by: Jonathan Cavitt CC: John Harrison ---

[Intel-gfx] [RFC PATCH 01/10] drm/i915: Add GuC TLB Invalidation device info flags

2023-10-10 Thread Jonathan Cavitt
Add device info flags for if GuC TLB Invalidation is enabled. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/intel_device_info.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h

Re: [Intel-gfx] [PATCH] drm/i915/gt: Temporarily force MTL into uncached mode

2023-10-10 Thread John Harrison
On 10/10/2023 09:44, Matt Roper wrote: On Tue, Oct 10, 2023 at 05:42:28PM +0100, Tvrtko Ursulin wrote: On 10/10/2023 17:17, Andi Shyti wrote: Hi Matt, FIXME: CAT errors are cropping up on MTL. This removes them, but the real root cause must still be diagnosed. Do you have a link to

[Intel-gfx] [RFC PATCH 09/10] drm/i915: Add generic interface for tlb invalidation

2023-10-10 Thread Jonathan Cavitt
From: Prathap Kumar Valsan This supports selective and full tlb invalidations. When GuC is enabled the tlb invalidations use guc ct otherwise use mmio interface. Signed-off-by: Prathap Kumar Valsan CC: Niranjana Vishwanathapura CC: Fei Yang Signed-off-by: Jonathan Cavitt ---

Re: [Intel-gfx] [PATCH] drm/i915/display: Free crtc_state in verify_crtc_state

2023-10-10 Thread Ville Syrjälä
On Tue, Oct 10, 2023 at 11:02:09AM +0530, Suraj Kandpal wrote: > Free hw_crtc_state in verify_crtc_state after we are done using > this or else it's just a resource leak. > > Fixes: 2745bdda2095 ("drm/i915: Stop clobbering old crtc state during state > check") > Signed-off-by: Suraj Kandpal >

[Intel-gfx] [RFC PATCH 04/10] drm/i915: No TLB invalidation on suspended GT

2023-10-10 Thread Jonathan Cavitt
In case of GT is suspended, don't allow submission of new TLB invalidation request and cancel all pending requests. The TLB entries will be invalidated either during GuC reload or on system resume. Signed-off-by: Fei Yang Signed-off-by: Jonathan Cavitt CC: John Harrison ---

[Intel-gfx] [RFC PATCH 10/10] drm/i915: Use selective tlb invalidations where supported

2023-10-10 Thread Jonathan Cavitt
For platforms supporting selective tlb invalidations, we don't need to do a full tlb invalidation. Rather do a range based tlb invalidation for every unbind of purged vma belongs to an active vm. Signed-off-by: Prathap Kumar Valsan Cc: Niranjana Vishwanathapura Cc: Fei Yang Signed-off-by:

[Intel-gfx] [RFC PATCH 08/10] drm/i915: Define GuC Based TLB invalidation routines

2023-10-10 Thread Jonathan Cavitt
From: Prathap Kumar Valsan The GuC firmware has defined the interface for selective TLB invalidation support. This patch adds routines to interface with GuC. Signed-off-by: Prathap Kumar Valsan CC: Matthew Brost --- .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 2 +

[Intel-gfx] [RFC PATCH 07/10] drm/i915: Enable GuC TLB invalidations for MTL

2023-10-10 Thread Jonathan Cavitt
Enable GuC TLB invalidations for MTL. Though more platforms than just MTL support GuC TLB invalidations, MTL is presently the only platform that requires it for any purpose, so only enable it there for now to minimize cross-platform impact. Signed-off-by: Jonathan Cavitt ---

[Intel-gfx] [RFC PATCH 03/10] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-10 Thread Jonathan Cavitt
From: Prathap Kumar Valsan The GuC firmware had defined the interface for Translation Look-Aside Buffer (TLB) invalidation. We should use this interface when invalidating the engine and GuC TLBs. Add additional functionality to intel_gt_invalidate_tlb, invalidating the GuC TLBs and falling back

[Intel-gfx] [RFC PATCH 02/10] drm/i915/guc: Add CT size delay helper

2023-10-10 Thread Jonathan Cavitt
Add a helper function to the GuC CT buffer that reports the expected time to process all outstanding requests. As of now, there is no functionality to check number of requests in the buffer, so the helper function just reports 2 seconds, or 1ms per request up to the maximum number of requests the

[Intel-gfx] [RFC PATCH 06/10] drm/i915/gt: Increase sleep in gt_tlb selftest sanitycheck

2023-10-10 Thread Jonathan Cavitt
For the gt_tlb live selftest, when operating on the GSC engine, increase the timeout from 10 ms to 200 ms because the GSC engine is a bit slower than the rest. Additionally, increase the default timeout from 10 ms to 20 ms because msleep < 20ms can sleep for up to 20ms. Signed-off-by: Jonathan

[Intel-gfx] [RFC PATCH 05/10] drm/i915: No TLB invalidation on wedged GT

2023-10-10 Thread Jonathan Cavitt
It is not an error for GuC TLB invalidations to fail when the GT is wedged or disabled, so do not process a wait failure as one in guc_send_invalidate_tlb. Signed-off-by: Fei Yang Signed-off-by: Jonathan Cavitt CC: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 18

[Intel-gfx] [PATCH dii-client 1/2] drm/i915: Add generic interface for tlb invalidation

2023-10-10 Thread Jonathan Cavitt
From: Prathap Kumar Valsan This supports selective and full tlb invalidations. When GuC is enabled the tlb invalidations use guc ct otherwise use mmio interface. Signed-off-by: Prathap Kumar Valsan CC: Niranjana Vishwanathapura CC: Fei Yang Signed-off-by: Jonathan Cavitt ---

[Intel-gfx] [RFC PATCH 01/10] drm/i915: Add GuC TLB Invalidation device info flags

2023-10-10 Thread Jonathan Cavitt
Add device info flags for if GuC TLB Invalidation is enabled. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/intel_device_info.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH dii-client 2/2] drm/i915: Use selective tlb invalidations where supported

2023-10-10 Thread Jonathan Cavitt
For platforms supporting selective tlb invalidations, we don't need to do a full tlb invalidation. Rather do a range based tlb invalidation for every unbind of purged vma belongs to an active vm. Signed-off-by: Prathap Kumar Valsan Cc: Niranjana Vishwanathapura Cc: Fei Yang Signed-off-by:

[Intel-gfx] [RFC PATCH 00/10] drm/i915: Implement range-based TLB

2023-10-10 Thread Jonathan Cavitt
Implement range-based TLB invalidations on top of GuC-based TLB invalidations. This is the future plan for GuC-based TLB invalidations because it helps improve performance over performing full tlb invalidations all the time. Jonathan Cavitt (7): drm/i915: Add GuC TLB Invalidation device info

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: Temporarily force MTL into uncached mode

2023-10-10 Thread John Harrison
On 10/10/2023 07:36, Jonathan Cavitt wrote: FIXME: CAT errors are cropping up on MTL. This removes them, but the real root cause must still be diagnosed. I think 'hides' would be more accurate than 'removes'. At least until we have a better understanding of the issue. Also, is there any

[Intel-gfx] [PATCH 2/2] drm/i915/display: Use correct method to free crtc_state

2023-10-10 Thread Suraj Kandpal
Even though there is no leaking of resource here lets just use the correct method to free crtc_state Fixes: 8a3b3df39757 ("drm/i915: Clean up variable names in old dpll functions") Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dpll.c | 3 ++- 1 file changed, 2

[Intel-gfx] [PATCH 1/2] drm/i915/display: Use intel_crtc_destroy_state instead kfree

2023-10-10 Thread Suraj Kandpal
intel_encoder_current_mode() seems to leak some resource because it uses kfree instead of intel_crtc_destroy_state let us fix that. Fixes: de330815677d ("drm/i915: Reuse normal state readout for LVDS/DVO fixed mode") Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_display.c

[Intel-gfx] [PATCH 0/2] Use intel_crtc_destroy state

2023-10-10 Thread Suraj Kandpal
Use intel_crtc_destroy_state to avoid leakage of any resources instead of the usual kfree Signed-off-by: Suraj Kandpal Suraj Kandpal (2): drm/i915/display: Use intel_crtc_destroy_state instead kfree drm/i915/display: Use correct method to free crtc_state

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for More print message helper updates

2023-10-10 Thread John Harrison
On 10/9/2023 19:26, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* More print message helper updates *URL:* https://patchwork.freedesktop.org/series/124853/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124853v1/index.html

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove the module parameter 'fastboot' (rev4)

2023-10-10 Thread Patchwork
== Series Details == Series: drm/i915: Remove the module parameter 'fastboot' (rev4) URL : https://patchwork.freedesktop.org/series/124255/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13733_full -> Patchwork_124255v4_full

Re: [Intel-gfx] [PATCH RESEND v2 0/2] Add drm_dbg_ratelimited()

2023-10-10 Thread John Harrison
On 10/10/2023 05:15, Andi Shyti wrote: Hi, I might have picked up the wrong series and missed some reviews and the extra patch from Nirmoy with a real use of the drm_dbg_ratelimited() that John was looking for. Thanks, Andi I just found the original post of this from back in January

Re: [Intel-gfx] [PATCH i-g-t v2 04/11] lib/kunit: Parse KTAP report from the main process thread

2023-10-10 Thread Janusz Krzysztofik
Hi Mauro, Thanks for review. On Tuesday, 10 October 2023 15:33:57 CEST Mauro Carvalho Chehab wrote: > On Mon, 9 Oct 2023 14:27:55 +0200 > Janusz Krzysztofik wrote: > > > There was an attempt to parse KTAP reports in the background while a kunit > > test module is loading. However, since

Re: [Intel-gfx] [PATCH i-g-t v2 04/11] lib/kunit: Parse KTAP report from the main process thread

2023-10-10 Thread Janusz Krzysztofik
Hi Kamil, Thanks for review. On Tuesday, 10 October 2023 17:59:56 CEST Kamil Konieczny wrote: > Hi Janusz, > On 2023-10-09 at 14:27:55 +0200, Janusz Krzysztofik wrote: > > There was an attempt to parse KTAP reports in the background while a kunit > > test module is loading. However, since

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Free crtc_state in verify_crtc_state (rev2)

2023-10-10 Thread Patchwork
== Series Details == Series: drm/i915/display: Free crtc_state in verify_crtc_state (rev2) URL : https://patchwork.freedesktop.org/series/124811/ State : success == Summary == CI Bug Log - changes from CI_DRM_13733_full -> Patchwork_124811v2_full

Re: [Intel-gfx] [PATCH] drm/i915/gt: Temporarily force MTL into uncached mode

2023-10-10 Thread Matt Roper
On Tue, Oct 10, 2023 at 05:42:28PM +0100, Tvrtko Ursulin wrote: > > On 10/10/2023 17:17, Andi Shyti wrote: > > Hi Matt, > > > > > > > > FIXME: CAT errors are cropping up on MTL. This removes them, > > > > > > but the real root cause must still be diagnosed. > > > > > > > > > > Do you have a

Re: [Intel-gfx] [PATCH i-g-t 4/4] tools/intel_gpu_top: Handle narrow terminals more gracefully

2023-10-10 Thread Kamil Konieczny
Hi Tvrtko, On 2023-10-10 at 12:07:14 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Instead of asserting just skip trying to print columns when terminal is > too narrow. > > At the same time fix some type confusion to fix calculations going huge. > > Signed-off-by: Tvrtko Ursulin >

Re: [Intel-gfx] [PATCH i-g-t 3/4] tools/intel_gpu_top: Optimise interactive display a bit

2023-10-10 Thread Kamil Konieczny
Hi Tvrtko, On 2023-10-10 at 12:07:13 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Padding the percentage bars and table columns with spaces happens quite a > lot so lets do better than putchar at a time. Have a table of visually > empty strings and build the required length out of

Re: [Intel-gfx] [PATCH] drm/i915/gt: Temporarily force MTL into uncached mode

2023-10-10 Thread Matt Roper
On Tue, Oct 10, 2023 at 06:17:27PM +0200, Andi Shyti wrote: > Hi Matt, > > > > > > FIXME: CAT errors are cropping up on MTL. This removes them, > > > > > but the real root cause must still be diagnosed. > > > > > > > > Do you have a link to specific IGT test(s) that illustrate the CAT > > > >

Re: [Intel-gfx] [PATCH] drm/i915/gt: Temporarily force MTL into uncached mode

2023-10-10 Thread Tvrtko Ursulin
On 10/10/2023 17:17, Andi Shyti wrote: Hi Matt, FIXME: CAT errors are cropping up on MTL. This removes them, but the real root cause must still be diagnosed. Do you have a link to specific IGT test(s) that illustrate the CAT errors so that we can ensure that they now appear fixed in CI?

Re: [Intel-gfx] [PATCH 00/19] drm/i915: Store DSC DPCD capabilities in the connector

2023-10-10 Thread Ville Syrjälä
On Fri, Oct 06, 2023 at 04:37:08PM +0300, Imre Deak wrote: > This patchset moves the DSC DPCD capabilities from the encoder > (intel_dp) to the connector. This is required since in an MST topology > each connector has its own version of these capabilities, allowing > to configure/enable the DSC

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/4] tools/intel_gpu_top: Fix client layout on first sample period

2023-10-10 Thread Kamil Konieczny
Hi Tvrtko, On 2023-10-10 at 12:07:12 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > When I moved the client name to be last, I did not account for the fact > current code skips showing engine utilisation until at least two sampling > periods have passed. Consequence of this is that

Re: [Intel-gfx] [PATCH i-g-t 1/4] tools/intel_gpu_top: Fix clients header width when no clients

2023-10-10 Thread Kamil Konieczny
Hi Tvrtko, On 2023-10-10 at 12:07:11 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Recent refactoring broke the clients header in cases when there are no > clients displayed. To fix it we need to account the width of the "NAME" > label. > > Signed-off-by: Tvrtko Ursulin Reviewed-by:

Re: [Intel-gfx] [PATCH] drm/i915/gt: Temporarily force MTL into uncached mode

2023-10-10 Thread Andi Shyti
Hi Matt, > > > > FIXME: CAT errors are cropping up on MTL. This removes them, > > > > but the real root cause must still be diagnosed. > > > > > > Do you have a link to specific IGT test(s) that illustrate the CAT > > > errors so that we can ensure that they now appear fixed in CI? > > > >

Re: [Intel-gfx] [PATCH] drm/i915/gt: Temporarily force MTL into uncached mode

2023-10-10 Thread Matt Roper
On Tue, Oct 10, 2023 at 05:11:54PM +0200, Andi Shyti wrote: > Hi Matt, > > On Tue, Oct 10, 2023 at 06:58:27AM -0700, Matt Roper wrote: > > On Mon, Oct 09, 2023 at 04:38:56PM -0700, Jonathan Cavitt wrote: > > > FIXME: CAT errors are cropping up on MTL. This removes them, > > > but the real root

Re: [Intel-gfx] [PATCH i-g-t v2 04/11] lib/kunit: Parse KTAP report from the main process thread

2023-10-10 Thread Kamil Konieczny
Hi Janusz, On 2023-10-09 at 14:27:55 +0200, Janusz Krzysztofik wrote: > There was an attempt to parse KTAP reports in the background while a kunit > test module is loading. However, since dynamic sub-subtests can be > executed only from the main thread, that attempt was not quite successful, > as

Re: [Intel-gfx] [PATCH 1/2] drm/i915: drop -Wall and related disables from cflags as redundant

2023-10-10 Thread Nick Desaulniers
On Tue, Oct 10, 2023 at 1:50 AM Jani Nikula wrote: > > On Tue, 10 Oct 2023, Jani Nikula wrote: > > On Mon, 09 Oct 2023, Nathan Chancellor wrote: > >> On Sun, Oct 08, 2023 at 12:28:46AM +0900, Masahiro Yamada wrote: > >>> On Fri, Oct 6, 2023 at 9:35 PM Jani Nikula wrote: > >>> > > >>> > The

Re: [Intel-gfx] [PATCH v10 0/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-10 Thread Andi Shyti
Hi Jonathan, On Tue, Oct 10, 2023 at 08:02:37AM -0700, Jonathan Cavitt wrote: > Implement GuC-based TLB invalidations and use them on MTL. I have to admit that I'm a bit biased on this series. Given this premise, you can add Reviewed-by: Andi Shyti to all the patches. Nevertheless to get

  1   2   >