On 10/25/2023 6:20 PM, Ville Syrjälä wrote:
On Wed, Oct 25, 2023 at 05:43:18PM +0530, Ankit Nautiyal wrote:
At the moment the max requested bpc is limited to 6 to 10/12.
For platforms that support DSC, min and max src bpc with DSC are
different.
Account for DSC bpc limitations, when setting
Hi,
CI is always testing against https://cgit.freedesktop.org/drm-tip
Br
Jani
> -Original Message-
> From: Intel-gfx On Behalf Of
> Christian
> Brauner
> Sent: Wednesday, October 25, 2023 11:39 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure
In accordance to Linux coding style(Documentation/process/4.Coding.rst),
remove unneeded braces from if-else block as all arms of this block
contain single statements.
Suggested-by: Andi Shyti
Signed-off-by: Soumya Negi
---
drivers/gpu/drm/i915/gt/intel_ggtt.c | 7 +++
1 file changed, 3
== Series Details ==
Series: debugobjects: stop accessing objects after releasing spinlock (rev3)
URL : https://patchwork.freedesktop.org/series/124185/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13786 -> Patchwork_124185v3
== Series Details ==
Series: debugobjects: stop accessing objects after releasing spinlock (rev3)
URL : https://patchwork.freedesktop.org/series/124185/
State : warning
== Summary ==
Error: dim checkpatch failed
bdb4ac71599d debugobjects: stop accessing objects after releasing spinlock
-:13:
== Series Details ==
Series: drm/i915/tc: Fix -Wformat-truncation in intel_tc_port_init (rev2)
URL : https://patchwork.freedesktop.org/series/125576/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13786 -> Patchwork_125576v2
== Series Details ==
Series: file, i915: fix file reference for mmap_singleton() (rev2)
URL : https://patchwork.freedesktop.org/series/125570/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/125570/revisions/2/mbox/ not
applied
Patch is empty.
On Wed, 25 Oct 2023 at 10:36, Christian Brauner wrote:
>
> I did think that the loop didn't really matter for this case but since
> it seemingly does paper over the weird semantics here let's drop it.
> Anyway, pushed to:
>
>
== Series Details ==
Series: Add gt_to_guc and guc_to_i915 helpers
URL : https://patchwork.freedesktop.org/series/125583/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13786 -> Patchwork_125583v1
Summary
---
== Series Details ==
Series: Add gt_to_guc and guc_to_i915 helpers
URL : https://patchwork.freedesktop.org/series/125583/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Cleanup a few functions in C10/C20 handling (rev2)
URL : https://patchwork.freedesktop.org/series/125323/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13786 -> Patchwork_125323v2
Summary
== Series Details ==
Series: Cleanup a few functions in C10/C20 handling (rev2)
URL : https://patchwork.freedesktop.org/series/125323/
State : warning
== Summary ==
Error: dim checkpatch failed
09fd1c2c911d drm/i915/display: Abstract C10/C20 pll hw readout
f52ea88bef32 drm/i915/display:
== Series Details ==
Series: Apply Wa_16018031267 / Wa_16018063123
URL : https://patchwork.freedesktop.org/series/125580/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13786 -> Patchwork_125580v1
Summary
---
== Series Details ==
Series: Apply Wa_16018031267 / Wa_16018063123
URL : https://patchwork.freedesktop.org/series/125580/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Apply Wa_16018031267 / Wa_16018063123
URL : https://patchwork.freedesktop.org/series/125580/
State : warning
== Summary ==
Error: dim checkpatch failed
9bcc31776a08 drm/i915: Reserve some kernel space per vm
558c3bcd5f24 drm/i915: Add WABB blit for Wa_16018031267
ate);
+ debug_print_object(, "free");
+ debug_object_fixup(o.descr->fixup_free,
+ (void *) oaddr, o.state);
goto repeat;
default:
hlist_del(>node);
---
base-commit: 201c8a7bd1f3f415920a2df4b8a8817e973f42fe
change-id: 20231025-debugobjects_fix-66e5292557c4
Best regards,
--
Andrzej Hajda
== Series Details ==
Series: drm/i915/mtl: Add Wa_22016670082
URL : https://patchwork.freedesktop.org/series/125574/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13786 -> Patchwork_125574v1
Summary
---
**SUCCESS**
== Series Details ==
Series: DP DSC min/max src bpc fixes
URL : https://patchwork.freedesktop.org/series/125571/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13786 -> Patchwork_125571v1
Summary
---
**SUCCESS**
== Series Details ==
Series: DP DSC min/max src bpc fixes
URL : https://patchwork.freedesktop.org/series/125571/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/include/asm/bitops.h:117:1:
On Wed, Oct 25, 2023 at 08:16:23PM -, Patchwork wrote:
> == Series Details ==
>
> Series: file, i915: fix file reference for mmap_singleton()
> URL : https://patchwork.freedesktop.org/series/125570/
> State : failure
>
> == Summary ==
>
> Error: patch
>
do_init_module+0x5f/0x210
<6> [511.401544] ? load_module+0x1d00/0x1f60
<6> [511.401581] ? init_module_from_file+0x86/0xd0
<6> [511.401590] ? init_module_from_file+0x86/0xd0
<6> [511.401613] ? idempotent_init_module+0x17c/0x230
<6> [511.401639] ? __x64_sys_finit_
== Series Details ==
Series: Enable Darkscreen Feature
URL : https://patchwork.freedesktop.org/series/125563/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13786 -> Patchwork_125563v1
Summary
---
**SUCCESS**
No
== Series Details ==
Series: file, i915: fix file reference for mmap_singleton()
URL : https://patchwork.freedesktop.org/series/125570/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/125570/revisions/1/mbox/ not
applied
Applying: file, i915: fix
== Series Details ==
Series: Enable Darkscreen Feature
URL : https://patchwork.freedesktop.org/series/125563/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/include/asm/bitops.h:117:1: warning:
== Series Details ==
Series: Enable Darkscreen Feature
URL : https://patchwork.freedesktop.org/series/125563/
State : warning
== Summary ==
Error: dim checkpatch failed
35c1fae9e76f drm/i915: Add Darkscreen registers and timer handler.
Traceback (most recent call last):
File
== Series Details ==
Series: drm/i915/mtl: Add Wa_14019821291 (rev3)
URL : https://patchwork.freedesktop.org/series/125282/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13786 -> Patchwork_125282v3
Summary
---
On Tue, Oct 24, 2023 at 02:20:33PM +0200, Andi Shyti wrote:
Hi Umesh,
On Fri, Oct 20, 2023 at 08:24:41AM -0700, Umesh Nerlige Ramappa wrote:
When the driver unbinds, pmu is unregistered and i915->uabi_engines is
set to RB_ROOT. Due to this, when i915 PMU tries to stop the engine
events, it
== Series Details ==
Series: drm/i915/mtl: Add Wa_14019821291 (rev3)
URL : https://patchwork.freedesktop.org/series/125282/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/mtl: Apply notify_guc to all GTs
URL : https://patchwork.freedesktop.org/series/125560/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13786 -> Patchwork_125560v1
Summary
---
On 25.10.2023 19:08, Nirmoy Das wrote:
Fix below compiler warning:
intel_tc.c:1879:11: error: ‘%d’ directive output may be truncated
writing between 1 and 11 bytes into a region of size 3
[-Werror=format-truncation=]
"%c/TC#%d", port_name(port), tc_port + 1);
^~
intel_tc.c:1878:2:
On Wed, 25 Oct 2023 at 02:01, Christian Brauner wrote:
>
> rcu_read_lock();
> - file = get_file_rcu(>gem.mmap_singleton);
> + file = get_file_rcu_once(>gem.mmap_singleton);
> rcu_read_unlock();
> if (file)
> return file;
Honestly, the
== Series Details ==
Series: drm/i915/display: Support PSR entry VSC packet to be transmitted one
frame earlier
URL : https://patchwork.freedesktop.org/series/125558/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13786 -> Patchwork_125558v1
On Wed, Oct 25, 2023 at 04:06:46PM +0530, Dnyaneshwar Bhadane wrote:
> This workaround is primarily implemented by the BIOS. However if the
> BIOS applies the workaround it will reserve a small piece of our DSM
> (which should be at the top, right below the WOPCM); we just need to
> keep that
== Series Details ==
Series: drm/i915/hdcp: Additional conditions to enable hdcp
URL : https://patchwork.freedesktop.org/series/125550/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13786 -> Patchwork_125550v1
Summary
Fix below compiler warning:
intel_tc.c:1879:11: error: ‘%d’ directive output may be truncated
writing between 1 and 11 bytes into a region of size 3
[-Werror=format-truncation=]
"%c/TC#%d", port_name(port), tc_port + 1);
^~
intel_tc.c:1878:2: note: ‘snprintf’ output between 7 and 17
On 10/25/2023 5:45 PM, Imre Deak wrote:
On Wed, Oct 25, 2023 at 03:57:26PM +0200, Nirmoy Das wrote:
Fix below compiler warning:
intel_tc.c:1879:11: error: ‘%d’ directive output may be truncated
writing between 1 and 11 bytes into a region of size 3
[-Werror=format-truncation=]
"%c/TC#%d",
link:
https://lore.kernel.org/r/20231024010925.3949910-9-imre.deak%40intel.com
patch subject: [Intel-gfx] [PATCH 08/29] drm/dp: Add helpers to calculate the
link BW overhead
config: arm-s5pv210_defconfig
(https://download.01.org/0day-ci/archive/20231025/202310252345.i0qkzguh-...@intel.com
On Wed, Oct 25, 2023 at 03:57:26PM +0200, Nirmoy Das wrote:
> Fix below compiler warning:
>
> intel_tc.c:1879:11: error: ‘%d’ directive output may be truncated
> writing between 1 and 11 bytes into a region of size 3
> [-Werror=format-truncation=]
> "%c/TC#%d", port_name(port), tc_port + 1);
>
On Mon, Oct 23, 2023 at 12:28:46PM -0300, Gustavo Sousa wrote:
Quoting Lucas De Marchi (2023-10-20 13:04:48-03:00)
On Thu, Oct 19, 2023 at 01:04:40PM -0300, Gustavo Sousa wrote:
Quoting Lucas De Marchi (2023-10-18 19:24:41-03:00)
With MTL adding PICA between the port and the real phy, the
On Wed, Oct 25, 2023 at 06:27:58PM +0300, Ville Syrjälä wrote:
> On Tue, Oct 24, 2023 at 04:09:06AM +0300, Imre Deak wrote:
> > A follow-up patch will add up all the overheads on a DP link, where it
> > makes more sense to specify each overhead factor in terms of the added
> > overhead amount vs.
On Tue, Oct 24, 2023 at 04:09:06AM +0300, Imre Deak wrote:
> A follow-up patch will add up all the overheads on a DP link, where it
> makes more sense to specify each overhead factor in terms of the added
> overhead amount vs. the reciprocal remainder (of usable BW remaining
> after deducting the
On 10/25/2023 4:53 PM, Andi Shyti wrote:
Hi Nirmoy,
+static inline struct drm_i915_private *guc_to_i915(struct intel_guc *guc)
+{
+ return guc_to_gt(guc)->i915;
+}
+
We don't want inline functions in headers files[1]. Otherwise the series
looks fine to me:
the reason for that patch
On Wed, Oct 25, 2023 at 05:18:00PM +0300, Ville Syrjälä wrote:
> On Fri, Oct 20, 2023 at 12:41:03PM +0300, Jouni Högander wrote:
> > We are preparing for Xe driver. Xe driver doesn't have i915_sw_fence
> > implementation. Lets drop i915_sw_fence usage from display code and
> > use dma_fence
Hi Nirmoy,
> > +static inline struct drm_i915_private *guc_to_i915(struct intel_guc *guc)
> > +{
> > + return guc_to_gt(guc)->i915;
> > +}
> > +
>
> We don't want inline functions in headers files[1]. Otherwise the series
> looks fine to me:
the reason for that patch is that we were including
Hi Andi,
On 10/25/2023 4:35 PM, Andi Shyti wrote:
Given a reference to "guc", the guc_to_i915() returns the
pointer to "i915" private data.
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/gt/intel_gt.h| 5 +
drivers/gpu/drm/i915/gt/uc/intel_guc.c| 2 +-
Get the guc reference from the gt using the gt_to_guc() helper.
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/i915_debugfs_params.c | 5 +++--
drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c | 4 ++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git
Get the guc reference from the ce using the ce_to_guc() helper.
Just a leftover from previous cleanups.
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
We already have guc_to_gt() and getting to guc from the GT it
requires some mental effort. Add the gt_to_guc().
Given the reference to the "gt", the gt_to_guc() will return the
pinter to the "guc".
Update all the files under the gt/ directory.
Signed-off-by: Andi Shyti
---
Get the guc reference from the gt using the gt_to_guc() helper.
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 4 +--
drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c | 3 +-
drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c| 2 +-
Given a reference to "guc", the guc_to_i915() returns the
pointer to "i915" private data.
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/gt/intel_gt.h| 5 +
drivers/gpu/drm/i915/gt/uc/intel_guc.c| 2 +-
drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c| 2
Hi,
while working on the GuC TLB invalidation these days, I just
wished I had the two helpers I am submitting today:
gt_to_guc()
guc_to_i915()
Now I have them, at the next GuC TLB invalidation my life will be
easier :-)
Andi
Changelog:
==
- add the gt_to_guc() helper and change
On Mon, Oct 23, 2023 at 02:34:17PM +0100, Daniel Thompson wrote:
> On Sun, Oct 22, 2023 at 11:46:22AM +0100, Sean Young wrote:
> > On Sat, Oct 21, 2023 at 11:08:22AM +0200, Hans de Goede wrote:
> > > On 10/19/23 12:51, Uwe Kleine-König wrote:
> > > > On Wed, Oct 18, 2023 at 03:57:48PM +0200, Hans
On Fri, Oct 20, 2023 at 12:41:03PM +0300, Jouni Högander wrote:
> We are preparing for Xe driver. Xe driver doesn't have i915_sw_fence
> implementation. Lets drop i915_sw_fence usage from display code and
> use dma_fence interfaces directly.
>
> For this purpose stack dma fences from related
Reserve one page in each vm for kernel space to use for things
such as workarounds.
v2: use real memory, do not decrease vm.total
v4: reserve only one page and explain flag
v5: remove allocated object on ppgtt cleanup
Suggested-by: Chris Wilson
Signed-off-by: Andrzej Hajda
Reviewed-by:
Test re-uses logic form indirect ctx BB selftest.
Signed-off-by: Nirmoy Das
Signed-off-by: Jonathan Cavitt
Signed-off-by: Andrzej Hajda
Reviewed-by: Andi Shyti
---
drivers/gpu/drm/i915/gt/selftest_lrc.c | 65 --
1 file changed, 47 insertions(+), 18
From: Jonathan Cavitt
Set copy engine arbitration into round robin mode
for part of Wa_16018031267 / Wa_16018063123 mitigation.
Signed-off-by: Nirmoy Das
Signed-off-by: Jonathan Cavitt
Signed-off-by: Andrzej Hajda
Reviewed-by: Andi Shyti
---
drivers/gpu/drm/i915/gt/intel_engine_regs.h | 3
Apply WABB blit for Wa_16018031267 / Wa_16018063123.
v3: drop unused enum definition
v4: move selftest to separate patch, use wa only on BCS0.
v5: fixed selftest caller to context_wabb
Signed-off-by: Nirmoy Das
Signed-off-by: Jonathan Cavitt
Signed-off-by: Andrzej Hajda
Reviewed-by: Andi
Hi all,
This the series from Jonathan:
[PATCH v12 0/4] Apply Wa_16018031267 / Wa_16018063123
taken over by me.
Changes in this version are described in the patches, in short:
v2:
- use real memory as WABB destination,
- address CI compains - do not decrease vm.total,
- minor reordering.
v3:
-
Fix below compiler warning:
intel_tc.c:1879:11: error: ‘%d’ directive output may be truncated
writing between 1 and 11 bytes into a region of size 3
[-Werror=format-truncation=]
"%c/TC#%d", port_name(port), tc_port + 1);
^~
intel_tc.c:1878:2: note: ‘snprintf’ output between 7 and 17
ild
4. If everything goes fine, there should be a "build" folder created within the
base folder of your repository
Then run the test using the following command.
sudo build/tests/i915_selftest --run-subtest live
Regards
Chaitanya
[1]
https://lore.kernel.org/in
Implemented workaround for XeLPM+
BSpec: 51762
Signed-off-by: Dnyaneshwar Bhadane
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c
b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index
On 25.10.2023 12:28, Nirmoy Das wrote:
Handle platforms with multiple GTs by iterate over all GTs.
Add a Fixes commit so this gets propagated for MTL support.
Fixes: 213c43676beb ("drm/i915/mtl: Remove the 'force_probe' requirement for Meteor
Lake")
Suggested-by: John Harrison
Cc: Jani
On Wed, 2023-10-25 at 12:46 +0300, Mika Kahola wrote:
> Display driver shall read DPCD 00071h[3:1] during configuration
> to get PSR setup time. This register provides the setup time
> requirement on the VSC SDP entry packet. If setup time cannot be
> met with the current timings
> (e.g., PSR
On Wed, Oct 18, 2023 at 04:24:00PM +0300, Stanislav Lisovskiy wrote:
> For validation purposes, it might be useful to be able to
> force Bigjoiner mode, even if current dotclock/resolution
> do not require that.
> Lets add such to option to debugfs.
>
> v2: - Apparently intel_dp_need_bigjoiner
On 04/10/2023 18:59, Teres Alexis, Alan Previn wrote:
On Thu, 2023-09-28 at 13:46 +0100, Tvrtko Ursulin wrote:
On 27/09/2023 17:36, Teres Alexis, Alan Previn wrote:
Thanks for taking the time to review this Tvrtko, replies inline below.
alan:snip
Main concern is that we need to be sure
On Wed, Oct 25, 2023 at 05:43:18PM +0530, Ankit Nautiyal wrote:
> At the moment the max requested bpc is limited to 6 to 10/12.
> For platforms that support DSC, min and max src bpc with DSC are
> different.
>
> Account for DSC bpc limitations, when setting min and max value for
>
At the moment the max requested bpc is limited to 6 to 10/12.
For platforms that support DSC, min and max src bpc with DSC are
different.
Account for DSC bpc limitations, when setting min and max value for
max_requested_bpc property.
Signed-off-by: Ankit Nautiyal
---
Use helpers for source min/max input bpc with DSC.
Signed-off-by: Ankit Nautiyal
---
drivers/gpu/drm/i915/display/intel_dp.c | 2 --
drivers/gpu/drm/i915/display/intel_dp.h | 2 ++
drivers/gpu/drm/i915/display/intel_dp_mst.c | 11 ---
3 files changed, 6 insertions(+), 9
Use correct helper for getting max DSC bpc supported by the source.
Fixes: 1c56e9a39833 ("drm/i915/dp: Get optimal link config to have best
compressed bpp")
Cc: Ankit Nautiyal
Cc: Stanislav Lisovskiy
Cc: Jani Nikula
Signed-off-by: Ankit Nautiyal
---
drivers/gpu/drm/i915/display/intel_dp.c
Return 0 if platform doesn't support DSC, and return 12 for Display ver
12+.
Signed-off-by: Ankit Nautiyal
---
drivers/gpu/drm/i915/display/intel_dp.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
Use helpers for source min/max src bpc appropriately for dp mst case and
to limit max_requested_bpc property min/max values.
Ankit Nautiyal (4):
drm/i915/dp: Simplify checks for helper intel_dp_dsc_max_src_input_bpc
drm/i915/dp: Fix the max DSC bpc supported by source
drm/i915/dp_mst: Use
On Wed, Oct 25, 2023 at 12:46:00PM +0300, Mika Kahola wrote:
> Display driver shall read DPCD 00071h[3:1] during configuration
> to get PSR setup time. This register provides the setup time
> requirement on the VSC SDP entry packet. If setup time cannot be
> met with the current timings
> (e.g.,
On Thu, 19 Oct 2023, "Borah, Chaitanya Kumar"
wrote:
>> -Original Message-
>> From: Govindapillai, Vinod
>> Sent: Wednesday, October 18, 2023 3:57 PM
>> To: intel-gfx@lists.freedesktop.org
>> Cc: Govindapillai, Vinod ; Sharma, Swati2
>> ; Borah, Chaitanya Kumar
>>
>> Subject: [PATCH v4
Today we got a report at [1] for rcu stalls on the i915 testsuite in [2]
due to the conversion of files to SLAB_TYPSSAFE_BY_RCU. Afaict,
get_file_rcu() goes into an infinite loop trying to carefully verify
that i915->gem.mmap_singleton hasn't changed - see the splat below.
So I stared at this
Hi Umesh,
On Fri, Oct 20, 2023 at 08:24:41AM -0700, Umesh Nerlige Ramappa wrote:
> When the driver unbinds, pmu is unregistered and i915->uabi_engines is
> set to RB_ROOT. Due to this, when i915 PMU tries to stop the engine
> events, it issues a warn_on because engine lookup fails.
>
> All perf
On Tue, 24 Oct 2023, Andi Shyti wrote:
> Hi Jani,
>
>> > static void rc6_res_reg_init(struct intel_rc6 *rc6)
>> > {
>> > - memset(rc6->res_reg, INVALID_MMIO_REG.reg, sizeof(rc6->res_reg));
>>
>> That's just bollocks. memset() is byte granularity, while
>> INVALID_MMIO_REG.reg is u32. If the
On Tue, 24 Oct 2023, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Try to drop a few seemingly unnecessary patches from core-for-CI.
Yay, ack!
>
> Ville Syrjälä (2):
> Revert "freezer: Dump more info on whoever is trying to get frozen
> with locks held"
> Revert "iommu: Remove iova
Hi Thomas, couple of minor comments and a question below.
On Wed, 2023-09-27 at 12:26 +0200, Thomas Zimmermann wrote:
> Replace all code that initializes or releases fbdev emulation
> throughout the driver. Instead initialize the fbdev client by a
> single call to i915_fbdev_setup() after i915
On Wed, 25 Oct 2023, Suraj Kandpal wrote:
> When we dock a monitor we end up with a enable and disable connector
> cycle but if hdcp content is running we get the userspace in
> enabled state and driver maintaing a undesired state which causes
> the content to stop playing and we only enabe hdcp
On Wed, 25 Oct 2023, Nemesa Garg wrote:
> Add debugfs entry for darkscreen to know the status
> bpc and timer value .
Superfluous space before '.'.
>
> Signed-off-by: Nemesa Garg
> ---
> .../gpu/drm/i915/display/intel_darkscreen.c | 38 +++
>
On Wed, 25 Oct 2023, Nemesa Garg wrote:
> Add new registers for Darkscreen
> The logic checks for any black screen at pipe level and upon such detection
> prints error.
> Darkscreen compares the pixels with the compare value(0x00 - black) for the
> detection purpose.
> This feature can be
On 25/10/2023 11:32, Coelho, Luciano wrote:
On Wed, 2023-10-25 at 11:25 +0100, Tvrtko Ursulin wrote:
On 25/10/2023 11:18, Tvrtko Ursulin wrote:
On 23/10/2023 11:33, Luca Coelho wrote:
The uncore code may not always be available (e.g. when we build the
display code with Xe), so we can't
Hello,
On Wed, Oct 25, 2023 at 10:53:27AM +0100, Sean Young wrote:
> On Mon, Oct 23, 2023 at 02:34:17PM +0100, Daniel Thompson wrote:
> > On Sun, Oct 22, 2023 at 11:46:22AM +0100, Sean Young wrote:
> > > On Sat, Oct 21, 2023 at 11:08:22AM +0200, Hans de Goede wrote:
> > > > On 10/19/23 12:51, Uwe
On Wed, 25 Oct 2023, Nirmoy Das wrote:
> On 10/24/2023 3:04 PM, Jani Nikula wrote:
>> Keep the display build lists together.
>>
>> Signed-off-by: Jani Nikula
>> ---
>> drivers/gpu/drm/i915/Makefile | 7 ---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git
Add new registers for Darkscreen
The logic checks for any black screen at pipe level and upon such detection
prints error.
Darkscreen compares the pixels with the compare value(0x00 - black) for the
detection purpose.
This feature can be enable/disable through debugfs.
Signed-off-by: Nemesa
Add debugfs entry for darkscreen to know the status
bpc and timer value .
Signed-off-by: Nemesa Garg
---
.../gpu/drm/i915/display/intel_darkscreen.c | 38 +++
.../drm/i915/display/intel_display_debugfs.c | 2 +
2 files changed, 40 insertions(+)
diff --git
The logic checks for any black screen at pipe level and
upon such detection prints error. Darkscreen compares the
pixels with the compare value(0x00 - black) for the detection
purpose. This feature can be enables/disabled through debugfs.
Nemesa Garg (2):
drm/i915: Add Darkscreen registers and
This workaround is primarily implemented by the BIOS. However if the
BIOS applies the workaround it will reserve a small piece of our DSM
(which should be at the top, right below the WOPCM); we just need to
keep that region reserved so that nothing else attempts to re-use it.
v2: Declare regs in
On Wed, 2023-10-25 at 11:25 +0100, Tvrtko Ursulin wrote:
> On 25/10/2023 11:18, Tvrtko Ursulin wrote:
> >
> > On 23/10/2023 11:33, Luca Coelho wrote:
> > > The uncore code may not always be available (e.g. when we build the
> > > display code with Xe), so we can't always rely on having the
Hi Nirmoy,
On Wed, Oct 25, 2023 at 12:28:26PM +0200, Nirmoy Das wrote:
> Handle platforms with multiple GTs by iterate over all GTs.
> Add a Fixes commit so this gets propagated for MTL support.
>
> Fixes: 213c43676beb ("drm/i915/mtl: Remove the 'force_probe' requirement for
> Meteor Lake")
>
On Wed, Oct 25, 2023 at 11:20:25AM +0100, Tvrtko Ursulin wrote:
>
> On 24/10/2023 13:42, Jani Nikula wrote:
> > On Tue, 24 Oct 2023, Andi Shyti wrote:
> > > Hi Jani,
> > >
> > > On Mon, Oct 23, 2023 at 06:02:55PM +0300, Jani Nikula wrote:
> > > > It's tedious to duplicate the container_of()
Handle platforms with multiple GTs by iterate over all GTs.
Add a Fixes commit so this gets propagated for MTL support.
Fixes: 213c43676beb ("drm/i915/mtl: Remove the 'force_probe' requirement for
Meteor Lake")
Suggested-by: John Harrison
Cc: Jani Nikula
Cc: Rodrigo Vivi
Cc: Tvrtko Ursulin
On 25/10/2023 11:18, Tvrtko Ursulin wrote:
On 23/10/2023 11:33, Luca Coelho wrote:
The uncore code may not always be available (e.g. when we build the
display code with Xe), so we can't always rely on having the uncore's
spinlock.
To handle this, split the spin_lock/unlock_irqsave/restore()
On 24/10/2023 13:42, Jani Nikula wrote:
On Tue, 24 Oct 2023, Andi Shyti wrote:
Hi Jani,
On Mon, Oct 23, 2023 at 06:02:55PM +0300, Jani Nikula wrote:
It's tedious to duplicate the container_of() everywhere. Add a helper.
Also do the logical steps of first getting from struct perf_event to
On 23/10/2023 11:33, Luca Coelho wrote:
The uncore code may not always be available (e.g. when we build the
display code with Xe), so we can't always rely on having the uncore's
spinlock.
To handle this, split the spin_lock/unlock_irqsave/restore() into
spin_lock/unlock() followed by a call
Display driver shall read DPCD 00071h[3:1] during configuration
to get PSR setup time. This register provides the setup time
requirement on the VSC SDP entry packet. If setup time cannot be
met with the current timings
(e.g., PSR setup time + other blanking requirements > blanking time),
driver
Hi Thomas, couple of inline commments/suggestions below.
On Wed, 2023-09-27 at 12:26 +0200, Thomas Zimmermann wrote:
> Move code from ad-hoc fbdev callbacks into DRM client functions
> and remove the old callbacks. The functions instruct the client
> to poll for changed output or restore the
On 10/24/2023 3:04 PM, Jani Nikula wrote:
Keep the display build lists together.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index
On 10/24/2023 3:04 PM, Jani Nikula wrote:
Unify the line continuations and indents, and sort the build lists.
Signed-off-by: Jani Nikula
---
Note: This is easiest to review by applying and looking at 'git show -w'
Thanks for the hint :)
Reviewed-by: Nirmoy Das
---
On Tue, Oct 24, 2023 at 06:57:35PM +0300, Andy Shevchenko wrote:
> Names of the MIPI sequence steps are sequential and defined, no
> need to check for the gaps. However in seq_name the MIPI_SEQ_END
> is missing. Add it there, and drop unneeded NULL check in
> sequence_name().
>
> Signed-off-by:
1 - 100 of 115 matches
Mail list logo
