On Sat, Oct 28, 2023 at 01:20:52AM +0530, Dnyaneshwar Bhadane wrote:
> This workaround is primarily implemented by the BIOS. However if the
> BIOS applies the workaround it will reserve a small piece of our DSM
> (which should be at the top, right below the WOPCM); we just need to
> keep that
== Series Details ==
Series: drm/i915: Skip pxp init if gt is wedged (rev2)
URL : https://patchwork.freedesktop.org/series/125658/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13825 -> Patchwork_125658v2
Summary
---
The gt wedged could be triggered by missing guc firmware file, HW not
working, etc. Once triggered, it means all gt usage is dead, therefore we
can't enable pxp under this fatal error condition.
v2: Updated commit message.
Signed-off-by: Zhanjun Dong
---
drivers/gpu/drm/i915/pxp/intel_pxp.c |
Hi all,
On Wed, 18 Oct 2023 12:46:36 +1100 Stephen Rothwell
wrote:
>
> On Fri, 13 Oct 2023 11:46:02 +1100 Stephen Rothwell
> wrote:
> >
> > Today's linux-next merge of the drm-misc tree got a conflict in:
> >
> > arch/ia64/include/asm/fb.h
> >
> > between commit:
> >
> > cf8e8658100d
On 2023-10-31 5:38 p.m., Teres Alexis, Alan Previn wrote:
On Fri, 2023-10-27 at 10:13 +0300, Jani Nikula wrote:
On Thu, 26 Oct 2023, Zhanjun Dong wrote:
alan:snip
I'll note that nobody checks intel_pxp_init() return status, so this
silently skips PXP.
BR,
Jani.
alan:snip
+ if
== Series Details ==
Series: series starting with [1/2] drm/i915: Remove incomplete PVC plumbing
(rev5)
URL : https://patchwork.freedesktop.org/series/125809/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13825 -> Patchwork_125809v5
== Series Details ==
Series: series starting with [1/2] drm/i915: Remove incomplete PVC plumbing
(rev5)
URL : https://patchwork.freedesktop.org/series/125809/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked
== Series Details ==
Series: series starting with [1/2] drm/i915: Remove incomplete PVC plumbing
(rev4)
URL : https://patchwork.freedesktop.org/series/125809/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13825 -> Patchwork_125809v4
== Series Details ==
Series: drm/i915: Remove unused for_each_uabi_class_engine (rev2)
URL : https://patchwork.freedesktop.org/series/125846/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/125846/revisions/2/mbox/ not
applied
Applying: drm/i915:
On Wed, Nov 01, 2023 at 06:26:47AM +, Hogander, Jouni wrote:
> On Tue, 2023-10-31 at 23:21 +, Paz Zcharya wrote:
> > Currently, i915 fails fastset if both the sink and the source support
> > any version of PSR and regardless of the configuration setting of the
> > driver (i.e.,
== Series Details ==
Series: series starting with [1/2] drm/i915: Remove incomplete PVC plumbing
(rev4)
URL : https://patchwork.freedesktop.org/series/125809/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked
== Series Details ==
Series: drm/i915/mtl: C20 state verification
URL : https://patchwork.freedesktop.org/series/125855/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13825 -> Patchwork_125855v1
Summary
---
On 30/10/2023 21:42, Andi Shyti wrote:
Hi Dorcas,
On Fri, Oct 27, 2023 at 08:47:45PM +0300, Dorcas AnonoLitunya wrote:
Removes space after opening parenthesis.
Fixes the checkpatch.pl error:
ERROR: space prohibited after that opening parenthesis '('
Signed-off-by: Dorcas AnonoLitunya
---
== Series Details ==
Series: drm/i915: Some register cleanups
URL : https://patchwork.freedesktop.org/series/125853/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13825 -> Patchwork_125853v1
Summary
---
**FAILURE**
== Series Details ==
Series: drm/i915: Some register cleanups
URL : https://patchwork.freedesktop.org/series/125853/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/include/asm/bitops.h:117:1:
== Series Details ==
Series: drm/i915: Some register cleanups
URL : https://patchwork.freedesktop.org/series/125853/
State : warning
== Summary ==
Error: dim checkpatch failed
2e6d356676a5 drm/i915: Extract hsw_chicken_trans_reg()
-:90: WARNING:LONG_LINE: line length of 108 exceeds 100
On 01/11/2023 10:06, Jani Nikula wrote:
On Wed, 01 Nov 2023, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Unused macro after 99919be74aa3 ("drm/i915/gem: Zap the i915_gem_object_blt
code")
removed some code.
Signed-off-by: Tvrtko Ursulin
\o/
Reviewed-by: Jani Nikula
Could I persuade
== Series Details ==
Series: series starting with [1/2] drm/i915: Remove incomplete PVC plumbing
(rev3)
URL : https://patchwork.freedesktop.org/series/125809/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13825 -> Patchwork_125809v3
Add state verification for C20 as we have one
for C10.
Signed-off-by: Mika Kahola
---
drivers/gpu/drm/i915/display/intel_cx0_phy.c | 111 ++
drivers/gpu/drm/i915/display/intel_cx0_phy.h | 2 +-
.../drm/i915/display/intel_modeset_verify.c | 2 +-
3 files changed, 88
== Series Details ==
Series: series starting with [1/2] drm/i915: Remove incomplete PVC plumbing
(rev3)
URL : https://patchwork.freedesktop.org/series/125809/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked
> -Original Message-
> From: Hogander, Jouni
> Sent: Wednesday, November 1, 2023 11:29 AM
> To: Kahola, Mika ; intel-gfx@lists.freedesktop.org
> Cc: ville.syrj...@linux.intel.com
> Subject: Re: [PATCH v2] drm/i915/display: Support PSR entry VSC packet to be
> transmitted one frame
> -Original Message-
> From: Ville Syrjälä
> Sent: Wednesday, November 1, 2023 11:38 AM
> To: Hogander, Jouni
> Cc: Kahola, Mika ; intel-gfx@lists.freedesktop.org
> Subject: Re: [PATCH v2] drm/i915/display: Support PSR entry VSC packet to be
> transmitted one frame earlier
>
> On Wed,
== Series Details ==
Series: drm/i915/mtl: Clear possible sticky bits on PICA message bus
URL : https://patchwork.freedesktop.org/series/125849/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13825 -> Patchwork_125849v1
== Series Details ==
Series: drm/i915/dsi: 2nd attempt to get rid of IOSF GPIO (rev4)
URL : https://patchwork.freedesktop.org/series/125516/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/125516/revisions/4/mbox/ not
applied
Applying:
> -Original Message-
> From: Jani Nikula
> Sent: Wednesday, November 1, 2023 12:51 PM
> To: Kahola, Mika ; intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Clear possible sticky bits on
> PICA message bus
>
> On Wed, 01 Nov 2023, Mika Kahola wrote:
> >
== Series Details ==
Series: drm/i915/dsi: gpio refactors
URL : https://patchwork.freedesktop.org/series/125848/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13825 -> Patchwork_125848v1
Summary
---
**SUCCESS**
On Tue, 31 Oct 2023, Imre Deak wrote:
> On Mon, Oct 30, 2023 at 05:58:15PM +0200, Imre Deak wrote:
> Hi Lyude, AMD folks et al,
>
> could you ack patches 2-9 in this patchset if they are ok and it's ok to
> merge them via the i915 tree?
Need acks from drm-misc maintainers too!
Cc: Maxime,
Thomas Zimmermann writes:
> Do not acquire a reference on the module that provides a client's
> callback functions in drm_client_init(). The additional reference
> prevents the user from unloading the callback functions' module and
> thus creating dangling pointers.
>
> This is only necessary if
From: Ville Syrjälä
The code to determine the pre-ICL DSI port control register is
repeated several times. Consolidate.
vlv_dsi_clear_device_ready() is left with the open-coded version
due to the weirdness with port A vs. C on VLV/CHV.
Signed-off-by: Ville Syrjälä
---
From: Ville Syrjälä
GLK has its own glk_dsi_clear_device_ready() so remove
the dead GLK checks from vlv_dsi_clear_device_ready().
Sadly BXT still uses vlv_dsi_clear_device_ready() so the
code still looks like a mess due to the difference in VLV/CHV
vs. BXT port A/C shenanigans.
Signed-off-by:
From: Ville Syrjälä
Stop repeating the same logic to determine the correct
config space register for MCHBAR.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/soc/intel_gmch.c | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git
From: Ville Syrjälä
'reg' is a very non-descriptive name. Just get rid of the silly
local variable and spell out the full register name always.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_display.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
From: Ville Syrjälä
We have the same code to determine the CHICKEN_TRANS register
offset sprinkled in a dozen places. Hoover it up into a small
helper.
TODO: find a better home for this
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_ddi.c | 9 +
From: Ville Syrjälä
Clean up some messy stuff related to determining
some register offsets.
Ville Syrjälä (5):
drm/i915: Extract hsw_chicken_trans_reg()
drm/i915: Stop using a 'reg' variable
drm/i915: Extract mchbar_reg()
drm/i915/dsi: Remove dead GLK checks
drm/i915/dsi: Extract
On Wed, Nov 01, 2023 at 12:17:30PM +0200, Ville Syrjälä wrote:
> On Mon, Oct 30, 2023 at 05:58:39PM +0200, Imre Deak wrote:
> > Factor out a helper to clear the pipe update flags, used by a follow-up
> > patch to modeset an MST topology.
> >
> > v2:
> > - Move the intel_crtc_needs_modeset() check
On Wed, Nov 01, 2023 at 12:51:12PM +0200, Jani Nikula wrote:
> On Wed, 01 Nov 2023, Mika Kahola wrote:
> > It is possible that sticky bits or error bits are left on
> > message bus status register. Reading and then writing the
> > value back to messagebus status register clears all possible
> >
== Series Details ==
Series: drm/i915: Remove unused for_each_uabi_class_engine
URL : https://patchwork.freedesktop.org/series/125846/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13824 -> Patchwork_125846v1
Summary
Hi,
On 11/1/23 11:20, Hans de Goede wrote:
> Hi,
>
> On 11/1/23 10:32, Andy Shevchenko wrote:
>> On Tue, Oct 31, 2023 at 10:15:52PM +0100, Hans de Goede wrote:
>>> On 10/31/23 17:07, Hans de Goede wrote:
On 10/24/23 18:11, Andy Shevchenko wrote:
> On Tue, Oct 24, 2023 at 06:57:38PM
== Series Details ==
Series: drm/i915: Remove unused for_each_uabi_class_engine
URL : https://patchwork.freedesktop.org/series/125846/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: Remove unused for_each_uabi_class_engine
URL : https://patchwork.freedesktop.org/series/125846/
State : warning
== Summary ==
Error: dim checkpatch failed
04f930dd6fea drm/i915: Remove unused for_each_uabi_class_engine
-:6: WARNING:COMMIT_LOG_LONG_LINE:
On Wed, 01 Nov 2023, Mika Kahola wrote:
> It is possible that sticky bits or error bits are left on
> message bus status register. Reading and then writing the
> value back to messagebus status register clears all possible
> sticky bits and errors.
Note that I don't know if this is the right
Hi,
On 11/1/23 11:34, Ville Syrjälä wrote:
> On Wed, Nov 01, 2023 at 11:20:23AM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 11/1/23 10:32, Andy Shevchenko wrote:
>>> On Tue, Oct 31, 2023 at 10:15:52PM +0100, Hans de Goede wrote:
On 10/31/23 17:07, Hans de Goede wrote:
> On 10/24/23
== Series Details ==
Series: series starting with [1/2] drm/i915: Remove incomplete PVC plumbing
(rev2)
URL : https://patchwork.freedesktop.org/series/125809/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13824 -> Patchwork_125809v2
On Wed, Nov 01, 2023 at 11:20:23AM +0100, Hans de Goede wrote:
> Hi,
>
> On 11/1/23 10:32, Andy Shevchenko wrote:
> > On Tue, Oct 31, 2023 at 10:15:52PM +0100, Hans de Goede wrote:
> >> On 10/31/23 17:07, Hans de Goede wrote:
> >>> On 10/24/23 18:11, Andy Shevchenko wrote:
> On Tue, Oct 24,
It is possible that sticky bits or error bits are left on
message bus status register. Reading and then writing the
value back to messagebus status register clears all possible
sticky bits and errors.
Signed-off-by: Mika Kahola
---
drivers/gpu/drm/i915/display/intel_cx0_phy.c | 14
On Wed, Oct 18, 2023 at 06:41:21PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Bspec tells us that we should disable the transcoder before
> deleting the payload. Looks like this has been reversed since
> MST support was added.
I suppose this shouldn't matter in practice since the
Hi,
On 11/1/23 10:32, Andy Shevchenko wrote:
> On Tue, Oct 31, 2023 at 10:15:52PM +0100, Hans de Goede wrote:
>> On 10/31/23 17:07, Hans de Goede wrote:
>>> On 10/24/23 18:11, Andy Shevchenko wrote:
On Tue, Oct 24, 2023 at 06:57:38PM +0300, Andy Shevchenko wrote:
>
> ...
>
>>> As for the
== Series Details ==
Series: series starting with [1/2] drm/i915: Remove incomplete PVC plumbing
(rev2)
URL : https://patchwork.freedesktop.org/series/125809/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked
On Mon, Oct 30, 2023 at 05:58:39PM +0200, Imre Deak wrote:
> Factor out a helper to clear the pipe update flags, used by a follow-up
> patch to modeset an MST topology.
>
> v2:
> - Move the intel_crtc_needs_modeset() check to the callers. (Ville)
>
> Reviewed-by: Stanislav Lisovskiy (v1)
>
The lowest level functions are about setting GPIO values, not about
executing any sequences anymore.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
Drop the unused parameter.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
With the various sequence versions and pointer increments interleaved,
it's a bit hard to decipher what's going on. Add separate paths for
different sequence versions.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 31
Follow the contemporary conventions.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
Purely a guess. Drop the nop function.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
This is something I've had laying around for more than a year I
think. Andy's series [1] reminded me of it. I don't think the two series
conflict, or if they do, it's trivial.
BR,
Jani.
[1] https://patchwork.freedesktop.org/series/125516/
Cc: Andy Shevchenko
Cc: Hans de Goede
Jani Nikula
On Wed, 01 Nov 2023, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Unused macro after 99919be74aa3 ("drm/i915/gem: Zap the i915_gem_object_blt
> code")
> removed some code.
>
> Signed-off-by: Tvrtko Ursulin
\o/
Reviewed-by: Jani Nikula
Could I persuade you to move for_each_engine(),
From: Tvrtko Ursulin
Unused macro after 99919be74aa3 ("drm/i915/gem: Zap the i915_gem_object_blt
code")
removed some code.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h
== Series Details ==
Series: drm/i915/display: Support PSR entry VSC packet to be transmitted one
frame earlier (rev2)
URL : https://patchwork.freedesktop.org/series/125558/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13824 -> Patchwork_125558v2
== Series Details ==
Series: drm/i915/display: Support PSR entry VSC packet to be transmitted one
frame earlier (rev2)
URL : https://patchwork.freedesktop.org/series/125558/
State : warning
== Summary ==
Error: dim checkpatch failed
0f3481222a42 drm/i915/display: Support PSR entry VSC packet
On Wed, Nov 01, 2023 at 09:28:51AM +, Hogander, Jouni wrote:
> On Wed, 2023-11-01 at 10:57 +0200, Mika Kahola wrote:
> > Display driver shall read DPCD 00071h[3:1] during configuration
> > to get PSR setup time. This register provides the setup time
> > requirement on the VSC SDP entry packet.
Hi
Am 01.11.23 um 10:25 schrieb Ville Syrjälä:
On Wed, Nov 01, 2023 at 09:33:41AM +0100, Thomas Zimmermann wrote:
Hi
Am 25.10.23 um 13:36 schrieb Hogander, Jouni:
[...]
+
+ if (!drm_drv_uses_atomic_modeset(dev))
+ drm_helper_disable_unused_functions(dev);
Can you please
Hi
Am 01.11.23 um 10:10 schrieb Hogander, Jouni:
[...]
We are currently working on new driver named as Xe. Due to this it
I've always thought that it's an entirely new driver. But I'm not
really
up-to-date. So the Xe driver is located under i915/ and also shares
code
with the existing i915
On Tue, Oct 31, 2023 at 10:15:52PM +0100, Hans de Goede wrote:
> On 10/31/23 17:07, Hans de Goede wrote:
> > On 10/24/23 18:11, Andy Shevchenko wrote:
> >> On Tue, Oct 24, 2023 at 06:57:38PM +0300, Andy Shevchenko wrote:
...
> > As for the CHT support, I have not added that to my tree yet, I
On Wed, 2023-11-01 at 10:57 +0200, Mika Kahola wrote:
> Display driver shall read DPCD 00071h[3:1] during configuration
> to get PSR setup time. This register provides the setup time
> requirement on the VSC SDP entry packet. If setup time cannot be
> met with the current timings
> (e.g., PSR
On Wed, Nov 01, 2023 at 09:33:41AM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 25.10.23 um 13:36 schrieb Hogander, Jouni:
> [...]
> >> +
> >> + if (!drm_drv_uses_atomic_modeset(dev))
> >> + drm_helper_disable_unused_functions(dev);
> >
> > Can you please explain why this is
On Wed, 2023-11-01 at 09:11 +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 25.10.23 um 10:36 schrieb Hogander, Jouni:
> > Hi Thomas, One minor comment inline below.
>
> Thank you so much for taking the time to review these patches.
>
> >
> > On Wed, 2023-09-27 at 12:26 +0200, Thomas Zimmermann
Display driver shall read DPCD 00071h[3:1] during configuration
to get PSR setup time. This register provides the setup time
requirement on the VSC SDP entry packet. If setup time cannot be
met with the current timings
(e.g., PSR setup time + other blanking requirements > blanking time),
driver
Hi
Am 25.10.23 um 13:36 schrieb Hogander, Jouni:
[...]
+
+ if (!drm_drv_uses_atomic_modeset(dev))
+ drm_helper_disable_unused_functions(dev);
Can you please explain why this is needed here?
This disables some parts of the mode-setting pipeline and is required
for
Hi
Am 25.10.23 um 11:36 schrieb Hogander, Jouni:
Hi Thomas, couple of inline commments/suggestions below.
On Wed, 2023-09-27 at 12:26 +0200, Thomas Zimmermann wrote:
Move code from ad-hoc fbdev callbacks into DRM client functions
and remove the old callbacks. The functions instruct the client
Hi
Am 25.10.23 um 10:36 schrieb Hogander, Jouni:
Hi Thomas, One minor comment inline below.
Thank you so much for taking the time to review these patches.
On Wed, 2023-09-27 at 12:26 +0200, Thomas Zimmermann wrote:
Initialize i915's fbdev client by giving an instance of struct
On Tue, 2023-10-31 at 23:21 +, Paz Zcharya wrote:
> Currently, i915 fails fastset if both the sink and the source support
> any version of PSR and regardless of the configuration setting of the
> driver (i.e., i915.enable_psr kernel argument). However, the
> implementation of PSR1 enable
71 matches
Mail list logo
