Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/vma: Fix potential UAF on multi-tile platforms (rev3)

2023-11-09 Thread Illipilli, TejasreeX
Hi, https://patchwork.freedesktop.org/series/126012/ - Re-reported Thanks, Tejasree -Original Message- From: Janusz Krzysztofik Sent: Friday, November 10, 2023 4:27 AM To: Andi Shyti Cc: intel-gfx@lists.freedesktop.org; LGCI Bug Filing Subject: Re: ✗ Fi.CI.BAT: failure for

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/vma: Fix potential UAF on multi-tile platforms (rev3)

2023-11-09 Thread Patchwork
== Series Details == Series: drm/i915/vma: Fix potential UAF on multi-tile platforms (rev3) URL : https://patchwork.freedesktop.org/series/126012/ State : success == Summary == CI Bug Log - changes from CI_DRM_13856 -> Patchwork_126012v3

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/vma: Fix potential UAF on multi-tile platforms (rev2)

2023-11-09 Thread Patchwork
== Series Details == Series: drm/i915/vma: Fix potential UAF on multi-tile platforms (rev2) URL : https://patchwork.freedesktop.org/series/126012/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13852 -> Patchwork_126012v2

[Intel-gfx] ✗ Fi.CI.BAT: failure for Don't send double context enable/disable requests

2023-11-09 Thread Patchwork
== Series Details == Series: Don't send double context enable/disable requests URL : https://patchwork.freedesktop.org/series/126234/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13859 -> Patchwork_126234v1 Summary

Re: [Intel-gfx] [PATCH 2/2] drm/i915: remove excess functions from plane protection check

2023-11-09 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, November 9, 2023 9:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH 2/2] drm/i915: remove excess functions from plane > protection check > > Reduce the

Re: [Intel-gfx] [PATCH 1/2] drm/i915: abstract plane protection check

2023-11-09 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, November 9, 2023 9:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH 1/2] drm/i915: abstract plane protection check > > Centralize the conditions in a

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/huc: Stop printing about unsupported HuC on MTL

2023-11-09 Thread Patchwork
== Series Details == Series: drm/i915/huc: Stop printing about unsupported HuC on MTL URL : https://patchwork.freedesktop.org/series/126226/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13859 -> Patchwork_126226v1 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gsc: Assign a uabi class number to the GSC CS

2023-11-09 Thread Patchwork
== Series Details == Series: drm/i915/gsc: Assign a uabi class number to the GSC CS URL : https://patchwork.freedesktop.org/series/126225/ State : success == Summary == CI Bug Log - changes from CI_DRM_13859 -> Patchwork_126225v1 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gsc: Assign a uabi class number to the GSC CS

2023-11-09 Thread Patchwork
== Series Details == Series: drm/i915/gsc: Assign a uabi class number to the GSC CS URL : https://patchwork.freedesktop.org/series/126225/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] Regression on linux-next (next-20231107)

2023-11-09 Thread Borah, Chaitanya Kumar
t; > > `` > > ``` > > > > We also verified that if we revert the patch the issue is not seen. > > > > Could you please check why the patch causes this regression

[Intel-gfx] [PATCH v6] drm/i915/dsb: DSB code refactoring

2023-11-09 Thread Animesh Manna
Refactor DSB implementation to be compatible with Xe driver. v1: RFC version. v2: Make intel_dsb structure opaque from external usage. [Jani] v3: Rebased on latest. v4: - Add boundary check in dsb_buffer_memset(). [Luca] - Use size_t instead of u32. [Luca] v5: WARN_ON() added for out of boudary

Re: [Intel-gfx] [PATCH] drm/i915/huc: Stop printing about unsupported HuC on MTL

2023-11-09 Thread John Harrison
On 11/9/2023 15:54, Daniele Ceraolo Spurio wrote: On MTL, the HuC is only supported on the media GT, so our validation check on the module parameter detects an inconsistency on the root GT (the modparams asks to enable HuC, but the support is not there) and prints the following info message:

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Add a selftest for FAST_REQUEST errors

2023-11-09 Thread John Harrison
On 11/9/2023 12:33, Daniele Ceraolo Spurio wrote: On 11/6/2023 3:59 PM, john.c.harri...@intel.com wrote: From: John Harrison There is a mechanism for reporting errors from fire and forget H2G messages. This is the only way to find out about almost any error in the GuC backend submission path.

Re: [Intel-gfx] [PATCH] drm/i915: Read a shadowed mmio register for ggtt flush

2023-11-09 Thread Belgaumkar, Vinay
On 11/9/2023 12:35 PM, Ville Syrjälä wrote: On Thu, Nov 09, 2023 at 12:01:26PM -0800, Belgaumkar, Vinay wrote: On 11/9/2023 11:30 AM, Ville Syrjälä wrote: On Thu, Nov 09, 2023 at 11:21:48AM -0800, Vinay Belgaumkar wrote: We read RENDER_HEAD as a part of the flush. If GT is in deeper sleep

[Intel-gfx] [PATCH 1/2] drm/i915/guc: Don't double enable a context

2023-11-09 Thread John . C . Harrison
From: John Harrison If a context is blocked, unblocked and subitted repeatedly in rapid succession, the driver can end up trying to enable the context while the previous enable request is still in flight. This can lead to much confusion in the state tracking. Prevent that by checking the

[Intel-gfx] [PATCH 2/2] drm/i915/guc: Don't disable a context whose enable is still pending

2023-11-09 Thread John . C . Harrison
From: John Harrison Various processes involve requesting GuC to disable a given context. However context enable/disable is an asynchronous process in the GuC. Thus, it is possible the previous enable request is still being processed when the disable request is triggered. Having both enable and

[Intel-gfx] [PATCH 0/2] Don't send double context enable/disable requests

2023-11-09 Thread John . C . Harrison
From: John Harrison The driver could sometimes send context enable/disable requests when a previous request was still pending. This is not allowed. So stop doing it. Signed-off-by: John Harrison John Harrison (2): drm/i915/guc: Don't double enable a context drm/i915/guc: Don't disable a

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: abstract plane protection check (rev2)

2023-11-09 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: abstract plane protection check (rev2) URL : https://patchwork.freedesktop.org/series/126205/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13856 -> Patchwork_126205v2

[Intel-gfx] [PATCH] drm/i915/huc: Stop printing about unsupported HuC on MTL

2023-11-09 Thread Daniele Ceraolo Spurio
On MTL, the HuC is only supported on the media GT, so our validation check on the module parameter detects an inconsistency on the root GT (the modparams asks to enable HuC, but the support is not there) and prints the following info message: [drm] GT0: Incompatible option enable_guc=3 - HuC is

[Intel-gfx] [PATCH] drm/i915/gsc: Assign a uabi class number to the GSC CS

2023-11-09 Thread Daniele Ceraolo Spurio
The GSC CS is not exposed to the user, so we skipped assigning a uabi class number for it. However, the trace logs use the uabi class and instance to identify the engine, so leaving uabi class unset makes the GSC CS show up as the RCS in those logs. Given that the engine is not exposed to the

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/vma: Fix potential UAF on multi-tile platforms (rev3)

2023-11-09 Thread Janusz Krzysztofik
On Thursday, 9 November 2023 22:44:02 CET Patchwork wrote: > == Series Details == > > Series: drm/i915/vma: Fix potential UAF on multi-tile platforms (rev3) > URL : https://patchwork.freedesktop.org/series/126012/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_13856

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Read a shadowed mmio register for ggtt flush

2023-11-09 Thread Patchwork
== Series Details == Series: drm/i915: Read a shadowed mmio register for ggtt flush URL : https://patchwork.freedesktop.org/series/126217/ State : success == Summary == CI Bug Log - changes from CI_DRM_13856 -> Patchwork_126217v1 Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: abstract plane protection check

2023-11-09 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: abstract plane protection check URL : https://patchwork.freedesktop.org/series/126205/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13856 -> Patchwork_126205v1

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/vma: Fix potential UAF on multi-tile platforms (rev3)

2023-11-09 Thread Patchwork
== Series Details == Series: drm/i915/vma: Fix potential UAF on multi-tile platforms (rev3) URL : https://patchwork.freedesktop.org/series/126012/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13856 -> Patchwork_126012v3

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm: Add drm_vblank_work_flush_all().

2023-11-09 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm: Add drm_vblank_work_flush_all(). URL : https://patchwork.freedesktop.org/series/126202/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13856 -> Patchwork_126202v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm: Add drm_vblank_work_flush_all().

2023-11-09 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm: Add drm_vblank_work_flush_all(). URL : https://patchwork.freedesktop.org/series/126202/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm: Add drm_vblank_work_flush_all().

2023-11-09 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm: Add drm_vblank_work_flush_all(). URL : https://patchwork.freedesktop.org/series/126202/ State : warning == Summary == Error: dim checkpatch failed abec0d586564 drm: Add drm_vblank_work_flush_all(). -:33: WARNING:WAITQUEUE_ACTIVE:

Re: [Intel-gfx] [PATCH] drm/i915: Read a shadowed mmio register for ggtt flush

2023-11-09 Thread Ville Syrjälä
On Thu, Nov 09, 2023 at 12:01:26PM -0800, Belgaumkar, Vinay wrote: > > On 11/9/2023 11:30 AM, Ville Syrjälä wrote: > > On Thu, Nov 09, 2023 at 11:21:48AM -0800, Vinay Belgaumkar wrote: > >> We read RENDER_HEAD as a part of the flush. If GT is in > >> deeper sleep states, this could lead to read

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Fix for potential false positives in GuC hang selftest

2023-11-09 Thread Daniele Ceraolo Spurio
On 11/6/2023 3:59 PM, john.c.harri...@intel.com wrote: From: John Harrison Noticed that the hangcheck selftest is submitting a non-preemptoble spinner. That means that even if the GuC does not die, the heartbeat will still kick in and trigger a reset. Which is rather defeating the purpose

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Add a selftest for FAST_REQUEST errors

2023-11-09 Thread Daniele Ceraolo Spurio
On 11/6/2023 3:59 PM, john.c.harri...@intel.com wrote: From: John Harrison There is a mechanism for reporting errors from fire and forget H2G messages. This is the only way to find out about almost any error in the GuC backend submission path. So it would be useful to know that it is

Re: [Intel-gfx] [PATCH] drm/i915: Read a shadowed mmio register for ggtt flush

2023-11-09 Thread Belgaumkar, Vinay
On 11/9/2023 11:30 AM, Ville Syrjälä wrote: On Thu, Nov 09, 2023 at 11:21:48AM -0800, Vinay Belgaumkar wrote: We read RENDER_HEAD as a part of the flush. If GT is in deeper sleep states, this could lead to read errors since we are not using a forcewake. Safer to read a shadowed register

Re: [Intel-gfx] [PULL] drm-misc-next

2023-11-09 Thread David Edelsohn
On Mon, Nov 6, 2023 at 5:55 AM Maxime Ripard wrote: > On Mon, Nov 06, 2023 at 11:37:34AM +0100, Thomas Hellström wrote: > > On 11/6/23 11:20, Maxime Ripard wrote: > > > On Mon, Nov 06, 2023 at 11:01:51AM +0100, Thomas Hellström wrote: > > > > Hi, David. > > > > > > > > On 11/3/23 17:37, David

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: C20 state verification (rev4)

2023-11-09 Thread Patchwork
== Series Details == Series: drm/i915/mtl: C20 state verification (rev4) URL : https://patchwork.freedesktop.org/series/125855/ State : success == Summary == CI Bug Log - changes from CI_DRM_13856 -> Patchwork_125855v4 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Read a shadowed mmio register for ggtt flush

2023-11-09 Thread Ville Syrjälä
On Thu, Nov 09, 2023 at 11:21:48AM -0800, Vinay Belgaumkar wrote: > We read RENDER_HEAD as a part of the flush. If GT is in > deeper sleep states, this could lead to read errors since we are > not using a forcewake. Safer to read a shadowed register instead. IIRC shadowing is only thing for

[Intel-gfx] [PATCH] drm/i915: Read a shadowed mmio register for ggtt flush

2023-11-09 Thread Vinay Belgaumkar
We read RENDER_HEAD as a part of the flush. If GT is in deeper sleep states, this could lead to read errors since we are not using a forcewake. Safer to read a shadowed register instead. Cc: John Harrison Cc: Daniele Ceraolo Spurio Signed-off-by: Vinay Belgaumkar ---

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/6] drm/i915: Add ability for tracking buffer objects per client (rev5)

2023-11-09 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915: Add ability for tracking buffer objects per client (rev5) URL : https://patchwork.freedesktop.org/series/126064/ State : success == Summary == CI Bug Log - changes from CI_DRM_13856 -> Patchwork_126064v5

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/6] drm/i915: Add ability for tracking buffer objects per client (rev5)

2023-11-09 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915: Add ability for tracking buffer objects per client (rev5) URL : https://patchwork.freedesktop.org/series/126064/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit

Re: [Intel-gfx] [PATCH] drm/i915/quirk: Add quirk for devices with incorrect PWM frequency

2023-11-09 Thread Dmitry Torokhov
Hi Allen, On Tue, Oct 17, 2023 at 06:01:39PM +, Allen Ballway wrote: > Cyernet T10C has a bad default PWM frequency causing the display to > strobe when the brightness is less than 100%. Create a new quirk to use > the value from the BIOS rather than the default register value. > >

[Intel-gfx] Regression on linux-next (next-20231107)

2023-11-09 Thread Borah, Chaitanya Kumar
next/combined-alt.html? [2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20231107 [3] http://gfx-ci.igk.intel.com/tree/linux-next/next-20231109/bat-dg2-14/boot0.txt [4] https://git.kernel.org/pub/scm/linux/kernel/git/next/linu

[Intel-gfx] [PATCH 1/2] drm/i915: abstract plane protection check

2023-11-09 Thread Jani Nikula
Centralize the conditions in a function. Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/skl_universal_plane.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c

[Intel-gfx] [PATCH 2/2] drm/i915: remove excess functions from plane protection check

2023-11-09 Thread Jani Nikula
Reduce the function calls by reusing ->decrypt. Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/skl_universal_plane.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c

[Intel-gfx] [PATCH 1/3] drm: Add drm_vblank_work_flush_all().

2023-11-09 Thread Maarten Lankhorst
In some cases we want to flush all vblank work, right before vblank_off for example. Add a simple function to make this possible. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_vblank_work.c | 22 ++ include/drm/drm_vblank_work.h | 2 ++ 2 files changed, 24

[Intel-gfx] [PATCH 2/3] drm/i915: Use vblank worker to unpin old legacy cursor fb safely

2023-11-09 Thread Maarten Lankhorst
From: Ville Syrjälä The cursor hardware only does sync updates, and thus the hardware will be scanning out from the old fb until the next start of vblank. So in order to make the legacy cursor fastpath actually safe we should not unpin the old fb until we're sure the hardware has ceased

[Intel-gfx] [PATCH 3/3] drm/i915: Use a different vblank worker for atomic unpin

2023-11-09 Thread Maarten Lankhorst
For the atomic codepath we unpin_work in old_plane_state to unpin the old fb. As this happened after swapping state, this is allowed. Use the unpin_work only as a barrier, and keep doing the actual unpinning in the atomic path. Signed-off-by: Maarten Lankhorst ---

Re: [Intel-gfx] [PATCH v2 0/6] drm/edid: split out drm_eld.[ch], add some SAD helpers

2023-11-09 Thread Jani Nikula
On Thu, 02 Nov 2023, Jani Nikula wrote: > On Tue, 31 Oct 2023, Jani Nikula wrote: >> v2 of https://patchwork.freedesktop.org/series/123384/ >> >> Jani Nikula (6): >> drm/edid: split out drm_eld.h from drm_edid.h >> drm/eld: replace uint8_t with u8 >> drm/edid: include drm_eld.h only where

Re: [Intel-gfx] [PATCH v2] drm/i915/vma: Fix potential UAF on multi-tile platforms

2023-11-09 Thread Andi Shyti
Hi Janusz, On Wed, Nov 08, 2023 at 05:29:06PM +0100, Janusz Krzysztofik wrote: > Object debugging tools were sporadically reporting illegal attempts to > free a still active i915 VMA object from when parking a GPU tile believed > to be idle. > > [161.359441] ODEBUG: free active (active state 0)

Re: [Intel-gfx] [PATCH v4] drm/i915/display: Support PSR entry VSC packet to be transmitted one frame earlier

2023-11-09 Thread Kahola, Mika
> -Original Message- > From: Jani Nikula > Sent: Wednesday, November 8, 2023 7:42 PM > To: Ville Syrjälä ; Kahola, Mika > > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v4] drm/i915/display: Support PSR entry VSC > packet to be transmitted one frame earlier >

Re: [Intel-gfx] [PATCH v9 1/6] drm/panelreplay: dpcd register definition for panelreplay

2023-11-09 Thread Jani Nikula
On Wed, 08 Nov 2023, Animesh Manna wrote: > Add DPCD register definition for discovering, enabling and > checking status of panel replay of the sink. > > Cc: Jouni Högander > Cc: Arun R Murthy > Cc: Jani Nikula > Reviewed-by: Arun R Murthy > Signed-off-by: Animesh Manna You got the ack,

Re: [Intel-gfx] [PATCH] drm/ttm: replace busy placement with flags v2

2023-11-09 Thread kernel test robot
Hi Somalapuram, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Somalapuram-Amaranath/drm-ttm-replace-busy-placement-with-flags-v2/20231109-104055 base: git://anongit.freedesktop.org

[Intel-gfx] [PATCH v2] drm/i915/mtl: C20 state verification

2023-11-09 Thread Mika Kahola
Add state verification for C20 as we have one for C10. V2: Use abstractation of HW readout (Gustavo) Drop MPLLA/B from message for TX and CMN parameters (Gustavo) Reviewed-by: Gustavo Sousa (v1) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 120

Re: [Intel-gfx] [PATCH] drm: i915: Adapt to -Walloc-size

2023-11-09 Thread Jani Nikula
On Wed, 08 Nov 2023, Jani Nikula wrote: > On Tue, 07 Nov 2023, Sam James wrote: >> GCC 14 introduces a new -Walloc-size included in -Wextra which errors out >> like: >> ``` >> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c: In function >> ‘eb_copy_relocations’: >>

Re: [Intel-gfx] [PATCH] drm/ttm: replace busy placement with flags v2

2023-11-09 Thread kernel test robot
Hi Somalapuram, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Somalapuram-Amaranath/drm-ttm-replace-busy-placement-with-flags-v2/20231109-104055 base: git://anongit.freedesktop.org

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/vma: Fix potential UAF on multi-tile platforms (rev2)

2023-11-09 Thread Janusz Krzysztofik
On Wednesday, 8 November 2023 22:27:35 CET Patchwork wrote: > == Series Details == > > Series: drm/i915/vma: Fix potential UAF on multi-tile platforms (rev2) > URL : https://patchwork.freedesktop.org/series/126012/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_13852

Re: [Intel-gfx] [PATCH] drm/ttm: replace busy placement with flags v2

2023-11-09 Thread kernel test robot
Hi Somalapuram, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Somalapuram-Amaranath/drm-ttm-replace-busy-placement-with-flags-v2/20231109-104055 base: git://anongit.freedesktop.org/drm