== Series Details ==
Series: Resolve suspend-resume racing with GuC destroy-context-worker (rev7)
URL : https://patchwork.freedesktop.org/series/121916/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13951 -> Patchwork_121916v7
Add @Oak to the KFD discussion. I will reply separately elaborating your
questions on GMEM's difference from HMM/MMU notifiers.
Christian, thanks for pointing me to that AMDKFD discussion. I have read the
discussion around the AMDKFD skeleton patch and found the previous discussion
in the
== Series Details ==
Series: series starting with [v3,1/2] drm/i915: Move reg_in_range_table
URL : https://patchwork.freedesktop.org/series/127082/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13951 -> Patchwork_127082v1
== Series Details ==
Series: series starting with [v3,1/2] drm/i915: Move reg_in_range_table
URL : https://patchwork.freedesktop.org/series/127082/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: series starting with [v3,1/2] drm/i915: Move reg_in_range_table
URL : https://patchwork.freedesktop.org/series/127082/
State : warning
== Summary ==
Error: dim checkpatch failed
553cf478868e drm/i915: Move reg_in_range_table
349983425e84 drm/i915: Introduce
== Series Details ==
Series: series starting with [v4,1/1] drm/i915/pxp: Add missing tag for
Wa_14019159160
URL : https://patchwork.freedesktop.org/series/127075/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13951 -> Patchwork_127075v1
== Series Details ==
Series: drm: enable W=1 warnings by default across the subsystem
URL : https://patchwork.freedesktop.org/series/127072/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13951 -> Patchwork_127072v1
Summary
== Series Details ==
Series: drm: enable W=1 warnings by default across the subsystem
URL : https://patchwork.freedesktop.org/series/127072/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/syncmap: squelch a sparse warning (rev2)
URL : https://patchwork.freedesktop.org/series/117802/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13951 -> Patchwork_117802v2
Summary
== Series Details ==
Series: drm/i915/syncmap: squelch a sparse warning (rev2)
URL : https://patchwork.freedesktop.org/series/117802/
State : warning
== Summary ==
Error: dim checkpatch failed
802dcf44a00e drm/i915/syncmap: squelch a sparse warning
-:4: WARNING:EMAIL_SUBJECT: A patch subject
== Series Details ==
Series: series starting with [v2,1/2] drm/i915: use PIPE_CONF_CHECK_BOOL() for
bool members
URL : https://patchwork.freedesktop.org/series/127066/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13951 -> Patchwork_127066v1
== Series Details ==
Series: series starting with [v1,1/1] drm/i915/display: Don't use "proxy"
headers (rev2)
URL : https://patchwork.freedesktop.org/series/127051/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13951 -> Patchwork_127051v2
On Wed, 2023-11-29 at 13:13 -0800, Teres Alexis, Alan Previn wrote:
> On Mon, 2023-11-27 at 15:24 -0500, Vivi, Rodrigo wrote:
> > On Wed, Nov 22, 2023 at 12:30:03PM -0800, Alan Previn wrote:
> alan:snip
> alan: thanks for reviewing and apologize for replying to this late.
>
> > > /*
> > > - *
If we are at the end of suspend or very early in resume
its possible an async fence signal (via rcu_call) is triggered
to free_engines which could lead us to the execution of
the context destruction worker (after a prior worker flush).
Thus, when suspending, insert rcu_barriers at the start
of
This series is the result of debugging issues root caused to
races between the GuC's destroyed_worker_func being triggered
vs repeating suspend-resume cycles with concurrent delayed
fence signals for engine-freeing.
The reproduction steps require that an app is launched right
before the start of
When suspending, flush the context-guc-id
deregistration worker at the final stages of
intel_gt_suspend_late when we finally call gt_sanitize
that eventually leads down to __uc_sanitize so that
the deregistration worker doesn't fire off later as
we reset the GuC microcontroller.
Signed-off-by:
== Series Details ==
Series: drm/i915/gem: Atomically invalidate userptr on mmu-notifier (rev2)
URL : https://patchwork.freedesktop.org/series/126998/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13949 -> Patchwork_126998v2
== Series Details ==
Series: drm/i915/gem: Atomically invalidate userptr on mmu-notifier (rev2)
URL : https://patchwork.freedesktop.org/series/126998/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/gem: Atomically invalidate userptr on mmu-notifier (rev2)
URL : https://patchwork.freedesktop.org/series/126998/
State : warning
== Summary ==
Error: dim checkpatch failed
6befc8cb8158 drm/i915/gem: Atomically invalidate userptr on mmu-notifier
-:117:
== Series Details ==
Series: drm/i915/display: Skip state verification with TBT-ALT mode (rev2)
URL : https://patchwork.freedesktop.org/series/126933/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13949 -> Patchwork_126933v2
Hi Weixi,
Even though Christian has listed reasons rejecting this proposal (yes they are
very reasonable to me), I would open my mind and further explore the
possibility here. Since the current GPU driver uses a hmm based implementation
(AMD and NV has done this; At Intel we are catching up),
On 11/13/2023 5:00 PM, john.c.harri...@intel.com wrote:
From: John Harrison
There is a mechanism for reporting errors from fire and forget H2G
messages. This is the only way to find out about almost any error in
the GuC backend submission path. So it would be useful to know that it
is
On Wed, 2023-11-29 at 15:34 -0500, Rodrigo Vivi wrote:
> On Wed, Nov 29, 2023 at 03:24:33PM -0500, Coelho, Luciano wrote:
> > On Wed, 2023-11-29 at 13:01 -0500, Rodrigo Vivi wrote:
> > > On Wed, Nov 29, 2023 at 11:17:28AM +0200, Luca Coelho wrote:
> > > > The uncore code may not always be
On Mon, 2023-11-27 at 15:24 -0500, Vivi, Rodrigo wrote:
> On Wed, Nov 22, 2023 at 12:30:03PM -0800, Alan Previn wrote:
alan:snip
alan: thanks for reviewing and apologize for replying to this late.
> > /*
> > -* On MTL and newer platforms, protected contexts require setting
> > -* the
Function reg_in_range_table is useful in more places, move function to
intel_uncore.h to make available to more places.
Signed-off-by: Matt Atwood
---
drivers/gpu/drm/i915/i915_perf.c| 13 +
drivers/gpu/drm/i915/intel_uncore.h | 12
2 files changed, 13
Wa_14011274333 applies to gen 12.0->12.55. There are regions of
registers that restore to default values on resume from rc6. The
hardware has a built in register (CTX_WA_PTR), that can point to a
region of memory full of commands to restore non default values on rc6
resume.
Based off patch by
On Wed, Nov 29, 2023 at 03:24:33PM -0500, Coelho, Luciano wrote:
> On Wed, 2023-11-29 at 13:01 -0500, Rodrigo Vivi wrote:
> > On Wed, Nov 29, 2023 at 11:17:28AM +0200, Luca Coelho wrote:
> > > The uncore code may not always be available (e.g. when we build the
> > > display code with Xe), so we
The uncore code may not always be available (e.g. when we build the
display code with Xe), so we can't always rely on having the uncore's
spinlock.
To handle this, split the spin_lock/unlock_irqsave/restore() into
spin_lock/unlock() followed by a call to local_irq_save/restore() and
create
On Wed, 2023-11-29 at 13:01 -0500, Rodrigo Vivi wrote:
> On Wed, Nov 29, 2023 at 11:17:28AM +0200, Luca Coelho wrote:
> > The uncore code may not always be available (e.g. when we build the
> > display code with Xe), so we can't always rely on having the uncore's
> > spinlock.
> >
> > To handle
Cc: Nathan Chancellor
On 11/29/23 13:12, Jani Nikula wrote:
At least the i915 and amd drivers enable a bunch more compiler warnings
than the kernel defaults.
Extend the W=1 warnings to the entire drm subsystem by default. Use the
copy-pasted warnings from scripts/Makefile.extrawarn with
Hi Dave, Daniel,
This pull request is a bit confusing, as it first adds the panel fixes
and a driver/core change, then immediately revert it.
Cheers,
~Maarten
drm-misc-fixes-2023-11-29:
Fixes for v6.7-rc4:
- Revert panel fixes as they require exporting device_is_dependent.
- Do not double
On Tue, Nov 28, 2023 at 08:03:31AM -0800, Matt Roper wrote:
> On Tue, Nov 28, 2023 at 03:54:51PM +0530, Balasubramani Vivekanandan wrote:
> > WAs 14011508470, 14011503030 were applied on IP versions beyond which
> > they are applicable. Fixed the IP version checks for these workarounds.
> >
> >
On Wed, Nov 29, 2023 at 07:33:17PM +0200, Jani Nikula wrote:
> Avoid bool/int mismatches in state checker macros.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git
On Wed, Nov 29, 2023 at 07:33:16PM +0200, Jani Nikula wrote:
> Don't treat bools as integers.
>
> v2: Rebase
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>
On Fri, 2023-11-24 at 08:30 +, Tvrtko Ursulin wrote:
> On 22/11/2023 19:15, Alan Previn wrote:
alan:snip
alan: thanks for reviewing.
> > if (iir & GEN12_DISPLAY_STATE_RESET_COMPLETE_INTERRUPT)
> > - pxp->session_events |= PXP_TERMINATION_COMPLETE;
> > +
On Wed, Nov 29, 2023 at 07:35:06PM +0200, Jani Nikula wrote:
> The code is fine, really, but tweak it to get rid of the sparse warning:
>
> drivers/gpu/drm/i915/selftests/i915_syncmap.c:80:54: warning: dubious: x | !y
>
> Signed-off-by: Jani Nikula
I always disliked the '!!' magic anyway,
On Mon, 2023-11-27 at 16:51 -0500, Vivi, Rodrigo wrote:
alan: Firstly, thanks for taking the time to review this, knowing you have a
lot on your plate right now.
>
alan:snip
> > @@ -3301,19 +3315,38 @@ static inline void guc_lrc_desc_unpin(struct
> > intel_context *ce)
> > /* Seal race
Add missing tag for "Wa_14019159160 - Case 2" (for existing
PXP code that ensures run alone mode bit is set to allow
PxP-decryption.
v4: - Include IP_VER 12.71. (Matt Roper)
v3: - Check targeted platforms using IP_VAL. (John Harrison)
v2: - Fix WA id number (John Harrison).
- Improve
On Wed, 29 Nov 2023, Kevin Quillen wrote:
> Posting here for visibility. I have tried up to the latest 6.6.2 kernel
> with the same result.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=2248917
Please file i915 issues to the freedesktop.org gitlab according to [1].
Thanks,
Jani.
[1]
Posting here for visibility. I have tried up to the latest 6.6.2 kernel
with the same result.
https://bugzilla.redhat.com/show_bug.cgi?id=2248917
1. Please describe the problem:
All kernel versions after 6.4.12 are refusing to boot. I took this
error out of the logs:
```
Nov 05 17:56:01
At least the i915 and amd drivers enable a bunch more compiler warnings
than the kernel defaults.
Extend the W=1 warnings to the entire drm subsystem by default. Use the
copy-pasted warnings from scripts/Makefile.extrawarn with
s/KBUILD_CFLAGS/subdir-ccflags-y/ to make it easier to compare and
On Wed, Nov 29, 2023 at 11:17:28AM +0200, Luca Coelho wrote:
> The uncore code may not always be available (e.g. when we build the
> display code with Xe), so we can't always rely on having the uncore's
> spinlock.
>
> To handle this, split the spin_lock/unlock_irqsave/restore() into
>
On Tue, 2023-11-28 at 10:03 -0800, Roper, Matthew D wrote:
> On Mon, Nov 27, 2023 at 12:11:50PM -0800, Alan Previn wrote:
> > Add missing tag for "Wa_14019159160 - Case 2" (for existing
> > PXP code that ensures run alone mode bit is set to allow
> > PxP-decryption.
alan:snip.
alan: thanks for
On Wed, 29 Nov 2023, 何敏红 wrote:
> Friendly ping. I think this patch was forgotten.
Pushed, thanks for the patch.
>
>
>
> 主 题：[PATCH v2] drm/i915: correct the input parameter on _intel_dsb_commit()
> 日 期：2023-11-14 10:43
> 发件人：何敏红
> 收件人：何敏红;
>
> Current, the dewake_scanline variable is
The code is fine, really, but tweak it to get rid of the sparse warning:
drivers/gpu/drm/i915/selftests/i915_syncmap.c:80:54: warning: dubious: x | !y
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/selftests/i915_syncmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Don't treat bools as integers.
v2: Rebase
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c
b/drivers/gpu/drm/i915/display/intel_display.c
index
Avoid bool/int mismatches in state checker macros.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c
b/drivers/gpu/drm/i915/display/intel_display.c
index
On Tue, 14 Nov 2023, heminhong wrote:
> Current, the dewake_scanline variable is defined as unsigned int,
> an unsigned int variable that is always greater than or equal to 0.
> when _intel_dsb_commit function is called by intel_dsb_commit function,
> the dewake_scanline variable may have an int
On Wed, 29 Nov 2023, Andy Shevchenko wrote:
> The driver uses math.h and not util_macros.h.
>
> Signed-off-by: Andy Shevchenko
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_snps_phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
== Series Details ==
Series: drm/i915/hwmon: Fix static analysis tool errors in i915 hwmon
URL : https://patchwork.freedesktop.org/series/127034/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13945 -> Patchwork_127034v1
== Series Details ==
Series: drm/i915/hwmon: Fix static analysis tool errors in i915 hwmon
URL : https://patchwork.freedesktop.org/series/127034/
State : warning
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/127034/revisions/1/mbox/ not
found
Am 29.11.23 um 09:27 schrieb zhuweixi:
Glad to hear that more sharable code is desirable.
IMHO, for a common MM subsystem, it is more beneficial for
GMEM to extend core MM instead of building a separate one.
As stated in the beginning of my RFC letter, MM systems are
large and similar. Even a
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Friday, November 24, 2023 10:28 AM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 2/5] drm/i915: Replace a memset() with zero
> initialization
>
> From: Ville Syrjälä
>
> Declaring a
== Series Details ==
Series: QGV/SAGV related fixes (rev2)
URL : https://patchwork.freedesktop.org/series/126962/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13945 -> Patchwork_126962v2
Summary
---
**FAILURE**
The driver uses math.h and not util_macros.h.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_snps_phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_snps_phy.c
b/drivers/gpu/drm/i915/display/intel_snps_phy.c
index
== Series Details ==
Series: QGV/SAGV related fixes (rev2)
URL : https://patchwork.freedesktop.org/series/126962/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/include/asm/bitops.h:116:1:
== Series Details ==
Series: QGV/SAGV related fixes (rev2)
URL : https://patchwork.freedesktop.org/series/126962/
State : warning
== Summary ==
Error: dim checkpatch failed
6deb00a50791 drm/i915: Add meaningful traces for QGV point info error handling
9d4a009f4cbe drm/i915: Extract code
Hi Jani,
On 28/11/23 18:33, Jani Nikula wrote:
On Tue, 28 Nov 2023, Vignesh Raman wrote:
On 28/11/23 12:21, Manivannan Sadhasivam wrote:
On Tue, Nov 28, 2023 at 11:44:26AM +0530, Vignesh Raman wrote:
Hi Mani,
On 28/11/23 10:44, Manivannan Sadhasivam wrote:
On Tue, Nov 28, 2023 at
With TBT-ALT mode we are not programming C20 chip PLL's and
hence we don't need to check state verification. We don't
need to program DP link signal levels i.e.pre-emphasis and
voltage swing either.
This patch fixes dmesg errors like this one
"[drm] ERROR PHY F Write 0c06 failed after 3
On Wed, 29 Nov 2023, Karthik Poosa wrote:
> Updated i915 hwmon with fixes for issues reported by static analysis tool.
What's the problem? It's not enough to say this fixes a static analyzer
report. Tell us what the problem is, and why this is the fix.
BR,
Jani.
>
> Signed-off-by: Karthik
Updated i915 hwmon with fixes for issues reported by static analysis tool.
Signed-off-by: Karthik Poosa
---
drivers/gpu/drm/i915/i915_hwmon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_hwmon.c
b/drivers/gpu/drm/i915/i915_hwmon.c
index
The uncore code may not always be available (e.g. when we build the
display code with Xe), so we can't always rely on having the uncore's
spinlock.
To handle this, split the spin_lock/unlock_irqsave/restore() into
spin_lock/unlock() followed by a call to local_irq_save/restore() and
create
Problem is that on some platforms, we do get QGV point mask in wrong
state on boot. However driver assumes it is set to 0
(i.e all points allowed), however in reality we might get them all restricted,
causing issues.
Lets disable SAGV initially to force proper QGV point state.
If more QGV points
In order to introduce a pwm api which can be used from atomic context,
we will need two functions for applying pwm changes:
int pwm_apply_might_sleep(struct pwm *, struct pwm_state *);
int pwm_apply_atomic(struct pwm *, struct pwm_state *);
This commit just deals with renaming
On Fri, Nov 24, 2023 at 02:31:18PM +0100, Thierry Reding wrote:
> On Sat, Nov 18, 2023 at 04:16:17PM +, Sean Young wrote:
> > In order to introduce a pwm api which can be used from atomic context,
> > we will need two functions for applying pwm changes:
> >
> > int
Oops, that should be changed to the following:
/* SPDX-License-Identifier: GPL-2.0-only */
/*
* Generalized Memory Management.
*
* Copyright (C) 2023- Huawei, Inc.
* Author: Weixi Zhu
*
*/
Thanks for pointing it out.
-Weixi
-Original Message-
From: emily
Sent: Wednesday,
Glad to hear that more sharable code is desirable.
IMHO, for a common MM subsystem, it is more beneficial for
GMEM to extend core MM instead of building a separate one.
As stated in the beginning of my RFC letter, MM systems are
large and similar. Even a sophisticated one like Linux MM
that
On Fri, 2023-11-17 at 17:15 +, Zanoni, Paulo R wrote:
> On Fri, 2023-11-17 at 11:50 -0500, Rodrigo Vivi wrote:
> > On Fri, Nov 17, 2023 at 11:26:44AM +0200, Ville Syrjälä wrote:
> > > On Fri, Nov 17, 2023 at 10:41:43AM +0200, Ville Syrjälä wrote:
> > > > On Fri, Nov 17, 2023 at 08:05:21AM
On Fri, 2023-11-17 at 12:46 +, Tvrtko Ursulin wrote:
> On 17/11/2023 12:21, Coelho, Luciano wrote:
> > Adding Tvrtko, for some reason he didn't get CCed before.
> >
> >
> > On Fri, 2023-11-17 at 11:26 +0200, Ville Syrjälä wrote:
> > > On Fri, Nov 17, 2023 at 10:41:43AM +0200, Ville Syrjälä
69 matches
Mail list logo
