✓ Fi.CI.BAT: success for drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

2024-03-06 Thread Patchwork
== Series Details == Series: drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2 URL : https://patchwork.freedesktop.org/series/130851/ State : success == Summary == CI Bug Log - changes from CI_DRM_14400 -> Patchwork_130851v1

✗ Fi.CI.SPARSE: warning for drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

2024-03-06 Thread Patchwork
== Series Details == Series: drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2 URL : https://patchwork.freedesktop.org/series/130851/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

2024-03-06 Thread Patchwork
== Series Details == Series: drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2 URL : https://patchwork.freedesktop.org/series/130851/ State : warning == Summary == Error: dim checkpatch failed 54fc3a878567 drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2 -:12:

✗ Fi.CI.BAT: failure for Enable Adaptive Sync SDP Support for DP (rev16)

2024-03-06 Thread Patchwork
== Series Details == Series: Enable Adaptive Sync SDP Support for DP (rev16) URL : https://patchwork.freedesktop.org/series/126829/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14400 -> Patchwork_126829v16 Summary ---

✗ Fi.CI.CHECKPATCH: warning for Enable Adaptive Sync SDP Support for DP (rev16)

2024-03-06 Thread Patchwork
== Series Details == Series: Enable Adaptive Sync SDP Support for DP (rev16) URL : https://patchwork.freedesktop.org/series/126829/ State : warning == Summary == Error: dim checkpatch failed 184028cc83b6 drm/dp: Add support to indicate if sink supports AS SDP 80e1133c2b56 drm: Add Adaptive

✗ Fi.CI.SPARSE: warning for Enable Adaptive Sync SDP Support for DP (rev16)

2024-03-06 Thread Patchwork
== Series Details == Series: Enable Adaptive Sync SDP Support for DP (rev16) URL : https://patchwork.freedesktop.org/series/126829/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[PATCH] drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

2024-03-06 Thread Wayne Lin
[Why] Commit: - commit 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload allocation/removement") accidently overwrite the commit - commit 54d217406afe ("drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2") which cause regression. [How] Recover the original NULL fix and remove the

✗ Fi.CI.BAT: failure for Enable MST bigjoiner (rev3)

2024-03-06 Thread Patchwork
== Series Details == Series: Enable MST bigjoiner (rev3) URL : https://patchwork.freedesktop.org/series/130449/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14400 -> Patchwork_130449v3 Summary --- **FAILURE**

[PATCH v16 9/9] drm/i915/display: Read/Write Adaptive Sync SDP

2024-03-06 Thread Mitul Golani
Add read/write calls for Adaptive Sync SDP. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c

[PATCH v16 8/9] drm/i915/display: Compute vrr_vsync params

2024-03-06 Thread Mitul Golani
Compute vrr_vsync_start/end, which sets the position for hardware to send the Vsync at a fixed position relative to the end of the Vblank. --v2: - Updated VSYNC_START/END macros to VRR_VSYNC_START/END. (Ankit) - Updated bit fields of VRR_VSYNC_START/END. (Ankit) --v3: - Add

[PATCH v16 7/9] drm/i915/display: Add state checker for Adaptive Sync SDP

2024-03-06 Thread Mitul Golani
Enable infoframe and add state checker for Adaptive Sync SDP enablement. --v1: - crtc_state->infoframes.enable, to add on correct place holder. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display.c | 46 1 file changed,

[PATCH v16 6/9] drm/i915/display: Compute AS SDP parameters

2024-03-06 Thread Mitul Golani
Add necessary function definitions to compute AS SDP data. The new intel_dp_compute_as_sdp function computes AS SDP values based on the display configuration, ensuring proper handling of Variable Refresh Rate (VRR). --v2: - Added DP_SDP_ADAPTIVE_SYNC to infoframe_type_to_idx(). [Ankit] -

[PATCH v16 5/9] drm/i915/dp: Add wrapper function to check AS SDP

2024-03-06 Thread Mitul Golani
Add a wrapper function to check if both the source and sink support Adaptive Sync SDP. --v1: Just use drm/i915/dp in subject line. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 8 drivers/gpu/drm/i915/display/intel_dp.h | 1 + 2

[PATCH v16 4/9] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-03-06 Thread Mitul Golani
Add the necessary structures and functions to handle reading and unpacking Adaptive Sync Secondary Data Packets. Also add support to write and pack AS SDP. --v2: - Correct use of REG_BIT and REG_GENMASK. [Jani] - Use as_sdp instead of async. [Jani] - Remove unrelated comments and changes. [Jani]

[PATCH v16 3/9] drm/i915/display: Add crtc state dump for Adaptive Sync SDP

2024-03-06 Thread Mitul Golani
Add crtc state dump for Adaptive Sync SDP to know which crtc specifically caused the failure. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- .../gpu/drm/i915/display/intel_crtc_state_dump.c| 13 + drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 2 files

[PATCH v16 1/9] drm/dp: Add support to indicate if sink supports AS SDP

2024-03-06 Thread Mitul Golani
Add an API that indicates support for Adaptive Sync SDP in the sink, which can be utilized by the rest of the DP programming. --v1: - Format commit message properly. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/display/drm_dp_helper.c | 25

[PATCH v16 2/9] drm: Add Adaptive Sync SDP logging

2024-03-06 Thread Mitul Golani
Add structure representing Adaptive Sync Secondary Data Packet (AS SDP). Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate debugging. --v2: - Update logging. [Jani, Ankit] - Use 'as_sdp' instead of 'async' [Ankit] - Correct define placeholders to where they are actually used.

[PATCH v16 0/9] Enable Adaptive Sync SDP Support for DP

2024-03-06 Thread Mitul Golani
An Adaptive-Sync-capable DP protocol converter indicates its support by setting the related bit in the DPCD register. This is valid for DP and edp as well. Computes AS SDP values based on the display configuration, ensuring proper handling of Variable Refresh Rate (VRR) in the context of Adaptive

[PATCH 1/1] drm/i915: Allow bigjoiner for MST

2024-03-06 Thread Vidya Srinivas
We need bigjoiner support with MST functionality for MST monitor resolutions > 5K to work. Adding support for the same. v2: Addressed review comments from Jani. Revert rejection of MST bigjoiner modes and add functionality v3: Fixed pipe_mismatch WARN for mst_master_transcoder Credits-to: Manasi

[PATCH 0/1] Enable MST bigjoiner

2024-03-06 Thread Vidya Srinivas
Support resolutions > 5k on MST monitors that need bigjoiner by adding MST bigjoiner functionality Vidya Srinivas (1): drm/i915: Allow bigjoiner for MST drivers/gpu/drm/i915/display/intel_ddi.c| 6 -- drivers/gpu/drm/i915/display/intel_dp_mst.c | 17 + 2 files

Re: [PATCH 22/22] drm: ensure drm headers are self-contained and pass kernel-doc

2024-03-06 Thread kernel test robot
Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [cannot apply to drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.8-rc7 next-20240306] [If your patch is applied to the wrong git tree, kindly

RE: [PATCH] drm/i915/dp: Enable AUX based backlight for HDR

2024-03-06 Thread Kandpal, Suraj
> -Original Message- > From: Ville Syrjälä > Sent: Wednesday, March 6, 2024 5:57 PM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma ; > Nautiyal, Ankit K > Subject: Re: [PATCH] drm/i915/dp: Enable AUX based backlight for HDR > > On Wed, Mar 06, 2024 at

✓ Fi.CI.BAT: success for drm/i915: Drop WA 16015675438 (rev2)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Drop WA 16015675438 (rev2) URL : https://patchwork.freedesktop.org/series/130815/ State : success == Summary == CI Bug Log - changes from CI_DRM_14400 -> Patchwork_130815v2 Summary ---

Re: [PATCH 22/22] drm: ensure drm headers are self-contained and pass kernel-doc

2024-03-06 Thread kernel test robot
Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [cannot apply to drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.8-rc7 next-20240306] [If your patch is applied to the wrong git tree, kindly

✗ Fi.CI.BAT: failure for drm/ci: update device type for volteer devices (rev3)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/ci: update device type for volteer devices (rev3) URL : https://patchwork.freedesktop.org/series/130723/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14400 -> Patchwork_130723v3 Summary

✗ Fi.CI.BAT: failure for drm/i915/dsi: Go back to the previous INIT_OTP/DISPLAY_ON order, mostly (rev2)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Go back to the previous INIT_OTP/DISPLAY_ON order, mostly (rev2) URL : https://patchwork.freedesktop.org/series/130714/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14400 -> Patchwork_130714v2

✗ Fi.CI.SPARSE: warning for drm/i915/dsi: Go back to the previous INIT_OTP/DISPLAY_ON order, mostly (rev2)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Go back to the previous INIT_OTP/DISPLAY_ON order, mostly (rev2) URL : https://patchwork.freedesktop.org/series/130714/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

✓ Fi.CI.BAT: success for drm/i915: Make crtc disable more atomic (rev3)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Make crtc disable more atomic (rev3) URL : https://patchwork.freedesktop.org/series/130715/ State : success == Summary == CI Bug Log - changes from CI_DRM_14400 -> Patchwork_130715v3 Summary ---

✗ Fi.CI.BAT: failure for drm/i915: cleanup dead code

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: cleanup dead code URL : https://patchwork.freedesktop.org/series/130828/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14400 -> Patchwork_130828v1 Summary --- **FAILURE**

✗ Fi.CI.SPARSE: warning for drm/i915: cleanup dead code

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: cleanup dead code URL : https://patchwork.freedesktop.org/series/130828/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[PATCH v3] drm/ci: update device type for volteer devices

2024-03-06 Thread Vignesh Raman
Volteer devices in the collabora lab are categorized under the asus-cx9400-volteer device type. The majority of these units has an Intel Core i5-1130G7 CPU, while some of them have a Intel Core i7-1160G7 CPU instead. So due to this difference, new device type template is added for the Intel Core

linux-next: manual merge of the drm tree with the drm-intel-fixes tree

2024-03-06 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/i915/display/intel_dp.c between commit: 984318aaf7b6 ("drm/i915/panelreplay: Move out psr_init_dpcd() from init_connector()") from the drm-intel-fixes tree and commit: e60cff453b82 ("drm/i915/dp:

✗ Fi.CI.BAT: failure for drm: fix headers, add header test facility

2024-03-06 Thread Patchwork
== Series Details == Series: drm: fix headers, add header test facility URL : https://patchwork.freedesktop.org/series/130822/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14399 -> Patchwork_130822v1 Summary ---

✗ Fi.CI.SPARSE: warning for drm: fix headers, add header test facility

2024-03-06 Thread Patchwork
== Series Details == Series: drm: fix headers, add header test facility URL : https://patchwork.freedesktop.org/series/130822/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm: fix headers, add header test facility

2024-03-06 Thread Patchwork
== Series Details == Series: drm: fix headers, add header test facility URL : https://patchwork.freedesktop.org/series/130822/ State : warning == Summary == Error: dim checkpatch failed 7caa1d7414d8 drm/crtc: make drm_crtc_internal.h self-contained ff01e9a4a385 drm: add missing header guards

✗ Fi.CI.BAT: failure for drm/i915/mtl: Update workaround 14018575942 (rev5)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Update workaround 14018575942 (rev5) URL : https://patchwork.freedesktop.org/series/130490/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14399 -> Patchwork_130490v5 Summary

Re: [PATCH v4 3/3] drm/i915/gt: Enable only one CCS for compute workload

2024-03-06 Thread Matt Roper
On Wed, Mar 06, 2024 at 02:22:47AM +0100, Andi Shyti wrote: > Enable only one CCS engine by default with all the compute sices > allocated to it. > > While generating the list of UABI engines to be exposed to the > user, exclude any additional CCS engines beyond the first > instance. > > This

✗ Fi.CI.BAT: failure for drm/i915: Drop WA 16015675438

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Drop WA 16015675438 URL : https://patchwork.freedesktop.org/series/130815/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14399 -> Patchwork_130815v1 Summary --- **FAILURE**

Re: [PATCH v4 1/3] drm/i915/gt: Disable HW load balancing for CCS

2024-03-06 Thread Matt Roper
On Wed, Mar 06, 2024 at 02:22:45AM +0100, Andi Shyti wrote: > The hardware should not dynamically balance the load between CCS > engines. Wa_14019159160 recommends disabling it across all > platforms. > > Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement") > Signed-off-by: Andi

✓ Fi.CI.BAT: success for drm/i915/mst: enable MST mode for 128b/132b single-stream sideband (rev4)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915/mst: enable MST mode for 128b/132b single-stream sideband (rev4) URL : https://patchwork.freedesktop.org/series/129468/ State : success == Summary == CI Bug Log - changes from CI_DRM_14399 -> Patchwork_129468v4

✗ Fi.CI.SPARSE: warning for drm/i915/mst: enable MST mode for 128b/132b single-stream sideband (rev4)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915/mst: enable MST mode for 128b/132b single-stream sideband (rev4) URL : https://patchwork.freedesktop.org/series/129468/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915/mst: enable MST mode for 128b/132b single-stream sideband (rev4)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915/mst: enable MST mode for 128b/132b single-stream sideband (rev4) URL : https://patchwork.freedesktop.org/series/129468/ State : warning == Summary == Error: dim checkpatch failed 2343cd3592f6 drm/mst: read sideband messaging cap -:128: WARNING:LONG_LINE:

✓ Fi.CI.BAT: success for drm/i915: better high level abstraction for display

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: better high level abstraction for display URL : https://patchwork.freedesktop.org/series/130805/ State : success == Summary == CI Bug Log - changes from CI_DRM_14398 -> Patchwork_130805v1 Summary

✗ Fi.CI.SPARSE: warning for drm/i915: better high level abstraction for display

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: better high level abstraction for display URL : https://patchwork.freedesktop.org/series/130805/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: better high level abstraction for display

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: better high level abstraction for display URL : https://patchwork.freedesktop.org/series/130805/ State : warning == Summary == Error: dim checkpatch failed 3000e528f9db drm/i915/display: ideas for further separating display code from the rest

✗ Fi.CI.BAT: failure for drm/i915: Fix VMA UAF on destroy against deactivate race (rev6)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Fix VMA UAF on destroy against deactivate race (rev6) URL : https://patchwork.freedesktop.org/series/129026/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14398 -> Patchwork_129026v6

✗ Fi.CI.SPARSE: warning for drm/i915: Fix VMA UAF on destroy against deactivate race (rev6)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Fix VMA UAF on destroy against deactivate race (rev6) URL : https://patchwork.freedesktop.org/series/129026/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for ALPM AUX-Less (rev3)

2024-03-06 Thread Patchwork
== Series Details == Series: ALPM AUX-Less (rev3) URL : https://patchwork.freedesktop.org/series/129938/ State : success == Summary == CI Bug Log - changes from CI_DRM_14398 -> Patchwork_129938v3 Summary --- **SUCCESS** No

✗ Fi.CI.SPARSE: warning for ALPM AUX-Less (rev3)

2024-03-06 Thread Patchwork
== Series Details == Series: ALPM AUX-Less (rev3) URL : https://patchwork.freedesktop.org/series/129938/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for ALPM AUX-Less (rev3)

2024-03-06 Thread Patchwork
== Series Details == Series: ALPM AUX-Less (rev3) URL : https://patchwork.freedesktop.org/series/129938/ State : warning == Summary == Error: dim checkpatch failed 0b6310df18cc drm/display: Add missing aux less alpm wake related bits 46f774b6bd3b drm/i915/psr: Add missing ALPM AUX-Less

✗ Fi.CI.BAT: failure for Disable automatic load CCS load balancing (rev6)

2024-03-06 Thread Patchwork
== Series Details == Series: Disable automatic load CCS load balancing (rev6) URL : https://patchwork.freedesktop.org/series/129951/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14398 -> Patchwork_129951v6 Summary ---

[PATCH 5/5] drm/i915: Remove special handling for !RCS_MASK()

2024-03-06 Thread Lucas De Marchi
With both XEHPSDV and PVC removed (as platforms, most of their code remain used by others), there's no need to handle !RCS_MASK() as other platforms don't ever have fused-off render. Remove those code paths and the special WA flag when initializing GuC. Signed-off-by: Lucas De Marchi ---

[PATCH 4/5] drm/i915: Drop dead code for pvc

2024-03-06 Thread Lucas De Marchi
PCI IDs for PVC were never added and platform always marked with force_probe. Drop what's not used and rename some places as needed. The registers not used anymore are also removed. Signed-off-by: Lucas De Marchi --- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 +-

[PATCH 2/5] drm/i915: Drop dead code for xehpsdv

2024-03-06 Thread Lucas De Marchi
PCI IDs for XEHPSDV were never added and platform always marked with force_probe. Drop what's not used and rename some places to either be xehp or dg2, depending on the platform/IP checks. The registers not used anymore are also removed. Signed-off-by: Lucas De Marchi --- Potential problem

[PATCH 1/5] drm/i915: Drop WA 16015675438

2024-03-06 Thread Lucas De Marchi
With dynamic load-balancing disabled on the compute side, there's no reason left to enable WA 16015675438. Drop it from both PVC and DG2. Note that this can be done because now the driver always set a fixed partition of EUs during initialization via the ccs_mode configuration. The flag to GuC is

[PATCH 0/5] drm/i915: cleanup dead code

2024-03-06 Thread Lucas De Marchi
Remove platforms that never had their PCI IDs added to the driver and are of course marked with requiring force_probe. Note that most of the code for those platforms is actually used by subsequent ones, so it's not a huge amount of code being removed.

[PATCH 3/5] drm/i915: Update IP_VER(12, 50)

2024-03-06 Thread Lucas De Marchi
With no platform declaring graphics/media IP_VER(12, 50), replace the checks throughout the code with IP_VER(12, 55) so the code makes sense by itself with no additional explanation of previous baggage. The info override for the various _info is then changed so the version definition is clearer

✗ Fi.CI.CHECKPATCH: warning for Disable automatic load CCS load balancing (rev6)

2024-03-06 Thread Patchwork
== Series Details == Series: Disable automatic load CCS load balancing (rev6) URL : https://patchwork.freedesktop.org/series/129951/ State : warning == Summary == Error: dim checkpatch failed c4061a06af34 drm/i915/gt: Disable HW load balancing for CCS cb3a146b7a46 drm/i915/gt: Refactor uabi

✓ Fi.CI.BAT: success for drm/i915/dp: Enable AUX based backlight for HDR (rev2)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915/dp: Enable AUX based backlight for HDR (rev2) URL : https://patchwork.freedesktop.org/series/130729/ State : success == Summary == CI Bug Log - changes from CI_DRM_14398 -> Patchwork_130729v2 Summary

[PATCH 22/22] drm: ensure drm headers are self-contained and pass kernel-doc

2024-03-06 Thread Jani Nikula
Ensure drm headers build, are self-contained, have header guards, and have no kernel-doc warnings, when CONFIG_DRM_HEADER_TEST=y. The mechanism follows similar patters used in i915, xe, and usr/include. To cover include/drm, we need to recurse there using the top level Kbuild and the new

[PATCH 20/22] drm/ttm: fix ttm_execbuf_util.h kernel-doc warnings

2024-03-06 Thread Jani Nikula
Fix some formatting errors and excess documentation. Signed-off-by: Jani Nikula --- include/drm/ttm/ttm_execbuf_util.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/include/drm/ttm/ttm_execbuf_util.h b/include/drm/ttm/ttm_execbuf_util.h index

[PATCH 21/22] drm/ttm: fix ttm_kmap_iter.h kernel-doc warnings

2024-03-06 Thread Jani Nikula
There's no proper way to document function pointer members, but at least silence the warnings. Signed-off-by: Jani Nikula --- include/drm/ttm/ttm_kmap_iter.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/drm/ttm/ttm_kmap_iter.h b/include/drm/ttm/ttm_kmap_iter.h

[PATCH 19/22] drm/ttm: make ttm_caching.h self-contained

2024-03-06 Thread Jani Nikula
Include for pgprot_t. Signed-off-by: Jani Nikula --- include/drm/ttm/ttm_caching.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/ttm/ttm_caching.h b/include/drm/ttm/ttm_caching.h index 235a743d90e1..a18f43e93aba 100644 --- a/include/drm/ttm/ttm_caching.h +++

[PATCH 18/22] drm/ttm: fix ttm_bo.h kernel-doc warnings

2024-03-06 Thread Jani Nikula
Some renames, some formatting fixes, add some as FIXME. Signed-off-by: Jani Nikula --- include/drm/ttm/ttm_bo.h | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/include/drm/ttm/ttm_bo.h b/include/drm/ttm/ttm_bo.h index 0223a41a64b2..8b1eb6828f0a 100644 ---

[PATCH 17/22] drm/i915/pxp: fix i915_pxp_tee_interface.h kernel-doc warnings

2024-03-06 Thread Jani Nikula
Make documentation match code. Signed-off-by: Jani Nikula --- include/drm/i915_pxp_tee_interface.h | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/include/drm/i915_pxp_tee_interface.h b/include/drm/i915_pxp_tee_interface.h index

[PATCH 16/22] drm/i915/hdcp: fix i915_hdcp_interface.h kernel-doc warnings

2024-03-06 Thread Jani Nikula
Make the documentation match code. Signed-off-by: Jani Nikula --- include/drm/i915_hdcp_interface.h | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/include/drm/i915_hdcp_interface.h b/include/drm/i915_hdcp_interface.h index 4c9c8167c2d5..a9f2ee576de8

[PATCH 15/22] drm/i915: fix i915_gsc_proxy_mei_interface.h kernel-doc

2024-03-06 Thread Jani Nikula
There's no proper way to document function pointer members, but at least silence the warnings. Signed-off-by: Jani Nikula --- include/drm/i915_gsc_proxy_mei_interface.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/drm/i915_gsc_proxy_mei_interface.h

[PATCH 14/22] drm/suballoc: fix drm_suballoc.h kernel-doc

2024-03-06 Thread Jani Nikula
Rename dma_fence to fence to match code. Signed-off-by: Jani Nikula --- include/drm/drm_suballoc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_suballoc.h b/include/drm/drm_suballoc.h index c2188bb0b157..7ba72a81a808 100644 --- a/include/drm/drm_suballoc.h

[PATCH 13/22] drm/i2c: silence ch7006.h and sil164.h kernel-doc warnings

2024-03-06 Thread Jani Nikula
Mark some members private to silence kernel-doc warnings, and add FIXME comments. Signed-off-by: Jani Nikula --- include/drm/i2c/ch7006.h | 1 + include/drm/i2c/sil164.h | 1 + 2 files changed, 2 insertions(+) diff --git a/include/drm/i2c/ch7006.h b/include/drm/i2c/ch7006.h index

[PATCH 12/22] drm/of: make drm_of.h self-contained

2024-03-06 Thread Jani Nikula
Include for ERR_PTR. Signed-off-by: Jani Nikula --- include/drm/drm_of.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_of.h b/include/drm/drm_of.h index 082a6e980d01..02d1cdd7f798 100644 --- a/include/drm/drm_of.h +++ b/include/drm/drm_of.h @@ -2,6 +2,7 @@ #ifndef

[PATCH 11/22] drm: fix drm_gem_vram_helper.h kernel-doc

2024-03-06 Thread Jani Nikula
Remove excess funcs kernel-doc. Signed-off-by: Jani Nikula --- include/drm/drm_gem_vram_helper.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/drm/drm_gem_vram_helper.h b/include/drm/drm_gem_vram_helper.h index e18429f09e53..c89c9bafeb44 100644 ---

[PATCH 10/22] drm/lease: make drm_lease.h self-contained

2024-03-06 Thread Jani Nikula
Include for types used. Signed-off-by: Jani Nikula --- include/drm/drm_lease.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_lease.h b/include/drm/drm_lease.h index 5c9ef6a2aeae..53545b4ca9ef 100644 --- a/include/drm/drm_lease.h +++ b/include/drm/drm_lease.h @@ -6,6

[PATCH 09/22] drm: fix drm_format_helper.h kernel-doc warnings

2024-03-06 Thread Jani Nikula
As the documentation says, all the fields are considered private. Mark them private also for kernel-doc to silence warnings. Signed-off-by: Jani Nikula --- include/drm/drm_format_helper.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_format_helper.h

[PATCH 08/22] drm/encoder: silence drm_encoder_slave.h kernel-doc

2024-03-06 Thread Jani Nikula
Mark some parts private to silence kernel-doc warnings, and add FIXME. Signed-off-by: Jani Nikula --- include/drm/drm_encoder_slave.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/drm/drm_encoder_slave.h b/include/drm/drm_encoder_slave.h index 7214101fd731..7f0ee97bb3a5 100644

[PATCH 07/22] drm/crc: make drm_debugfs_crc.h self-contained and fix kernel-doc

2024-03-06 Thread Jani Nikula
Add a number of require includes and forward declare struct drm_crtc. s/crc/crcs/ kernel-doc to match code. Signed-off-by: Jani Nikula --- include/drm/drm_debugfs_crc.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_debugfs_crc.h

[PATCH 06/22] drm/dp_mst: fix drm_dp_mst_helper.h kernel-doc

2024-03-06 Thread Jani Nikula
Drop excess vcpi member documentation. Signed-off-by: Jani Nikula --- include/drm/display/drm_dp_mst_helper.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/drm/display/drm_dp_mst_helper.h b/include/drm/display/drm_dp_mst_helper.h index 9b19d8bd520a..3ae88a383a41 100644 ---

[PATCH 04/22] drm/amdgpu: make amd_asic_type.h self-contained

2024-03-06 Thread Jani Nikula
Include for u8. Signed-off-by: Jani Nikula --- include/drm/amd_asic_type.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/drm/amd_asic_type.h b/include/drm/amd_asic_type.h index 724c45e3e9a7..9be85b821aa6 100644 --- a/include/drm/amd_asic_type.h +++

[PATCH 03/22] drm/kunit: fix drm_kunit_helpers.h kernel-doc

2024-03-06 Thread Jani Nikula
s/_features/_feat/ to match code. Signed-off-by: Jani Nikula --- include/drm/drm_kunit_helpers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_kunit_helpers.h b/include/drm/drm_kunit_helpers.h index 6e99627edf45..e7cc17ee4934 100644 ---

✓ Fi.CI.BAT: success for IO and fast wake lines calculation and increase fw sync length (rev4)

2024-03-06 Thread Patchwork
== Series Details == Series: IO and fast wake lines calculation and increase fw sync length (rev4) URL : https://patchwork.freedesktop.org/series/130173/ State : success == Summary == CI Bug Log - changes from CI_DRM_14398 -> Patchwork_130173v4

[PATCH 05/22] drm: bridge: samsung-dsim: make samsung-dsim.h self-contained

2024-03-06 Thread Jani Nikula
Include and forward declare struct platform device. Signed-off-by: Jani Nikula --- include/drm/bridge/samsung-dsim.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h index e0c105051246..9764d6eb5beb

[PATCH 02/22] drm: add missing header guards to drm_internal.h

2024-03-06 Thread Jani Nikula
Including the file twice leads to errors. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_internal.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h index 8e4faf0a28e6..d69744c9ac15 100644 ---

[PATCH 01/22] drm/crtc: make drm_crtc_internal.h self-contained

2024-03-06 Thread Jani Nikula
Forward declare struct drm_printer. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_crtc_internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h index a514d5207e41..72c26f996b3b 100644 ---

[PATCH 00/22] drm: fix headers, add header test facility

2024-03-06 Thread Jani Nikula
First, fix a bunch of issues in drm headers, uncovered with the last patch. A few kernel-doc warnings are just brushed under the carpet for now, with a FIXME comment. Otherwise, pretty straightforward stuff. Second, add a header test facility to catch issues at build time when

Re: [RFC v2 0/4] drm/i915: better high level abstraction for display

2024-03-06 Thread Rodrigo Vivi
On Wed, Mar 06, 2024 at 02:24:34PM +0200, Jani Nikula wrote: > This is v2 of [1]. Improve the abstractions for display code. > > The main goals are: > > 1) The display code does not access struct drm_i915_private or struct >xe_device. It only uses its own struct intel_display instead. > >

✗ Fi.CI.SPARSE: warning for IO and fast wake lines calculation and increase fw sync length (rev4)

2024-03-06 Thread Patchwork
== Series Details == Series: IO and fast wake lines calculation and increase fw sync length (rev4) URL : https://patchwork.freedesktop.org/series/130173/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [RFC v2 2/4] drm/i915/display: add generic to_intel_display() macro

2024-03-06 Thread Rodrigo Vivi
On Wed, Mar 06, 2024 at 02:24:36PM +0200, Jani Nikula wrote: > Convert various pointers to struct intel_display * using _Generic(). > > Add some macro magic to make adding new conversions easier, and somewhat > abstract the need to cast each generic association. The cast is required > because all

Re: [PATCH v8 1/3] drm/buddy: Implement tracking clear page feature

2024-03-06 Thread Matthew Auld
On 04/03/2024 16:32, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. - Track the available cleared pages

Re: ✗ Fi.CI.BAT: failure for drm/i915: Convert fbdev to DRM client (rev7)

2024-03-06 Thread Thomas Zimmermann
FYI, there's a possible regression reported here. I was not able to reproduce this bug locally with neither i915 nor xe. Am 01.03.24 um 18:42 schrieb Patchwork: Project List - Patchwork *Patch Details* *Series:* drm/i915: Convert fbdev to DRM client (rev7) *URL:*

RE: Regression on linux-next (next-20240228)

2024-03-06 Thread Borah, Chaitanya Kumar
Hello Mathew, > -Original Message- > From: Matthew Wilcox > Sent: Tuesday, March 5, 2024 11:19 PM > To: Borah, Chaitanya Kumar > Cc: intel-gfx@lists.freedesktop.org; Kurmi, Suresh Kumar > ; Saarinen, Jani > Subject: Re: Regression on linux-next (next-20240228) > > On Tue, Mar 05, 2024

Re: [PATCH v8 1/3] drm/buddy: Implement tracking clear page feature

2024-03-06 Thread Paneer Selvam, Arunpravin
Hi Matthew, Ping? Thanks, Arun. On 3/4/2024 10:02 PM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. -

Re: [PATCH v8 3/3] drm/buddy: Add user for defragmentation

2024-03-06 Thread Paneer Selvam, Arunpravin
Hi Christian, On 3/5/2024 5:41 PM, Christian König wrote: Am 05.03.24 um 12:14 schrieb Paneer Selvam, Arunpravin: On 3/5/2024 4:33 PM, Paneer Selvam, Arunpravin wrote: Hi Christian, On 3/4/2024 10:09 PM, Christian König wrote: Am 04.03.24 um 17:32 schrieb Arunpravin Paneer Selvam: Add

Re: linux-next: build failure after merge of the kunit-next tree

2024-03-06 Thread Shuah Khan
Hi Stephen, On 3/1/24 15:30, Shuah Khan wrote: Hi Stephen, On 3/1/24 13:46, Stephen Rothwell wrote: Hi Shuah, On Fri, 1 Mar 2024 09:05:57 -0700 Shuah Khan wrote: On 3/1/24 03:43, Stephen Rothwell wrote: Hi all, On Fri, 1 Mar 2024 15:15:02 +0800 David Gow wrote: On Thu, 29 Feb 2024 at

Re: [PATCH v7 2/6] drm/i915: Unregister in-kernel clients

2024-03-06 Thread Thomas Zimmermann
Hi Am 05.03.24 um 17:25 schrieb Jani Nikula: On Tue, 05 Mar 2024, Rodrigo Vivi wrote: On Fri, Mar 01, 2024 at 02:42:55PM +0100, Thomas Zimmermann wrote: Unregister all in-kernel clients before unloading the i915 driver. For other drivers, drm_dev_unregister() does this automatically. As i915

[PATCH] drm/i915: Drop WA 16015675438

2024-03-06 Thread Lucas De Marchi
With dynamic load-balancing disabled on the compute side, there's no reason left to enable WA 16015675438. Drop it from both PVC and DG2. Note that this can be done because now the driver always set a fixed partition of EUs during initialization via the ccs_mode configuration. The flag to GuC is

Re: [PULL] drm-misc-fixes

2024-03-06 Thread Maxime Ripard
Hi, On Thu, Feb 29, 2024 at 01:54:30PM +, Matthew Auld wrote: > On 29/02/2024 13:37, Maxime Ripard wrote: > > Hi, > > > > Here's this week drm-misc fixes PR. > > > > There's two commits for files unders drivers/soc/qcom that don't have a > > maintainer Acked-by. Bjorn's Acked-by was

[PATCH v3 5/6] drm/i915/mst: add intel_dp_mst_disconnect()

2024-03-06 Thread Jani Nikula
Abstract the MST mode disconnect to a separate function. Cc: Arun R Murthy Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git

[PATCH v3 6/6] drm/i915/mst: enable MST mode for 128b/132b single-stream sideband

2024-03-06 Thread Jani Nikula
If the sink supports 128b/132b and single-stream sideband messaging, enable MST mode. With this, the topology manager will still write DP_MSTM_CTRL, which should be ignored by the sink. In the future, the topology manager should probably only set the sideband messaging related parts of the

[PATCH v3 4/6] drm/i915/mst: use the MST mode detected previously

2024-03-06 Thread Jani Nikula
Drop the duplicate read of DP_MSTM_CAP DPCD register, and the duplicate logic for choosing MST mode, and store the chosen mode in struct intel_dp. Rename intel_dp_configure_mst() to intel_dp_mst_configure() while at it. v2: Rebase on drm_dp_mst_detect() returning the mode, not bool Cc: Arun R

[PATCH v3 3/6] drm/i915/mst: abstract choosing the MST mode to use

2024-03-06 Thread Jani Nikula
Clarify the conditions for choosing the MST mode to use by adding a new function intel_dp_mst_mode_choose(). This also prepares for being able to extend the MST modes to single-stream sideband messaging. Cc: Arun R Murthy Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula

[PATCH v3 2/6] drm/i915/mst: improve debug logging of DP MST mode detect

2024-03-06 Thread Jani Nikula
Rename intel_dp_can_mst() to intel_dp_mst_detect(), and move all DP MST detect debug logging there. Debug log the sink's MST capability, including single-stream sideband messaging support, and the decision whether to enable MST mode or not. Do this regardless of whether we're actually enabling MST

  1   2   >