Re: [PATCH] drm/i915/dp: Fix DSC state HW readout for SST connectors

On 3/11/2024 8:26 PM, Imre Deak wrote: Commit a62e14598150 ("drm/i915/dp: Fix connector DSC HW state readout") moved the DSC HW state readout to a connector specific hook, however only added the hook for DP MST connectors, not for DP SST ones. Fix adding the hook for SST connectors as well.

✗ Fi.CI.BAT: failure for drm/i915/display: Fixed a screen flickering when turning on display from off (rev2)

== Series Details == Series: drm/i915/display: Fixed a screen flickering when turning on display from off (rev2) URL : https://patchwork.freedesktop.org/series/130780/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14420 -> Patchwork_130780v2

✓ Fi.CI.BAT: success for Fix divide-by-zero regression on DP MST unplug with nouveau

== Series Details == Series: Fix divide-by-zero regression on DP MST unplug with nouveau URL : https://patchwork.freedesktop.org/series/131002/ State : success == Summary == CI Bug Log - changes from CI_DRM_14420 -> Patchwork_131002v1

✗ Fi.CI.CHECKPATCH: warning for Fix divide-by-zero regression on DP MST unplug with nouveau

== Series Details == Series: Fix divide-by-zero regression on DP MST unplug with nouveau URL : https://patchwork.freedesktop.org/series/131002/ State : warning == Summary == Error: dim checkpatch failed 0a773e72b268 Fix divide-by-zero regression on DP MST unplug with nouveau -:14:

[PATCH] drm/i915/display: Fixed a screen flickering when turning on display from off

From: Gareth Yu Turn on the panel from zero brightness of the last state, the panel was set a maximum PWM in the flow. Once the panel initialization is completed, the backlight is restored to xero brightness. There is a flckering generated. This flicker happens in "Screen dimming and power off"

✗ Fi.CI.BUILD: failure for drm/i915/gem: Execbuffer objects must have struct pages.

== Series Details == Series: drm/i915/gem: Execbuffer objects must have struct pages. URL : https://patchwork.freedesktop.org/series/131000/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC [M]

✓ Fi.CI.BAT: success for drm/i915/hwmon: Fix locking inversion in sysfs getter (rev2)

== Series Details == Series: drm/i915/hwmon: Fix locking inversion in sysfs getter (rev2) URL : https://patchwork.freedesktop.org/series/130966/ State : success == Summary == CI Bug Log - changes from CI_DRM_14420 -> Patchwork_130966v2

✗ Fi.CI.CHECKPATCH: warning for drm/i915/hwmon: Fix locking inversion in sysfs getter (rev2)

== Series Details == Series: drm/i915/hwmon: Fix locking inversion in sysfs getter (rev2) URL : https://patchwork.freedesktop.org/series/130966/ State : warning == Summary == Error: dim checkpatch failed 876b08387035 drm/i915/hwmon: Fix locking inversion in sysfs getter -:14:

✗ Fi.CI.BAT: failure for series starting with drm/xe: Introduce xe_pm_runtime_get_noresume for inner callers (rev3)

== Series Details == Series: series starting with drm/xe: Introduce xe_pm_runtime_get_noresume for inner callers (rev3) URL : https://patchwork.freedesktop.org/series/130995/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14420 -> Patchwork_130995v3

✗ Fi.CI.SPARSE: warning for series starting with drm/xe: Introduce xe_pm_runtime_get_noresume for inner callers (rev3)

== Series Details == Series: series starting with drm/xe: Introduce xe_pm_runtime_get_noresume for inner callers (rev3) URL : https://patchwork.freedesktop.org/series/130995/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be

✓ Fi.CI.BAT: success for drm/i915/dp: Fix DSC state HW readout for SST connectors

== Series Details == Series: drm/i915/dp: Fix DSC state HW readout for SST connectors URL : https://patchwork.freedesktop.org/series/130986/ State : success == Summary == CI Bug Log - changes from CI_DRM_14420 -> Patchwork_130986v1 Summary

✗ Fi.CI.BAT: failure for Enable Adaptive Sync SDP Support for DP (rev17)

== Series Details == Series: Enable Adaptive Sync SDP Support for DP (rev17) URL : https://patchwork.freedesktop.org/series/126829/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14420 -> Patchwork_126829v17 Summary ---

✗ Fi.CI.SPARSE: warning for Enable Adaptive Sync SDP Support for DP (rev17)

== Series Details == Series: Enable Adaptive Sync SDP Support for DP (rev17) URL : https://patchwork.freedesktop.org/series/126829/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Enable Adaptive Sync SDP Support for DP (rev17)

== Series Details == Series: Enable Adaptive Sync SDP Support for DP (rev17) URL : https://patchwork.freedesktop.org/series/126829/ State : warning == Summary == Error: dim checkpatch failed 451ab13b0a0e drm/dp: Add support to indicate if sink supports AS SDP cf5877afd69f drm: Add Adaptive

✗ Fi.CI.BAT: failure for drm: fix .get_modes() return values (rev2)

== Series Details == Series: drm: fix .get_modes() return values (rev2) URL : https://patchwork.freedesktop.org/series/130926/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14420 -> Patchwork_130926v2 Summary ---

✗ Fi.CI.SPARSE: warning for drm: fix .get_modes() return values (rev2)

== Series Details == Series: drm: fix .get_modes() return values (rev2) URL : https://patchwork.freedesktop.org/series/130926/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

✓ Fi.CI.BAT: success for drm/i915/dp: Enable AUX based backlight for HDR (rev4)

== Series Details == Series: drm/i915/dp: Enable AUX based backlight for HDR (rev4) URL : https://patchwork.freedesktop.org/series/130729/ State : success == Summary == CI Bug Log - changes from CI_DRM_14420 -> Patchwork_130729v4 Summary

[drm-intel:for-linux-next 4/6] drivers/gpu/drm/i915/display/intel_bios.c:3417:24: error: implicit declaration of function 'intel_opregion_vbt_present'; did you mean 'intel_opregion_asle_present'?

tree: git://anongit.freedesktop.org/drm-intel for-linux-next head: 0e7dd6fe96020e6b7f5e068bf1c66078e0b145d3 commit: 9d9bb71f3e115b75ec5e38f087e159a87fc0413a [4/6] drm/i915: Extract opregion vbt presence check config: sparc64-allmodconfig

✗ Fi.CI.BAT: failure for drm/i915/dp: Increase idle pattern wait timeout to 2ms (rev4)

== Series Details == Series: drm/i915/dp: Increase idle pattern wait timeout to 2ms (rev4) URL : https://patchwork.freedesktop.org/series/130643/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14420 -> Patchwork_130643v4

[PATCH v2] Fix divide-by-zero regression on DP MST unplug with nouveau

Fix a regression when using nouveau and unplugging a StarTech MSTDP122DP DisplaypPort 1.2 MST hub (the same regression does not appear when using a Cable Matters DisplayPort 1.4 MST hub). Trace: divide error: [#1] PREEMPT SMP PTI CPU: 7 PID: 2962 Comm: Xorg Not tainted 6.8.0-rc3+ #744

Re: [PATCH 6/8] drm/i915/xe2lpd: Support MDCLK:CDCLK ratio changes

Quoting Lisovskiy, Stanislav (2024-03-11 18:01:04-03:00) >On Mon, Mar 04, 2024 at 03:30:25PM -0300, Gustavo Sousa wrote: >> Commit 394b4b7df9f7 ("drm/i915/lnl: Add CDCLK table") and commit >> 3d3696c0fed1 ("drm/i915/lnl: Start using CDCLK through PLL") started >> adding support for CDCLK

Re: [PATCH 6/8] drm/i915/xe2lpd: Support MDCLK:CDCLK ratio changes

On Mon, Mar 04, 2024 at 03:30:25PM -0300, Gustavo Sousa wrote: > Commit 394b4b7df9f7 ("drm/i915/lnl: Add CDCLK table") and commit > 3d3696c0fed1 ("drm/i915/lnl: Start using CDCLK through PLL") started > adding support for CDCLK programming support for Xe2LPD. One final piece > is missing, which is

[PATCH] drm/i915/gem: Execbuffer objects must have struct pages.

We cannot write requests to objects without struct pages, so escape early if the requests are bound to objects that lack them. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v2] drm/i915/hwmon: Fix locking inversion in sysfs getter

In i915 hwmon sysfs getter path we now take a hwmon_lock, then acquire an rpm wakeref. That results in lock inversion: <4> [197.079335] == <4> [197.085473] WARNING: possible circular locking dependency detected <4> [197.091611]

[PATCH] drm/xe: Introduce intel_runtime_pm_get_noresume at compat-i915-headers for display

The i915-display will start using the intel_runtime_pm_noresume. So we need to add the compat header before it. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 8 1 file changed, 8 insertions(+) diff --git

[PATCH] drm/xe: Introduce xe_pm_runtime_get_noresume for inner callers

Let's ensure that we have an option for inner callers that will raise WARN if device is not active and not protected by outer callers. Make this also a void function forcing every caller to unconditionally put the reference back afterwards. This will be very important for cases where we want to

Re: [PATCH 0/5] drm/i915: cleanup dead code

On Mon, Mar 11, 2024 at 05:43:00PM +, Tvrtko Ursulin wrote: On 06/03/2024 19:36, Lucas De Marchi wrote: Remove platforms that never had their PCI IDs added to the driver and are of course marked with requiring force_probe. Note that most of the code for those platforms is actually used by

[PATCH 11/11] drm/xe: Kill xe_device_mem_access_{get*,put}

Let's simply convert all the current callers towards direct xe_pm_runtime access and remove this extra layer of indirection. v2: Convert all the current callers instead of a big refactor at once. Signed-off-by: Rodrigo Vivi Reviewed-by: Matthew Auld --- drivers/gpu/drm/xe/display/xe_fb_pin.c

[PATCH 10/11] drm/xe: Ensure all the inner access are using the _noresume variant

At this point mem_access references should be only used as inner points of the execution and a get with synchronous resume previously called at an outer point. So, before killing mem_acces in favor of direct accsess, let's ensure that we first convert them towards the new _noresume variant that

[PATCH 09/11] drm/xe: Convert mem_access_if_ongoing to direct xe_pm_runtime_get_if_active

Now that assert_mem_access is relying directly on the pm_runtime state instead of the counters, there's no reason why we cannot use the pm_runtime functions directly. Signed-off-by: Rodrigo Vivi Reviewed-by: Matthew Auld --- drivers/gpu/drm/xe/xe_device.c | 17 -

[PATCH 07/11] drm/xe: Convert xe_gem_fault to use direct xe_pm_runtime calls

The gem page fault is one of the outer bound protections where we want to ensure that the hardware is in D0 before proceeding with memory access. Let's convert it towards the xe_pm_runtime functions directly so we can then convert the mem_access to be inner protection only and then Kill it for

[PATCH 08/11] drm/xe: Removing extra mem_access protection from runtime pm

This is not needed any longer, now that we have all the protection in place with the runtime pm itself. Signed-off-by: Rodrigo Vivi Reviewed-by: Matthew Auld --- drivers/gpu/drm/xe/xe_device.c | 8 drivers/gpu/drm/xe/xe_device.h | 1 - drivers/gpu/drm/xe/xe_pm.c | 3 --- 3 files

[PATCH 06/11] drm/xe: Remove useless mem_access during probe

xe_pm_init is the very last thing during the xe_pci_probe(), hence these protections are useless from the point of view of ensuring that the device is awake. Let's remove it so we continue towards the goal of killing xe_device_mem_access. v2: Adding more cases v3: Provide a separate fix for

[PATCH 05/11] drm/xe: Convert GSC HDCP from mem_access to direct xe_pm_runtime calls

We need to convert so we can continue to kill the mem_access. At this point we should be protected by the display wakerefs already, so let's use the noresume variant. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/display/xe_hdcp_gsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 04/11] drm/xe: Move lockdep protection from mem_access to xe_pm_runtime

The mem_access itself is not holding any lock, but attempting to train lockdep with possible scarring locks happening during runtime pm. We are going soon to kill the mem_access get and put helpers in favor of direct xe_pm_runtime calls, so let's just move this lock around to where it now belongs.

[PATCH 01/11] drm/xe: Introduce xe_pm_runtime_get_noresume for inner callers

Let's ensure that we have an option for inner callers that will raise WARN if device is not active and not protected by outer callers. Make this also a void function forcing every caller to unconditionally put the reference back afterwards. This will be very important for cases where we want to

[PATCH 03/11] drm/i915/display: convert inner wakeref get towards get_if_in_use

This patch brings no functional change. Since at this point of the code we are already asserting a wakeref was held, it means that we are with runtime_pm 'in_use' and in practical terms we are only bumping the pm_runtime usage counter and moving on. However, xe driver has a lockdep annotation

[PATCH 02/11] drm/xe: Introduce intel_runtime_pm_get_noresume at compat-i915-headers for display

The i915-display will start using the intel_runtime_pm_noresume. So we need to add the compat header before it. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [PATCH] drm/i915/hwmon: Fix locking inversion in sysfs getter

On Mon, Mar 11, 2024 at 07:14:09PM +0100, Janusz Krzysztofik wrote: > On Monday, 11 March 2024 18:35:43 CET Guenter Roeck wrote: > > On 3/11/24 09:58, Rodrigo Vivi wrote: > > > On Mon, Mar 11, 2024 at 09:06:46AM +0100, Janusz Krzysztofik wrote: > > >> In i915 hwmon sysfs getter path we now take a

Re: [PATCH 01/10] drm/i915/display: convert inner wakeref get towards get_if_in_use

On Mon, Mar 11, 2024 at 05:06:32PM +0200, Imre Deak wrote: > On Fri, Mar 08, 2024 at 10:19:58AM -0500, Rodrigo Vivi wrote: > > [...] > > > > > > The difference between a wakeref (aka wakelock) and a raw-wakeref is > > > that the former is required for accessing the HW, which is asserted when > >

Re: [PATCH] drm/i915/hwmon: Fix locking inversion in sysfs getter

On Monday, 11 March 2024 18:35:43 CET Guenter Roeck wrote: > On 3/11/24 09:58, Rodrigo Vivi wrote: > > On Mon, Mar 11, 2024 at 09:06:46AM +0100, Janusz Krzysztofik wrote: > >> In i915 hwmon sysfs getter path we now take a hwmon_lock, then acquire an > >> rpm wakeref. That results in lock

RE: [PATCH v2] drm/i915: Reuse RPLU cdclk fns for MTL+

Merged the patch. Thanks for the reviews. Regards, Radhakrishna Sripada > -Original Message- > From: Sripada, Radhakrishna > Sent: Wednesday, February 28, 2024 1:49 PM > To: intel-gfx@lists.freedesktop.org > Cc: Sripada, Radhakrishna ; Sousa, Gustavo > ; Nikula, Jani > Subject: [PATCH

Re: [PATCH 0/5] drm/i915: cleanup dead code

On 06/03/2024 19:36, Lucas De Marchi wrote: Remove platforms that never had their PCI IDs added to the driver and are of course marked with requiring force_probe. Note that most of the code for those platforms is actually used by subsequent ones, so it's not a huge amount of code being

Re: [PATCH] drm/i915/hwmon: Fix locking inversion in sysfs getter

On 3/11/24 09:58, Rodrigo Vivi wrote: On Mon, Mar 11, 2024 at 09:06:46AM +0100, Janusz Krzysztofik wrote: In i915 hwmon sysfs getter path we now take a hwmon_lock, then acquire an rpm wakeref. That results in lock inversion: <4> [197.079335]

Re: [PATCH] drm/i915/hwmon: Fix locking inversion in sysfs getter

On Mon, Mar 11, 2024 at 09:06:46AM +0100, Janusz Krzysztofik wrote: > In i915 hwmon sysfs getter path we now take a hwmon_lock, then acquire an > rpm wakeref. That results in lock inversion: > > <4> [197.079335] == > <4> [197.085473] WARNING:

Re: [PATCH 4/5] drm/i915: Drop dead code for pvc

On Mon, Mar 11, 2024 at 10:35:20AM -0500, Lucas De Marchi wrote: > On Mon, Mar 11, 2024 at 11:29:31AM -0400, Rodrigo Vivi wrote: > > > @@ -2907,9 +2829,7 @@ engine_init_workarounds(struct intel_engine_cs > > > *engine, struct i915_wa_list *wal > > > if (engine->flags &

Re: [PATCH 3/5] drm/i915: Update IP_VER(12, 50)

On Mon, Mar 11, 2024 at 10:29:45AM -0500, Lucas De Marchi wrote: > On Mon, Mar 11, 2024 at 11:18:03AM -0400, Rodrigo Vivi wrote: > > On Wed, Mar 06, 2024 at 11:36:41AM -0800, Lucas De Marchi wrote: > > > With no platform declaring graphics/media IP_VER(12, 50), > > > > this is not true. > > We

Re: [PATCH] Fix divide-by-zero on DP unplug with nouveau

On Mon, Mar 11, 2024 at 06:09:29PM +0200, Imre Deak wrote: > On Sat, Feb 10, 2024 at 09:24:59PM +, Chris Bainbridge wrote: > > Sorry for the delay. > > > The following trace occurs when using nouveau and unplugging a DP MST > > adaptor: > > > > divide error: [#1] PREEMPT SMP PTI > >

Re: [PATCH] Fix divide-by-zero on DP unplug with nouveau

On 11.03.24 17:09, Imre Deak wrote: > On Sat, Feb 10, 2024 at 09:24:59PM +, Chris Bainbridge wrote: > Sorry for the delay. Happens, thx for looking onto this! >> The following trace occurs when using nouveau and unplugging a DP MST >> adaptor: > [...] >> +if (bpp_x16 == 0) >> +

Re: [PATCH] Fix divide-by-zero on DP unplug with nouveau

On Sat, Feb 10, 2024 at 09:24:59PM +, Chris Bainbridge wrote: Sorry for the delay. > The following trace occurs when using nouveau and unplugging a DP MST > adaptor: > > divide error: [#1] PREEMPT SMP PTI > CPU: 7 PID: 2962 Comm: Xorg Not tainted 6.8.0-rc3+ #744 > Hardware name:

RE: [REGRESSION] Divide-by-zero on DisplayPort MST unplug with nouveau

> -Original Message- > From: Jani Nikula > Sent: Monday, 11 March 2024 18.03 > To: Saarinen, Jani ; Linux regressions mailing list > ; Deak, Imre > Cc: Chris Bainbridge ; intel-gfx g...@lists.freedesktop.org>; David Airlie ; Daniel Vetter > ; ML dri-devel > Subject: RE: [REGRESSION]

RE: [REGRESSION] Divide-by-zero on DisplayPort MST unplug with nouveau

On Mon, 11 Mar 2024, "Saarinen, Jani" wrote: > Hi, > >> -Original Message- >> From: Intel-gfx On Behalf Of Linux >> regression tracking (Thorsten Leemhuis) >> Sent: Monday, 11 March 2024 17.53 >> To: Deak, Imre >> Cc: regressi...@lists.linux.dev; Chris Bainbridge >> ; intel-gfx ; >>

RE: [REGRESSION] Divide-by-zero on DisplayPort MST unplug with nouveau

Hi, > -Original Message- > From: Intel-gfx On Behalf Of Linux > regression tracking (Thorsten Leemhuis) > Sent: Monday, 11 March 2024 17.53 > To: Deak, Imre > Cc: regressi...@lists.linux.dev; Chris Bainbridge > ; intel-gfx ; > David Airlie ; Daniel Vetter ; ML dri-devel > > Subject:

Re: [REGRESSION] Divide-by-zero on DisplayPort MST unplug with nouveau

On 07.03.24 18:58, Chris Bainbridge wrote: > - Forwarded message from Chris Bainbridge > - > > Date: Sat, 10 Feb 2024 21:24:59 + Hmm, it looks like nobody is looking into this regression. Is there a good reason? Imre, or did you maybe just miss that Chris' regression seems to be

Re: ✗ Fi.CI.IGT: failure for drm/i915: Drop WA 16015675438 (rev2)

On Thu, Mar 07, 2024 at 05:24:38PM -, Patchwork wrote: == Series Details == Series: drm/i915: Drop WA 16015675438 (rev2) URL : https://patchwork.freedesktop.org/series/130815/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14400_full -> Patchwork_130815v2_full

Re: [PATCH 4/5] drm/i915: Drop dead code for pvc

On Mon, Mar 11, 2024 at 11:29:31AM -0400, Rodrigo Vivi wrote: @@ -2907,9 +2829,7 @@ engine_init_workarounds(struct intel_engine_cs *engine, struct i915_wa_list *wal if (engine->flags & I915_ENGINE_FIRST_RENDER_COMPUTE) general_render_compute_wa_init(engine, wal); -

Re: [PATCH] drm/i915: Drop WA 16015675438

On Mon, Mar 11, 2024 at 10:54:57AM -0400, Rodrigo Vivi wrote: On Wed, Mar 06, 2024 at 06:43:39AM -0800, Lucas De Marchi wrote: With dynamic load-balancing disabled on the compute side, there's no reason left to enable WA 16015675438. Drop it from both PVC and DG2. Note that this can be done

Re: [PATCH 3/5] drm/i915: Update IP_VER(12, 50)

On Mon, Mar 11, 2024 at 11:18:03AM -0400, Rodrigo Vivi wrote: On Wed, Mar 06, 2024 at 11:36:41AM -0800, Lucas De Marchi wrote: With no platform declaring graphics/media IP_VER(12, 50), this is not true. We still have #define XE_HPM_FEATURES \ .__runtime.media.ip.ver = 12, \

Re: [PATCH 4/5] drm/i915: Drop dead code for pvc

On Wed, Mar 06, 2024 at 11:36:42AM -0800, Lucas De Marchi wrote: > PCI IDs for PVC were never added and platform always marked with > force_probe. Drop what's not used and rename some places as needed. > > The registers not used anymore are also removed. > > Signed-off-by: Lucas De Marchi > ---

Re: [PATCH 3/5] drm/i915: Update IP_VER(12, 50)

On Wed, Mar 06, 2024 at 11:36:41AM -0800, Lucas De Marchi wrote: > With no platform declaring graphics/media IP_VER(12, 50), this is not true. We still have #define XE_HPM_FEATURES \ .__runtime.media.ip.ver = 12, \ .__runtime.media.ip.rel = 50 replace the > checks throughout

Re: [PATCH 2/5] drm/i915: Drop dead code for xehpsdv

On Wed, Mar 06, 2024 at 11:36:40AM -0800, Lucas De Marchi wrote: > PCI IDs for XEHPSDV were never added and platform always marked with > force_probe. Drop what's not used and rename some places to either be > xehp or dg2, depending on the platform/IP checks. > > The registers not used anymore

Re: [PATCH 01/10] drm/i915/display: convert inner wakeref get towards get_if_in_use

On Fri, Mar 08, 2024 at 10:19:58AM -0500, Rodrigo Vivi wrote: > [...] > > > > The difference between a wakeref (aka wakelock) and a raw-wakeref is > > that the former is required for accessing the HW, which is asserted when > > reading/writing a register. A raw-wakeref is not enough for this and

[PATCH] drm/i915/dp: Fix DSC state HW readout for SST connectors

Commit a62e14598150 ("drm/i915/dp: Fix connector DSC HW state readout") moved the DSC HW state readout to a connector specific hook, however only added the hook for DP MST connectors, not for DP SST ones. Fix adding the hook for SST connectors as well. This fixes the following warn on platforms

Re: [PATCH] drm/i915: Drop WA 16015675438

On Wed, Mar 06, 2024 at 06:43:39AM -0800, Lucas De Marchi wrote: > With dynamic load-balancing disabled on the compute side, there's no > reason left to enable WA 16015675438. Drop it from both PVC and DG2. > Note that this can be done because now the driver always set a fixed > partition of EUs

Re: [PATCH] drm/ci: update device type for volteer devices

Reviewed-by: David Heidelberg If possible, please merge this ASAP, because major move of most of the devices to type acer-cp514-2h-1130g7-volteer will happen tomorrow. Thank you On 05/03/2024 11:16, Vignesh Raman wrote: Volteer devices in the collabora lab are categorized under the

Re: [PATCH v4 0/4] TTM unlockable restartable LRU list iteration

On Fri, 2024-03-08 at 13:13 +0530, Somalapuram, Amaranath wrote: > Patches are tested on AMD platform. > Repeated stress test on Unigine Heaven, memory full (VRAM + GTT + > system > SWAP), then free. > No errors/warning in kernel log. > Any suggestion specific tests? We are testing locally

Re: [PATCH v4 2/4] drm/ttm: Use LRU hitches

Hi! Thanks for reviewing. On Fri, 2024-03-08 at 18:50 +0530, Somalapuram, Amaranath wrote: > > On 3/6/2024 12:31 PM, Thomas Hellström wrote: > > Have iterators insert themselves into the list they are iterating > > over using hitch list nodes. Since only the iterator owner > > can remove these

Re: [PATCH v2 00/16] drm: fix headers, add header test facility

On Fri, 08 Mar 2024, Jani Nikula wrote: > Follow-up to [1], with the already merged patches dropped, review > comments addressed, some new patches added, etc. > > I did still leave in the FIXME comments in "drm/i2c: silence ch7006.h > and sil164.h kernel-doc warnings", and just silenced the >

Re: [PATCH v2 16/16] drm: ensure drm headers are self-contained and pass kernel-doc

On Fri, 08 Mar 2024, Jani Nikula wrote: > Ensure drm headers build, are self-contained, have header guards, and > have no kernel-doc warnings, when CONFIG_DRM_HEADER_TEST=y. > > The mechanism follows similar patters used in i915, xe, and usr/include. > > To cover include/drm, we need to recurse

Re: [PATCH v5] drm/i915/dp: Increase idle pattern wait timeout to 2ms

Quoting Shekhar Chauhan (2024-03-11 01:15:04-03:00) >The driver currently waits 1ms for idle patterns, >but for Xe2LPD and possibly future display IPs, >it requires a 1640us (rounded up to 2ms) timeout >whilst waiting for idle patterns for MST streams. > >To simplify the code, the timeout is

Re: [PATCH v3 0/6] VBT read cleanup

On Wed, 28 Feb 2024, Radhakrishna Sripada wrote: > This series is originally based out of [1], and built on top of [2]. > > The primary departure from [1] was that vbt is no longer cached. During vbt > show, based on the source of vbt, it would simply be re-read reducing the > read/cleanup

[PATCH v17 8/9] drm/i915/display: Compute vrr_vsync params

Compute vrr_vsync_start/end, which sets the position for hardware to send the Vsync at a fixed position relative to the end of the Vblank. --v2: - Updated VSYNC_START/END macros to VRR_VSYNC_START/END. (Ankit) - Updated bit fields of VRR_VSYNC_START/END. (Ankit) --v3: - Add

[PATCH v17 9/9] drm/i915/display: Read/Write Adaptive Sync SDP

Add read/write calls for Adaptive Sync SDP. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c

[PATCH v17 7/9] drm/i915/display: Add state checker for Adaptive Sync SDP

Enable infoframe and add state checker for Adaptive Sync SDP enablement. --v1: - crtc_state->infoframes.enable, to add on correct place holder. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display.c | 46 1 file changed,

[PATCH v17 5/9] drm/i915/dp: Add wrapper function to check AS SDP

Add a wrapper function to check if both the source and sink support Adaptive Sync SDP. --v1: Just use drm/i915/dp in subject line. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 8 drivers/gpu/drm/i915/display/intel_dp.h | 1 + 2

[PATCH v17 6/9] drm/i915/display: Compute AS SDP parameters

Add necessary function definitions to compute AS SDP data. The new intel_dp_compute_as_sdp function computes AS SDP values based on the display configuration, ensuring proper handling of Variable Refresh Rate (VRR). --v2: - Added DP_SDP_ADAPTIVE_SYNC to infoframe_type_to_idx(). [Ankit] -

[PATCH v17 4/9] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

Add the necessary structures and functions to handle reading and unpacking Adaptive Sync Secondary Data Packets. Also add support to write and pack AS SDP. --v2: - Correct use of REG_BIT and REG_GENMASK. [Jani] - Use as_sdp instead of async. [Jani] - Remove unrelated comments and changes. [Jani]

[PATCH v17 2/9] drm: Add Adaptive Sync SDP logging

Add structure representing Adaptive Sync Secondary Data Packet (AS SDP). Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate debugging. --v2: - Update logging. [Jani, Ankit] - Use 'as_sdp' instead of 'async' [Ankit] - Correct define placeholders to where they are actually used.

[PATCH v17 3/9] drm/i915/display: Add crtc state dump for Adaptive Sync SDP

Add crtc state dump for Adaptive Sync SDP to know which crtc specifically caused the failure. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- .../gpu/drm/i915/display/intel_crtc_state_dump.c| 13 + drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 2 files

[PATCH v17 1/9] drm/dp: Add support to indicate if sink supports AS SDP

Add an API that indicates support for Adaptive Sync SDP in the sink, which can be utilized by the rest of the DP programming. --v1: - Format commit message properly. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/display/drm_dp_helper.c | 25

[PATCH v17 0/9] Enable Adaptive Sync SDP Support for DP

An Adaptive-Sync-capable DP protocol converter indicates its support by setting the related bit in the DPCD register. This is valid for DP and edp as well. Computes AS SDP values based on the display configuration, ensuring proper handling of Variable Refresh Rate (VRR) in the context of

Re: [PATCH 2/2] drm/i915: Implement vblank synchronized MBUS join changes

On Fri, Mar 08, 2024 at 05:11:42PM +0200, Ville Syrjälä wrote: > On Fri, Mar 08, 2024 at 03:43:35PM +0200, Lisovskiy, Stanislav wrote: > > On Fri, Mar 08, 2024 at 12:07:19PM +0200, Ville Syrjälä wrote: > > > On Wed, Feb 28, 2024 at 10:02:13AM +0200, Stanislav Lisovskiy wrote: > > > > Currently we

Re: Reminder: 2024 X.Org Board of Directors Elections timeline extended, request for nominations

This is a reminder that we are still looking for candidates for the upcoming X.Org Board of Directors elections, and that today is the last day to submit personal statements for nomination. X.org membership renewals are still open and will be needed to vote on those elections. Please read

Re: [PATCH 7/8] drm/bridge: lt9611uxc: use int for holding number of modes

On Fri, 8 Mar 2024 at 18:04, Jani Nikula wrote: > > lt9611uxc_connector_get_modes() propagates the return value of > drm_edid_connector_add_modes() but stores the int temporarily in an > unsigned int. Use the correct type. > > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Robert Foss >

Re: [PATCH 7/8] drm/bridge: lt9611uxc: use int for holding number of modes

On 08/03/2024 17:03, Jani Nikula wrote: lt9611uxc_connector_get_modes() propagates the return value of drm_edid_connector_add_modes() but stores the int temporarily in an unsigned int. Use the correct type. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Signed-off-by: Jani Nikula ---

Re: [PATCH 2/8] drm/panel: do not return negative error codes from drm_panel_get_modes()

On 08/03/2024 17:03, Jani Nikula wrote: None of the callers of drm_panel_get_modes() expect it to return negative error codes. Either they propagate the return value in their struct drm_connector_helper_funcs .get_modes() hook (which is also not supposed to return negative codes), or add it to

[PATCH] drm/i915/hwmon: Fix locking inversion in sysfs getter

In i915 hwmon sysfs getter path we now take a hwmon_lock, then acquire an rpm wakeref. That results in lock inversion: <4> [197.079335] == <4> [197.085473] WARNING: possible circular locking dependency detected <4> [197.091611]