== Series Details ==
Series: QGV/SAGV related fixes (rev10)
URL : https://patchwork.freedesktop.org/series/126962/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14533 -> Patchwork_126962v10
Summary
---
**SUCCESS**
== Series Details ==
Series: drm/i915/guc: Update w/a 14019159160 (rev2)
URL : https://patchwork.freedesktop.org/series/130890/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14537 -> Patchwork_130890v2
Summary
---
== Series Details ==
Series: drm/i915/guc: Update w/a 14019159160 (rev2)
URL : https://patchwork.freedesktop.org/series/130890/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/guc: Update w/a 14019159160 (rev2)
URL : https://patchwork.freedesktop.org/series/130890/
State : warning
== Summary ==
Error: dim checkpatch failed
ff350c317bfe drm/i915/guc: Update w/a 14019159160
-:20: WARNING:LONG_LINE_COMMENT: line length of 108
== Series Details ==
Series: drm/i915/display: Introduce Display Metrics info
URL : https://patchwork.freedesktop.org/series/132108/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14537 -> Patchwork_132108v1
Summary
---
== Series Details ==
Series: drm/i915/display: Introduce Display Metrics info
URL : https://patchwork.freedesktop.org/series/132108/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/display: Introduce Display Metrics info
URL : https://patchwork.freedesktop.org/series/132108/
State : warning
== Summary ==
Error: dim checkpatch failed
1aaf96febc0d drm/i915/display: Introduce Display Metrics info
Traceback (most recent call last):
Introduce a display metrics information through debugfs
for a better view of the vblank and page flips, in special
Async flips behavior.
There is currently an overall expectation that whenever
vblank_mode=0 is used with an graphics application, that
automatically async_flips are happening.
== Series Details ==
Series: drm/i915: use check_add_overflow() and drop local variants
URL : https://patchwork.freedesktop.org/series/132104/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14537 -> Patchwork_132104v1
== Series Details ==
Series: drm/i915: use check_add_overflow() and drop local variants
URL : https://patchwork.freedesktop.org/series/132104/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
On Fri, Apr 05, 2024 at 11:39:33PM +0300, Dmitry Baryshkov wrote:
> On Fri, 5 Apr 2024 at 22:17, Ville Syrjälä
> wrote:
> >
> > On Fri, Apr 05, 2024 at 06:24:01AM +0300, Dmitry Baryshkov wrote:
> > > On Thu, Apr 04, 2024 at 11:33:25PM +0300, Ville Syrjala wrote:
> > > > From: Ville Syrjälä
> > >
On Fri, 5 Apr 2024 at 22:17, Ville Syrjälä
wrote:
>
> On Fri, Apr 05, 2024 at 06:24:01AM +0300, Dmitry Baryshkov wrote:
> > On Thu, Apr 04, 2024 at 11:33:25PM +0300, Ville Syrjala wrote:
> > > From: Ville Syrjälä
> > >
> > > The modes[] array contains pointers to modes on the connectors'
> > >
== Series Details ==
Series: drm/xe/display: Fix double mutex initialization
URL : https://patchwork.freedesktop.org/series/132100/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14537 -> Patchwork_132100v1
Summary
---
On Fri, Apr 05, 2024 at 10:37:37PM +0300, Jani Nikula wrote:
Some cleanups on i915 side, and subsequent cleanups on xe side. I'd like
to merge all of these via drm-intel-next.
For the entire series:
Reviewed-by: Lucas De Marchi
and ack on merging via drm-intel-next.
Lucas De Marchi
BR,
On Fri, 05 Apr 2024, Lucas De Marchi wrote:
> All of these mutexes are already initialized by the display side since
> commit 3fef3e6ff86a ("drm/i915: move display mutex inits to display
> code"), so the xe shouldn´t initialize them.
>
> Fixes: 44e694958b95 ("drm/xe/display: Implement display
On Fri, Apr 05, 2024 at 10:37:39PM +0300, Jani Nikula wrote:
Avoid the dependency on intel_uc_fw.h, and allow removal of xe compat
intel_uc_fw.h. If there needs to be duplication of the URL, at least
have the duplication in a sensible way.
Cc: Lucas De Marchi
Signed-off-by: Jani Nikula
Prefer common check_add_overflow() from overflow.h over the locally
rolled versions of it. While check_add_overflow() does require a
variable to assign to, unlike add_overflows_t(), it's still better than
having multiple versions around.
Cc: Kees Cook
Signed-off-by: Jani Nikula
---
On Fri, Apr 05, 2024 at 11:23:01AM +0300, Jani Nikula wrote:
> On Thu, 04 Apr 2024, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Switch to the canonical [CONNECTOR:%d:%s] etc. format for
> > printing out kms objects.
>
> I've been pinging for reviews on [1] for a while now. :/
>
> I'm
== Series Details ==
Series: drm/i915 and drm/xe display integration cleanups
URL : https://patchwork.freedesktop.org/series/132097/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14537 -> Patchwork_132097v1
Summary
---
All of these mutexes are already initialized by the display side since
commit 3fef3e6ff86a ("drm/i915: move display mutex inits to display
code"), so the xe shouldn´t initialize them.
Fixes: 44e694958b95 ("drm/xe/display: Implement display support")
Cc: Jani Nikula
Cc: Arun R Murthy
== Series Details ==
Series: drm/i915 and drm/xe display integration cleanups
URL : https://patchwork.freedesktop.org/series/132097/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
== Series Details ==
Series: drm/i915 and drm/xe display integration cleanups
URL : https://patchwork.freedesktop.org/series/132097/
State : warning
== Summary ==
Error: dim checkpatch failed
b8ca0bbab20e drm/i915: use IS_JASPERLAKE()/IS_ELKHARTLAKE() instead of
IS_PLATFORM()
0706baf1630e
On Fri, Apr 05, 2024 at 09:57:07AM +0200, Thomas Zimmermann wrote:
> Hi
>
> Am 04.04.24 um 22:33 schrieb Ville Syrjala:
> > From: Ville Syrjälä
> >
> > Get rid of all the redundant debugs and just wait until the end
> > to print which mode (and of which type) we picked.
> >
> > Signed-off-by:
On Fri, Apr 05, 2024 at 01:42:49PM +, Kulkarni, Vandita wrote:
> > -Original Message-
> > From: Intel-gfx On Behalf Of Ville
> > Syrjala
> > Sent: Friday, April 5, 2024 3:04 AM
> > To: intel-gfx@lists.freedesktop.org
> > Subject: [PATCH v2 01/17] drm/i915: Update pipes in reverse
On Fri, Apr 05, 2024 at 06:32:46AM +0300, Dmitry Baryshkov wrote:
> On Thu, Apr 04, 2024 at 11:33:28PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > crtc->mode is legacy junk and shouldn't really be used with
> > atomic drivers.
> >
> > Most (all?) atomic drivers do end up still
There's a bunch of unnecessary stuff not needed by display code. Remove.
Cc: Lucas De Marchi
Signed-off-by: Jani Nikula
---
.../drm/xe/compat-i915-headers/i915_vgpu.h| 26 ---
1 file changed, 26 deletions(-)
diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_vgpu.h
It's only there for GEM_BUG_ON(), but the display code no longer uses
it. Good riddance.
Cc: Lucas De Marchi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 1 -
drivers/gpu/drm/xe/compat-i915-headers/i915_gem.h | 9 -
2 files changed, 10 deletions(-)
There's a bunch of unused cruft. Just throw away.
Cc: Lucas De Marchi
Signed-off-by: Jani Nikula
---
.../gpu/drm/xe/compat-i915-headers/i915_drv.h | 32 ---
1 file changed, 32 deletions(-)
diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
All the users are in display, move the fixed point header under
display. We could also consider making these more general purpose
things, but that takes a bunch more effort. This allows the immediate
cleanup of xe compat i915_fixed.h.
Cc: Lucas De Marchi
Signed-off-by: Jani Nikula
---
Avoid the dependency on intel_uc_fw.h, and allow removal of xe compat
intel_uc_fw.h. If there needs to be duplication of the URL, at least
have the duplication in a sensible way.
Cc: Lucas De Marchi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dmc.c | 4 +++-
Avoid direct IS_PLATFORM() usage when we have the platform helpers.
Cc: Lucas De Marchi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
Some cleanups on i915 side, and subsequent cleanups on xe side. I'd like
to merge all of these via drm-intel-next.
BR,
Jani.
Jani Nikula (6):
drm/i915: use IS_JASPERLAKE()/IS_ELKHARTLAKE() instead of
IS_PLATFORM()
drm/i915/dmc: define firmware URL locally
drm/i915: move i915_fixed.h to
On Fri, Apr 05, 2024 at 06:58:44AM +, Hogander, Jouni wrote:
> On Fri, 2024-04-05 at 00:34 +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Bigjoiner seem to be causing all kinds of grief to the PSR
> > code currently. I don't believe there is any hardware issue
> > but the code
On Fri, Apr 05, 2024 at 06:24:01AM +0300, Dmitry Baryshkov wrote:
> On Thu, Apr 04, 2024 at 11:33:25PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > The modes[] array contains pointers to modes on the connectors'
> > mode lists, which are protected by dev->mode_config.mutex.
> >
== Series Details ==
Series: drm/dp: correct struct member name in documentation
URL : https://patchwork.freedesktop.org/series/132062/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14531 -> Patchwork_132062v1
Summary
On Fri, Apr 05, 2024 at 10:45:42AM +0200, Thomas Zimmermann wrote:
> Hi
>
> Am 07.03.24 um 21:39 schrieb Jani Nikula:
> > Add a printer based function for dumping the modeline, so it's not
> > limited to KMS debug.
> >
> > Note: The printed output intentionally does not have the "Modeline"
> >
On Fri, 2024-04-05 at 09:30 -0700, Easwar Hariharan wrote:
>
> Thanks for the review, and for the appetite to go further! So we are
> on the same page, you would prefer
> renaming to controller/target like the feedback on other drm drivers
> (i915, gma500, radeon)?
FWIW I'm in support of this as
On Thu, Apr 04, 2024 at 08:59:29AM +0530, Suraj Kandpal wrote:
> As of now whenerver HDR is switched on we use the PWM to change the
> backlight as opposed to AUX based backlight changes in terms of nits.
> This patch writes to the appropriate DPCD registers to enable aux
> based backlight using
KUnit can provide KTAP reports from test modules via debugfs files, one
per test suite. Using that source of test results instead of extracting
them from dmesg, where they may be interleaved with other kernel messages,
seems more easy to handle and less error prone. Switch to it.
If KUnit
On Fri, Apr 05, 2024 at 02:07:05PM +0530, Suraj Kandpal wrote:
> Limit minimum brightness to vbt min brightness when using aux
> based brightness control to avoid letting the screen
> from going completely blank.
> Sometimes vbt can have some bogus values hence clamping the value
> for sanity in
> -Original Message-
> From: Sebastian Wick
> Sent: Friday, April 5, 2024 10:55 PM
> To: Kandpal, Suraj
> Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar
> ; Shankar, Uma
> ; Nautiyal, Ankit K ;
> Murthy, Arun R ; Syrjala, Ville
> ; Kumar, Naveen1
> Subject: Re: [4/7]
> -Original Message-
> From: Sebastian Wick
> Sent: Friday, April 5, 2024 11:02 PM
> To: Kandpal, Suraj
> Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar
> ; Shankar, Uma
> ; Nautiyal, Ankit K ;
> Murthy, Arun R ; Syrjala, Ville
> ; Kumar, Naveen1
> Subject: Re: [6/7]
> -Original Message-
> From: Sebastian Wick
> Sent: Friday, April 5, 2024 10:46 PM
> To: Kandpal, Suraj
> Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar
> ; Shankar, Uma
> ; Nautiyal, Ankit K ;
> Murthy, Arun R ; Syrjala, Ville
> ; Kumar, Naveen1
> Subject: Re: [3/7]
On Thu, Apr 04, 2024 at 08:59:30AM +0530, Suraj Kandpal wrote:
> Write panel override luminance values which helps the TCON decide
> if tone mapping needs to be enabled or not.
>
> Signed-off-by: Suraj Kandpal
> ---
> .../drm/i915/display/intel_dp_aux_backlight.c | 25 +++
> 1
On Thu, Apr 04, 2024 at 08:59:28AM +0530, Suraj Kandpal wrote:
> Change comments from Pre-TGL+ to Pre-ICL as mentioned in specs
>
> Signed-off-by: Suraj Kandpal
> ---
> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff
On Thu, Apr 04, 2024 at 08:59:27AM +0530, Suraj Kandpal wrote:
> Change INTEL_EDP_HDR_TCON_SDP_COLORIMETRY enable to
> INTEL_EDP_HDR_TCON_SDP_OVERRIDE_AUX as this bit is tells TCON to
> ignore DPCD colorimetry values and take the one's sent through
> SDP.
I actually like the original name because
On 05.04.2024 16:47, Jani Nikula wrote:
On Mon, 27 Feb 2023, Peter Zijlstra wrote:
On Thu, Feb 23, 2023 at 10:24:19PM +0100, Andrzej Hajda wrote:
On 22.02.2023 18:04, Peter Zijlstra wrote:
On Wed, Jan 18, 2023 at 04:35:22PM +0100, Andrzej Hajda wrote:
Andrzej Hajda (7):
arch: rename
On Mon, Apr 1, 2024 at 2:50 PM Daniele Ceraolo Spurio
wrote:
>
> The following changes since commit 93f329774542b9b7d57abb18ea8b6542f2d8feac:
>
> Merge branch 'robot/pr-0-1709214990' into 'main' (2024-02-29 14:10:53 +)
>
> are available in the Git repository at:
>
>
Hi Easwar,
On 3/29/24 18:00, Easwar Hariharan wrote:
I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave"
with more appropriate terms. Inspired by and following on to Wolfram's
series to fix drivers/i2c/[1], fix the terminology for users of
I2C_ALGOBIT bitbanging interface,
Forgot to add my Rb
Reviewed-by: Arun R Murthy
Thanks and Regards,
Arun R Murthy
> -Original Message-
> From: Murthy, Arun R
> Sent: Friday, April 5, 2024 6:30 PM
> To: Hogander, Jouni ; ville.syrj...@linux.intel.com;
> intel-gfx@lists.freedesktop.org
> Subject:
On Fri, Apr 5, 2024 at 8:37 AM kernel test robot wrote:
>
> tree/branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> branch HEAD: 8568bb2ccc278f344e6ac44af6ed010a90aa88dc Add linux-next
> specific files for 20240405
>
> Error/Warni
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: 8568bb2ccc278f344e6ac44af6ed010a90aa88dc Add linux-next specific
files for 20240405
Error/Warning reports:
https://lore.kernel.org/oe-kbuild-all/202404051333.7und7ppw-...@intel.com
https
== Series Details ==
Series: drm/i915: PREEMPT_RT related fixups. (rev5)
URL : https://patchwork.freedesktop.org/series/95463/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14534 -> Patchwork_95463v5
Summary
---
== Series Details ==
Series: drm/i915: PREEMPT_RT related fixups. (rev5)
URL : https://patchwork.freedesktop.org/series/95463/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: PREEMPT_RT related fixups. (rev5)
URL : https://patchwork.freedesktop.org/series/95463/
State : warning
== Summary ==
Error: dim checkpatch failed
12b51e744085 drm/i915: Use preempt_disable/enable_rt() where recommended
-:7: WARNING:COMMIT_LOG_LONG_LINE:
== Series Details ==
Series: series starting with [v2] drm: Add drm_vblank_work_flush_all(). (rev2)
URL : https://patchwork.freedesktop.org/series/132028/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14534 -> Patchwork_132028v2
On Mon, 27 Feb 2023, Peter Zijlstra wrote:
> On Thu, Feb 23, 2023 at 10:24:19PM +0100, Andrzej Hajda wrote:
>> On 22.02.2023 18:04, Peter Zijlstra wrote:
>> > On Wed, Jan 18, 2023 at 04:35:22PM +0100, Andrzej Hajda wrote:
>> >
>> > > Andrzej Hajda (7):
>> > >arch: rename all internal names
== Series Details ==
Series: series starting with [v2] drm: Add drm_vblank_work_flush_all(). (rev2)
URL : https://patchwork.freedesktop.org/series/132028/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: series starting with [v2] drm: Add drm_vblank_work_flush_all(). (rev2)
URL : https://patchwork.freedesktop.org/series/132028/
State : warning
== Summary ==
Error: dim checkpatch failed
484c7f370590 drm: Add drm_vblank_work_flush_all().
-:33:
Once the known issues are addressed, it should be safe to enable the
driver.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/gpu/drm/i915/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
index
Disabling interrupts and invoking the irq_work function directly breaks
on PREEMPT_RT.
PREEMPT_RT does not invoke all irq_work from hardirq context because
some of the user have spinlock_t locking in the callback function.
These locks are then turned into a sleeping locks which can not be
acquired
From: Mike Galbraith
Commit
8d7849db3eab7 ("drm/i915: Make sprite updates atomic")
started disabling interrupts across atomic updates. This breaks on PREEMPT_RT
because within this section the code attempt to acquire spinlock_t locks which
are sleeping locks on PREEMPT_RT.
According to the
execlists_dequeue() is invoked from a function which uses
local_irq_disable() to disable interrupts so the spin_lock() behaves
like spin_lock_irq().
This breaks PREEMPT_RT because local_irq_disable() + spin_lock() is not
the same as spin_lock_irq().
execlists_dequeue_irq() and execlists_dequeue()
The !irqs_disabled() check triggers on PREEMPT_RT even with
i915_sched_engine::lock acquired. The reason is the lock is transformed
into a sleeping lock on PREEMPT_RT and does not disable interrupts.
There is no need to check for disabled interrupts. The lockdep
annotation below already check if
From: Mike Galbraith
Mario Kleiner suggest in commit
ad3543ede630f ("drm/intel: Push get_scanout_position() timestamping into kms
driver.")
a spots where preemption should be disabled on PREEMPT_RT. The
difference is that on PREEMPT_RT the intel_uncore::lock disables neither
preemption nor
Luca Abeni reported this:
| BUG: scheduling while atomic: kworker/u8:2/15203/0x0003
| CPU: 1 PID: 15203 Comm: kworker/u8:2 Not tainted 4.19.1-rt3 #10
| Call Trace:
| rt_spin_lock+0x3f/0x50
| gen6_read32+0x45/0x1d0 [i915]
| g4x_get_vblank_counter+0x36/0x40 [i915]
|
The order of the header files is important. If this header file is
included after tracepoint.h was included then the NOTRACE here becomes a
nop. Currently this happens for two .c files which use the tracepoitns
behind DRM_I915_LOW_LEVEL_TRACEPOINTS.
Cc: Steven Rostedt
Signed-off-by: Sebastian
Hi,
The following patches are from the PREEMPT_RT queue. It is mostly about
disabling interrupts/preemption which leads to problems. Unfortunately
DRM_I915_LOW_LEVEL_TRACEPOINTS had to be disabled because it acquires locks
from within trace points. Making the lock a raw_spinlock_t led to higher
intel_guc_send_busy_loop() looks at in_atomic() and irqs_disabled() to
decide if it should busy-spin while waiting or if it may sleep.
Both checks will report false on PREEMPT_RT if sleeping spinlocks are
acquired leading to RCU splats while the function sleeps.
Check also if RCU has been
The !in_atomic() check in _wait_for_atomic() triggers on PREEMPT_RT
because the uncore::lock is a spinlock_t and does not disable
preemption or interrupts.
Changing the uncore:lock to a raw_spinlock_t doubles the worst case
latency on an otherwise idle testbox during testing. Therefore I'm
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Friday, April 5, 2024 3:04 AM
> To: intel-gfx@lists.freedesktop.org
> Subject: [PATCH v2 01/17] drm/i915: Update pipes in reverse order for
> bigjoiner
>
> From: Ville Syrjälä
>
> With bigjoiner the master crtc
what does "rebase" instead of "PATCH" is supposed to mean here?
And then we have a "PATCH v2" as reply to this one.
Shouldn't this go to dri-devel (too)?
Lucas De Marchi
On Thu, Apr 04, 2024 at 12:48:11PM +0200, Maarten Lankhorst wrote:
From: Maarten Lankhorst
In some cases we want to flush
== Series Details ==
Series: Panel Replay fixes and clean ups
URL : https://patchwork.freedesktop.org/series/132073/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14533 -> Patchwork_132073v1
Summary
---
**SUCCESS**
From: Maarten Lankhorst
In some cases we want to flush all vblank work, right before vblank_off
for example. Add a simple function to make this possible.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/drm_vblank_work.c | 22 ++
include/drm/drm_vblank_work.h | 2
> -Original Message-
> From: Intel-gfx On Behalf Of
> Hogander, Jouni
> Sent: Friday, April 5, 2024 12:29 PM
> To: ville.syrj...@linux.intel.com; intel-gfx@lists.freedesktop.org
> Subject: Re: [PATCH v2 02/17] drm/i915/psr: Disable PSR when bigjoiner is used
>
> On Fri, 2024-04-05 at
> -Original Message-
> From: Intel-gfx On Behalf Of
> Hogander, Jouni
> Sent: Friday, April 5, 2024 12:29 PM
> To: ville.syrj...@linux.intel.com; intel-gfx@lists.freedesktop.org
> Subject: Re: [PATCH v2 02/17] drm/i915/psr: Disable PSR when bigjoiner is used
>
> On Fri, 2024-04-05 at
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Friday, April 5, 2024 3:04 AM
> To: intel-gfx@lists.freedesktop.org
> Subject: [PATCH v2 01/17] drm/i915: Update pipes in reverse order for
> bigjoiner
>
> From: Ville Syrjälä
>
> With bigjoiner the master
== Series Details ==
Series: Panel Replay fixes and clean ups
URL : https://patchwork.freedesktop.org/series/132073/
State : warning
== Summary ==
Error: dim checkpatch failed
c17cab9b7282 drm/i915/psr: Add some documentation of variables used in psr code
01e4b2f7edc9 drm/i915/psr: Set
== Series Details ==
Series: QGV/SAGV related fixes (rev10)
URL : https://patchwork.freedesktop.org/series/126962/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14533 -> Patchwork_126962v10
Summary
---
**FAILURE**
Hi Dave, Sima,
Everyone seems to be out on vacation, so the pull request is pretty empty.
Cheers,
~Maarten
drm-misc-next-2024-04-05:
drm-misc-next for v6.10:
Core Changes:
- Fix DRM_DISPLAY_DP_HELPER dependencies.
Driver Changes:
- i2c and polling fixes to ast.
- Small fixes to panthor.
-
== Series Details ==
Series: QGV/SAGV related fixes (rev10)
URL : https://patchwork.freedesktop.org/series/126962/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/include/asm/bitops.h:116:1:
On HPD interrupt we want to check if the reason for HPD was some panel
replay error detected by monitor/panel. This is already done for PSR. We
want to do this for panel replay as well. Modify intel_psr_short_pulse to
support panel replay as well.
Signed-off-by: Jouni Högander
Reviewed-by:
Unify enabling and disabling of psr/panel replay for a sink. Modify
intel_psr_enable_sink accordingly and use it for both cases.
v3:
- move psr2_su_region_et_valid to be check for PSR2 only
v2:
- enable panel replay for sink before link training
- write ALPM_CONFIG only for PSR
- add
Panel replay has to be enabled on sink side before link training. Take this
into account in fastset check and in initial fastset check.
Signed-off-by: Jouni Högander
Reviewed-by: Animesh Manna
---
drivers/gpu/drm/i915/display/intel_display.c | 12
Currently panel replay is supporting only main link on mode -> Do not
update phy power state for non-eDP panel replay.
Bspec: 53370
v2: use intel_dp_is_edp to differentiate
Signed-off-by: Jouni Högander
Reviewed-by: Animesh Manna
---
drivers/gpu/drm/i915/display/intel_psr.c | 12
Bspec is saying this
mask register: Only PSR_MASK[Mask FBC modify] and PSR_MASK[Mask Hotplug]
are used in panel replay mode.
Status register: Only SRD_STATUS[SRD state] field is used in panel replay
mode.
Due to this stop writing and reading registers and bits not used by panel
replay if panel
We are adding more boolean variable into intel_psr and intel_crtc_state
structs. Add some documentation about these for sake of clarity.
v2: Modify has_psr + has_panel_replay to mean panel replay
Signed-off-by: Jouni Högander
Reviewed-by: Animesh Manna
---
Currently intel_psr_pause and intel_psr_resume do nothing in case of panel
replay. Change them to perform pause and return also in case of panel
replay.
Signed-off-by: Jouni Högander
Reviewed-by: Animesh Manna
---
drivers/gpu/drm/i915/display/intel_psr.c | 4 ++--
1 file changed, 2
Current code is setting only intel_crtc_state->has_panel_replay in panel
replay case. There are lots of stuff behind intel_crtc_state->has_psr that
is needed for panel replay as well. Instead of converting each check to
has_psr || has_panel_replay set has_psr in case of panel replay as
well. Code
This patch set is a subset of Panel Replay selective update support set:
https://patchwork.freedesktop.org/series/128193/
It contains fixes and clean ups to current Panel Replay implementation:
Several needed functions are not executed for panel replay
Ensure link training follows enabling
The current intel_bw_atomic_check do not check the possbility
of a sagv configuration change after the hw state readout.
Hence cannot update the sagv configuration until some other
relevant changes like data rates, number of planes etc. happen.
Introduce a flag to force qgv check in such cases.
From: Stanislav Lisovskiy
There could be multiple qgv and psf gv points with similar values.
Apparently pcode's handling og psf and qgv points are different. For
qgv case, pcode sets whatever is asked by the driver. But in case
of psf gv points, it compares the bw from points before setting the
From: Stanislav Lisovskiy
Problem is that on some platforms, we do get QGV point mask in wrong
state on boot. However driver assumes it is set to 0
(i.e all points allowed), however in reality we might get them all
restricted, causing issues.
Lets disable SAGV initially to force proper QGV point
Extract the code to prepare the QGV points mask as per the
format expected by the pcode as this could be utlized from
multiple points.
Signed-off-by: Vinod Govindapillai
---
drivers/gpu/drm/i915/display/intel_bw.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff
From: Stanislav Lisovskiy
For debug purposes we need those - error path won't flood the log,
however there has been already numerous cases, when due to lack
of debugs, we couldn't immediately tell what was the problem on
customer machine, which slowed down the investigation, requiring
to get
From: Stanislav Lisovskiy
We need that in order to force disable SAGV in next patch.
Also it is beneficial to separate that code, as in majority cases,
when SAGV is enabled, we don't even need those calculations.
Also we probably need to determine max PSF GV point as well, however
currently we
We have couple of customer issues, related to SAGV/QGV point
calculation. Those patches contain fixes plus some additional
debugs for those issues.
Stanislav Lisovskiy (4):
drm/i915/display: Add meaningful traces for QGV point info error
handling
drm/i915/display: Extract code required to
> -Original Message-
> From: Hogander, Jouni
> Sent: Wednesday, April 3, 2024 2:30 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Manna, Animesh ; Hogander, Jouni
>
> Subject: [PATCH v5 08/19] drm/i915/psr: Unify panel replay enable/disable
> sink
>
> Unify enabling and disabling of
> -Original Message-
> From: Hogander, Jouni
> Sent: Wednesday, April 3, 2024 2:30 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Manna, Animesh ; Hogander, Jouni
>
> Subject: [PATCH v5 06/19] drm/i915/psr: Do not write registers/bits not
> applicable for panel replay
>
> Bspec is
> -Original Message-
> From: Hogander, Jouni
> Sent: Wednesday, April 3, 2024 2:30 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Manna, Animesh ; Hogander, Jouni
>
> Subject: [PATCH v5 04/19] drm/i915/psr: Do not update phy power state in
> case of non-eDP panel replay
>
> Currently
1 - 100 of 129 matches
Mail list logo
