[PATCH] drm/i915/audio: 'scheduling while atomic' during system resume

2024-04-08 Thread Brent Lu
The i915_audio_component_codec_wake_override() function will be called during resume process so replace usleep_range() function calls with udelay() to avoid the 'scheduling while atomic' error. [22138.069052] BUG: scheduling while atomic: cras/2682/0x [22138.069359] Call Trace:

Re: [PATCH 5/5] drm/vkms: Use drm_crtc_vblank_crtc()

2024-04-08 Thread Maíra Canal
On 4/8/24 16:06, Ville Syrjala wrote: From: Ville Syrjälä Replace the open coded drm_crtc_vblank_crtc() with the real thing. Cc: Rodrigo Siqueira Cc: Melissa Wen Cc: "Maíra Canal" Cc: Haneen Mohammed Cc: Daniel Vetter Signed-off-by: Ville Syrjälä Reviewed-by: Maíra Canal Best

✗ Fi.CI.BAT: failure for drm: debug logging improvements (rev3)

2024-04-08 Thread Patchwork
== Series Details == Series: drm: debug logging improvements (rev3) URL : https://patchwork.freedesktop.org/series/130881/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14545 -> Patchwork_130881v3 Summary ---

✗ Fi.CI.CHECKPATCH: warning for drm: debug logging improvements (rev3)

2024-04-08 Thread Patchwork
== Series Details == Series: drm: debug logging improvements (rev3) URL : https://patchwork.freedesktop.org/series/130881/ State : warning == Summary == Error: dim checkpatch failed 2e4e1a4bd898 drm/probe-helper: switch to drm device based logging 820abea6dcdd drm/modes: switch to drm device

✗ Fi.CI.SPARSE: warning for drm: debug logging improvements (rev3)

2024-04-08 Thread Patchwork
== Series Details == Series: drm: debug logging improvements (rev3) URL : https://patchwork.freedesktop.org/series/130881/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/vblank: Introduce drm_crtc_vblank_crtc()

2024-04-08 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/vblank: Introduce drm_crtc_vblank_crtc() URL : https://patchwork.freedesktop.org/series/132178/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/vblank: Introduce drm_crtc_vblank_crtc()

2024-04-08 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/vblank: Introduce drm_crtc_vblank_crtc() URL : https://patchwork.freedesktop.org/series/132178/ State : warning == Summary == Error: dim checkpatch failed f6612e1c60a0 drm/vblank: Introduce drm_crtc_vblank_crtc() -:10:

✓ Fi.CI.BAT: success for drm/i915: drm_i915_private and xe_device cleanups

2024-04-08 Thread Patchwork
== Series Details == Series: drm/i915: drm_i915_private and xe_device cleanups URL : https://patchwork.freedesktop.org/series/132173/ State : success == Summary == CI Bug Log - changes from CI_DRM_14545 -> Patchwork_132173v1 Summary

✗ Fi.CI.SPARSE: warning for drm/i915: drm_i915_private and xe_device cleanups

2024-04-08 Thread Patchwork
== Series Details == Series: drm/i915: drm_i915_private and xe_device cleanups URL : https://patchwork.freedesktop.org/series/132173/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: drm_i915_private and xe_device cleanups

2024-04-08 Thread Patchwork
== Series Details == Series: drm/i915: drm_i915_private and xe_device cleanups URL : https://patchwork.freedesktop.org/series/132173/ State : warning == Summary == Error: dim checkpatch failed 05cfe53e63a7 drm/i915/gt: drop display clock info from gt debugfs 5d7d095a9116 drm/i915: move

✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: move rawclk init to intel_cdclk_init()

2024-04-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: move rawclk init to intel_cdclk_init() URL : https://patchwork.freedesktop.org/series/132168/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14545 -> Patchwork_132168v1

✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: move rawclk init to intel_cdclk_init()

2024-04-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: move rawclk init to intel_cdclk_init() URL : https://patchwork.freedesktop.org/series/132168/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked

✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/display: remove small micro-optimizations in irq handling

2024-04-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: remove small micro-optimizations in irq handling URL : https://patchwork.freedesktop.org/series/132152/ State : success == Summary == CI Bug Log - changes from CI_DRM_14545 -> Patchwork_132152v1

✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/display: remove small micro-optimizations in irq handling

2024-04-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: remove small micro-optimizations in irq handling URL : https://patchwork.freedesktop.org/series/132152/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be

Re: [PATCH 4/5] drm/nouveau: Use drm_crtc_vblank_crtc()

2024-04-08 Thread Lyude Paul
Reviewed-by: Lyude Paul On Mon, 2024-04-08 at 22:06 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace the open coded drm_crtc_vblank_crtc() with the real > thing. > > Cc: Karol Herbst > Cc: Lyude Paul > Cc: Danilo Krummrich > Cc: nouv...@lists.freedesktop.org > Signed-off-by:

✓ Fi.CI.BAT: success for drm/i915/guc: Update w/a 14019159160 (rev4)

2024-04-08 Thread Patchwork
== Series Details == Series: drm/i915/guc: Update w/a 14019159160 (rev4) URL : https://patchwork.freedesktop.org/series/130890/ State : success == Summary == CI Bug Log - changes from CI_DRM_14545 -> Patchwork_130890v4 Summary ---

Re: [PATCH 0/8] drm/i915: drm_i915_private and xe_device cleanups

2024-04-08 Thread Lucas De Marchi
On Tue, Apr 09, 2024 at 12:02:17AM +0300, Jani Nikula wrote: On Mon, 08 Apr 2024, Jani Nikula wrote: Continue cleaning up the members from drm_i915_private and xe_device to struct intel_display. Lucas, there's a bunch of xe changes included here, ack for merging via drm-intel-next?

Re: [PATCH 6/8] drm/i915: move de_irq_mask to display substruct

2024-04-08 Thread Lucas De Marchi
On Mon, Apr 08, 2024 at 09:08:41PM +0300, Jani Nikula wrote: The info is related to display, and should be placed under i915->display. Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_display_core.h | 2 ++ .../gpu/drm/i915/display/intel_display_irq.c| 17 +

✗ Fi.CI.SPARSE: warning for drm/i915/guc: Update w/a 14019159160 (rev4)

2024-04-08 Thread Patchwork
== Series Details == Series: drm/i915/guc: Update w/a 14019159160 (rev4) URL : https://patchwork.freedesktop.org/series/130890/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Update w/a 14019159160 (rev4)

2024-04-08 Thread Patchwork
== Series Details == Series: drm/i915/guc: Update w/a 14019159160 (rev4) URL : https://patchwork.freedesktop.org/series/130890/ State : warning == Summary == Error: dim checkpatch failed 2949d5eceea7 drm/i915/guc: Update w/a 14019159160 -:20: WARNING:LONG_LINE_COMMENT: line length of 108

Re: [PATCH 0/8] drm/i915: drm_i915_private and xe_device cleanups

2024-04-08 Thread Jani Nikula
On Mon, 08 Apr 2024, Jani Nikula wrote: > Continue cleaning up the members from drm_i915_private and xe_device to > struct intel_display. Lucas, there's a bunch of xe changes included here, ack for merging via drm-intel-next? BR, Jani. > > Jani Nikula (8): > drm/i915/gt: drop display clock

✓ Fi.CI.BAT: success for drm/i915/pps: move pps debugfs file to intel_pps.c

2024-04-08 Thread Patchwork
== Series Details == Series: drm/i915/pps: move pps debugfs file to intel_pps.c URL : https://patchwork.freedesktop.org/series/132148/ State : success == Summary == CI Bug Log - changes from CI_DRM_14543 -> Patchwork_132148v1 Summary

✗ Fi.CI.CHECKPATCH: warning for drm/i915/pps: move pps debugfs file to intel_pps.c

2024-04-08 Thread Patchwork
== Series Details == Series: drm/i915/pps: move pps debugfs file to intel_pps.c URL : https://patchwork.freedesktop.org/series/132148/ State : warning == Summary == Error: dim checkpatch failed fa41b7dd74d8 drm/i915/pps: move pps debugfs file to intel_pps.c -:106: CHECK:BRACES: Blank lines

[PATCH 5/5] drm/vkms: Use drm_crtc_vblank_crtc()

2024-04-08 Thread Ville Syrjala
From: Ville Syrjälä Replace the open coded drm_crtc_vblank_crtc() with the real thing. Cc: Rodrigo Siqueira Cc: Melissa Wen Cc: "Maíra Canal" Cc: Haneen Mohammed Cc: Daniel Vetter Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/vkms/vkms_crtc.c | 7 ++- 1 file changed, 2

[PATCH 4/5] drm/nouveau: Use drm_crtc_vblank_crtc()

2024-04-08 Thread Ville Syrjala
From: Ville Syrjälä Replace the open coded drm_crtc_vblank_crtc() with the real thing. Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.org Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/nouveau/nouveau_display.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 2/5] drm/amdgpu: Use drm_crtc_vblank_crtc()

2024-04-08 Thread Ville Syrjala
From: Ville Syrjälä Replace the open coded drm_crtc_vblank_crtc() with the real thing. Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: amd-...@lists.freedesktop.org Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 8 ++--

[PATCH 3/5] drm/i915: Use drm_crtc_vblank_crtc()

2024-04-08 Thread Ville Syrjala
From: Ville Syrjälä Replace the open coded drm_crtc_vblank_crtc() with the real thing. Cc: intel-gfx@lists.freedesktop.org Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_crtc.c | 3 +-- drivers/gpu/drm/i915/display/intel_vblank.c | 16 +--- 2 files changed,

[PATCH 1/5] drm/vblank: Introduce drm_crtc_vblank_crtc()

2024-04-08 Thread Ville Syrjala
From: Ville Syrjälä Make life easier by providing a function that hands out the the correct drm_vblank_crtc for a given a drm_crtc. Also abstract the lower level internals of the vblank code in a similar fashion. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_vblank.c | 58

✗ Fi.CI.BAT: failure for drm: debug logging improvements (rev2)

2024-04-08 Thread Patchwork
== Series Details == Series: drm: debug logging improvements (rev2) URL : https://patchwork.freedesktop.org/series/130881/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14543 -> Patchwork_130881v2 Summary ---

✗ Fi.CI.CHECKPATCH: warning for drm: debug logging improvements (rev2)

2024-04-08 Thread Patchwork
== Series Details == Series: drm: debug logging improvements (rev2) URL : https://patchwork.freedesktop.org/series/130881/ State : warning == Summary == Error: dim checkpatch failed 8940559de49f drm/probe-helper: switch to drm device based logging 6624644e87e2 drm/modes: switch to drm device

✓ Fi.CI.BAT: success for drm/edid: cleanups, resend

2024-04-08 Thread Patchwork
== Series Details == Series: drm/edid: cleanups, resend URL : https://patchwork.freedesktop.org/series/132142/ State : success == Summary == CI Bug Log - changes from CI_DRM_14543 -> Patchwork_132142v1 Summary --- **SUCCESS** No

Re: [PATCH 0/8] drm/i915: drm_i915_private and xe_device cleanups

2024-04-08 Thread Ville Syrjälä
On Mon, Apr 08, 2024 at 09:08:35PM +0300, Jani Nikula wrote: > Continue cleaning up the members from drm_i915_private and xe_device to > struct intel_display. > > Jani Nikula (8): > drm/i915/gt: drop display clock info from gt debugfs > drm/i915: move skl_preferred_vco_freq to display

✗ Fi.CI.SPARSE: warning for drm/edid: cleanups, resend

2024-04-08 Thread Patchwork
== Series Details == Series: drm/edid: cleanups, resend URL : https://patchwork.freedesktop.org/series/132142/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1:

✗ Fi.CI.CHECKPATCH: warning for drm/edid: cleanups, resend

2024-04-08 Thread Patchwork
== Series Details == Series: drm/edid: cleanups, resend URL : https://patchwork.freedesktop.org/series/132142/ State : warning == Summary == Error: dim checkpatch failed d6df9c755975 drm/displayid: move drm_displayid.h to drm_displayd_internal.h -:31: WARNING:FILE_PATH_CHANGES: added, moved

Re: [PATCH 1/4] drm/edid: add drm_edid_get_product_id()

2024-04-08 Thread Ville Syrjälä
On Thu, Mar 21, 2024 at 12:05:09PM +0200, Jani Nikula wrote: > Add a struct drm_edid based function to get the vendor and product ID > from an EDID. Add a separate struct for defining this part of the EDID, > with defined byte order for product code and serial number. > > Signed-off-by: Jani

[PATCH 8/8] drm/xe/display: remove unused xe->enabled_irq_mask

2024-04-08 Thread Jani Nikula
The xe->enabled_irq_mask member has never been used for anything. Signed-off-by: Jani Nikula --- drivers/gpu/drm/xe/display/xe_display.c | 1 - drivers/gpu/drm/xe/xe_device_types.h| 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/gpu/drm/xe/display/xe_display.c

[PATCH 7/8] drm/i915: move pipestat_irq_mask to display substruct

2024-04-08 Thread Jani Nikula
The info is related to display, and should be placed under i915->display. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_core.h | 1 + drivers/gpu/drm/i915/display/intel_display_irq.c | 14 +++--- drivers/gpu/drm/i915/i915_drv.h | 1 -

[PATCH 6/8] drm/i915: move de_irq_mask to display substruct

2024-04-08 Thread Jani Nikula
The info is related to display, and should be placed under i915->display. Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_display_core.h | 2 ++ .../gpu/drm/i915/display/intel_display_irq.c| 17 + drivers/gpu/drm/i915/i915_drv.h | 5 +

[PATCH 3/8] drm/i915: move max_dotclk_freq to display substruct

2024-04-08 Thread Jani Nikula
The info is related to display, and should be placed under i915->display. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c| 6 +++--- drivers/gpu/drm/i915/display/intel_crt.c | 2 +- drivers/gpu/drm/i915/display/intel_display.c | 6 +++---

[PATCH 2/8] drm/i915: move skl_preferred_vco_freq to display substruct

2024-04-08 Thread Jani Nikula
The info is related to display, and should be placed under i915->display. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 17 - .../gpu/drm/i915/display/intel_display_core.h | 1 + drivers/gpu/drm/i915/i915_drv.h | 1 -

[PATCH 5/8] drm/i915: move display_irqs_enabled to display substruct

2024-04-08 Thread Jani Nikula
The info is related to display, and should be placed under i915->display. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_core.h | 2 ++ drivers/gpu/drm/i915/display/intel_display_irq.c | 14 +++--- drivers/gpu/drm/i915/display/intel_hotplug_irq.c | 2 +-

[PATCH 4/8] drm/i915: move vblank_enabled to display substruct

2024-04-08 Thread Jani Nikula
The info is related to display, and should be placed under i915->display. Start a new irq sub-substruct. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_core.h | 5 + drivers/gpu/drm/i915/display/intel_display_irq.c | 12 ++--

[PATCH 1/8] drm/i915/gt: drop display clock info from gt debugfs

2024-04-08 Thread Jani Nikula
The same info is available in i915_cdclk_info. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c index

[PATCH 0/8] drm/i915: drm_i915_private and xe_device cleanups

2024-04-08 Thread Jani Nikula
Continue cleaning up the members from drm_i915_private and xe_device to struct intel_display. Jani Nikula (8): drm/i915/gt: drop display clock info from gt debugfs drm/i915: move skl_preferred_vco_freq to display substruct drm/i915: move max_dotclk_freq to display substruct drm/i915: move

Re: [PATCH 2/4] drm/edid: add drm_edid_print_product_id()

2024-04-08 Thread Ville Syrjälä
On Thu, Mar 21, 2024 at 12:05:10PM +0200, Jani Nikula wrote: > Add a function to print a decoded EDID vendor and product id to a drm > printer, optinally with the raw data. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 35 +++ >

✓ Fi.CI.BAT: success for Panel replay selective update support (rev6)

2024-04-08 Thread Patchwork
== Series Details == Series: Panel replay selective update support (rev6) URL : https://patchwork.freedesktop.org/series/128193/ State : success == Summary == CI Bug Log - changes from CI_DRM_14543 -> Patchwork_128193v6 Summary ---

✗ Fi.CI.SPARSE: warning for Panel replay selective update support (rev6)

2024-04-08 Thread Patchwork
== Series Details == Series: Panel replay selective update support (rev6) URL : https://patchwork.freedesktop.org/series/128193/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Panel replay selective update support (rev6)

2024-04-08 Thread Patchwork
== Series Details == Series: Panel replay selective update support (rev6) URL : https://patchwork.freedesktop.org/series/128193/ State : warning == Summary == Error: dim checkpatch failed 206b20dab9c8 drm/i915/psr: Rename has_psr2 as has_sel_update -:31: CHECK:PARENTHESIS_ALIGNMENT: Alignment

Re: [PATCH 1/2] drm/i915: move rawclk init to intel_cdclk_init()

2024-04-08 Thread Ville Syrjälä
On Mon, Apr 08, 2024 at 08:28:27PM +0300, Ville Syrjälä wrote: > On Mon, Apr 08, 2024 at 08:23:14PM +0300, Jani Nikula wrote: > > The rawclk initialization is a bit out of place in > > intel_device_info_runtime_init(). Move it to intel_cdclk_init(), with a > > bit of refactoring on

Re: [PATCH 1/2] drm/i915: move rawclk init to intel_cdclk_init()

2024-04-08 Thread Ville Syrjälä
On Mon, Apr 08, 2024 at 08:23:14PM +0300, Jani Nikula wrote: > The rawclk initialization is a bit out of place in > intel_device_info_runtime_init(). Move it to intel_cdclk_init(), with a > bit of refactoring on intel_read_rawclk(). rawclk is used outside of display. > > Signed-off-by: Jani

Re: [PATCH 11/12] drm/client: Streamline mode selection debugs

2024-04-08 Thread Ville Syrjälä
On Mon, Apr 08, 2024 at 09:46:44AM +0200, Thomas Zimmermann wrote: > Hi > > Am 05.04.24 um 21:58 schrieb Ville Syrjälä: > > On Fri, Apr 05, 2024 at 09:57:07AM +0200, Thomas Zimmermann wrote: > >> Hi > >> > >> Am 04.04.24 um 22:33 schrieb Ville Syrjala: > >>> From: Ville Syrjälä > >>> > >>> Get

[PATCH 2/2] drm/i915: move rawclk from runtime to display runtime info

2024-04-08 Thread Jani Nikula
It's mostly about display, so move it under display. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_backlight.c | 10 +- drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- drivers/gpu/drm/i915/display/intel_display_device.c| 2 ++

[PATCH 1/2] drm/i915: move rawclk init to intel_cdclk_init()

2024-04-08 Thread Jani Nikula
The rawclk initialization is a bit out of place in intel_device_info_runtime_init(). Move it to intel_cdclk_init(), with a bit of refactoring on intel_read_rawclk(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 23 +++---

✓ Fi.CI.BAT: success for drm/i915: use check_add_overflow() and drop local variants (rev2)

2024-04-08 Thread Patchwork
== Series Details == Series: drm/i915: use check_add_overflow() and drop local variants (rev2) URL : https://patchwork.freedesktop.org/series/132104/ State : success == Summary == CI Bug Log - changes from CI_DRM_14543 -> Patchwork_132104v2

✗ Fi.CI.SPARSE: warning for drm/i915: use check_add_overflow() and drop local variants (rev2)

2024-04-08 Thread Patchwork
== Series Details == Series: drm/i915: use check_add_overflow() and drop local variants (rev2) URL : https://patchwork.freedesktop.org/series/132104/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[linux-next:master] BUILD REGRESSION 11cb68ad52ac78c81e33b806b531f097e68edfa2

2024-04-08 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 11cb68ad52ac78c81e33b806b531f097e68edfa2 Add linux-next specific files for 20240408 Error/Warning: (recently discovered and may have been fixed) drivers/gpu/drm/drm_mm.c:152:1: error: unused

Re: [PATCH 05/10] drm/i915: skip DRM_I915_LOW_LEVEL_TRACEPOINTS with NOTRACE

2024-04-08 Thread Steven Rostedt
On Fri, 5 Apr 2024 16:18:23 +0200 Sebastian Andrzej Siewior wrote: > The order of the header files is important. If this header file is > included after tracepoint.h was included then the NOTRACE here becomes a > nop. Currently this happens for two .c files which use the tracepoitns > behind

✗ Fi.CI.BAT: failure for series starting with [v2] drm: Add drm_vblank_work_flush_all(). (rev3)

2024-04-08 Thread Patchwork
== Series Details == Series: series starting with [v2] drm: Add drm_vblank_work_flush_all(). (rev3) URL : https://patchwork.freedesktop.org/series/132028/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14543 -> Patchwork_132028v3

✗ Fi.CI.SPARSE: warning for series starting with [v2] drm: Add drm_vblank_work_flush_all(). (rev3)

2024-04-08 Thread Patchwork
== Series Details == Series: series starting with [v2] drm: Add drm_vblank_work_flush_all(). (rev3) URL : https://patchwork.freedesktop.org/series/132028/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for series starting with [v2] drm: Add drm_vblank_work_flush_all(). (rev3)

2024-04-08 Thread Patchwork
== Series Details == Series: series starting with [v2] drm: Add drm_vblank_work_flush_all(). (rev3) URL : https://patchwork.freedesktop.org/series/132028/ State : warning == Summary == Error: dim checkpatch failed 59ee87364491 drm: Add drm_vblank_work_flush_all(). -:33:

Re: [PATCH 2/6] drm/i915/dmc: define firmware URL locally

2024-04-08 Thread Josh Boyer
On Fri, Apr 5, 2024 at 4:29 PM Lucas De Marchi wrote: > > On Fri, Apr 05, 2024 at 10:37:39PM +0300, Jani Nikula wrote: > >Avoid the dependency on intel_uc_fw.h, and allow removal of xe compat > >intel_uc_fw.h. If there needs to be duplication of the URL, at least > >have the duplication in a

Re: [PATCH v0 10/14] sfc: falcon: Make I2C terminology more inclusive

2024-04-08 Thread Easwar Hariharan
On 4/2/2024 1:29 AM, Simon Horman wrote: > On Fri, Mar 29, 2024 at 05:00:34PM +, Easwar Hariharan wrote: >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" >> with more appropriate terms. Inspired by and following on to Wolfram's >> series to fix drivers/i2c/[1], fix the

Re: [PATCH v0 10/14] sfc: falcon: Make I2C terminology more inclusive

2024-04-08 Thread Martin Habets
On Thu, Apr 04, 2024 at 12:18:06PM -0700, Easwar Hariharan wrote: > On 4/2/2024 2:00 AM, Martin Habets wrote: > > On Fri, Mar 29, 2024 at 05:00:34PM +, Easwar Hariharan wrote: > >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" > >> with more appropriate terms. Inspired

Re: [PATCH v0 10/14] sfc: falcon: Make I2C terminology more inclusive

2024-04-08 Thread Simon Horman
On Thu, Apr 04, 2024 at 12:17:26PM -0700, Easwar Hariharan wrote: > On 4/2/2024 1:29 AM, Simon Horman wrote: > > On Fri, Mar 29, 2024 at 05:00:34PM +, Easwar Hariharan wrote: > >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" > >> with more appropriate terms. Inspired

Re: [PATCH 0/6] drm: enable W=1 warnings by default across the subsystem

2024-04-08 Thread Aishwarya TCV
On 05/04/2024 10:57, Jani Nikula wrote: > On Thu, 04 Apr 2024, Aishwarya TCV wrote: >> Observed warning "include/drm/drm_print.h:536:35: warning: '%4.4s' >> directive argument is null [-Wformat-overflow=]" when building the >> modules with "defconfig+kselftest-ftrace"( >>

Re: [PATCH v0 02/14] drm/amdgpu,drm/radeon: Make I2C terminology more inclusive

2024-04-08 Thread Ville Syrjälä
On Fri, Mar 29, 2024 at 06:38:10PM +0100, Andi Shyti wrote: > Hi, > > On Fri, Mar 29, 2024 at 10:28:14AM -0700, Easwar Hariharan wrote: > > On 3/29/2024 10:16 AM, Andi Shyti wrote: > > > Hi Easwar, > > > > > > On Fri, Mar 29, 2024 at 05:00:26PM +, Easwar Hariharan wrote: > > >> I2C v7, SMBus

Re: [PATCH v0 00/14] Make I2C terminology more inclusive for I2C Algobit and consumers

2024-04-08 Thread Easwar Hariharan
Hi Wolfram, On 4/5/2024 3:18 AM, Wolfram Sang wrote: > Hello Easwar, > > On Fri, Mar 29, 2024 at 05:00:24PM +, Easwar Hariharan wrote: >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" >> with more appropriate terms. Inspired by and following on to Wolfram's >> series

Re: [PATCH v0 10/14] sfc: falcon: Make I2C terminology more inclusive

2024-04-08 Thread Easwar Hariharan
On 4/2/2024 2:00 AM, Martin Habets wrote: > On Fri, Mar 29, 2024 at 05:00:34PM +, Easwar Hariharan wrote: >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" >> with more appropriate terms. Inspired by and following on to Wolfram's >> series to fix drivers/i2c/[1], fix

Re: [PATCH v0 13/14] drm/nouveau: Make I2C terminology more inclusive

2024-04-08 Thread Easwar Hariharan
On 4/5/2024 9:15 AM, Danilo Krummrich wrote: > Hi Easwar, > > On 3/29/24 18:00, Easwar Hariharan wrote: >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" >> with more appropriate terms. Inspired by and following on to Wolfram's >> series to fix drivers/i2c/[1], fix the

Re: [PATCH v0 01/14] IB/hfi1, IB/qib: Make I2C terminology more inclusive

2024-04-08 Thread Dennis Dalessandro
On 4/3/24 4:30 AM, Leon Romanovsky wrote: > On Fri, Mar 29, 2024 at 05:00:25PM +, Easwar Hariharan wrote: >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" >> with more appropriate terms. Inspired by and following on to Wolfram's series >> to fix drivers/i2c[1], fix

Re: [PATCH v0 03/14] drm/gma500,drm/i915: Make I2C terminology more inclusive

2024-04-08 Thread Easwar Hariharan
On 4/2/2024 9:52 AM, Jani Nikula wrote: > On Tue, 02 Apr 2024, Easwar Hariharan wrote: >> On 4/2/2024 7:32 AM, Jani Nikula wrote: >>> On Tue, 02 Apr 2024, Easwar Hariharan wrote: On 4/2/2024 12:48 AM, Jani Nikula wrote: > On Fri, 29 Mar 2024, Easwar Hariharan > wrote: >> I2C

Re: [PATCH v0 03/14] drm/gma500,drm/i915: Make I2C terminology more inclusive

2024-04-08 Thread Easwar Hariharan
On 4/2/2024 12:48 AM, Jani Nikula wrote: > On Fri, 29 Mar 2024, Easwar Hariharan wrote: >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" >> with more appropriate terms. Inspired by and following on to Wolfram's >> series to fix drivers/i2c/[1], fix the terminology for

Re: [PATCH v0 01/14] IB/hfi1, IB/qib: Make I2C terminology more inclusive

2024-04-08 Thread Easwar Hariharan
On 4/3/2024 8:54 AM, Dennis Dalessandro wrote: > > On 4/3/24 4:30 AM, Leon Romanovsky wrote: >> On Fri, Mar 29, 2024 at 05:00:25PM +, Easwar Hariharan wrote: >>> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" >>> with more appropriate terms. Inspired by and following

Re: [PATCH v0 10/14] sfc: falcon: Make I2C terminology more inclusive

2024-04-08 Thread Martin Habets
On Fri, Mar 29, 2024 at 05:00:34PM +, Easwar Hariharan wrote: > I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" > with more appropriate terms. Inspired by and following on to Wolfram's > series to fix drivers/i2c/[1], fix the terminology for users of > I2C_ALGOBIT

[REQUEST] Add support for Intel DPST (Display Power Saving Technology)

2024-04-08 Thread José Relvas
Hey folks, I've noticed that power-profiles-daemon recently added support for AMD's panel power saving technology with this MR: https://gitlab.freedesktop.org/upower/power-profiles-daemon/-/merge_requests/137 It appears to be controlled via a panel_power_saving SYSFS property. This reminded

Re: [PATCH 0/6] drm: enable W=1 warnings by default across the subsystem

2024-04-08 Thread Aishwarya TCV
On 10/01/2024 17:39, Jani Nikula wrote: > This is v2 of [1] to enable most W=1 warnings across the drm > subsystem. Some fixes first, and a CONFIG_DRM_WERROR on top. > > I build tested this for x86 (both gcc and clang), arm and arm64. > > BR, > Jani. > > > [1]

Re: [PATCH v0 10/14] sfc: falcon: Make I2C terminology more inclusive

2024-04-08 Thread Simon Horman
On Fri, Mar 29, 2024 at 05:00:34PM +, Easwar Hariharan wrote: > I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" > with more appropriate terms. Inspired by and following on to Wolfram's > series to fix drivers/i2c/[1], fix the terminology for users of > I2C_ALGOBIT

Re: [PATCH v0 03/14] drm/gma500,drm/i915: Make I2C terminology more inclusive

2024-04-08 Thread Easwar Hariharan
On 4/2/2024 7:32 AM, Jani Nikula wrote: > On Tue, 02 Apr 2024, Easwar Hariharan wrote: >> On 4/2/2024 12:48 AM, Jani Nikula wrote: >>> On Fri, 29 Mar 2024, Easwar Hariharan wrote: I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" with more appropriate terms.

Re: [PATCH 0/4] drm/edid & drm/i915: vendor and product id logging improvements

2024-04-08 Thread Jani Nikula
On Mon, 08 Apr 2024, Melissa Wen wrote: > On 04/08, Jani Nikula wrote: >> On Mon, 08 Apr 2024, Melissa Wen wrote: >> > On 04/02, Jani Nikula wrote: >> >> On Thu, 21 Mar 2024, Jani Nikula wrote: >> >> > Jani Nikula (4): >> >> > drm/edid: add drm_edid_get_product_id() >> >> > drm/edid: add

Re: [PATCH 0/4] drm/edid & drm/i915: vendor and product id logging improvements

2024-04-08 Thread Melissa Wen
On 04/08, Jani Nikula wrote: > On Mon, 08 Apr 2024, Melissa Wen wrote: > > On 04/02, Jani Nikula wrote: > >> On Thu, 21 Mar 2024, Jani Nikula wrote: > >> > Jani Nikula (4): > >> > drm/edid: add drm_edid_get_product_id() > >> > drm/edid: add drm_edid_print_product_id() > >> > drm/i915/bios:

[PATCH v2 3/3] drm/915/lspcon: Reduce dmesg errors during lspcon_init failure

2024-04-08 Thread Ankit Nautiyal
Currently lspcon_resume calls lspcon_init and in case of failure we get error messages from lspcon_init and then again from lspcon_resume. Just have a single error message in lspcon_init. v2: Add the relavant info with each error, and avoid mix of dbg and error messages. (Jani) Signed-off-by:

Re: [PATCH 0/4] drm/edid & drm/i915: vendor and product id logging improvements

2024-04-08 Thread Jani Nikula
On Mon, 08 Apr 2024, Melissa Wen wrote: > On 04/02, Jani Nikula wrote: >> On Thu, 21 Mar 2024, Jani Nikula wrote: >> > Jani Nikula (4): >> > drm/edid: add drm_edid_get_product_id() >> > drm/edid: add drm_edid_print_product_id() >> > drm/i915/bios: switch to struct drm_edid and struct >> >

RE: [PATCH v2 20/25] drm/i915/bmg: BMG should re-use MTL's south display logic

2024-04-08 Thread Bhadane, Dnyaneshwar
> -Original Message- > From: Intel-gfx On Behalf Of > Balasubramani Vivekanandan > Sent: Wednesday, April 3, 2024 4:53 PM > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Cc: Roper, Matthew D ; De Marchi, Lucas > ; Vivekanandan, Balasubramani > > Subject: [PATCH

Re: [PATCH] drm/i915: use check_add_overflow() and drop local variants

2024-04-08 Thread Rodrigo Vivi
On Fri, Apr 05, 2024 at 11:26:25PM +0300, Jani Nikula wrote: > Prefer common check_add_overflow() from overflow.h over the locally > rolled versions of it. While check_add_overflow() does require a > variable to assign to, unlike add_overflows_t(), it's still better than > having multiple versions

[PATCH 2/2] drm/xe/display: remove compat raw reg read/write support

2024-04-08 Thread Jani Nikula
The i915 display code no longer uses these interfaces. Remove them. Signed-off-by: Jani Nikula --- .../drm/xe/compat-i915-headers/intel_uncore.h | 24 --- 1 file changed, 24 deletions(-) diff --git a/drivers/gpu/drm/xe/compat-i915-headers/intel_uncore.h

[PATCH 1/2] drm/i915/display: remove small micro-optimizations in irq handling

2024-04-08 Thread Jani Nikula
The raw register reads/writes are there as micro-optimizations to avoid multiple pointer indirections on uncore->regs. Presumably this is useful when there are plenty of register reads/writes in the same function. However, the display irq handling only has a few raw reads/writes. Remove them for

Re: [PATCH v2 7/7] drm: prefer DRM_MODE_FMT/ARG over drm_mode_debug_printmodeline()

2024-04-08 Thread Ville Syrjälä
On Mon, Apr 08, 2024 at 12:24:02PM +0300, Jani Nikula wrote: > We have DRM_MODE_FMT and DRM_MODE_ARG() macros to allow unified debug > printing of modes in any printk-formatted logging. Prefer them over > drm_mode_debug_printmodeline(). > > This allows drm device specific logging of modes, in the

Re: [PATCH v2 01/17] drm/i915: Update pipes in reverse order for bigjoiner

2024-04-08 Thread Ville Syrjälä
On Fri, Apr 05, 2024 at 12:56:52PM +, Murthy, Arun R wrote: > > > -Original Message- > > From: Intel-gfx On Behalf Of Ville > > Syrjala > > Sent: Friday, April 5, 2024 3:04 AM > > To: intel-gfx@lists.freedesktop.org > > Subject: [PATCH v2 01/17] drm/i915: Update pipes in reverse

Re: [PATCH v2 6/7] drm/crtc-helper: switch to drm device based logging and warns

2024-04-08 Thread Ville Syrjälä
On Mon, Apr 08, 2024 at 12:24:01PM +0300, Jani Nikula wrote: > Prefer drm device based drm_dbg_kms(), drm_err(), drm_WARN_ON() over > DRM_DEBUG_KMS(), DRM_ERROR(), and WARN_ON(). Also update encoder, > connector, and crtc logging to include the object id and name, where > possible. > >

Re: [PATCH 0/4] drm/edid & drm/i915: vendor and product id logging improvements

2024-04-08 Thread Melissa Wen
On 04/02, Jani Nikula wrote: > On Thu, 21 Mar 2024, Jani Nikula wrote: > > Jani Nikula (4): > > drm/edid: add drm_edid_get_product_id() > > drm/edid: add drm_edid_print_product_id() > > drm/i915/bios: switch to struct drm_edid and struct > > drm_edid_product_id > > drm/i915/bios:

Re: [PATCH v7 6/6] drm/i915: Implement fbdev emulation as in-kernel client

2024-04-08 Thread Thomas Zimmermann
Hi Am 05.04.24 um 10:34 schrieb Hogander, Jouni: [...] diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c index e0f13c62a1832..69178b73845e1 100644 --- a/drivers/gpu/drm/i915/i915_driver.c +++ b/drivers/gpu/drm/i915/i915_driver.c @@ -816,6 +816,8 @@ int

Re: [PATCH] drm/i915/pps: move pps debugfs file to intel_pps.c

2024-04-08 Thread Ville Syrjälä
On Mon, Apr 08, 2024 at 12:43:57PM +0300, Jani Nikula wrote: > Continue with placing debugfs next to the implementation. > > Signed-off-by: Jani Nikula > --- > .../drm/i915/display/intel_display_debugfs.c | 27 ++-- > drivers/gpu/drm/i915/display/intel_pps.c | 32

Re: [PATCH v7 1/6] drm/client: Export drm_client_dev_unregister()

2024-04-08 Thread Thomas Zimmermann
Hi Am 08.03.24 um 16:49 schrieb Rodrigo Vivi: On Fri, Mar 01, 2024 at 02:42:54PM +0100, Thomas Zimmermann wrote: Export drm_client_dev_unregister() for use by the i915 driver. The driver does not use drm_dev_unregister(), Perhaps we should make i915 to call for the drm_dev_unregister since it

Re: [PATCH v2 0/7] drm: debug logging improvements

2024-04-08 Thread Thomas Zimmermann
Hi Reviewed-by: Thomas Zimmermann for patches 5 to 7. Best regards Thomas Am 08.04.24 um 11:23 schrieb Jani Nikula: v2 of [1], dropping drm_mode_print() stuff altogether, and switching to DRM_MODE_FMT/DRM_MODE_ARG() in a separate patch. Also add a few more drm device based logging

Re: [PATCH v10 2/6] drm/i915/display: Extract code required to calculate max qgv/psf gv point

2024-04-08 Thread Govindapillai, Vinod
On Mon, 2024-04-08 at 11:32 +0300, Lisovskiy, Stanislav wrote: > On Fri, Apr 05, 2024 at 02:35:29PM +0300, Vinod Govindapillai wrote: > > From: Stanislav Lisovskiy > > > > We need that in order to force disable SAGV in next patch. > > Also it is beneficial to separate that code, as in majority

Re: [PATCH v10 5/6] drm/i915/display: handle systems with duplicate psf gv points

2024-04-08 Thread Govindapillai, Vinod
On Mon, 2024-04-08 at 11:29 +0300, Lisovskiy, Stanislav wrote: > On Fri, Apr 05, 2024 at 02:35:32PM +0300, Vinod Govindapillai wrote: > > From: Stanislav Lisovskiy > > > > There could be multiple qgv and psf gv points with similar values. > > Apparently pcode's handling og psf and qgv points are

Re: [PATCH 3/3] drm/915/lspcon: Reduce dmesg errors during lspcon_init failure

2024-04-08 Thread Jani Nikula
On Mon, 08 Apr 2024, Ankit Nautiyal wrote: > Currently lspcon_resume calls lspcon_init and in case of failure we get > error messages from lspcon_init and then again from lspcon_resume. > > Just have a single error message in lspcon_init and convert all other > errors as dbg messages. > >

Re: [PATCH 2/3] drm/i915/lspcon: Separate out function to set pcon mode

2024-04-08 Thread Jani Nikula
On Mon, 08 Apr 2024, Ankit Nautiyal wrote: > Currently lspcon_probe tries to probe for LSPCON and also set the > PCON mode on the LSPCON. If any of these fails, it returns fail > resulting in error message. So even if there is nothing connected to > LSPCON port we get error messages for probe

Re: [PATCH 1/3] drm/i915/lspcon: Separate out function to get expected mode

2024-04-08 Thread Jani Nikula
On Mon, 08 Apr 2024, Ankit Nautiyal wrote: > Reuse code to wake native aux channel and get the expected lspcon > mode. > > Signed-off-by: Ankit Nautiyal Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_lspcon.c | 18 ++ > 1 file changed, 10 insertions(+), 8

[PATCH] drm/i915/pps: move pps debugfs file to intel_pps.c

2024-04-08 Thread Jani Nikula
Continue with placing debugfs next to the implementation. Signed-off-by: Jani Nikula --- .../drm/i915/display/intel_display_debugfs.c | 27 ++-- drivers/gpu/drm/i915/display/intel_pps.c | 32 +++ drivers/gpu/drm/i915/display/intel_pps.h | 2 ++ 3 files

  1   2   >