[Intel-gfx] [PATCH v8 04/19] drm/i915/hdcp: No HDCP when encoder is't initialized

2020-12-11 Thread Anshuman Gupta
ik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c index b9d8825e2bb1..7d63e9495956 100644 --- a/drivers/gpu/drm/i915/d

[Intel-gfx] [PATCH v8 05/19] drm/i915/hdcp: DP MST transcoder for link and stream

2020-12-11 Thread Anshuman Gupta
and HDCP 2.2 over DP MST on Gen12. Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- .../gpu/drm/i915/display/intel_display_types.h| 2 ++ drivers/gpu/drm

Re: [Intel-gfx] [PATCH v7 1/2] drm/i915/display: Support PSR Multiple Transcoders

2020-12-16 Thread Anshuman Gupta
upporting multiple transcoder > PSR on BDW+ Could you please send this in a separate patch, remove the PORT_A restriction so that we can support multiple psr instances. Thanks, Anshuman Gupta. > > Signed-off-by: Gwan-gyeong Mun > Cc: José Roberto de Souza > Cc: Juha-Pek

Re: [Intel-gfx] [PATCH 1/1] drm/i915/dp: optimize pps_lock wherever required

2020-12-14 Thread Anshuman Gupta
On 2020-12-11 at 16:13:56 +0200, Jani Nikula wrote: > On Fri, 04 Dec 2020, Anshuman Gupta wrote: > > Reading backlight status from PPS register doesn't require > > AUX power on the platform which has South Display Engine on PCH. > > It invokes a unnecessary power well

[Intel-gfx] [PATCH v8 17/19] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks

2020-12-11 Thread Anshuman Gupta
redundant link check. [Ram] v4: - use pipe instead of port to access HDCP2_STREAM_STATUS Cc: Ramalingam C Reviewed-by: Uma Shankar Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- .../drm/i915/display/intel_display_types.h| 4 + drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 89

[Intel-gfx] [PATCH v8 18/19] drm/i915/hdcp: Configure HDCP2.2 MST steram encryption status

2020-12-11 Thread Anshuman Gupta
Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 51 ++- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c index

[Intel-gfx] [PATCH v8 19/19] drm/i915/hdcp: Enable HDCP 2.2 MST support

2020-12-11 Thread Anshuman Gupta
Enable HDCP 2.2 MST support till Gen12. Cc: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v2] drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms

2020-11-10 Thread Anshuman Gupta
l PCH. v3: - use intel_de_rmw(). [Rodrigo] Cc: Rodrigo Vivi Signed-off-by: Bob Paauwe Signed-off-by: Anshuman Gupta Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_display_power.c | 13 +++-- drivers/gpu/drm/i915/i915_irq.c| 6 -- 2 files c

Re: [Intel-gfx] [PATCH 22/27] drm/i915/pxp: Expose session state for display protection flip

2020-11-17 Thread Anshuman Gupta
ool intel_pxp_gem_object_status(struct drm_i915_private *i915, u64 > gem_object_metadata) Currently this api used by Patch 27 of this series, uses gem object user flag (obj->user_flags) to pass as gem_object_metadata but it is unused ? why do we need this gem_object_metadata ? Tha

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms (rev4)

2020-11-17 Thread Anshuman Gupta
On 2020-11-11 at 21:48:13 +, Patchwork wrote: Hi Matt, Could you please help to merge the below patch to dinq. It is having RB of rodrigo and CI results also green. Thanks, Anshuman Gupta. > == Series Details == > > Series: drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11

Re: [Intel-gfx] [PATCH v4 15/16] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks

2020-11-08 Thread Anshuman Gupta
On 2020-11-06 at 16:42:21 +0530, Ramalingam C wrote: > On 2020-11-06 at 14:57:25 +0530, Ramalingam C wrote: > > On 2020-11-03 at 11:57:00 +0530, Anshuman Gupta wrote: > > > Add support for HDCP 2.2 DP MST shim callback. > > > This adds existing DP HDCP shim callb

[Intel-gfx] [PATCH v5 12/17] drm/hdcp: Max MST content streams

2020-11-10 Thread Anshuman Gupta
Let's define Maximum MST content streams up to four generically which can be supported by modern display controllers. Cc: Sean Paul Cc: Ramalingam C Acked-by: Maarten Lankhorst Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Signed-off-by: Anshuman Gupta --- include/drm/drm_hdcp.h | 8

[Intel-gfx] [PATCH v5 03/17] drm/i915/hotplug: Handle CP_IRQ for DP-MST

2020-11-10 Thread Anshuman Gupta
Handle CP_IRQ in DEVICE_SERVICE_IRQ_VECTOR_ESI0 It requires to call intel_hdcp_handle_cp_irq() in case of CP_IRQ is triggered by a sink in DP-MST topology. Cc: "Ville Syrjälä" Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Signed-off-by: Anshuman Gupta --- d

[Intel-gfx] [PATCH v5 11/17] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len

2020-11-10 Thread Anshuman Gupta
Acked-by: Tomas Winkler Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/misc/mei/hdcp/mei_hdcp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c b/drivers/misc/mei/hdcp/mei_hdcp.c index

[Intel-gfx] [PATCH v5 15/17] drm/i915/hdcp: Add HDCP 2.2 stream register

2020-11-10 Thread Anshuman Gupta
Add HDCP 2.2 DP MST HDCP2_STREAM_STATUS and HDCP2_AUTH_STREAM register in i915_reg header. Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/i915_reg.h | 30 ++ 1 file changed, 30 insertions

[Intel-gfx] [PATCH v5 13/17] drm/i915/hdcp: MST streams support in hdcp port_data

2020-11-10 Thread Anshuman Gupta
stream. v3: - Cosmetic changes. [Uma] v4: - 's/port_auth/hdcp_port_auth'. [Ram] - Commit log improvement. Cc: Ramalingam C Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta --- .../drm/i915/display/intel_display_types.h| 4 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 103

[Intel-gfx] [PATCH v5 06/17] drm/i915/hdcp: HDCP stream encryption support

2020-11-10 Thread Anshuman Gupta
Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 10 +-- drivers/gpu/drm/i915/display/intel_ddi.h | 6 +- .../drm/i915/display/intel_display_types.h| 4 + drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 86 --- drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v5 04/17] drm/i915/hdcp: DP MST transcoder for link and stream

2020-11-10 Thread Anshuman Gupta
and HDCP 2.2 over DP MST on Gen12. Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- .../gpu/drm/i915/display/intel_display_types.h| 2 ++ drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v5 05/17] drm/i915/hdcp: Move HDCP enc status timeout to header

2020-11-10 Thread Anshuman Gupta
. It will be used by both HDCP{1.x,2.x} stream status timeout. Related: 'commit 7e90e8d0c0ea ("drm/i915: Increase timeout for Encrypt status change")' Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_

[Intel-gfx] [PATCH v5 00/17] HDCP 2.2 and HDCP 1.4 Gen12 DP MST support

2020-11-10 Thread Anshuman Gupta
drm-intel. [PATCH v5 12/17] drm/hdcp: Max MST content streams has an Ack from drm-misc maintainer to merge it via drm-intel. Test-with: 20201103082628.9287-2-karthik@intel.com Anshuman Gupta (17): drm/i915/hdcp: Update CP property in update_pipe drm/i915/hdcp: Get conn while content_type

[Intel-gfx] [PATCH v5 10/17] drm/i915/hdcp: Encapsulate hdcp_port_data to dig_port

2020-11-10 Thread Anshuman Gupta
Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 + .../drm/i915/display/intel_display_types.h| 5 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 56 +++ 3 files changed, 39 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v5 02/17] drm/i915/hdcp: Get conn while content_type changed

2020-11-10 Thread Anshuman Gupta
ma Shankar Reviewed-by: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c index eee8263405b9..b9d8825e2bb1 100644 ---

[Intel-gfx] [PATCH v5 08/17] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-11-10 Thread Anshuman Gupta
Enable HDCP 1.4 over DP MST for Gen12. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v5 09/17] drm/i915/hdcp: Pass dig_port to intel_hdcp_init

2020-11-10 Thread Anshuman Gupta
Pass dig_port as an argument to intel_hdcp_init() and intel_hdcp2_init(). This will be required for HDCP 2.2 stream encryption. Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 4

[Intel-gfx] [PATCH v5 01/17] drm/i915/hdcp: Update CP property in update_pipe

2020-11-10 Thread Anshuman Gupta
EGISTERED) v3: Commit log improvement. [Uma] Added a comment before scheduling prop_work. [Uma] Fixes: 33f9a623bfc6 ("drm/i915/hdcp: Update CP as per the kernel internal state") Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Signed-off-by: Anshuman Gupta --- d

[Intel-gfx] [PATCH v5 07/17] drm/i915/hdcp: Enable HDCP 1.4 stream encryption

2020-11-10 Thread Anshuman Gupta
-by: Uma Shankar Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 45 --- 1 file changed, 31 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c index 0322a83c151d

[Intel-gfx] [PATCH v5 14/17] drm/i915/hdcp: Pass connector to check_2_2_link

2020-11-10 Thread Anshuman Gupta
-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_display_types.h | 3 ++- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 3 ++- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- drivers/gpu/drm/i915/display/intel_hdmi.c | 3 ++- 4 files changed, 7 insertions(+), 4

[Intel-gfx] [PATCH v5 16/17] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks

2020-11-10 Thread Anshuman Gupta
redundant link check. [Ram] Cc: Ramalingam C Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta --- .../drm/i915/display/intel_display_types.h| 4 + drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 89 +-- 2 files changed, 85 insertions(+), 8 deletions(-) diff --git

[Intel-gfx] [PATCH v5 17/17] drm/i915/hdcp: Enable HDCP 2.2 MST support

2020-11-10 Thread Anshuman Gupta
all encrypted stream encryption is disabled, disable the port HDCP encryption and deauthenticate the port. v2: - Add connector details in drm_err. [Ram] - 's/port_auth/hdcp_auth_status'. [Ram] - Added a debug print for stream enc. Cc: Ramalingam C Reviewed-by: Uma Shankar Signed-off-by: Anshuman

[Intel-gfx] [PATCH v4 15/16] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks

2020-11-02 Thread Anshuman Gupta
-by: Anshuman Gupta --- .../drm/i915/display/intel_display_types.h| 4 + drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 80 +-- 2 files changed, 76 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for HDCP 2.2 and HDCP 1.4 Gen12 DP MST support (rev2)

2020-10-29 Thread Anshuman Gupta
known issue in case these are not known issue could we create bug and rerport the results. All of the below igt@kms_frontbuffer_tracking are failing due to similar dmesg warning. igt@kms_big_fb is odd one out a kernel panic. Rest of all are gem failures. Thanks, Anshuman Gupta. On 2020-10-28 at 06

[Intel-gfx] [PATCH] drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms

2020-10-30 Thread Anshuman Gupta
l PCH. Cc: Rodrigo Vivi Signed-off-by: Bob Paauwe Signed-off-by: Anshuman Gupta Signed-off-by: Matt Roper --- .../drm/i915/display/intel_display_power.c| 21 +-- drivers/gpu/drm/i915/i915_irq.c | 6 -- 2 files changed, 23 insertions(+), 4 deletions(-)

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for HDCP 2.2 and HDCP 1.4 Gen12 DP MST support (rev2)

2020-11-02 Thread Anshuman Gupta
in patch [v4,15/16] commit log, i will send a patch for this. "drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks -:13: WARNING:TYPO_SPELLING: 'chnages' may be misspelled - perhaps 'changes'?" Thanks, Anshuman Gupta. On 2020-10-29 at 17:54:44 +, Patchwork wrote: > == Series Details =

Re: [Intel-gfx] [PATCH] drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms

2020-11-04 Thread Anshuman Gupta
On 2020-11-03 at 17:06:42 -0500, Rodrigo Vivi wrote: > On Fri, Oct 30, 2020 at 11:46:58AM +0530, Anshuman Gupta wrote: > > From: Bob Paauwe > > > > The WA specifies that we need to toggle a SDE chicken bit on and then > > off as the final step in preparation for s0i

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display/tgl: Disable FBC with PSR2

2020-11-04 Thread Anshuman Gupta
& > + IS_TIGERLAKE(dev_priv)) { IMHO we need to use state boolean crtc_state->has_psr2, we can have sink supports PSR2 but it may not be enabled due to any reason. Thanks, Anshuman Gupta. > + fbc->no_fbc_reason = "not supported with PSR2"; > +

Re: [Intel-gfx] [PATCH v4 13/16] drm/i915/hdcp: Pass connector to check_2_2_link

2020-11-05 Thread Anshuman Gupta
On 2020-11-05 at 22:15:37 +0530, Ramalingam C wrote: > On 2020-10-27 at 22:12:05 +0530, Anshuman Gupta wrote: > > This requires for HDCP 2.2 MST check link. > > > > Cc: Ramalingam C > > Reviewed-by: Uma Shankar > > Signed-off-by: Anshuman Gupta > >

Re: [Intel-gfx] [PATCH v4 06/16] drm/i915/hdcp: HDCP stream encryption support

2020-11-05 Thread Anshuman Gupta
On 2020-11-05 at 21:04:03 +0530, Ramalingam C wrote: > On 2020-10-27 at 22:11:58 +0530, Anshuman Gupta wrote: > > Both HDCP_{1.x,2.x} requires to select/deselect Multistream HDCP bit > > in TRANS_DDI_FUNC_CTL in order to enable/disable stream HDCP > > encryption over

Re: [Intel-gfx] [PATCH v4 08/16] drm/i915/hdcp: Pass dig_port to intel_hdcp_init

2020-11-05 Thread Anshuman Gupta
On 2020-11-05 at 22:09:12 +0530, Ramalingam C wrote: > On 2020-10-27 at 22:12:00 +0530, Anshuman Gupta wrote: > > Pass dig_port as an argument to intel_hdcp_init() > > and intel_hdcp2_init(). > > This will be required for HDCP 2.2 stream encryption. > > > > Cc: R

Re: [Intel-gfx] [PATCH v4 12/16] drm/i915/hdcp: MST streams support in hdcp port_data

2020-11-05 Thread Anshuman Gupta
On 2020-11-05 at 22:04:15 +0530, Ramalingam C wrote: > On 2020-10-27 at 22:12:04 +0530, Anshuman Gupta wrote: > > Add support for multiple mst stream in hdcp port data > > which will be used by RepeaterAuthStreamManage msg and > > HDCP 2.2 security f/w for m' validation.

Re: [Intel-gfx] [PATCH v4 07/16] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-11-05 Thread Anshuman Gupta
On 2020-11-05 at 21:11:52 +0530, Ramalingam C wrote: > On 2020-10-27 at 22:11:59 +0530, Anshuman Gupta wrote: > > Enable HDCP 1.4 over DP MST for Gen12. > > This also enable the stream encryption support for > > older generations, which was missing earlier. > It w

[Intel-gfx] [PATCH v4 13/16] drm/i915/hdcp: Pass connector to check_2_2_link

2020-10-27 Thread Anshuman Gupta
This requires for HDCP 2.2 MST check link. Cc: Ramalingam C Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_display_types.h | 3 ++- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 3 ++- drivers/gpu/drm/i915/display/intel_hdcp.c | 2

[Intel-gfx] [PATCH v4 15/16] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks

2020-10-27 Thread Anshuman Gupta
Add support for HDCP 2.2 DP MST shim callback. This adds existing DP HDCP shim callback for Link Authentication and Encryption and HDCP 2.2 stream encryption callback. v2: Added a WARN_ON() instead of drm_err. [Uma] Cosmetic chnages. [Uma] Cc: Ramalingam C Signed-off-by: Anshuman Gupta

[Intel-gfx] [PATCH v4 08/16] drm/i915/hdcp: Pass dig_port to intel_hdcp_init

2020-10-27 Thread Anshuman Gupta
Pass dig_port as an argument to intel_hdcp_init() and intel_hdcp2_init(). This will be required for HDCP 2.2 stream encryption. Cc: Ramalingam C Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 4 ++-- drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v4 06/16] drm/i915/hdcp: HDCP stream encryption support

2020-10-27 Thread Anshuman Gupta
that link in order to enable/disable the stream encryption. Both of above requirement are same for all Gen with respect to B.Spec Documentation. v2: Cosmetic changes function name, error msg print and stream typo fixes. [Uma] Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm

[Intel-gfx] [PATCH v4 12/16] drm/i915/hdcp: MST streams support in hdcp port_data

2020-10-27 Thread Anshuman Gupta
Add support for multiple mst stream in hdcp port data which will be used by RepeaterAuthStreamManage msg and HDCP 2.2 security f/w for m' validation. v2: Init the hdcp port data k for HDMI/DP SST strem. v3: Cosmetic changes. [Uma] Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- .../drm

[Intel-gfx] [PATCH v4 14/16] drm/i915/hdcp: Add HDCP 2.2 stream register

2020-10-27 Thread Anshuman Gupta
Add HDCP 2.2 DP MST HDCP2_STREAM_STATUS and HDCP2_AUTH_STREAM register in i915_reg header. Cc: Ramalingam C Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/i915_reg.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers

[Intel-gfx] [PATCH v4 10/16] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len

2020-10-27 Thread Anshuman Gupta
Acked-by: Tomas Winkler Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta --- drivers/misc/mei/hdcp/mei_hdcp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c b/drivers/misc/mei/hdcp/mei_hdcp.c index 9ae9669e46ea..3506a3534294 100644

[Intel-gfx] [PATCH v4 11/16] drm/hdcp: Max MST content streams

2020-10-27 Thread Anshuman Gupta
Let's define Maximum MST content streams up to four generically which can be supported by modern display controllers. Cc: Sean Paul Cc: Ramalingam C Acked-by: Maarten Lankhorst Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta --- include/drm/drm_hdcp.h | 8 1 file changed, 4

[Intel-gfx] [PATCH v4 16/16] drm/i915/hdcp: Enable HDCP 2.2 MST support

2020-10-27 Thread Anshuman Gupta
all encrypted stream encryption is disabled, disable the port HDCP encryption and deauthenticate the port. Cc: Ramalingam C Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 46 ++- 1 file changed, 44 insertions(+), 2

[Intel-gfx] [PATCH v4 07/16] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-10-27 Thread Anshuman Gupta
comment. [Uma] Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 10 ++--- drivers/gpu/drm/i915/display/intel_hdcp.c | 43 ++--- 2 files changed, 32 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v4 09/16] drm/i915/hdcp: Encapsulate hdcp_port_data to dig_port

2020-10-27 Thread Anshuman Gupta
hdcp_port_data is specific to a port on which HDCP encryption is getting enabled, so encapsulate it to intel_digital_port. This will be required to enable HDCP 2.2 stream encryption. Cc: Ramalingam C Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v4 01/16] drm/i915/hdcp: Update CP property in update_pipe

2020-10-27 Thread Anshuman Gupta
EGISTERED) v3: Commit log improvement. [Uma] Added a comment before scheduling prop_work. [Uma] Fixes: 33f9a623bfc6 ("drm/i915/hdcp: Update CP as per the kernel internal state") Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 8

[Intel-gfx] [PATCH v4 03/16] drm/i915/hotplug: Handle CP_IRQ for DP-MST

2020-10-27 Thread Anshuman Gupta
Handle CP_IRQ in DEVICE_SERVICE_IRQ_VECTOR_ESI0 It requires to call intel_hdcp_handle_cp_irq() in case of CP_IRQ is triggered by a sink in DP-MST topology. Cc: "Ville Syrjälä" Cc: Ramalingam C Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/

[Intel-gfx] [PATCH v4 05/16] drm/i915/hdcp: Move HDCP enc status timeout to header

2020-10-27 Thread Anshuman Gupta
. It will be used by both HDCP{1.x,2.x} stream status timeout. Related: 'commit 7e90e8d0c0ea ("drm/i915: Increase timeout for Encrypt status change")' Cc: Ramalingam C Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 9 - drivers/gp

[Intel-gfx] [PATCH v4 04/16] drm/i915/hdcp: DP MST transcoder for link and stream

2020-10-27 Thread Anshuman Gupta
and HDCP 2.2 over DP MST on Gen12. Cc: Ramalingam C Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- .../gpu/drm/i915/display/intel_display_types.h| 2 ++ drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- drivers

[Intel-gfx] [PATCH v4 00/16] HDCP 2.2 and HDCP 1.4 Gen12 DP MST support

2020-10-27 Thread Anshuman Gupta
drm-intel. [PATCH v4 11/16] drm/hdcp: Max MST content streams has an Ack from drm-misc maintainer to merge it via dm-intel. Test-with: 20201023100709.5211-2-karthik@intel.com Anshuman Gupta (16): drm/i915/hdcp: Update CP property in update_pipe drm/i915/hdcp: Get conn while content_type

[Intel-gfx] [PATCH v4 02/16] drm/i915/hdcp: Get conn while content_type changed

2020-10-27 Thread Anshuman Gupta
Get DRM connector reference count while scheduling a prop work to avoid any possible destroy of DRM connector when it is in DRM_CONNECTOR_REGISTERED state. Fixes: a6597faa2d59 ("drm/i915: Protect workers against disappearing connectors") Cc: Sean Paul Cc: Ramalingam C Signed-off-by

Re: [Intel-gfx] [PATCH 05/13] drm/i915/pps: rename edp_panel_* to intel_pps_*_unlocked

2020-12-28 Thread Anshuman Gupta
On 2020-12-22 at 20:19:45 +0530, Jani Nikula wrote: > Follow the usual naming pattern for functions, both for the prefix and > the _unlocked suffix for functions that expect the lock to be held when IMHO referring * pps lock * would be good in commit log. Thanks, Anshuman. > calling. > >

Re: [Intel-gfx] [PATCH 03/13] drm/i915/pps: rename intel_edp_backlight_* to intel_pps_backlight_*

2020-12-28 Thread Anshuman Gupta
On 2020-12-22 at 20:19:43 +0530, Jani Nikula wrote: > Follow the usual naming pattern for functions. > > Signed-off-by: Jani Nikula Looks good to me. Reviewed-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/display/intel_dp.c | 6 +++--- > drivers/gpu/drm/i915/displa

Re: [Intel-gfx] [PATCH 04/13] drm/i915/pps: rename intel_edp_panel_* to intel_pps_*

2020-12-28 Thread Anshuman Gupta
On 2020-12-22 at 20:19:44 +0530, Jani Nikula wrote: > Follow the usual naming pattern for functions. We don't need to repeat > "panel" here. > > Follow the usual naming pattern for functions. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 8 >

[Intel-gfx] [RFC 0/1] converging intel igfx and dgfx opregion

2021-01-05 Thread Anshuman Gupta
to get the oprom. Let's first read the oprom by PCI interface and in case of failure fall back to SPI interface. Requesting community to provide suggestion and feedback on above proposal. Thanks, Anshuman Gupta. -- 2.26.2 ___ Intel-gfx mailing list Int

[Intel-gfx] [RFC] drm/i915/pps: Add PPS power domain

2021-01-04 Thread Anshuman Gupta
wells as the platforms need AUX power in order to access PPS registers supports eDP only on PORT_A. Cc: Imre Deak Cc: Jani Nikula Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_display_power.c | 7 +++ drivers/gpu/drm/i915/display/intel_display_power.h | 1 + drivers/gpu

[Intel-gfx] [PATCH v9 00/19] HDCP 2.2 and HDCP 1.4 Gen12 DP MST support

2021-01-11 Thread Anshuman Gupta
an Ack from Tomas to merge it via drm-intel. [PATCH v9 13/19] drm/hdcp: Max MST content streams has an Ack from drm-misc maintainer to merge it via drm-intel. Test-with: 20201126050320.2434-2-karthik@intel.com Anshuman Gupta (19): drm/i915/hdcp: Update CP property in update_pipe drm/i915

[Intel-gfx] [PATCH v9 01/19] drm/i915/hdcp: Update CP property in update_pipe

2021-01-11 Thread Anshuman Gupta
EGISTERED WARN_ON. v3: - Commit log improvement. [Uma] - Added a comment before scheduling prop_work. [Uma] Fixes: 33f9a623bfc6 ("drm/i915/hdcp: Update CP as per the kernel internal state") Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Sign

[Intel-gfx] [PATCH v9 08/19] drm/i915/hdcp: Configure HDCP1.4 MST steram encryption status

2021-01-11 Thread Anshuman Gupta
for connector detail in DMESG. [Ram] - comments improvement. [Ram] Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 38 +++ 1 file changed, 25 insertions(+), 13

[Intel-gfx] [PATCH v9 09/19] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2021-01-11 Thread Anshuman Gupta
Enable HDCP 1.4 over DP MST for Gen12. v2: - Enable HDCP for <= Gen12 platforms. [Ram] v3: - Connector detials in debug msg. [Ram] Cc: Ramalingam C Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 7 +++

[Intel-gfx] [PATCH v9 02/19] drm/i915/hdcp: Get conn while content_type changed

2021-01-11 Thread Anshuman Gupta
ma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c index ee

[Intel-gfx] [PATCH v9 03/19] drm/i915/hotplug: Handle CP_IRQ for DP-MST

2021-01-11 Thread Anshuman Gupta
Handle CP_IRQ in DEVICE_SERVICE_IRQ_VECTOR_ESI0 It requires to call intel_hdcp_handle_cp_irq() in case of CP_IRQ is triggered by a sink in DP-MST topology. Cc: "Ville Syrjälä" Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by

[Intel-gfx] [PATCH v9 04/19] drm/i915/hdcp: No HDCP when encoder is't initialized

2021-01-11 Thread Anshuman Gupta
ik B S Reviewed-by: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c index b9d8825e2bb1..7d63e9495956

[Intel-gfx] [PATCH v9 05/19] drm/i915/hdcp: DP MST transcoder for link and stream

2021-01-11 Thread Anshuman Gupta
and HDCP 2.2 over DP MST on Gen12. Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- .../gpu/drm/i915/display/intel_display_types.h| 2 ++ drivers/gpu/drm

[Intel-gfx] [PATCH v9 06/19] drm/i915/hdcp: Move HDCP enc status timeout to header

2021-01-11 Thread Anshuman Gupta
. It will be used by both HDCP{1.x,2.x} stream status timeout. Related: 'commit 7e90e8d0c0ea ("drm/i915: Increase timeout for Encrypt status change")' Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i9

[Intel-gfx] [PATCH v9 13/19] drm/hdcp: Max MST content streams

2021-01-11 Thread Anshuman Gupta
Let's define Maximum MST content streams up to four generically which can be supported by modern display controllers. Cc: Sean Paul Cc: Ramalingam C Acked-by: Maarten Lankhorst Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta

[Intel-gfx] [PATCH v9 11/19] drm/i915/hdcp: Encapsulate hdcp_port_data to dig_port

2021-01-11 Thread Anshuman Gupta
Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 + .../drm/i915/display/intel_display_types.h| 5 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 56 +++ 3 files changed, 39 insertions(+), 24 deletions(-) diff

[Intel-gfx] [PATCH v9 12/19] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len

2021-01-11 Thread Anshuman Gupta
Acked-by: Tomas Winkler Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/misc/mei/hdcp/mei_hdcp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c b/drivers/misc/mei/hdcp

[Intel-gfx] [PATCH v9 07/19] drm/i915/hdcp: HDCP stream encryption support

2021-01-11 Thread Anshuman Gupta
C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 10 +-- drivers/gpu/drm/i915/display/intel_ddi.h | 6 +- .../drm/i915/display/intel_display_types.h| 4 + drivers/gpu/drm

[Intel-gfx] [PATCH v9 10/19] drm/i915/hdcp: Pass dig_port to intel_hdcp_init

2021-01-11 Thread Anshuman Gupta
Pass dig_port as an argument to intel_hdcp_init() and intel_hdcp2_init(). This will be required for HDCP 2.2 stream encryption. Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v9 14/19] drm/i915/hdcp: MST streams support in hdcp port_data

2021-01-11 Thread Anshuman Gupta
-by: Anshuman Gupta --- .../drm/i915/display/intel_display_types.h| 4 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 113 +++--- 2 files changed, 102 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v9 15/19] drm/i915/hdcp: Pass connector to check_2_2_link

2021-01-11 Thread Anshuman Gupta
-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_display_types.h | 3 ++- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 3 ++- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- drivers/gpu/drm/i915/display/intel_hdmi.c

[Intel-gfx] [PATCH v9 16/19] drm/i915/hdcp: Add HDCP 2.2 stream register

2021-01-11 Thread Anshuman Gupta
-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/i915_reg.h | 39 + 1 file changed, 39 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index b448e507d41e..cade0a7a97b2 100644

[Intel-gfx] [PATCH v9 17/19] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks

2021-01-11 Thread Anshuman Gupta
redundant link check. [Ram] v4: - use pipe instead of port to access HDCP2_STREAM_STATUS Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- .../drm/i915/display/intel_display_types.h| 4 + drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v9 18/19] drm/i915/hdcp: Configure HDCP2.2 MST steram encryption status

2021-01-11 Thread Anshuman Gupta
Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 51 ++- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v9 19/19] drm/i915/hdcp: Enable HDCP 2.2 MST support

2021-01-11 Thread Anshuman Gupta
Enable HDCP 2.2 MST support till Gen12. Cc: Ramalingam C Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c

[Intel-gfx] [RFC-v21 13/13] drm/i915/pxp: Add plane decryption support

2021-01-17 Thread Anshuman Gupta
gem_object_metadata. [Krishna] v3: - intel_pxp_gem_object_status() API changes. Cc: Bommu Krishnaiah Cc: Huang Sean Z Cc: Gaurav Kumar Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_sprite.c | 21 ++--- drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for HDCP misc fixes (rev2)

2021-01-22 Thread Anshuman Gupta
On 2021-01-20 at 18:46:50 +, Patchwork wrote: > == Series Details == > > Series: HDCP misc fixes (rev2) > URL : https://patchwork.freedesktop.org/series/86025/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_9650_full -> Patchwork_19422_full >

[Intel-gfx] [PATCH v2 2/2] drm/i915/hdcp: Fix uninitialized symbol

2021-01-20 Thread Anshuman Gupta
ted-by: Dan Carpenter Reviewed-by: Ankit Nautiyal Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdc

Re: [Intel-gfx] [PATCH v2 01/17] drm/i915/pps: abstract panel power sequencer from intel_dp.c

2021-01-13 Thread Anshuman Gupta
to add a vlv_get_dpll() helper to get at the vlv/chv dpll from > pps code. > > v2: Rebase. > > Signed-off-by: Jani Nikula Looks Good to me. Reviewed-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/Makefile |1 + > drivers/gpu/drm/i915/display/inte

[Intel-gfx] [PATCH v2 1/2] drm/i915/hdcp: Fix WARN_ON(data->k > INTEL_NUM_PIPES)

2021-01-18 Thread Anshuman Gupta
-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c index db8dff2eeb0a..581ccb038b87 100644 --- a/drivers/gpu/drm/i915/display/intel_hdcp.c +++ b

[Intel-gfx] [PATCH v2 2/2] drm/i915/hdcp: Fix uninitialized symbol

2021-01-18 Thread Anshuman Gupta
Move (num_hdcp_streams > 0) condition to stream_encryption() code block, where it actually belongs. This fixes the static analysis error of uninitialized symbol 'ret'. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 20 ++-- 1 f

[Intel-gfx] [PATCH v2 0/2] HDCP misc fixes

2021-01-18 Thread Anshuman Gupta
Anshuman Gupta (2): drm/i915/hdcp: Fix WARN_ON(data->k > INTEL_NUM_PIPES) drm/i915/hdcp: Fix uninitialized symbol drivers/gpu/drm/i915/display/intel_hdcp.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) --

[Intel-gfx] [PATCH 0/2] HDCP misc fixes

2021-01-15 Thread Anshuman Gupta
HDCP misc fixes. Anshuman Gupta (2): drm/i915/hdcp: Fix WARN_ON(data->k > INTEL_NUM_PIPES) drm/i915/hdcp: Fix error: uninitialized symbol 'ret'. drivers/gpu/drm/i915/display/intel_hdcp.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) --

[Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Fix WARN_ON(data->k > INTEL_NUM_PIPES)

2021-01-15 Thread Anshuman Gupta
Initialize no. of streams transmitted on a port to zero such that intel_hdcp_required_content_stream() can prepared the content stream after subsequemt attmept to enable hdcp after a HDCP failure. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 2

[Intel-gfx] [PATCH 2/2] drm/i915/hdcp: Fix error: uninitialized symbol 'ret'.

2021-01-15 Thread Anshuman Gupta
Move (num_hdcp_streams > 0) condition to stream_encryption() code block, where it actually belongs. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/driv

Re: [Intel-gfx] [PATCH v2 14/17] drm/i915/pps: refactor init abstractions

2021-01-13 Thread Anshuman Gupta
s_encoder_reset(struct intel_dp > *intel_dp) >* Reinit the power sequencer, in case BIOS did something nasty IMHO above comment would need a improvement, or nuke it ? as intel_pps_encoder_reset() will also get called from intel_pps_init()

Re: [Intel-gfx] [PATCH v2 05/17] drm/i915/pps: rename edp_panel_* to intel_pps_*_unlocked

2021-01-13 Thread Anshuman Gupta
On 2021-01-08 at 19:44:13 +0200, Jani Nikula wrote: > Follow the usual naming pattern for functions, both for the prefix and > the _unlocked suffix for functions that expect the lock to be held when > calling. No functional changes. > > Signed-off-by: Jani Nikula LGTM. Review

Re: [Intel-gfx] [PATCH v2 04/17] drm/i915/pps: rename intel_edp_panel_* to intel_pps_*

2021-01-13 Thread Anshuman Gupta
On 2021-01-08 at 19:44:12 +0200, Jani Nikula wrote: > Follow the usual naming pattern for functions. We don't need to repeat > "panel" here. No functional changes. > > v2: Fix comment (Anshuman) > > Signed-off-by: Jani Nikula LGTM. Reviewed-by: Anshuman Gupta &

Re: [Intel-gfx] [PATCH v2 06/17] drm/i915/pps: abstract intel_pps_vdd_off_sync

2021-01-13 Thread Anshuman Gupta
On 2021-01-08 at 19:44:14 +0200, Jani Nikula wrote: > Add a locked version of intel_pps_vdd_off_sync_unlocked() that does > everything the callers expect it to. No functional changes. > > v2: Fix typo (Anshuman) > > Signed-off-by: Jani Nikula LGTM. Reviewed-by: Anshuman Gupta

Re: [Intel-gfx] [PATCH v2 15/17] drm/i915/pps: move pps code over from intel_display.c and refactor

2021-01-13 Thread Anshuman Gupta
On 2021-01-08 at 19:44:23 +0200, Jani Nikula wrote: > intel_display.c has some pps functions that belong to intel_pps.c. Move > them over. > > While at it, refactor the duplicate intel_pps_init() in intel_display.c > into an orthogonal intel_pps_setup() in intel_pps.c, and call it earlier > in

Re: [Intel-gfx] [PATCH v2 16/17] drm/i915/dp: abstract struct intel_dp pps members to a sub-struct

2021-01-13 Thread Anshuman Gupta
tel_dp->pps.backlight_on_delay); > seq_printf(m, "Backlight off delay: %d\n", > -intel_dp->backlight_off_delay); > +intel_dp->pps.backlight_off_delay); Not related to this patch but can we add panel_power_cycle_delay too in the debugfs, that is also use

Re: [Intel-gfx] [PATCH] drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST

2021-01-13 Thread Anshuman Gupta
pport this call for HDCP 1.4 (namely Synaptics and Realtek). > > I had considered creating a quirk for this, but I think it's more > prudent to just disable the check entirely since I don't have an idea > how widespread support is. May be we can remove it from the link check and can re

Re: [Intel-gfx] [PATCH v2 13/17] drm/i915/pps: rename intel_dp_init_panel_power_sequencer* functions

2021-01-13 Thread Anshuman Gupta
panel_power_sequencer_registers -> pps_init_registers > - intel_dp_init_panel_power_timestamps -> pps_init_timestamps > > as this is what the functions do. Skip the intel_ prefix here to > emphasize these are static and not exported. > > No functional changes. > >

<    2   3   4   5   6   7   8   9   >