comments and add comments for a limit of supporting of
> a single pipe PSR
You missed to addressed few comment.
Is drrs_status_per_crtc debugfs print is not required anymore?
Also please use drm_{dbg,warn} at every place in this patch.
Thanks,
Anshuman Gupta.
>
> Signed-off-by: Gwan-gyeong
wells as the platforms need AUX power in order to access PPS
registers supports eDP only on PORT_A.
v2:
- Fixed missed POWER_DOMAIN_PPS in pps_unlock().
Cc: Imre Deak
Cc: Jani Nikula
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_display_power.c | 7 +++
drivers/gpu/drm
On 2021-01-29 at 14:38:23 +, Patchwork wrote:
> == Series Details ==
>
> Series: disable the QSES check for HDCP2.2 over MST (rev2)
> URL : https://patchwork.freedesktop.org/series/86375/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_9697_full ->
Floating a stand-alone patch form the below series in order to
merge it.
https://patchwork.freedesktop.org/series/86325/
Juston Li (1):
drm/i915/hdcp: disable the QSES check for HDCP2.2 over MST
drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 31 +---
1 file changed, 1
a better idea of how widely supported
QSES is and how to support it optionally.
Signed-off-by: Juston Li
Reviewed-by: Anshuman Gupta
Signed-off-by: Anshuman Gupta
Link:
https://patchwork.freedesktop.org/patch/msgid/20210127065034.2501119-4-juston...@intel.com
---
drivers/gpu/drm/i915/display
DP-MST connector encoder initializes at modeset
Adding a connector->encoder NULL check in order to
avoid any NULL pointer dereference.
intel_hdcp_enable() already handle this but debugfs
can also invoke the intel_{hdcp,hdcp2_capable}.
Handling it gracefully.
Signed-off-by: Anshuman Gu
get cpu_trancoder from intel_psr, therefore we don't need to
> pass intel_crtc_state to this function.
>
> Cc: José Roberto de Souza
> Signed-off-by: Gwan-gyeong Mun
> Signed-off-by: Matt Roper
Reviewed-by: Anshuman Gupta
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 7
at least AUX power wells require this to do a power well->PHY
> lookup.
>
> Signed-off-by: Imre Deak
Looks good to me.
Reviewed-by: Anshuman Gupta
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i9
e doc, queue_delayed_work will return false only when
work was in queue after dequeued put_async_work() it should return true ?
Thanks,
Anshuman Gupta.
>
> Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/3421
> Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/2289
>
v2 link: https://patchwork.freedesktop.org/series/77866/
Anshuman Gupta (2):
drm/i915/dg1: Adjust the AUDIO power domain
drm/i915/display: Use AUDIO_VERBS for crtc power domain mask
drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/display/intel_display.c | 2
-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/display/intel_display.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
b/drivers/gpu/drm/i915/display/intel_ddi.c
index 3d8918674153
DG1 and XE_PLD platforms has Audio MMIO/VERBS lies in PG0 power
well. Adjusting the power domain accordingly to
POWER_DOMAIN_AUDIO_VERBS for audio detection and POWER_DOMAIN_AUDIO
for audio playback.
Cc: Ville Syrjälä
Cc: Kai Vehmanen
Cc: Uma Shankar
Cc: Imre Deak
Signed-off-by: Anshuman
On 2021-05-26 at 20:07:29 +0530, Imre Deak wrote:
> On ADL_P the power well->PHY mapping doesn't follow the mapping on previous
> platforms, fix this up.
>
> While at it remove the redundant dev_priv param from
> icl_tc_phy_aux_ch().
Looks good to me.
Reviewed-by: Anshuman Gupt
Use POWER_DOMAIN_AUDIO_PLAYBACK to enable/disable
display audio codec power in intel_display_power_{get, put}
v1: Changes since RFC
- changed power domain names. [Imre]
Cc: Kai Vehmanen
Cc: Uma Shankar
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_audio.c | 4 ++--
1
} and TBT from DG1
power well and PW_3 power domains. [Imre]
- Fixed the order of powe wells , power domains and its
registration. [Imre]
Cc: Ville Syrjälä
Cc: Kai Vehmanen
Cc: Uma Shankar
Cc: Imre Deak
Signed-off-by: Anshuman Gupta
---
.../drm/i915/display/intel_display_power.c| 232
This revision has fixed review comment from Imre on RFC patch.
https://patchwork.freedesktop.org/series/90827/
Anshuman Gupta (3):
drm/i915/dg1: Adjust the AUDIO power domain
drm/i915/display: Use AUDIO_MMIO for crtc power domain mask
drm/i915/audio: Use AUDIO_PLAYBACK power domain
Vehmanen
Cc: Uma Shankar
Cc: Imre Deak
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/display/intel_display.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
b/drivers
This revision has fixed review comment from Imre on RFC patch.
https://patchwork.freedesktop.org/series/90827/
Anshuman Gupta (3):
drm/i915/dg1: Adjust the AUDIO power domain
drm/i915/display: Use AUDIO_MMIO for crtc power domain mask
drm/i915/audio: Use AUDIO_PLAYBACK power domain
PCHs used on
> > gen11 platforms") Cc: Matt Roper
> > Cc: Rodrigo Vivi
> > Cc: Imre Deak
> > Signed-off-by: Anshuman Gupta
> > ---
> >
> > .../drm/i915/display/intel_display_power.c| 16 +++---
> > drivers/gpu/drm/i915/i915
Extend i915_lpsp_capability sysfs to xelpd and future platforms.
Cc: Animesh Manna
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_display_debugfs.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
b/drivers/gpu
:
- removed RKL from comment and simplified condition. [Rodrigo]
Fixes: b896898c7369 ("drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11
platforms")
Cc: Matt Roper
Cc: Rodrigo Vivi
Cc: Imre Deak
Signed-off-by: Anshuman Gupta
Reviewed-by: Rodrigo Vivi
---
.../drm/i9
Earlier HDCP over MST support was added for TGL Platform.
Extending it to all future platfroms.
v2:
- Remove the platform check and commit log changes. [Jani]
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_dp_mst.c | 11 ---
1 file changed, 4 insertions(+), 7
Adding HDCP support over DP MST for Display13 Platforms.
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
b/drivers/gpu/drm/i915/display/intel_dp_mst.c
When protected sufaces has flipped and pxp session is disabled,
display black pixels by using plane color CTM correction.
v2:
- Display black pixels in aysnc flip too.
Cc: Ville Syrjälä
Cc: Gaurav Kumar
Cc: Shankar Uma
Signed-off-by: Anshuman Gupta
Signed-off-by: Daniele Ceraolo Spurio
Syrjälä
Signed-off-by: Anshuman Gupta
Signed-off-by: Daniele Ceraolo Spurio
---
.../gpu/drm/i915/display/intel_atomic_plane.c | 3 ++
drivers/gpu/drm/i915/display/intel_display.c | 5 +++
.../drm/i915/display/intel_display_types.h| 3 ++
.../drm/i915/display/skl_universal_plane.c| 32
B.Spec: 49231
Cc: Ville Syrjälä
Cc: Kai Vehmanen
Cc: Uma Shankar
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_display.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c
b/drivers/gpu/drm/i915
Show only connector hdcp capability in i915_display_info
instead of platform and sink.
There are some platforms which don't support HDCP 2.2
yet, those are not HDCP 2.2 capable but those platform
should show up the connector capability in i915_display_info.
Signed-off-by: Anshuman Gupta
ULL check in
i915_hdcp_sink_capability_show. [Imre]
Reviewed-by: Imre Deak
Signed-off-by: Anshuman Gupta
---
.../drm/i915/display/intel_display_debugfs.c| 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
ULL check in
i915_hdcp_sink_capability_show. [Imre]
Signed-off-by: Anshuman Gupta
---
.../gpu/drm/i915/display/intel_display_debugfs.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
b/drivers/gpu/drm/i
HDCP DP 2.2 errata is part of HDCP DP 2.3 specs
as well.
Anshuman Gupta (2):
drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 56 +---
include/drm/drm_hdcp.h
authentication
in case it timedout to read entire msg.
https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
Cc: Ramalingam C
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 56 +---
include/drm/drm_hdcp.h
Fix LC_Send_L_Prime message timeout to 16 as documented
in DP HDCP 2.2 errata page 3.
https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
Cc: Ramalingam C
Signed-off-by: Anshuman Gupta
---
include/drm/drm_hdcp.h | 2 +-
1 file changed, 1 insertion(+), 1
HDCP1_DEVICE_DOWNSTREAM bit to
detect a HDCP {1.x,2.x} mix mst topology.
Cc: Sean Paul
Cc: Ramalingam C
Signed-off-by: Anshuman Gupta
---
.../drm/i915/display/intel_display_types.h| 4 ++
drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 39 +++
drivers/gpu/drm/i915/display
HDCP DP 2.2 errata is part of HDCP DP 2.3 specs
as well.
Anshuman Gupta (2):
drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 45 ++--
include/drm/drm_hdcp.h
authentication
in case it timedout to read entire msg.
https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
v2:
- Removed redundant variable msg_can_timedout. [Ankit]
Cc: Ramalingam C
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 45
Fix LC_Send_L_Prime message timeout to 16 as documented
in DP HDCP 2.2 errata page 3.
https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
Cc: Ramalingam C
Reviewed-by: Ankit Nautiyal
Signed-off-by: Anshuman Gupta
---
include/drm/drm_hdcp.h | 2 +-
1 file
: b896898c7369 ("drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11
platforms")
Cc: Matt Roper
Cc: Rodrigo Vivi
Signed-off-by: Anshuman Gupta
---
.../drm/i915/display/intel_display_power.c| 18 +---
drivers/gpu/drm/i915/i915_irq.c | 21 --
:
- removed RKL from comment and simplified condition. [Rodrigo]
Fixes: b896898c7369 ("drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11
platforms")
Cc: Matt Roper
Cc: Rodrigo Vivi
Cc: Imre Deak
Signed-off-by: Anshuman Gupta
---
.../drm/i915/display/intel_display_power
Fix static analysis tool uninitialized symbol error.
Reported-by: kernel test robot
Reported-by: Dan Carpenter
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display
[1]
>[1]:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19809/shard-skl6/igt@kms_flip_tiling@flip-y-ti...@edp-1-pipe-c.html
Hi Lakshmi ,
Above CI-IGT failures are not related to this patch, this patch is just a
rebase and CI results were green at Rev1.
https://patchwork.fr
HDCP1_DEVICE_DOWNSTREAM bit to
detect a HDCP {1.x,2.x} mix mst topology.
Cc: Sean Paul
Cc: Ramalingam C
Signed-off-by: Anshuman Gupta
Reviewed-by: Ankit Nautiyal
Signed-off-by: Anshuman Gupta
---
.../drm/i915/display/intel_display_types.h| 4 ++
drivers/gpu/drm/i915/display/intel_dp_hdcp.c
Rebased.
Anshuman Gupta (3):
drm/i915/hdcp: HDCP2.2 MST Link failure recovery
drm/i915/hdcp: link hdcp2 recovery on link enc stopped
drm/i915/hdcp: return correct error code
drivers/gpu/drm/i915/display/intel_hdcp.c | 26 +--
1 file changed, 20 insertions(+), 6
it can enable port
authentication and encryption.
Cc: Ramalingam C
Reviewed-by: Ankit Nautiyal
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c
b
When stream encryption enabling fails due to Link encryption status
has stopped, prepare HDCP2 for recovery by disabling port authentication
and encryption such that it can re-attempt port authentication
and encryption.
Cc: Ramalingam C
Reviewed-by: Ankit Nautiyal
Signed-off-by: Anshuman Gupta
to port authentication and encryption.
Cc: Ramalingam C
Reviewed-by: Ankit Nautiyal
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c
b/drivers/gpu/drm/i915
it can enable port
authentication and encryption.
Cc: Ramalingam C
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c
b/drivers/gpu/drm/i915/display
When stream encryption {enable,disable} fails, prepare HDCP2 for
recovery by enabling port authentication and port encryption again.
Cc: Ramalingam C
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 17 ++---
1 file changed, 14 insertions(+), 3
to port authentication and encryption.
Cc: Ramalingam C
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c
b/drivers/gpu/drm/i915/display/intel_hdcp.c
index
Misc HDCP 2.2 MST fixes.
Anshuman Gupta (3):
drm/i915/hdcp: HDCP2.2 MST Link failure recovery
drm/i915/hdcp: recover link on stream enc enable/disable failure
drm/i915/hdcp: return correct error code
drivers/gpu/drm/i915/display/intel_hdcp.c | 30 +--
1 file changed
Misc HDCP 2.2 MST fixes.
Anshuman Gupta (3):
drm/i915/hdcp: HDCP2.2 MST Link failure recovery
drm/i915/hdcp: link hdcp2 recovery on link enc stopped
drm/i915/hdcp: return correct error code
drivers/gpu/drm/i915/display/intel_hdcp.c | 26 +--
1 file changed, 20
it can enable port
authentication and encryption.
Cc: Ramalingam C
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c
b/drivers/gpu/drm/i915/display
When stream encryption enabling fails due to Link encryption status
has stopped, prepare HDCP2 for recovery by disabling port authentication
and encryption such that it can re-attempt port authentication
and encryption.
Cc: Ramalingam C
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915
to port authentication and encryption.
Cc: Ramalingam C
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c
b/drivers/gpu/drm/i915/display/intel_hdcp.c
index
Fix static analysis tool uninitialized symbol error.
v2:
- use ktime_set(0, 0) instead to initialize to zero. [Ankit]
Reported-by: kernel test robot
Reported-by: Dan Carpenter
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 2 +-
1 file changed, 1 insertion
:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9761/shard-iclb6/igt@perf_...@cpu-hotplug.html
>[2]:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19664/shard-iclb7/igt@perf_...@cpu-hotplug.html
Hi Lakshmi ,
Above failure are not related to this series.
could you please
> [INCOMPLETE][1] +2 similar issues
> [1]: None
Above failures not related to HDCP failures.
Pushed the series to drm-intel-next.
Thanks for patch.
Br,
Anshuman Gupta.
>
>
> New tests
> -
>
> New tests have been introduced between CI_DRM_10537_full and
>
Extend i915_lpsp_capability debugfs to DG2,ADLP and future platforms.
v2: commit log modification.
Cc: Animesh Manna
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_display_debugfs.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/display
:
- removed RKL from comment and simplified condition. [Rodrigo]
Fixes: b896898c7369 ("drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11
platforms")
Cc: Matt Roper
Cc: Rodrigo Vivi
Cc: Imre Deak
Signed-off-by: Anshuman Gupta
Reviewed-by: Rodrigo Vivi
---
.../drm/i9
is failing.
Anshuman Gupta (1):
drm/i915: Tweaked Wa_14010685332 for all PCHs
.../drm/i915/display/intel_display_power.c| 16 +++---
drivers/gpu/drm/i915/i915_irq.c | 21 ---
2 files changed, 8 insertions(+), 29 deletions(-)
--
2.26.2
:
- removed RKL from comment and simplified condition. [Rodrigo]
Fixes: b896898c7369 ("drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11
platforms")
Cc: Matt Roper
Cc: Rodrigo Vivi
Cc: Imre Deak
Signed-off-by: Anshuman Gupta
Reviewed-by: Rodrigo Vivi
---
.../drm/i9
]
removed pointless code. [Ville]
v8 (Daniele): update PXP check
v9: move decrypt check after icl_check_nv12_planes() when overlays
have fb set (Juston)
Cc: Bommu Krishnaiah
Cc: Huang Sean Z
Cc: Gaurav Kumar
Cc: Ville Syrjälä
Signed-off-by: Anshuman Gupta
Signed-off-by: Daniele Ceraolo
): update pxp_is_borked check.
v5: rebase on top of v9 plane decryption moving the decrypt check
(Juston)
Cc: Ville Syrjälä
Cc: Gaurav Kumar
Cc: Shankar Uma
Signed-off-by: Anshuman Gupta
Signed-off-by: Daniele Ceraolo Spurio
Signed-off-by: Juston Li
Reviewed-by: Rodrigo Vivi
---
drivers/gpu
:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20792/shard-skl4/igt@kms_frontbuffer_track...@psr-rgb565-draw-blt.html
Hi Lakshmi,
This CI IGT failure is on unrelated platfrom and not realted to this patch.
Pushed to drm-intel-next, while pushing fixed a checkpatch
"W
Squashes the patchset to a single patch to avoid any
build failure.
Anshuman Gupta (1):
drm/i915/dg1: Adjust the AUDIO power domain
drivers/gpu/drm/i915/display/intel_audio.c| 4 +-
drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/display/intel_display.c
to avoid build failure.
Cc: Ville Syrjälä
Cc: Kai Vehmanen
Cc: Uma Shankar
Cc: Imre Deak
Reviewed-by: Imre Deak
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_audio.c| 4 +-
drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/display
:
- removed RKL from comment and simplified condition. [Rodrigo]
Fixes: b896898c7369 ("drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11
platforms")
Cc: Matt Roper
Cc: Rodrigo Vivi
Cc: Imre Deak
Signed-off-by: Anshuman Gupta
Reviewed-by: Rodrigo Vivi
---
.../drm/i9
NOTRUN -> [DMESG-WARN][1]
>[1]:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20792/fi-rkl-guc/igt@core_hotunp...@unbind-rebind.html
Hi Lakshmi ,
Above CI BAT failure is a unrealted failure(not realted to display), it
seems related to core power.
truct intel_hdcp *hdcp = >hdcp;
> int ret = 0, i, tries = 3;
>
> for (i = 0; i < tries && !dig_port->hdcp_auth_status; i++) {
> ret = hdcp2_authenticate_sink(connector);
> if (!ret) {
> + /* Stream which requires encryption */
to account for RxInfo being read
v5 looks good to me
Reviewed-by: Anshuman Gupta
>
> Changes in v4:
> - rebase and edit commit message
>
> Changes in v3:
> - remove comment
>
> Changes in v2:
> - remove unnecessary moving of drm_i915_private from patch 1
>
> Sign
measure_clocks() and prevent
miscalculation of engine tick cycles.
Suggested-by: Chris P Wilson
Signed-off-by: Anshuman Gupta
Reviewed-by: Badal Nilawar
---
drivers/gpu/drm/i915/gt/selftest_gt_pm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/selftest_gt_pm.c
On 2021-11-16 at 21:22:38 +0530, Tilak Tangudu wrote:
> v1: Enable runtime pm autosuspend by default for Gen12
> and later versions.
>
> v2: Enable runtime pm autosuspend by default for all
> platforms(Syrjala Ville)
>
> v3: Change commit message(Nikula Jani)
It would require to reorder the
() to calculate
correct engine ticks cycles.
Suggested-by: Chris P Wilson
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/gt/selftest_gt_pm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/selftest_gt_pm.c
b/drivers/gpu/drm/i915/gt/selftest_gt_pm.c
index
On 2021-11-30 at 18:29:54 +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/selftest: Disable IRQ for timestamp calculation (rev3)
> URL : https://patchwork.freedesktop.org/series/96853/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_10943_full ->
measure_clocks() and prevent
miscalculation of engine tick cycles.
v2:
- nuke preempt_{disable,enable}, as disable_local_irq()
disable the preemption. (Chris)
Cc: Chris P Wilson
Cc: Badal Nilawar
Cc: Ashutosh Dixit
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/gt/selftest_gt_pm.c
} and TBT from DG1
power well and PW_3 power domains. [Imre]
- Fixed the order of powe wells , power domains and its
registration. [Imre]
v2:
- Not allowe DC states when AUDIO_MMIO domain enabled. [Imre]
Cc: Ville Syrjälä
Cc: Kai Vehmanen
Cc: Uma Shankar
Cc: Imre Deak
Signed-off-by: Anshuman
Cc: Badal Nilawar
Cc: Uma Shankar
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_opregion.c | 179 +-
drivers/gpu/drm/i915/display/intel_opregion.h | 3 +
2 files changed, 134 insertions(+), 48 deletions(-)
diff --git a/drivers/gpu/drm/i915/display
Adding DGFX opregion dummy functions.
These will be setup later to support dgfx opregion.
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_opregion.c | 34 +--
1 file changed, 32 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display
Cc: Rodrigo Vivi
Cc: Uma Shankar
Cc: Badal Nilawar
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_opregion.c | 343 +-
drivers/gpu/drm/i915/display/intel_opregion.h | 1 +
2 files changed, 327 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm
This series setup DGFX OpRegion.
v2 has addressed the review comment to keep only opregion
abstraction stuff in "Abstract opregion function" opregion
patch and some other error handling as mentioned in the
patches commitlog.
Anshuman Gupta (6):
drm/i915/opregion: Add intel_opr
Adding intel_opregion_init() wrapper function, which encapsulates
intel_opregion_setup() and will be used for other opregion specific
initialization.
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_opregion.c | 12 +++-
drivers/gpu/drm/i915/display/intel_opregion.h
Cc: Jani Nikula
Cc: Uma Shankar
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_opregion.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c
b/drivers/gpu/drm/i915/display/intel_opregion.c
index
Add kzalloc NULL check for opreg_rvda pointer.
Cc: Jani Nikula
Cc: Uma Shankar
Cc: Rodrigo Vivi
Reviewed-by: Uma Shankar
Reviewed-by: Badal Nilawar
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_opregion.c | 22 ++-
1 file changed, 21 insertions(+), 1 delet
() in
intel_dgfx_alloc_opregion(), and added necessary
credit to Manasi.
PCI Firmware Spec: ID:12886
https://pcisig.com/specifications
Cc: Jani Nikula
Cc: Rodrigo Vivi
Cc: Uma Shankar
Cc: Badal Nilawar
Signed-off-by: Manasi Navare
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_opregion.c | 339
Add kzalloc NULL check for opreg_rvda pointer.
v3:
- Added kmemdup() insead of kzalloc() + memcpy() in
intel_dgfx_alloc_rvda(), and added necessary
credit to Manasi.
Cc: Jani Nikula
Cc: Uma Shankar
Cc: Rodrigo Vivi
Cc: Badal Nilawar
Signed-off-by: Manasi Navare
Signed-off-by: Anshuman Gu
This series setup DGFX OpRegion.
v2 has addressed the review comment to keep only opregion
abstraction stuff in "Abstract opregion function" opregion
patch and some other error handling as mentioned in the
patches commitlog.
v3 has addressed review comment from Manasi.
Anshuma
Adding intel_opregion_init() wrapper function, which encapsulates
intel_opregion_setup() and will be used for other opregion specific
initialization.
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_opregion.c | 12 +++-
drivers/gpu/drm/i915/display/intel_opregion.h
to Manasi for static analysis fix around
drm_WARN_ON(>drm, !opregion->asls || !opregion->header)
Cc: Jani Nikula
Cc: Rodrigo Vivi
Cc: Badal Nilawar
Cc: Uma Shankar
Signed-off-by: Manasi Navare
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_opregio
Adding DGFX opregion dummy functions.
These will be setup later to support dgfx opregion.
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_opregion.c | 34 +--
1 file changed, 32 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display
Cc: Jani Nikula
Cc: Uma Shankar
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_opregion.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c
b/drivers/gpu/drm/i915/display/intel_opregion.c
index
but there are runtime active children.
Dump i915 child's runtime pm status to debug such
i915 runtime suspend issues.
Cc: Chris Wilson
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/i915_debugfs.c | 38 +
1 file changed, 38 insertions(+)
diff --git a/drivers/gpu/drm/i915
but there are runtime active children.
Dump i915 child's runtime pm status to debug such
i915 runtime suspend issues.
v2:
- Added const array of rpm_status strings to avoid switch. [Ashutosh]
Cc: Chris Wilson
Reviewed-by: Badal Nilawar
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/i915_debugfs.c
On 2022-03-16 at 11:25:33 +0200, Jani Nikula wrote:
> On Sun, 20 Feb 2022, Anshuman Gupta wrote:
> > Abstract opregion operations like get opregion base, get rvda and
> > opregion cleanup in form of i915_opregion_ops.
> > This will be required to converge igfx and dgfx
This series setup DGFX OpRegion.
Anshuman Gupta (4):
drm/i915/opregion: Abstract opregion function
drm/i915/opregion: Register opreg func only for disp parts
drm/i915/dgfx: OPROM OpRegion Setup
drm/i915/dgfx: Get VBT from rvda
drivers/gpu/drm/i915/display/intel_opregion.c | 533
: Rodrigo Vivi
Cc: Badal Nilawar
Cc: Uma Shankar
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_opregion.c | 215 ++
drivers/gpu/drm/i915/display/intel_opregion.h | 8 +-
drivers/gpu/drm/i915/i915_driver.c| 2 +-
3 files changed, 172 insertions
It need to register opregion_func only for graphics sku
which has display. Use HAS_DISPLAY() to register
opregion_func.
Cc: Badal Nilawar
Cc: Jani Nikula
Cc: Uma Shankar
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_opregion.c | 7 +--
1 file changed, 5 insertions
Signature.
After successful sanity check, driver will consume the OPROM
config data to get opreg and vbt accordingly.
PCI Firmware Spec: ID:12886
https://pcisig.com/specifications
Cc: Jani Nikula
Cc: Rodrigo Vivi
Cc: Uma Shankar
Cc: Badal Nilawar
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm
ani Nikula
Cc: Uma Shankar
Cc: Rodrigo Vivi
Cc: Badal Nilawar
Signed-off-by: Anshuman Gupta
---
drivers/gpu/drm/i915/display/intel_opregion.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c
b/drivers/gpu/drm/i
On 2022-03-15 at 05:27:39 +0530, Patchwork wrote:
Pushed to drm-intel-next.
Thanks for review and patch.
Br,
Anshuman Gupta.
>Patch Details
>
>Series: drm/i915/pmu: Drop redundant IS_VALLEYVIEW check in __get_rc6()
>(rev2)
>URL: [1]https://patchwork.freedesktop.or
SDV(i915))
> + return intel_uncore_read(uncore, XEHPSDV_RP_STATE_CAP);
> + else if (IS_GEN9_LP(i915))
> + return intel_uncore_read(uncore, BXT_RP_STATE_CAP);
> + else
> + return intel_uncore_read(uncore, GEN6_RP_STATE_CAP);
> +}
> +
On 2022-04-07 at 09:44:48 +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/rps: Centralize computation of freq caps (rev6)
> URL : https://patchwork.freedesktop.org/series/101606/
> State : success
Pushed to drm-intel-gt-next.
Thanks for patch and review.
Br,
Anshuman.
>
>
701 - 800 of 884 matches
Mail list logo
