[Intel-gfx] [PATCH 06/11] drm/i915/guc: Extract param logic form guc_init_fw()

tel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti

[Intel-gfx] [PATCH 10/11] drm/i915/uc: Add params for specifying firmware

n.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> --- drivers/gpu/drm/i915/i915_params.c

[Intel-gfx] [PATCH 07/11] drm/i915/guc: Simplify intel_guc_init_hw()

o <michal.wajdec...@intel.com> Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.inte

[Intel-gfx] [PATCH 09/11] drm/i915/uc: Separate firmware selection and preparation

Winiarski <michal.winiar...@intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> --- drivers/gpu/drm/i915/intel_guc_loader.c | 14 +---

[Intel-gfx] [PATCH 08/11] drm/i915/uc: Simplify firmware path handling

..@intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Tvrtko Ursulin <tvrtko.ursu...@intel.com> --- drivers/gpu/drm/i915/intel_guc_loader.c | 36 ++---

[Intel-gfx] [PATCH 04/11] drm/i915/uc: Move intel_uc_fw_fetch() to intel_uc.c

to the fail label. v2: remove second declaration, reorder (M. Wajdeczko) v3: non-trivial rebase v4: remove obj cleanup in the fail scenario (C. Wilson) Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Signed-off-by: Arkadiusz Hiler &

[Intel-gfx] [PATCH 03/11] drm/i915/uc: Rename intel_?uc_{setup, load}() to _init_hw()

hal.wajdec...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> --- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/intel_guc_loader.c | 44 -

[Intel-gfx] [PATCH 05/11] drm/i915/uc: Introduce intel_uc_init_fw()

ski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> --- drivers/gpu/drm/i915/i915_drv.c | 3 +-- drivers/gpu/drm/i915/intel_guc_loader.c | 30 ---

[Intel-gfx] [PATCH 02/11] drm/i915/huc: Add huc_to_i915

Used to obtain "dev_priv" from huc struct pointer. We already have similar thing for guc. Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Michal Wajdeczko <michal.wajdec...@intel.com> --- dri

[Intel-gfx] [PATCH 11/11] HAX enable GuC for CI

--- drivers/gpu/drm/i915/i915_params.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index b6a7e36..9dcc8a0 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_params.c

[Intel-gfx] [PATCH v6] drm/i915/guc: Simplify intel_guc_init_hw()

ele Ceraolo Spurio <daniele.ceraolospu...@intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/intel_guc_loader.c | 144 +++--

[Intel-gfx] [PATCH 02/10] drm/i915/huc: Add huc_to_i915

Used to obtain "dev_priv" from huc struct pointer. We already have similar thing for guc. Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Michal Wajdeczko <michal.wajdec...@intel.com> --- dri

[Intel-gfx] [PATCH 06/10] drm/i915/guc: Extract param logic form guc_init_fw()

tel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti

[Intel-gfx] [PATCH 05/10] drm/i915/uc: Introduce intel_uc_init_fw()

ski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> --- drivers/gpu/drm/i915/i915_drv.c | 3 +-- drivers/gpu/drm/i915/intel_guc_loader.c | 30 ---

[Intel-gfx] [PATCH 04/10] drm/i915/uc: Move intel_uc_fw_fetch() to intel_uc.c

to the fail label. v2: remove second declaration, reorder (M. Wajdeczko) v3: non-trivial rebase v4: remove obj cleanup in the fail scenario (C. Wilson) Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Signed-off-by: Arkadiusz Hiler &

[Intel-gfx] [PATCH 08/10] drm/i915/uc: Simplify firmware path handling

nen) v5: non-trivial rebase Cc: Anusha Srivatsa <anusha.sriva...@intel.com> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com> Cc: Michal Winiarski <michal.winiar...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel

[Intel-gfx] [PATCH 09/10] drm/i915/uc: Separate firmware selection and preparation

Winiarski <michal.winiar...@intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> --- drivers/gpu/drm/i915/intel_guc_loader.c | 14 +---

[Intel-gfx] [PATCH 07/10] drm/i915/guc: Simplify intel_guc_init_hw()

ele Ceraolo Spurio <daniele.ceraolospu...@intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/intel_guc_loader.c | 147 +++---

[Intel-gfx] [PATCH 03/10] drm/i915/uc: Rename intel_?uc_{setup, load}() to _init_hw()

hal.wajdec...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> --- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/intel_guc_loader.c | 44 -

[Intel-gfx] [PATCH 10/10] drm/i915/uc: Add params for specifying firmware

n.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/i915_params.c | 10 ++ drivers/gpu/drm/i915/i915_params.h

[Intel-gfx] [PATCH v7 00/10] GuC Scrub vol. 1

and guc firmware path, separate fw select step from actual prepare v6: feedback + pushed a couple of patches with r-b down the stack v7: reorder, rename, rebase Arkadiusz Hiler (10): drm/i915/uc: Drop superfluous externs in intel_uc.h drm/i915/huc: Add huc_to_i915 drm/i915/uc: Rename intel_?uc_

[Intel-gfx] [PATCH 01/10] drm/i915/uc: Drop superfluous externs in intel_uc.h

Externs are implicit and we generally try to avoid them. Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> --- drivers/gpu/drm/i915/intel_uc.h | 12 ++

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for GuC Scrub vol. 1 (rev8)

On Thu, Mar 02, 2017 at 06:02:09PM +, Patchwork wrote: > == Series Details == > > Series: GuC Scrub vol. 1 (rev8) > URL : https://patchwork.freedesktop.org/series/16856/ > State : failure > > == Summary == > > CC [M] drivers/gpu/drm/i915/gvt/execlist.o > LD

[Intel-gfx] [PATCH] drm/i915/uc: Move intel_uc_fw_fetch() to intel_uc.c

to the fail label. v2: remove second declaration, reorder (M. Wajdeczko) v3: non-trivial rebase v4: remove obj cleanup in the fail scenario (C. Wilson) Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Signed-off-by: Arkadiusz Hiler &

[Intel-gfx] [PATCH 01/10] drm/i915/uc: Rename intel_?uc_{setup, load}() to _init_hw()

ris Wilson <ch...@chris-wilson.co.uk> Cc: Michal Winiarski <michal.winiar...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Revi

[Intel-gfx] [PATCH 04/10] drm/i915/uc: Move intel_uc_fw_fetch() to intel_uc.c

The file fits better. Additionally rename it to intel_uc_prepare_fw(), as the function does more than simple fetch. v2: remove second declaration, reorder (M. Wajdeczko) Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> ---

[Intel-gfx] [PATCH v6 00/10] GuC Scrub vol. 1

step from actual prepare v6: feedback + pushed a couple of patches with r-b down the stack Arkadiusz Hiler (10): drm/i915/uc: Rename intel_?uc_{setup,load}() to _init_hw() drm/i915/uc: Drop superfluous externs in intel_uc.h drm/i915/huc: Add huc_to_i915 drm/i915/uc: Move intel_uc_fw_fetch

[Intel-gfx] [PATCH 03/10] drm/i915/huc: Add huc_to_i915

Used to obtain "dev_priv" from huc struct pointer. We already have similar thing for guc. Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Michal Wajdeczko <michal.wajdec...@intel.com> --- dri

[Intel-gfx] [PATCH 08/10] drm/i915/uc: Simplify firmware path handling

nen) Cc: Anusha Srivatsa <anusha.sriva...@intel.com> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com> Cc: Michal Winiarski <michal.winiar...@intel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-

[Intel-gfx] [PATCH 06/10] drm/i915/guc: Extract param logic form guc_init_fw()

tel.com> Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti

[Intel-gfx] [PATCH 07/10] drm/i915/guc: Simplify intel_guc_init_hw()

ele Ceraolo Spurio <daniele.ceraolospu...@intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/intel_guc_loader.c | 147 +++---

[Intel-gfx] [PATCH 09/10] drm/i915/uc: Separate firmware selection and preparation

Winiarski <michal.winiar...@intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> --- drivers/gpu/drm/i915/intel_guc_loader.c | 14 +---

[Intel-gfx] [PATCH 05/10] drm/i915/uc: Introduce intel_uc_init_fw()

intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Reviewed-by: Michal Wajdeczko <michal.wajdec...@intel.com> --- drivers/gpu/drm/i915/i915_drv.c | 3 +-- dr

[Intel-gfx] [PATCH 10/10] drm/i915/uc: Add params for specifying firmware

n.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Cc: Michal Winiarski <michal.winiar...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/i915_params.c | 10 ++ drivers/gpu/drm/i915/i915_params.h

Re: [Intel-gfx] [PATCH 10/10] drm/i915/uc: Add params for specifying firmware

On Wed, Mar 08, 2017 at 02:19:48AM +0100, Srivatsa, Anusha wrote: > > > >-Original Message- > >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > >Arkadiusz Hiler > >Sent: Tuesday, March 7, 2017 7:25 AM > >To: intel-

Re: [Intel-gfx] [PATCH 10/10] drm/i915/uc: Add params for specifying firmware

On Wed, Mar 08, 2017 at 11:23:36AM +0200, Jani Nikula wrote: > On Wed, 08 Mar 2017, "Srivatsa, Anusha" <anusha.sriva...@intel.com> wrote: > >>-Original Message- > >>From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > &g

Re: [Intel-gfx] [PATCH i-g-t] tests: kms_pipe_color: only test existing properties

vel color management") > Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Pushed with the beginning of the commit message changed to "test/kms_pipe_color: Only..." and a note

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_debugfs: Prevent compiler warning on unchecked printf format

s > 64. I have no clue why we > care about the padding size (crc_size), but since this was added > recently, I'd rather leave it alone. > > Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk> Reviewed-by: Arkadiusz Hiler &l

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_busy: Only test against one engine

Wilson <ch...@chris-wilson.co.uk> > Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com> > Acked-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > Signed-off-by: Da

Re: [Intel-gfx] [PATCH i-g-t] tests/pm_rpm: Use the quick mode by default

; > Cc: Paulo Zanoni <paulo.r.zan...@intel.com> > Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> > --- > tests/pm_rpm.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [Intel-gfx] [PATCH i-g-t] configure.ac: Try to find XMLRPC with xmlrpc-c-config if pkg-config fails

On Fri, Aug 04, 2017 at 12:15:18PM +0300, Arkadiusz Hiler wrote: > On Thu, Aug 03, 2017 at 07:35:33PM +0200, Daniel Vetter wrote: > > On Thu, Aug 03, 2017 at 04:34:45PM +0300, Petri Latvala wrote: > > > Debian and Ubuntu have XMLRPC packages without pkg-config files. Let's >

Re: [Intel-gfx] [PATCH i-g-t] configure.ac: Try to find XMLRPC with xmlrpc-c-config if pkg-config fails

On Thu, Aug 03, 2017 at 07:35:33PM +0200, Daniel Vetter wrote: > On Thu, Aug 03, 2017 at 04:34:45PM +0300, Petri Latvala wrote: > > Debian and Ubuntu have XMLRPC packages without pkg-config files. Let's > > do automatically what the user would anyway do manually. > > > > Signed-off-by: Petri

Re: [Intel-gfx] [PATCH i-g-t] tests/drv_module_reload: Fix running single tests

aniel Vetter <daniel.vet...@intel.com> Tested-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> -- Cheers, Arek ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [RFC i-g-t] tests/gem_exec_basic: Documentation for subtests

On Wed, Aug 09, 2017 at 10:00:16AM -0700, Belgaumkar, Vinay wrote: > > > On 8/9/2017 7:32 AM, Arkadiusz Hiler wrote: > > On Tue, Aug 08, 2017 at 03:09:00PM -0700, Vinay Belgaumkar wrote: > > > This is an RFC for adding documentation to IGT subtests. Each subtest can &g

[Intel-gfx] [PATCH i-g-t] tests/igt_command_line: Ignore subtest list for kms_ccs

Temporary workaround for "make check" to pass despite the issue with kms_ccs which do not list any subtests, even though it should. TO BE REVERTED by Daniel Stone Cc: Daniel Stone <dani...@collabora.com> Cc: Daniel Vetter <daniel.vet...@intel.com> Signed-off-by: Arkadiu

Re: [Intel-gfx] [PATCH i-g-t] tests/igt_command_line: Ignore subtest list for kms_ccs

On Thu, Aug 10, 2017 at 07:26:37PM +0300, Arkadiusz Hiler wrote: > Temporary workaround for "make check" to pass despite the issue with > kms_ccs which do not list any subtests, even though it should. > > TO BE REVERTED by Daniel Stone > > Cc: Daniel Stone <dani

Re: [Intel-gfx] [i-g-t] many testcases skiped

> > > -Original Message- > > From: Hiler, Arkadiusz > > Sent: Monday, July 17, 2017 4:30 PM > > To: Gu, HailinX <hailinx...@intel.com> > > Cc: intel-gfx@lists.freedesktop.org; Li, ZhijianX <zhijianx...@intel.com>; > > Li, > > Philip &l

Re: [Intel-gfx] [PATCH i-g-t 3/3] tests/gem_reset_stats: Enforce full chip reset mode before run

On Thu, Jul 06, 2017 at 10:29:41AM -0700, Michel Thierry wrote: > On 06/07/17 04:12, Arkadiusz Hiler wrote: > > On Tue, Jun 20, 2017 at 11:25:02AM -0700, Michel Thierry wrote: > > > Platforms with per-engine reset enabled (i915.reset=2) are unlikely to > > > perform

Re: [Intel-gfx] [i-g-t] many testcases skiped

On Mon, Jul 17, 2017 at 12:28:00PM +0800, Hailin Gu wrote: > Hi~ all, > > Does the test program have any hardware or version limitations? > > > I found that most testcase could run on a machine with intel(R) Core(TM) > i7-2600K CPU @ 3.40GHz. > > But can't run on Intel(R) Xeon(R) CPU E5-2699

Re: [Intel-gfx] [i-g-t] many testcases skiped

On Mon, Jul 17, 2017 at 11:14:03AM +0300, Arkadiusz Hiler wrote: > On Mon, Jul 17, 2017 at 12:28:00PM +0800, Hailin Gu wrote: > > Hi~ all, > > > > Does the test program have any hardware or version limitations? > > > > > > I found that most testcase could

[Intel-gfx] [PATCH i-g-t] lib/igt_debugfs: Update documentation and clenup

of strdup() in favor of an early allocation. Cc: Martin Peres <martin.pe...@intel.com> Cc: Liviu Dudau <liviu.du...@arm.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- lib/igt_debugfs.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/l

Re: [Intel-gfx] [PATCH i-g-t 1/7] igt: lib/igt_crc: Split out CRC functionality

On Thu, Jul 06, 2017 at 05:14:18PM +0100, Liviu Dudau wrote: > From: Brian Starkey > > Separate out the CRC code for better compartmentalisation. Should ease > the addition of more/different CRC sources in the future. > > Signed-off-by: Brian Starkey

[Intel-gfx] [PATCH i-g-t] igt: Add LOCAL defines for distro compatibility

distros catch up (+/- some epsilon). Cc: Petri Latvala <petri.latv...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- benchmarks/gem_exec_tracer.c | 10 -- tools/aubdump.c | 5 - 2

Re: [Intel-gfx] [PATCH i-g-t] igt: Add LOCAL defines for distro compatibility

On Tue, Jul 11, 2017 at 04:12:18PM +0100, Emil Velikov wrote: > Hi Arkadiusz, > > On 11 July 2017 at 12:48, Arkadiusz Hiler <arkadiusz.hi...@intel.com> wrote: > > Each Linux distro takes a different spin on providing kernel's uapi > > headers (especialy the *drm*.h

Re: [Intel-gfx] [PATCH i-g-t] tests/debugfs_test: Add a shorter timeout when reading sysfs entries

buf = igt_sysfs_get(path_fd, dirent->d_name); > + char *buf; > > + igt_set_timeout(5, "reading sysfs entry"); > + buf = igt_sysfs_get(path_fd, dirent->d_name); > +

Re: [Intel-gfx] [PATCH i-g-t v2] lib/igt_core: Handle glib errors correctly to avoid stderr spew

ot have group ?DUT? > > Fixes: ee31e0b5 ("Introduce common frame dumping configuration...") > > Cc: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> > Cc: Lyude <ly...@redhat.com> > Cc: Martin Peres <martin.pe...@linux.intel.com> > Signed-off-by:

Re: [Intel-gfx] [PATCH v3 06/18] drm/i915: Check for duplicated power well IDs

ff-by: Imre Deak <imre.d...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 07/18] drm/i915/bxt, glk: Give a proper name to the power well struct phy field

; > Signed-off-by: Imre Deak <imre.d...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] CONTRIBUTING: formalize review rules

: Ben Widawsky <b...@bwidawsk.net> > Acked-by: Tvrtko Ursulin <tvrtko.ursu...@intel.com> > Acked-by: Mika Kuoppala <mika.kuopp...@intel.com> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> Acked-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> With

Re: [Intel-gfx] [PATCH 09/18] drm/i915/gen9+: Remove redundant state check during power well toggling

On Thu, Jul 06, 2017 at 05:40:31PM +0300, Imre Deak wrote: > Atm we enable/disable a power well only if it wasn't already > enabled/disabled respectively. The only reason for this I can think of > is to save the extra MMIO writes. Since the HW state matches the power > well's usage counter most of

Re: [Intel-gfx] [PATCH 11/18] drm/i915/hsw, bdw: Split power well set to enable/disable helpers

nces between the enable and disable helpers. > > While at it also remove the redundant enable/disable debug messages, > the same info is printed already elsewhere. > > Signed-off-by: Imre Deak <imre.d...@intel.com> Reviewed-by: Arkadiusz

Re: [Intel-gfx] [PATCH v3 13/18] drm/i915/hsw, bdw: Add irq_pipe_mask, has_vga power well attributes

v3: > - Use u8 for pipe_mask in related helpers too for clarity. > > Signed-off-by: Imre Deak <imre.d...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 12/18] drm/i915/hsw+: Unify the hsw/bdw and gen9+ power well req/state macros

use the same code for GEN9+. > > Signed-off-by: Imre Deak <imre.d...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 09/18] drm/i915/gen9+: Remove redundant state check during power well toggling

On Fri, Jul 21, 2017 at 02:25:18PM +0300, Imre Deak wrote: > On Fri, Jul 21, 2017 at 02:14:33PM +0300, Arkadiusz Hiler wrote: > > On Thu, Jul 06, 2017 at 05:40:31PM +0300, Imre Deak wrote: > > > Atm we enable/disable a power well only if it wasn't already > > > en

Re: [Intel-gfx] [PATCH 10/18] drm/i915/hsw, bdw: Remove redundant state check during power well toggling

On Thu, Jul 06, 2017 at 05:40:32PM +0300, Imre Deak wrote: > Similarly to the GEN9 power well toggling, saving an occasional extra > MMIO write is not worth the code complexity, let's simplify things. > > Signed-off-by: Imre Deak <imre.d...@intel.com> Reviewed-by: Arkadiusz H

Re: [Intel-gfx] [PATCH 08/18] drm/i915/gen9+: Remove redundant power well state assert during enabling

let's remove it to simplify things. > > Signed-off-by: Imre Deak <imre.d...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 14/18] drm/i915/hsw, bdw: Wait for the power well disabled state

gt; also use the existing GEN9+ helper to wait for the enabled state. > > Signed-off-by: Imre Deak <imre.d...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https:/

Re: [Intel-gfx] [PATCH v2 15/18] drm/i915/hsw+: Add has_fuses power well attribute

ws us to use the HSW/BDW power well code for GEN9+ as well in a > follow-up patch. > > v2: > - Use an enum for power gates instead of raw numbers. (Ville) Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> ___ In

Re: [Intel-gfx] [PATCH 17/18] drm/i915: Move hsw_power_well_enable() next to the rest of HSW helpers

On Thu, Jul 06, 2017 at 05:40:39PM +0300, Imre Deak wrote: > Move the helper next to the rest of HSW specific code. > > Signed-off-by: Imre Deak <imre.d...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> ___ I

Re: [Intel-gfx] [PATCH 09/18] drm/i915/gen9+: Remove redundant state check during power well toggling

On Fri, Jul 21, 2017 at 02:32:55PM +0300, Arkadiusz Hiler wrote: > On Fri, Jul 21, 2017 at 02:25:18PM +0300, Imre Deak wrote: > > On Fri, Jul 21, 2017 at 02:14:33PM +0300, Arkadiusz Hiler wrote: > > > On Thu, Jul 06, 2017 at 05:40:31PM +0300, Imre Deak wrote: > > > >

Re: [Intel-gfx] [PATCH v2 16/18] drm/i915/gen9+: Unify the HSW/BDW and GEN9+ power well helpers

> setting the irq_pipe_mask, has_vga and has_fuses attributes as needed. > > v2: > - Rebased on v2 of patch 15. > > Signed-off-by: Imre Deak <imre.d...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> _

Re: [Intel-gfx] [PATCH 18/18] drm/i915: Gather all the power well->domain mappings to one place

On Thu, Jul 06, 2017 at 05:40:40PM +0300, Imre Deak wrote: > Shuffle the power well->domain mapping macros around so they are at one > place in old->new GEN order. > > Signed-off-by: Imre Deak <imre.d...@intel.com> Reviewed-by: Arkadiusz Hiler &l

Re: [Intel-gfx] [PATCH i-g-t] docs: Update documentation generation with missing entries

> > More files are added to the API reference, with a minimalistic > description block added to them when it was missing. > > Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> Reviewed-by: Arkadiusz Hiler <ark

Re: [Intel-gfx] [PATCH i-g-t] igt/debugfs_test: Skip dummy reads for crtc-n/crc/data

tc control data > > Signed-off-by: Abdiel Janulgue <abdiel.janul...@linux.intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> -- Cheers, Arek ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freed

[Intel-gfx] [PATCH i-g-t] configure.ac: Make AMDGPU depend on libdrm >= 2.4.76

leo@amd.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Reported-by: Martin Peres <martin.pe...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/co

Re: [Intel-gfx] [PATCH i-g-t 3/3] tests/gem_reset_stats: Enforce full chip reset mode before run

On Tue, Jun 20, 2017 at 11:25:02AM -0700, Michel Thierry wrote: > Platforms with per-engine reset enabled (i915.reset=2) are unlikely to > perform a full chip reset, keeping the reset_count unmodified. In order > to keep the expectations of this test, enforce that full GPU reset is > enabled

Re: [Intel-gfx] [PATCH i-g-t v2] tests/gem_mocs_settings: Fix LNCFCMOCS testing and extract the subtests

nto subtests. > We're only doing tests that involve "dirtying" the registers for the > render engine - since it's the only one that has those registers in its > context. > > v2: Do not skip all BSD engines, test non-default contexts on render > only, change names in CI ext

[Intel-gfx] [PATCH i-g-t] lib/ioctl_wrappers: Fix some comments

slaw Szwichtenberg <radoslaw.szwichtenb...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- lib/ioctl_wrappers.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c in

Re: [Intel-gfx] [PATCH i-g-t v2] lib/ioctl_wrappers: Fix function descriptions

slaw Szwichtenberg <radoslaw.szwichtenb...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> I'll push it in a moment, thanks! I followed up with a couple of similar fixes around the area, on top of your patch. Feel free to rev

Re: [Intel-gfx] [PATCH i-g-t] igt/debugfs_test: Skip dummy reads for sysfs pipe crc data

On Wed, Jun 28, 2017 at 01:33:16PM +0300, Abdiel Janulgue wrote: > Doing this tends to takes forever. > > Signed-off-by: Abdiel Janulgue > --- > tests/debugfs_test.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/debugfs_test.c

Re: [Intel-gfx] [RESEND i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU.

On Wed, Jun 28, 2017 at 03:17:00PM +0300, Arkadiusz Hiler wrote: > On Thu, Jun 22, 2017 at 09:28:35AM -0700, Anusha Srivatsa wrote: > > From: anushasr <anusha.sriva...@intel.com> > > > > Just following the spec and adding these extra IDs. > > > > v2:

Re: [Intel-gfx] [RESEND i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU.

On Thu, Jun 22, 2017 at 09:28:35AM -0700, Anusha Srivatsa wrote: > From: anushasr > > Just following the spec and adding these extra IDs. > > v2: update IDs following the kernel commit: > b056f8f3d6b900e8afd19f312719160346d263b4 (Chris) > > Cc: Rodrigo Vivi

Re: [Intel-gfx] [PATCH i-g-t 2/3] lib: Add reset-type helper in ioctl_wrappers

On Tue, Jun 20, 2017 at 11:25:01AM -0700, Michel Thierry wrote: > Soon we will have tests that are only for platforms with reset-engine > (GEN8+), so add a helper to query the has_gpu_reset via the getparam ioctl. > > Signed-off-by: Michel Thierry > --- >

Re: [Intel-gfx] [PATCH i-g-t] vc4: Test setting labels of BOs.

On Thu, Jun 22, 2017 at 01:51:29PM -0700, Eric Anholt wrote: > So far this test is basically making sure that we throw appropriate > errors, and don't oops the kernel with silly inputs. > > Signed-off-by: Eric Anholt <e...@anholt.net> Acked-by: Arkadiusz Hiler <arka

Re: [Intel-gfx] [PATCH] drm/i915: Update MOCS settings for gen 9

On Wed, Apr 26, 2017 at 06:00:41PM +0300, David Weinehall wrote: > Add a bunch of MOCS entries for gen 9 that were missing from intel_mocs. > Some of these are used by media-sdk; if these entries are missing > the default will instead be to do everything uncached. > > This patch improves

Re: [Intel-gfx] [PATCH i-g-t 1/2] Add support for subtest-specific documentation

with subtests much better than just having comments on top of internal functions (those does not have to map directly onto subtests). Bonus points for having it right above the igt_subtest_f() call and making it easily accessible from the command line as those are the two places developers a

Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Use drm_open_driver, don't need drm master

On Mon, Aug 07, 2017 at 03:23:29PM +0300, Petri Latvala wrote: > Signed-off-by: Petri Latvala <petri.latv...@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> -- Cheers, Arek ___ Intel-gfx mailing list Intel-gfx@lists.

Re: [Intel-gfx] [RFC i-g-t] tests/gem_exec_basic: Documentation for subtests

On Tue, Aug 08, 2017 at 03:09:00PM -0700, Vinay Belgaumkar wrote: > This is an RFC for adding documentation to IGT subtests. Each subtest can have > something similar to a WHAT - explaining what the subtest actually does, > and a WHY - which explains a use case, if applicable. Additionally, >

Re: [Intel-gfx] [PATCH] tests/kms_cursor_legacy: use 'enum pipe' type instead of 'int'

On Wed, Aug 02, 2017 at 07:54:17PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan <gustavo.pado...@collabora.com> > > Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> and pushed

Re: [Intel-gfx] [PATCH i-g-t] tests/core_auth: set rlimit

ve a consistent rlimit by adjusting it manually. > > v2: Use the default of 1024 from everywhere except ubuntu. > > Cc: Tomi Sarvela <tomi.p.sarv...@intel.com> > Cc: Chris Wilson <ch...@chris-wilson.co.uk> > Signed-off-by: Daniel Vetter <daniel.vet...@intel

Re: [Intel-gfx] [PATCH i-g-t 2/3] lib: Add ALSA library with dedicated helpers

On Thu, Aug 17, 2017 at 07:05:56PM +0300, Paul Kocialkowski wrote: > This introduces an ALSA library, with dedicated helpers for handling > playback and capture. It handles ALSA device identification and > configuration as well as a run loop with callback mechanisms for feeding > output data and

Re: [Intel-gfx] [PATCH igt] igt/gem_exec_params: Delete the circularly defined tests

Wilson <ch...@chris-wilson.co.uk> Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH igt 01/24] lib/debugfs: Make is_mountpoint() non-fatal

On Mon, Aug 14, 2017 at 09:18:25PM +0100, Chris Wilson wrote: > is_mountpoint() asserts rather than report the error. Normally this > isn't a problem, except for atypical selftests. > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> Reviewed-by: Arkadiusz Hiler <arka

Re: [Intel-gfx] [PATCH igt 21/24] lib/kms: Pass fd to igt_enable_connectors()

On Mon, Aug 14, 2017 at 09:18:45PM +0100, Chris Wilson wrote: > Pass the fd along to igt_enable_connectors() so that it actually dtrt > when there are multiple drm devices in the system. > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> Reviewed-by: Arkadiusz H

[Intel-gfx] [PATCH] drm/i915/gen9: Reintroduce WaEnableYV12BugFixInHalfSliceChicken7

ID#0764 Cc: Mika Kuoppala <mika.kuopp...@intel.com> Cc: Jeff McGee <jeff.mc...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- drivers/gpu/drm/i915/intel_engine_cs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_engine_

[Intel-gfx] [PATCH] chamelium: Fix build issues on Android

s included unconditionally. v2: keep lists of sources files in Makefile.sources (M. Wajdeczko) Cc: Michal Wajdeczko <michal.wajdec...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- lib/Makefile.am| 4 lib/Makefile.sources | 8 +++- lib/igt.h

[Intel-gfx] [PATCH i-g-t v2] tools/Android.mk: Add guc_logger and l3_parity to skip list

Those tools do not build on Android due to "Linux-only" dependencies. Let's blacklist them for now. v2: commit message fixup (P. Latvala) Cc: Petri Latvala <petri.latv...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- tools/Android.mk | 2

Re: [Intel-gfx] [PATCH i-g-t v2 00/13] Fix IGTs for Android\

ixed version. Thanks! -- Cheers, Arek > On Tue, May 16, 2017 at 03:24:49PM +0200, Arkadiusz Hiler wrote: > > IGTs are broken for Android since the introduction of dependency on procps. > > Over > > time other incompatibilities built up. > > > > I took th

[Intel-gfx] [PATCH i-g-t 02/13] Make conditions on HAVE_UDEV consistent

We have a lot of `#ifdef HAVE_UDEV` and ` #if HAVE_UDEV` all over the place, but ifdef and if have a slightly different semantics. Let make it consistent by using #ifdefs only. Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- lib/igt_aux.c | 2 +-

[Intel-gfx] [PATCH i-g-t 01/13] tests/drm_import_export: Include {i915_, }drm.h properly

Using `libdrm/` impairs compatibility with android build system and pkg-config manages -I for us on regular distros. Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- tests/drm_import_export.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

<    1   2   3   4   5   6   >